eventespresso / event-espresso-core

core/libraries/rest_api/Model_Data_Translator.php

Doc Comments +2 added lines, -1 removed lines

@@ -55,7 +55,7 @@ 
 	
 	/**
 	 * Prepares an array of field values FOR use in JSON/REST API
-	 * @param type $field_obj
+	 * @param \EE_Model_Field_Base $field_obj
 	 * @param type $original_value_maybe_array
 	 * @param string $request_version (eg 4.8.36)
 	 * @return array
@@ -97,6 +97,7 @@ 
 	* Prepares a field's value for display in the API
 	* @param \EE_Model_Field_Base $field_obj
 	* @param mixed $original_value
+	* @param string $requested_version
 	* @return mixed
 	*/
    public static function prepare_field_value_for_json( $field_obj, $original_value, $requested_version ) {

Spacing +76 added lines, -76 removed lines

@@ -1,8 +1,8 @@ 
 <?php
 namespace EventEspresso\core\libraries\rest_api;
 
-if ( ! defined( 'EVENT_ESPRESSO_VERSION' ) ) {
-	exit( 'No direct script access allowed' );
+if ( ! defined('EVENT_ESPRESSO_VERSION')) {
+	exit('No direct script access allowed');
 }
 
 
@@ -41,14 +41,14 @@ 
 	 * @param string  $requested_version
 	 * @return mixed
 	 */
-	public static function prepare_field_values_from_json( $field_obj, $original_value_maybe_array, $requested_version ) {
-		if( is_array( $original_value_maybe_array ) ) {
+	public static function prepare_field_values_from_json($field_obj, $original_value_maybe_array, $requested_version) {
+		if (is_array($original_value_maybe_array)) {
 			$new_value_maybe_array = array();
-			foreach( $original_value_maybe_array as $array_key => $array_item ) {
-				$new_value_maybe_array[ $array_key ] = Model_Data_Translator::prepare_field_value_from_json( $field_obj, $array_item, $requested_version );
+			foreach ($original_value_maybe_array as $array_key => $array_item) {
+				$new_value_maybe_array[$array_key] = Model_Data_Translator::prepare_field_value_from_json($field_obj, $array_item, $requested_version);
 			}
 		} else {
-			$new_value_maybe_array = Model_Data_Translator::prepare_field_value_from_json( $field_obj, $original_value_maybe_array, $requested_version );
+			$new_value_maybe_array = Model_Data_Translator::prepare_field_value_from_json($field_obj, $original_value_maybe_array, $requested_version);
 		}
 		return $new_value_maybe_array;
 	}
@@ -60,14 +60,14 @@ 
 	 * @param string $request_version (eg 4.8.36)
 	 * @return array
 	 */
-	public static function prepare_field_values_for_json( $field_obj, $original_value_maybe_array, $request_version ){
-		if( is_array( $original_value_maybe_array ) ) {
+	public static function prepare_field_values_for_json($field_obj, $original_value_maybe_array, $request_version) {
+		if (is_array($original_value_maybe_array)) {
 			$new_value_maybe_array = array();
-			foreach( $original_value_maybe_array as $array_key => $array_item ) {
-				$new_value_maybe_array[ $array_key ] = Model_Data_Translator::prepare_field_value_for_json( $field_obj, $array_item, $request_version );
+			foreach ($original_value_maybe_array as $array_key => $array_item) {
+				$new_value_maybe_array[$array_key] = Model_Data_Translator::prepare_field_value_for_json($field_obj, $array_item, $request_version);
 			}
 		} else {
-			$new_value_maybe_array = Model_Data_Translator::prepare_field_value_for_json( $field_obj, $original_value_maybe_array, $request_version );
+			$new_value_maybe_array = Model_Data_Translator::prepare_field_value_for_json($field_obj, $original_value_maybe_array, $request_version);
 		}
 		return $new_value_maybe_array;
 	}
@@ -80,13 +80,13 @@ 
 	 * @param string $requested_version
 	 * @return mixed
 	 */
-	public static function prepare_field_value_from_json( $field_obj, $original_value, $requested_version ) {
+	public static function prepare_field_value_from_json($field_obj, $original_value, $requested_version) {
 		$new_value = null;
-		if( $field_obj instanceof \EE_Infinite_Integer_Field
-			&& in_array( $original_value, array( null, '' ), true ) ) {
+		if ($field_obj instanceof \EE_Infinite_Integer_Field
+			&& in_array($original_value, array(null, ''), true)) {
 			$new_value = EE_INF;
-		} elseif( $field_obj instanceof \EE_Datetime_Field ) {
-			$new_value = rest_parse_date( $original_value );
+		} elseif ($field_obj instanceof \EE_Datetime_Field) {
+			$new_value = rest_parse_date($original_value);
 		} else {
 			$new_value = $original_value;
 		}
@@ -99,22 +99,22 @@ 
 	* @param mixed $original_value
 	* @return mixed
 	*/
-   public static function prepare_field_value_for_json( $field_obj, $original_value, $requested_version ) {
-		if( $original_value === EE_INF ) {
+   public static function prepare_field_value_for_json($field_obj, $original_value, $requested_version) {
+		if ($original_value === EE_INF) {
 			$new_value = Model_Data_Translator::ee_inf_in_rest;
-		} elseif( $field_obj instanceof \EE_Datetime_Field ) {
-			if( $original_value instanceof \DateTime ) {
-				$new_value = $original_value->format( 'Y-m-d H:i:s' );
-			} elseif( is_int( $original_value ) ) {
-				$new_value = date( 'Y-m-d H:i:s', $original_value ); 
+		} elseif ($field_obj instanceof \EE_Datetime_Field) {
+			if ($original_value instanceof \DateTime) {
+				$new_value = $original_value->format('Y-m-d H:i:s');
+			} elseif (is_int($original_value)) {
+				$new_value = date('Y-m-d H:i:s', $original_value); 
 			} else {
 				$new_value = $original_value;
 			}
-			$new_value = mysql_to_rfc3339( $new_value );
+			$new_value = mysql_to_rfc3339($new_value);
 		} else {
 			$new_value = $original_value;
 		}
-		return apply_filters( 'FHEE__EventEspresso\core\libraries\rest_api\Model_Data_Translator__prepare_field_for_rest_api',
+		return apply_filters('FHEE__EventEspresso\core\libraries\rest_api\Model_Data_Translator__prepare_field_for_rest_api',
 			$new_value,
 			$field_obj,
 			$original_value,
@@ -134,29 +134,29 @@ 
 	 * @return array
 	 * @throws \EE_Error
 	 */
-	public static function prepare_conditions_query_params_for_models( $inputted_query_params_of_this_type, \EEM_Base $model, $requested_version ) {
+	public static function prepare_conditions_query_params_for_models($inputted_query_params_of_this_type, \EEM_Base $model, $requested_version) {
 		$query_param_for_models = array();
-		foreach( $inputted_query_params_of_this_type as $query_param_key => $query_param_value ) {
+		foreach ($inputted_query_params_of_this_type as $query_param_key => $query_param_value) {
 			$field = Model_Data_Translator::deduce_field_from_query_param( 
-				Model_Data_Translator::remove_stars_and_anything_after_from_condition_query_param_key( $query_param_key ), 
+				Model_Data_Translator::remove_stars_and_anything_after_from_condition_query_param_key($query_param_key), 
 				$model
 			);
-			if( $field instanceof \EE_Model_Field_Base ) {
+			if ($field instanceof \EE_Model_Field_Base) {
 				//did they specify an operator?
-				if( is_array( $query_param_value ) ) {
-					$op = $query_param_value[ 0 ];
-					$translated_value = array( $op );
-					if( isset( $query_param_value[ 1 ] ) ) {
-						$value = $query_param_value[ 1 ];
-						$translated_value[1] = Model_Data_Translator::prepare_field_values_from_json( $field, $value, $requested_version );
+				if (is_array($query_param_value)) {
+					$op = $query_param_value[0];
+					$translated_value = array($op);
+					if (isset($query_param_value[1])) {
+						$value = $query_param_value[1];
+						$translated_value[1] = Model_Data_Translator::prepare_field_values_from_json($field, $value, $requested_version);
 					}
 				} else {
-					$translated_value  = Model_Data_Translator::prepare_field_value_from_json( $field, $query_param_value, $requested_version );
+					$translated_value = Model_Data_Translator::prepare_field_value_from_json($field, $query_param_value, $requested_version);
 				}
-				$query_param_for_models[ $query_param_key ] = $translated_value;
+				$query_param_for_models[$query_param_key] = $translated_value;
 			} else {
 				//so it's not for a field, assume it's a logic query param key
-				$query_param_for_models[ $query_param_key ] = Model_Data_Translator::prepare_conditions_query_params_for_models( $query_param_value, $model, $requested_version );
+				$query_param_for_models[$query_param_key] = Model_Data_Translator::prepare_conditions_query_params_for_models($query_param_value, $model, $requested_version);
 			}
 		}
 		return $query_param_for_models;
@@ -171,27 +171,27 @@ 
 	 * @param string $requested_version eg "4.8.36". If null is provided, defaults to the latest release of the EE4 REST API
 	 * @return array which can be passed into the EE4 REST API when querying a model resource
 	 */
-	public static function prepare_query_params_for_rest_api( $model_query_params, \EEM_Base $model,  $requested_version = null ) {
-		if( $requested_version === null ) {
-			$requested_version = \EED_Core_Rest_Api::latest_rest_api_version() ;
+	public static function prepare_query_params_for_rest_api($model_query_params, \EEM_Base $model, $requested_version = null) {
+		if ($requested_version === null) {
+			$requested_version = \EED_Core_Rest_Api::latest_rest_api_version();
 		}
 		$rest_query_params = $model_query_params;
-		if ( isset( $model_query_params[0] ) ) {
-			$rest_query_params[ 'where' ] = Model_Data_Translator::prepare_conditions_query_params_for_rest_api(
-				$model_query_params[ 0 ],
+		if (isset($model_query_params[0])) {
+			$rest_query_params['where'] = Model_Data_Translator::prepare_conditions_query_params_for_rest_api(
+				$model_query_params[0],
 				$model,
 				$requested_version
 			);
-			unset( $rest_query_params[0] );
+			unset($rest_query_params[0]);
 		}
-		if ( isset( $model_query_params[ 'having' ] ) ) {
-			$rest_query_params[ 'having' ] = Model_Data_Translator::prepare_conditions_query_params_for_rest_api(
-				$model_query_params[ 'having' ],
+		if (isset($model_query_params['having'])) {
+			$rest_query_params['having'] = Model_Data_Translator::prepare_conditions_query_params_for_rest_api(
+				$model_query_params['having'],
 				$model,
 				$requested_version
 			);
 		}
-		return apply_filters( 'FHEE__EventEspresso\core\libraries\rest_api\Model_Data_Translator__prepare_query_params_for_rest_api', $rest_query_params, $model_query_params, $model, $requested_version );
+		return apply_filters('FHEE__EventEspresso\core\libraries\rest_api\Model_Data_Translator__prepare_query_params_for_rest_api', $rest_query_params, $model_query_params, $model, $requested_version);
 	}
 	
 	/**
@@ -201,29 +201,29 @@ 
 	 * @param string $requested_version eg "4.8.36"
 	 * @return array ready for use in the rest api query params
 	 */
-	public static function prepare_conditions_query_params_for_rest_api( $inputted_query_params_of_this_type, \EEM_Base $model, $requested_version ) {
+	public static function prepare_conditions_query_params_for_rest_api($inputted_query_params_of_this_type, \EEM_Base $model, $requested_version) {
 		$query_param_for_models = array();
-		foreach( $inputted_query_params_of_this_type as $query_param_key => $query_param_value ) {
+		foreach ($inputted_query_params_of_this_type as $query_param_key => $query_param_value) {
 			$field = Model_Data_Translator::deduce_field_from_query_param( 
-				Model_Data_Translator::remove_stars_and_anything_after_from_condition_query_param_key( $query_param_key ), 
+				Model_Data_Translator::remove_stars_and_anything_after_from_condition_query_param_key($query_param_key), 
 				$model
 			);
-			if( $field instanceof \EE_Model_Field_Base ) {
+			if ($field instanceof \EE_Model_Field_Base) {
 				//did they specify an operator?
-				if( is_array( $query_param_value ) ) {
-					$op = $query_param_value[ 0 ];
-					$translated_value = array( $op );
-					if( isset( $query_param_value[ 1 ] ) ) {
-						$value = $query_param_value[ 1 ];
-						$translated_value[1] = Model_Data_Translator::prepare_field_values_for_json( $field, $value, $requested_version );
+				if (is_array($query_param_value)) {
+					$op = $query_param_value[0];
+					$translated_value = array($op);
+					if (isset($query_param_value[1])) {
+						$value = $query_param_value[1];
+						$translated_value[1] = Model_Data_Translator::prepare_field_values_for_json($field, $value, $requested_version);
 					}
 				} else {
-					$translated_value  = Model_Data_Translator::prepare_field_value_for_json( $field, $query_param_value, $requested_version );
+					$translated_value = Model_Data_Translator::prepare_field_value_for_json($field, $query_param_value, $requested_version);
 				}
-				$query_param_for_models[ $query_param_key ] = $translated_value;
+				$query_param_for_models[$query_param_key] = $translated_value;
 			} else {
 				//so it's not for a field, assume it's a logic query param key
-				$query_param_for_models[ $query_param_key ] = Model_Data_Translator::prepare_conditions_query_params_for_rest_api( $query_param_value, $model, $requested_version );
+				$query_param_for_models[$query_param_key] = Model_Data_Translator::prepare_conditions_query_params_for_rest_api($query_param_value, $model, $requested_version);
 			}
 		}
 		return $query_param_for_models;
@@ -235,11 +235,11 @@ 
 	 * @param $condition_query_param_key
 	 * @return string
 	 */
-	public static function remove_stars_and_anything_after_from_condition_query_param_key( $condition_query_param_key ) {
+	public static function remove_stars_and_anything_after_from_condition_query_param_key($condition_query_param_key) {
 		$pos_of_star = strpos($condition_query_param_key, '*');
-		if($pos_of_star === FALSE){
+		if ($pos_of_star === FALSE) {
 			return $condition_query_param_key;
-		}else{
+		} else {
 			$condition_query_param_sans_star = substr($condition_query_param_key, 0, $pos_of_star);
 			return $condition_query_param_sans_star;
 		}
@@ -255,26 +255,26 @@ 
 	 * @return \EE_Model_Field_Base
 	 * @throws \EE_Error
 	 */
-	public static function deduce_field_from_query_param($query_param_name, \EEM_Base $model){
+	public static function deduce_field_from_query_param($query_param_name, \EEM_Base $model) {
 		//ok, now proceed with deducing which part is the model's name, and which is the field's name
 		//which will help us find the database table and column
 
-		$query_param_parts = explode(".",$query_param_name);
-		if(empty($query_param_parts)){
-			throw new \EE_Error(sprintf(__("_extract_column_name is empty when trying to extract column and table name from %s",'event_espresso'),$query_param_name));
+		$query_param_parts = explode(".", $query_param_name);
+		if (empty($query_param_parts)) {
+			throw new \EE_Error(sprintf(__("_extract_column_name is empty when trying to extract column and table name from %s", 'event_espresso'), $query_param_name));
 		}
 		$number_of_parts = count($query_param_parts);
-		$last_query_param_part = $query_param_parts[ count($query_param_parts) - 1 ];
-		if($number_of_parts == 1){
+		$last_query_param_part = $query_param_parts[count($query_param_parts) - 1];
+		if ($number_of_parts == 1) {
 			$field_name = $last_query_param_part;
-		}else{// $number_of_parts >= 2
+		} else {// $number_of_parts >= 2
 			//the last part is the column name, and there are only 2parts. therefore...
 			$field_name = $last_query_param_part;
-			$model = \EE_Registry::instance()->load_model( $query_param_parts[ $number_of_parts - 2 ]);
+			$model = \EE_Registry::instance()->load_model($query_param_parts[$number_of_parts - 2]);
 		}
-		try{
+		try {
 			return $model->field_settings_for($field_name);
-		}catch(\EE_Error $e){
+		} catch (\EE_Error $e) {
 			return null;
 		}
 	}

core/services/progress_steps/ProgressStep.php

Spacing +28 added lines, -28 removed lines

@@ -3,8 +3,8 @@ 
 
 use EventEspresso\Core\Exceptions\InvalidDataTypeException;
 
-if ( ! defined( 'EVENT_ESPRESSO_VERSION' ) ) {
-	exit( 'No direct script access allowed' );
+if ( ! defined('EVENT_ESPRESSO_VERSION')) {
+	exit('No direct script access allowed');
 }
 
 
@@ -19,7 +19,7 @@ 
  * @author        Brent Christensen
  * @since         4.9.0
  */
-class ProgressStep implements ProgressStepInterface{
+class ProgressStep implements ProgressStepInterface {
 
 
 	/**
@@ -65,11 +65,11 @@ 
 	 * @param string $text
 	 * @throws InvalidDataTypeException
 	 */
-	public function __construct( $order, $id, $html_class, $text ) {
-		$this->setOrder( $order );
-		$this->setId( $id );
-		$this->setHtmlClass( $html_class );
-		$this->setText( $text );
+	public function __construct($order, $id, $html_class, $text) {
+		$this->setOrder($order);
+		$this->setId($id);
+		$this->setHtmlClass($html_class);
+		$this->setText($text);
 	}
 
 
@@ -86,8 +86,8 @@ 
 	/**
 	 * @param boolean $current
 	 */
-	public function setIsCurrent( $current = true ) {
-		$this->current = filter_var( $current, FILTER_VALIDATE_BOOLEAN );
+	public function setIsCurrent($current = true) {
+		$this->current = filter_var($current, FILTER_VALIDATE_BOOLEAN);
 	}
 
 
@@ -104,8 +104,8 @@ 
 	/**
 	 * @param boolean $completed
 	 */
-	public function setIsCompleted( $completed = true ) {
-		$this->completed = filter_var( $completed, FILTER_VALIDATE_BOOLEAN );
+	public function setIsCompleted($completed = true) {
+		$this->completed = filter_var($completed, FILTER_VALIDATE_BOOLEAN);
 	}
 
 
@@ -124,9 +124,9 @@ 
 	 * @param string $id
 	 * @throws InvalidDataTypeException
 	 */
-	protected function setId( $id = '' ) {
-		if ( ! is_string( $id ) ) {
-			throw new InvalidDataTypeException( '$id', $id, 'string' );
+	protected function setId($id = '') {
+		if ( ! is_string($id)) {
+			throw new InvalidDataTypeException('$id', $id, 'string');
 		}
 		$this->id = $id;
 	}
@@ -148,9 +148,9 @@ 
 	 * @param int $order
 	 * @throws InvalidDataTypeException
 	 */
-	protected function setOrder( $order = 0 ) {
-		if ( ! is_int( $order ) ) {
-			throw new InvalidDataTypeException( '$order', $order, 'integer' );
+	protected function setOrder($order = 0) {
+		if ( ! is_int($order)) {
+			throw new InvalidDataTypeException('$order', $order, 'integer');
 		}
 		$this->order = $order;
 	}
@@ -162,9 +162,9 @@ 
 	 */
 	public function htmlClass() {
 		$html_class = $this->html_class;
-		if ( $this->isCurrent() ) {
+		if ($this->isCurrent()) {
 			$html_class .= ' progress-step-active';
-		} else if ( $this->isCompleted() ) {
+		} else if ($this->isCompleted()) {
 			$html_class .= ' progress-step-completed';
 		}
 		return $html_class;
@@ -177,12 +177,12 @@ 
 	 * @param string $html_class
 	 * @throws InvalidDataTypeException
 	 */
-	protected function setHtmlClass( $html_class ) {
-		if ( ! is_string( $html_class ) ) {
-			throw new InvalidDataTypeException( '$html_class', $html_class, 'string' );
+	protected function setHtmlClass($html_class) {
+		if ( ! is_string($html_class)) {
+			throw new InvalidDataTypeException('$html_class', $html_class, 'string');
 		}
-		if ( strpos( $html_class, 'progress-step-' ) === false ) {
-			$html_class = 'progress-step-' . $html_class;
+		if (strpos($html_class, 'progress-step-') === false) {
+			$html_class = 'progress-step-'.$html_class;
 		}
 		$this->html_class = $html_class;
 	}
@@ -203,9 +203,9 @@ 
 	 * @param string $text
 	 * @throws InvalidDataTypeException
 	 */
-	protected function setText( $text ) {
-		if ( ! is_string( $text ) ) {
-			throw new InvalidDataTypeException( '$text', $text, 'string' );
+	protected function setText($text) {
+		if ( ! is_string($text)) {
+			throw new InvalidDataTypeException('$text', $text, 'string');
 		}
 		$this->text = $text;
 	}

core/services/progress_steps/ProgressStepManager.php

Spacing +41 added lines, -41 removed lines

@@ -10,8 +10,8 @@ 
 use EventEspresso\core\services\collections\CollectionInterface;
 use EventEspresso\core\services\progress_steps\display_strategies\ProgressStepsDisplayInterface;
 
-if ( ! defined( 'EVENT_ESPRESSO_VERSION' ) ) {
-	exit( 'No direct script access allowed' );
+if ( ! defined('EVENT_ESPRESSO_VERSION')) {
+	exit('No direct script access allowed');
 }
 
 
@@ -78,15 +78,15 @@ 
 		CollectionInterface $collection = null,
 		EE_Request $request = null
 	) {
-		$this->setDisplayStrategy( $display_strategy_name );
-		$this->setDefaultStep( $default_step );
-		$this->setFormStepUrlKey( $form_step_url_key );
-		if ( ! $collection instanceof CollectionInterface ) {
-			$collection = new Collection( '\EventEspresso\core\services\progress_steps\ProgressStepInterface' );
+		$this->setDisplayStrategy($display_strategy_name);
+		$this->setDefaultStep($default_step);
+		$this->setFormStepUrlKey($form_step_url_key);
+		if ( ! $collection instanceof CollectionInterface) {
+			$collection = new Collection('\EventEspresso\core\services\progress_steps\ProgressStepInterface');
 		}
 		$this->collection = $collection;
-		if ( ! $request instanceof EE_Request ) {
-			$request = \EE_Registry::instance()->load_core( 'Request' );
+		if ( ! $request instanceof EE_Request) {
+			$request = \EE_Registry::instance()->load_core('Request');
 		}
 		$this->request = $request;
 	}
@@ -98,28 +98,28 @@ 
 	 * @throws InvalidDataTypeException
 	 * @throws InvalidClassException
 	 */
-	protected function setDisplayStrategy( $display_strategy_name = 'number_bubbles' ) {
-		if ( ! is_string( $display_strategy_name ) ) {
-			throw new InvalidDataTypeException( '$display_strategy_name', $display_strategy_name, 'string' );
+	protected function setDisplayStrategy($display_strategy_name = 'number_bubbles') {
+		if ( ! is_string($display_strategy_name)) {
+			throw new InvalidDataTypeException('$display_strategy_name', $display_strategy_name, 'string');
 		}
 		// build up FQCN from incoming display strategy folder name
 		$display_strategy_class = 'EventEspresso\core\services\progress_steps\display_strategies\\';
-		$display_strategy_class .= $display_strategy_name . '\\';
-		$display_strategy_class .= str_replace( ' ', '', ucwords( str_replace( '_', ' ', $display_strategy_name ) ) );
+		$display_strategy_class .= $display_strategy_name.'\\';
+		$display_strategy_class .= str_replace(' ', '', ucwords(str_replace('_', ' ', $display_strategy_name)));
 		$display_strategy_class .= 'ProgressStepsDisplay';
 		$display_strategy_class = apply_filters(
 			'FHEE__ProgressStepManager__setDisplayStrategy__display_strategy_class',
 			$display_strategy_class
 		);
-		if ( ! class_exists( $display_strategy_class ) ) {
-			throw new InvalidClassException( $display_strategy_class );
+		if ( ! class_exists($display_strategy_class)) {
+			throw new InvalidClassException($display_strategy_class);
 		}
 		$display_strategy = new $display_strategy_class();
-		if ( ! $display_strategy instanceof ProgressStepsDisplayInterface ) {
+		if ( ! $display_strategy instanceof ProgressStepsDisplayInterface) {
 			throw new InvalidClassException(
 				$display_strategy_class,
 				sprintf(
-					__( 'The "%1$s" Class needs to be an implementation of the "%1$s" Interface.', 'event_espresso' ),
+					__('The "%1$s" Class needs to be an implementation of the "%1$s" Interface.', 'event_espresso'),
 					$display_strategy_class,
 					'\EventEspresso\core\services\progress_steps\display_strategies\ProgressStepsDisplayInterface'
 				)
@@ -134,9 +134,9 @@ 
 	 * @param string $default_step
 	 * @throws InvalidDataTypeException
 	 */
-	public function setDefaultStep( $default_step ) {
-		if ( ! is_string( $default_step ) ) {
-			throw new InvalidDataTypeException( '$default_step', $default_step, 'string' );
+	public function setDefaultStep($default_step) {
+		if ( ! is_string($default_step)) {
+			throw new InvalidDataTypeException('$default_step', $default_step, 'string');
 		}
 		$this->default_step = $default_step;
 	}
@@ -147,11 +147,11 @@ 
 	 * @param string $form_step_url_key
 	 * @throws InvalidDataTypeException
 	 */
-	public function setFormStepUrlKey( $form_step_url_key = 'ee-form-step' ) {
-		if ( ! is_string( $form_step_url_key ) ) {
-			throw new InvalidDataTypeException( '$form_step_key', $form_step_url_key, 'string' );
+	public function setFormStepUrlKey($form_step_url_key = 'ee-form-step') {
+		if ( ! is_string($form_step_url_key)) {
+			throw new InvalidDataTypeException('$form_step_key', $form_step_url_key, 'string');
 		}
-		$this->form_step_url_key = ! empty( $form_step_url_key ) ? $form_step_url_key : 'ee-form-step';
+		$this->form_step_url_key = ! empty($form_step_url_key) ? $form_step_url_key : 'ee-form-step';
 	}
 
 
@@ -160,26 +160,26 @@ 
 	 * @param string $step
 	 * @throws InvalidIdentifierException
 	 */
-	public function setCurrentStep( $step = '' ) {
+	public function setCurrentStep($step = '') {
 		// use incoming value if it's set, otherwise use request param if it's set, otherwise use default
-		$step = ! empty( $step )
+		$step = ! empty($step)
 			? $step
-			: $this->request->get( $this->form_step_url_key, $this->default_step );
+			: $this->request->get($this->form_step_url_key, $this->default_step);
 		// grab the step previously known as current, in case we need to revert
 		$current_current_step = $this->collection->current();
 		// verify that requested step exists
-		if ( ! $this->collection->has( $step ) ) {
-			throw new InvalidIdentifierException( $step, $this->default_step );
+		if ( ! $this->collection->has($step)) {
+			throw new InvalidIdentifierException($step, $this->default_step);
 		}
-		if ( $this->collection->setCurrent( $step ) ) {
+		if ($this->collection->setCurrent($step)) {
 			// if the old boss is the same as the new boss, then nothing changes
-			if ( $this->collection->current() !== $current_current_step ) {
-				$current_current_step->setIsCurrent( false );
+			if ($this->collection->current() !== $current_current_step) {
+				$current_current_step->setIsCurrent(false);
 			}
 			$this->collection->current()->setIsCurrent();
 		} else {
-			$this->collection->setCurrent( $current_current_step->id() );
-			$current_current_step->setIsCurrent( true );
+			$this->collection->setCurrent($current_current_step->id());
+			$current_current_step->setIsCurrent(true);
 		}
 	}
 
@@ -191,14 +191,14 @@ 
 	public function setPreviousStepsCompleted() {
 		$current_current_step = $this->collection->current();
 		$this->collection->rewind();
-		while ( $this->collection->valid() ) {
-			if ( $this->collection->current() === $current_current_step ) {
+		while ($this->collection->valid()) {
+			if ($this->collection->current() === $current_current_step) {
 				break;
 			}
 			$this->setCurrentStepCompleted();
 			$this->collection->next();
 		}
-		$this->collection->setCurrentUsingObject( $current_current_step );
+		$this->collection->setCurrentUsingObject($current_current_step);
 		return false;
 	}
 
@@ -239,7 +239,7 @@ 
 	public function displaySteps() {
 		return \EEH_Template::display_template(
 			$this->display_strategy->getTemplate(),
-			array( 'progress_steps' => $this->collection ),
+			array('progress_steps' => $this->collection),
 			true
 		);
 	}
@@ -250,8 +250,8 @@ 
 	 * @param bool $completed
 	 * @return \EventEspresso\core\services\progress_steps\ProgressStepInterface
 	 */
-	public function setCurrentStepCompleted( $completed = true ) {
-		return $this->collection->current()->setIsCompleted( $completed );
+	public function setCurrentStepCompleted($completed = true) {
+		return $this->collection->current()->setIsCompleted($completed);
 	}
 
 

Unused Use Statements +4 added lines, -4 removed lines

@@ -2,10 +2,10 @@
 namespace EventEspresso\core\services\progress_steps;
 
 use EE_Request;
-use  EventEspresso\core\exceptions\InvalidClassException;
-use  EventEspresso\core\exceptions\InvalidDataTypeException;
-use  EventEspresso\core\exceptions\InvalidIdentifierException;
-use  EventEspresso\core\exceptions\InvalidInterfaceException;
+use EventEspresso\core\exceptions\InvalidClassException;
+use EventEspresso\core\exceptions\InvalidDataTypeException;
+use EventEspresso\core\exceptions\InvalidIdentifierException;
+use EventEspresso\core\exceptions\InvalidInterfaceException;
 use EventEspresso\core\services\collections\Collection;
 use EventEspresso\core\services\collections\CollectionInterface;
 use EventEspresso\core\services\progress_steps\display_strategies\ProgressStepsDisplayInterface;

core/services/progress_steps/display_strategies/number_bubbles/NumberBubblesProgressStepsDisplay.php

Spacing +4 added lines, -4 removed lines

@@ -3,8 +3,8 @@ 
 
 use EventEspresso\core\services\progress_steps\display_strategies\ProgressStepsDisplayInterface;
 
-if ( ! defined( 'EVENT_ESPRESSO_VERSION' ) ) {
-	exit( 'No direct script access allowed' );
+if ( ! defined('EVENT_ESPRESSO_VERSION')) {
+	exit('No direct script access allowed');
 }
 
 
@@ -29,7 +29,7 @@ 
 		// core/services/progress_steps/display_strategies/number_bubbles/number_bubbles.css
 		wp_enqueue_style(
 			'ee_progress_steps_display_number_bubbles',
-			plugin_dir_url( __FILE__ ) . 'number_bubbles.css'
+			plugin_dir_url(__FILE__).'number_bubbles.css'
 		);
 	}
 
@@ -42,7 +42,7 @@ 
 	 */
 	public function getTemplate() {
 		// return plugin_dir_path( __FILE__ ) . 'number_bubbles.template.php';
-		return __DIR__ . DS .'number_bubbles.template.php';
+		return __DIR__.DS.'number_bubbles.template.php';
 	}
 
 }

core/services/commands/CommandInterface.php

Spacing +2 added lines, -2 removed lines

@@ -1,6 +1,6 @@
 <?php
-if ( ! defined( 'EVENT_ESPRESSO_VERSION' ) ) {
-	exit( 'No direct script access allowed' );
+if ( ! defined('EVENT_ESPRESSO_VERSION')) {
+	exit('No direct script access allowed');
 }
 /**
  * Class EE_Line_Item_Filter_Collection

core/services/commands/InvalidCommandHandlerException.php

Spacing +6 added lines, -6 removed lines

@@ -1,8 +1,8 @@ 
 <?php
 namespace EventEspresso\core\services\commands;
 
-if ( ! defined( 'EVENT_ESPRESSO_VERSION' ) ) {
-	exit( 'No direct script access allowed' );
+if ( ! defined('EVENT_ESPRESSO_VERSION')) {
+	exit('No direct script access allowed');
 }
 
 
@@ -25,14 +25,14 @@ 
 	 * @param  int        $code
 	 * @param  \Exception $previous
 	 */
-	public function __construct( $command_name, $message = '', $code = 0, \Exception $previous = null ) {
-		if ( empty( $message ) ) {
+	public function __construct($command_name, $message = '', $code = 0, \Exception $previous = null) {
+		if (empty($message)) {
 			$message = sprintf(
-				__( 'The supplied Command Handler "%1$s" does not have a valid name. It should be in the following format: "{CommandName}Handler" ', 'event_espresso' ),
+				__('The supplied Command Handler "%1$s" does not have a valid name. It should be in the following format: "{CommandName}Handler" ', 'event_espresso'),
 				$command_name
 			);
 		}
-		parent::__construct( $message, $code, $previous );
+		parent::__construct($message, $code, $previous);
 	}
 
 }

core/services/commands/CommandHandlerInterface.php

Spacing +3 added lines, -3 removed lines

@@ -1,8 +1,8 @@ 
 <?php
 namespace EventEspresso\core\services\commands;
 
-if ( ! defined( 'EVENT_ESPRESSO_VERSION' ) ) {
-	exit( 'No direct script access allowed' );
+if ( ! defined('EVENT_ESPRESSO_VERSION')) {
+	exit('No direct script access allowed');
 }
 
 
@@ -19,7 +19,7 @@ 
 	 * @param \EventEspresso\core\services\commands\CommandInterface $command
 	 * @return mixed
 	 */
-	public function handle( CommandInterface $command );
+	public function handle(CommandInterface $command);
 
 }
 // End of file CommandHandlerInterface.php

core/services/commands/CommandHandlerManagerInterface.php

Spacing +4 added lines, -4 removed lines

@@ -1,8 +1,8 @@ 
 <?php
 namespace EventEspresso\core\services\commands;
 
-if ( ! defined( 'EVENT_ESPRESSO_VERSION' ) ) {
-	exit( 'No direct script access allowed' );
+if ( ! defined('EVENT_ESPRESSO_VERSION')) {
+	exit('No direct script access allowed');
 }
 
 
@@ -19,14 +19,14 @@ 
 	 * @param \EventEspresso\core\services\commands\CommandHandlerInterface $command_handler
 	 * @return mixed
 	 */
-	public function addCommandHandler( CommandHandlerInterface $command_handler );
+	public function addCommandHandler(CommandHandlerInterface $command_handler);
 
 
 	/**
 	 * @param \EventEspresso\core\services\commands\CommandInterface $command
 	 * @return mixed
 	 */
-	public function getCommandHandler( CommandInterface $command );
+	public function getCommandHandler(CommandInterface $command);
 
 }
 // End of file CommandHandlerManagerInterface.php

core/EE_Dependency_Map.core.php

Doc Comments +1 added lines, -1 removed lines

@@ -26,7 +26,7 @@
 	 * just checks the field isn't blank
 	 *
 	 * @param $normalized_value
-	 * @return bool
+	 * @return boolean|null
 	 * @throws \EE_Validation_Error
 	 */
 	function validate($normalized_value) {

Spacing +44 added lines, -44 removed lines

@@ -1,6 +1,6 @@ 
 <?php
-if ( ! defined( 'EVENT_ESPRESSO_VERSION' ) ) {
-	exit( 'No direct script access allowed' );
+if ( ! defined('EVENT_ESPRESSO_VERSION')) {
+	exit('No direct script access allowed');
 }
 
 
@@ -75,11 +75,11 @@ 
 	 * @param  \EE_Request  $request
 	 * @param  \EE_Response $response
 	 */
-	protected function __construct( EE_Request $request, EE_Response $response ) {
+	protected function __construct(EE_Request $request, EE_Response $response) {
 		$this->_request = $request;
 		$this->_response = $response;
-		add_action( 'EE_Load_Espresso_Core__handle_request__initialize_core_loading', array( $this, 'initialize' ) );
-		do_action( 'EE_Dependency_Map____construct' );
+		add_action('EE_Load_Espresso_Core__handle_request__initialize_core_loading', array($this, 'initialize'));
+		do_action('EE_Dependency_Map____construct');
 	}
 
 
@@ -101,10 +101,10 @@ 
 	 * @param  \EE_Response $response
 	 * @return \EE_Dependency_Map instance
 	 */
-	public static function instance( EE_Request $request = null, EE_Response $response = null ) {
+	public static function instance(EE_Request $request = null, EE_Response $response = null) {
 		// check if class object is instantiated, and instantiated properly
-		if ( ! self::$_instance instanceof EE_Dependency_Map ) {
-			self::$_instance = new EE_Dependency_Map( $request, $response );
+		if ( ! self::$_instance instanceof EE_Dependency_Map) {
+			self::$_instance = new EE_Dependency_Map($request, $response);
 		}
 		return self::$_instance;
 	}
@@ -116,16 +116,16 @@ 
 	 * @param array  $dependencies
 	 * @return boolean
 	 */
-	public static function register_dependencies( $class, $dependencies ) {
-		if ( ! isset( self::$_instance->_dependency_map[ $class ] ) ) {
+	public static function register_dependencies($class, $dependencies) {
+		if ( ! isset(self::$_instance->_dependency_map[$class])) {
 			// we need to make sure that any aliases used when registering a dependency
 			// get resolved to the correct class name
-			foreach ( (array) $dependencies as $dependency => $load_source ) {
-				$alias = self::$_instance->get_alias( $dependency );
-				unset( $dependencies[ $dependency ] );
-				$dependencies[ $alias ] = $load_source;
+			foreach ((array) $dependencies as $dependency => $load_source) {
+				$alias = self::$_instance->get_alias($dependency);
+				unset($dependencies[$dependency]);
+				$dependencies[$alias] = $load_source;
 			}
-			self::$_instance->_dependency_map[ $class ] = (array) $dependencies;
+			self::$_instance->_dependency_map[$class] = (array) $dependencies;
 			return true;
 		}
 		return false;
@@ -139,19 +139,19 @@ 
 	 * @return bool
 	 * @throws \EE_Error
 	 */
-	public static function register_class_loader( $class_name, $loader = 'load_core' ) {
+	public static function register_class_loader($class_name, $loader = 'load_core') {
 		// check that loader method starts with "load_" and exists in EE_Registry
-		if ( strpos( $loader, 'load_' ) !== 0 || ! method_exists( 'EE_Registry', $loader ) ) {
+		if (strpos($loader, 'load_') !== 0 || ! method_exists('EE_Registry', $loader)) {
 			throw new EE_Error(
 				sprintf(
-					__( '"%1$s" is not a valid loader method on EE_Registry.', 'event_espresso' ),
+					__('"%1$s" is not a valid loader method on EE_Registry.', 'event_espresso'),
 					$loader
 				)
 			);
 		}
-		$class_name = self::$_instance->get_alias( $class_name );
-		if ( ! isset( self::$_instance->_class_loaders[ $class_name ] ) ) {
-			self::$_instance->_class_loaders[ $class_name ] = $loader;
+		$class_name = self::$_instance->get_alias($class_name);
+		if ( ! isset(self::$_instance->_class_loaders[$class_name])) {
+			self::$_instance->_class_loaders[$class_name] = $loader;
 			return true;
 		}
 		return false;
@@ -174,8 +174,8 @@ 
 	 * @param string $class_name
 	 * @return boolean
 	 */
-	public function has( $class_name = '' ) {
-		return isset( $this->_dependency_map[ $class_name ] ) ? true : false;
+	public function has($class_name = '') {
+		return isset($this->_dependency_map[$class_name]) ? true : false;
 	}
 
 
@@ -187,9 +187,9 @@ 
 	 * @param string $dependency
 	 * @return bool
 	 */
-	public function has_dependency_for_class( $class_name = '', $dependency = '' ) {
-		$dependency = $this->get_alias( $dependency );
-		return isset( $this->_dependency_map[ $class_name ], $this->_dependency_map[ $class_name ][ $dependency ] )
+	public function has_dependency_for_class($class_name = '', $dependency = '') {
+		$dependency = $this->get_alias($dependency);
+		return isset($this->_dependency_map[$class_name], $this->_dependency_map[$class_name][$dependency])
 			? true
 			: false;
 	}
@@ -203,10 +203,10 @@ 
 	 * @param string $dependency
 	 * @return int
 	 */
-	public function loading_strategy_for_class_dependency( $class_name = '', $dependency = '' ) {
-		$dependency = $this->get_alias( $dependency );
-		return $this->has_dependency_for_class( $class_name, $dependency )
-			? $this->_dependency_map[ $class_name ][ $dependency ]
+	public function loading_strategy_for_class_dependency($class_name = '', $dependency = '') {
+		$dependency = $this->get_alias($dependency);
+		return $this->has_dependency_for_class($class_name, $dependency)
+			? $this->_dependency_map[$class_name][$dependency]
 			: EE_Dependency_Map::not_registered;
 	}
 
@@ -216,9 +216,9 @@ 
 	 * @param string $class_name
 	 * @return string | Closure
 	 */
-	public function class_loader( $class_name ) {
-		$class_name = $this->get_alias( $class_name );
-		return isset( $this->_class_loaders[ $class_name ] ) ? $this->_class_loaders[ $class_name ] : '';
+	public function class_loader($class_name) {
+		$class_name = $this->get_alias($class_name);
+		return isset($this->_class_loaders[$class_name]) ? $this->_class_loaders[$class_name] : '';
 	}
 
 
@@ -239,8 +239,8 @@ 
 	 * @param string $alias
 	 * @return bool
 	 */
-	public function add_alias( $class_name, $alias ) {
-		$this->_aliases[ $class_name ] = $alias;
+	public function add_alias($class_name, $alias) {
+		$this->_aliases[$class_name] = $alias;
 	}
 
 
@@ -251,8 +251,8 @@ 
 	 * @param string $class_name
 	 * @return boolean
 	 */
-	public function has_alias( $class_name = '' ) {
-		return isset( $this->_aliases[ $class_name ] ) ? true : false;
+	public function has_alias($class_name = '') {
+		return isset($this->_aliases[$class_name]) ? true : false;
 	}
 
 
@@ -272,9 +272,9 @@ 
 	 * @param string $class_name
 	 * @return boolean
 	 */
-	public function get_alias( $class_name = '' ) {
-		return $this->has_alias( $class_name )
-			? $this->get_alias( $this->_aliases[ $class_name ] )
+	public function get_alias($class_name = '') {
+		return $this->has_alias($class_name)
+			? $this->get_alias($this->_aliases[$class_name])
 			: $class_name;
 	}
 
@@ -461,17 +461,17 @@ 
 			'EE_Messages_Data_Handler_Collection'  => 'load_lib',
 			'EE_Message_Template_Group_Collection' => 'load_lib',
 			'EE_Messages_Generator' => function() {
-				return EE_Registry::instance()->load_lib( 'Messages_Generator', array(), false, false );
+				return EE_Registry::instance()->load_lib('Messages_Generator', array(), false, false);
 			},
-			'EE_Messages_Template_Defaults' => function( $arguments = array() ) {
-				return EE_Registry::instance()->load_lib( 'Messages_Template_Defaults', $arguments, false, false );
+			'EE_Messages_Template_Defaults' => function($arguments = array()) {
+				return EE_Registry::instance()->load_lib('Messages_Template_Defaults', $arguments, false, false);
 			},
 			//load_model
 			'EEM_Message_Template_Group'           => 'load_model',
 			'EEM_Message_Template'                 => 'load_model',
 			//load_helper
 			'EEH_Parse_Shortcodes'                 => function() {
-				if ( EE_Registry::instance()->load_helper( 'Parse_Shortcodes' ) ) {
+				if (EE_Registry::instance()->load_helper('Parse_Shortcodes')) {
 					return new EEH_Parse_Shortcodes();
 				}
 				return null;