Checkout - Code Metrics - Inspection of "Daily Inspection: Merge branch 'master' into BUG-1..." - eventespresso/event-espresso-core - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Branch — BUG-10412-mcrypt-deprecated (d1c48b)

unknown

created 2017-05-19 21:00 UTC

Checkout A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	38
Duplicated Lines	0 %

Coupling/Cohesion

Components	0
Dependencies	1

Importance

Changes

Metric	Value
dl	0
loc	38
rs	10
c	0
b	0
f	0
wmc	4
lcom	0
cbo	1

4 Methods

Rating	Name	Size	Complexity
A	fillOutFirstNameFieldForAttendee()	4	1
A	fillOutLastNameFieldForAttendee()	4	1
A	fillOutEmailFieldForAttendee()	4	1
A	goToNextRegistrationStep()	4	1

<?php

namespace EventEspresso\Codeception\helpers;

use Page\Checkout as CheckoutPage;


/**
 * Trait Checkout
 * Helper actions for the checkout process (SPCO).
 *
 * @package EventEspresso\Codeception\helpers
 */
trait Checkout
{
    /**
     * @param     $value
     * @param int $attendee_number
     */
    public function fillOutFirstNameFieldForAttendee($value, $attendee_number = 1)
    {
        $this->actor()->fillField(CheckoutPage::firstNameFieldSelectorForAttendeeNumber($attendee_number), $value);
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
    }

    /**
     * @param     $value
     * @param int $attendee_number
     */
    public function fillOutLastNameFieldForAttendee($value, $attendee_number = 1)
    {
        $this->actor()->fillField(CheckoutPage::lastNameFieldSelectorForAttendeeNumber($attendee_number), $value);
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
    }

    /**
     * @param     $value
     * @param int $attendee_number
     */
    public function fillOutEmailFieldForAttendee($value, $attendee_number = 1)
    {
        $this->actor()->fillField(CheckoutPage::emailFieldSelectorForAttendeeNumber($attendee_number), $value);
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
    }


    /**
     * Clicks the next registration step button.
     */
    public function goToNextRegistrationStep()
    {
        $this->actor()->click(CheckoutPage::NEXT_STEP_BUTTON_SELECTOR);
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
    }
}

1			<?php
2
3			namespace EventEspresso\Codeception\helpers;
4
5			use Page\Checkout as CheckoutPage;
6
7
8			/**
9			* Trait Checkout
10			* Helper actions for the checkout process (SPCO).
11			*
12			* @package EventEspresso\Codeception\helpers
13			*/
14			trait Checkout
15			{
16			/**
17			* @param $value
18			* @param int $attendee_number
19			*/
20			public function fillOutFirstNameFieldForAttendee($value, $attendee_number = 1)
21			{
22			$this->actor()->fillField(CheckoutPage::firstNameFieldSelectorForAttendeeNumber($attendee_number), $value);
			0 ignored issues – show Bug introduced 2017-05-19 23:04 UTC by Report Bug Copy Issue Report It seems like `actor()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
23			}
24
25			/**
26			* @param $value
27			* @param int $attendee_number
28			*/
29			public function fillOutLastNameFieldForAttendee($value, $attendee_number = 1)
30			{
31			$this->actor()->fillField(CheckoutPage::lastNameFieldSelectorForAttendeeNumber($attendee_number), $value);
			0 ignored issues – show Bug introduced 2017-05-19 23:04 UTC by Report Bug Copy Issue Report It seems like `actor()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
32			}
33
34			/**
35			* @param $value
36			* @param int $attendee_number
37			*/
38			public function fillOutEmailFieldForAttendee($value, $attendee_number = 1)
39			{
40			$this->actor()->fillField(CheckoutPage::emailFieldSelectorForAttendeeNumber($attendee_number), $value);
			0 ignored issues – show Bug introduced 2017-05-19 23:04 UTC by Report Bug Copy Issue Report It seems like `actor()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
41			}
42
43
44			/**
45			* Clicks the next registration step button.
46			*/
47			public function goToNextRegistrationStep()
48			{
49			$this->actor()->click(CheckoutPage::NEXT_STEP_BUTTON_SELECTOR);
			0 ignored issues – show Bug introduced 2017-05-19 23:04 UTC by Report Bug Copy Issue Report It seems like `actor()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
50			}
51			}

eventespresso / event-espresso-core

Branch — BUG-10412-mcrypt-deprecated (d1c48b)

Checkout A

Complexity

Size/Duplication

Coupling/Cohesion

Importance

4 Methods

Duplication Side-by-Side

Filter issues like