eventespresso / event-espresso-core

core/data_migration_scripts/4_1_0_stages/EE_DMS_4_1_0_prices.dmsstage.php

Indentation +429 added lines, -429 removed lines

@@ -108,448 +108,448 @@
 class EE_DMS_4_1_0_prices extends EE_Data_Migration_Script_Stage_Table
 {
 
-    const price_type_base = 1;
+	const price_type_base = 1;
 
-    const price_type_member_discount = 3;
+	const price_type_member_discount = 3;
 
-    const price_type_percent_surcharge = 4;
+	const price_type_percent_surcharge = 4;
 
-    const price_type_flat_surcharge = 5;
+	const price_type_flat_surcharge = 5;
 
-    private string $_new_price_table;
+	private string $_new_price_table;
 
-    private string $_new_ticket_table;
+	private string $_new_ticket_table;
 
-    private string $_new_ticket_price_table;
+	private string $_new_ticket_price_table;
 
-    private string $_new_datetime_ticket_table;
+	private string $_new_datetime_ticket_table;
 
-    /**
-     * A count of all the different tickets created, used for setting the new ones' TKT_Order
-     *
-     * @var int
-     */
-    private int $_ticket_count = 0;
+	/**
+	 * A count of all the different tickets created, used for setting the new ones' TKT_Order
+	 *
+	 * @var int
+	 */
+	private int $_ticket_count = 0;
 
-    private array $price_data_types = [
-        '%d',// PRT_ID
-        '%f',// PRT_amount
-        '%s',// PRC_name
-        '%d',// PRC_is_default
-        '%d',// PRC_overrides
-        '%d',// PRC_order
-        '%d',// PRC_deleted
-        '%d',// PRC_parent
-    ];
+	private array $price_data_types = [
+		'%d',// PRT_ID
+		'%f',// PRT_amount
+		'%s',// PRC_name
+		'%d',// PRC_is_default
+		'%d',// PRC_overrides
+		'%d',// PRC_order
+		'%d',// PRC_deleted
+		'%d',// PRC_parent
+	];
 
 
-    public function __construct()
-    {
-        global $wpdb;
-        $this->_pretty_name               = esc_html__("Prices", "event_espresso");
-        $this->_old_table                 = $wpdb->prefix . "events_prices";
-        $this->select_expression          = 'p.*, e.event_status';
-        $this->_extra_where_sql           = ' AS p
+	public function __construct()
+	{
+		global $wpdb;
+		$this->_pretty_name               = esc_html__("Prices", "event_espresso");
+		$this->_old_table                 = $wpdb->prefix . "events_prices";
+		$this->select_expression          = 'p.*, e.event_status';
+		$this->_extra_where_sql           = ' AS p
             INNER JOIN ' . $wpdb->prefix . 'events_detail AS e ON p.event_id=e.id
             WHERE e.event_status!="D"';
-        $this->_new_price_table           = $wpdb->prefix . "esp_price";
-        $this->_new_ticket_table          = $wpdb->prefix . "esp_ticket";
-        $this->_new_ticket_price_table    = $wpdb->prefix . "esp_ticket_price";
-        $this->_new_datetime_ticket_table = $wpdb->prefix . "esp_datetime_ticket";
-        parent::__construct();
-    }
-
-
-    /**
-     * @throws EE_Error
-     */
-    protected function _migrate_old_row($old_row)
-    {
-        // create the base price
-        $new_price_id = $this->_insert_new_price($old_row);
-        // create the member discount if there is any
-        // commented-out because we may actually NOT be supporting this in 4.1
-        //      if($old_row['event_cost'] != $old_row['member_price']){
-        //          $member_price_discount_id = $this->_insert_new_member_price($old_row);
-        //      }else{
-        //          $member_price_discount_id = 0;
-        //      }
-        // create the surcharge if there is any
-        if (floatval($old_row['surcharge']) >= 0.01) {
-            $surcharge_price_id = $this->_insert_new_surcharge_price($old_row);
-            $this->get_migration_script()->set_mapping(
-                $this->_old_table, $old_row['id'], $this->_new_price_table, [$new_price_id, $surcharge_price_id]
-            );
-        } else {
-            $surcharge_price_id = 0;
-            $this->get_migration_script()->set_mapping(
-                $this->_old_table, $old_row['id'], $this->_new_price_table, [$new_price_id]
-            );
-        }
-        // associate the ticket to all datetimes for event (ie, this ONE ticket grants access to ALL datetimes, not just one of the attendee's choice.
-        // if the latter were the case, then we'd create a separate ticket for each datetime and have their
-        // association be one-to-one)
-        // create ticket
-        //      $ticket_id = $this->_insert_new_ticket($old_row);
-        //      if($ticket_id){
-        //          $this->get_migration_script()->set_mapping($this->_old_table, $old_row['id'], $this->_new_ticket_table, $ticket_id);
-        //          //associate to the prices
-        //          $this->_insert_ticket_price_relation($ticket_id, $new_price_id);
-        //          $this->_insert_ticket_price_relation($ticket_id, $surcharge_price_id);
-        //          //associate to datetimes for the event
-        //          foreach($this->_get_datetime_ids_for_old_event_id($old_row['event_id']) as $new_datetime_id){
-        //              $this->_insert_datetime_ticket_relation($new_datetime_id, $ticket_id);
-        //          }
-        //      }
-        // create a ticket for each old price -old datetime combo
-        $tickets_for_old_price = [];
-        foreach ($this->_get_datetime_ids_for_old_event_id($old_row['event_id']) as $new_datetime_id) {
-            $ticket_id               = $this->_insert_new_ticket($old_row);
-            $tickets_for_old_price[] = $ticket_id;
-            // associate to old prices
-            $this->_insert_ticket_price_relation($ticket_id, $new_price_id);
-            $this->_insert_ticket_price_relation($ticket_id, $surcharge_price_id);
-            $this->_insert_datetime_ticket_relation($new_datetime_id, $ticket_id);
-        }
-        $this->get_migration_script()->set_mapping(
-            $this->_old_table,
-            $old_row['id'],
-            $this->_new_ticket_table,
-            $tickets_for_old_price
-        );
-    }
-
-
-    /**
-     * Creates a 4.1 price base type
-     *
-     * @param array $old_price
-     * @return int
-     * @global wpdb $wpdb
-     */
-    private function _insert_new_price(array $old_price): int
-    {
-        global $wpdb;
-        $cols_n_values = [
-            'PRT_ID'         => self::price_type_base,
-            'PRC_amount'     => floatval($old_price['event_cost']),
-            'PRC_name'       => $old_price['price_type'],
-            'PRC_is_default' => false,
-            'PRC_overrides'  => false,
-            'PRC_order'      => 0,
-            'PRC_deleted'    => false,
-            'PRC_parent'     => null,
-
-        ];
-        $success       = $wpdb->insert($this->_new_price_table, $cols_n_values, $this->price_data_types);
-        if (! $success) {
-            $this->add_error(
-                $this->get_migration_script()->_create_error_message_for_db_insertion(
-                    $this->_old_table,
-                    $old_price,
-                    $this->_new_price_table,
-                    $cols_n_values,
-                    $this->price_data_types
-                )
-            );
-            return 0;
-        }
-        return $wpdb->insert_id;
-    }
-    /**
-     * Creates a 4.1 member price discount
-     *
-     * @param array $old_price
-     * @return int
-     * @global wpdb $wpdb
-     */
-    //  private function _insert_new_member_price($old_price){
-    //      $discount_amount = floatval($old_price['event_cost']) - floatval($old_price['member_price']);
-    //      global $wpdb;
-    //      $cols_n_values = array(
-    //          'PRT_ID'=>self::price_type_member_discount,
-    //          'PRC_amount'=>$discount_amount,
-    //          'PRC_name'=>$old_price['member_price_type'],
-    //          'PRC_is_default'=>false,
-    //          'PRC_overrides'=>false,
-    //          'PRC_order'=>10,
-    //          'PRC_deleted'=>false,
-    //          'PRC_parent'=>null
-    //
-    //      );
-    //      $data_types = array(
-    //          '%d',//PRT_ID
-    //          '%f',//PRT_amount
-    //          '%s',//PRC_name
-    //          '%d',//PRC_is_default
-    //          '%d',//PRC_overrides
-    //          '%d',//PRC_order
-    //          '%d',//PRC_deleted
-    //          '%d',//PRC_parent
-    //      );
-    //      $success = $wpdb->insert($this->_new_price_table,$cols_n_values,$data_types);
-    //      if ( ! $success){
-    //          $this->add_error($this->get_migration_script()->_create_error_message_for_db_insertion($this->_old_table, $old_price, $this->_new_price_table, $cols_n_values, $data_types));
-    //          return 0;
-    //      }
-    //      $new_id = $wpdb->insert_id;
-    //      return $new_id;
-    //  }
-    /**
-     * Creates a 4.1 member price discount
-     *
-     * @param array $old_price
-     * @return int
-     * @global wpdb $wpdb
-     */
-    private function _insert_new_surcharge_price(array $old_price): int
-    {
-        if ($old_price['surcharge_type'] == 'flat_rate') {
-            $price_type = self::price_type_flat_surcharge;
-        } else {
-            $price_type = self::price_type_percent_surcharge;
-        }
-        global $wpdb;
-        $cols_n_values = [
-            'PRT_ID'         => $price_type,
-            'PRC_amount'     => floatval($old_price['surcharge']),
-            'PRC_name'       => esc_html__("Surcharge", "event_espresso"),
-            'PRC_is_default' => false,
-            'PRC_overrides'  => false,
-            'PRC_order'      => 20,
-            'PRC_deleted'    => false,
-            'PRC_parent'     => null,
-
-        ];
-        $success       = $wpdb->insert($this->_new_price_table, $cols_n_values, $this->price_data_types);
-        if (! $success) {
-            $this->add_error(
-                $this->get_migration_script()->_create_error_message_for_db_insertion(
-                    $this->_old_table,
-                    $old_price,
-                    $this->_new_price_table,
-                    $cols_n_values,
-                    $this->price_data_types
-                )
-            );
-            return 0;
-        }
-        return $wpdb->insert_id;
-    }
-
-
-    /**
-     * Inserts a 4.1 ticket based off the 3.1 price, and the price IDs we've already made from the 3.1 price
-     *
-     * @param array $old_price_row array where keys are columns
-     * @return int new ticket id
-     */
-    private function _insert_new_ticket(array $old_price_row): int
-    {
-        global $wpdb;
-        $event_row = $this->_get_event_row($old_price_row['event_id']);
-        if ($old_price_row['surcharge_type'] == 'flat_rate') {
-            $final_ticket_price = floatval($old_price_row['event_cost']) + floatval($old_price_row['surcharge']);
-        } else {// percent surcharge
-            $final_ticket_price =
-                floatval($old_price_row['event_cost']) * (1 + floatval($old_price_row['surcharge']) / 100);
-        }
-        $start_date     =
-            $event_row['registration_start'] .
-            " " .
-            $this->get_migration_script()->convertTimeFromAMPM($event_row['registration_startT']);
-        $start_date_utc = $this->get_migration_script()->convert_date_string_to_utc(
-            $this,
-            $old_price_row,
-            $start_date,
-            $event_row['timezone_string']
-        );
-        $end_date       =
-            $event_row['registration_end'] .
-            " " .
-            $this->get_migration_script()->convertTimeFromAMPM($event_row['registration_endT']);
-        $end_date_utc   = $this->get_migration_script()->convert_date_string_to_utc(
-            $this,
-            $old_price_row,
-            $end_date,
-            $event_row['timezone_string']
-        );
-        $cols_n_values  = [
-            'TTM_ID'          => 0,
-            'TKT_name'        => $old_price_row['price_type'],
-            'TKT_description' => '',
-            'TKT_start_date'  => $start_date_utc,
-            'TKT_end_date'    => $end_date_utc,
-            'TKT_min'         => 0,
-            'TKT_max'         => -1,
-            'TKT_price'       => $final_ticket_price,
-            'TKT_sold'        => 0,
-            // note: this will get calculated as we actually add registrations during the migration
-            'TKT_qty'         => -1,
-            'TKT_uses'        => 1,
-            'TKT_taxable'     => false,
-            // so by default, old prices are NOT taxable. This way they don't suddenly have a sudden spike in prices
-            'TKT_is_default'  => false,
-            'TKT_order'       => $this->_get_ticket_count(),
-            'TKT_row'         => 0,
-            // doesn't matter because UI reset this on first save anyways
-            'TKT_deleted'     => false,
-            'TKT_parent'      => 0,
-
-        ];
-        $data_types     = [
-            '%d',// TTM_ID
-            '%s',// TKT_name
-            '%s',// TKT_description
-            '%s',// TKT_start_date
-            '%s',// TKT_end_date
-            '%d',// TKT_min
-            '%d',// TKT_max
-            '%f',// TKT_price
-            '%d',// TKT_sold
-            '%d',// TKT_qty
-            '%d',// TKT_uses
-            '%d',// TKT_taxable
-            '%d',// TKT_is_default
-            '%d',// TKT_order
-            '%d',// TKT_row
-            '%d',// TKT_deleted
-            '%d',// TKT_parent
-        ];
-        $success        = $wpdb->insert($this->_new_ticket_table, $cols_n_values, $data_types);
-        if (! $success) {
-            $this->add_error(
-                $this->get_migration_script()->_create_error_message_for_db_insertion(
-                    $this->_old_table,
-                    $old_price_row,
-                    $this->_new_ticket_table,
-                    $cols_n_values,
-                    $data_types
-                )
-            );
-            return 0;
-        }
-        return $wpdb->insert_id;
-    }
-
-
-    /**
-     * Adds a join between a ticket and a price
-     *
-     * @param int   $new_ticket_id
-     * @param int   $new_price_id
-     * @return void
-     * @global wpdb $wpdb
-     */
-    private function _insert_ticket_price_relation(int $new_ticket_id, int $new_price_id): void
-    {
-        global $wpdb;
-        $cols_n_values = [
-            'TKT_ID' => $new_ticket_id,
-            'PRC_ID' => $new_price_id,
-        ];
-        $data_types    = [
-            '%d',// TKT_ID
-            '%d',// PRC_ID
-        ];
-        $success       = $wpdb->insert($this->_new_ticket_price_table, $cols_n_values, $data_types);
-        if (! $success) {
-            $this->add_error(
-                $this->get_migration_script()->_create_error_message_for_db_insertion(
-                    $this->_old_table,
-                    ['ticket id' => $new_ticket_id, 'price id' => $new_price_id],
-                    $this->_new_ticket_price_table,
-                    $cols_n_values,
-                    $data_types
-                )
-            );
-        }
-    }
-
-
-    /**
-     * Adds a join between a ticket and a datetime
-     *
-     * @param int   $new_datetime_id
-     * @param int   $new_ticket_id
-     * @return void
-     * @global wpdb $wpdb
-     */
-    private function _insert_datetime_ticket_relation(int $new_datetime_id, int $new_ticket_id)
-    {
-        global $wpdb;
-        $cols_n_values = [
-            'TKT_ID' => $new_ticket_id,
-            'DTT_ID' => $new_datetime_id,
-        ];
-        $data_types    = [
-            '%d',// TKT_ID
-            '%d',// DTT_ID
-        ];
-        $success       = $wpdb->insert($this->_new_datetime_ticket_table, $cols_n_values, $data_types);
-        if (! $success) {
-            $this->add_error(
-                $this->get_migration_script()->_create_error_message_for_db_insertion(
-                    $this->_old_table,
-                    ['ticket id' => $new_ticket_id, 'datetime id' => $new_datetime_id],
-                    $this->_new_datetime_ticket_table,
-                    $cols_n_values,
-                    $data_types
-                )
-            );
-        }
-    }
-
-
-    /**
-     * Simply gets the 3.1 event row data
-     *
-     * @param int   $event_id
-     * @return array
-     * @global wpdb $wpdb
-     */
-    private function _get_event_row(int $event_id): array
-    {
-        global $wpdb;
-        $old_event_table = $wpdb->prefix . "events_detail";
-        return $wpdb->get_row($wpdb->prepare("SELECT * FROM $old_event_table WHERE id=%d", $event_id), ARRAY_A);
-    }
-
-
-    /**
-     * Gets a higher ticket count than last time it was called (and is persisted between HTTP requests).
-     * Yes we COULD run a query joining events->datetimes->ticket_datetimes->tickets, but this should work fine too
-     *
-     * @return int
-     */
-    private function _get_ticket_count(): int
-    {
-        return $this->_ticket_count++;
-    }
-
-
-    /**
-     * Using the 3.1 event id, gets the 4.1 datetimes for it
-     *
-     * @param int $old_event_id
-     * @return array where values are datetime ids
-     * @throws EE_Error
-     */
-    private function _get_datetime_ids_for_old_event_id(int $old_event_id): array
-    {
-        global $wpdb;
-        $new_cpt_id = $this->get_migration_script()->get_mapping_new_pk(
-            $wpdb->prefix . "events_detail",
-            $old_event_id,
-            $wpdb->posts
-        );
-        return $wpdb->get_col(
-            $wpdb->prepare(
-                "SELECT DTT_ID FROM {$wpdb->prefix}esp_datetime WHERE EVT_ID=%d",
-                $new_cpt_id
-            )
-        );
-    }
+		$this->_new_price_table           = $wpdb->prefix . "esp_price";
+		$this->_new_ticket_table          = $wpdb->prefix . "esp_ticket";
+		$this->_new_ticket_price_table    = $wpdb->prefix . "esp_ticket_price";
+		$this->_new_datetime_ticket_table = $wpdb->prefix . "esp_datetime_ticket";
+		parent::__construct();
+	}
+
+
+	/**
+	 * @throws EE_Error
+	 */
+	protected function _migrate_old_row($old_row)
+	{
+		// create the base price
+		$new_price_id = $this->_insert_new_price($old_row);
+		// create the member discount if there is any
+		// commented-out because we may actually NOT be supporting this in 4.1
+		//      if($old_row['event_cost'] != $old_row['member_price']){
+		//          $member_price_discount_id = $this->_insert_new_member_price($old_row);
+		//      }else{
+		//          $member_price_discount_id = 0;
+		//      }
+		// create the surcharge if there is any
+		if (floatval($old_row['surcharge']) >= 0.01) {
+			$surcharge_price_id = $this->_insert_new_surcharge_price($old_row);
+			$this->get_migration_script()->set_mapping(
+				$this->_old_table, $old_row['id'], $this->_new_price_table, [$new_price_id, $surcharge_price_id]
+			);
+		} else {
+			$surcharge_price_id = 0;
+			$this->get_migration_script()->set_mapping(
+				$this->_old_table, $old_row['id'], $this->_new_price_table, [$new_price_id]
+			);
+		}
+		// associate the ticket to all datetimes for event (ie, this ONE ticket grants access to ALL datetimes, not just one of the attendee's choice.
+		// if the latter were the case, then we'd create a separate ticket for each datetime and have their
+		// association be one-to-one)
+		// create ticket
+		//      $ticket_id = $this->_insert_new_ticket($old_row);
+		//      if($ticket_id){
+		//          $this->get_migration_script()->set_mapping($this->_old_table, $old_row['id'], $this->_new_ticket_table, $ticket_id);
+		//          //associate to the prices
+		//          $this->_insert_ticket_price_relation($ticket_id, $new_price_id);
+		//          $this->_insert_ticket_price_relation($ticket_id, $surcharge_price_id);
+		//          //associate to datetimes for the event
+		//          foreach($this->_get_datetime_ids_for_old_event_id($old_row['event_id']) as $new_datetime_id){
+		//              $this->_insert_datetime_ticket_relation($new_datetime_id, $ticket_id);
+		//          }
+		//      }
+		// create a ticket for each old price -old datetime combo
+		$tickets_for_old_price = [];
+		foreach ($this->_get_datetime_ids_for_old_event_id($old_row['event_id']) as $new_datetime_id) {
+			$ticket_id               = $this->_insert_new_ticket($old_row);
+			$tickets_for_old_price[] = $ticket_id;
+			// associate to old prices
+			$this->_insert_ticket_price_relation($ticket_id, $new_price_id);
+			$this->_insert_ticket_price_relation($ticket_id, $surcharge_price_id);
+			$this->_insert_datetime_ticket_relation($new_datetime_id, $ticket_id);
+		}
+		$this->get_migration_script()->set_mapping(
+			$this->_old_table,
+			$old_row['id'],
+			$this->_new_ticket_table,
+			$tickets_for_old_price
+		);
+	}
+
+
+	/**
+	 * Creates a 4.1 price base type
+	 *
+	 * @param array $old_price
+	 * @return int
+	 * @global wpdb $wpdb
+	 */
+	private function _insert_new_price(array $old_price): int
+	{
+		global $wpdb;
+		$cols_n_values = [
+			'PRT_ID'         => self::price_type_base,
+			'PRC_amount'     => floatval($old_price['event_cost']),
+			'PRC_name'       => $old_price['price_type'],
+			'PRC_is_default' => false,
+			'PRC_overrides'  => false,
+			'PRC_order'      => 0,
+			'PRC_deleted'    => false,
+			'PRC_parent'     => null,
+
+		];
+		$success       = $wpdb->insert($this->_new_price_table, $cols_n_values, $this->price_data_types);
+		if (! $success) {
+			$this->add_error(
+				$this->get_migration_script()->_create_error_message_for_db_insertion(
+					$this->_old_table,
+					$old_price,
+					$this->_new_price_table,
+					$cols_n_values,
+					$this->price_data_types
+				)
+			);
+			return 0;
+		}
+		return $wpdb->insert_id;
+	}
+	/**
+	 * Creates a 4.1 member price discount
+	 *
+	 * @param array $old_price
+	 * @return int
+	 * @global wpdb $wpdb
+	 */
+	//  private function _insert_new_member_price($old_price){
+	//      $discount_amount = floatval($old_price['event_cost']) - floatval($old_price['member_price']);
+	//      global $wpdb;
+	//      $cols_n_values = array(
+	//          'PRT_ID'=>self::price_type_member_discount,
+	//          'PRC_amount'=>$discount_amount,
+	//          'PRC_name'=>$old_price['member_price_type'],
+	//          'PRC_is_default'=>false,
+	//          'PRC_overrides'=>false,
+	//          'PRC_order'=>10,
+	//          'PRC_deleted'=>false,
+	//          'PRC_parent'=>null
+	//
+	//      );
+	//      $data_types = array(
+	//          '%d',//PRT_ID
+	//          '%f',//PRT_amount
+	//          '%s',//PRC_name
+	//          '%d',//PRC_is_default
+	//          '%d',//PRC_overrides
+	//          '%d',//PRC_order
+	//          '%d',//PRC_deleted
+	//          '%d',//PRC_parent
+	//      );
+	//      $success = $wpdb->insert($this->_new_price_table,$cols_n_values,$data_types);
+	//      if ( ! $success){
+	//          $this->add_error($this->get_migration_script()->_create_error_message_for_db_insertion($this->_old_table, $old_price, $this->_new_price_table, $cols_n_values, $data_types));
+	//          return 0;
+	//      }
+	//      $new_id = $wpdb->insert_id;
+	//      return $new_id;
+	//  }
+	/**
+	 * Creates a 4.1 member price discount
+	 *
+	 * @param array $old_price
+	 * @return int
+	 * @global wpdb $wpdb
+	 */
+	private function _insert_new_surcharge_price(array $old_price): int
+	{
+		if ($old_price['surcharge_type'] == 'flat_rate') {
+			$price_type = self::price_type_flat_surcharge;
+		} else {
+			$price_type = self::price_type_percent_surcharge;
+		}
+		global $wpdb;
+		$cols_n_values = [
+			'PRT_ID'         => $price_type,
+			'PRC_amount'     => floatval($old_price['surcharge']),
+			'PRC_name'       => esc_html__("Surcharge", "event_espresso"),
+			'PRC_is_default' => false,
+			'PRC_overrides'  => false,
+			'PRC_order'      => 20,
+			'PRC_deleted'    => false,
+			'PRC_parent'     => null,
+
+		];
+		$success       = $wpdb->insert($this->_new_price_table, $cols_n_values, $this->price_data_types);
+		if (! $success) {
+			$this->add_error(
+				$this->get_migration_script()->_create_error_message_for_db_insertion(
+					$this->_old_table,
+					$old_price,
+					$this->_new_price_table,
+					$cols_n_values,
+					$this->price_data_types
+				)
+			);
+			return 0;
+		}
+		return $wpdb->insert_id;
+	}
+
+
+	/**
+	 * Inserts a 4.1 ticket based off the 3.1 price, and the price IDs we've already made from the 3.1 price
+	 *
+	 * @param array $old_price_row array where keys are columns
+	 * @return int new ticket id
+	 */
+	private function _insert_new_ticket(array $old_price_row): int
+	{
+		global $wpdb;
+		$event_row = $this->_get_event_row($old_price_row['event_id']);
+		if ($old_price_row['surcharge_type'] == 'flat_rate') {
+			$final_ticket_price = floatval($old_price_row['event_cost']) + floatval($old_price_row['surcharge']);
+		} else {// percent surcharge
+			$final_ticket_price =
+				floatval($old_price_row['event_cost']) * (1 + floatval($old_price_row['surcharge']) / 100);
+		}
+		$start_date     =
+			$event_row['registration_start'] .
+			" " .
+			$this->get_migration_script()->convertTimeFromAMPM($event_row['registration_startT']);
+		$start_date_utc = $this->get_migration_script()->convert_date_string_to_utc(
+			$this,
+			$old_price_row,
+			$start_date,
+			$event_row['timezone_string']
+		);
+		$end_date       =
+			$event_row['registration_end'] .
+			" " .
+			$this->get_migration_script()->convertTimeFromAMPM($event_row['registration_endT']);
+		$end_date_utc   = $this->get_migration_script()->convert_date_string_to_utc(
+			$this,
+			$old_price_row,
+			$end_date,
+			$event_row['timezone_string']
+		);
+		$cols_n_values  = [
+			'TTM_ID'          => 0,
+			'TKT_name'        => $old_price_row['price_type'],
+			'TKT_description' => '',
+			'TKT_start_date'  => $start_date_utc,
+			'TKT_end_date'    => $end_date_utc,
+			'TKT_min'         => 0,
+			'TKT_max'         => -1,
+			'TKT_price'       => $final_ticket_price,
+			'TKT_sold'        => 0,
+			// note: this will get calculated as we actually add registrations during the migration
+			'TKT_qty'         => -1,
+			'TKT_uses'        => 1,
+			'TKT_taxable'     => false,
+			// so by default, old prices are NOT taxable. This way they don't suddenly have a sudden spike in prices
+			'TKT_is_default'  => false,
+			'TKT_order'       => $this->_get_ticket_count(),
+			'TKT_row'         => 0,
+			// doesn't matter because UI reset this on first save anyways
+			'TKT_deleted'     => false,
+			'TKT_parent'      => 0,
+
+		];
+		$data_types     = [
+			'%d',// TTM_ID
+			'%s',// TKT_name
+			'%s',// TKT_description
+			'%s',// TKT_start_date
+			'%s',// TKT_end_date
+			'%d',// TKT_min
+			'%d',// TKT_max
+			'%f',// TKT_price
+			'%d',// TKT_sold
+			'%d',// TKT_qty
+			'%d',// TKT_uses
+			'%d',// TKT_taxable
+			'%d',// TKT_is_default
+			'%d',// TKT_order
+			'%d',// TKT_row
+			'%d',// TKT_deleted
+			'%d',// TKT_parent
+		];
+		$success        = $wpdb->insert($this->_new_ticket_table, $cols_n_values, $data_types);
+		if (! $success) {
+			$this->add_error(
+				$this->get_migration_script()->_create_error_message_for_db_insertion(
+					$this->_old_table,
+					$old_price_row,
+					$this->_new_ticket_table,
+					$cols_n_values,
+					$data_types
+				)
+			);
+			return 0;
+		}
+		return $wpdb->insert_id;
+	}
+
+
+	/**
+	 * Adds a join between a ticket and a price
+	 *
+	 * @param int   $new_ticket_id
+	 * @param int   $new_price_id
+	 * @return void
+	 * @global wpdb $wpdb
+	 */
+	private function _insert_ticket_price_relation(int $new_ticket_id, int $new_price_id): void
+	{
+		global $wpdb;
+		$cols_n_values = [
+			'TKT_ID' => $new_ticket_id,
+			'PRC_ID' => $new_price_id,
+		];
+		$data_types    = [
+			'%d',// TKT_ID
+			'%d',// PRC_ID
+		];
+		$success       = $wpdb->insert($this->_new_ticket_price_table, $cols_n_values, $data_types);
+		if (! $success) {
+			$this->add_error(
+				$this->get_migration_script()->_create_error_message_for_db_insertion(
+					$this->_old_table,
+					['ticket id' => $new_ticket_id, 'price id' => $new_price_id],
+					$this->_new_ticket_price_table,
+					$cols_n_values,
+					$data_types
+				)
+			);
+		}
+	}
+
+
+	/**
+	 * Adds a join between a ticket and a datetime
+	 *
+	 * @param int   $new_datetime_id
+	 * @param int   $new_ticket_id
+	 * @return void
+	 * @global wpdb $wpdb
+	 */
+	private function _insert_datetime_ticket_relation(int $new_datetime_id, int $new_ticket_id)
+	{
+		global $wpdb;
+		$cols_n_values = [
+			'TKT_ID' => $new_ticket_id,
+			'DTT_ID' => $new_datetime_id,
+		];
+		$data_types    = [
+			'%d',// TKT_ID
+			'%d',// DTT_ID
+		];
+		$success       = $wpdb->insert($this->_new_datetime_ticket_table, $cols_n_values, $data_types);
+		if (! $success) {
+			$this->add_error(
+				$this->get_migration_script()->_create_error_message_for_db_insertion(
+					$this->_old_table,
+					['ticket id' => $new_ticket_id, 'datetime id' => $new_datetime_id],
+					$this->_new_datetime_ticket_table,
+					$cols_n_values,
+					$data_types
+				)
+			);
+		}
+	}
+
+
+	/**
+	 * Simply gets the 3.1 event row data
+	 *
+	 * @param int   $event_id
+	 * @return array
+	 * @global wpdb $wpdb
+	 */
+	private function _get_event_row(int $event_id): array
+	{
+		global $wpdb;
+		$old_event_table = $wpdb->prefix . "events_detail";
+		return $wpdb->get_row($wpdb->prepare("SELECT * FROM $old_event_table WHERE id=%d", $event_id), ARRAY_A);
+	}
+
+
+	/**
+	 * Gets a higher ticket count than last time it was called (and is persisted between HTTP requests).
+	 * Yes we COULD run a query joining events->datetimes->ticket_datetimes->tickets, but this should work fine too
+	 *
+	 * @return int
+	 */
+	private function _get_ticket_count(): int
+	{
+		return $this->_ticket_count++;
+	}
+
+
+	/**
+	 * Using the 3.1 event id, gets the 4.1 datetimes for it
+	 *
+	 * @param int $old_event_id
+	 * @return array where values are datetime ids
+	 * @throws EE_Error
+	 */
+	private function _get_datetime_ids_for_old_event_id(int $old_event_id): array
+	{
+		global $wpdb;
+		$new_cpt_id = $this->get_migration_script()->get_mapping_new_pk(
+			$wpdb->prefix . "events_detail",
+			$old_event_id,
+			$wpdb->posts
+		);
+		return $wpdb->get_col(
+			$wpdb->prepare(
+				"SELECT DTT_ID FROM {$wpdb->prefix}esp_datetime WHERE EVT_ID=%d",
+				$new_cpt_id
+			)
+		);
+	}
 }
 // @todo: tell users that in 3.1 the limit was on registration PER event,in 4.1 it's limit PER TICKET... SO, if they sell 2 different types of tickets
 //

Spacing +58 added lines, -58 removed lines

@@ -132,14 +132,14 @@ 
     private int $_ticket_count = 0;
 
     private array $price_data_types = [
-        '%d',// PRT_ID
-        '%f',// PRT_amount
-        '%s',// PRC_name
-        '%d',// PRC_is_default
-        '%d',// PRC_overrides
-        '%d',// PRC_order
-        '%d',// PRC_deleted
-        '%d',// PRC_parent
+        '%d', // PRT_ID
+        '%f', // PRT_amount
+        '%s', // PRC_name
+        '%d', // PRC_is_default
+        '%d', // PRC_overrides
+        '%d', // PRC_order
+        '%d', // PRC_deleted
+        '%d', // PRC_parent
     ];
 
 
@@ -147,15 +147,15 @@ 
     {
         global $wpdb;
         $this->_pretty_name               = esc_html__("Prices", "event_espresso");
-        $this->_old_table                 = $wpdb->prefix . "events_prices";
+        $this->_old_table                 = $wpdb->prefix."events_prices";
         $this->select_expression          = 'p.*, e.event_status';
         $this->_extra_where_sql           = ' AS p
-            INNER JOIN ' . $wpdb->prefix . 'events_detail AS e ON p.event_id=e.id
+            INNER JOIN ' . $wpdb->prefix.'events_detail AS e ON p.event_id=e.id
             WHERE e.event_status!="D"';
-        $this->_new_price_table           = $wpdb->prefix . "esp_price";
-        $this->_new_ticket_table          = $wpdb->prefix . "esp_ticket";
-        $this->_new_ticket_price_table    = $wpdb->prefix . "esp_ticket_price";
-        $this->_new_datetime_ticket_table = $wpdb->prefix . "esp_datetime_ticket";
+        $this->_new_price_table           = $wpdb->prefix."esp_price";
+        $this->_new_ticket_table          = $wpdb->prefix."esp_ticket";
+        $this->_new_ticket_price_table    = $wpdb->prefix."esp_ticket_price";
+        $this->_new_datetime_ticket_table = $wpdb->prefix."esp_datetime_ticket";
         parent::__construct();
     }
 
@@ -241,8 +241,8 @@ 
             'PRC_parent'     => null,
 
         ];
-        $success       = $wpdb->insert($this->_new_price_table, $cols_n_values, $this->price_data_types);
-        if (! $success) {
+        $success = $wpdb->insert($this->_new_price_table, $cols_n_values, $this->price_data_types);
+        if ( ! $success) {
             $this->add_error(
                 $this->get_migration_script()->_create_error_message_for_db_insertion(
                     $this->_old_table,
@@ -321,8 +321,8 @@ 
             'PRC_parent'     => null,
 
         ];
-        $success       = $wpdb->insert($this->_new_price_table, $cols_n_values, $this->price_data_types);
-        if (! $success) {
+        $success = $wpdb->insert($this->_new_price_table, $cols_n_values, $this->price_data_types);
+        if ( ! $success) {
             $this->add_error(
                 $this->get_migration_script()->_create_error_message_for_db_insertion(
                     $this->_old_table,
@@ -354,9 +354,9 @@ 
             $final_ticket_price =
                 floatval($old_price_row['event_cost']) * (1 + floatval($old_price_row['surcharge']) / 100);
         }
-        $start_date     =
-            $event_row['registration_start'] .
-            " " .
+        $start_date =
+            $event_row['registration_start'].
+            " ".
             $this->get_migration_script()->convertTimeFromAMPM($event_row['registration_startT']);
         $start_date_utc = $this->get_migration_script()->convert_date_string_to_utc(
             $this,
@@ -364,17 +364,17 @@ 
             $start_date,
             $event_row['timezone_string']
         );
-        $end_date       =
-            $event_row['registration_end'] .
-            " " .
+        $end_date =
+            $event_row['registration_end'].
+            " ".
             $this->get_migration_script()->convertTimeFromAMPM($event_row['registration_endT']);
-        $end_date_utc   = $this->get_migration_script()->convert_date_string_to_utc(
+        $end_date_utc = $this->get_migration_script()->convert_date_string_to_utc(
             $this,
             $old_price_row,
             $end_date,
             $event_row['timezone_string']
         );
-        $cols_n_values  = [
+        $cols_n_values = [
             'TTM_ID'          => 0,
             'TKT_name'        => $old_price_row['price_type'],
             'TKT_description' => '',
@@ -397,27 +397,27 @@ 
             'TKT_parent'      => 0,
 
         ];
-        $data_types     = [
-            '%d',// TTM_ID
-            '%s',// TKT_name
-            '%s',// TKT_description
-            '%s',// TKT_start_date
-            '%s',// TKT_end_date
-            '%d',// TKT_min
-            '%d',// TKT_max
-            '%f',// TKT_price
-            '%d',// TKT_sold
-            '%d',// TKT_qty
-            '%d',// TKT_uses
-            '%d',// TKT_taxable
-            '%d',// TKT_is_default
-            '%d',// TKT_order
-            '%d',// TKT_row
-            '%d',// TKT_deleted
-            '%d',// TKT_parent
+        $data_types = [
+            '%d', // TTM_ID
+            '%s', // TKT_name
+            '%s', // TKT_description
+            '%s', // TKT_start_date
+            '%s', // TKT_end_date
+            '%d', // TKT_min
+            '%d', // TKT_max
+            '%f', // TKT_price
+            '%d', // TKT_sold
+            '%d', // TKT_qty
+            '%d', // TKT_uses
+            '%d', // TKT_taxable
+            '%d', // TKT_is_default
+            '%d', // TKT_order
+            '%d', // TKT_row
+            '%d', // TKT_deleted
+            '%d', // TKT_parent
         ];
-        $success        = $wpdb->insert($this->_new_ticket_table, $cols_n_values, $data_types);
-        if (! $success) {
+        $success = $wpdb->insert($this->_new_ticket_table, $cols_n_values, $data_types);
+        if ( ! $success) {
             $this->add_error(
                 $this->get_migration_script()->_create_error_message_for_db_insertion(
                     $this->_old_table,
@@ -448,12 +448,12 @@ 
             'TKT_ID' => $new_ticket_id,
             'PRC_ID' => $new_price_id,
         ];
-        $data_types    = [
-            '%d',// TKT_ID
-            '%d',// PRC_ID
+        $data_types = [
+            '%d', // TKT_ID
+            '%d', // PRC_ID
         ];
-        $success       = $wpdb->insert($this->_new_ticket_price_table, $cols_n_values, $data_types);
-        if (! $success) {
+        $success = $wpdb->insert($this->_new_ticket_price_table, $cols_n_values, $data_types);
+        if ( ! $success) {
             $this->add_error(
                 $this->get_migration_script()->_create_error_message_for_db_insertion(
                     $this->_old_table,
@@ -482,12 +482,12 @@ 
             'TKT_ID' => $new_ticket_id,
             'DTT_ID' => $new_datetime_id,
         ];
-        $data_types    = [
-            '%d',// TKT_ID
-            '%d',// DTT_ID
+        $data_types = [
+            '%d', // TKT_ID
+            '%d', // DTT_ID
         ];
-        $success       = $wpdb->insert($this->_new_datetime_ticket_table, $cols_n_values, $data_types);
-        if (! $success) {
+        $success = $wpdb->insert($this->_new_datetime_ticket_table, $cols_n_values, $data_types);
+        if ( ! $success) {
             $this->add_error(
                 $this->get_migration_script()->_create_error_message_for_db_insertion(
                     $this->_old_table,
@@ -511,7 +511,7 @@ 
     private function _get_event_row(int $event_id): array
     {
         global $wpdb;
-        $old_event_table = $wpdb->prefix . "events_detail";
+        $old_event_table = $wpdb->prefix."events_detail";
         return $wpdb->get_row($wpdb->prepare("SELECT * FROM $old_event_table WHERE id=%d", $event_id), ARRAY_A);
     }
 
@@ -539,7 +539,7 @@ 
     {
         global $wpdb;
         $new_cpt_id = $this->get_migration_script()->get_mapping_new_pk(
-            $wpdb->prefix . "events_detail",
+            $wpdb->prefix."events_detail",
             $old_event_id,
             $wpdb->posts
         );

core/data_migration_scripts/EE_DMS_Core_4_3_0.dms.php

Indentation +206 added lines, -206 removed lines

@@ -10,11 +10,11 @@ 
 $stages            = glob(EE_CORE . 'data_migration_scripts/4_3_0_stages/*');
 $class_to_filepath = [];
 if (! empty($stages)) {
-    foreach ($stages as $filepath) {
-        $matches = [];
-        preg_match('~4_3_0_stages/(.*).dmsstage.php~', $filepath, $matches);
-        $class_to_filepath[ $matches[1] ] = $filepath;
-    }
+	foreach ($stages as $filepath) {
+		$matches = [];
+		preg_match('~4_3_0_stages/(.*).dmsstage.php~', $filepath, $matches);
+		$class_to_filepath[ $matches[1] ] = $filepath;
+	}
 }
 // give addons a chance to autoload their stages too
 $class_to_filepath = apply_filters('FHEE__EE_DMS_4_3_0__autoloaded_stages', $class_to_filepath);
@@ -31,63 +31,63 @@ 
 class EE_DMS_Core_4_3_0 extends EE_Data_Migration_Script_Base
 {
 
-    /**
-     * EE_DMS_Core_4_3_0 constructor.
-     *
-     * @param TableManager|null  $table_manager
-     * @param TableAnalysis|null $table_analysis
-     */
-    public function __construct(TableManager $table_manager = null, TableAnalysis $table_analysis = null)
-    {
-        $this->_pretty_name      = esc_html__("Data Update to Event Espresso 4.3.0", "event_espresso");
-        $this->_priority         = 10;
-        $this->_migration_stages = [
-            new EE_DMS_4_3_0_question_option_order(),
-            new EE_DMS_4_3_0_event_message_templates(),
-        ];
-        parent::__construct($table_manager, $table_analysis);
-    }
-
-
-    public function can_migrate_from_version($version_array)
-    {
-        $version_string = $version_array['Core'];
-        if (
-            version_compare($version_string, '4.3.0.decaf', '<') &&
-            version_compare($version_string, '4.2.0.decaf', '>=')
-        ) {
-            //          echo "$version_string can be migrated fro";
-            return true;
-        } elseif (! $version_string) {
-            //          echo "no version string provided: $version_string";
-            // no version string provided... this must be pre 4.2
-            return false;// changed mind. dont want people thinking they should migrate yet because they cant
-        } else {
-            //          echo "$version_string doesnt apply";
-            return false;
-        }
-    }
-
-
-    /**
-     * @throws EE_Error
-     * @throws ReflectionException
-     */
-    public function schema_changes_before_migration()
-    {
-        // relies on 4.1's EEH_Activation::create_table
-        require_once(EE_HELPERS . 'EEH_Activation.helper.php');
-
-        $table_name = 'esp_answer';
-        $sql        = "ANS_ID int(10) unsigned NOT NULL AUTO_INCREMENT,
+	/**
+	 * EE_DMS_Core_4_3_0 constructor.
+	 *
+	 * @param TableManager|null  $table_manager
+	 * @param TableAnalysis|null $table_analysis
+	 */
+	public function __construct(TableManager $table_manager = null, TableAnalysis $table_analysis = null)
+	{
+		$this->_pretty_name      = esc_html__("Data Update to Event Espresso 4.3.0", "event_espresso");
+		$this->_priority         = 10;
+		$this->_migration_stages = [
+			new EE_DMS_4_3_0_question_option_order(),
+			new EE_DMS_4_3_0_event_message_templates(),
+		];
+		parent::__construct($table_manager, $table_analysis);
+	}
+
+
+	public function can_migrate_from_version($version_array)
+	{
+		$version_string = $version_array['Core'];
+		if (
+			version_compare($version_string, '4.3.0.decaf', '<') &&
+			version_compare($version_string, '4.2.0.decaf', '>=')
+		) {
+			//          echo "$version_string can be migrated fro";
+			return true;
+		} elseif (! $version_string) {
+			//          echo "no version string provided: $version_string";
+			// no version string provided... this must be pre 4.2
+			return false;// changed mind. dont want people thinking they should migrate yet because they cant
+		} else {
+			//          echo "$version_string doesnt apply";
+			return false;
+		}
+	}
+
+
+	/**
+	 * @throws EE_Error
+	 * @throws ReflectionException
+	 */
+	public function schema_changes_before_migration()
+	{
+		// relies on 4.1's EEH_Activation::create_table
+		require_once(EE_HELPERS . 'EEH_Activation.helper.php');
+
+		$table_name = 'esp_answer';
+		$sql        = "ANS_ID int(10) unsigned NOT NULL AUTO_INCREMENT,
 					REG_ID int(10) unsigned NOT NULL,
 					QST_ID int(10) unsigned NOT NULL,
 					ANS_value text NOT NULL,
 					PRIMARY KEY  (ANS_ID)";
-        $this->_table_should_exist_previously($table_name, $sql);
+		$this->_table_should_exist_previously($table_name, $sql);
 
-        $table_name = 'esp_attendee_meta';
-        $sql        = "ATTM_ID int(10) unsigned NOT	NULL AUTO_INCREMENT,
+		$table_name = 'esp_attendee_meta';
+		$sql        = "ATTM_ID int(10) unsigned NOT	NULL AUTO_INCREMENT,
 						ATT_ID bigint(20) unsigned NOT NULL,
 						ATT_fname varchar(45) NOT NULL,
 						ATT_lname varchar(45) NOT	NULL,
@@ -103,10 +103,10 @@ 
 								KEY ATT_fname (ATT_fname),
 								KEY ATT_lname (ATT_lname),
 								KEY ATT_email (ATT_email(191))";
-        $this->_table_should_exist_previously($table_name, $sql, 'ENGINE=InnoDB');
+		$this->_table_should_exist_previously($table_name, $sql, 'ENGINE=InnoDB');
 
-        $table_name = 'esp_country';
-        $sql        = "CNT_ISO varchar(2) COLLATE utf8_bin NOT NULL,
+		$table_name = 'esp_country';
+		$sql        = "CNT_ISO varchar(2) COLLATE utf8_bin NOT NULL,
 					  CNT_ISO3 varchar(3) COLLATE utf8_bin NOT NULL,
 					  RGN_ID tinyint(3) unsigned DEFAULT NULL,
 					  CNT_name varchar(45) COLLATE utf8_bin NOT NULL,
@@ -122,10 +122,10 @@ 
 					  CNT_is_EU tinyint(1) DEFAULT '0',
 					  CNT_active tinyint(1) DEFAULT '0',
 					  PRIMARY KEY  (CNT_ISO)";
-        $this->_table_should_exist_previously($table_name, $sql);
+		$this->_table_should_exist_previously($table_name, $sql);
 
-        $table_name = 'esp_datetime';
-        $sql        = "DTT_ID int(10) unsigned NOT NULL AUTO_INCREMENT,
+		$table_name = 'esp_datetime';
+		$sql        = "DTT_ID int(10) unsigned NOT NULL AUTO_INCREMENT,
 				  EVT_ID bigint(20) unsigned NOT NULL,
 				  DTT_name varchar(255) NOT NULL DEFAULT '',
 				  DTT_description text NOT NULL,
@@ -140,10 +140,10 @@ 
 						PRIMARY KEY  (DTT_ID),
 						KEY EVT_ID (EVT_ID),
 						KEY DTT_is_primary (DTT_is_primary)";
-        $this->_table_should_exist_previously($table_name, $sql);
+		$this->_table_should_exist_previously($table_name, $sql);
 
-        $table_name = 'esp_event_meta';
-        $sql        = "
+		$table_name = 'esp_event_meta';
+		$sql        = "
 			EVTM_ID int(10) NOT NULL AUTO_INCREMENT,
 			EVT_ID bigint(20) unsigned NOT NULL,
 			EVT_display_desc tinyint(1) unsigned NOT NULL DEFAULT 1,
@@ -158,35 +158,35 @@ 
 			EVT_external_URL varchar(200) NULL,
 			EVT_donations tinyint(1) NULL,
 			PRIMARY KEY  (EVTM_ID)";
-        $this->_table_should_exist_previously($table_name, $sql);
+		$this->_table_should_exist_previously($table_name, $sql);
 
-        $table_name = 'esp_event_question_group';
-        $sql        = "EQG_ID int(10) unsigned NOT NULL AUTO_INCREMENT,
+		$table_name = 'esp_event_question_group';
+		$sql        = "EQG_ID int(10) unsigned NOT NULL AUTO_INCREMENT,
 					EVT_ID bigint(20) unsigned NOT NULL,
 					QSG_ID int(10) unsigned NOT NULL,
 					EQG_primary tinyint(1) unsigned NOT NULL DEFAULT 0,
 					PRIMARY KEY  (EQG_ID)";
-        $this->_table_should_exist_previously($table_name, $sql);
+		$this->_table_should_exist_previously($table_name, $sql);
 
-        $table_name = 'esp_event_venue';
-        $sql        = "EVV_ID int(11) NOT NULL AUTO_INCREMENT,
+		$table_name = 'esp_event_venue';
+		$sql        = "EVV_ID int(11) NOT NULL AUTO_INCREMENT,
 				EVT_ID bigint(20) unsigned NOT NULL,
 				VNU_ID bigint(20) unsigned NOT NULL,
 				EVV_primary tinyint(1) unsigned NOT NULL DEFAULT 0,
 				PRIMARY KEY  (EVV_ID)";
-        $this->_table_should_exist_previously($table_name, $sql);
+		$this->_table_should_exist_previously($table_name, $sql);
 
-        $table_name = 'esp_extra_meta';
-        $sql        = "EXM_ID int(11) NOT NULL AUTO_INCREMENT,
+		$table_name = 'esp_extra_meta';
+		$sql        = "EXM_ID int(11) NOT NULL AUTO_INCREMENT,
 				OBJ_ID int(11) DEFAULT NULL,
 				EXM_type varchar(45) DEFAULT NULL,
 				EXM_key varchar(45) DEFAULT NULL,
 				EXM_value text,
 				PRIMARY KEY  (EXM_ID)";
-        $this->_table_should_exist_previously($table_name, $sql);
+		$this->_table_should_exist_previously($table_name, $sql);
 
-        $table_name = 'esp_line_item';
-        $sql        = "LIN_ID int(11) NOT NULL AUTO_INCREMENT,
+		$table_name = 'esp_line_item';
+		$sql        = "LIN_ID int(11) NOT NULL AUTO_INCREMENT,
 				LIN_code varchar(245) NOT NULL DEFAULT '',
 				TXN_ID int(11) DEFAULT NULL,
 				LIN_name varchar(245) NOT NULL DEFAULT '',
@@ -202,21 +202,21 @@ 
 				OBJ_ID int(11) DEFAULT NULL,
 				OBJ_type varchar(45)DEFAULT NULL,
 				PRIMARY KEY  (LIN_ID)";
-        $this->_table_should_exist_previously($table_name, $sql);
+		$this->_table_should_exist_previously($table_name, $sql);
 
-        $table_name = 'esp_message_template';
-        $sql        = "MTP_ID int(10) unsigned NOT NULL AUTO_INCREMENT,
+		$table_name = 'esp_message_template';
+		$sql        = "MTP_ID int(10) unsigned NOT NULL AUTO_INCREMENT,
 					GRP_ID int(10) unsigned NOT NULL,
 					MTP_context varchar(50) NOT NULL,
 					MTP_template_field varchar(30) NOT NULL,
 					MTP_content text NOT NULL,
 					PRIMARY KEY  (MTP_ID),
 					KEY GRP_ID (GRP_ID)";
-        $this->_table_should_exist_previously($table_name, $sql);
-        $this->_get_table_manager()->dropIndex('esp_message_template_group', 'EVT_ID');
+		$this->_table_should_exist_previously($table_name, $sql);
+		$this->_get_table_manager()->dropIndex('esp_message_template_group', 'EVT_ID');
 
-        $table_name = 'esp_message_template_group';
-        $sql        = "GRP_ID int(10) unsigned NOT NULL AUTO_INCREMENT,
+		$table_name = 'esp_message_template_group';
+		$sql        = "GRP_ID int(10) unsigned NOT NULL AUTO_INCREMENT,
 					MTP_user_id int(10) NOT NULL DEFAULT '1',
 					MTP_name varchar(245) NOT NULL DEFAULT '',
 					MTP_description varchar(245) NOT NULL DEFAULT '',
@@ -228,19 +228,19 @@ 
 					MTP_is_active tinyint(1) NOT NULL DEFAULT '1',
 					PRIMARY KEY  (GRP_ID),
 					KEY MTP_user_id (MTP_user_id)";
-        $this->_table_should_exist_previously($table_name, $sql);
+		$this->_table_should_exist_previously($table_name, $sql);
 
-        $table_name = 'esp_event_message_template';
-        $sql        = "EMT_ID bigint(20) unsigned NOT NULL AUTO_INCREMENT,
+		$table_name = 'esp_event_message_template';
+		$sql        = "EMT_ID bigint(20) unsigned NOT NULL AUTO_INCREMENT,
 					EVT_ID bigint(20) unsigned NOT NULL DEFAULT 0,
 					GRP_ID int(10) unsigned NOT NULL DEFAULT 0,
 					PRIMARY KEY  (EMT_ID),
 					KEY EVT_ID (EVT_ID),
 					KEY GRP_ID (GRP_ID)";
-        $this->_table_is_new_in_this_version($table_name, $sql);
+		$this->_table_is_new_in_this_version($table_name, $sql);
 
-        $table_name = 'esp_payment';
-        $sql        = "PAY_ID int(10) unsigned NOT NULL AUTO_INCREMENT,
+		$table_name = 'esp_payment';
+		$sql        = "PAY_ID int(10) unsigned NOT NULL AUTO_INCREMENT,
 					TXN_ID int(10) unsigned DEFAULT NULL,
 					STS_ID varchar(3) COLLATE utf8_bin DEFAULT NULL,
 					PAY_timestamp datetime NOT NULL DEFAULT '0000-00-00 00:00:00',
@@ -256,10 +256,10 @@ 
 					PRIMARY KEY  (PAY_ID),
 					KEY TXN_ID (TXN_ID),
 					KEY PAY_timestamp (PAY_timestamp)";
-        $this->_table_should_exist_previously($table_name, $sql, 'ENGINE=InnoDB');
+		$this->_table_should_exist_previously($table_name, $sql, 'ENGINE=InnoDB');
 
-        $table_name = "esp_ticket";
-        $sql        = "TKT_ID int(10) unsigned NOT NULL AUTO_INCREMENT,
+		$table_name = "esp_ticket";
+		$sql        = "TKT_ID int(10) unsigned NOT NULL AUTO_INCREMENT,
 					  TTM_ID int(10) unsigned NOT NULL,
 					  TKT_name varchar(245) NOT NULL DEFAULT '',
 					  TKT_description text NOT NULL,
@@ -279,32 +279,32 @@ 
 					  TKT_parent int(10) unsigned DEFAULT '0',
 					  TKT_deleted tinyint(1) NOT NULL DEFAULT '0',
 					  PRIMARY KEY  (TKT_ID)";
-        $this->_table_should_exist_previously($table_name, $sql);
+		$this->_table_should_exist_previously($table_name, $sql);
 
-        $table_name = "esp_ticket_price";
-        $sql        = "TKP_ID int(10) unsigned NOT NULL AUTO_INCREMENT,
+		$table_name = "esp_ticket_price";
+		$sql        = "TKP_ID int(10) unsigned NOT NULL AUTO_INCREMENT,
 					  TKT_ID int(10) unsigned NOT NULL,
 					  PRC_ID int(10) unsigned NOT NULL,
 					  PRIMARY KEY  (TKP_ID)";
-        $this->_table_should_exist_previously($table_name, $sql);
+		$this->_table_should_exist_previously($table_name, $sql);
 
-        $table_name = "esp_datetime_ticket";
-        $sql        = "DTK_ID int(10) unsigned NOT NULL AUTO_INCREMENT,
+		$table_name = "esp_datetime_ticket";
+		$sql        = "DTK_ID int(10) unsigned NOT NULL AUTO_INCREMENT,
 					  DTT_ID int(10) unsigned NOT NULL,
 					  TKT_ID int(10) unsigned NOT NULL,
 					  PRIMARY KEY  (DTK_ID)";
-        $this->_table_should_exist_previously($table_name, $sql);
+		$this->_table_should_exist_previously($table_name, $sql);
 
-        $table_name = "esp_ticket_template";
-        $sql        = "TTM_ID int(10) unsigned NOT NULL AUTO_INCREMENT,
+		$table_name = "esp_ticket_template";
+		$sql        = "TTM_ID int(10) unsigned NOT NULL AUTO_INCREMENT,
 					  TTM_name varchar(45) NOT NULL,
 					  TTM_description text,
 					  TTM_file varchar(45),
 					  PRIMARY KEY  (TTM_ID)";
-        $this->_table_should_exist_previously($table_name, $sql);
+		$this->_table_should_exist_previously($table_name, $sql);
 
-        $table_name = "esp_price";
-        $sql        = "PRC_ID int(10) unsigned NOT NULL AUTO_INCREMENT,
+		$table_name = "esp_price";
+		$sql        = "PRC_ID int(10) unsigned NOT NULL AUTO_INCREMENT,
 					  PRT_ID tinyint(3) unsigned NOT NULL,
 					  PRC_amount decimal(10,3) NOT NULL DEFAULT '0.00',
 					  PRC_name varchar(245) NOT NULL,
@@ -315,10 +315,10 @@ 
 					  PRC_order tinyint(3) unsigned NOT NULL DEFAULT '0',
 					  PRC_parent int(10) unsigned DEFAULT 0,
 					  PRIMARY KEY  (PRC_ID)";
-        $this->_table_should_exist_previously($table_name, $sql);
+		$this->_table_should_exist_previously($table_name, $sql);
 
-        $table_name = "esp_price_type";
-        $sql        = "PRT_ID tinyint(3) unsigned NOT NULL AUTO_INCREMENT,
+		$table_name = "esp_price_type";
+		$sql        = "PRT_ID tinyint(3) unsigned NOT NULL AUTO_INCREMENT,
 				  PRT_name varchar(45) NOT NULL,
 				  PBT_ID tinyint(3) unsigned NOT NULL DEFAULT '1',
 				  PRT_is_percent tinyint(1) NOT NULL DEFAULT '0',
@@ -326,10 +326,10 @@ 
 				  PRT_deleted tinyint(1) NOT NULL DEFAULT '0',
 				  UNIQUE KEY PRT_name_UNIQUE (PRT_name),
 				  PRIMARY KEY  (PRT_ID)";
-        $this->_table_should_exist_previously($table_name, $sql);
+		$this->_table_should_exist_previously($table_name, $sql);
 
-        $table_name = 'esp_question';
-        $sql        = 'QST_ID int(10) unsigned NOT NULL AUTO_INCREMENT,
+		$table_name = 'esp_question';
+		$sql        = 'QST_ID int(10) unsigned NOT NULL AUTO_INCREMENT,
 					QST_display_text text NOT NULL,
 					QST_admin_label varchar(255) NOT NULL,
 					QST_system varchar(25) DEFAULT NULL,
@@ -341,11 +341,11 @@ 
 					QST_wp_user bigint(20) unsigned NULL,
 					QST_deleted tinyint(1) unsigned NOT NULL DEFAULT 0,
 					PRIMARY KEY  (QST_ID)';
-        $this->_table_should_exist_previously($table_name, $sql);
-        $this->_get_table_manager()->dropIndex('esp_question_group', 'QSG_identifier_UNIQUE');
+		$this->_table_should_exist_previously($table_name, $sql);
+		$this->_get_table_manager()->dropIndex('esp_question_group', 'QSG_identifier_UNIQUE');
 
-        $table_name = 'esp_question_group';
-        $sql        = 'QSG_ID int(10) unsigned NOT NULL AUTO_INCREMENT,
+		$table_name = 'esp_question_group';
+		$sql        = 'QSG_ID int(10) unsigned NOT NULL AUTO_INCREMENT,
 					QSG_name varchar(255) NOT NULL,
 					QSG_identifier varchar(100) NOT NULL,
 					QSG_desc text NULL,
@@ -356,28 +356,28 @@ 
 					QSG_deleted tinyint(1) unsigned NOT NULL DEFAULT 0,
 					PRIMARY KEY  (QSG_ID),
 					UNIQUE KEY QSG_identifier_UNIQUE (QSG_identifier ASC)';
-        $this->_table_should_exist_previously($table_name, $sql);
+		$this->_table_should_exist_previously($table_name, $sql);
 
-        $table_name = 'esp_question_group_question';
-        $sql        = "QGQ_ID int(10) unsigned NOT NULL AUTO_INCREMENT,
+		$table_name = 'esp_question_group_question';
+		$sql        = "QGQ_ID int(10) unsigned NOT NULL AUTO_INCREMENT,
 					QSG_ID int(10) unsigned NOT NULL,
 					QST_ID int(10) unsigned NOT NULL,
 					QGQ_order int(10) unsigned NOT NULL DEFAULT 0,
 					PRIMARY KEY  (QGQ_ID) ";
-        $this->_table_should_exist_previously($table_name, $sql);
+		$this->_table_should_exist_previously($table_name, $sql);
 
-        $table_name = 'esp_question_option';
-        $sql        = "QSO_ID int(10) unsigned NOT NULL AUTO_INCREMENT,
+		$table_name = 'esp_question_option';
+		$sql        = "QSO_ID int(10) unsigned NOT NULL AUTO_INCREMENT,
 					QSO_value varchar(255) NOT NULL,
 					QSO_desc text NOT NULL,
 					QST_ID int(10) unsigned NOT NULL,
 					QSO_order int(10) unsigned NOT NULL DEFAULT 0,
 					QSO_deleted tinyint(1) unsigned NOT NULL DEFAULT 0,
 					PRIMARY KEY  (QSO_ID)";
-        $this->_table_should_exist_previously($table_name, $sql);
+		$this->_table_should_exist_previously($table_name, $sql);
 
-        $table_name = 'esp_registration';
-        $sql        = "REG_ID int(10) unsigned NOT NULL AUTO_INCREMENT,
+		$table_name = 'esp_registration';
+		$sql        = "REG_ID int(10) unsigned NOT NULL AUTO_INCREMENT,
 					  EVT_ID bigint(20) unsigned NOT NULL,
 					  ATT_ID bigint(20) unsigned NOT NULL,
 					  TXN_ID int(10) unsigned NOT NULL,
@@ -400,28 +400,28 @@ 
 					  KEY STS_ID (STS_ID),
 					  KEY REG_url_link (REG_url_link),
 					  KEY REG_code (REG_code)";
-        $this->_table_should_exist_previously($table_name, $sql, 'ENGINE=InnoDB');
+		$this->_table_should_exist_previously($table_name, $sql, 'ENGINE=InnoDB');
 
-        $table_name = 'esp_checkin';
-        $sql        = "CHK_ID int(10) unsigned NOT NULL AUTO_INCREMENT,
+		$table_name = 'esp_checkin';
+		$sql        = "CHK_ID int(10) unsigned NOT NULL AUTO_INCREMENT,
 					REG_ID int(10) unsigned NOT NULL,
 					DTT_ID int(10) unsigned NOT NULL,
 					CHK_in tinyint(1) unsigned NOT NULL DEFAULT 1,
 					CHK_timestamp datetime NOT NULL DEFAULT '0000-00-00 00:00:00',
 					PRIMARY KEY  (CHK_ID)";
-        $this->_table_should_exist_previously($table_name, $sql);
+		$this->_table_should_exist_previously($table_name, $sql);
 
-        $table_name = 'esp_state';
-        $sql        = "STA_ID smallint(5) unsigned NOT NULL AUTO_INCREMENT,
+		$table_name = 'esp_state';
+		$sql        = "STA_ID smallint(5) unsigned NOT NULL AUTO_INCREMENT,
 					  CNT_ISO varchar(2) COLLATE utf8_bin NOT NULL,
 					  STA_abbrev varchar(6) COLLATE utf8_bin NOT NULL,
 					  STA_name varchar(100) COLLATE utf8_bin NOT NULL,
 					  STA_active tinyint(1) DEFAULT '1',
 					  PRIMARY KEY  (STA_ID)";
-        $this->_table_should_exist_previously($table_name, $sql);
+		$this->_table_should_exist_previously($table_name, $sql);
 
-        $table_name = 'esp_status';
-        $sql        = "STS_ID varchar(3) COLLATE utf8_bin NOT NULL,
+		$table_name = 'esp_status';
+		$sql        = "STS_ID varchar(3) COLLATE utf8_bin NOT NULL,
 					  STS_code varchar(45) COLLATE utf8_bin NOT NULL,
 					  STS_type set('event','registration','transaction','payment','email') COLLATE utf8_bin NOT NULL,
 					  STS_can_edit tinyint(1) NOT NULL DEFAULT 0,
@@ -429,10 +429,10 @@ 
 					  STS_open tinyint(1) NOT NULL DEFAULT 1,
 					  UNIQUE KEY STS_ID_UNIQUE (STS_ID),
 					  KEY STS_type (STS_type)";
-        $this->_table_should_exist_previously($table_name, $sql);
+		$this->_table_should_exist_previously($table_name, $sql);
 
-        $table_name = 'esp_transaction';
-        $sql        = "TXN_ID int(10) unsigned NOT NULL AUTO_INCREMENT,
+		$table_name = 'esp_transaction';
+		$sql        = "TXN_ID int(10) unsigned NOT NULL AUTO_INCREMENT,
 					  TXN_timestamp datetime NOT NULL DEFAULT '0000-00-00 00:00:00',
 					  TXN_total decimal(10,3) DEFAULT '0.00',
 					  TXN_paid decimal(10,3) NOT NULL DEFAULT '0.00',
@@ -442,10 +442,10 @@ 
 					  PRIMARY KEY  (TXN_ID),
 					  KEY TXN_timestamp (TXN_timestamp),
 					  KEY STS_ID (STS_ID)";
-        $this->_table_should_exist_previously($table_name, $sql);
+		$this->_table_should_exist_previously($table_name, $sql);
 
-        $table_name = 'esp_venue_meta';
-        $sql        = "VNUM_ID int(11) NOT NULL AUTO_INCREMENT,
+		$table_name = 'esp_venue_meta';
+		$sql        = "VNUM_ID int(11) NOT NULL AUTO_INCREMENT,
 			VNU_ID bigint(20) unsigned NOT NULL DEFAULT 0,
 			VNU_address varchar(255) DEFAULT NULL,
 			VNU_address2 varchar(255) DEFAULT NULL,
@@ -463,75 +463,75 @@ 
 			PRIMARY KEY  (VNUM_ID),
 			KEY STA_ID (STA_ID),
 			KEY CNT_ISO (CNT_ISO)";
-        $this->_table_should_exist_previously($table_name, $sql);
-        $script_with_defaults = EE_Registry::instance()->load_dms('Core_4_1_0');
-        // setting up the DEFAULT stats and countries is also essential for the data migrations to run
-        // (because many need to convert old string states to foreign keys into the states table)
-        $script_with_defaults->insert_default_states();
-        $script_with_defaults->insert_default_countries();
-        // setting up DEFAULT prices, price types, and tickets is also essential for the price migrations
-        $script_with_defaults->insert_default_price_types();
-        $script_with_defaults->insert_default_prices();
-        // but the schema on the tickets table has changed since 4.1, so use our DEFAULT ticket method instead of 4.1's
-        $this->insert_default_tickets();
-        // setting up the config wp option pretty well counts as a 'schema change', or at least should happen here
-        EE_Config::instance()->update_espresso_config();
-        return true;
-    }
-
-
-    /**
-     * @return boolean
-     */
-    public function schema_changes_after_migration()
-    {
-        return true;
-    }
-
-
-    public function migration_page_hooks()
-    {
-    }
-
-
-    /**
-     * insert DEFAULT ticket
-     * Almost identical to EE_DMS_Core_4_1_0::insert_default_tickets, except is aware of the TKT_required field
-     *
-     * @access public
-     * @static
-     * @return void
-     * @throws EE_Error
-     */
-    public function insert_default_tickets()
-    {
-        global $wpdb;
-        $ticket_table = $wpdb->prefix . "esp_ticket";
-        if ($this->_get_table_analysis()->tableExists($ticket_table)) {
-            $SQL           = 'SELECT COUNT(TKT_ID) FROM ' . $ticket_table;
-            $tickets_exist = $wpdb->get_var($SQL);
-            if (! $tickets_exist) {
-                $SQL = "INSERT INTO $ticket_table
+		$this->_table_should_exist_previously($table_name, $sql);
+		$script_with_defaults = EE_Registry::instance()->load_dms('Core_4_1_0');
+		// setting up the DEFAULT stats and countries is also essential for the data migrations to run
+		// (because many need to convert old string states to foreign keys into the states table)
+		$script_with_defaults->insert_default_states();
+		$script_with_defaults->insert_default_countries();
+		// setting up DEFAULT prices, price types, and tickets is also essential for the price migrations
+		$script_with_defaults->insert_default_price_types();
+		$script_with_defaults->insert_default_prices();
+		// but the schema on the tickets table has changed since 4.1, so use our DEFAULT ticket method instead of 4.1's
+		$this->insert_default_tickets();
+		// setting up the config wp option pretty well counts as a 'schema change', or at least should happen here
+		EE_Config::instance()->update_espresso_config();
+		return true;
+	}
+
+
+	/**
+	 * @return boolean
+	 */
+	public function schema_changes_after_migration()
+	{
+		return true;
+	}
+
+
+	public function migration_page_hooks()
+	{
+	}
+
+
+	/**
+	 * insert DEFAULT ticket
+	 * Almost identical to EE_DMS_Core_4_1_0::insert_default_tickets, except is aware of the TKT_required field
+	 *
+	 * @access public
+	 * @static
+	 * @return void
+	 * @throws EE_Error
+	 */
+	public function insert_default_tickets()
+	{
+		global $wpdb;
+		$ticket_table = $wpdb->prefix . "esp_ticket";
+		if ($this->_get_table_analysis()->tableExists($ticket_table)) {
+			$SQL           = 'SELECT COUNT(TKT_ID) FROM ' . $ticket_table;
+			$tickets_exist = $wpdb->get_var($SQL);
+			if (! $tickets_exist) {
+				$SQL = "INSERT INTO $ticket_table
 					( TKT_ID, TTM_ID, TKT_name, TKT_description, TKT_qty, TKT_sold, TKT_uses, TKT_required, TKT_min, TKT_max, TKT_price, TKT_start_date, TKT_end_date, TKT_taxable, TKT_order, TKT_row, TKT_is_default, TKT_parent, TKT_deleted ) VALUES
 					( 1, 0, '" .
-                       esc_html__("Free Ticket", "event_espresso") .
-                       "', '', 100, 0, -1, 0, 0, -1, 0.00, '0000-00-00 00:00:00', '0000-00-00 00:00:00', 0, 0, 1, 1, 0, 0);";
-                $SQL = apply_filters('FHEE__EE_DMS_4_1_0__insert_default_tickets__SQL', $SQL);
-                $wpdb->query($SQL);
-            }
-        }
-        $ticket_price_table = $wpdb->prefix . "esp_ticket_price";
-        if ($this->_get_table_analysis()->tableExists($ticket_price_table)) {
-            $SQL              = 'SELECT COUNT(TKP_ID) FROM ' . $ticket_price_table;
-            $ticket_prc_exist = $wpdb->get_var($SQL);
-            if (! $ticket_prc_exist) {
-                $SQL = "INSERT INTO $ticket_price_table
+					   esc_html__("Free Ticket", "event_espresso") .
+					   "', '', 100, 0, -1, 0, 0, -1, 0.00, '0000-00-00 00:00:00', '0000-00-00 00:00:00', 0, 0, 1, 1, 0, 0);";
+				$SQL = apply_filters('FHEE__EE_DMS_4_1_0__insert_default_tickets__SQL', $SQL);
+				$wpdb->query($SQL);
+			}
+		}
+		$ticket_price_table = $wpdb->prefix . "esp_ticket_price";
+		if ($this->_get_table_analysis()->tableExists($ticket_price_table)) {
+			$SQL              = 'SELECT COUNT(TKP_ID) FROM ' . $ticket_price_table;
+			$ticket_prc_exist = $wpdb->get_var($SQL);
+			if (! $ticket_prc_exist) {
+				$SQL = "INSERT INTO $ticket_price_table
 				( TKP_ID, TKT_ID, PRC_ID ) VALUES
 				( 1, 1, 1 )
 				";
-                $SQL = apply_filters('FHEE__EE_DMS_4_1_0__insert_default_tickets__SQL__ticket_price', $SQL);
-                $wpdb->query($SQL);
-            }
-        }
-    }
+				$SQL = apply_filters('FHEE__EE_DMS_4_1_0__insert_default_tickets__SQL__ticket_price', $SQL);
+				$wpdb->query($SQL);
+			}
+		}
+	}
 }

Spacing +14 added lines, -14 removed lines

@@ -7,13 +7,13 @@ 
 // unfortunately, this needs to be done upon INCLUSION of this file,
 // instead of construction, because it only gets constructed on first page load
 // (all other times it gets resurrected from a wordpress option)
-$stages            = glob(EE_CORE . 'data_migration_scripts/4_3_0_stages/*');
+$stages            = glob(EE_CORE.'data_migration_scripts/4_3_0_stages/*');
 $class_to_filepath = [];
-if (! empty($stages)) {
+if ( ! empty($stages)) {
     foreach ($stages as $filepath) {
         $matches = [];
         preg_match('~4_3_0_stages/(.*).dmsstage.php~', $filepath, $matches);
-        $class_to_filepath[ $matches[1] ] = $filepath;
+        $class_to_filepath[$matches[1]] = $filepath;
     }
 }
 // give addons a chance to autoload their stages too
@@ -58,10 +58,10 @@ 
         ) {
             //          echo "$version_string can be migrated fro";
             return true;
-        } elseif (! $version_string) {
+        } elseif ( ! $version_string) {
             //          echo "no version string provided: $version_string";
             // no version string provided... this must be pre 4.2
-            return false;// changed mind. dont want people thinking they should migrate yet because they cant
+            return false; // changed mind. dont want people thinking they should migrate yet because they cant
         } else {
             //          echo "$version_string doesnt apply";
             return false;
@@ -76,7 +76,7 @@ 
     public function schema_changes_before_migration()
     {
         // relies on 4.1's EEH_Activation::create_table
-        require_once(EE_HELPERS . 'EEH_Activation.helper.php');
+        require_once(EE_HELPERS.'EEH_Activation.helper.php');
 
         $table_name = 'esp_answer';
         $sql        = "ANS_ID int(10) unsigned NOT NULL AUTO_INCREMENT,
@@ -506,25 +506,25 @@ 
     public function insert_default_tickets()
     {
         global $wpdb;
-        $ticket_table = $wpdb->prefix . "esp_ticket";
+        $ticket_table = $wpdb->prefix."esp_ticket";
         if ($this->_get_table_analysis()->tableExists($ticket_table)) {
-            $SQL           = 'SELECT COUNT(TKT_ID) FROM ' . $ticket_table;
+            $SQL           = 'SELECT COUNT(TKT_ID) FROM '.$ticket_table;
             $tickets_exist = $wpdb->get_var($SQL);
-            if (! $tickets_exist) {
+            if ( ! $tickets_exist) {
                 $SQL = "INSERT INTO $ticket_table
 					( TKT_ID, TTM_ID, TKT_name, TKT_description, TKT_qty, TKT_sold, TKT_uses, TKT_required, TKT_min, TKT_max, TKT_price, TKT_start_date, TKT_end_date, TKT_taxable, TKT_order, TKT_row, TKT_is_default, TKT_parent, TKT_deleted ) VALUES
-					( 1, 0, '" .
-                       esc_html__("Free Ticket", "event_espresso") .
+					( 1, 0, '".
+                       esc_html__("Free Ticket", "event_espresso").
                        "', '', 100, 0, -1, 0, 0, -1, 0.00, '0000-00-00 00:00:00', '0000-00-00 00:00:00', 0, 0, 1, 1, 0, 0);";
                 $SQL = apply_filters('FHEE__EE_DMS_4_1_0__insert_default_tickets__SQL', $SQL);
                 $wpdb->query($SQL);
             }
         }
-        $ticket_price_table = $wpdb->prefix . "esp_ticket_price";
+        $ticket_price_table = $wpdb->prefix."esp_ticket_price";
         if ($this->_get_table_analysis()->tableExists($ticket_price_table)) {
-            $SQL              = 'SELECT COUNT(TKP_ID) FROM ' . $ticket_price_table;
+            $SQL              = 'SELECT COUNT(TKP_ID) FROM '.$ticket_price_table;
             $ticket_prc_exist = $wpdb->get_var($SQL);
-            if (! $ticket_prc_exist) {
+            if ( ! $ticket_prc_exist) {
                 $SQL = "INSERT INTO $ticket_price_table
 				( TKP_ID, TKT_ID, PRC_ID ) VALUES
 				( 1, 1, 1 )

core/data_migration_scripts/EE_DMS_Core_4_9_0.dms.php

Indentation +333 added lines, -333 removed lines

@@ -12,9 +12,9 @@ 
 $stages            = glob(EE_CORE . 'data_migration_scripts/4_9_0_stages/*');
 $class_to_filepath = [];
 foreach ($stages as $filepath) {
-    $matches = [];
-    preg_match('~4_9_0_stages/(.*).dmsstage.php~', $filepath, $matches);
-    $class_to_filepath[ $matches[1] ] = $filepath;
+	$matches = [];
+	preg_match('~4_9_0_stages/(.*).dmsstage.php~', $filepath, $matches);
+	$class_to_filepath[ $matches[1] ] = $filepath;
 }
 // give addons a chance to autoload their stages too
 $class_to_filepath = apply_filters('FHEE__EE_DMS_4_9_0__autoloaded_stages', $class_to_filepath);
@@ -33,73 +33,73 @@ 
 class EE_DMS_Core_4_9_0 extends EE_Data_Migration_Script_Base
 {
 
-    /**
-     * return EE_DMS_Core_4_9_0
-     *
-     * @param TableManager|null  $table_manager
-     * @param TableAnalysis|null $table_analysis
-     */
-    public function __construct(TableManager $table_manager = null, TableAnalysis $table_analysis = null)
-    {
-        $this->_pretty_name      = esc_html__("Data Update to Event Espresso 4.9.0", "event_espresso");
-        $this->_priority         = 10;
-        $this->_migration_stages = [
-            new EE_DMS_4_9_0_Email_System_Question(),
-            new EE_DMS_4_9_0_Answers_With_No_Registration(),
-        ];
-        parent::__construct($table_manager, $table_analysis);
-    }
-
-
-    /**
-     * Whether to migrate or not.
-     *
-     * @param array $version_array
-     * @return bool
-     */
-    public function can_migrate_from_version($version_array)
-    {
-        $version_string = $version_array['Core'];
-        if (
-            version_compare($version_string, '4.9.0.decaf', '<') &&
-            version_compare($version_string, '4.8.0.decaf', '>=')
-        ) {
-            //          echo "$version_string can be migrated from";
-            return true;
-        } elseif (! $version_string) {
-            //          echo "no version string provided: $version_string";
-            // no version string provided... this must be pre 4.3
-            return false;// changed mind. dont want people thinking they should migrate yet because they cant
-        } else {
-            //          echo "$version_string doesnt apply";
-            return false;
-        }
-    }
-
-
-    /**
-     * @return bool
-     * @throws EE_Error
-     * @throws ReflectionException
-     */
-    public function schema_changes_before_migration()
-    {
-        require_once(EE_HELPERS . 'EEH_Activation.helper.php');
-        $now_in_mysql = current_time('mysql', true);
-
-        $table_name   = 'esp_answer';
-        $sql          = " ANS_ID int(10) unsigned NOT NULL AUTO_INCREMENT,
+	/**
+	 * return EE_DMS_Core_4_9_0
+	 *
+	 * @param TableManager|null  $table_manager
+	 * @param TableAnalysis|null $table_analysis
+	 */
+	public function __construct(TableManager $table_manager = null, TableAnalysis $table_analysis = null)
+	{
+		$this->_pretty_name      = esc_html__("Data Update to Event Espresso 4.9.0", "event_espresso");
+		$this->_priority         = 10;
+		$this->_migration_stages = [
+			new EE_DMS_4_9_0_Email_System_Question(),
+			new EE_DMS_4_9_0_Answers_With_No_Registration(),
+		];
+		parent::__construct($table_manager, $table_analysis);
+	}
+
+
+	/**
+	 * Whether to migrate or not.
+	 *
+	 * @param array $version_array
+	 * @return bool
+	 */
+	public function can_migrate_from_version($version_array)
+	{
+		$version_string = $version_array['Core'];
+		if (
+			version_compare($version_string, '4.9.0.decaf', '<') &&
+			version_compare($version_string, '4.8.0.decaf', '>=')
+		) {
+			//          echo "$version_string can be migrated from";
+			return true;
+		} elseif (! $version_string) {
+			//          echo "no version string provided: $version_string";
+			// no version string provided... this must be pre 4.3
+			return false;// changed mind. dont want people thinking they should migrate yet because they cant
+		} else {
+			//          echo "$version_string doesnt apply";
+			return false;
+		}
+	}
+
+
+	/**
+	 * @return bool
+	 * @throws EE_Error
+	 * @throws ReflectionException
+	 */
+	public function schema_changes_before_migration()
+	{
+		require_once(EE_HELPERS . 'EEH_Activation.helper.php');
+		$now_in_mysql = current_time('mysql', true);
+
+		$table_name   = 'esp_answer';
+		$sql          = " ANS_ID int(10) unsigned NOT NULL AUTO_INCREMENT,
 					REG_ID int(10) unsigned NOT NULL,
 					QST_ID int(10) unsigned NOT NULL,
 					ANS_value text NOT NULL,
 					PRIMARY KEY  (ANS_ID),
 					KEY REG_ID (REG_ID),
 					KEY QST_ID (QST_ID)";
-        $this->_table_has_not_changed_since_previous($table_name, $sql);
+		$this->_table_has_not_changed_since_previous($table_name, $sql);
 
-        $table_name = 'esp_attendee_meta';
-        $this->_get_table_manager()->dropIndexIfSizeNot($table_name, 'ATT_email');
-        $sql = "ATTM_ID int(10) unsigned NOT NULL AUTO_INCREMENT,
+		$table_name = 'esp_attendee_meta';
+		$this->_get_table_manager()->dropIndexIfSizeNot($table_name, 'ATT_email');
+		$sql = "ATTM_ID int(10) unsigned NOT NULL AUTO_INCREMENT,
 				ATT_ID bigint(20) unsigned NOT NULL,
 				ATT_fname varchar(45) NOT NULL,
 				ATT_lname varchar(45) NOT NULL,
@@ -116,10 +116,10 @@ 
 				KEY ATT_email (ATT_email(191)),
 				KEY ATT_lname (ATT_lname),
 				KEY ATT_fname (ATT_fname)";
-        $this->_table_is_changed_in_this_version($table_name, $sql);
+		$this->_table_is_changed_in_this_version($table_name, $sql);
 
-        $table_name = 'esp_checkin';
-        $sql        = "CHK_ID int(10) unsigned NOT NULL AUTO_INCREMENT,
+		$table_name = 'esp_checkin';
+		$sql        = "CHK_ID int(10) unsigned NOT NULL AUTO_INCREMENT,
 				REG_ID int(10) unsigned NOT NULL,
 				DTT_ID int(10) unsigned NOT NULL,
 				CHK_in tinyint(1) unsigned NOT NULL DEFAULT 1,
@@ -127,10 +127,10 @@ 
 				PRIMARY KEY  (CHK_ID),
 				KEY REG_ID (REG_ID),
 				KEY DTT_ID (DTT_ID)";
-        $this->_table_has_not_changed_since_previous($table_name, $sql);
+		$this->_table_has_not_changed_since_previous($table_name, $sql);
 
-        $table_name = 'esp_country';
-        $sql        = "CNT_ISO varchar(2) NOT NULL,
+		$table_name = 'esp_country';
+		$sql        = "CNT_ISO varchar(2) NOT NULL,
 				CNT_ISO3 varchar(3) NOT NULL,
 				RGN_ID tinyint(3) unsigned DEFAULT NULL,
 				CNT_name varchar(45) NOT NULL,
@@ -146,20 +146,20 @@ 
 				CNT_is_EU tinyint(1) DEFAULT '0',
 				CNT_active tinyint(1) DEFAULT '0',
 				PRIMARY KEY  (CNT_ISO)";
-        $this->_table_has_not_changed_since_previous($table_name, $sql);
+		$this->_table_has_not_changed_since_previous($table_name, $sql);
 
-        $table_name = 'esp_currency';
-        $sql        = "CUR_code varchar(6) NOT NULL,
+		$table_name = 'esp_currency';
+		$sql        = "CUR_code varchar(6) NOT NULL,
 				CUR_single varchar(45) DEFAULT 'dollar',
 				CUR_plural varchar(45) DEFAULT 'dollars',
 				CUR_sign varchar(45) DEFAULT '$',
 				CUR_dec_plc varchar(1) NOT NULL DEFAULT '2',
 				CUR_active tinyint(1) DEFAULT '0',
 				PRIMARY KEY  (CUR_code)";
-        $this->_table_has_not_changed_since_previous($table_name, $sql);
+		$this->_table_has_not_changed_since_previous($table_name, $sql);
 
-        $table_name = 'esp_datetime';
-        $sql        = "DTT_ID int(10) unsigned NOT NULL AUTO_INCREMENT,
+		$table_name = 'esp_datetime';
+		$sql        = "DTT_ID int(10) unsigned NOT NULL AUTO_INCREMENT,
 				EVT_ID bigint(20) unsigned NOT NULL,
 				DTT_name varchar(255) NOT NULL DEFAULT '',
 				DTT_description text NOT NULL,
@@ -176,28 +176,28 @@ 
 				KEY DTT_EVT_start (DTT_EVT_start),
 				KEY EVT_ID (EVT_ID),
 				KEY DTT_is_primary (DTT_is_primary)";
-        $this->_table_is_changed_in_this_version($table_name, $sql);
+		$this->_table_is_changed_in_this_version($table_name, $sql);
 
-        $table_name = "esp_datetime_ticket";
-        $sql        = "DTK_ID int(10) unsigned NOT NULL AUTO_INCREMENT,
+		$table_name = "esp_datetime_ticket";
+		$sql        = "DTK_ID int(10) unsigned NOT NULL AUTO_INCREMENT,
 				DTT_ID int(10) unsigned NOT NULL,
 				TKT_ID int(10) unsigned NOT NULL,
 				PRIMARY KEY  (DTK_ID),
 				KEY DTT_ID (DTT_ID),
 				KEY TKT_ID (TKT_ID)";
-        $this->_table_has_not_changed_since_previous($table_name, $sql);
+		$this->_table_has_not_changed_since_previous($table_name, $sql);
 
-        $table_name = 'esp_event_message_template';
-        $sql        = "EMT_ID bigint(20) unsigned NOT NULL AUTO_INCREMENT,
+		$table_name = 'esp_event_message_template';
+		$sql        = "EMT_ID bigint(20) unsigned NOT NULL AUTO_INCREMENT,
 				EVT_ID bigint(20) unsigned NOT NULL DEFAULT 0,
 				GRP_ID int(10) unsigned NOT NULL DEFAULT 0,
 				PRIMARY KEY  (EMT_ID),
 				KEY EVT_ID (EVT_ID),
 				KEY GRP_ID (GRP_ID)";
-        $this->_table_has_not_changed_since_previous($table_name, $sql);
+		$this->_table_has_not_changed_since_previous($table_name, $sql);
 
-        $table_name = 'esp_event_meta';
-        $sql        = "EVTM_ID int(10) NOT NULL AUTO_INCREMENT,
+		$table_name = 'esp_event_meta';
+		$sql        = "EVTM_ID int(10) NOT NULL AUTO_INCREMENT,
 				EVT_ID bigint(20) unsigned NOT NULL,
 				EVT_display_desc tinyint(1) unsigned NOT NULL DEFAULT 1,
 				EVT_display_ticket_selector tinyint(1) unsigned NOT NULL DEFAULT 1,
@@ -212,38 +212,38 @@ 
 				EVT_donations tinyint(1) NULL,
 				PRIMARY KEY  (EVTM_ID),
 				KEY EVT_ID (EVT_ID)";
-        $this->_table_has_not_changed_since_previous($table_name, $sql);
+		$this->_table_has_not_changed_since_previous($table_name, $sql);
 
-        $table_name = 'esp_event_question_group';
-        $sql        = "EQG_ID int(10) unsigned NOT NULL AUTO_INCREMENT,
+		$table_name = 'esp_event_question_group';
+		$sql        = "EQG_ID int(10) unsigned NOT NULL AUTO_INCREMENT,
 				EVT_ID bigint(20) unsigned NOT NULL,
 				QSG_ID int(10) unsigned NOT NULL,
 				EQG_primary tinyint(1) unsigned NOT NULL DEFAULT 0,
 				PRIMARY KEY  (EQG_ID),
 				KEY EVT_ID (EVT_ID),
 				KEY QSG_ID (QSG_ID)";
-        $this->_table_is_changed_in_this_version($table_name, $sql);
+		$this->_table_is_changed_in_this_version($table_name, $sql);
 
-        $table_name = 'esp_event_venue';
-        $sql        = "EVV_ID int(11) NOT NULL AUTO_INCREMENT,
+		$table_name = 'esp_event_venue';
+		$sql        = "EVV_ID int(11) NOT NULL AUTO_INCREMENT,
 				EVT_ID bigint(20) unsigned NOT NULL,
 				VNU_ID bigint(20) unsigned NOT NULL,
 				EVV_primary tinyint(1) unsigned NOT NULL DEFAULT 0,
 				PRIMARY KEY  (EVV_ID)";
-        $this->_table_has_not_changed_since_previous($table_name, $sql);
+		$this->_table_has_not_changed_since_previous($table_name, $sql);
 
-        $table_name = 'esp_extra_meta';
-        $sql        = "EXM_ID int(11) NOT NULL AUTO_INCREMENT,
+		$table_name = 'esp_extra_meta';
+		$sql        = "EXM_ID int(11) NOT NULL AUTO_INCREMENT,
 				OBJ_ID int(11) DEFAULT NULL,
 				EXM_type varchar(45) DEFAULT NULL,
 				EXM_key varchar(45) DEFAULT NULL,
 				EXM_value text,
 				PRIMARY KEY  (EXM_ID),
 				KEY EXM_type (EXM_type,OBJ_ID,EXM_key)";
-        $this->_table_has_not_changed_since_previous($table_name, $sql);
+		$this->_table_has_not_changed_since_previous($table_name, $sql);
 
-        $table_name = 'esp_extra_join';
-        $sql        = "EXJ_ID int(11) NOT NULL AUTO_INCREMENT,
+		$table_name = 'esp_extra_join';
+		$sql        = "EXJ_ID int(11) NOT NULL AUTO_INCREMENT,
 				EXJ_first_model_id varchar(6) NOT NULL,
 				EXJ_first_model_name varchar(20) NOT NULL,
 				EXJ_second_model_id varchar(6) NOT NULL,
@@ -251,10 +251,10 @@ 
 				PRIMARY KEY  (EXJ_ID),
 				KEY first_model (EXJ_first_model_name,EXJ_first_model_id),
 				KEY second_model (EXJ_second_model_name,EXJ_second_model_id)";
-        $this->_table_has_not_changed_since_previous($table_name, $sql);
+		$this->_table_has_not_changed_since_previous($table_name, $sql);
 
-        $table_name = 'esp_line_item';
-        $sql        = "LIN_ID int(11) NOT NULL AUTO_INCREMENT,
+		$table_name = 'esp_line_item';
+		$sql        = "LIN_ID int(11) NOT NULL AUTO_INCREMENT,
 				LIN_code varchar(245) NOT NULL DEFAULT '',
 				TXN_ID int(11) DEFAULT NULL,
 				LIN_name varchar(245) NOT NULL DEFAULT '',
@@ -275,12 +275,12 @@ 
 				KEY txn_type_timestamp (TXN_ID,LIN_type,LIN_timestamp),
 				KEY txn_obj_id_obj_type (TXN_ID,OBJ_ID,OBJ_type),
 				KEY obj_id_obj_type (OBJ_ID,OBJ_type)";
-        $this->_get_table_manager()->dropIndex('esp_line_item', 'TXN_ID');
-        $this->_get_table_manager()->dropIndex('esp_line_item', 'LIN_code');
-        $this->_table_is_changed_in_this_version($table_name, $sql);
+		$this->_get_table_manager()->dropIndex('esp_line_item', 'TXN_ID');
+		$this->_get_table_manager()->dropIndex('esp_line_item', 'LIN_code');
+		$this->_table_is_changed_in_this_version($table_name, $sql);
 
-        $table_name = 'esp_log';
-        $sql        = "LOG_ID int(11) NOT NULL AUTO_INCREMENT,
+		$table_name = 'esp_log';
+		$sql        = "LOG_ID int(11) NOT NULL AUTO_INCREMENT,
 				LOG_time datetime DEFAULT NULL,
 				OBJ_ID varchar(45) DEFAULT NULL,
 				OBJ_type varchar(45) DEFAULT NULL,
@@ -291,13 +291,13 @@ 
 				KEY LOG_time (LOG_time),
 				KEY OBJ (OBJ_type,OBJ_ID),
 				KEY LOG_type (LOG_type)";
-        $this->_table_has_not_changed_since_previous($table_name, $sql);
+		$this->_table_has_not_changed_since_previous($table_name, $sql);
 
-        $table_name = 'esp_message';
-        $this->_get_table_manager()->dropIndexIfSizeNot($table_name, 'MSG_to');
-        $this->_get_table_manager()->dropIndexIfSizeNot($table_name, 'MSG_from');
-        $this->_get_table_manager()->dropIndexIfSizeNot($table_name, 'MSG_subject');
-        $sql = "MSG_ID bigint(20) unsigned NOT NULL AUTO_INCREMENT,
+		$table_name = 'esp_message';
+		$this->_get_table_manager()->dropIndexIfSizeNot($table_name, 'MSG_to');
+		$this->_get_table_manager()->dropIndexIfSizeNot($table_name, 'MSG_from');
+		$this->_get_table_manager()->dropIndexIfSizeNot($table_name, 'MSG_subject');
+		$sql = "MSG_ID bigint(20) unsigned NOT NULL AUTO_INCREMENT,
 				GRP_ID int(10) unsigned NULL,
 				MSG_token varchar(255) NULL,
 				TXN_ID int(10) unsigned NULL,
@@ -329,20 +329,20 @@ 
 				KEY STS_ID (STS_ID),
 				KEY MSG_created (MSG_created),
 				KEY MSG_modified (MSG_modified)";
-        $this->_table_is_new_in_this_version($table_name, $sql);
+		$this->_table_is_new_in_this_version($table_name, $sql);
 
-        $table_name = 'esp_message_template';
-        $sql        = "MTP_ID int(10) unsigned NOT NULL AUTO_INCREMENT,
+		$table_name = 'esp_message_template';
+		$sql        = "MTP_ID int(10) unsigned NOT NULL AUTO_INCREMENT,
 				GRP_ID int(10) unsigned NOT NULL,
 				MTP_context varchar(50) NOT NULL,
 				MTP_template_field varchar(30) NOT NULL,
 				MTP_content text NOT NULL,
 				PRIMARY KEY  (MTP_ID),
 				KEY GRP_ID (GRP_ID)";
-        $this->_table_has_not_changed_since_previous($table_name, $sql);
+		$this->_table_has_not_changed_since_previous($table_name, $sql);
 
-        $table_name = 'esp_message_template_group';
-        $sql        = "GRP_ID int(10) unsigned NOT NULL AUTO_INCREMENT,
+		$table_name = 'esp_message_template_group';
+		$sql        = "GRP_ID int(10) unsigned NOT NULL AUTO_INCREMENT,
 				MTP_user_id int(10) NOT NULL DEFAULT '1',
 				MTP_name varchar(245) NOT NULL DEFAULT '',
 				MTP_description varchar(245) NOT NULL DEFAULT '',
@@ -354,10 +354,10 @@ 
 				MTP_is_active tinyint(1) NOT NULL DEFAULT '1',
 				PRIMARY KEY  (GRP_ID),
 				KEY MTP_user_id (MTP_user_id)";
-        $this->_table_has_not_changed_since_previous($table_name, $sql);
+		$this->_table_has_not_changed_since_previous($table_name, $sql);
 
-        $table_name = 'esp_payment';
-        $sql        = "PAY_ID int(10) unsigned NOT NULL AUTO_INCREMENT,
+		$table_name = 'esp_payment';
+		$sql        = "PAY_ID int(10) unsigned NOT NULL AUTO_INCREMENT,
 				TXN_ID int(10) unsigned DEFAULT NULL,
 				STS_ID varchar(3) DEFAULT NULL,
 				PAY_timestamp datetime NOT NULL DEFAULT '0000-00-00 00:00:00',
@@ -374,10 +374,10 @@ 
 				PRIMARY KEY  (PAY_ID),
 				KEY PAY_timestamp (PAY_timestamp),
 				KEY TXN_ID (TXN_ID)";
-        $this->_table_is_changed_in_this_version($table_name, $sql);
+		$this->_table_is_changed_in_this_version($table_name, $sql);
 
-        $table_name = 'esp_payment_method';
-        $sql        = "PMD_ID int(11) NOT NULL AUTO_INCREMENT,
+		$table_name = 'esp_payment_method';
+		$sql        = "PMD_ID int(11) NOT NULL AUTO_INCREMENT,
 				PMD_type varchar(124) DEFAULT NULL,
 				PMD_name varchar(255) DEFAULT NULL,
 				PMD_desc text,
@@ -393,27 +393,27 @@ 
 				PRIMARY KEY  (PMD_ID),
 				UNIQUE KEY PMD_slug_UNIQUE (PMD_slug),
 				KEY PMD_type (PMD_type)";
-        $this->_table_has_not_changed_since_previous($table_name, $sql);
+		$this->_table_has_not_changed_since_previous($table_name, $sql);
 
-        $table_name = "esp_ticket_price";
-        $sql        = "TKP_ID int(10) unsigned NOT NULL AUTO_INCREMENT,
+		$table_name = "esp_ticket_price";
+		$sql        = "TKP_ID int(10) unsigned NOT NULL AUTO_INCREMENT,
 				TKT_ID int(10) unsigned NOT NULL,
 				PRC_ID int(10) unsigned NOT NULL,
 				PRIMARY KEY  (TKP_ID),
 				KEY TKT_ID (TKT_ID),
 				KEY PRC_ID (PRC_ID)";
-        $this->_table_has_not_changed_since_previous($table_name, $sql);
+		$this->_table_has_not_changed_since_previous($table_name, $sql);
 
-        $table_name = "esp_ticket_template";
-        $sql        = "TTM_ID int(10) unsigned NOT NULL AUTO_INCREMENT,
+		$table_name = "esp_ticket_template";
+		$sql        = "TTM_ID int(10) unsigned NOT NULL AUTO_INCREMENT,
 				TTM_name varchar(45) NOT NULL,
 				TTM_description text,
 				TTM_file varchar(45),
 				PRIMARY KEY  (TTM_ID)";
-        $this->_table_has_not_changed_since_previous($table_name, $sql);
+		$this->_table_has_not_changed_since_previous($table_name, $sql);
 
-        $table_name = 'esp_question';
-        $sql        = 'QST_ID int(10) unsigned NOT NULL AUTO_INCREMENT,
+		$table_name = 'esp_question';
+		$sql        = 'QST_ID int(10) unsigned NOT NULL AUTO_INCREMENT,
 				QST_display_text text NOT NULL,
 				QST_admin_label varchar(255) NOT NULL,
 				QST_system varchar(25) DEFAULT NULL,
@@ -427,20 +427,20 @@ 
 				QST_deleted tinyint(2) unsigned NOT NULL DEFAULT 0,
 				PRIMARY KEY  (QST_ID),
 				KEY QST_order (QST_order)';
-        $this->_table_is_changed_in_this_version($table_name, $sql);
+		$this->_table_is_changed_in_this_version($table_name, $sql);
 
-        $table_name = 'esp_question_group_question';
-        $sql        = "QGQ_ID int(10) unsigned NOT NULL AUTO_INCREMENT,
+		$table_name = 'esp_question_group_question';
+		$sql        = "QGQ_ID int(10) unsigned NOT NULL AUTO_INCREMENT,
 				QSG_ID int(10) unsigned NOT NULL,
 				QST_ID int(10) unsigned NOT NULL,
 				QGQ_order int(10) unsigned NOT NULL DEFAULT 0,
 				PRIMARY KEY  (QGQ_ID),
 				KEY QST_ID (QST_ID),
 				KEY QSG_ID_order (QSG_ID,QGQ_order)";
-        $this->_table_has_not_changed_since_previous($table_name, $sql);
+		$this->_table_has_not_changed_since_previous($table_name, $sql);
 
-        $table_name = 'esp_question_option';
-        $sql        = "QSO_ID int(10) unsigned NOT NULL AUTO_INCREMENT,
+		$table_name = 'esp_question_option';
+		$sql        = "QSO_ID int(10) unsigned NOT NULL AUTO_INCREMENT,
 				QSO_value varchar(255) NOT NULL,
 				QSO_desc text NOT NULL,
 				QST_ID int(10) unsigned NOT NULL,
@@ -450,10 +450,10 @@ 
 				PRIMARY KEY  (QSO_ID),
 				KEY QST_ID (QST_ID),
 				KEY QSO_order (QSO_order)";
-        $this->_table_has_not_changed_since_previous($table_name, $sql);
+		$this->_table_has_not_changed_since_previous($table_name, $sql);
 
-        $table_name = 'esp_registration';
-        $sql        = "REG_ID int(10) unsigned NOT NULL AUTO_INCREMENT,
+		$table_name = 'esp_registration';
+		$sql        = "REG_ID int(10) unsigned NOT NULL AUTO_INCREMENT,
 				EVT_ID bigint(20) unsigned NOT NULL,
 				ATT_ID bigint(20) unsigned NOT NULL,
 				TXN_ID int(10) unsigned NOT NULL,
@@ -477,20 +477,20 @@ 
 				KEY TKT_ID (TKT_ID),
 				KEY EVT_ID (EVT_ID),
 				KEY STS_ID (STS_ID)";
-        $this->_table_is_changed_in_this_version($table_name, $sql);
+		$this->_table_is_changed_in_this_version($table_name, $sql);
 
-        $table_name = 'esp_registration_payment';
-        $sql        = "RPY_ID int(10) unsigned NOT NULL AUTO_INCREMENT,
+		$table_name = 'esp_registration_payment';
+		$sql        = "RPY_ID int(10) unsigned NOT NULL AUTO_INCREMENT,
 					  REG_ID int(10) unsigned NOT NULL,
 					  PAY_ID int(10) unsigned NULL,
 					  RPY_amount decimal(12,3) NOT NULL DEFAULT '0.00',
 					  PRIMARY KEY  (RPY_ID),
 					  KEY REG_ID (REG_ID),
 					  KEY PAY_ID (PAY_ID)";
-        $this->_table_is_changed_in_this_version($table_name, $sql);
+		$this->_table_is_changed_in_this_version($table_name, $sql);
 
-        $table_name = 'esp_state';
-        $sql        = "STA_ID smallint(5) unsigned NOT NULL AUTO_INCREMENT,
+		$table_name = 'esp_state';
+		$sql        = "STA_ID smallint(5) unsigned NOT NULL AUTO_INCREMENT,
 				CNT_ISO varchar(2) NOT NULL,
 				STA_abbrev varchar(24) NOT NULL,
 				STA_name varchar(100) NOT NULL,
@@ -498,10 +498,10 @@ 
 				PRIMARY KEY  (STA_ID),
 				KEY STA_abbrev (STA_abbrev),
 				KEY CNT_ISO (CNT_ISO)";
-        $this->_table_has_not_changed_since_previous($table_name, $sql);
+		$this->_table_has_not_changed_since_previous($table_name, $sql);
 
-        $table_name = 'esp_status';
-        $sql        = "STS_ID varchar(3) NOT NULL,
+		$table_name = 'esp_status';
+		$sql        = "STS_ID varchar(3) NOT NULL,
 				STS_code varchar(45) NOT NULL,
 				STS_type varchar(45) NOT NULL,
 				STS_can_edit tinyint(1) NOT NULL DEFAULT 0,
@@ -509,10 +509,10 @@ 
 				STS_open tinyint(1) NOT NULL DEFAULT 1,
 				UNIQUE KEY STS_ID_UNIQUE (STS_ID),
 				KEY STS_type (STS_type)";
-        $this->_table_has_not_changed_since_previous($table_name, $sql);
+		$this->_table_has_not_changed_since_previous($table_name, $sql);
 
-        $table_name = 'esp_transaction';
-        $sql        = "TXN_ID int(10) unsigned NOT NULL AUTO_INCREMENT,
+		$table_name = 'esp_transaction';
+		$sql        = "TXN_ID int(10) unsigned NOT NULL AUTO_INCREMENT,
 				TXN_timestamp datetime NOT NULL DEFAULT '0000-00-00 00:00:00',
 				TXN_total decimal(12,3) DEFAULT '0.00',
 				TXN_paid decimal(12,3) NOT NULL DEFAULT '0.00',
@@ -524,10 +524,10 @@ 
 				PRIMARY KEY  (TXN_ID),
 				KEY TXN_timestamp (TXN_timestamp),
 				KEY STS_ID (STS_ID)";
-        $this->_table_is_changed_in_this_version($table_name, $sql);
+		$this->_table_is_changed_in_this_version($table_name, $sql);
 
-        $table_name = 'esp_venue_meta';
-        $sql        = "VNUM_ID int(11) NOT NULL AUTO_INCREMENT,
+		$table_name = 'esp_venue_meta';
+		$sql        = "VNUM_ID int(11) NOT NULL AUTO_INCREMENT,
 			VNU_ID bigint(20) unsigned NOT NULL DEFAULT 0,
 			VNU_address varchar(255) DEFAULT NULL,
 			VNU_address2 varchar(255) DEFAULT NULL,
@@ -546,10 +546,10 @@ 
 			KEY VNU_ID (VNU_ID),
 			KEY STA_ID (STA_ID),
 			KEY CNT_ISO (CNT_ISO)";
-        $this->_table_has_not_changed_since_previous($table_name, $sql);
-        // modified tables
-        $table_name = "esp_price";
-        $sql        = "PRC_ID int(10) unsigned NOT NULL AUTO_INCREMENT,
+		$this->_table_has_not_changed_since_previous($table_name, $sql);
+		// modified tables
+		$table_name = "esp_price";
+		$sql        = "PRC_ID int(10) unsigned NOT NULL AUTO_INCREMENT,
 				PRT_ID tinyint(3) unsigned NOT NULL,
 				PRC_amount decimal(12,3) NOT NULL DEFAULT '0.00',
 				PRC_name varchar(245) NOT NULL,
@@ -562,10 +562,10 @@ 
 				PRC_parent int(10) unsigned DEFAULT 0,
 				PRIMARY KEY  (PRC_ID),
 				KEY PRT_ID (PRT_ID)";
-        $this->_table_is_changed_in_this_version($table_name, $sql);
+		$this->_table_is_changed_in_this_version($table_name, $sql);
 
-        $table_name = "esp_price_type";
-        $sql        = "PRT_ID tinyint(3) unsigned NOT NULL AUTO_INCREMENT,
+		$table_name = "esp_price_type";
+		$sql        = "PRT_ID tinyint(3) unsigned NOT NULL AUTO_INCREMENT,
 				PRT_name varchar(45) NOT NULL,
 				PBT_ID tinyint(3) unsigned NOT NULL DEFAULT '1',
 				PRT_is_percent tinyint(1) NOT NULL DEFAULT '0',
@@ -574,10 +574,10 @@ 
 				PRT_deleted tinyint(1) NOT NULL DEFAULT '0',
 				UNIQUE KEY PRT_name_UNIQUE (PRT_name),
 				PRIMARY KEY  (PRT_ID)";
-        $this->_table_has_not_changed_since_previous($table_name, $sql);
+		$this->_table_has_not_changed_since_previous($table_name, $sql);
 
-        $table_name = "esp_ticket";
-        $sql        = "TKT_ID int(10) unsigned NOT NULL AUTO_INCREMENT,
+		$table_name = "esp_ticket";
+		$sql        = "TKT_ID int(10) unsigned NOT NULL AUTO_INCREMENT,
 				TTM_ID int(10) unsigned NOT NULL,
 				TKT_name varchar(245) NOT NULL DEFAULT '',
 				TKT_description text NOT NULL,
@@ -600,10 +600,10 @@ 
 				TKT_deleted tinyint(1) NOT NULL DEFAULT '0',
 				PRIMARY KEY  (TKT_ID),
 				KEY TKT_start_date (TKT_start_date)";
-        $this->_table_is_changed_in_this_version($table_name, $sql);
+		$this->_table_is_changed_in_this_version($table_name, $sql);
 
-        $table_name = 'esp_question_group';
-        $sql        = 'QSG_ID int(10) unsigned NOT NULL AUTO_INCREMENT,
+		$table_name = 'esp_question_group';
+		$sql        = 'QSG_ID int(10) unsigned NOT NULL AUTO_INCREMENT,
 				QSG_name varchar(255) NOT NULL,
 				QSG_identifier varchar(100) NOT NULL,
 				QSG_desc text NULL,
@@ -616,169 +616,169 @@ 
 				PRIMARY KEY  (QSG_ID),
 				UNIQUE KEY QSG_identifier_UNIQUE (QSG_identifier),
 				KEY QSG_order (QSG_order)';
-        $this->_table_has_not_changed_since_previous($table_name, $sql);
-        $this->insert_default_data();
-        return true;
-    }
-
-
-    /**
-     * Inserts default data after parent was called.
-     *
-     * @throws EE_Error
-     * @throws InvalidArgumentException
-     * @throws ReflectionException
-     * @throws InvalidDataTypeException
-     * @throws InvalidInterfaceException
-     * @since 4.10.0.p
-     */
-    public function insert_default_data()
-    {
-        /** @var EE_DMS_Core_4_1_0 $script_4_1_defaults */
-        $script_4_1_defaults = EE_Registry::instance()->load_dms('Core_4_1_0');
-        // (because many need to convert old string states to foreign keys into the states table)
-        $script_4_1_defaults->insert_default_states();
-        $script_4_1_defaults->insert_default_countries();
-        /** @var EE_DMS_Core_4_5_0 $script_4_5_defaults */
-        $script_4_5_defaults = EE_Registry::instance()->load_dms('Core_4_5_0');
-        $script_4_5_defaults->insert_default_price_types();
-        $script_4_5_defaults->insert_default_prices();
-        $script_4_5_defaults->insert_default_tickets();
-        /** @var EE_DMS_Core_4_6_0 $script_4_6_defaults */
-        $script_4_6_defaults = EE_Registry::instance()->load_dms('Core_4_6_0');
-        $script_4_6_defaults->add_default_admin_only_payments();
-        $script_4_6_defaults->insert_default_currencies();
-        /** @var EE_DMS_Core_4_8_0 $script_4_8_defaults */
-        $script_4_8_defaults = EE_Registry::instance()->load_dms('Core_4_8_0');
-        $script_4_8_defaults->verify_new_countries();
-        $script_4_8_defaults->verify_new_currencies();
-        $this->verify_db_collations();
-        $this->verify_db_collations_again();
-    }
-
-
-    /**
-     * @return boolean
-     */
-    public function schema_changes_after_migration()
-    {
-        return true;
-    }
-
-
-    public function migration_page_hooks()
-    {
-    }
-
-
-    /**
-     * Verify all EE4 models' tables use utf8mb4 collation
-     *
-     * @return void
-     */
-    public function verify_db_collations()
-    {
-        global $wpdb;
-        // double-check we haven't already done it or that that the DB doesn't support utf8mb4
-        if (
-            'utf8mb4' !== $wpdb->charset || get_option('ee_verified_db_collations', false)
-        ) {
-            return;
-        }
-        // grab tables from each model
-        $tables_to_check = [];
-        foreach (EE_Registry::instance()->non_abstract_db_models as $model_name) {
-            if (method_exists($model_name, 'instance')) {
-                $model_obj = call_user_func([$model_name, 'instance']);
-                if ($model_obj instanceof EEM_Base) {
-                    foreach ($model_obj->get_tables() as $table) {
-                        if (
-                            strpos($table->get_table_name(), 'esp_') &&
-                            (is_main_site()
-                             // for main tables, verify global tables
-                             ||
-                             ! $table->is_global(
-                             )// if not the main site, then only verify non-global tables (avoid doubling up)
-                            ) &&
-                            function_exists('maybe_convert_table_to_utf8mb4')
-                        ) {
-                            $tables_to_check[] = $table->get_table_name();
-                        }
-                    }
-                }
-            }
-        }
-        // and let's just be sure these addons' tables get migrated too. They already get handled if their addons are active
-        // when this code is run, but not otherwise. Once we record what tables EE added, we'll be able to use that instead
-        // of hard-coding this
-        $addon_tables = [
-            // mailchimp
-            'esp_event_mailchimp_list_group',
-            'esp_event_question_mailchimp_field',
-            // multisite
-            'esp_blog_meta',
-            // people
-            'esp_people_to_post',
-            // promotions
-            'esp_promotion',
-            'esp_promotion_object',
-        ];
-        foreach ($addon_tables as $table_name) {
-            $tables_to_check[] = $table_name;
-        }
-        $this->_verify_db_collations_for_tables(array_unique($tables_to_check));
-        // ok and now let's remember this was done (without needing to check the db schemas all over again)
-        add_option('ee_verified_db_collations', true, null, 'no');
-        // seeing how this ran with the fix from 10435, no need to check again
-        add_option('ee_verified_db_collations_again', true, null, 'no');
-    }
-
-
-    /**
-     * Verifies DB collations because a bug was discovered on
-     * https://events.codebasehq.com/projects/event-espresso/tickets/10435 which meant some DB collations might not
-     * have been updated
-     *
-     * @return void
-     */
-    public function verify_db_collations_again()
-    {
-        global $wpdb;
-        // double-check we haven't already done this or that the DB doesn't support it
-        // compare to how WordPress' upgrade_430() function does this check
-        if (
-            'utf8mb4' !== $wpdb->charset || get_option('ee_verified_db_collations_again', false)
-        ) {
-            return;
-        }
-        $tables_to_check = [
-            'esp_attendee_meta',
-            'esp_message',
-        ];
-        $this->_verify_db_collations_for_tables(array_unique($tables_to_check));
-        add_option('ee_verified_db_collations_again', true, null, 'no');
-    }
-
-
-    /**
-     * Runs maybe_convert_table_to_utf8mb4 on the specified tables
-     *
-     * @param $tables_to_check
-     * @return boolean true if logic ran, false if it didn't
-     */
-    protected function _verify_db_collations_for_tables($tables_to_check)
-    {
-        foreach ($tables_to_check as $table_name) {
-            $table_name = $this->_table_analysis->ensureTableNameHasPrefix($table_name);
-            if (
-                ! apply_filters(
-                    'FHEE__EE_DMS_Core_4_9_0__verify_db_collations__check_overridden',
-                    false,
-                    $table_name
-                ) && $this->_get_table_analysis()->tableExists($table_name)
-            ) {
-                maybe_convert_table_to_utf8mb4($table_name);
-            }
-        }
-    }
+		$this->_table_has_not_changed_since_previous($table_name, $sql);
+		$this->insert_default_data();
+		return true;
+	}
+
+
+	/**
+	 * Inserts default data after parent was called.
+	 *
+	 * @throws EE_Error
+	 * @throws InvalidArgumentException
+	 * @throws ReflectionException
+	 * @throws InvalidDataTypeException
+	 * @throws InvalidInterfaceException
+	 * @since 4.10.0.p
+	 */
+	public function insert_default_data()
+	{
+		/** @var EE_DMS_Core_4_1_0 $script_4_1_defaults */
+		$script_4_1_defaults = EE_Registry::instance()->load_dms('Core_4_1_0');
+		// (because many need to convert old string states to foreign keys into the states table)
+		$script_4_1_defaults->insert_default_states();
+		$script_4_1_defaults->insert_default_countries();
+		/** @var EE_DMS_Core_4_5_0 $script_4_5_defaults */
+		$script_4_5_defaults = EE_Registry::instance()->load_dms('Core_4_5_0');
+		$script_4_5_defaults->insert_default_price_types();
+		$script_4_5_defaults->insert_default_prices();
+		$script_4_5_defaults->insert_default_tickets();
+		/** @var EE_DMS_Core_4_6_0 $script_4_6_defaults */
+		$script_4_6_defaults = EE_Registry::instance()->load_dms('Core_4_6_0');
+		$script_4_6_defaults->add_default_admin_only_payments();
+		$script_4_6_defaults->insert_default_currencies();
+		/** @var EE_DMS_Core_4_8_0 $script_4_8_defaults */
+		$script_4_8_defaults = EE_Registry::instance()->load_dms('Core_4_8_0');
+		$script_4_8_defaults->verify_new_countries();
+		$script_4_8_defaults->verify_new_currencies();
+		$this->verify_db_collations();
+		$this->verify_db_collations_again();
+	}
+
+
+	/**
+	 * @return boolean
+	 */
+	public function schema_changes_after_migration()
+	{
+		return true;
+	}
+
+
+	public function migration_page_hooks()
+	{
+	}
+
+
+	/**
+	 * Verify all EE4 models' tables use utf8mb4 collation
+	 *
+	 * @return void
+	 */
+	public function verify_db_collations()
+	{
+		global $wpdb;
+		// double-check we haven't already done it or that that the DB doesn't support utf8mb4
+		if (
+			'utf8mb4' !== $wpdb->charset || get_option('ee_verified_db_collations', false)
+		) {
+			return;
+		}
+		// grab tables from each model
+		$tables_to_check = [];
+		foreach (EE_Registry::instance()->non_abstract_db_models as $model_name) {
+			if (method_exists($model_name, 'instance')) {
+				$model_obj = call_user_func([$model_name, 'instance']);
+				if ($model_obj instanceof EEM_Base) {
+					foreach ($model_obj->get_tables() as $table) {
+						if (
+							strpos($table->get_table_name(), 'esp_') &&
+							(is_main_site()
+							 // for main tables, verify global tables
+							 ||
+							 ! $table->is_global(
+							 )// if not the main site, then only verify non-global tables (avoid doubling up)
+							) &&
+							function_exists('maybe_convert_table_to_utf8mb4')
+						) {
+							$tables_to_check[] = $table->get_table_name();
+						}
+					}
+				}
+			}
+		}
+		// and let's just be sure these addons' tables get migrated too. They already get handled if their addons are active
+		// when this code is run, but not otherwise. Once we record what tables EE added, we'll be able to use that instead
+		// of hard-coding this
+		$addon_tables = [
+			// mailchimp
+			'esp_event_mailchimp_list_group',
+			'esp_event_question_mailchimp_field',
+			// multisite
+			'esp_blog_meta',
+			// people
+			'esp_people_to_post',
+			// promotions
+			'esp_promotion',
+			'esp_promotion_object',
+		];
+		foreach ($addon_tables as $table_name) {
+			$tables_to_check[] = $table_name;
+		}
+		$this->_verify_db_collations_for_tables(array_unique($tables_to_check));
+		// ok and now let's remember this was done (without needing to check the db schemas all over again)
+		add_option('ee_verified_db_collations', true, null, 'no');
+		// seeing how this ran with the fix from 10435, no need to check again
+		add_option('ee_verified_db_collations_again', true, null, 'no');
+	}
+
+
+	/**
+	 * Verifies DB collations because a bug was discovered on
+	 * https://events.codebasehq.com/projects/event-espresso/tickets/10435 which meant some DB collations might not
+	 * have been updated
+	 *
+	 * @return void
+	 */
+	public function verify_db_collations_again()
+	{
+		global $wpdb;
+		// double-check we haven't already done this or that the DB doesn't support it
+		// compare to how WordPress' upgrade_430() function does this check
+		if (
+			'utf8mb4' !== $wpdb->charset || get_option('ee_verified_db_collations_again', false)
+		) {
+			return;
+		}
+		$tables_to_check = [
+			'esp_attendee_meta',
+			'esp_message',
+		];
+		$this->_verify_db_collations_for_tables(array_unique($tables_to_check));
+		add_option('ee_verified_db_collations_again', true, null, 'no');
+	}
+
+
+	/**
+	 * Runs maybe_convert_table_to_utf8mb4 on the specified tables
+	 *
+	 * @param $tables_to_check
+	 * @return boolean true if logic ran, false if it didn't
+	 */
+	protected function _verify_db_collations_for_tables($tables_to_check)
+	{
+		foreach ($tables_to_check as $table_name) {
+			$table_name = $this->_table_analysis->ensureTableNameHasPrefix($table_name);
+			if (
+				! apply_filters(
+					'FHEE__EE_DMS_Core_4_9_0__verify_db_collations__check_overridden',
+					false,
+					$table_name
+				) && $this->_get_table_analysis()->tableExists($table_name)
+			) {
+				maybe_convert_table_to_utf8mb4($table_name);
+			}
+		}
+	}
 }

Spacing +5 added lines, -5 removed lines

@@ -9,12 +9,12 @@ 
 // unfortunately, this needs to be done upon INCLUSION of this file,
 // instead of construction, because it only gets constructed on first page load
 // (all other times it gets resurrected from a wordpress option)
-$stages            = glob(EE_CORE . 'data_migration_scripts/4_9_0_stages/*');
+$stages            = glob(EE_CORE.'data_migration_scripts/4_9_0_stages/*');
 $class_to_filepath = [];
 foreach ($stages as $filepath) {
     $matches = [];
     preg_match('~4_9_0_stages/(.*).dmsstage.php~', $filepath, $matches);
-    $class_to_filepath[ $matches[1] ] = $filepath;
+    $class_to_filepath[$matches[1]] = $filepath;
 }
 // give addons a chance to autoload their stages too
 $class_to_filepath = apply_filters('FHEE__EE_DMS_4_9_0__autoloaded_stages', $class_to_filepath);
@@ -66,10 +66,10 @@ 
         ) {
             //          echo "$version_string can be migrated from";
             return true;
-        } elseif (! $version_string) {
+        } elseif ( ! $version_string) {
             //          echo "no version string provided: $version_string";
             // no version string provided... this must be pre 4.3
-            return false;// changed mind. dont want people thinking they should migrate yet because they cant
+            return false; // changed mind. dont want people thinking they should migrate yet because they cant
         } else {
             //          echo "$version_string doesnt apply";
             return false;
@@ -84,7 +84,7 @@ 
      */
     public function schema_changes_before_migration()
     {
-        require_once(EE_HELPERS . 'EEH_Activation.helper.php');
+        require_once(EE_HELPERS.'EEH_Activation.helper.php');
         $now_in_mysql = current_time('mysql', true);
 
         $table_name   = 'esp_answer';

core/data_migration_scripts/EE_DMS_Core_4_2_0.dms.php

Indentation +167 added lines, -167 removed lines

@@ -10,11 +10,11 @@ 
 $stages            = glob(EE_CORE . 'data_migration_scripts/4_2_0_stages/*');
 $class_to_filepath = [];
 if (! empty($stages)) {
-    foreach ($stages as $filepath) {
-        $matches = [];
-        preg_match('~4_2_0_stages/(.*).dmsstage.php~', $filepath, $matches);
-        $class_to_filepath[ $matches[1] ] = $filepath;
-    }
+	foreach ($stages as $filepath) {
+		$matches = [];
+		preg_match('~4_2_0_stages/(.*).dmsstage.php~', $filepath, $matches);
+		$class_to_filepath[ $matches[1] ] = $filepath;
+	}
 }
 // give addons a chance to autoload their stages too
 $class_to_filepath = apply_filters('FHEE__EE_DMS_4_2_0__autoloaded_stages', $class_to_filepath);
@@ -33,64 +33,64 @@ 
 class EE_DMS_Core_4_2_0 extends EE_Data_Migration_Script_Base
 {
 
-    /**
-     * EE_DMS_Core_4_2_0 constructor.
-     *
-     * @param TableManager|null  $table_manager
-     * @param TableAnalysis|null $table_analysis
-     */
-    public function __construct(TableManager $table_manager = null, TableAnalysis $table_analysis = null)
-    {
-        $this->_pretty_name      = esc_html__("Data Update to Event Espresso 4.2.0", "event_espresso");
-        $this->_priority         = 10;
-        $this->_migration_stages = [
-            new EE_DMS_4_2_0_question_group_questions(),
-            new EE_DMS_4_2_0_datetime_fields(),
-        ];
-        parent::__construct($table_manager, $table_analysis);
-    }
-
-
-    public function can_migrate_from_version($version_array)
-    {
-        $version_string = $version_array['Core'];
-        if (
-            version_compare($version_string, '4.2.0.decaf', '<') &&
-            version_compare($version_string, '4.1.0.decaf', '>=')
-        ) {
-            //          echo "$version_string can be migrated fro";
-            return true;
-        } elseif (! $version_string) {
-            //          echo "no version string provided: $version_string";
-            // no version string provided... this must be pre 4.1
-            // because since 4.1 we're
-            return false;// changed mind. dont want people thinking they should migrate yet because they cant
-        } else {
-            //          echo "$version_string doesnt apply";
-            return false;
-        }
-    }
-
-
-    /**
-     * @throws EE_Error
-     * @throws ReflectionException
-     */
-    public function schema_changes_before_migration()
-    {
-        // relies on 4.1's EEH_Activation::create_table
-        require_once(EE_HELPERS . 'EEH_Activation.helper.php');
-
-        $table_name = 'esp_answer';
-        $sql        = "ANS_ID int(10) unsigned NOT NULL AUTO_INCREMENT,
+	/**
+	 * EE_DMS_Core_4_2_0 constructor.
+	 *
+	 * @param TableManager|null  $table_manager
+	 * @param TableAnalysis|null $table_analysis
+	 */
+	public function __construct(TableManager $table_manager = null, TableAnalysis $table_analysis = null)
+	{
+		$this->_pretty_name      = esc_html__("Data Update to Event Espresso 4.2.0", "event_espresso");
+		$this->_priority         = 10;
+		$this->_migration_stages = [
+			new EE_DMS_4_2_0_question_group_questions(),
+			new EE_DMS_4_2_0_datetime_fields(),
+		];
+		parent::__construct($table_manager, $table_analysis);
+	}
+
+
+	public function can_migrate_from_version($version_array)
+	{
+		$version_string = $version_array['Core'];
+		if (
+			version_compare($version_string, '4.2.0.decaf', '<') &&
+			version_compare($version_string, '4.1.0.decaf', '>=')
+		) {
+			//          echo "$version_string can be migrated fro";
+			return true;
+		} elseif (! $version_string) {
+			//          echo "no version string provided: $version_string";
+			// no version string provided... this must be pre 4.1
+			// because since 4.1 we're
+			return false;// changed mind. dont want people thinking they should migrate yet because they cant
+		} else {
+			//          echo "$version_string doesnt apply";
+			return false;
+		}
+	}
+
+
+	/**
+	 * @throws EE_Error
+	 * @throws ReflectionException
+	 */
+	public function schema_changes_before_migration()
+	{
+		// relies on 4.1's EEH_Activation::create_table
+		require_once(EE_HELPERS . 'EEH_Activation.helper.php');
+
+		$table_name = 'esp_answer';
+		$sql        = "ANS_ID int(10) unsigned NOT NULL AUTO_INCREMENT,
 					REG_ID int(10) unsigned NOT NULL,
 					QST_ID int(10) unsigned NOT NULL,
 					ANS_value text NOT NULL,
 					PRIMARY KEY  (ANS_ID)";
-        $this->_table_should_exist_previously($table_name, $sql);
+		$this->_table_should_exist_previously($table_name, $sql);
 
-        $table_name = 'esp_attendee_meta';
-        $sql        = "ATTM_ID int(10) unsigned NOT	NULL AUTO_INCREMENT,
+		$table_name = 'esp_attendee_meta';
+		$sql        = "ATTM_ID int(10) unsigned NOT	NULL AUTO_INCREMENT,
 						ATT_ID bigint(20) unsigned NOT NULL,
 						ATT_fname varchar(45) NOT NULL,
 						ATT_lname varchar(45) NOT	NULL,
@@ -106,10 +106,10 @@ 
 								KEY ATT_fname (ATT_fname),
 								KEY ATT_lname (ATT_lname),
 								KEY ATT_email (ATT_email(191))";
-        $this->_table_should_exist_previously($table_name, $sql, 'ENGINE=InnoDB');
+		$this->_table_should_exist_previously($table_name, $sql, 'ENGINE=InnoDB');
 
-        $table_name = 'esp_country';
-        $sql        = "CNT_ISO varchar(2) COLLATE utf8_bin NOT NULL,
+		$table_name = 'esp_country';
+		$sql        = "CNT_ISO varchar(2) COLLATE utf8_bin NOT NULL,
 					  CNT_ISO3 varchar(3) COLLATE utf8_bin NOT NULL,
 					  RGN_ID tinyint(3) unsigned DEFAULT NULL,
 					  CNT_name varchar(45) COLLATE utf8_bin NOT NULL,
@@ -125,10 +125,10 @@ 
 					  CNT_is_EU tinyint(1) DEFAULT '0',
 					  CNT_active tinyint(1) DEFAULT '0',
 					  PRIMARY KEY  (CNT_ISO)";
-        $this->_table_should_exist_previously($table_name, $sql);
+		$this->_table_should_exist_previously($table_name, $sql);
 
-        $table_name = 'esp_datetime';
-        $sql        = "DTT_ID int(10) unsigned NOT NULL AUTO_INCREMENT,
+		$table_name = 'esp_datetime';
+		$sql        = "DTT_ID int(10) unsigned NOT NULL AUTO_INCREMENT,
 				  EVT_ID bigint(20) unsigned NOT NULL,
 				  DTT_name varchar(255) NOT NULL DEFAULT '',
 				  DTT_description text NOT NULL,
@@ -143,10 +143,10 @@ 
 						PRIMARY KEY  (DTT_ID),
 						KEY EVT_ID (EVT_ID),
 						KEY DTT_is_primary (DTT_is_primary)";
-        $this->_table_should_exist_previously($table_name, $sql);
+		$this->_table_should_exist_previously($table_name, $sql);
 
-        $table_name = 'esp_event_meta';
-        $sql        = "
+		$table_name = 'esp_event_meta';
+		$sql        = "
 			EVTM_ID int(10) NOT NULL AUTO_INCREMENT,
 			EVT_ID bigint(20) unsigned NOT NULL,
 			EVT_display_desc tinyint(1) unsigned NOT NULL DEFAULT 1,
@@ -161,35 +161,35 @@ 
 			EVT_external_URL varchar(200) NULL,
 			EVT_donations tinyint(1) NULL,
 			PRIMARY KEY  (EVTM_ID)";
-        $this->_table_should_exist_previously($table_name, $sql);
+		$this->_table_should_exist_previously($table_name, $sql);
 
-        $table_name = 'esp_event_question_group';
-        $sql        = "EQG_ID int(10) unsigned NOT NULL AUTO_INCREMENT,
+		$table_name = 'esp_event_question_group';
+		$sql        = "EQG_ID int(10) unsigned NOT NULL AUTO_INCREMENT,
 					EVT_ID bigint(20) unsigned NOT NULL,
 					QSG_ID int(10) unsigned NOT NULL,
 					EQG_primary tinyint(1) unsigned NOT NULL DEFAULT 0,
 					PRIMARY KEY  (EQG_ID)";
-        $this->_table_should_exist_previously($table_name, $sql);
+		$this->_table_should_exist_previously($table_name, $sql);
 
-        $table_name = 'esp_event_venue';
-        $sql        = "EVV_ID int(11) NOT NULL AUTO_INCREMENT,
+		$table_name = 'esp_event_venue';
+		$sql        = "EVV_ID int(11) NOT NULL AUTO_INCREMENT,
 				EVT_ID bigint(20) unsigned NOT NULL,
 				VNU_ID bigint(20) unsigned NOT NULL,
 				EVV_primary tinyint(1) unsigned NOT NULL DEFAULT 0,
 				PRIMARY KEY  (EVV_ID)";
-        $this->_table_should_exist_previously($table_name, $sql);
+		$this->_table_should_exist_previously($table_name, $sql);
 
-        $table_name = 'esp_extra_meta';
-        $sql        = "EXM_ID int(11) NOT NULL AUTO_INCREMENT,
+		$table_name = 'esp_extra_meta';
+		$sql        = "EXM_ID int(11) NOT NULL AUTO_INCREMENT,
 				OBJ_ID int(11) DEFAULT NULL,
 				EXM_type varchar(45) DEFAULT NULL,
 				EXM_key varchar(45) DEFAULT NULL,
 				EXM_value text,
 				PRIMARY KEY  (EXM_ID)";
-        $this->_table_should_exist_previously($table_name, $sql);
+		$this->_table_should_exist_previously($table_name, $sql);
 
-        $table_name = 'esp_line_item';
-        $sql        = "LIN_ID int(11) NOT NULL AUTO_INCREMENT,
+		$table_name = 'esp_line_item';
+		$sql        = "LIN_ID int(11) NOT NULL AUTO_INCREMENT,
 				LIN_code varchar(245) NOT NULL DEFAULT '',
 				TXN_ID int(11) DEFAULT NULL,
 				LIN_name varchar(245) NOT NULL DEFAULT '',
@@ -205,20 +205,20 @@ 
 				OBJ_ID int(11) DEFAULT NULL,
 				OBJ_type varchar(45)DEFAULT NULL,
 				PRIMARY KEY  (LIN_ID)";
-        $this->_table_should_exist_previously($table_name, $sql);
+		$this->_table_should_exist_previously($table_name, $sql);
 
-        $table_name = 'esp_message_template';
-        $sql        = "MTP_ID int(10) unsigned NOT NULL AUTO_INCREMENT,
+		$table_name = 'esp_message_template';
+		$sql        = "MTP_ID int(10) unsigned NOT NULL AUTO_INCREMENT,
 					GRP_ID int(10) unsigned NOT NULL,
 					MTP_context varchar(50) NOT NULL,
 					MTP_template_field varchar(30) NOT NULL,
 					MTP_content text NOT NULL,
 					PRIMARY KEY  (MTP_ID),
 					KEY GRP_ID (GRP_ID)";
-        $this->_table_should_exist_previously($table_name, $sql);
+		$this->_table_should_exist_previously($table_name, $sql);
 
-        $table_name = 'esp_message_template_group';
-        $sql        = "GRP_ID int(10) unsigned NOT NULL AUTO_INCREMENT,
+		$table_name = 'esp_message_template_group';
+		$sql        = "GRP_ID int(10) unsigned NOT NULL AUTO_INCREMENT,
 					EVT_ID bigint(20) unsigned DEFAULT NULL,
 					MTP_user_id int(10) NOT NULL DEFAULT '1',
 					MTP_messenger varchar(30) NOT NULL,
@@ -230,10 +230,10 @@ 
 					PRIMARY KEY  (GRP_ID),
 					KEY EVT_ID (EVT_ID),
 					KEY MTP_user_id (MTP_user_id)";
-        $this->_table_should_exist_previously($table_name, $sql);
+		$this->_table_should_exist_previously($table_name, $sql);
 
-        $table_name = 'esp_payment';
-        $sql        = "PAY_ID int(10) unsigned NOT NULL AUTO_INCREMENT,
+		$table_name = 'esp_payment';
+		$sql        = "PAY_ID int(10) unsigned NOT NULL AUTO_INCREMENT,
 					TXN_ID int(10) unsigned DEFAULT NULL,
 					STS_ID varchar(3) COLLATE utf8_bin DEFAULT NULL,
 					PAY_timestamp datetime NOT NULL DEFAULT '0000-00-00 00:00:00',
@@ -249,10 +249,10 @@ 
 					PRIMARY KEY  (PAY_ID),
 					KEY TXN_ID (TXN_ID),
 					KEY PAY_timestamp (PAY_timestamp)";
-        $this->_table_should_exist_previously($table_name, $sql, 'ENGINE=InnoDB');
+		$this->_table_should_exist_previously($table_name, $sql, 'ENGINE=InnoDB');
 
-        $table_name = "esp_ticket";
-        $sql        = "TKT_ID int(10) unsigned NOT NULL AUTO_INCREMENT,
+		$table_name = "esp_ticket";
+		$sql        = "TKT_ID int(10) unsigned NOT NULL AUTO_INCREMENT,
 					  TTM_ID int(10) unsigned NOT NULL,
 					  TKT_name varchar(245) NOT NULL DEFAULT '',
 					  TKT_description text NOT NULL,
@@ -271,32 +271,32 @@ 
 					  TKT_parent int(10) unsigned DEFAULT '0',
 					  TKT_deleted tinyint(1) NOT NULL DEFAULT '0',
 					  PRIMARY KEY  (TKT_ID)";
-        $this->_table_should_exist_previously($table_name, $sql);
+		$this->_table_should_exist_previously($table_name, $sql);
 
-        $table_name = "esp_ticket_price";
-        $sql        = "TKP_ID int(10) unsigned NOT NULL AUTO_INCREMENT,
+		$table_name = "esp_ticket_price";
+		$sql        = "TKP_ID int(10) unsigned NOT NULL AUTO_INCREMENT,
 					  TKT_ID int(10) unsigned NOT NULL,
 					  PRC_ID int(10) unsigned NOT NULL,
 					  PRIMARY KEY  (TKP_ID)";
-        $this->_table_should_exist_previously($table_name, $sql);
+		$this->_table_should_exist_previously($table_name, $sql);
 
-        $table_name = "esp_datetime_ticket";
-        $sql        = "DTK_ID int(10) unsigned NOT NULL AUTO_INCREMENT,
+		$table_name = "esp_datetime_ticket";
+		$sql        = "DTK_ID int(10) unsigned NOT NULL AUTO_INCREMENT,
 					  DTT_ID int(10) unsigned NOT NULL,
 					  TKT_ID int(10) unsigned NOT NULL,
 					  PRIMARY KEY  (DTK_ID)";
-        $this->_table_should_exist_previously($table_name, $sql);
+		$this->_table_should_exist_previously($table_name, $sql);
 
-        $table_name = "esp_ticket_template";
-        $sql        = "TTM_ID int(10) unsigned NOT NULL AUTO_INCREMENT,
+		$table_name = "esp_ticket_template";
+		$sql        = "TTM_ID int(10) unsigned NOT NULL AUTO_INCREMENT,
 					  TTM_name varchar(45) NOT NULL,
 					  TTM_description text,
 					  TTM_file varchar(45),
 					  PRIMARY KEY  (TTM_ID)";
-        $this->_table_should_exist_previously($table_name, $sql);
+		$this->_table_should_exist_previously($table_name, $sql);
 
-        $table_name = "esp_price";
-        $sql        = "PRC_ID int(10) unsigned NOT NULL AUTO_INCREMENT,
+		$table_name = "esp_price";
+		$sql        = "PRC_ID int(10) unsigned NOT NULL AUTO_INCREMENT,
 					  PRT_ID tinyint(3) unsigned NOT NULL,
 					  PRC_amount decimal(10,3) NOT NULL DEFAULT '0.00',
 					  PRC_name varchar(245) NOT NULL,
@@ -307,10 +307,10 @@ 
 					  PRC_order tinyint(3) unsigned NOT NULL DEFAULT '0',
 					  PRC_parent int(10) unsigned DEFAULT 0,
 					  PRIMARY KEY  (PRC_ID)";
-        $this->_table_should_exist_previously($table_name, $sql);
+		$this->_table_should_exist_previously($table_name, $sql);
 
-        $table_name = "esp_price_type";
-        $sql        = "PRT_ID tinyint(3) unsigned NOT NULL AUTO_INCREMENT,
+		$table_name = "esp_price_type";
+		$sql        = "PRT_ID tinyint(3) unsigned NOT NULL AUTO_INCREMENT,
 				  PRT_name varchar(45) NOT NULL,
 				  PBT_ID tinyint(3) unsigned NOT NULL DEFAULT '1',
 				  PRT_is_percent tinyint(1) NOT NULL DEFAULT '0',
@@ -318,10 +318,10 @@ 
 				  PRT_deleted tinyint(1) NOT NULL DEFAULT '0',
 				  UNIQUE KEY PRT_name_UNIQUE (PRT_name),
 				  PRIMARY KEY  (PRT_ID)";
-        $this->_table_should_exist_previously($table_name, $sql);
+		$this->_table_should_exist_previously($table_name, $sql);
 
-        $table_name = 'esp_question';
-        $sql        = 'QST_ID int(10) unsigned NOT NULL AUTO_INCREMENT,
+		$table_name = 'esp_question';
+		$sql        = 'QST_ID int(10) unsigned NOT NULL AUTO_INCREMENT,
 					QST_display_text text NOT NULL,
 					QST_admin_label varchar(255) NOT NULL,
 					QST_system varchar(25) DEFAULT NULL,
@@ -333,11 +333,11 @@ 
 					QST_wp_user bigint(20) unsigned NULL,
 					QST_deleted tinyint(1) unsigned NOT NULL DEFAULT 0,
 					PRIMARY KEY  (QST_ID)';
-        $this->_table_should_exist_previously($table_name, $sql);
-        $this->_get_table_manager()->dropIndex('esp_question_group', 'QSG_identifier_UNIQUE');
+		$this->_table_should_exist_previously($table_name, $sql);
+		$this->_get_table_manager()->dropIndex('esp_question_group', 'QSG_identifier_UNIQUE');
 
-        $table_name = 'esp_question_group';
-        $sql        = 'QSG_ID int(10) unsigned NOT NULL AUTO_INCREMENT,
+		$table_name = 'esp_question_group';
+		$sql        = 'QSG_ID int(10) unsigned NOT NULL AUTO_INCREMENT,
 					QSG_name varchar(255) NOT NULL,
 					QSG_identifier varchar(100) NOT NULL,
 					QSG_desc text NULL,
@@ -348,27 +348,27 @@ 
 					QSG_deleted tinyint(1) unsigned NOT NULL DEFAULT 0,
 					PRIMARY KEY  (QSG_ID),
 					UNIQUE KEY QSG_identifier_UNIQUE (QSG_identifier ASC)';
-        $this->_table_should_exist_previously($table_name, $sql);
+		$this->_table_should_exist_previously($table_name, $sql);
 
-        $table_name = 'esp_question_group_question';
-        $sql        = "QGQ_ID int(10) unsigned NOT NULL AUTO_INCREMENT,
+		$table_name = 'esp_question_group_question';
+		$sql        = "QGQ_ID int(10) unsigned NOT NULL AUTO_INCREMENT,
 					QSG_ID int(10) unsigned NOT NULL,
 					QST_ID int(10) unsigned NOT NULL,
 					QGQ_order int(10) unsigned NOT NULL DEFAULT 0,
 					PRIMARY KEY  (QGQ_ID) ";
-        $this->_table_should_exist_previously($table_name, $sql);
+		$this->_table_should_exist_previously($table_name, $sql);
 
-        $table_name = 'esp_question_option';
-        $sql        = "QSO_ID int(10) unsigned NOT NULL AUTO_INCREMENT,
+		$table_name = 'esp_question_option';
+		$sql        = "QSO_ID int(10) unsigned NOT NULL AUTO_INCREMENT,
 					QSO_value varchar(255) NOT NULL,
 					QSO_desc text NOT NULL,
 					QST_ID int(10) unsigned NOT NULL,
 					QSO_deleted tinyint(1) unsigned NOT NULL DEFAULT 0,
 					PRIMARY KEY  (QSO_ID)";
-        $this->_table_should_exist_previously($table_name, $sql);
+		$this->_table_should_exist_previously($table_name, $sql);
 
-        $table_name = 'esp_registration';
-        $sql        = "REG_ID int(10) unsigned NOT NULL AUTO_INCREMENT,
+		$table_name = 'esp_registration';
+		$sql        = "REG_ID int(10) unsigned NOT NULL AUTO_INCREMENT,
 					  EVT_ID bigint(20) unsigned NOT NULL,
 					  ATT_ID bigint(20) unsigned NOT NULL,
 					  TXN_ID int(10) unsigned NOT NULL,
@@ -391,28 +391,28 @@ 
 					  KEY STS_ID (STS_ID),
 					  KEY REG_url_link (REG_url_link),
 					  KEY REG_code (REG_code)";
-        $this->_table_should_exist_previously($table_name, $sql, 'ENGINE=InnoDB');
+		$this->_table_should_exist_previously($table_name, $sql, 'ENGINE=InnoDB');
 
-        $table_name = 'esp_checkin';
-        $sql        = "CHK_ID int(10) unsigned NOT NULL AUTO_INCREMENT,
+		$table_name = 'esp_checkin';
+		$sql        = "CHK_ID int(10) unsigned NOT NULL AUTO_INCREMENT,
 					REG_ID int(10) unsigned NOT NULL,
 					DTT_ID int(10) unsigned NOT NULL,
 					CHK_in tinyint(1) unsigned NOT NULL DEFAULT 1,
 					CHK_timestamp datetime NOT NULL DEFAULT '0000-00-00 00:00:00',
 					PRIMARY KEY  (CHK_ID)";
-        $this->_table_should_exist_previously($table_name, $sql);
+		$this->_table_should_exist_previously($table_name, $sql);
 
-        $table_name = 'esp_state';
-        $sql        = "STA_ID smallint(5) unsigned NOT NULL AUTO_INCREMENT,
+		$table_name = 'esp_state';
+		$sql        = "STA_ID smallint(5) unsigned NOT NULL AUTO_INCREMENT,
 					  CNT_ISO varchar(2) COLLATE utf8_bin NOT NULL,
 					  STA_abbrev varchar(6) COLLATE utf8_bin NOT NULL,
 					  STA_name varchar(100) COLLATE utf8_bin NOT NULL,
 					  STA_active tinyint(1) DEFAULT '1',
 					  PRIMARY KEY  (STA_ID)";
-        $this->_table_should_exist_previously($table_name, $sql);
+		$this->_table_should_exist_previously($table_name, $sql);
 
-        $table_name = 'esp_status';
-        $sql        = "STS_ID varchar(3) COLLATE utf8_bin NOT NULL,
+		$table_name = 'esp_status';
+		$sql        = "STS_ID varchar(3) COLLATE utf8_bin NOT NULL,
 					  STS_code varchar(45) COLLATE utf8_bin NOT NULL,
 					  STS_type set('event','registration','transaction','payment','email') COLLATE utf8_bin NOT NULL,
 					  STS_can_edit tinyint(1) NOT NULL DEFAULT 0,
@@ -420,10 +420,10 @@ 
 					  STS_open tinyint(1) NOT NULL DEFAULT 1,
 					  UNIQUE KEY STS_ID_UNIQUE (STS_ID),
 					  KEY STS_type (STS_type)";
-        $this->_table_should_exist_previously($table_name, $sql);
+		$this->_table_should_exist_previously($table_name, $sql);
 
-        $table_name = 'esp_transaction';
-        $sql        = "TXN_ID int(10) unsigned NOT NULL AUTO_INCREMENT,
+		$table_name = 'esp_transaction';
+		$sql        = "TXN_ID int(10) unsigned NOT NULL AUTO_INCREMENT,
 					  TXN_timestamp datetime NOT NULL DEFAULT '0000-00-00 00:00:00',
 					  TXN_total decimal(10,3) DEFAULT '0.00',
 					  TXN_paid decimal(10,3) NOT NULL DEFAULT '0.00',
@@ -433,10 +433,10 @@ 
 					  PRIMARY KEY  (TXN_ID),
 					  KEY TXN_timestamp (TXN_timestamp),
 					  KEY STS_ID (STS_ID)";
-        $this->_table_should_exist_previously($table_name, $sql);
+		$this->_table_should_exist_previously($table_name, $sql);
 
-        $table_name = 'esp_venue_meta';
-        $sql        = "VNUM_ID int(11) NOT NULL AUTO_INCREMENT,
+		$table_name = 'esp_venue_meta';
+		$sql        = "VNUM_ID int(11) NOT NULL AUTO_INCREMENT,
 			VNU_ID bigint(20) unsigned NOT NULL DEFAULT 0,
 			VNU_address varchar(255) DEFAULT NULL,
 			VNU_address2 varchar(255) DEFAULT NULL,
@@ -454,34 +454,34 @@ 
 			PRIMARY KEY  (VNUM_ID),
 			KEY STA_ID (STA_ID),
 			KEY CNT_ISO (CNT_ISO)";
-        $this->_table_should_exist_previously($table_name, $sql);
-        $script_with_defaults = EE_Registry::instance()->load_dms('Core_4_1_0');
-        // setting up the DEFAULT stats and countries is also essential for the data migrations to run
-        // (because many need to convert old string states to foreign keys into the states table)
-        $script_with_defaults->insert_default_states();
-        $script_with_defaults->insert_default_countries();
-        // setting up DEFAULT prices, price types, and tickets is also essential for the price migrations
-        $script_with_defaults->insert_default_price_types();
-        $script_with_defaults->insert_default_prices();
-        $script_with_defaults->insert_default_tickets();
-        // setting up the config wp option pretty well counts as a 'schema change', or at least should happen here
-        EE_Config::instance()->update_espresso_config();
-        return true;
-    }
-
-
-    /**
-     * We COULD clean up the esp_question.QST_order field here. We'll leave it for now
-     *
-     * @return boolean
-     */
-    public function schema_changes_after_migration()
-    {
-        return true;
-    }
-
-
-    public function migration_page_hooks()
-    {
-    }
+		$this->_table_should_exist_previously($table_name, $sql);
+		$script_with_defaults = EE_Registry::instance()->load_dms('Core_4_1_0');
+		// setting up the DEFAULT stats and countries is also essential for the data migrations to run
+		// (because many need to convert old string states to foreign keys into the states table)
+		$script_with_defaults->insert_default_states();
+		$script_with_defaults->insert_default_countries();
+		// setting up DEFAULT prices, price types, and tickets is also essential for the price migrations
+		$script_with_defaults->insert_default_price_types();
+		$script_with_defaults->insert_default_prices();
+		$script_with_defaults->insert_default_tickets();
+		// setting up the config wp option pretty well counts as a 'schema change', or at least should happen here
+		EE_Config::instance()->update_espresso_config();
+		return true;
+	}
+
+
+	/**
+	 * We COULD clean up the esp_question.QST_order field here. We'll leave it for now
+	 *
+	 * @return boolean
+	 */
+	public function schema_changes_after_migration()
+	{
+		return true;
+	}
+
+
+	public function migration_page_hooks()
+	{
+	}
 }

Spacing +6 added lines, -6 removed lines

@@ -7,13 +7,13 @@ 
 // unfortunately, this needs to be done upon INCLUSION of this file,
 // instead of construction, because it only gets constructed on first page load
 // (all other times it gets resurrected from a wordpress option)
-$stages            = glob(EE_CORE . 'data_migration_scripts/4_2_0_stages/*');
+$stages            = glob(EE_CORE.'data_migration_scripts/4_2_0_stages/*');
 $class_to_filepath = [];
-if (! empty($stages)) {
+if ( ! empty($stages)) {
     foreach ($stages as $filepath) {
         $matches = [];
         preg_match('~4_2_0_stages/(.*).dmsstage.php~', $filepath, $matches);
-        $class_to_filepath[ $matches[1] ] = $filepath;
+        $class_to_filepath[$matches[1]] = $filepath;
     }
 }
 // give addons a chance to autoload their stages too
@@ -60,11 +60,11 @@ 
         ) {
             //          echo "$version_string can be migrated fro";
             return true;
-        } elseif (! $version_string) {
+        } elseif ( ! $version_string) {
             //          echo "no version string provided: $version_string";
             // no version string provided... this must be pre 4.1
             // because since 4.1 we're
-            return false;// changed mind. dont want people thinking they should migrate yet because they cant
+            return false; // changed mind. dont want people thinking they should migrate yet because they cant
         } else {
             //          echo "$version_string doesnt apply";
             return false;
@@ -79,7 +79,7 @@ 
     public function schema_changes_before_migration()
     {
         // relies on 4.1's EEH_Activation::create_table
-        require_once(EE_HELPERS . 'EEH_Activation.helper.php');
+        require_once(EE_HELPERS.'EEH_Activation.helper.php');
 
         $table_name = 'esp_answer';
         $sql        = "ANS_ID int(10) unsigned NOT NULL AUTO_INCREMENT,

core/data_migration_scripts/4_6_0_stages/EE_DMS_4_6_0_state_system_question.dmsstage.php

Indentation +40 added lines, -40 removed lines

@@ -10,46 +10,46 @@
 class EE_DMS_4_6_0_state_system_question extends EE_Data_Migration_Script_Stage_Table
 {
 
-    public function __construct()
-    {
-        global $wpdb;
-        $this->_pretty_name     = esc_html__('State - System Question', 'event_espresso');
-        $this->_old_table       = $wpdb->prefix . 'esp_question';
-        $this->_extra_where_sql = "WHERE QST_system = 'state'";
-        parent::__construct();
-    }
+	public function __construct()
+	{
+		global $wpdb;
+		$this->_pretty_name     = esc_html__('State - System Question', 'event_espresso');
+		$this->_old_table       = $wpdb->prefix . 'esp_question';
+		$this->_extra_where_sql = "WHERE QST_system = 'state'";
+		parent::__construct();
+	}
 
 
-    /**
-     * updates the question with the new question type
-     *
-     * @param array $old_row an associative array where keys are column names and values are their values.
-     * @return void
-     */
-    protected function _migrate_old_row($old_row)
-    {
-        if ($old_row['QST_ID'] && $old_row['QST_system'] == 'state') {
-            global $wpdb;
-            $success = $wpdb->update(
-                $this->_old_table,
-                ['QST_type' => 'STATE'],            // data
-                ['QST_ID' => $old_row['QST_ID']],  // where
-                ['%s'],                             // data format
-                ['%d']                              // where format
-            );
-            if (! $success) {
-                $this->add_error(
-                    sprintf(
-                        esc_html__(
-                            'Could not update question system name "%1$s" for question ID=%2$d because "%3$s"',
-                            'event_espresso'
-                        ),
-                        wp_json_encode($old_row['QST_system']),
-                        $old_row['QST_ID'],
-                        $wpdb->last_error
-                    )
-                );
-            }
-        }
-    }
+	/**
+	 * updates the question with the new question type
+	 *
+	 * @param array $old_row an associative array where keys are column names and values are their values.
+	 * @return void
+	 */
+	protected function _migrate_old_row($old_row)
+	{
+		if ($old_row['QST_ID'] && $old_row['QST_system'] == 'state') {
+			global $wpdb;
+			$success = $wpdb->update(
+				$this->_old_table,
+				['QST_type' => 'STATE'],            // data
+				['QST_ID' => $old_row['QST_ID']],  // where
+				['%s'],                             // data format
+				['%d']                              // where format
+			);
+			if (! $success) {
+				$this->add_error(
+					sprintf(
+						esc_html__(
+							'Could not update question system name "%1$s" for question ID=%2$d because "%3$s"',
+							'event_espresso'
+						),
+						wp_json_encode($old_row['QST_system']),
+						$old_row['QST_ID'],
+						$wpdb->last_error
+					)
+				);
+			}
+		}
+	}
 }

Spacing +5 added lines, -5 removed lines

@@ -14,7 +14,7 @@ 
     {
         global $wpdb;
         $this->_pretty_name     = esc_html__('State - System Question', 'event_espresso');
-        $this->_old_table       = $wpdb->prefix . 'esp_question';
+        $this->_old_table       = $wpdb->prefix.'esp_question';
         $this->_extra_where_sql = "WHERE QST_system = 'state'";
         parent::__construct();
     }
@@ -32,12 +32,12 @@ 
             global $wpdb;
             $success = $wpdb->update(
                 $this->_old_table,
-                ['QST_type' => 'STATE'],            // data
-                ['QST_ID' => $old_row['QST_ID']],  // where
-                ['%s'],                             // data format
+                ['QST_type' => 'STATE'], // data
+                ['QST_ID' => $old_row['QST_ID']], // where
+                ['%s'], // data format
                 ['%d']                              // where format
             );
-            if (! $success) {
+            if ( ! $success) {
                 $this->add_error(
                     sprintf(
                         esc_html__(

core/data_migration_scripts/4_6_0_stages/EE_DMS_4_6_0_transactions.dmsstage.php

Indentation +67 added lines, -67 removed lines

@@ -10,78 +10,78 @@
 class EE_DMS_4_6_0_transactions extends EE_Data_Migration_Script_Stage_Table
 {
 
-    protected string $_transaction_table;
+	protected string $_transaction_table;
 
-    protected string $_payment_method_table;
+	protected string $_payment_method_table;
 
 
-    public function __construct()
-    {
-        global $wpdb;
-        $this->_old_table            = $wpdb->prefix . 'esp_extra_meta';
-        $this->_transaction_table    = $wpdb->prefix . 'esp_transaction';
-        $this->_payment_method_table = $wpdb->prefix . 'esp_payment_method';
-        $this->_pretty_name          = esc_html__('Transaction Payment Method Relations', 'event_espresso');
-        $this->_extra_where_sql      = "WHERE EXM_key = 'gateway' AND EXM_type = 'Transaction'";
-        parent::__construct();
-    }
+	public function __construct()
+	{
+		global $wpdb;
+		$this->_old_table            = $wpdb->prefix . 'esp_extra_meta';
+		$this->_transaction_table    = $wpdb->prefix . 'esp_transaction';
+		$this->_payment_method_table = $wpdb->prefix . 'esp_payment_method';
+		$this->_pretty_name          = esc_html__('Transaction Payment Method Relations', 'event_espresso');
+		$this->_extra_where_sql      = "WHERE EXM_key = 'gateway' AND EXM_type = 'Transaction'";
+		parent::__construct();
+	}
 
 
-    protected function _migrate_old_row($old_row)
-    {
-        global $wpdb;
-        // get the payment method's ID
-        $PMD_ID = $this->_get_payment_method_id_by_gateway_name($old_row['EXM_value']);
-        if (! $PMD_ID) {
-            $this->add_error(
-                sprintf(
-                    esc_html__(
-                        'Could not find payment method with PMD_type = \'%1$s\' when migrating extra meta row %2$s',
-                        'event_espresso'
-                    ),
-                    $old_row['EXM_value'],
-                    $this->_json_encode($old_row)
-                )
-            );
-            return;
-        }
-        $new_values          = ['PMD_ID' => $PMD_ID];
-        $wheres              = ['TXN_ID' => $old_row['OBJ_ID']];
-        $new_value_data_types = ['%d'];
-        $where_data_types     = ['%d'];
-        $success             = $wpdb->update(
-            $this->_transaction_table,
-            $new_values,
-            $wheres,
-            $new_value_data_types,
-            $where_data_types
-        );
-        if (! $success) {
-            $this->add_error(
-                sprintf(
-                    esc_html__('Couldn\'t set %1$s row in table %2$s where %3$s', 'event_espresso'),
-                    $this->_json_encode($new_values),
-                    $this->_transaction_table,
-                    $this->_json_encode($wheres)
-                )
-            );
-        }
-    }
+	protected function _migrate_old_row($old_row)
+	{
+		global $wpdb;
+		// get the payment method's ID
+		$PMD_ID = $this->_get_payment_method_id_by_gateway_name($old_row['EXM_value']);
+		if (! $PMD_ID) {
+			$this->add_error(
+				sprintf(
+					esc_html__(
+						'Could not find payment method with PMD_type = \'%1$s\' when migrating extra meta row %2$s',
+						'event_espresso'
+					),
+					$old_row['EXM_value'],
+					$this->_json_encode($old_row)
+				)
+			);
+			return;
+		}
+		$new_values          = ['PMD_ID' => $PMD_ID];
+		$wheres              = ['TXN_ID' => $old_row['OBJ_ID']];
+		$new_value_data_types = ['%d'];
+		$where_data_types     = ['%d'];
+		$success             = $wpdb->update(
+			$this->_transaction_table,
+			$new_values,
+			$wheres,
+			$new_value_data_types,
+			$where_data_types
+		);
+		if (! $success) {
+			$this->add_error(
+				sprintf(
+					esc_html__('Couldn\'t set %1$s row in table %2$s where %3$s', 'event_espresso'),
+					$this->_json_encode($new_values),
+					$this->_transaction_table,
+					$this->_json_encode($wheres)
+				)
+			);
+		}
+	}
 
 
-    /**
-     * @param string $gateway_name
-     * @return string
-     * @global wpdb  $wpdb
-     */
-    protected function _get_payment_method_id_by_gateway_name(string $gateway_name): string
-    {
-        global $wpdb;
-        return $wpdb->get_var(
-            $wpdb->prepare(
-                "SELECT PMD_ID FROM " . $wpdb->prefix . "esp_payment_method WHERE PMD_type = %s",
-                $gateway_name
-            )
-        );
-    }
+	/**
+	 * @param string $gateway_name
+	 * @return string
+	 * @global wpdb  $wpdb
+	 */
+	protected function _get_payment_method_id_by_gateway_name(string $gateway_name): string
+	{
+		global $wpdb;
+		return $wpdb->get_var(
+			$wpdb->prepare(
+				"SELECT PMD_ID FROM " . $wpdb->prefix . "esp_payment_method WHERE PMD_type = %s",
+				$gateway_name
+			)
+		);
+	}
 }

Spacing +6 added lines, -6 removed lines

@@ -18,9 +18,9 @@ 
     public function __construct()
     {
         global $wpdb;
-        $this->_old_table            = $wpdb->prefix . 'esp_extra_meta';
-        $this->_transaction_table    = $wpdb->prefix . 'esp_transaction';
-        $this->_payment_method_table = $wpdb->prefix . 'esp_payment_method';
+        $this->_old_table            = $wpdb->prefix.'esp_extra_meta';
+        $this->_transaction_table    = $wpdb->prefix.'esp_transaction';
+        $this->_payment_method_table = $wpdb->prefix.'esp_payment_method';
         $this->_pretty_name          = esc_html__('Transaction Payment Method Relations', 'event_espresso');
         $this->_extra_where_sql      = "WHERE EXM_key = 'gateway' AND EXM_type = 'Transaction'";
         parent::__construct();
@@ -32,7 +32,7 @@ 
         global $wpdb;
         // get the payment method's ID
         $PMD_ID = $this->_get_payment_method_id_by_gateway_name($old_row['EXM_value']);
-        if (! $PMD_ID) {
+        if ( ! $PMD_ID) {
             $this->add_error(
                 sprintf(
                     esc_html__(
@@ -56,7 +56,7 @@ 
             $new_value_data_types,
             $where_data_types
         );
-        if (! $success) {
+        if ( ! $success) {
             $this->add_error(
                 sprintf(
                     esc_html__('Couldn\'t set %1$s row in table %2$s where %3$s', 'event_espresso'),
@@ -79,7 +79,7 @@ 
         global $wpdb;
         return $wpdb->get_var(
             $wpdb->prepare(
-                "SELECT PMD_ID FROM " . $wpdb->prefix . "esp_payment_method WHERE PMD_type = %s",
+                "SELECT PMD_ID FROM ".$wpdb->prefix."esp_payment_method WHERE PMD_type = %s",
                 $gateway_name
             )
         );

core/data_migration_scripts/4_6_0_stages/EE_DMS_4_6_0_question_types.dmsstage.php

Indentation +50 added lines, -50 removed lines

@@ -10,58 +10,58 @@
 class EE_DMS_4_6_0_question_types extends EE_Data_Migration_Script_Stage_Table
 {
 
-    protected array $_question_type_conversions = [];
+	protected array $_question_type_conversions = [];
 
 
-    public function __construct()
-    {
-        global $wpdb;
-        $this->_pretty_name               = esc_html__('Question Types', 'event_espresso');
-        $this->_old_table                 = $wpdb->prefix . 'esp_question';
-        $this->_question_type_conversions = [
-            'MULTIPLE' => 'CHECKBOX',
-            'SINGLE'   => 'RADIO_BTN',
-        ];
-        // when fetching rows, because we automatically use a limit and offset
-        // rows counted before migrating any rows, need to ALSO be counted after a bunch of rows were counted
-        // so we need to include both the migrated rows as well as the non-migrated rows
-        $QST_types_to_count     = array_merge(
-            array_keys($this->_question_type_conversions),
-            $this->_question_type_conversions
-        );
-        $this->_extra_where_sql = "WHERE QST_type IN ('" . implode("', '", $QST_types_to_count) . "')";
-        parent::__construct();
-    }
+	public function __construct()
+	{
+		global $wpdb;
+		$this->_pretty_name               = esc_html__('Question Types', 'event_espresso');
+		$this->_old_table                 = $wpdb->prefix . 'esp_question';
+		$this->_question_type_conversions = [
+			'MULTIPLE' => 'CHECKBOX',
+			'SINGLE'   => 'RADIO_BTN',
+		];
+		// when fetching rows, because we automatically use a limit and offset
+		// rows counted before migrating any rows, need to ALSO be counted after a bunch of rows were counted
+		// so we need to include both the migrated rows as well as the non-migrated rows
+		$QST_types_to_count     = array_merge(
+			array_keys($this->_question_type_conversions),
+			$this->_question_type_conversions
+		);
+		$this->_extra_where_sql = "WHERE QST_type IN ('" . implode("', '", $QST_types_to_count) . "')";
+		parent::__construct();
+	}
 
 
-    /**
-     * @param array $old_row an associative array where keys are column names and values are their values.
-     * @return void
-     */
-    protected function _migrate_old_row($old_row)
-    {
-        global $wpdb;
-        if ($old_row['QST_ID'] && isset($this->_question_type_conversions[ $old_row['QST_type'] ])) {
-            $success = $wpdb->update(
-                $this->_old_table,
-                ['QST_type' => $this->_question_type_conversions[ $old_row['QST_type'] ]],   // data
-                ['QST_ID' => $old_row['QST_ID']],                                            // where
-                ['%s'],                                                                      // data format
-                ['%d']                                                                       // where format
-            );
-            if (! $success) {
-                $this->add_error(
-                    sprintf(
-                        esc_html__(
-                            'Could not update question type %1$s for question ID=%2$d because "%3$s"',
-                            'event_espresso'
-                        ),
-                        wp_json_encode($old_row['QST_type']),
-                        $old_row['QST_ID'],
-                        $wpdb->last_error
-                    )
-                );
-            }
-        }
-    }
+	/**
+	 * @param array $old_row an associative array where keys are column names and values are their values.
+	 * @return void
+	 */
+	protected function _migrate_old_row($old_row)
+	{
+		global $wpdb;
+		if ($old_row['QST_ID'] && isset($this->_question_type_conversions[ $old_row['QST_type'] ])) {
+			$success = $wpdb->update(
+				$this->_old_table,
+				['QST_type' => $this->_question_type_conversions[ $old_row['QST_type'] ]],   // data
+				['QST_ID' => $old_row['QST_ID']],                                            // where
+				['%s'],                                                                      // data format
+				['%d']                                                                       // where format
+			);
+			if (! $success) {
+				$this->add_error(
+					sprintf(
+						esc_html__(
+							'Could not update question type %1$s for question ID=%2$d because "%3$s"',
+							'event_espresso'
+						),
+						wp_json_encode($old_row['QST_type']),
+						$old_row['QST_ID'],
+						$wpdb->last_error
+					)
+				);
+			}
+		}
+	}
 }

Spacing +8 added lines, -8 removed lines

@@ -17,7 +17,7 @@ 
     {
         global $wpdb;
         $this->_pretty_name               = esc_html__('Question Types', 'event_espresso');
-        $this->_old_table                 = $wpdb->prefix . 'esp_question';
+        $this->_old_table                 = $wpdb->prefix.'esp_question';
         $this->_question_type_conversions = [
             'MULTIPLE' => 'CHECKBOX',
             'SINGLE'   => 'RADIO_BTN',
@@ -25,11 +25,11 @@ 
         // when fetching rows, because we automatically use a limit and offset
         // rows counted before migrating any rows, need to ALSO be counted after a bunch of rows were counted
         // so we need to include both the migrated rows as well as the non-migrated rows
-        $QST_types_to_count     = array_merge(
+        $QST_types_to_count = array_merge(
             array_keys($this->_question_type_conversions),
             $this->_question_type_conversions
         );
-        $this->_extra_where_sql = "WHERE QST_type IN ('" . implode("', '", $QST_types_to_count) . "')";
+        $this->_extra_where_sql = "WHERE QST_type IN ('".implode("', '", $QST_types_to_count)."')";
         parent::__construct();
     }
 
@@ -41,15 +41,15 @@ 
     protected function _migrate_old_row($old_row)
     {
         global $wpdb;
-        if ($old_row['QST_ID'] && isset($this->_question_type_conversions[ $old_row['QST_type'] ])) {
+        if ($old_row['QST_ID'] && isset($this->_question_type_conversions[$old_row['QST_type']])) {
             $success = $wpdb->update(
                 $this->_old_table,
-                ['QST_type' => $this->_question_type_conversions[ $old_row['QST_type'] ]],   // data
-                ['QST_ID' => $old_row['QST_ID']],                                            // where
-                ['%s'],                                                                      // data format
+                ['QST_type' => $this->_question_type_conversions[$old_row['QST_type']]], // data
+                ['QST_ID' => $old_row['QST_ID']], // where
+                ['%s'], // data format
                 ['%d']                                                                       // where format
             );
-            if (! $success) {
+            if ( ! $success) {
                 $this->add_error(
                     sprintf(
                         esc_html__(

core/data_migration_scripts/4_6_0_stages/EE_DMS_4_6_0_payments.dmsstage.php

Indentation +115 added lines, -115 removed lines

@@ -10,125 +10,125 @@
 class EE_DMS_4_6_0_payments extends EE_Data_Migration_Script_Stage_Table
 {
 
-    protected string $_payment_method_table;
+	protected string $_payment_method_table;
 
 
-    public function __construct()
-    {
-        global $wpdb;
-        $this->_old_table            = $wpdb->prefix . 'esp_payment';
-        $this->_payment_method_table = $wpdb->prefix . 'esp_payment_method';
-        $this->_pretty_name          = esc_html__('Payment-Payment Method Relations', 'event_espresso');
-        parent::__construct();
-    }
+	public function __construct()
+	{
+		global $wpdb;
+		$this->_old_table            = $wpdb->prefix . 'esp_payment';
+		$this->_payment_method_table = $wpdb->prefix . 'esp_payment_method';
+		$this->_pretty_name          = esc_html__('Payment-Payment Method Relations', 'event_espresso');
+		parent::__construct();
+	}
 
 
-    protected function _migrate_old_row($old_row)
-    {
-        global $wpdb;
-        // get the payment method's ID
-        $PMD_ID = apply_filters(
-            'FHEE__EE_DMS_4_6_0_payments__migrate_old_row__PMD_ID',
-            $this->_get_payment_method_id_by_gateway_name($old_row['PAY_gateway'], $old_row['PAY_method'])
-        );
-        if (! $PMD_ID) {
-            $this->add_error(
-                sprintf(
-                    esc_html__(
-                        'Could not find payment method with PMD_type = \'%1$s\' when migrating payment row %2$s so just assigned it an unknown payment method',
-                        'event_espresso'
-                    ),
-                    $old_row['PAY_gateway'],
-                    $this->_json_encode($old_row)
-                )
-            );
-            $PMD_ID = 0;
-        }
-        $new_values          = [
-            'PMD_ID'     => $PMD_ID,
-            'PAY_source' => ($old_row['PAY_via_admin'] ? 'ADMIN' : 'CART'),
-        ];
-        $wheres              = ['PAY_ID' => $old_row['PAY_ID']];
-        $new_value_datatypes = ['%d', '%s'];
-        $where_datatypes     = ['%d'];
-        $success             = $wpdb->update(
-            $this->_old_table,
-            $new_values,
-            $wheres,
-            $new_value_datatypes,
-            $where_datatypes
-        );
-        if (! $success) {
-            $this->add_error(
-                sprintf(
-                    esc_html__('Couldn\'t set %1$s row in table %2$s where %3$s', 'event_espresso'),
-                    $this->_json_encode($new_values),
-                    $this->_old_table,
-                    $this->_json_encode($wheres)
-                )
-            );
-        }
-    }
+	protected function _migrate_old_row($old_row)
+	{
+		global $wpdb;
+		// get the payment method's ID
+		$PMD_ID = apply_filters(
+			'FHEE__EE_DMS_4_6_0_payments__migrate_old_row__PMD_ID',
+			$this->_get_payment_method_id_by_gateway_name($old_row['PAY_gateway'], $old_row['PAY_method'])
+		);
+		if (! $PMD_ID) {
+			$this->add_error(
+				sprintf(
+					esc_html__(
+						'Could not find payment method with PMD_type = \'%1$s\' when migrating payment row %2$s so just assigned it an unknown payment method',
+						'event_espresso'
+					),
+					$old_row['PAY_gateway'],
+					$this->_json_encode($old_row)
+				)
+			);
+			$PMD_ID = 0;
+		}
+		$new_values          = [
+			'PMD_ID'     => $PMD_ID,
+			'PAY_source' => ($old_row['PAY_via_admin'] ? 'ADMIN' : 'CART'),
+		];
+		$wheres              = ['PAY_ID' => $old_row['PAY_ID']];
+		$new_value_datatypes = ['%d', '%s'];
+		$where_datatypes     = ['%d'];
+		$success             = $wpdb->update(
+			$this->_old_table,
+			$new_values,
+			$wheres,
+			$new_value_datatypes,
+			$where_datatypes
+		);
+		if (! $success) {
+			$this->add_error(
+				sprintf(
+					esc_html__('Couldn\'t set %1$s row in table %2$s where %3$s', 'event_espresso'),
+					$this->_json_encode($new_values),
+					$this->_old_table,
+					$this->_json_encode($wheres)
+				)
+			);
+		}
+	}
 
 
-    /**
-     *  array(
-     * 'PP' => esc_html__( 'PayPal', 'event_espresso' ),
-     * 'CC' => esc_html__( 'Credit Card', 'event_espresso' ),
-     * 'DB'=>  esc_html__("Debit Card", 'event_espresso'),
-     * 'CHQ' => esc_html__( 'Cheque', 'event_espresso' ),
-     * 'CSH' => esc_html__( 'Cash', 'event_espresso' ),
-     * 'BK'=>  esc_html__("Bank", 'event_espresso'),
-     * 'IV'=>  esc_html__("Invoice", 'event_espresso'),
-     * 'MO'=>  esc_html__("Money Order", 'event_espresso'),
-     *
-     * @param string $gateway_name
-     * @param string $old_pay_method_column
-     * @return string
-     * @global wpdb  $wpdb
-     */
-    protected function _get_payment_method_id_by_gateway_name(
-        string $gateway_name,
-        string $old_pay_method_column
-    ): string {
-        global $wpdb;
-        // convert from old known PAY_method values to their corresponding
-        // PMD_type or default PMD_name
-        switch ($old_pay_method_column) {
-            case 'PP':
-                $pmd_type = 'Paypal_Standard';
-                break;
-            case 'CC':
-                $pmd_type = 'Credit_Card';
-                break;
-            case 'DB':
-                $pmd_type = 'Debit_Card';
-                break;
-            case 'CHQ':
-                $pmd_type = 'Check';
-                break;
-            case 'CSH':
-                $pmd_type = 'Cash';
-                break;
-            case 'BK':
-                $pmd_type = 'Bank';
-                break;
-            case 'IV':
-                $pmd_type = 'Invoice';
-                break;
-            case 'MO':
-                $pmd_type = 'Money_Order';
-                break;
-            default:
-                $pmd_type = $gateway_name;
-        }
-        $pmd_name = str_replace("_", " ", $pmd_type);
-        return $wpdb->get_var(
-            $wpdb->prepare(
-                "SELECT PMD_ID FROM " . $wpdb->prefix . "esp_payment_method WHERE PMD_type = %s OR PMD_name = %s",
-                $pmd_type,
-                $pmd_name
-            )
-        );
-    }
+	/**
+	 *  array(
+	 * 'PP' => esc_html__( 'PayPal', 'event_espresso' ),
+	 * 'CC' => esc_html__( 'Credit Card', 'event_espresso' ),
+	 * 'DB'=>  esc_html__("Debit Card", 'event_espresso'),
+	 * 'CHQ' => esc_html__( 'Cheque', 'event_espresso' ),
+	 * 'CSH' => esc_html__( 'Cash', 'event_espresso' ),
+	 * 'BK'=>  esc_html__("Bank", 'event_espresso'),
+	 * 'IV'=>  esc_html__("Invoice", 'event_espresso'),
+	 * 'MO'=>  esc_html__("Money Order", 'event_espresso'),
+	 *
+	 * @param string $gateway_name
+	 * @param string $old_pay_method_column
+	 * @return string
+	 * @global wpdb  $wpdb
+	 */
+	protected function _get_payment_method_id_by_gateway_name(
+		string $gateway_name,
+		string $old_pay_method_column
+	): string {
+		global $wpdb;
+		// convert from old known PAY_method values to their corresponding
+		// PMD_type or default PMD_name
+		switch ($old_pay_method_column) {
+			case 'PP':
+				$pmd_type = 'Paypal_Standard';
+				break;
+			case 'CC':
+				$pmd_type = 'Credit_Card';
+				break;
+			case 'DB':
+				$pmd_type = 'Debit_Card';
+				break;
+			case 'CHQ':
+				$pmd_type = 'Check';
+				break;
+			case 'CSH':
+				$pmd_type = 'Cash';
+				break;
+			case 'BK':
+				$pmd_type = 'Bank';
+				break;
+			case 'IV':
+				$pmd_type = 'Invoice';
+				break;
+			case 'MO':
+				$pmd_type = 'Money_Order';
+				break;
+			default:
+				$pmd_type = $gateway_name;
+		}
+		$pmd_name = str_replace("_", " ", $pmd_type);
+		return $wpdb->get_var(
+			$wpdb->prepare(
+				"SELECT PMD_ID FROM " . $wpdb->prefix . "esp_payment_method WHERE PMD_type = %s OR PMD_name = %s",
+				$pmd_type,
+				$pmd_name
+			)
+		);
+	}
 }

Spacing +6 added lines, -6 removed lines

@@ -16,8 +16,8 @@ 
     public function __construct()
     {
         global $wpdb;
-        $this->_old_table            = $wpdb->prefix . 'esp_payment';
-        $this->_payment_method_table = $wpdb->prefix . 'esp_payment_method';
+        $this->_old_table            = $wpdb->prefix.'esp_payment';
+        $this->_payment_method_table = $wpdb->prefix.'esp_payment_method';
         $this->_pretty_name          = esc_html__('Payment-Payment Method Relations', 'event_espresso');
         parent::__construct();
     }
@@ -31,7 +31,7 @@ 
             'FHEE__EE_DMS_4_6_0_payments__migrate_old_row__PMD_ID',
             $this->_get_payment_method_id_by_gateway_name($old_row['PAY_gateway'], $old_row['PAY_method'])
         );
-        if (! $PMD_ID) {
+        if ( ! $PMD_ID) {
             $this->add_error(
                 sprintf(
                     esc_html__(
@@ -44,7 +44,7 @@ 
             );
             $PMD_ID = 0;
         }
-        $new_values          = [
+        $new_values = [
             'PMD_ID'     => $PMD_ID,
             'PAY_source' => ($old_row['PAY_via_admin'] ? 'ADMIN' : 'CART'),
         ];
@@ -58,7 +58,7 @@ 
             $new_value_datatypes,
             $where_datatypes
         );
-        if (! $success) {
+        if ( ! $success) {
             $this->add_error(
                 sprintf(
                     esc_html__('Couldn\'t set %1$s row in table %2$s where %3$s', 'event_espresso'),
@@ -125,7 +125,7 @@ 
         $pmd_name = str_replace("_", " ", $pmd_type);
         return $wpdb->get_var(
             $wpdb->prepare(
-                "SELECT PMD_ID FROM " . $wpdb->prefix . "esp_payment_method WHERE PMD_type = %s OR PMD_name = %s",
+                "SELECT PMD_ID FROM ".$wpdb->prefix."esp_payment_method WHERE PMD_type = %s OR PMD_name = %s",
                 $pmd_type,
                 $pmd_name
             )

core/data_migration_scripts/4_6_0_stages/EE_DMS_4_6_0_country_system_question.dmsstage.php

Indentation +40 added lines, -40 removed lines

@@ -10,46 +10,46 @@
 class EE_DMS_4_6_0_country_system_question extends EE_Data_Migration_Script_Stage_Table
 {
 
-    public function __construct()
-    {
-        global $wpdb;
-        $this->_pretty_name     = esc_html__('Country - System Question', 'event_espresso');
-        $this->_old_table       = $wpdb->prefix . 'esp_question';
-        $this->_extra_where_sql = "WHERE QST_system = 'country'";
-        parent::__construct();
-    }
+	public function __construct()
+	{
+		global $wpdb;
+		$this->_pretty_name     = esc_html__('Country - System Question', 'event_espresso');
+		$this->_old_table       = $wpdb->prefix . 'esp_question';
+		$this->_extra_where_sql = "WHERE QST_system = 'country'";
+		parent::__construct();
+	}
 
 
-    /**
-     * updates the question with the new question type
-     *
-     * @param array $old_row an associative array where keys are column names and values are their values.
-     * @return void
-     */
-    protected function _migrate_old_row($old_row)
-    {
-        if ($old_row['QST_ID'] && $old_row['QST_system'] == 'country') {
-            global $wpdb;
-            $success = $wpdb->update(
-                $this->_old_table,
-                ['QST_type' => 'COUNTRY'],          // data
-                ['QST_ID' => $old_row['QST_ID']],  // where
-                ['%s'],                             // data format
-                ['%d']                              // where format
-            );
-            if (! $success) {
-                $this->add_error(
-                    sprintf(
-                        esc_html__(
-                            'Could not update question system name "%1$s" for question ID=%2$d because "%3$s"',
-                            'event_espresso'
-                        ),
-                        wp_json_encode($old_row['QST_system']),
-                        $old_row['QST_ID'],
-                        $wpdb->last_error
-                    )
-                );
-            }
-        }
-    }
+	/**
+	 * updates the question with the new question type
+	 *
+	 * @param array $old_row an associative array where keys are column names and values are their values.
+	 * @return void
+	 */
+	protected function _migrate_old_row($old_row)
+	{
+		if ($old_row['QST_ID'] && $old_row['QST_system'] == 'country') {
+			global $wpdb;
+			$success = $wpdb->update(
+				$this->_old_table,
+				['QST_type' => 'COUNTRY'],          // data
+				['QST_ID' => $old_row['QST_ID']],  // where
+				['%s'],                             // data format
+				['%d']                              // where format
+			);
+			if (! $success) {
+				$this->add_error(
+					sprintf(
+						esc_html__(
+							'Could not update question system name "%1$s" for question ID=%2$d because "%3$s"',
+							'event_espresso'
+						),
+						wp_json_encode($old_row['QST_system']),
+						$old_row['QST_ID'],
+						$wpdb->last_error
+					)
+				);
+			}
+		}
+	}
 }

Spacing +5 added lines, -5 removed lines

@@ -14,7 +14,7 @@ 
     {
         global $wpdb;
         $this->_pretty_name     = esc_html__('Country - System Question', 'event_espresso');
-        $this->_old_table       = $wpdb->prefix . 'esp_question';
+        $this->_old_table       = $wpdb->prefix.'esp_question';
         $this->_extra_where_sql = "WHERE QST_system = 'country'";
         parent::__construct();
     }
@@ -32,12 +32,12 @@ 
             global $wpdb;
             $success = $wpdb->update(
                 $this->_old_table,
-                ['QST_type' => 'COUNTRY'],          // data
-                ['QST_ID' => $old_row['QST_ID']],  // where
-                ['%s'],                             // data format
+                ['QST_type' => 'COUNTRY'], // data
+                ['QST_ID' => $old_row['QST_ID']], // where
+                ['%s'], // data format
                 ['%d']                              // where format
             );
-            if (! $success) {
+            if ( ! $success) {
                 $this->add_error(
                     sprintf(
                         esc_html__(