eventespresso / event-espresso-core

core/data_migration_scripts/4_6_0_stages/EE_DMS_4_6_0_country_system_question.dmsstage.php

Indentation +41 added lines, -41 removed lines

@@ -14,48 +14,48 @@
 
 
 
-    /**
-     * Just initializes the status of the migration
-     *
-     * @return EE_DMS_4_6_0_country_system_question
-     */
-    public function __construct()
-    {
-        global $wpdb;
-        $this->_pretty_name = __('Country - System Question', 'event_espresso');
-        $this->_old_table = $wpdb->prefix.'esp_question';
-        $this->_extra_where_sql = "WHERE QST_system = 'country'";
-        parent::__construct();
-    }
+	/**
+	 * Just initializes the status of the migration
+	 *
+	 * @return EE_DMS_4_6_0_country_system_question
+	 */
+	public function __construct()
+	{
+		global $wpdb;
+		$this->_pretty_name = __('Country - System Question', 'event_espresso');
+		$this->_old_table = $wpdb->prefix.'esp_question';
+		$this->_extra_where_sql = "WHERE QST_system = 'country'";
+		parent::__construct();
+	}
 
 
 
-    /**
-     * updates the question with the new question type
-     * @param array $question an associative array where keys are column names and values are their values.
-     * @return null
-     */
-    protected function _migrate_old_row($question)
-    {
-        if ($question['QST_ID'] && $question['QST_system'] == 'country') {
-            global $wpdb;
-            $success = $wpdb->update(
-                $this->_old_table,
-                array( 'QST_type' => 'COUNTRY' ),  // data
-                array( 'QST_ID' => $question['QST_ID'] ),  // where
-                array( '%s' ),   // data format
-                array( '%d' )  // where format
-            );
-            if (! $success) {
-                $this->add_error(
-                    sprintf(
-                        __('Could not update question system name "%1$s" for question ID=%2$d because "%3$s"', 'event_espresso'),
-                        wp_json_encode($question['QST_system']),
-                        $question['QST_ID'],
-                        $wpdb->last_error
-                    )
-                );
-            }
-        }
-    }
+	/**
+	 * updates the question with the new question type
+	 * @param array $question an associative array where keys are column names and values are their values.
+	 * @return null
+	 */
+	protected function _migrate_old_row($question)
+	{
+		if ($question['QST_ID'] && $question['QST_system'] == 'country') {
+			global $wpdb;
+			$success = $wpdb->update(
+				$this->_old_table,
+				array( 'QST_type' => 'COUNTRY' ),  // data
+				array( 'QST_ID' => $question['QST_ID'] ),  // where
+				array( '%s' ),   // data format
+				array( '%d' )  // where format
+			);
+			if (! $success) {
+				$this->add_error(
+					sprintf(
+						__('Could not update question system name "%1$s" for question ID=%2$d because "%3$s"', 'event_espresso'),
+						wp_json_encode($question['QST_system']),
+						$question['QST_ID'],
+						$wpdb->last_error
+					)
+				);
+			}
+		}
+	}
 }

Spacing +5 added lines, -5 removed lines

@@ -41,12 +41,12 @@
             global $wpdb;
             $success = $wpdb->update(
                 $this->_old_table,
-                array( 'QST_type' => 'COUNTRY' ),  // data
-                array( 'QST_ID' => $question['QST_ID'] ),  // where
-                array( '%s' ),   // data format
-                array( '%d' )  // where format
+                array('QST_type' => 'COUNTRY'), // data
+                array('QST_ID' => $question['QST_ID']), // where
+                array('%s'), // data format
+                array('%d')  // where format
             );
-            if (! $success) {
+            if ( ! $success) {
                 $this->add_error(
                     sprintf(
                         __('Could not update question system name "%1$s" for question ID=%2$d because "%3$s"', 'event_espresso'),

core/data_migration_scripts/4_6_0_stages/EE_DMS_4_6_0_payment_method_currencies.dmsstage.php

Indentation +164 added lines, -164 removed lines

@@ -12,174 +12,174 @@
  */
 class EE_DMS_4_6_0_payment_method_currencies extends EE_Data_Migration_Script_Stage
 {
-    protected $_currency_table_name;
-    protected $_currency_payment_method_table_name;
-    protected $_payment_method_table_name;
-    /**
-     * each key is the name of a 4.1-style gateway we know how to migrate to 4.6
-     * @var array
-     */
-    protected $_gateway_currencies = array(
-        'Aim' => array(
-            'AUD',
-            'USD',
-            'CAD',
-            'EUR',
-            'GBP',
-            'NZD',
-        ),
-        'Bank' => 'all',
-        'Check' => 'all',
-        'Invoice' => 'all',
-        'Mijireh' => 'all',
-        'Paypal_Pro' => array(
-            'USD',
-            'GBP',
-            'CAD',
-            'AUD',
-            'BRL',
-            'CHF',
-            'CZK',
-            'DKK',
-            'EUR',
-            'HKD',
-            'HUF',
-            'ILS',
-            'JPY',
-            'MXN',
-            'MYR',
-            'NOK',
-            'NZD',
-            'PHP',
-            'PLN',
-            'SEK',
-            'SGD',
-            'THB',
-            'TRY',
-            'TWD',
-        ),
-        'Paypal_Standard' => array(
-            'USD',
-            'GBP',
-            'CAD',
-            'AUD',
-            'BRL',
-            'CHF',
-            'CZK',
-            'DKK',
-            'EUR',
-            'HKD',
-            'HUF',
-            'ILS',
-            'JPY',
-            'MXN',
-            'MYR',
-            'NOK',
-            'NZD',
-            'PHP',
-            'PLN',
-            'SEK',
-            'SGD',
-            'THB',
-            'TRY',
-            'TWD'
-        )
-    );
-    public function __construct()
-    {
-        global $wpdb;
-        $this->_pretty_name = __('Payment Method Currencies', 'event_espresso');
-        $this->_payment_method_table_name = $wpdb->prefix.'esp_payment_method';
-        $this->_currency_payment_method_table_name = $wpdb->prefix.'esp_currency_payment_method';
-        $this->_currency_table_name = $wpdb->prefix.'esp_currency';
-        parent::__construct();
-    }
+	protected $_currency_table_name;
+	protected $_currency_payment_method_table_name;
+	protected $_payment_method_table_name;
+	/**
+	 * each key is the name of a 4.1-style gateway we know how to migrate to 4.6
+	 * @var array
+	 */
+	protected $_gateway_currencies = array(
+		'Aim' => array(
+			'AUD',
+			'USD',
+			'CAD',
+			'EUR',
+			'GBP',
+			'NZD',
+		),
+		'Bank' => 'all',
+		'Check' => 'all',
+		'Invoice' => 'all',
+		'Mijireh' => 'all',
+		'Paypal_Pro' => array(
+			'USD',
+			'GBP',
+			'CAD',
+			'AUD',
+			'BRL',
+			'CHF',
+			'CZK',
+			'DKK',
+			'EUR',
+			'HKD',
+			'HUF',
+			'ILS',
+			'JPY',
+			'MXN',
+			'MYR',
+			'NOK',
+			'NZD',
+			'PHP',
+			'PLN',
+			'SEK',
+			'SGD',
+			'THB',
+			'TRY',
+			'TWD',
+		),
+		'Paypal_Standard' => array(
+			'USD',
+			'GBP',
+			'CAD',
+			'AUD',
+			'BRL',
+			'CHF',
+			'CZK',
+			'DKK',
+			'EUR',
+			'HKD',
+			'HUF',
+			'ILS',
+			'JPY',
+			'MXN',
+			'MYR',
+			'NOK',
+			'NZD',
+			'PHP',
+			'PLN',
+			'SEK',
+			'SGD',
+			'THB',
+			'TRY',
+			'TWD'
+		)
+	);
+	public function __construct()
+	{
+		global $wpdb;
+		$this->_pretty_name = __('Payment Method Currencies', 'event_espresso');
+		$this->_payment_method_table_name = $wpdb->prefix.'esp_payment_method';
+		$this->_currency_payment_method_table_name = $wpdb->prefix.'esp_currency_payment_method';
+		$this->_currency_table_name = $wpdb->prefix.'esp_currency';
+		parent::__construct();
+	}
 
-    protected function _count_records_to_migrate()
-    {
-        $count = 0;
-        foreach ($this->_gateway_currencies as $currencies) {
-            if ($currencies == 'all') {
-                $currencies = $this->_get_all_currencies();
-            }
-            $count += count($currencies);
-        }
-        return $count;
-    }
+	protected function _count_records_to_migrate()
+	{
+		$count = 0;
+		foreach ($this->_gateway_currencies as $currencies) {
+			if ($currencies == 'all') {
+				$currencies = $this->_get_all_currencies();
+			}
+			$count += count($currencies);
+		}
+		return $count;
+	}
 
 
 
-    protected function _migration_step($num_items_to_migrate = 50)
-    {
-        $items_actually_migrated = 0;
-        $relations_to_add_this_step = $this->_gather_relations_to_add($num_items_to_migrate);
-        foreach ($relations_to_add_this_step as $pm_slug => $currencies) {
-            $id = $this->get_migration_script()->get_mapping_new_pk('EE_Gateway_Config', $pm_slug, $this->_payment_method_table_name);
-            foreach ($currencies as $currency) {
-                if ($id) {
-                    $this->_add_currency_relations($id, $currency);
-                }
-                $items_actually_migrated++;
-            }
-        }
-        if ($this->count_records_migrated() + $items_actually_migrated >= $this->count_records_to_migrate()) {
-            $this->set_completed();
-        }
-        return $items_actually_migrated;
-    }
+	protected function _migration_step($num_items_to_migrate = 50)
+	{
+		$items_actually_migrated = 0;
+		$relations_to_add_this_step = $this->_gather_relations_to_add($num_items_to_migrate);
+		foreach ($relations_to_add_this_step as $pm_slug => $currencies) {
+			$id = $this->get_migration_script()->get_mapping_new_pk('EE_Gateway_Config', $pm_slug, $this->_payment_method_table_name);
+			foreach ($currencies as $currency) {
+				if ($id) {
+					$this->_add_currency_relations($id, $currency);
+				}
+				$items_actually_migrated++;
+			}
+		}
+		if ($this->count_records_migrated() + $items_actually_migrated >= $this->count_records_to_migrate()) {
+			$this->set_completed();
+		}
+		return $items_actually_migrated;
+	}
 
-    private function _gather_relations_to_add($num_items_to_migrate)
-    {
-        $relations_to_add_this_step = array();
-        $migrate_up_to_count = $this->count_records_migrated() + $num_items_to_migrate;
-        $iterator = 0;
-        foreach ($this->_gateway_currencies as $pm_slug => $currencies) {
-            if ($currencies == 'all') {
-                $currencies = $this->_get_all_currencies();
-            }
-            foreach ($currencies as $currency_code) {
-                if ($this->count_records_migrated() <= $iterator &&
-                        $iterator < $migrate_up_to_count ) {
-                    $relations_to_add_this_step[ $pm_slug ] [] = $currency_code;
-                }
-                $iterator++;
-            }
-        }
-        return $relations_to_add_this_step;
-    }
-    /**
-     * Gets all the currency codes in the database
-     * @return array
-     */
-    private function _get_all_currencies()
-    {
-        global $wpdb;
-        $currencies = $wpdb->get_col("SELECT CUR_code FROM {$this->_currency_table_name}");
-        return $currencies;
-    }
+	private function _gather_relations_to_add($num_items_to_migrate)
+	{
+		$relations_to_add_this_step = array();
+		$migrate_up_to_count = $this->count_records_migrated() + $num_items_to_migrate;
+		$iterator = 0;
+		foreach ($this->_gateway_currencies as $pm_slug => $currencies) {
+			if ($currencies == 'all') {
+				$currencies = $this->_get_all_currencies();
+			}
+			foreach ($currencies as $currency_code) {
+				if ($this->count_records_migrated() <= $iterator &&
+						$iterator < $migrate_up_to_count ) {
+					$relations_to_add_this_step[ $pm_slug ] [] = $currency_code;
+				}
+				$iterator++;
+			}
+		}
+		return $relations_to_add_this_step;
+	}
+	/**
+	 * Gets all the currency codes in the database
+	 * @return array
+	 */
+	private function _get_all_currencies()
+	{
+		global $wpdb;
+		$currencies = $wpdb->get_col("SELECT CUR_code FROM {$this->_currency_table_name}");
+		return $currencies;
+	}
 
-    /**
-     * Adds teh relation between the payment method and the currencies it can be used for
-     * @param int $id
-     * @param string $gateway_slug
-     */
-    private function _add_currency_relations($pm_id, $currency_code)
-    {
-        global $wpdb;
-        $cur_pm_relation = array(
-                    'CUR_code'=>$currency_code,
-                    'PMD_ID'=>$pm_id,
-                );
-        $success = $wpdb->insert(
-            $this->_currency_payment_method_table_name,
-            $cur_pm_relation,
-            array(
-                    '%s',// CUR_code
-                    '%d',// PMD_ID
-                )
-        );
-        if (! $success) {
-            $this->add_error(sprintf(__('Could not add currency relation %s because %s', "event_espresso"), wp_json_encode($cur_pm_relation), $wpdb->last_error));
-        }
-    }
+	/**
+	 * Adds teh relation between the payment method and the currencies it can be used for
+	 * @param int $id
+	 * @param string $gateway_slug
+	 */
+	private function _add_currency_relations($pm_id, $currency_code)
+	{
+		global $wpdb;
+		$cur_pm_relation = array(
+					'CUR_code'=>$currency_code,
+					'PMD_ID'=>$pm_id,
+				);
+		$success = $wpdb->insert(
+			$this->_currency_payment_method_table_name,
+			$cur_pm_relation,
+			array(
+					'%s',// CUR_code
+					'%d',// PMD_ID
+				)
+		);
+		if (! $success) {
+			$this->add_error(sprintf(__('Could not add currency relation %s because %s', "event_espresso"), wp_json_encode($cur_pm_relation), $wpdb->last_error));
+		}
+	}
 }

Spacing +5 added lines, -5 removed lines

@@ -139,8 +139,8 @@ 
             }
             foreach ($currencies as $currency_code) {
                 if ($this->count_records_migrated() <= $iterator &&
-                        $iterator < $migrate_up_to_count ) {
-                    $relations_to_add_this_step[ $pm_slug ] [] = $currency_code;
+                        $iterator < $migrate_up_to_count) {
+                    $relations_to_add_this_step[$pm_slug] [] = $currency_code;
                 }
                 $iterator++;
             }
@@ -174,11 +174,11 @@ 
             $this->_currency_payment_method_table_name,
             $cur_pm_relation,
             array(
-                    '%s',// CUR_code
-                    '%d',// PMD_ID
+                    '%s', // CUR_code
+                    '%d', // PMD_ID
                 )
         );
-        if (! $success) {
+        if ( ! $success) {
             $this->add_error(sprintf(__('Could not add currency relation %s because %s', "event_espresso"), wp_json_encode($cur_pm_relation), $wpdb->last_error));
         }
     }

core/data_migration_scripts/4_6_0_stages/EE_DMS_4_6_0_state_system_question.dmsstage.php

Indentation +41 added lines, -41 removed lines

@@ -14,48 +14,48 @@
 
 
 
-    /**
-     * Just initializes the status of the migration
-     *
-     * @return EE_DMS_4_6_0_state_system_question
-     */
-    public function __construct()
-    {
-        global $wpdb;
-        $this->_pretty_name = __('State - System Question', 'event_espresso');
-        $this->_old_table = $wpdb->prefix.'esp_question';
-        $this->_extra_where_sql = "WHERE QST_system = 'state'";
-        parent::__construct();
-    }
+	/**
+	 * Just initializes the status of the migration
+	 *
+	 * @return EE_DMS_4_6_0_state_system_question
+	 */
+	public function __construct()
+	{
+		global $wpdb;
+		$this->_pretty_name = __('State - System Question', 'event_espresso');
+		$this->_old_table = $wpdb->prefix.'esp_question';
+		$this->_extra_where_sql = "WHERE QST_system = 'state'";
+		parent::__construct();
+	}
 
 
 
-    /**
-     * updates the question with the new question type
-     * @param array $question an associative array where keys are column names and values are their values.
-     * @return null
-     */
-    protected function _migrate_old_row($question)
-    {
-        if ($question['QST_ID'] && $question['QST_system'] == 'state') {
-            global $wpdb;
-            $success = $wpdb->update(
-                $this->_old_table,
-                array( 'QST_type' => 'STATE' ),  // data
-                array( 'QST_ID' => $question['QST_ID'] ),  // where
-                array( '%s' ),   // data format
-                array( '%d' )  // where format
-            );
-            if (! $success) {
-                $this->add_error(
-                    sprintf(
-                        __('Could not update question system name "%1$s" for question ID=%2$d because "%3$s"', 'event_espresso'),
-                        wp_json_encode($question['QST_system']),
-                        $question['QST_ID'],
-                        $wpdb->last_error
-                    )
-                );
-            }
-        }
-    }
+	/**
+	 * updates the question with the new question type
+	 * @param array $question an associative array where keys are column names and values are their values.
+	 * @return null
+	 */
+	protected function _migrate_old_row($question)
+	{
+		if ($question['QST_ID'] && $question['QST_system'] == 'state') {
+			global $wpdb;
+			$success = $wpdb->update(
+				$this->_old_table,
+				array( 'QST_type' => 'STATE' ),  // data
+				array( 'QST_ID' => $question['QST_ID'] ),  // where
+				array( '%s' ),   // data format
+				array( '%d' )  // where format
+			);
+			if (! $success) {
+				$this->add_error(
+					sprintf(
+						__('Could not update question system name "%1$s" for question ID=%2$d because "%3$s"', 'event_espresso'),
+						wp_json_encode($question['QST_system']),
+						$question['QST_ID'],
+						$wpdb->last_error
+					)
+				);
+			}
+		}
+	}
 }

Spacing +5 added lines, -5 removed lines

@@ -41,12 +41,12 @@
             global $wpdb;
             $success = $wpdb->update(
                 $this->_old_table,
-                array( 'QST_type' => 'STATE' ),  // data
-                array( 'QST_ID' => $question['QST_ID'] ),  // where
-                array( '%s' ),   // data format
-                array( '%d' )  // where format
+                array('QST_type' => 'STATE'), // data
+                array('QST_ID' => $question['QST_ID']), // where
+                array('%s'), // data format
+                array('%d')  // where format
             );
-            if (! $success) {
+            if ( ! $success) {
                 $this->add_error(
                     sprintf(
                         __('Could not update question system name "%1$s" for question ID=%2$d because "%3$s"', 'event_espresso'),

core/data_migration_scripts/4_6_0_stages/EE_DMS_4_6_0_invoice_settings.dmsstage.php

Indentation +47 added lines, -47 removed lines

@@ -28,59 +28,59 @@
 class EE_DMS_4_6_0_invoice_settings extends EE_Data_Migration_Script_Stage
 {
 
-    /**
-     * Just initializes the status of the migration
-     */
-    public function __construct()
-    {
-        $this->_pretty_name = __('Update Invoice Settings', 'event_espresso');
-        parent::__construct();
-    }
+	/**
+	 * Just initializes the status of the migration
+	 */
+	public function __construct()
+	{
+		$this->_pretty_name = __('Update Invoice Settings', 'event_espresso');
+		parent::__construct();
+	}
 
 
 
-    /**
-     * _count_records_to_migrate
-     * Counts the records to migrate; the public version may cache it
-     *
-     * @access protected
-     * @return int
-     */
-    protected function _count_records_to_migrate()
-    {
-        return 1;
-    }
+	/**
+	 * _count_records_to_migrate
+	 * Counts the records to migrate; the public version may cache it
+	 *
+	 * @access protected
+	 * @return int
+	 */
+	protected function _count_records_to_migrate()
+	{
+		return 1;
+	}
 
 
 
-    /**
-     *    _migration_step
-     *
-     * @access protected
-     * @param int $num_items
-     * @throws EE_Error
-     * @return int number of items ACTUALLY migrated
-     * @throws InvalidDataTypeException
-     */
-    protected function _migration_step($num_items = 1)
-    {
+	/**
+	 *    _migration_step
+	 *
+	 * @access protected
+	 * @param int $num_items
+	 * @throws EE_Error
+	 * @return int number of items ACTUALLY migrated
+	 * @throws InvalidDataTypeException
+	 */
+	protected function _migration_step($num_items = 1)
+	{
 
-        $templates_relative_path = 'modules/gateways/Invoice/lib/templates/';
-        $overridden_invoice_body = EEH_Template::locate_template($templates_relative_path . 'invoice_body.template.php', null, false, false, true);
-        $overridden_receipt_body= EEH_Template::locate_template($templates_relative_path . 'receipt_body.template.php', null, false, false, true);
-        if ($overridden_invoice_body || $overridden_receipt_body) {
-            new PersistentAdminNotice(
-                'invoice_overriding_templates',
-                esc_html__(
-                    'Note: in this version of Event Espresso, PDF and HTML Invoices and Receipts are now Messages and can be changed just like any other messages; however we noticed you had previously overridden the old default Invoice/Receipt templates. Because of this, your old Invoice/Receipt templates will continue to be used INSTEAD of the new Invoice/Receipt message equivalents (but this will be removed in an upcoming version). We recommend deleting your old Invoice/Receipt templates and using the new messages system. Then modify the new Invoice and Receipt messages\'s content in Messages -> Invoice and Messages -> Receipt.',
-                    'event_espresso'
-                ),
-                true
-            );
-        }
+		$templates_relative_path = 'modules/gateways/Invoice/lib/templates/';
+		$overridden_invoice_body = EEH_Template::locate_template($templates_relative_path . 'invoice_body.template.php', null, false, false, true);
+		$overridden_receipt_body= EEH_Template::locate_template($templates_relative_path . 'receipt_body.template.php', null, false, false, true);
+		if ($overridden_invoice_body || $overridden_receipt_body) {
+			new PersistentAdminNotice(
+				'invoice_overriding_templates',
+				esc_html__(
+					'Note: in this version of Event Espresso, PDF and HTML Invoices and Receipts are now Messages and can be changed just like any other messages; however we noticed you had previously overridden the old default Invoice/Receipt templates. Because of this, your old Invoice/Receipt templates will continue to be used INSTEAD of the new Invoice/Receipt message equivalents (but this will be removed in an upcoming version). We recommend deleting your old Invoice/Receipt templates and using the new messages system. Then modify the new Invoice and Receipt messages\'s content in Messages -> Invoice and Messages -> Receipt.',
+					'event_espresso'
+				),
+				true
+			);
+		}
 
-        // regardless of whether it worked or not, we ought to continue the migration
-        $this->set_completed();
-        return 1;
-    }
+		// regardless of whether it worked or not, we ought to continue the migration
+		$this->set_completed();
+		return 1;
+	}
 }

Spacing +2 added lines, -2 removed lines

@@ -66,8 +66,8 @@
     {
 
         $templates_relative_path = 'modules/gateways/Invoice/lib/templates/';
-        $overridden_invoice_body = EEH_Template::locate_template($templates_relative_path . 'invoice_body.template.php', null, false, false, true);
-        $overridden_receipt_body= EEH_Template::locate_template($templates_relative_path . 'receipt_body.template.php', null, false, false, true);
+        $overridden_invoice_body = EEH_Template::locate_template($templates_relative_path.'invoice_body.template.php', null, false, false, true);
+        $overridden_receipt_body = EEH_Template::locate_template($templates_relative_path.'receipt_body.template.php', null, false, false, true);
         if ($overridden_invoice_body || $overridden_receipt_body) {
             new PersistentAdminNotice(
                 'invoice_overriding_templates',

core/data_migration_scripts/4_6_0_stages/EE_DMS_4_6_0_payments.dmsstage.php

Indentation +78 added lines, -78 removed lines

@@ -11,44 +11,44 @@ 
  */
 class EE_DMS_4_6_0_payments extends EE_Data_Migration_Script_Stage_Table
 {
-    protected $_payment_method_table;
-    public function __construct()
-    {
-        global $wpdb;
-        $this->_old_table = $wpdb->prefix . 'esp_payment';
-        $this->_payment_method_table = $wpdb->prefix . 'esp_payment_method';
-        $this->_pretty_name = __('Payment-Payment Method Relations', 'event_espresso');
-        parent::__construct();
-    }
-    protected function _migrate_old_row($payment_row)
-    {
-        global $wpdb;
-        // get the payment method's ID
-        $PMD_ID = apply_filters('FHEE__EE_DMS_4_6_0_payments__migrate_old_row__PMD_ID', $this->_get_payment_method_id_by_gateway_name($payment_row['PAY_gateway'], $payment_row['PAY_method']));
-        if (! $PMD_ID) {
-            $this->add_error(sprintf(__('Could not find payment method with PMD_type = \'%1$s\' when migrating payment row %2$s so just assigned it an unknown payment method', 'event_espresso'), $payment_row['PAY_gateway'], $this->_json_encode($payment_row)));
-            $PMD_ID = 0;
-        }
-        $new_values = array(
-            'PMD_ID' => $PMD_ID,
-            'PAY_source' => ( $payment_row['PAY_via_admin'] ? 'ADMIN' : 'CART' ) );
-        $wheres = array( 'PAY_ID' => $payment_row['PAY_ID'] );
-        $new_value_datatypes = array( '%d', '%s' );
-        $where_datatypes = array( '%d' );
-        $success = $wpdb->update(
-            $this->_old_table,
-            $new_values,
-            $wheres,
-            $new_value_datatypes,
-            $where_datatypes
-        );
-        if (! $success) {
-            $this->add_error(sprintf(__('Couldnt set %1$s row in table %2$s where %3$s', 'event_espresso'), $this->_json_encode($new_values), $this->_old_table, $this->_json_encode($wheres)));
-        }
-    }
-    /**
-     *
-     *  array(
+	protected $_payment_method_table;
+	public function __construct()
+	{
+		global $wpdb;
+		$this->_old_table = $wpdb->prefix . 'esp_payment';
+		$this->_payment_method_table = $wpdb->prefix . 'esp_payment_method';
+		$this->_pretty_name = __('Payment-Payment Method Relations', 'event_espresso');
+		parent::__construct();
+	}
+	protected function _migrate_old_row($payment_row)
+	{
+		global $wpdb;
+		// get the payment method's ID
+		$PMD_ID = apply_filters('FHEE__EE_DMS_4_6_0_payments__migrate_old_row__PMD_ID', $this->_get_payment_method_id_by_gateway_name($payment_row['PAY_gateway'], $payment_row['PAY_method']));
+		if (! $PMD_ID) {
+			$this->add_error(sprintf(__('Could not find payment method with PMD_type = \'%1$s\' when migrating payment row %2$s so just assigned it an unknown payment method', 'event_espresso'), $payment_row['PAY_gateway'], $this->_json_encode($payment_row)));
+			$PMD_ID = 0;
+		}
+		$new_values = array(
+			'PMD_ID' => $PMD_ID,
+			'PAY_source' => ( $payment_row['PAY_via_admin'] ? 'ADMIN' : 'CART' ) );
+		$wheres = array( 'PAY_ID' => $payment_row['PAY_ID'] );
+		$new_value_datatypes = array( '%d', '%s' );
+		$where_datatypes = array( '%d' );
+		$success = $wpdb->update(
+			$this->_old_table,
+			$new_values,
+			$wheres,
+			$new_value_datatypes,
+			$where_datatypes
+		);
+		if (! $success) {
+			$this->add_error(sprintf(__('Couldnt set %1$s row in table %2$s where %3$s', 'event_espresso'), $this->_json_encode($new_values), $this->_old_table, $this->_json_encode($wheres)));
+		}
+	}
+	/**
+	 *
+	 *  array(
             'PP' => __( 'PayPal', 'event_espresso' ),
             'CC' => __( 'Credit Card', 'event_espresso' ),
             'DB'=>  __("Debit Card", 'event_espresso'),
@@ -57,44 +57,44 @@ 
             'BK'=>  __("Bank", 'event_espresso'),
             'IV'=>  __("Invoice", 'event_espresso'),
             'MO'=>  __("Money Order", 'event_espresso'),
-     * @global type $wpdb
-     * @param int $id
-     * @return string
-     */
-    protected function _get_payment_method_id_by_gateway_name($gateway_name, $old_pay_method_column)
-    {
-        global $wpdb;
-        // convert from old known PAY_method values to their corresponding
-        // PMD_type or default PMD_name
-        switch ($old_pay_method_column) {
-            case 'PP':
-                $pmd_type = 'Paypal_Standard';
-                break;
-            case 'CC':
-                $pmd_type = 'Credit_Card';
-                break;
-            case 'DB':
-                $pmd_type = 'Debit_Card';
-                break;
-            case 'CHQ':
-                $pmd_type = 'Check';
-                break;
-            case 'CSH':
-                $pmd_type = 'Cash';
-                break;
-            case 'BK':
-                $pmd_type = 'Bank';
-                break;
-            case 'IV':
-                $pmd_type = 'Invoice';
-                break;
-            case 'MO':
-                $pmd_type = 'Money_Order';
-                break;
-            default:
-                $pmd_type = $gateway_name;
-        }
-        $pmd_name = str_replace("_", " ", $pmd_type);
-        return $wpdb->get_var($wpdb->prepare("SELECT PMD_ID FROM " . $wpdb->prefix . "esp_payment_method WHERE PMD_type = %s OR PMD_name = %s", $pmd_type, $pmd_name));
-    }
+	 * @global type $wpdb
+	 * @param int $id
+	 * @return string
+	 */
+	protected function _get_payment_method_id_by_gateway_name($gateway_name, $old_pay_method_column)
+	{
+		global $wpdb;
+		// convert from old known PAY_method values to their corresponding
+		// PMD_type or default PMD_name
+		switch ($old_pay_method_column) {
+			case 'PP':
+				$pmd_type = 'Paypal_Standard';
+				break;
+			case 'CC':
+				$pmd_type = 'Credit_Card';
+				break;
+			case 'DB':
+				$pmd_type = 'Debit_Card';
+				break;
+			case 'CHQ':
+				$pmd_type = 'Check';
+				break;
+			case 'CSH':
+				$pmd_type = 'Cash';
+				break;
+			case 'BK':
+				$pmd_type = 'Bank';
+				break;
+			case 'IV':
+				$pmd_type = 'Invoice';
+				break;
+			case 'MO':
+				$pmd_type = 'Money_Order';
+				break;
+			default:
+				$pmd_type = $gateway_name;
+		}
+		$pmd_name = str_replace("_", " ", $pmd_type);
+		return $wpdb->get_var($wpdb->prepare("SELECT PMD_ID FROM " . $wpdb->prefix . "esp_payment_method WHERE PMD_type = %s OR PMD_name = %s", $pmd_type, $pmd_name));
+	}
 }

Spacing +9 added lines, -9 removed lines

@@ -15,8 +15,8 @@ 
     public function __construct()
     {
         global $wpdb;
-        $this->_old_table = $wpdb->prefix . 'esp_payment';
-        $this->_payment_method_table = $wpdb->prefix . 'esp_payment_method';
+        $this->_old_table = $wpdb->prefix.'esp_payment';
+        $this->_payment_method_table = $wpdb->prefix.'esp_payment_method';
         $this->_pretty_name = __('Payment-Payment Method Relations', 'event_espresso');
         parent::__construct();
     }
@@ -25,16 +25,16 @@ 
         global $wpdb;
         // get the payment method's ID
         $PMD_ID = apply_filters('FHEE__EE_DMS_4_6_0_payments__migrate_old_row__PMD_ID', $this->_get_payment_method_id_by_gateway_name($payment_row['PAY_gateway'], $payment_row['PAY_method']));
-        if (! $PMD_ID) {
+        if ( ! $PMD_ID) {
             $this->add_error(sprintf(__('Could not find payment method with PMD_type = \'%1$s\' when migrating payment row %2$s so just assigned it an unknown payment method', 'event_espresso'), $payment_row['PAY_gateway'], $this->_json_encode($payment_row)));
             $PMD_ID = 0;
         }
         $new_values = array(
             'PMD_ID' => $PMD_ID,
-            'PAY_source' => ( $payment_row['PAY_via_admin'] ? 'ADMIN' : 'CART' ) );
-        $wheres = array( 'PAY_ID' => $payment_row['PAY_ID'] );
-        $new_value_datatypes = array( '%d', '%s' );
-        $where_datatypes = array( '%d' );
+            'PAY_source' => ($payment_row['PAY_via_admin'] ? 'ADMIN' : 'CART') );
+        $wheres = array('PAY_ID' => $payment_row['PAY_ID']);
+        $new_value_datatypes = array('%d', '%s');
+        $where_datatypes = array('%d');
         $success = $wpdb->update(
             $this->_old_table,
             $new_values,
@@ -42,7 +42,7 @@ 
             $new_value_datatypes,
             $where_datatypes
         );
-        if (! $success) {
+        if ( ! $success) {
             $this->add_error(sprintf(__('Couldnt set %1$s row in table %2$s where %3$s', 'event_espresso'), $this->_json_encode($new_values), $this->_old_table, $this->_json_encode($wheres)));
         }
     }
@@ -95,6 +95,6 @@ 
                 $pmd_type = $gateway_name;
         }
         $pmd_name = str_replace("_", " ", $pmd_type);
-        return $wpdb->get_var($wpdb->prepare("SELECT PMD_ID FROM " . $wpdb->prefix . "esp_payment_method WHERE PMD_type = %s OR PMD_name = %s", $pmd_type, $pmd_name));
+        return $wpdb->get_var($wpdb->prepare("SELECT PMD_ID FROM ".$wpdb->prefix."esp_payment_method WHERE PMD_type = %s OR PMD_name = %s", $pmd_type, $pmd_name));
     }
 }

core/data_migration_scripts/4_6_0_stages/EE_DMS_4_6_0_transactions.dmsstage.php

Indentation +47 added lines, -47 removed lines

@@ -11,51 +11,51 @@
  */
 class EE_DMS_4_6_0_transactions extends EE_Data_Migration_Script_Stage_Table
 {
-    protected $_transaction_table;
-    protected $_payment_method_table;
-    public function __construct()
-    {
-        global $wpdb;
-        $this->_old_table = $wpdb->prefix . 'esp_extra_meta';
-        $this->_transaction_table = $wpdb->prefix . 'esp_transaction';
-        $this->_payment_method_table = $wpdb->prefix . 'esp_payment_method';
-        $this->_pretty_name = __('Transaction Payment Method Relations', 'event_espresso');
-        $this->_extra_where_sql = "WHERE EXM_key = 'gateway' AND EXM_type = 'Transaction'";
-        parent::__construct();
-    }
-    protected function _migrate_old_row($extra_meta_row)
-    {
-        global $wpdb;
-        // get the payment method's ID
-        $PMD_ID = $this->_get_payment_method_id_by_gateway_name($extra_meta_row['EXM_value']);
-        if (! $PMD_ID) {
-            $this->add_error(sprintf(__('Could not find payment method with PMD_type = \'%1$s\' when migrating extra meta row %2$s', 'event_espresso'), $extra_meta_row['EXM_value'], $this->_json_encode($extra_meta_row)));
-            return;
-        }
-        $new_values = array( 'PMD_ID' => $PMD_ID );
-        $wheres = array( 'TXN_ID' => $extra_meta_row['OBJ_ID'] );
-        $new_value_datatypes = array( '%d' );
-        $where_datatypes = array( '%d' );
-        $success = $wpdb->update(
-            $this->_transaction_table,
-            $new_values,
-            $wheres,
-            $new_value_datatypes,
-            $where_datatypes
-        );
-        if (! $success) {
-            $this->add_error(sprintf(__('Couldnt set %1$s row in table %2$s where %3$s', 'event_espresso'), $this->_json_encode($new_values), $this->_transaction_table, $this->_json_encode($wheres)));
-        }
-    }
-    /**
-     *
-     * @global type $wpdb
-     * @param int $id
-     * @return string
-     */
-    protected function _get_payment_method_id_by_gateway_name($gateway_name)
-    {
-        global $wpdb;
-        return $wpdb->get_var($wpdb->prepare("SELECT PMD_ID FROM " . $wpdb->prefix . "esp_payment_method WHERE PMD_type = %s", $gateway_name));
-    }
+	protected $_transaction_table;
+	protected $_payment_method_table;
+	public function __construct()
+	{
+		global $wpdb;
+		$this->_old_table = $wpdb->prefix . 'esp_extra_meta';
+		$this->_transaction_table = $wpdb->prefix . 'esp_transaction';
+		$this->_payment_method_table = $wpdb->prefix . 'esp_payment_method';
+		$this->_pretty_name = __('Transaction Payment Method Relations', 'event_espresso');
+		$this->_extra_where_sql = "WHERE EXM_key = 'gateway' AND EXM_type = 'Transaction'";
+		parent::__construct();
+	}
+	protected function _migrate_old_row($extra_meta_row)
+	{
+		global $wpdb;
+		// get the payment method's ID
+		$PMD_ID = $this->_get_payment_method_id_by_gateway_name($extra_meta_row['EXM_value']);
+		if (! $PMD_ID) {
+			$this->add_error(sprintf(__('Could not find payment method with PMD_type = \'%1$s\' when migrating extra meta row %2$s', 'event_espresso'), $extra_meta_row['EXM_value'], $this->_json_encode($extra_meta_row)));
+			return;
+		}
+		$new_values = array( 'PMD_ID' => $PMD_ID );
+		$wheres = array( 'TXN_ID' => $extra_meta_row['OBJ_ID'] );
+		$new_value_datatypes = array( '%d' );
+		$where_datatypes = array( '%d' );
+		$success = $wpdb->update(
+			$this->_transaction_table,
+			$new_values,
+			$wheres,
+			$new_value_datatypes,
+			$where_datatypes
+		);
+		if (! $success) {
+			$this->add_error(sprintf(__('Couldnt set %1$s row in table %2$s where %3$s', 'event_espresso'), $this->_json_encode($new_values), $this->_transaction_table, $this->_json_encode($wheres)));
+		}
+	}
+	/**
+	 *
+	 * @global type $wpdb
+	 * @param int $id
+	 * @return string
+	 */
+	protected function _get_payment_method_id_by_gateway_name($gateway_name)
+	{
+		global $wpdb;
+		return $wpdb->get_var($wpdb->prepare("SELECT PMD_ID FROM " . $wpdb->prefix . "esp_payment_method WHERE PMD_type = %s", $gateway_name));
+	}
 }

Spacing +10 added lines, -10 removed lines

@@ -16,9 +16,9 @@ 
     public function __construct()
     {
         global $wpdb;
-        $this->_old_table = $wpdb->prefix . 'esp_extra_meta';
-        $this->_transaction_table = $wpdb->prefix . 'esp_transaction';
-        $this->_payment_method_table = $wpdb->prefix . 'esp_payment_method';
+        $this->_old_table = $wpdb->prefix.'esp_extra_meta';
+        $this->_transaction_table = $wpdb->prefix.'esp_transaction';
+        $this->_payment_method_table = $wpdb->prefix.'esp_payment_method';
         $this->_pretty_name = __('Transaction Payment Method Relations', 'event_espresso');
         $this->_extra_where_sql = "WHERE EXM_key = 'gateway' AND EXM_type = 'Transaction'";
         parent::__construct();
@@ -28,14 +28,14 @@ 
         global $wpdb;
         // get the payment method's ID
         $PMD_ID = $this->_get_payment_method_id_by_gateway_name($extra_meta_row['EXM_value']);
-        if (! $PMD_ID) {
+        if ( ! $PMD_ID) {
             $this->add_error(sprintf(__('Could not find payment method with PMD_type = \'%1$s\' when migrating extra meta row %2$s', 'event_espresso'), $extra_meta_row['EXM_value'], $this->_json_encode($extra_meta_row)));
             return;
         }
-        $new_values = array( 'PMD_ID' => $PMD_ID );
-        $wheres = array( 'TXN_ID' => $extra_meta_row['OBJ_ID'] );
-        $new_value_datatypes = array( '%d' );
-        $where_datatypes = array( '%d' );
+        $new_values = array('PMD_ID' => $PMD_ID);
+        $wheres = array('TXN_ID' => $extra_meta_row['OBJ_ID']);
+        $new_value_datatypes = array('%d');
+        $where_datatypes = array('%d');
         $success = $wpdb->update(
             $this->_transaction_table,
             $new_values,
@@ -43,7 +43,7 @@ 
             $new_value_datatypes,
             $where_datatypes
         );
-        if (! $success) {
+        if ( ! $success) {
             $this->add_error(sprintf(__('Couldnt set %1$s row in table %2$s where %3$s', 'event_espresso'), $this->_json_encode($new_values), $this->_transaction_table, $this->_json_encode($wheres)));
         }
     }
@@ -56,6 +56,6 @@ 
     protected function _get_payment_method_id_by_gateway_name($gateway_name)
     {
         global $wpdb;
-        return $wpdb->get_var($wpdb->prepare("SELECT PMD_ID FROM " . $wpdb->prefix . "esp_payment_method WHERE PMD_type = %s", $gateway_name));
+        return $wpdb->get_var($wpdb->prepare("SELECT PMD_ID FROM ".$wpdb->prefix."esp_payment_method WHERE PMD_type = %s", $gateway_name));
     }
 }

core/data_migration_scripts/4_6_0_stages/EE_DMS_4_6_0_billing_info.dmsstage.php

Indentation +64 added lines, -64 removed lines

@@ -11,69 +11,69 @@
  */
 class EE_DMS_4_6_0_billing_info extends EE_Data_Migration_Script_Stage_Table
 {
-    public function __construct()
-    {
-        global $wpdb;
-        $this->_old_table = $wpdb->postmeta;
-        $this->_pretty_name = __('Billing Info', 'event_espresso');
-        $this->_extra_where_sql = "WHERE meta_key LIKE 'billing_info_%'";
-        parent::__construct();
-    }
-    protected function _migrate_old_row($old_row)
-    {
-        $new_billing_info = array();
-        $old_billing_info = maybe_unserialize($old_row['meta_value']);
-        $gateway_name = str_replace("billing_info_", '', $old_row['meta_key']);
-        $repetitive_prefix = '_reg-page-billing-';
-        $repetitive_suffix = "-" . $gateway_name;
-        foreach ($old_billing_info as $old_input_name => $input_value) {
-            $old_input_name_important_part = str_replace(array( $repetitive_prefix, $repetitive_suffix ), array( '', ''), $old_input_name);
+	public function __construct()
+	{
+		global $wpdb;
+		$this->_old_table = $wpdb->postmeta;
+		$this->_pretty_name = __('Billing Info', 'event_espresso');
+		$this->_extra_where_sql = "WHERE meta_key LIKE 'billing_info_%'";
+		parent::__construct();
+	}
+	protected function _migrate_old_row($old_row)
+	{
+		$new_billing_info = array();
+		$old_billing_info = maybe_unserialize($old_row['meta_value']);
+		$gateway_name = str_replace("billing_info_", '', $old_row['meta_key']);
+		$repetitive_prefix = '_reg-page-billing-';
+		$repetitive_suffix = "-" . $gateway_name;
+		foreach ($old_billing_info as $old_input_name => $input_value) {
+			$old_input_name_important_part = str_replace(array( $repetitive_prefix, $repetitive_suffix ), array( '', ''), $old_input_name);
 
-            switch ($old_input_name_important_part) {
-                case 'fname':
-                    $new_input_name = 'first_name';
-                    break;
-                case 'lname':
-                    $new_input_name = 'last_name';
-                    break;
-                case 'state':
-                    // we used to store the state's id ,but now we just store the name
-                    $new_input_name = $old_input_name_important_part;
-                    $input_value = $this->_get_state_name_by_ID($input_value);
-                    break;
-                case 'card-nmbr':
-                    $new_input_name = 'credit_card';
-                    break;
-                case 'card-type':// paypal pro only
-                    $new_input_name = 'credit_card_type';
-                    break;
-                case 'card-exp-date-mnth':
-                    $new_input_name = 'exp_month';
-                    $input_value = '';
-                    break;
-                case 'card-exp-date-year':
-                    $new_input_name = 'exp_year';
-                    $input_value = 0;
-                    break;
-                case 'ccv-code':
-                    $new_input_name = 'cvv';
-                    break;
-                default:
-                    $new_input_name = $old_input_name_important_part;
-            }
-            $new_billing_info[ $new_input_name ] = $input_value;
-        }
-        update_post_meta($old_row['post_id'], $old_row['meta_key'], $new_billing_info);
-    }
-    /**
-     *
-     * @global type $wpdb
-     * @param int $id
-     * @return string
-     */
-    protected function _get_state_name_by_ID($id)
-    {
-        global $wpdb;
-        return $wpdb->get_var($wpdb->prepare("SELECT STA_name FROM " . $wpdb->prefix . "esp_state WHERE STA_ID = %d", $id));
-    }
+			switch ($old_input_name_important_part) {
+				case 'fname':
+					$new_input_name = 'first_name';
+					break;
+				case 'lname':
+					$new_input_name = 'last_name';
+					break;
+				case 'state':
+					// we used to store the state's id ,but now we just store the name
+					$new_input_name = $old_input_name_important_part;
+					$input_value = $this->_get_state_name_by_ID($input_value);
+					break;
+				case 'card-nmbr':
+					$new_input_name = 'credit_card';
+					break;
+				case 'card-type':// paypal pro only
+					$new_input_name = 'credit_card_type';
+					break;
+				case 'card-exp-date-mnth':
+					$new_input_name = 'exp_month';
+					$input_value = '';
+					break;
+				case 'card-exp-date-year':
+					$new_input_name = 'exp_year';
+					$input_value = 0;
+					break;
+				case 'ccv-code':
+					$new_input_name = 'cvv';
+					break;
+				default:
+					$new_input_name = $old_input_name_important_part;
+			}
+			$new_billing_info[ $new_input_name ] = $input_value;
+		}
+		update_post_meta($old_row['post_id'], $old_row['meta_key'], $new_billing_info);
+	}
+	/**
+	 *
+	 * @global type $wpdb
+	 * @param int $id
+	 * @return string
+	 */
+	protected function _get_state_name_by_ID($id)
+	{
+		global $wpdb;
+		return $wpdb->get_var($wpdb->prepare("SELECT STA_name FROM " . $wpdb->prefix . "esp_state WHERE STA_ID = %d", $id));
+	}
 }

Spacing +4 added lines, -4 removed lines

@@ -25,9 +25,9 @@ 
         $old_billing_info = maybe_unserialize($old_row['meta_value']);
         $gateway_name = str_replace("billing_info_", '', $old_row['meta_key']);
         $repetitive_prefix = '_reg-page-billing-';
-        $repetitive_suffix = "-" . $gateway_name;
+        $repetitive_suffix = "-".$gateway_name;
         foreach ($old_billing_info as $old_input_name => $input_value) {
-            $old_input_name_important_part = str_replace(array( $repetitive_prefix, $repetitive_suffix ), array( '', ''), $old_input_name);
+            $old_input_name_important_part = str_replace(array($repetitive_prefix, $repetitive_suffix), array('', ''), $old_input_name);
 
             switch ($old_input_name_important_part) {
                 case 'fname':
@@ -61,7 +61,7 @@ 
                 default:
                     $new_input_name = $old_input_name_important_part;
             }
-            $new_billing_info[ $new_input_name ] = $input_value;
+            $new_billing_info[$new_input_name] = $input_value;
         }
         update_post_meta($old_row['post_id'], $old_row['meta_key'], $new_billing_info);
     }
@@ -74,6 +74,6 @@ 
     protected function _get_state_name_by_ID($id)
     {
         global $wpdb;
-        return $wpdb->get_var($wpdb->prepare("SELECT STA_name FROM " . $wpdb->prefix . "esp_state WHERE STA_ID = %d", $id));
+        return $wpdb->get_var($wpdb->prepare("SELECT STA_name FROM ".$wpdb->prefix."esp_state WHERE STA_ID = %d", $id));
     }
 }

core/data_migration_scripts/4_6_0_stages/EE_DMS_4_6_0_question_types.dmsstage.php

Indentation +49 added lines, -49 removed lines

@@ -12,57 +12,57 @@
 class EE_DMS_4_6_0_question_types extends EE_Data_Migration_Script_Stage_Table
 {
 
-    protected $_question_type_conversions = array();
+	protected $_question_type_conversions = array();
 
 
 
-    /**
-     * Just initializes the status of the migration
-     *
-     * @return EE_DMS_4_6_0_question_types
-     */
-    public function __construct()
-    {
-        global $wpdb;
-        $this->_pretty_name = __('Question Types', 'event_espresso');
-        $this->_old_table = $wpdb->prefix.'esp_question';
-        $this->_question_type_conversions = array(
-            'MULTIPLE'          => 'CHECKBOX',
-            'SINGLE'                => 'RADIO_BTN'
-        );
-        // when fetching rows, because we automatically use a limit and offset
-        // rows counted before migrating any rows, need to ALSO be counted after a bunch of rows were counted
-        // so we need to include both the migrated rows as well as the non-migrated rows
-        $QST_types_to_count = array_merge(array_keys($this->_question_type_conversions), $this->_question_type_conversions);
-        $this->_extra_where_sql = "WHERE QST_type IN ('" . implode("', '", $QST_types_to_count) . "')" ;
-        parent::__construct();
-    }
+	/**
+	 * Just initializes the status of the migration
+	 *
+	 * @return EE_DMS_4_6_0_question_types
+	 */
+	public function __construct()
+	{
+		global $wpdb;
+		$this->_pretty_name = __('Question Types', 'event_espresso');
+		$this->_old_table = $wpdb->prefix.'esp_question';
+		$this->_question_type_conversions = array(
+			'MULTIPLE'          => 'CHECKBOX',
+			'SINGLE'                => 'RADIO_BTN'
+		);
+		// when fetching rows, because we automatically use a limit and offset
+		// rows counted before migrating any rows, need to ALSO be counted after a bunch of rows were counted
+		// so we need to include both the migrated rows as well as the non-migrated rows
+		$QST_types_to_count = array_merge(array_keys($this->_question_type_conversions), $this->_question_type_conversions);
+		$this->_extra_where_sql = "WHERE QST_type IN ('" . implode("', '", $QST_types_to_count) . "')" ;
+		parent::__construct();
+	}
 
-    /**
-     * @param array $question an associative array where keys are column names and values are their values.
-     * @return null
-     */
-    protected function _migrate_old_row($question)
-    {
-        global $wpdb;
-        if ($question['QST_ID'] && isset($this->_question_type_conversions[ $question['QST_type'] ])) {
-            $success = $wpdb->update(
-                $this->_old_table,
-                array( 'QST_type' => $this->_question_type_conversions[ $question['QST_type'] ] ),  // data
-                array( 'QST_ID' => $question['QST_ID'] ),  // where
-                array( '%s' ),   // data format
-                array( '%d' )  // where format
-            );
-            if (! $success) {
-                $this->add_error(
-                    sprintf(
-                        __('Could not update question type %1$s for question ID=%2$d because "%3$s"', 'event_espresso'),
-                        wp_json_encode($question['QST_type']),
-                        $question['QST_ID'],
-                        $wpdb->last_error
-                    )
-                );
-            }
-        }
-    }
+	/**
+	 * @param array $question an associative array where keys are column names and values are their values.
+	 * @return null
+	 */
+	protected function _migrate_old_row($question)
+	{
+		global $wpdb;
+		if ($question['QST_ID'] && isset($this->_question_type_conversions[ $question['QST_type'] ])) {
+			$success = $wpdb->update(
+				$this->_old_table,
+				array( 'QST_type' => $this->_question_type_conversions[ $question['QST_type'] ] ),  // data
+				array( 'QST_ID' => $question['QST_ID'] ),  // where
+				array( '%s' ),   // data format
+				array( '%d' )  // where format
+			);
+			if (! $success) {
+				$this->add_error(
+					sprintf(
+						__('Could not update question type %1$s for question ID=%2$d because "%3$s"', 'event_espresso'),
+						wp_json_encode($question['QST_type']),
+						$question['QST_ID'],
+						$wpdb->last_error
+					)
+				);
+			}
+		}
+	}
 }

Spacing +7 added lines, -7 removed lines

@@ -34,7 +34,7 @@ 
         // rows counted before migrating any rows, need to ALSO be counted after a bunch of rows were counted
         // so we need to include both the migrated rows as well as the non-migrated rows
         $QST_types_to_count = array_merge(array_keys($this->_question_type_conversions), $this->_question_type_conversions);
-        $this->_extra_where_sql = "WHERE QST_type IN ('" . implode("', '", $QST_types_to_count) . "')" ;
+        $this->_extra_where_sql = "WHERE QST_type IN ('".implode("', '", $QST_types_to_count)."')";
         parent::__construct();
     }
 
@@ -45,15 +45,15 @@ 
     protected function _migrate_old_row($question)
     {
         global $wpdb;
-        if ($question['QST_ID'] && isset($this->_question_type_conversions[ $question['QST_type'] ])) {
+        if ($question['QST_ID'] && isset($this->_question_type_conversions[$question['QST_type']])) {
             $success = $wpdb->update(
                 $this->_old_table,
-                array( 'QST_type' => $this->_question_type_conversions[ $question['QST_type'] ] ),  // data
-                array( 'QST_ID' => $question['QST_ID'] ),  // where
-                array( '%s' ),   // data format
-                array( '%d' )  // where format
+                array('QST_type' => $this->_question_type_conversions[$question['QST_type']]), // data
+                array('QST_ID' => $question['QST_ID']), // where
+                array('%s'), // data format
+                array('%d')  // where format
             );
-            if (! $success) {
+            if ( ! $success) {
                 $this->add_error(
                     sprintf(
                         __('Could not update question type %1$s for question ID=%2$d because "%3$s"', 'event_espresso'),

core/data_migration_scripts/4_6_0_stages/EE_DMS_4_6_0_gateways.dmsstage.php

Indentation +256 added lines, -256 removed lines

@@ -14,277 +14,277 @@
 class EE_DMS_4_6_0_gateways extends EE_Data_Migration_Script_Stage
 {
 
-    protected $_new_table_name;
-    protected $_extra_meta_table_name;
-    protected $_currency_table_name;
-    protected $_currency_payment_method_table_name;
+	protected $_new_table_name;
+	protected $_extra_meta_table_name;
+	protected $_currency_table_name;
+	protected $_currency_payment_method_table_name;
 
-    /**
-     * each key is the name of a 4.1-style gateway we know how to migrate to 4.6
-     * @var array
-     */
-    protected $_gateway_we_know_to_migrate = array(
-        'Aim',
-        'Bank',
-        'Check',
-        'Invoice',
-        'Mijireh',
-        'Paypal_Pro',
-        'Paypal_Standard',
-    );
+	/**
+	 * each key is the name of a 4.1-style gateway we know how to migrate to 4.6
+	 * @var array
+	 */
+	protected $_gateway_we_know_to_migrate = array(
+		'Aim',
+		'Bank',
+		'Check',
+		'Invoice',
+		'Mijireh',
+		'Paypal_Pro',
+		'Paypal_Standard',
+	);
 
 
 
-    /**
-     * Just initializes the status of the migration
-     */
-    public function __construct()
-    {
-        global $wpdb;
-        $this->_new_table_name = $wpdb->prefix."esp_payment_method";
-        $this->_extra_meta_table_name = $wpdb->prefix."esp_extra_meta";
-        $this->_currency_table_name = $wpdb->prefix."esp_currency";
-        $this->_currency_payment_method_table_name = $wpdb->prefix."esp_currency_payment_method";
-        $this->_pretty_name = __('Gateways', 'event_espresso');
-        parent::__construct();
-    }
+	/**
+	 * Just initializes the status of the migration
+	 */
+	public function __construct()
+	{
+		global $wpdb;
+		$this->_new_table_name = $wpdb->prefix."esp_payment_method";
+		$this->_extra_meta_table_name = $wpdb->prefix."esp_extra_meta";
+		$this->_currency_table_name = $wpdb->prefix."esp_currency";
+		$this->_currency_payment_method_table_name = $wpdb->prefix."esp_currency_payment_method";
+		$this->_pretty_name = __('Gateways', 'event_espresso');
+		parent::__construct();
+	}
 
 
 
-    /**
-     * Counts the records to migrate; the public version may cache it
-     * @return int
-     */
-    protected function _count_records_to_migrate()
-    {
-        return count(EE_Config::instance()->gateway->payment_settings);
-    }
+	/**
+	 * Counts the records to migrate; the public version may cache it
+	 * @return int
+	 */
+	protected function _count_records_to_migrate()
+	{
+		return count(EE_Config::instance()->gateway->payment_settings);
+	}
 
 
 
-    /**
-     * IMPORTANT: if an error is encountered, or everything is finished, this stage should update its status property accordingly.
-     * Note: it should not alter the count of items migrated. That is done in the public function that calls this.
-     * IMPORTANT: The count of items migrated should ONLY be less than $num_items_to_migrate when it's the last migration step, otherwise it
-     * should always return $num_items_to_migrate. (Eg, if we're migrating attendees rows from the database, and $num_items_to_migrate is set to 50,
-     * then we SHOULD actually migrate 50 rows,but at very least we MUST report/return 50 items migrated)
-     * @param int $num_items_to_migrate
-     * @return int number of items ACTUALLY migrated
-     */
-    protected function _migration_step($num_items_to_migrate = 50)
-    {
-        $items_actually_migrated = 0;
-        $gateways_to_deal_with = array_slice(EE_Config::instance()->gateway->payment_settings, $this->count_records_migrated(), $num_items_to_migrate);
-        foreach ($gateways_to_deal_with as $old_gateway_slug => $old_gateway_settings) {
-            if (in_array($old_gateway_slug, $this->_gateway_we_know_to_migrate)) {
-                if (! $old_gateway_settings) {
-                    // no settings existed for this gateway anyways... weird...
-                    $items_actually_migrated++;
-                    continue;
-                }
-                // now prepare the settings to make sure they're in the 4.1 format
-                $success = $this->_convert_gateway_settings(
-                    $old_gateway_slug,
-                    $old_gateway_settings,
-                    isset(EE_Config::instance()->gateway->active_gateways[ $old_gateway_slug ])
-                );
-                if ($success) {
-                    EE_Config::instance()->gateway->payment_settings[ $old_gateway_slug ] = 'Deprecated';
-                }
-            }
-            $items_actually_migrated++;
-        }
+	/**
+	 * IMPORTANT: if an error is encountered, or everything is finished, this stage should update its status property accordingly.
+	 * Note: it should not alter the count of items migrated. That is done in the public function that calls this.
+	 * IMPORTANT: The count of items migrated should ONLY be less than $num_items_to_migrate when it's the last migration step, otherwise it
+	 * should always return $num_items_to_migrate. (Eg, if we're migrating attendees rows from the database, and $num_items_to_migrate is set to 50,
+	 * then we SHOULD actually migrate 50 rows,but at very least we MUST report/return 50 items migrated)
+	 * @param int $num_items_to_migrate
+	 * @return int number of items ACTUALLY migrated
+	 */
+	protected function _migration_step($num_items_to_migrate = 50)
+	{
+		$items_actually_migrated = 0;
+		$gateways_to_deal_with = array_slice(EE_Config::instance()->gateway->payment_settings, $this->count_records_migrated(), $num_items_to_migrate);
+		foreach ($gateways_to_deal_with as $old_gateway_slug => $old_gateway_settings) {
+			if (in_array($old_gateway_slug, $this->_gateway_we_know_to_migrate)) {
+				if (! $old_gateway_settings) {
+					// no settings existed for this gateway anyways... weird...
+					$items_actually_migrated++;
+					continue;
+				}
+				// now prepare the settings to make sure they're in the 4.1 format
+				$success = $this->_convert_gateway_settings(
+					$old_gateway_slug,
+					$old_gateway_settings,
+					isset(EE_Config::instance()->gateway->active_gateways[ $old_gateway_slug ])
+				);
+				if ($success) {
+					EE_Config::instance()->gateway->payment_settings[ $old_gateway_slug ] = 'Deprecated';
+				}
+			}
+			$items_actually_migrated++;
+		}
 
-        EE_Config::instance()->update_espresso_config(false, false);
-        if ($this->count_records_migrated() + $items_actually_migrated >= $this->count_records_to_migrate()) {
-            $this->set_completed();
-        }
-        return $items_actually_migrated;
-    }
+		EE_Config::instance()->update_espresso_config(false, false);
+		if ($this->count_records_migrated() + $items_actually_migrated >= $this->count_records_to_migrate()) {
+			$this->set_completed();
+		}
+		return $items_actually_migrated;
+	}
 
-    /**
-     * Converts the 4.1-style gateway to a 4.6-style payment method and saves it to the DB
-     * @param string $old_gateway_slug
-     * @param array $old_gateway_settings
-     * @param boolean $active indicates the gateway is currently active
-     * @return boolean success
-     */
-    protected function _convert_gateway_settings($old_gateway_slug, $old_gateway_settings, $active)
-    {
-        switch ($old_gateway_slug) {
-            case 'Aim':
-                $extra_meta_key_values = array(
-                    'login_id'=>$old_gateway_settings['authnet_aim_login_id'],
-                    'transaction_key'=>$old_gateway_settings['authnet_aim_transaction_key'],
-                    'test_transactions'=>$old_gateway_settings['test_transactions']
-                );
-                $desc = __('Please provide the following billing information.', 'event_espresso');
-                break;
-            case 'Bank':
-                $extra_meta_key_values = array(
-                    'page_title'=>$old_gateway_settings['page_title'],
-                    'payment_instructions'=>
-                    sprintf(__('%1$s<br/>Name on Bank Account: %2$s<br/>Bank Account Number: %3$s<br/>Bank Name: %4$s<br/>Bank Address:%5$s', 'event_espresso'), $old_gateway_settings['bank_instructions'], $old_gateway_settings['account_name'], $old_gateway_settings['account_number'], $old_gateway_settings['bank_name'], $old_gateway_settings['bank_address']) );
-                $desc = __('Make payment using an electronic funds transfer from your bank.', 'event_espresso');
-                break;
-            case 'Check':
-                $extra_meta_key_values = array(
-                    'check_title'=> $old_gateway_settings['check_title'],
-                    'payment_instructions'=>$old_gateway_settings['check_instructions'],
-                    'address_to_send_payment'=>$old_gateway_settings['payment_address']
-                );
-                $desc = __('On the next page you will be given instructions on how to make a payment by check.', 'event_espresso');
-                break;
-            case 'Invoice':
-                $extra_meta_key_values = array(
-                    'pdf_payee_name' => $old_gateway_settings['template_invoice_payee_name'],
-                    'pdf_payee_email' => $old_gateway_settings['template_invoice_email'],
-                    'pdf_payee_tax_number' => $old_gateway_settings['template_invoice_tax_number'],
-                    'pdf_payee_address' => $old_gateway_settings['template_invoice_address'],
-                    'pdf_instructions' => $old_gateway_settings['template_payment_instructions'],
-                    'pdf_logo_image' => $old_gateway_settings['invoice_logo_url'],
-                    'page_confirmation_text' => isset($old_gateway_settings['page_instructions']) ? $old_gateway_settings['page_instructions'] : '',
-                    'page_extra_info' => isset($old_gateway_settings['payment_address']) ? $old_gateway_settings['payment_address'] : '',
-                    'legacy_invoice_css' => $old_gateway_settings['invoice_css']
-                );
-                // if they didnt want the invoiec gateway to show, pretend it was inactive
-                if (! $old_gateway_settings['show']) {
-                    $active = false;
-                }
-                $desc = __('On the next page you will be able to access your invoice and instructions on how to pay it.', 'event_espresso');
-                break;
-            case 'Mijireh':
-                $extra_meta_key_values = array(
-                    'access_key' => $old_gateway_settings['access_key']
-                );
-                $desc =  __('On the next page you will be able to enter your billing information to make the payment.', 'event_espresso');
-                break;
-            case 'Paypal_Pro':
-                $extra_meta_key_values = array(
-                    'username'=>$old_gateway_settings['username'],
-                    'password'=>$old_gateway_settings['password'],
-                    'signature'=>$old_gateway_settings['signature'],
-                    'credit_card_types'=>$old_gateway_settings['credit_cards'],
-                );
-                $desc = __('Please provide the following billing information.', 'event_espresso');
-                break;
-            case 'Paypal_Standard':
-                $extra_meta_key_values = array(
-                    'paypal_id' => $old_gateway_settings['paypal_id'],
-                    'image_url' => $old_gateway_settings['image_url'],
-                    'shipping_details' => isset($old_gateway_settings['no_shipping']) ? $old_gateway_settings['no_shipping'] : false,
+	/**
+	 * Converts the 4.1-style gateway to a 4.6-style payment method and saves it to the DB
+	 * @param string $old_gateway_slug
+	 * @param array $old_gateway_settings
+	 * @param boolean $active indicates the gateway is currently active
+	 * @return boolean success
+	 */
+	protected function _convert_gateway_settings($old_gateway_slug, $old_gateway_settings, $active)
+	{
+		switch ($old_gateway_slug) {
+			case 'Aim':
+				$extra_meta_key_values = array(
+					'login_id'=>$old_gateway_settings['authnet_aim_login_id'],
+					'transaction_key'=>$old_gateway_settings['authnet_aim_transaction_key'],
+					'test_transactions'=>$old_gateway_settings['test_transactions']
+				);
+				$desc = __('Please provide the following billing information.', 'event_espresso');
+				break;
+			case 'Bank':
+				$extra_meta_key_values = array(
+					'page_title'=>$old_gateway_settings['page_title'],
+					'payment_instructions'=>
+					sprintf(__('%1$s<br/>Name on Bank Account: %2$s<br/>Bank Account Number: %3$s<br/>Bank Name: %4$s<br/>Bank Address:%5$s', 'event_espresso'), $old_gateway_settings['bank_instructions'], $old_gateway_settings['account_name'], $old_gateway_settings['account_number'], $old_gateway_settings['bank_name'], $old_gateway_settings['bank_address']) );
+				$desc = __('Make payment using an electronic funds transfer from your bank.', 'event_espresso');
+				break;
+			case 'Check':
+				$extra_meta_key_values = array(
+					'check_title'=> $old_gateway_settings['check_title'],
+					'payment_instructions'=>$old_gateway_settings['check_instructions'],
+					'address_to_send_payment'=>$old_gateway_settings['payment_address']
+				);
+				$desc = __('On the next page you will be given instructions on how to make a payment by check.', 'event_espresso');
+				break;
+			case 'Invoice':
+				$extra_meta_key_values = array(
+					'pdf_payee_name' => $old_gateway_settings['template_invoice_payee_name'],
+					'pdf_payee_email' => $old_gateway_settings['template_invoice_email'],
+					'pdf_payee_tax_number' => $old_gateway_settings['template_invoice_tax_number'],
+					'pdf_payee_address' => $old_gateway_settings['template_invoice_address'],
+					'pdf_instructions' => $old_gateway_settings['template_payment_instructions'],
+					'pdf_logo_image' => $old_gateway_settings['invoice_logo_url'],
+					'page_confirmation_text' => isset($old_gateway_settings['page_instructions']) ? $old_gateway_settings['page_instructions'] : '',
+					'page_extra_info' => isset($old_gateway_settings['payment_address']) ? $old_gateway_settings['payment_address'] : '',
+					'legacy_invoice_css' => $old_gateway_settings['invoice_css']
+				);
+				// if they didnt want the invoiec gateway to show, pretend it was inactive
+				if (! $old_gateway_settings['show']) {
+					$active = false;
+				}
+				$desc = __('On the next page you will be able to access your invoice and instructions on how to pay it.', 'event_espresso');
+				break;
+			case 'Mijireh':
+				$extra_meta_key_values = array(
+					'access_key' => $old_gateway_settings['access_key']
+				);
+				$desc =  __('On the next page you will be able to enter your billing information to make the payment.', 'event_espresso');
+				break;
+			case 'Paypal_Pro':
+				$extra_meta_key_values = array(
+					'username'=>$old_gateway_settings['username'],
+					'password'=>$old_gateway_settings['password'],
+					'signature'=>$old_gateway_settings['signature'],
+					'credit_card_types'=>$old_gateway_settings['credit_cards'],
+				);
+				$desc = __('Please provide the following billing information.', 'event_espresso');
+				break;
+			case 'Paypal_Standard':
+				$extra_meta_key_values = array(
+					'paypal_id' => $old_gateway_settings['paypal_id'],
+					'image_url' => $old_gateway_settings['image_url'],
+					'shipping_details' => isset($old_gateway_settings['no_shipping']) ? $old_gateway_settings['no_shipping'] : false,
 
-                );
-                $desc = sprintf(__('After clicking \'Finalize Registration\', you will be forwarded to PayPal to make your payment. Make sure you return to this site in order to properly finalize your registration.', 'event_espresso'), '<strong>', '</strong>');
-                break;
-            default:
-                // if we don't recognize the payment method, just put everything in it into extra meta. At least this way its preserved somewhere
-                $extra_meta_key_values = $old_gateway_settings;
-                $desc = '';
-        }
-        $pretty_name = isset($old_gateway_settings['display_name']) ? $old_gateway_settings['display_name'] : $old_gateway_slug;
-        $offline_gateways = array( 'Bank', 'Check', 'Invoice' );
-        if ($active && in_array($old_gateway_slug, $offline_gateways)) {
-            $scope = array( 'CART', 'ADMIN');
-        } elseif ($active && ! in_array($old_gateway_slug, $offline_gateways)) {
-            $scope = array( 'CART' );
-        } elseif (! $active && in_array($old_gateway_slug, $offline_gateways)) {
-            $scope = array( 'ADMIN' );
-        } else {
-            $scope = array();
-        }
-        $payment_method_col_values = array(
-            'PMD_type' => $old_gateway_slug,
-            'PMD_name' => $pretty_name,
-            'PMD_desc' => $desc,
-            'PMD_admin_name' => $pretty_name,
-            'PMD_slug' => sanitize_key($old_gateway_slug),
-            'PMD_debug_mode' => isset($old_gateway_settings['use_sandbox']) ? $old_gateway_settings['use_sandbox'] : false,
-            'PMD_button_url' => isset($old_gateway_settings['button_url']) ? $old_gateway_settings['button_url'] : null,
-            'PMD_scope' =>  serialize($scope)
-        );
-        $db_types = array(
-            '%s',// PMD_type
-            '%s',// PMD_name
-            '%s',// PMD_desc
-            '%s',// PMD_admin_name
-            '%s',// PMD_slug
-            '%d',// PMD_debug_mode
-            '%s',// PMD_button_url
-            '%s',// PMD_scope
-        );
-        global $wpdb;
-        // first: check if it already exists
-        $id = $wpdb->get_var($wpdb->prepare("SELECT PMD_ID FROM {$this->_new_table_name} WHERE PMD_slug=%s", $payment_method_col_values['PMD_slug']));
-        if ($id) {
-            // just update that payment method instead of creating a new one
-            $success = $wpdb->update(
-                $this->_new_table_name,
-                $payment_method_col_values,
-                array(
-                        'PMD_ID'=>$id
-                    ),
-                $db_types,
-                array(
-                        '%d',// PMD_ID
-                    )
-            );
-            if (! $success) {
-                $this->add_error(sprintf(__('Could not update payment method %d with properties %s because %s', "event_espresso"), $id, wp_json_encode($payment_method_col_values), $wpdb->last_error));
-            }
-        } else {
-            $success = $wpdb->insert(
-                $this->_new_table_name,
-                $payment_method_col_values,
-                $db_types
-            );
-            if (! $success) {
-                $this->add_error($wpdb->last_error);
-                return false;
-            } else {
-                $id = $wpdb->insert_id;
-            }
-        }
+				);
+				$desc = sprintf(__('After clicking \'Finalize Registration\', you will be forwarded to PayPal to make your payment. Make sure you return to this site in order to properly finalize your registration.', 'event_espresso'), '<strong>', '</strong>');
+				break;
+			default:
+				// if we don't recognize the payment method, just put everything in it into extra meta. At least this way its preserved somewhere
+				$extra_meta_key_values = $old_gateway_settings;
+				$desc = '';
+		}
+		$pretty_name = isset($old_gateway_settings['display_name']) ? $old_gateway_settings['display_name'] : $old_gateway_slug;
+		$offline_gateways = array( 'Bank', 'Check', 'Invoice' );
+		if ($active && in_array($old_gateway_slug, $offline_gateways)) {
+			$scope = array( 'CART', 'ADMIN');
+		} elseif ($active && ! in_array($old_gateway_slug, $offline_gateways)) {
+			$scope = array( 'CART' );
+		} elseif (! $active && in_array($old_gateway_slug, $offline_gateways)) {
+			$scope = array( 'ADMIN' );
+		} else {
+			$scope = array();
+		}
+		$payment_method_col_values = array(
+			'PMD_type' => $old_gateway_slug,
+			'PMD_name' => $pretty_name,
+			'PMD_desc' => $desc,
+			'PMD_admin_name' => $pretty_name,
+			'PMD_slug' => sanitize_key($old_gateway_slug),
+			'PMD_debug_mode' => isset($old_gateway_settings['use_sandbox']) ? $old_gateway_settings['use_sandbox'] : false,
+			'PMD_button_url' => isset($old_gateway_settings['button_url']) ? $old_gateway_settings['button_url'] : null,
+			'PMD_scope' =>  serialize($scope)
+		);
+		$db_types = array(
+			'%s',// PMD_type
+			'%s',// PMD_name
+			'%s',// PMD_desc
+			'%s',// PMD_admin_name
+			'%s',// PMD_slug
+			'%d',// PMD_debug_mode
+			'%s',// PMD_button_url
+			'%s',// PMD_scope
+		);
+		global $wpdb;
+		// first: check if it already exists
+		$id = $wpdb->get_var($wpdb->prepare("SELECT PMD_ID FROM {$this->_new_table_name} WHERE PMD_slug=%s", $payment_method_col_values['PMD_slug']));
+		if ($id) {
+			// just update that payment method instead of creating a new one
+			$success = $wpdb->update(
+				$this->_new_table_name,
+				$payment_method_col_values,
+				array(
+						'PMD_ID'=>$id
+					),
+				$db_types,
+				array(
+						'%d',// PMD_ID
+					)
+			);
+			if (! $success) {
+				$this->add_error(sprintf(__('Could not update payment method %d with properties %s because %s', "event_espresso"), $id, wp_json_encode($payment_method_col_values), $wpdb->last_error));
+			}
+		} else {
+			$success = $wpdb->insert(
+				$this->_new_table_name,
+				$payment_method_col_values,
+				$db_types
+			);
+			if (! $success) {
+				$this->add_error($wpdb->last_error);
+				return false;
+			} else {
+				$id = $wpdb->insert_id;
+			}
+		}
 
-        if ($id) {
-            $this->_convert_extra_meta_values($id, $extra_meta_key_values);
-            $this->get_migration_script()->set_mapping('EE_Gateway_Config', $old_gateway_slug, $this->_new_table_name, $id);
-            return true;
-        }
-        return false;
-    }
+		if ($id) {
+			$this->_convert_extra_meta_values($id, $extra_meta_key_values);
+			$this->get_migration_script()->set_mapping('EE_Gateway_Config', $old_gateway_slug, $this->_new_table_name, $id);
+			return true;
+		}
+		return false;
+	}
 
 
 
-    /**
-     * Converts old gateway settings which don't map onto the Payment_Method model
-     * to extra meta fields
-     * @param int $id
-     * @param array $extra_meta_key_values
-     */
-    private function _convert_extra_meta_values($id, $extra_meta_key_values)
-    {
-        global $wpdb;
-        foreach ($extra_meta_key_values as $key => $value) {
-            $exm_args = array(
-                'OBJ_ID'=>$id,
-                'EXM_type'=>'Payment_Method',
-                'EXM_key'=>$key,
-                'EXM_value'=> maybe_serialize($value)
-            );
-            $success = $wpdb->insert(
-                $this->_extra_meta_table_name,
-                $exm_args,
-                array(
-                        '%d',// OBJ_ID
-                        '%s',// EXM_type
-                        '%s',// EXM_key
-                        '%s',// EXM_value
-                    )
-            );
-            if (! $success) {
-                $this->add_error(sprintf(__('Could not insert extra meta key with values %s. %s', "event_espresso"), wp_json_encode($exm_args), $wpdb->last_error));
-            }
-        }
-    }
+	/**
+	 * Converts old gateway settings which don't map onto the Payment_Method model
+	 * to extra meta fields
+	 * @param int $id
+	 * @param array $extra_meta_key_values
+	 */
+	private function _convert_extra_meta_values($id, $extra_meta_key_values)
+	{
+		global $wpdb;
+		foreach ($extra_meta_key_values as $key => $value) {
+			$exm_args = array(
+				'OBJ_ID'=>$id,
+				'EXM_type'=>'Payment_Method',
+				'EXM_key'=>$key,
+				'EXM_value'=> maybe_serialize($value)
+			);
+			$success = $wpdb->insert(
+				$this->_extra_meta_table_name,
+				$exm_args,
+				array(
+						'%d',// OBJ_ID
+						'%s',// EXM_type
+						'%s',// EXM_key
+						'%s',// EXM_value
+					)
+			);
+			if (! $success) {
+				$this->add_error(sprintf(__('Could not insert extra meta key with values %s. %s', "event_espresso"), wp_json_encode($exm_args), $wpdb->last_error));
+			}
+		}
+	}
 }

Spacing +26 added lines, -26 removed lines

@@ -77,7 +77,7 @@ 
         $gateways_to_deal_with = array_slice(EE_Config::instance()->gateway->payment_settings, $this->count_records_migrated(), $num_items_to_migrate);
         foreach ($gateways_to_deal_with as $old_gateway_slug => $old_gateway_settings) {
             if (in_array($old_gateway_slug, $this->_gateway_we_know_to_migrate)) {
-                if (! $old_gateway_settings) {
+                if ( ! $old_gateway_settings) {
                     // no settings existed for this gateway anyways... weird...
                     $items_actually_migrated++;
                     continue;
@@ -86,10 +86,10 @@ 
                 $success = $this->_convert_gateway_settings(
                     $old_gateway_slug,
                     $old_gateway_settings,
-                    isset(EE_Config::instance()->gateway->active_gateways[ $old_gateway_slug ])
+                    isset(EE_Config::instance()->gateway->active_gateways[$old_gateway_slug])
                 );
                 if ($success) {
-                    EE_Config::instance()->gateway->payment_settings[ $old_gateway_slug ] = 'Deprecated';
+                    EE_Config::instance()->gateway->payment_settings[$old_gateway_slug] = 'Deprecated';
                 }
             }
             $items_actually_migrated++;
@@ -148,7 +148,7 @@ 
                     'legacy_invoice_css' => $old_gateway_settings['invoice_css']
                 );
                 // if they didnt want the invoiec gateway to show, pretend it was inactive
-                if (! $old_gateway_settings['show']) {
+                if ( ! $old_gateway_settings['show']) {
                     $active = false;
                 }
                 $desc = __('On the next page you will be able to access your invoice and instructions on how to pay it.', 'event_espresso');
@@ -157,7 +157,7 @@ 
                 $extra_meta_key_values = array(
                     'access_key' => $old_gateway_settings['access_key']
                 );
-                $desc =  __('On the next page you will be able to enter your billing information to make the payment.', 'event_espresso');
+                $desc = __('On the next page you will be able to enter your billing information to make the payment.', 'event_espresso');
                 break;
             case 'Paypal_Pro':
                 $extra_meta_key_values = array(
@@ -183,13 +183,13 @@ 
                 $desc = '';
         }
         $pretty_name = isset($old_gateway_settings['display_name']) ? $old_gateway_settings['display_name'] : $old_gateway_slug;
-        $offline_gateways = array( 'Bank', 'Check', 'Invoice' );
+        $offline_gateways = array('Bank', 'Check', 'Invoice');
         if ($active && in_array($old_gateway_slug, $offline_gateways)) {
-            $scope = array( 'CART', 'ADMIN');
+            $scope = array('CART', 'ADMIN');
         } elseif ($active && ! in_array($old_gateway_slug, $offline_gateways)) {
-            $scope = array( 'CART' );
-        } elseif (! $active && in_array($old_gateway_slug, $offline_gateways)) {
-            $scope = array( 'ADMIN' );
+            $scope = array('CART');
+        } elseif ( ! $active && in_array($old_gateway_slug, $offline_gateways)) {
+            $scope = array('ADMIN');
         } else {
             $scope = array();
         }
@@ -204,14 +204,14 @@ 
             'PMD_scope' =>  serialize($scope)
         );
         $db_types = array(
-            '%s',// PMD_type
-            '%s',// PMD_name
-            '%s',// PMD_desc
-            '%s',// PMD_admin_name
-            '%s',// PMD_slug
-            '%d',// PMD_debug_mode
-            '%s',// PMD_button_url
-            '%s',// PMD_scope
+            '%s', // PMD_type
+            '%s', // PMD_name
+            '%s', // PMD_desc
+            '%s', // PMD_admin_name
+            '%s', // PMD_slug
+            '%d', // PMD_debug_mode
+            '%s', // PMD_button_url
+            '%s', // PMD_scope
         );
         global $wpdb;
         // first: check if it already exists
@@ -226,10 +226,10 @@ 
                     ),
                 $db_types,
                 array(
-                        '%d',// PMD_ID
+                        '%d', // PMD_ID
                     )
             );
-            if (! $success) {
+            if ( ! $success) {
                 $this->add_error(sprintf(__('Could not update payment method %d with properties %s because %s', "event_espresso"), $id, wp_json_encode($payment_method_col_values), $wpdb->last_error));
             }
         } else {
@@ -238,7 +238,7 @@ 
                 $payment_method_col_values,
                 $db_types
             );
-            if (! $success) {
+            if ( ! $success) {
                 $this->add_error($wpdb->last_error);
                 return false;
             } else {
@@ -276,13 +276,13 @@ 
                 $this->_extra_meta_table_name,
                 $exm_args,
                 array(
-                        '%d',// OBJ_ID
-                        '%s',// EXM_type
-                        '%s',// EXM_key
-                        '%s',// EXM_value
+                        '%d', // OBJ_ID
+                        '%s', // EXM_type
+                        '%s', // EXM_key
+                        '%s', // EXM_value
                     )
             );
-            if (! $success) {
+            if ( ! $success) {
                 $this->add_error(sprintf(__('Could not insert extra meta key with values %s. %s', "event_espresso"), wp_json_encode($exm_args), $wpdb->last_error));
             }
         }