eventespresso / event-espresso-core

core/services/commands/CompositeCommandHandler.php

Spacing +1 added lines, -1 removed lines

@@ -2,7 +2,7 @@
 
 namespace EventEspresso\core\services\commands;
 
-if (! defined('EVENT_ESPRESSO_VERSION')) {
+if ( ! defined('EVENT_ESPRESSO_VERSION')) {
     exit('No direct script access allowed');
 }
 

Indentation +41 added lines, -41 removed lines

@@ -3,7 +3,7 @@ 
 namespace EventEspresso\core\services\commands;
 
 if (! defined('EVENT_ESPRESSO_VERSION')) {
-    exit('No direct script access allowed');
+	exit('No direct script access allowed');
 }
 
 
@@ -21,59 +21,59 @@ 
 abstract class CompositeCommandHandler extends CommandHandler
 {
 
-    /**
-     * @type CommandBusInterface $command_bus
-     */
-    private $command_bus;
+	/**
+	 * @type CommandBusInterface $command_bus
+	 */
+	private $command_bus;
 
-    /**
-     * @type CommandFactoryInterface $command_factory
-     */
-    private $command_factory;
+	/**
+	 * @type CommandFactoryInterface $command_factory
+	 */
+	private $command_factory;
 
 
 
-    /**
-     * CompositeCommandHandler constructor.
-     *
-     * @param CommandBusInterface     $command_bus
-     * @param CommandFactoryInterface $command_factory
-     */
-    public function __construct(CommandBusInterface $command_bus, CommandFactoryInterface $command_factory)
-    {
-        $this->command_bus = $command_bus;
-        $this->command_factory = $command_factory;
-    }
+	/**
+	 * CompositeCommandHandler constructor.
+	 *
+	 * @param CommandBusInterface     $command_bus
+	 * @param CommandFactoryInterface $command_factory
+	 */
+	public function __construct(CommandBusInterface $command_bus, CommandFactoryInterface $command_factory)
+	{
+		$this->command_bus = $command_bus;
+		$this->command_factory = $command_factory;
+	}
 
 
 
-    /**
-     * @param CommandBusInterface $command_bus
-     */
-    public function setCommandBus(CommandBusInterface $command_bus)
-    {
-        $this->command_bus = $command_bus;
-    }
+	/**
+	 * @param CommandBusInterface $command_bus
+	 */
+	public function setCommandBus(CommandBusInterface $command_bus)
+	{
+		$this->command_bus = $command_bus;
+	}
 
 
 
-    /**
-     * @return CommandBusInterface
-     */
-    public function commandBus()
-    {
-        return $this->command_bus;
-    }
+	/**
+	 * @return CommandBusInterface
+	 */
+	public function commandBus()
+	{
+		return $this->command_bus;
+	}
 
 
 
-    /**
-     * @return CommandFactoryInterface
-     */
-    public function commandFactory()
-    {
-        return $this->command_factory;
-    }
+	/**
+	 * @return CommandFactoryInterface
+	 */
+	public function commandFactory()
+	{
+		return $this->command_factory;
+	}
 
 
 

core/domain/services/capabilities/CapabilitiesCheckerInterface.php

Indentation +22 added lines, -22 removed lines

@@ -20,26 +20,26 @@
 interface CapabilitiesCheckerInterface
 {
 
-    /**
-     * Verifies that the current user has ALL of the capabilities listed in the CapCheck DTO.
-     * If any of the individual capability checks fails, then the command will NOT be executed.
-     *
-     * @param CapCheckInterface|CapCheckInterface[] $cap_check
-     * @return bool
-     * @throws InvalidClassException
-     * @throws InsufficientPermissionsException
-     */
-    public function processCapCheck($cap_check);
-
-
-
-    /**
-     * @param string $capability - the capability to be checked, like: 'ee_edit_registrations'
-     * @param string $context    - what the user is attempting to do, like: 'Edit Registration'
-     * @param int    $ID         - (optional) ID for item where current_user_can is being called from
-     * @return bool
-     * @throws InsufficientPermissionsException
-     * @throws InvalidClassException
-     */
-    public function process($capability, $context, $ID = 0);
+	/**
+	 * Verifies that the current user has ALL of the capabilities listed in the CapCheck DTO.
+	 * If any of the individual capability checks fails, then the command will NOT be executed.
+	 *
+	 * @param CapCheckInterface|CapCheckInterface[] $cap_check
+	 * @return bool
+	 * @throws InvalidClassException
+	 * @throws InsufficientPermissionsException
+	 */
+	public function processCapCheck($cap_check);
+
+
+
+	/**
+	 * @param string $capability - the capability to be checked, like: 'ee_edit_registrations'
+	 * @param string $context    - what the user is attempting to do, like: 'Edit Registration'
+	 * @param int    $ID         - (optional) ID for item where current_user_can is being called from
+	 * @return bool
+	 * @throws InsufficientPermissionsException
+	 * @throws InvalidClassException
+	 */
+	public function process($capability, $context, $ID = 0);
 }

core/domain/services/capabilities/CapabilitiesChecker.php

Indentation +87 added lines, -87 removed lines

@@ -8,7 +8,7 @@ 
 use EventEspresso\core\exceptions\InvalidDataTypeException;
 
 if (! defined('EVENT_ESPRESSO_VERSION')) {
-    exit('No direct script access allowed');
+	exit('No direct script access allowed');
 }
 
 
@@ -24,92 +24,92 @@ 
 class CapabilitiesChecker implements CapabilitiesCheckerInterface
 {
 
-    /**
-     * @type EE_Capabilities $capabilities
-     */
-    private $capabilities;
-
-
-
-    /**
-     * CapabilitiesChecker constructor
-     *
-     * @param EE_Capabilities $capabilities
-     */
-    public function __construct(EE_Capabilities $capabilities)
-    {
-        $this->capabilities = $capabilities;
-    }
-
-
-
-    /**
-     * @return EE_Capabilities
-     */
-    protected function capabilities()
-    {
-        return $this->capabilities;
-    }
-
-
-
-    /**
-     * Verifies that the current user has ALL of the capabilities listed in the CapCheck DTO.
-     * If any of the individual capability checks fails, then the command will NOT be executed.
-     *
-     * @param CapCheckInterface|CapCheckInterface[] $cap_check
-     * @return bool
-     * @throws InvalidClassException
-     * @throws InsufficientPermissionsException
-     */
-    public function processCapCheck($cap_check)
-    {
-        if (is_array($cap_check)) {
-            foreach ($cap_check as $check) {
-                $this->processCapCheck($check);
-            }
-            return true;
-        }
-        // at this point, $cap_check should be an individual instance of CapCheck
-        if (! $cap_check instanceof CapCheckInterface) {
-            throw new InvalidClassException(
-                '\EventEspresso\core\domain\services\capabilities\CapCheckInterface'
-            );
-        }
-        // sometimes cap checks are conditional, and no capabilities are required
-        if ($cap_check instanceof PublicCapabilities) {
-            return true;
-        }
-        $capabilities = (array)$cap_check->capability();
-        foreach ($capabilities as $capability) {
-            if (
-            ! $this->capabilities()->current_user_can(
-                $capability,
-                $cap_check->context(),
-                $cap_check->ID()
-            )
-            ) {
-                throw new InsufficientPermissionsException($cap_check->context());
-            }
-        }
-        return true;
-    }
-
-
-
-    /**
-     * @param string $capability - the capability to be checked, like: 'ee_edit_registrations'
-     * @param string $context    - what the user is attempting to do, like: 'Edit Registration'
-     * @param int    $ID         - (optional) ID for item where current_user_can is being called from
-     * @return bool
-     * @throws InvalidDataTypeException
-     * @throws InsufficientPermissionsException
-     * @throws InvalidClassException
-     */
-    public function process($capability, $context, $ID = 0)
-    {
-        return $this->processCapCheck(new CapCheck($capability, $context, $ID));
-    }
+	/**
+	 * @type EE_Capabilities $capabilities
+	 */
+	private $capabilities;
+
+
+
+	/**
+	 * CapabilitiesChecker constructor
+	 *
+	 * @param EE_Capabilities $capabilities
+	 */
+	public function __construct(EE_Capabilities $capabilities)
+	{
+		$this->capabilities = $capabilities;
+	}
+
+
+
+	/**
+	 * @return EE_Capabilities
+	 */
+	protected function capabilities()
+	{
+		return $this->capabilities;
+	}
+
+
+
+	/**
+	 * Verifies that the current user has ALL of the capabilities listed in the CapCheck DTO.
+	 * If any of the individual capability checks fails, then the command will NOT be executed.
+	 *
+	 * @param CapCheckInterface|CapCheckInterface[] $cap_check
+	 * @return bool
+	 * @throws InvalidClassException
+	 * @throws InsufficientPermissionsException
+	 */
+	public function processCapCheck($cap_check)
+	{
+		if (is_array($cap_check)) {
+			foreach ($cap_check as $check) {
+				$this->processCapCheck($check);
+			}
+			return true;
+		}
+		// at this point, $cap_check should be an individual instance of CapCheck
+		if (! $cap_check instanceof CapCheckInterface) {
+			throw new InvalidClassException(
+				'\EventEspresso\core\domain\services\capabilities\CapCheckInterface'
+			);
+		}
+		// sometimes cap checks are conditional, and no capabilities are required
+		if ($cap_check instanceof PublicCapabilities) {
+			return true;
+		}
+		$capabilities = (array)$cap_check->capability();
+		foreach ($capabilities as $capability) {
+			if (
+			! $this->capabilities()->current_user_can(
+				$capability,
+				$cap_check->context(),
+				$cap_check->ID()
+			)
+			) {
+				throw new InsufficientPermissionsException($cap_check->context());
+			}
+		}
+		return true;
+	}
+
+
+
+	/**
+	 * @param string $capability - the capability to be checked, like: 'ee_edit_registrations'
+	 * @param string $context    - what the user is attempting to do, like: 'Edit Registration'
+	 * @param int    $ID         - (optional) ID for item where current_user_can is being called from
+	 * @return bool
+	 * @throws InvalidDataTypeException
+	 * @throws InsufficientPermissionsException
+	 * @throws InvalidClassException
+	 */
+	public function process($capability, $context, $ID = 0)
+	{
+		return $this->processCapCheck(new CapCheck($capability, $context, $ID));
+	}
 
 
 

Spacing +3 added lines, -3 removed lines

@@ -7,7 +7,7 @@ 
 use EventEspresso\core\exceptions\InvalidClassException;
 use EventEspresso\core\exceptions\InvalidDataTypeException;
 
-if (! defined('EVENT_ESPRESSO_VERSION')) {
+if ( ! defined('EVENT_ESPRESSO_VERSION')) {
     exit('No direct script access allowed');
 }
 
@@ -71,7 +71,7 @@ 
             return true;
         }
         // at this point, $cap_check should be an individual instance of CapCheck
-        if (! $cap_check instanceof CapCheckInterface) {
+        if ( ! $cap_check instanceof CapCheckInterface) {
             throw new InvalidClassException(
                 '\EventEspresso\core\domain\services\capabilities\CapCheckInterface'
             );
@@ -80,7 +80,7 @@ 
         if ($cap_check instanceof PublicCapabilities) {
             return true;
         }
-        $capabilities = (array)$cap_check->capability();
+        $capabilities = (array) $cap_check->capability();
         foreach ($capabilities as $capability) {
             if (
             ! $this->capabilities()->current_user_can(

core/EE_Load_Espresso_Core.core.php

Spacing +12 added lines, -12 removed lines

@@ -3,7 +3,7 @@ 
 use EventEspresso\core\exceptions\InvalidInterfaceException;
 use EventEspresso\core\services\loaders\LoaderInterface;
 
-if (! defined('EVENT_ESPRESSO_VERSION')) {
+if ( ! defined('EVENT_ESPRESSO_VERSION')) {
     exit('No direct script access allowed');
 }
 
@@ -56,7 +56,7 @@ 
      */
     public function __construct()
     {
-        espresso_load_required('EventEspresso\core\Factory', EE_CORE . 'Factory.php');
+        espresso_load_required('EventEspresso\core\Factory', EE_CORE.'Factory.php');
     }
 
 
@@ -111,9 +111,9 @@ 
         $this->_load_class_tools();
         // load interfaces
         espresso_load_required('EEI_Payment_Method_Interfaces',
-            EE_LIBRARIES . 'payment_methods' . DS . 'EEI_Payment_Method_Interfaces.php');
+            EE_LIBRARIES.'payment_methods'.DS.'EEI_Payment_Method_Interfaces.php');
         // deprecated functions
-        espresso_load_required('EE_Deprecated', EE_CORE . 'EE_Deprecated.core.php');
+        espresso_load_required('EE_Deprecated', EE_CORE.'EE_Deprecated.core.php');
         // WP cron jobs
         $this->registry->load_core('Cron_Tasks');
         $this->registry->load_core('EE_Request_Handler');
@@ -149,7 +149,7 @@ 
      */
     public function dependency_map()
     {
-        if (! $this->dependency_map instanceof EE_Dependency_Map) {
+        if ( ! $this->dependency_map instanceof EE_Dependency_Map) {
             throw new EE_Error(
                 sprintf(
                     __('Invalid EE_Dependency_Map: "%1$s"', 'event_espresso'),
@@ -168,7 +168,7 @@ 
      */
     public function registry()
     {
-        if (! $this->registry instanceof EE_Registry) {
+        if ( ! $this->registry instanceof EE_Registry) {
             throw new EE_Error(
                 sprintf(
                     __('Invalid EE_Registry: "%1$s"', 'event_espresso'),
@@ -186,14 +186,14 @@ 
      */
     private function _load_dependency_map()
     {
-        if (! is_readable(EE_CORE . 'EE_Dependency_Map.core.php')) {
+        if ( ! is_readable(EE_CORE.'EE_Dependency_Map.core.php')) {
             EE_Error::add_error(
                 __('The EE_Dependency_Map core class could not be loaded.', 'event_espresso'),
                 __FILE__, __FUNCTION__, __LINE__
             );
             wp_die(EE_Error::get_notices());
         }
-        require_once(EE_CORE . 'EE_Dependency_Map.core.php');
+        require_once(EE_CORE.'EE_Dependency_Map.core.php');
         return EE_Dependency_Map::instance($this->request, $this->response);
     }
 
@@ -204,14 +204,14 @@ 
      */
     private function _load_registry()
     {
-        if (! is_readable(EE_CORE . 'EE_Registry.core.php')) {
+        if ( ! is_readable(EE_CORE.'EE_Registry.core.php')) {
             EE_Error::add_error(
                 __('The EE_Registry core class could not be loaded.', 'event_espresso'),
                 __FILE__, __FUNCTION__, __LINE__
             );
             wp_die(EE_Error::get_notices());
         }
-        require_once(EE_CORE . 'EE_Registry.core.php');
+        require_once(EE_CORE.'EE_Registry.core.php');
         return EE_Registry::instance($this->dependency_map);
     }
 
@@ -222,13 +222,13 @@ 
      */
     private function _load_class_tools()
     {
-        if (! is_readable(EE_HELPERS . 'EEH_Class_Tools.helper.php')) {
+        if ( ! is_readable(EE_HELPERS.'EEH_Class_Tools.helper.php')) {
             EE_Error::add_error(
                 __('The EEH_Class_Tools helper could not be loaded.', 'event_espresso'),
                 __FILE__, __FUNCTION__, __LINE__
             );
         }
-        require_once(EE_HELPERS . 'EEH_Class_Tools.helper.php');
+        require_once(EE_HELPERS.'EEH_Class_Tools.helper.php');
     }
 
 

Indentation +223 added lines, -223 removed lines

@@ -4,7 +4,7 @@ 
 use EventEspresso\core\services\loaders\LoaderInterface;
 
 if (! defined('EVENT_ESPRESSO_VERSION')) {
-    exit('No direct script access allowed');
+	exit('No direct script access allowed');
 }
 
 
@@ -24,228 +24,228 @@ 
 class EE_Load_Espresso_Core implements EEI_Request_Decorator, EEI_Request_Stack_Core_App
 {
 
-    /**
-     * @type LoaderInterface $loader
-     */
-    protected $loader;
-
-    /**
-     * @var EE_Request $request
-     */
-    protected $request;
-
-    /**
-     * @var EE_Response $response
-     */
-    protected $response;
-
-    /**
-     * @var EE_Dependency_Map $dependency_map
-     */
-    protected $dependency_map;
-
-    /**
-     * @var EE_Registry $registry
-     */
-    protected $registry;
-
-
-
-    /**
-     * EE_Load_Espresso_Core constructor
-     */
-    public function __construct()
-    {
-        espresso_load_required('EventEspresso\core\Factory', EE_CORE . 'Factory.php');
-    }
-
-
-
-    /**
-     * handle
-     * sets hooks for running rest of system
-     * provides "AHEE__EE_System__construct__complete" hook for EE Addons to use as their starting point
-     * starting EE Addons from any other point may lead to problems
-     *
-     * @param EE_Request  $request
-     * @param EE_Response $response
-     * @return EE_Response
-     * @throws EE_Error
-     * @throws InvalidDataTypeException
-     * @throws InvalidInterfaceException
-     * @throws InvalidArgumentException
-     */
-    public function handle_request(EE_Request $request, EE_Response $response)
-    {
-        $this->request = $request;
-        $this->response = $response;
-        // info about how to load classes required by other classes
-        $this->dependency_map = $this->_load_dependency_map();
-        // central repository for classes
-        $this->registry = $this->_load_registry();
-        // PSR4 Autoloaders
-        $this->registry->load_core('EE_Psr4AutoloaderInit');
-        do_action('EE_Load_Espresso_Core__handle_request__initialize_core_loading');
-        $this->loader = $this->registry->create('EventEspresso\core\services\loaders\Loader');
-        $this->dependency_map->setLoader($this->loader);
-        // build DI container
-        $OpenCoffeeShop = new EventEspresso\core\services\container\OpenCoffeeShop();
-        $OpenCoffeeShop->addRecipes();
-        // $CoffeeShop = $OpenCoffeeShop->CoffeeShop();
-        // create and cache the CommandBus, and also add middleware
-        $this->registry->create(
-            'CommandBusInterface',
-            array(
-                null,
-                apply_filters(
-                    'FHEE__EE_Load_Espresso_Core__handle_request__CommandBus_middleware',
-                    array(
-                        $this->registry->create('CapChecker'),
-                        $this->registry->create('AddActionHook'),
-                    )
-                ),
-            ),
-            true
-        );
-        // workarounds for PHP < 5.3
-        $this->_load_class_tools();
-        // load interfaces
-        espresso_load_required('EEI_Payment_Method_Interfaces',
-            EE_LIBRARIES . 'payment_methods' . DS . 'EEI_Payment_Method_Interfaces.php');
-        // deprecated functions
-        espresso_load_required('EE_Deprecated', EE_CORE . 'EE_Deprecated.core.php');
-        // WP cron jobs
-        $this->registry->load_core('Cron_Tasks');
-        $this->registry->load_core('EE_Request_Handler');
-        $this->registry->load_core('EE_System');
-        return $this->response;
-    }
-
-
-
-    /**
-     * @return EE_Request
-     */
-    public function request()
-    {
-        return $this->request;
-    }
-
-
-
-    /**
-     * @return EE_Response
-     */
-    public function response()
-    {
-        return $this->response;
-    }
-
-
-
-    /**
-     * @return EE_Dependency_Map
-     * @throws EE_Error
-     */
-    public function dependency_map()
-    {
-        if (! $this->dependency_map instanceof EE_Dependency_Map) {
-            throw new EE_Error(
-                sprintf(
-                    __('Invalid EE_Dependency_Map: "%1$s"', 'event_espresso'),
-                    print_r($this->dependency_map, true)
-                )
-            );
-        }
-        return $this->dependency_map;
-    }
-
-
-
-    /**
-     * @return EE_Registry
-     * @throws EE_Error
-     */
-    public function registry()
-    {
-        if (! $this->registry instanceof EE_Registry) {
-            throw new EE_Error(
-                sprintf(
-                    __('Invalid EE_Registry: "%1$s"', 'event_espresso'),
-                    print_r($this->registry, true)
-                )
-            );
-        }
-        return $this->registry;
-    }
-
-
-
-    /**
-     * @return EE_Dependency_Map
-     */
-    private function _load_dependency_map()
-    {
-        if (! is_readable(EE_CORE . 'EE_Dependency_Map.core.php')) {
-            EE_Error::add_error(
-                __('The EE_Dependency_Map core class could not be loaded.', 'event_espresso'),
-                __FILE__, __FUNCTION__, __LINE__
-            );
-            wp_die(EE_Error::get_notices());
-        }
-        require_once(EE_CORE . 'EE_Dependency_Map.core.php');
-        return EE_Dependency_Map::instance($this->request, $this->response);
-    }
-
-
-
-    /**
-     * @return EE_Registry
-     */
-    private function _load_registry()
-    {
-        if (! is_readable(EE_CORE . 'EE_Registry.core.php')) {
-            EE_Error::add_error(
-                __('The EE_Registry core class could not be loaded.', 'event_espresso'),
-                __FILE__, __FUNCTION__, __LINE__
-            );
-            wp_die(EE_Error::get_notices());
-        }
-        require_once(EE_CORE . 'EE_Registry.core.php');
-        return EE_Registry::instance($this->dependency_map);
-    }
-
-
-
-    /**
-     * @return void
-     */
-    private function _load_class_tools()
-    {
-        if (! is_readable(EE_HELPERS . 'EEH_Class_Tools.helper.php')) {
-            EE_Error::add_error(
-                __('The EEH_Class_Tools helper could not be loaded.', 'event_espresso'),
-                __FILE__, __FUNCTION__, __LINE__
-            );
-        }
-        require_once(EE_HELPERS . 'EEH_Class_Tools.helper.php');
-    }
-
-
-
-    /**
-     * called after the request stack has been fully processed
-     * if any of the middleware apps has requested the plugin be deactivated, then we do that now
-     *
-     * @param EE_Request  $request
-     * @param EE_Response $response
-     */
-    public function handle_response(EE_Request $request, EE_Response $response)
-    {
-        if ($response->plugin_deactivated()) {
-            espresso_deactivate_plugin(EE_PLUGIN_BASENAME);
-        }
-    }
+	/**
+	 * @type LoaderInterface $loader
+	 */
+	protected $loader;
+
+	/**
+	 * @var EE_Request $request
+	 */
+	protected $request;
+
+	/**
+	 * @var EE_Response $response
+	 */
+	protected $response;
+
+	/**
+	 * @var EE_Dependency_Map $dependency_map
+	 */
+	protected $dependency_map;
+
+	/**
+	 * @var EE_Registry $registry
+	 */
+	protected $registry;
+
+
+
+	/**
+	 * EE_Load_Espresso_Core constructor
+	 */
+	public function __construct()
+	{
+		espresso_load_required('EventEspresso\core\Factory', EE_CORE . 'Factory.php');
+	}
+
+
+
+	/**
+	 * handle
+	 * sets hooks for running rest of system
+	 * provides "AHEE__EE_System__construct__complete" hook for EE Addons to use as their starting point
+	 * starting EE Addons from any other point may lead to problems
+	 *
+	 * @param EE_Request  $request
+	 * @param EE_Response $response
+	 * @return EE_Response
+	 * @throws EE_Error
+	 * @throws InvalidDataTypeException
+	 * @throws InvalidInterfaceException
+	 * @throws InvalidArgumentException
+	 */
+	public function handle_request(EE_Request $request, EE_Response $response)
+	{
+		$this->request = $request;
+		$this->response = $response;
+		// info about how to load classes required by other classes
+		$this->dependency_map = $this->_load_dependency_map();
+		// central repository for classes
+		$this->registry = $this->_load_registry();
+		// PSR4 Autoloaders
+		$this->registry->load_core('EE_Psr4AutoloaderInit');
+		do_action('EE_Load_Espresso_Core__handle_request__initialize_core_loading');
+		$this->loader = $this->registry->create('EventEspresso\core\services\loaders\Loader');
+		$this->dependency_map->setLoader($this->loader);
+		// build DI container
+		$OpenCoffeeShop = new EventEspresso\core\services\container\OpenCoffeeShop();
+		$OpenCoffeeShop->addRecipes();
+		// $CoffeeShop = $OpenCoffeeShop->CoffeeShop();
+		// create and cache the CommandBus, and also add middleware
+		$this->registry->create(
+			'CommandBusInterface',
+			array(
+				null,
+				apply_filters(
+					'FHEE__EE_Load_Espresso_Core__handle_request__CommandBus_middleware',
+					array(
+						$this->registry->create('CapChecker'),
+						$this->registry->create('AddActionHook'),
+					)
+				),
+			),
+			true
+		);
+		// workarounds for PHP < 5.3
+		$this->_load_class_tools();
+		// load interfaces
+		espresso_load_required('EEI_Payment_Method_Interfaces',
+			EE_LIBRARIES . 'payment_methods' . DS . 'EEI_Payment_Method_Interfaces.php');
+		// deprecated functions
+		espresso_load_required('EE_Deprecated', EE_CORE . 'EE_Deprecated.core.php');
+		// WP cron jobs
+		$this->registry->load_core('Cron_Tasks');
+		$this->registry->load_core('EE_Request_Handler');
+		$this->registry->load_core('EE_System');
+		return $this->response;
+	}
+
+
+
+	/**
+	 * @return EE_Request
+	 */
+	public function request()
+	{
+		return $this->request;
+	}
+
+
+
+	/**
+	 * @return EE_Response
+	 */
+	public function response()
+	{
+		return $this->response;
+	}
+
+
+
+	/**
+	 * @return EE_Dependency_Map
+	 * @throws EE_Error
+	 */
+	public function dependency_map()
+	{
+		if (! $this->dependency_map instanceof EE_Dependency_Map) {
+			throw new EE_Error(
+				sprintf(
+					__('Invalid EE_Dependency_Map: "%1$s"', 'event_espresso'),
+					print_r($this->dependency_map, true)
+				)
+			);
+		}
+		return $this->dependency_map;
+	}
+
+
+
+	/**
+	 * @return EE_Registry
+	 * @throws EE_Error
+	 */
+	public function registry()
+	{
+		if (! $this->registry instanceof EE_Registry) {
+			throw new EE_Error(
+				sprintf(
+					__('Invalid EE_Registry: "%1$s"', 'event_espresso'),
+					print_r($this->registry, true)
+				)
+			);
+		}
+		return $this->registry;
+	}
+
+
+
+	/**
+	 * @return EE_Dependency_Map
+	 */
+	private function _load_dependency_map()
+	{
+		if (! is_readable(EE_CORE . 'EE_Dependency_Map.core.php')) {
+			EE_Error::add_error(
+				__('The EE_Dependency_Map core class could not be loaded.', 'event_espresso'),
+				__FILE__, __FUNCTION__, __LINE__
+			);
+			wp_die(EE_Error::get_notices());
+		}
+		require_once(EE_CORE . 'EE_Dependency_Map.core.php');
+		return EE_Dependency_Map::instance($this->request, $this->response);
+	}
+
+
+
+	/**
+	 * @return EE_Registry
+	 */
+	private function _load_registry()
+	{
+		if (! is_readable(EE_CORE . 'EE_Registry.core.php')) {
+			EE_Error::add_error(
+				__('The EE_Registry core class could not be loaded.', 'event_espresso'),
+				__FILE__, __FUNCTION__, __LINE__
+			);
+			wp_die(EE_Error::get_notices());
+		}
+		require_once(EE_CORE . 'EE_Registry.core.php');
+		return EE_Registry::instance($this->dependency_map);
+	}
+
+
+
+	/**
+	 * @return void
+	 */
+	private function _load_class_tools()
+	{
+		if (! is_readable(EE_HELPERS . 'EEH_Class_Tools.helper.php')) {
+			EE_Error::add_error(
+				__('The EEH_Class_Tools helper could not be loaded.', 'event_espresso'),
+				__FILE__, __FUNCTION__, __LINE__
+			);
+		}
+		require_once(EE_HELPERS . 'EEH_Class_Tools.helper.php');
+	}
+
+
+
+	/**
+	 * called after the request stack has been fully processed
+	 * if any of the middleware apps has requested the plugin be deactivated, then we do that now
+	 *
+	 * @param EE_Request  $request
+	 * @param EE_Response $response
+	 */
+	public function handle_response(EE_Request $request, EE_Response $response)
+	{
+		if ($response->plugin_deactivated()) {
+			espresso_deactivate_plugin(EE_PLUGIN_BASENAME);
+		}
+	}
 
 
 

core/services/commands/CommandBus.php

Spacing +6 added lines, -6 removed lines

@@ -6,7 +6,7 @@ 
 use EventEspresso\core\services\commands\middleware\CommandBusMiddlewareInterface;
 use EventEspresso\core\services\commands\middleware\InvalidCommandBusMiddlewareException;
 
-if (! defined('EVENT_ESPRESSO_VERSION')) {
+if ( ! defined('EVENT_ESPRESSO_VERSION')) {
     exit('No direct script access allowed');
 }
 
@@ -88,24 +88,24 @@ 
      */
     public function execute($command)
     {
-        if (! $command instanceof CommandInterface) {
-            throw new InvalidDataTypeException(__METHOD__ . '( $command )', $command, 'CommandInterface');
+        if ( ! $command instanceof CommandInterface) {
+            throw new InvalidDataTypeException(__METHOD__.'( $command )', $command, 'CommandInterface');
         }
         // we're going to add the Command Handler as a callable
         // that will get run at the end of our middleware stack
         // can't pass $this to a Closure, so use a named variable
         $command_bus = $this;
-        $middleware = function ($command) use ($command_bus) {
+        $middleware = function($command) use ($command_bus) {
             return $command_bus->getCommandHandlerManager()
                 ->getCommandHandler($command, $command_bus)
                 ->handle($command);
         };
         // now build the rest of the middleware stack
         while ($command_bus_middleware = array_pop($this->command_bus_middleware)) {
-            if (! $command_bus_middleware instanceof CommandBusMiddlewareInterface) {
+            if ( ! $command_bus_middleware instanceof CommandBusMiddlewareInterface) {
                 throw new InvalidCommandBusMiddlewareException($command_bus_middleware);
             }
-            $middleware = function ($command) use ($command_bus_middleware, $middleware) {
+            $middleware = function($command) use ($command_bus_middleware, $middleware) {
                 return $command_bus_middleware->handle($command, $middleware);
             };
         }

Indentation +73 added lines, -73 removed lines

@@ -7,7 +7,7 @@ 
 use EventEspresso\core\services\commands\middleware\InvalidCommandBusMiddlewareException;
 
 if (! defined('EVENT_ESPRESSO_VERSION')) {
-    exit('No direct script access allowed');
+	exit('No direct script access allowed');
 }
 
 
@@ -40,78 +40,78 @@ 
 class CommandBus implements CommandBusInterface
 {
 
-    /**
-     * @type CommandHandlerManagerInterface $command_handler_manager
-     */
-    private $command_handler_manager;
-
-    /**
-     * @type CommandBusMiddlewareInterface[] $command_bus_middleware
-     */
-    private $command_bus_middleware;
-
-
-
-    /**
-     * CommandBus constructor
-     *
-     * @param CommandHandlerManagerInterface  $command_handler_manager
-     * @param CommandBusMiddlewareInterface[] $command_bus_middleware
-     */
-    public function __construct(
-        CommandHandlerManagerInterface $command_handler_manager,
-        array $command_bus_middleware = array()
-    ) {
-        $this->command_handler_manager = $command_handler_manager;
-        $this->command_bus_middleware = is_array($command_bus_middleware)
-            ? $command_bus_middleware
-            : array($command_bus_middleware);
-    }
-
-
-
-    /**
-     * @return CommandHandlerManagerInterface
-     */
-    public function getCommandHandlerManager()
-    {
-        return $this->command_handler_manager;
-    }
-
-
-
-    /**
-     * @param CommandInterface $command
-     * @return mixed
-     * @throws InvalidDataTypeException
-     * @throws InvalidCommandBusMiddlewareException
-     */
-    public function execute($command)
-    {
-        if (! $command instanceof CommandInterface) {
-            throw new InvalidDataTypeException(__METHOD__ . '( $command )', $command, 'CommandInterface');
-        }
-        // we're going to add the Command Handler as a callable
-        // that will get run at the end of our middleware stack
-        // can't pass $this to a Closure, so use a named variable
-        $command_bus = $this;
-        $middleware = function ($command) use ($command_bus) {
-            return $command_bus->getCommandHandlerManager()
-                ->getCommandHandler($command, $command_bus)
-                ->handle($command);
-        };
-        // now build the rest of the middleware stack
-        while ($command_bus_middleware = array_pop($this->command_bus_middleware)) {
-            if (! $command_bus_middleware instanceof CommandBusMiddlewareInterface) {
-                throw new InvalidCommandBusMiddlewareException($command_bus_middleware);
-            }
-            $middleware = function ($command) use ($command_bus_middleware, $middleware) {
-                return $command_bus_middleware->handle($command, $middleware);
-            };
-        }
-        // and finally, pass the command into the stack and return the results
-        return $middleware($command);
-    }
+	/**
+	 * @type CommandHandlerManagerInterface $command_handler_manager
+	 */
+	private $command_handler_manager;
+
+	/**
+	 * @type CommandBusMiddlewareInterface[] $command_bus_middleware
+	 */
+	private $command_bus_middleware;
+
+
+
+	/**
+	 * CommandBus constructor
+	 *
+	 * @param CommandHandlerManagerInterface  $command_handler_manager
+	 * @param CommandBusMiddlewareInterface[] $command_bus_middleware
+	 */
+	public function __construct(
+		CommandHandlerManagerInterface $command_handler_manager,
+		array $command_bus_middleware = array()
+	) {
+		$this->command_handler_manager = $command_handler_manager;
+		$this->command_bus_middleware = is_array($command_bus_middleware)
+			? $command_bus_middleware
+			: array($command_bus_middleware);
+	}
+
+
+
+	/**
+	 * @return CommandHandlerManagerInterface
+	 */
+	public function getCommandHandlerManager()
+	{
+		return $this->command_handler_manager;
+	}
+
+
+
+	/**
+	 * @param CommandInterface $command
+	 * @return mixed
+	 * @throws InvalidDataTypeException
+	 * @throws InvalidCommandBusMiddlewareException
+	 */
+	public function execute($command)
+	{
+		if (! $command instanceof CommandInterface) {
+			throw new InvalidDataTypeException(__METHOD__ . '( $command )', $command, 'CommandInterface');
+		}
+		// we're going to add the Command Handler as a callable
+		// that will get run at the end of our middleware stack
+		// can't pass $this to a Closure, so use a named variable
+		$command_bus = $this;
+		$middleware = function ($command) use ($command_bus) {
+			return $command_bus->getCommandHandlerManager()
+				->getCommandHandler($command, $command_bus)
+				->handle($command);
+		};
+		// now build the rest of the middleware stack
+		while ($command_bus_middleware = array_pop($this->command_bus_middleware)) {
+			if (! $command_bus_middleware instanceof CommandBusMiddlewareInterface) {
+				throw new InvalidCommandBusMiddlewareException($command_bus_middleware);
+			}
+			$middleware = function ($command) use ($command_bus_middleware, $middleware) {
+				return $command_bus_middleware->handle($command, $middleware);
+			};
+		}
+		// and finally, pass the command into the stack and return the results
+		return $middleware($command);
+	}
 
 
 }

core/services/commands/CommandFactory.php

Indentation +34 added lines, -34 removed lines

@@ -24,40 +24,40 @@
 
 
 
-    /**
-     * @var LoaderInterface $loader
-     */
-    private $loader;
-
-
-
-    /**
-     * CommandFactory constructor
-     *
-     * @param LoaderInterface $loader
-     * @throws InvalidDataTypeException
-     * @throws InvalidInterfaceException
-     * @throws InvalidArgumentException
-     */
-    public function __construct(LoaderInterface $loader = null)
-    {
-       $this->loader = $loader;
-    }
-
-
-
-    /**
-     * @param string $command_fqcn
-     * @param array  $arguments
-     * @return mixed
-     * @throws InvalidArgumentException
-     * @throws InvalidDataTypeException
-     * @throws InvalidInterfaceException
-     */
-    public function getNew($command_fqcn, $arguments = array())
-    {
-        return $this->loader->getNew($command_fqcn, $arguments);
-    }
+	/**
+	 * @var LoaderInterface $loader
+	 */
+	private $loader;
+
+
+
+	/**
+	 * CommandFactory constructor
+	 *
+	 * @param LoaderInterface $loader
+	 * @throws InvalidDataTypeException
+	 * @throws InvalidInterfaceException
+	 * @throws InvalidArgumentException
+	 */
+	public function __construct(LoaderInterface $loader = null)
+	{
+	   $this->loader = $loader;
+	}
+
+
+
+	/**
+	 * @param string $command_fqcn
+	 * @param array  $arguments
+	 * @return mixed
+	 * @throws InvalidArgumentException
+	 * @throws InvalidDataTypeException
+	 * @throws InvalidInterfaceException
+	 */
+	public function getNew($command_fqcn, $arguments = array())
+	{
+		return $this->loader->getNew($command_fqcn, $arguments);
+	}
 
 
 

core/services/commands/CommandFactoryInterface.php

Indentation +9 added lines, -9 removed lines

@@ -13,15 +13,15 @@
 interface CommandFactoryInterface
 {
 
-    /**
-     * @param string $command_fqcn
-     * @param array  $arguments
-     * @return mixed
-     * @throws InvalidArgumentException
-     * @throws InvalidDataTypeException
-     * @throws InvalidInterfaceException
-     */
-    public function getNew($command_fqcn, $arguments = array());
+	/**
+	 * @param string $command_fqcn
+	 * @param array  $arguments
+	 * @return mixed
+	 * @throws InvalidArgumentException
+	 * @throws InvalidDataTypeException
+	 * @throws InvalidInterfaceException
+	 */
+	public function getNew($command_fqcn, $arguments = array());
 
 }
 // End of file CommandFactoryInterface.php

core/services/commands/CommandHandlerManager.php

Indentation +104 added lines, -104 removed lines

@@ -6,7 +6,7 @@ 
 use EventEspresso\core\services\loaders\LoaderInterface;
 
 if (! defined('EVENT_ESPRESSO_VERSION')) {
-    exit('No direct script access allowed');
+	exit('No direct script access allowed');
 }
 
 
@@ -24,109 +24,109 @@ 
 class CommandHandlerManager implements CommandHandlerManagerInterface
 {
 
-    /**
-     * @var CommandHandlerInterface[] $command_handlers
-     */
-    protected $command_handlers;
-
-    /**
-     * @type LoaderInterface $loader
-     */
-    private $loader;
-
-
-
-    /**
-     * CommandHandlerManager constructor
-     *
-     * @param LoaderInterface $loader
-     */
-    public function __construct(LoaderInterface $loader)
-    {
-        $this->loader = $loader;
-    }
-
-
-
-    /**
-     * By default, Commands and CommandHandlers would normally
-     * reside in the same folder under the same namespace,
-     * and the names of the two classes would only differ in that
-     * one ends in "Command" and the other ends in "CommandHandler".
-     * However, if you wanted to utilize a CommandHandler from somewhere else,
-     * then this method allows you to add that CommandHandler and specify the FQCN
-     * (Fully Qualified ClassName) for the Command class that it should be used for.
-     * For example:
-     *      by default the "Vendor\some\namespace\DoSomethingCommand"
-     *      would resolve to using "Vendor\some\namespace\DoSomethingCommandHandler"
-     *      but if you wanted to instead process that commend using:
-     *      "Vendor\a\totally\different\namespace\for\DoSomethingCommandHandler"
-     *      then the following code:
-     *      $CommandHandlerManager = $this->loader->getShared( 'CommandHandlerManagerInterface' );
-     *      $CommandHandlerManager->addCommandHandler(
-     *          new Vendor\a\totally\different\namespace\for\DoSomethingCommandHandler(),
-     *          'Vendor\some\namespace\DoSomethingCommand'
-     *      );
-     *      would result in the alternate CommandHandler being used to process that Command
-     *
-     * @param CommandHandlerInterface $command_handler
-     * @param string                  $fqcn_for_command Fully Qualified ClassName for Command
-     * @return void
-     * @throws InvalidCommandHandlerException
-     */
-    public function addCommandHandler(CommandHandlerInterface $command_handler, $fqcn_for_command = '')
-    {
-        $command = ! empty($fqcn_for_command)
-            ? $fqcn_for_command
-            : str_replace('CommandHandler', 'Command', get_class($command_handler));
-        if (empty($command)) {
-            throw new InvalidCommandHandlerException($command);
-        }
-        $this->command_handlers[$command] = $command_handler;
-    }
-
-
-
-    /**
-     * @param CommandInterface $command
-     * @param CommandBusInterface       $command_bus
-     * @return mixed
-     * @throws DomainException
-     * @throws CommandHandlerNotFoundException
-     */
-    public function getCommandHandler(CommandInterface $command, CommandBusInterface $command_bus = null)
-    {
-        $command_name = get_class($command);
-        $command_handler = apply_filters(
-            'FHEE__EventEspresso_core_services_commands_CommandHandlerManager__getCommandHandler__command_handler',
-            str_replace('Command', 'CommandHandler', $command_name),
-            $command
-        );
-        $handler = null;
-        // has a command handler already been set for this class ?
-        // if not, can we find one via the FQCN ?
-        if (isset($this->command_handlers[$command_name])) {
-            $handler = $this->command_handlers[$command_name];
-        } else if (class_exists($command_handler)) {
-            $handler = $this->loader->getShared($command_handler);
-        }
-        // if Handler requires an instance of the CommandBus, but that has not yet been set
-        if ($handler instanceof CompositeCommandHandler && ! $handler->commandBus() instanceof CommandBusInterface) {
-            if (! $command_bus instanceof CommandBusInterface) {
-                throw new DomainException(
-                    esc_html__(
-                        'CompositeCommandHandler classes require an instance of the CommandBus.',
-                        'event_espresso'
-                    )
-                );
-            }
-            $handler->setCommandBus($command_bus);
-        }
-        if ($handler instanceof CommandHandlerInterface) {
-            return $handler;
-        }
-        throw new CommandHandlerNotFoundException($command_handler);
-    }
+	/**
+	 * @var CommandHandlerInterface[] $command_handlers
+	 */
+	protected $command_handlers;
+
+	/**
+	 * @type LoaderInterface $loader
+	 */
+	private $loader;
+
+
+
+	/**
+	 * CommandHandlerManager constructor
+	 *
+	 * @param LoaderInterface $loader
+	 */
+	public function __construct(LoaderInterface $loader)
+	{
+		$this->loader = $loader;
+	}
+
+
+
+	/**
+	 * By default, Commands and CommandHandlers would normally
+	 * reside in the same folder under the same namespace,
+	 * and the names of the two classes would only differ in that
+	 * one ends in "Command" and the other ends in "CommandHandler".
+	 * However, if you wanted to utilize a CommandHandler from somewhere else,
+	 * then this method allows you to add that CommandHandler and specify the FQCN
+	 * (Fully Qualified ClassName) for the Command class that it should be used for.
+	 * For example:
+	 *      by default the "Vendor\some\namespace\DoSomethingCommand"
+	 *      would resolve to using "Vendor\some\namespace\DoSomethingCommandHandler"
+	 *      but if you wanted to instead process that commend using:
+	 *      "Vendor\a\totally\different\namespace\for\DoSomethingCommandHandler"
+	 *      then the following code:
+	 *      $CommandHandlerManager = $this->loader->getShared( 'CommandHandlerManagerInterface' );
+	 *      $CommandHandlerManager->addCommandHandler(
+	 *          new Vendor\a\totally\different\namespace\for\DoSomethingCommandHandler(),
+	 *          'Vendor\some\namespace\DoSomethingCommand'
+	 *      );
+	 *      would result in the alternate CommandHandler being used to process that Command
+	 *
+	 * @param CommandHandlerInterface $command_handler
+	 * @param string                  $fqcn_for_command Fully Qualified ClassName for Command
+	 * @return void
+	 * @throws InvalidCommandHandlerException
+	 */
+	public function addCommandHandler(CommandHandlerInterface $command_handler, $fqcn_for_command = '')
+	{
+		$command = ! empty($fqcn_for_command)
+			? $fqcn_for_command
+			: str_replace('CommandHandler', 'Command', get_class($command_handler));
+		if (empty($command)) {
+			throw new InvalidCommandHandlerException($command);
+		}
+		$this->command_handlers[$command] = $command_handler;
+	}
+
+
+
+	/**
+	 * @param CommandInterface $command
+	 * @param CommandBusInterface       $command_bus
+	 * @return mixed
+	 * @throws DomainException
+	 * @throws CommandHandlerNotFoundException
+	 */
+	public function getCommandHandler(CommandInterface $command, CommandBusInterface $command_bus = null)
+	{
+		$command_name = get_class($command);
+		$command_handler = apply_filters(
+			'FHEE__EventEspresso_core_services_commands_CommandHandlerManager__getCommandHandler__command_handler',
+			str_replace('Command', 'CommandHandler', $command_name),
+			$command
+		);
+		$handler = null;
+		// has a command handler already been set for this class ?
+		// if not, can we find one via the FQCN ?
+		if (isset($this->command_handlers[$command_name])) {
+			$handler = $this->command_handlers[$command_name];
+		} else if (class_exists($command_handler)) {
+			$handler = $this->loader->getShared($command_handler);
+		}
+		// if Handler requires an instance of the CommandBus, but that has not yet been set
+		if ($handler instanceof CompositeCommandHandler && ! $handler->commandBus() instanceof CommandBusInterface) {
+			if (! $command_bus instanceof CommandBusInterface) {
+				throw new DomainException(
+					esc_html__(
+						'CompositeCommandHandler classes require an instance of the CommandBus.',
+						'event_espresso'
+					)
+				);
+			}
+			$handler->setCommandBus($command_bus);
+		}
+		if ($handler instanceof CommandHandlerInterface) {
+			return $handler;
+		}
+		throw new CommandHandlerNotFoundException($command_handler);
+	}
 
 
 }

Spacing +2 added lines, -2 removed lines

@@ -5,7 +5,7 @@ 
 use DomainException;
 use EventEspresso\core\services\loaders\LoaderInterface;
 
-if (! defined('EVENT_ESPRESSO_VERSION')) {
+if ( ! defined('EVENT_ESPRESSO_VERSION')) {
     exit('No direct script access allowed');
 }
 
@@ -112,7 +112,7 @@ 
         }
         // if Handler requires an instance of the CommandBus, but that has not yet been set
         if ($handler instanceof CompositeCommandHandler && ! $handler->commandBus() instanceof CommandBusInterface) {
-            if (! $command_bus instanceof CommandBusInterface) {
+            if ( ! $command_bus instanceof CommandBusInterface) {
                 throw new DomainException(
                     esc_html__(
                         'CompositeCommandHandler classes require an instance of the CommandBus.',

core/services/loaders/Loader.php

Indentation +134 added lines, -134 removed lines

@@ -24,140 +24,140 @@
 {
 
 
-    /**
-     * @var LoaderDecoratorInterface $new_loader
-     */
-    private $new_loader;
-
-
-    /**
-     * @var LoaderDecoratorInterface $shared_loader
-     */
-    private $shared_loader;
-
-
-
-    /**
-     * Loader constructor.
-     *
-     * @param LoaderDecoratorInterface|null $new_loader
-     * @param LoaderDecoratorInterface|null $shared_loader
-     * @throws InvalidInterfaceException
-     * @throws InvalidArgumentException
-     * @throws InvalidDataTypeException
-     */
-    public function __construct(LoaderDecoratorInterface $new_loader = null, LoaderDecoratorInterface $shared_loader = null)
-    {
-        $this->new_loader = $this->setupNewLoader($new_loader);
-        $this->shared_loader = $this->setupSharedLoader($shared_loader);
-    }
-
-
-
-    /**
-     * @param LoaderDecoratorInterface|null $new_loader
-     * @return CoreLoader|LoaderDecoratorInterface
-     * @throws InvalidArgumentException
-     */
-    private function setupNewLoader(LoaderDecoratorInterface $new_loader = null)
-    {
-        // if not already generated, create a standard loader
-        if (! $new_loader instanceof LoaderDecoratorInterface) {
-            $new_loader = new CoreLoader(EE_Registry::instance());
-        }
-        return $new_loader;
-    }
-
-
-
-    /**
-     * @param LoaderDecoratorInterface|null $shared_loader
-     * @return CoreLoader|LoaderDecoratorInterface
-     * @throws InvalidDataTypeException
-     * @throws InvalidInterfaceException
-     * @throws InvalidArgumentException
-     */
-    private function setupSharedLoader(LoaderDecoratorInterface $shared_loader = null)
-    {
-        // if not already generated, create a caching loader
-        if (! $shared_loader instanceof LoaderDecoratorInterface) {
-            $shared_loader = new CachingLoader(
-                new CoreLoader(EE_Registry::instance()),
-                new LooseCollection('')
-            );
-        }
-        return $shared_loader;
-    }
-
-
-
-    /**
-     * @return LoaderDecoratorInterface
-     */
-    public function getNewLoader()
-    {
-        return $this->new_loader;
-    }
-
-
-
-    /**
-     * @return LoaderDecoratorInterface
-     */
-    public function getSharedLoader()
-    {
-        return $this->shared_loader;
-    }
-
-
-
-    /**
-     * @param string $fqcn
-     * @param array  $arguments
-     * @param bool   $shared
-     * @return mixed
-     */
-    public function load($fqcn, $arguments = array(), $shared = true)
-    {
-        return $shared
-            ? $this->getSharedLoader()->load($fqcn, $arguments)
-            : $this->getNewLoader()->load($fqcn, $arguments);
-    }
-
-
-
-    /**
-     * @param string $fqcn
-     * @param array  $arguments
-     * @return mixed
-     */
-    public function getNew($fqcn, $arguments = array())
-    {
-        return $this->getNewLoader()->load($fqcn, $arguments);
-    }
-
-
-
-    /**
-     * @param string $fqcn
-     * @param array  $arguments
-     * @return mixed
-     */
-    public function getShared($fqcn, $arguments = array())
-    {
-        return $this->getSharedLoader()->load($fqcn, $arguments);
-    }
-
-
-
-    /**
-     * calls reset() on loaders if that method exists
-     */
-    public function reset()
-    {
-        $this->new_loader->reset();
-        $this->shared_loader->reset();
-    }
+	/**
+	 * @var LoaderDecoratorInterface $new_loader
+	 */
+	private $new_loader;
+
+
+	/**
+	 * @var LoaderDecoratorInterface $shared_loader
+	 */
+	private $shared_loader;
+
+
+
+	/**
+	 * Loader constructor.
+	 *
+	 * @param LoaderDecoratorInterface|null $new_loader
+	 * @param LoaderDecoratorInterface|null $shared_loader
+	 * @throws InvalidInterfaceException
+	 * @throws InvalidArgumentException
+	 * @throws InvalidDataTypeException
+	 */
+	public function __construct(LoaderDecoratorInterface $new_loader = null, LoaderDecoratorInterface $shared_loader = null)
+	{
+		$this->new_loader = $this->setupNewLoader($new_loader);
+		$this->shared_loader = $this->setupSharedLoader($shared_loader);
+	}
+
+
+
+	/**
+	 * @param LoaderDecoratorInterface|null $new_loader
+	 * @return CoreLoader|LoaderDecoratorInterface
+	 * @throws InvalidArgumentException
+	 */
+	private function setupNewLoader(LoaderDecoratorInterface $new_loader = null)
+	{
+		// if not already generated, create a standard loader
+		if (! $new_loader instanceof LoaderDecoratorInterface) {
+			$new_loader = new CoreLoader(EE_Registry::instance());
+		}
+		return $new_loader;
+	}
+
+
+
+	/**
+	 * @param LoaderDecoratorInterface|null $shared_loader
+	 * @return CoreLoader|LoaderDecoratorInterface
+	 * @throws InvalidDataTypeException
+	 * @throws InvalidInterfaceException
+	 * @throws InvalidArgumentException
+	 */
+	private function setupSharedLoader(LoaderDecoratorInterface $shared_loader = null)
+	{
+		// if not already generated, create a caching loader
+		if (! $shared_loader instanceof LoaderDecoratorInterface) {
+			$shared_loader = new CachingLoader(
+				new CoreLoader(EE_Registry::instance()),
+				new LooseCollection('')
+			);
+		}
+		return $shared_loader;
+	}
+
+
+
+	/**
+	 * @return LoaderDecoratorInterface
+	 */
+	public function getNewLoader()
+	{
+		return $this->new_loader;
+	}
+
+
+
+	/**
+	 * @return LoaderDecoratorInterface
+	 */
+	public function getSharedLoader()
+	{
+		return $this->shared_loader;
+	}
+
+
+
+	/**
+	 * @param string $fqcn
+	 * @param array  $arguments
+	 * @param bool   $shared
+	 * @return mixed
+	 */
+	public function load($fqcn, $arguments = array(), $shared = true)
+	{
+		return $shared
+			? $this->getSharedLoader()->load($fqcn, $arguments)
+			: $this->getNewLoader()->load($fqcn, $arguments);
+	}
+
+
+
+	/**
+	 * @param string $fqcn
+	 * @param array  $arguments
+	 * @return mixed
+	 */
+	public function getNew($fqcn, $arguments = array())
+	{
+		return $this->getNewLoader()->load($fqcn, $arguments);
+	}
+
+
+
+	/**
+	 * @param string $fqcn
+	 * @param array  $arguments
+	 * @return mixed
+	 */
+	public function getShared($fqcn, $arguments = array())
+	{
+		return $this->getSharedLoader()->load($fqcn, $arguments);
+	}
+
+
+
+	/**
+	 * calls reset() on loaders if that method exists
+	 */
+	public function reset()
+	{
+		$this->new_loader->reset();
+		$this->shared_loader->reset();
+	}
 
 }
 // End of file Loader.php

Spacing +2 added lines, -2 removed lines

@@ -62,7 +62,7 @@ 
     private function setupNewLoader(LoaderDecoratorInterface $new_loader = null)
     {
         // if not already generated, create a standard loader
-        if (! $new_loader instanceof LoaderDecoratorInterface) {
+        if ( ! $new_loader instanceof LoaderDecoratorInterface) {
             $new_loader = new CoreLoader(EE_Registry::instance());
         }
         return $new_loader;
@@ -80,7 +80,7 @@ 
     private function setupSharedLoader(LoaderDecoratorInterface $shared_loader = null)
     {
         // if not already generated, create a caching loader
-        if (! $shared_loader instanceof LoaderDecoratorInterface) {
+        if ( ! $shared_loader instanceof LoaderDecoratorInterface) {
             $shared_loader = new CachingLoader(
                 new CoreLoader(EE_Registry::instance()),
                 new LooseCollection('')