eventespresso /
event-espresso-core
Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.
Common duplication problems, and corresponding solutions are:
| 1 | <?php |
||
| 23 | class Attendee extends Calculations_Base |
||
| 24 | { |
||
| 25 | |||
| 26 | /** |
||
| 27 | * @since $VID:$ |
||
| 28 | * @param $wpdb_row |
||
| 29 | * @return EE_Attendee|\EE_Base_Class |
||
| 30 | * @throws EE_Error |
||
| 31 | * @throws InvalidArgumentException |
||
| 32 | * @throws InvalidDataTypeException |
||
| 33 | * @throws InvalidInterfaceException |
||
| 34 | */ |
||
| 35 | private static function getAttendeeObject($wpdb_row) |
||
| 43 | |||
| 44 | |||
| 45 | /** |
||
| 46 | * @param array $wpdb_row |
||
| 47 | * @param WP_REST_Request $request |
||
| 48 | * @param Base $controller |
||
| 49 | * @since $VID:$ |
||
| 50 | * @return string |
||
| 51 | * @throws EE_Error |
||
| 52 | * @throws InvalidArgumentException |
||
| 53 | * @throws InvalidDataTypeException |
||
| 54 | * @throws InvalidInterfaceException |
||
| 55 | */ |
||
| 56 | public static function userAvatar(array $wpdb_row, WP_REST_Request $request, Base $controller) |
||
| 65 | } |
||
| 66 |
Let’s assume that you have a directory layout like this:
. |-- OtherDir | |-- Bar.php | `-- Foo.php `-- SomeDir `-- Foo.phpand let’s assume the following content of
Bar.php:If both files
OtherDir/Foo.phpandSomeDir/Foo.phpare loaded in the same runtime, you will see a PHP error such as the following:PHP Fatal error: Cannot use SomeDir\Foo as Foo because the name is already in use in OtherDir/Foo.phpHowever, as
OtherDir/Foo.phpdoes not necessarily have to be loaded and the error is only triggered if it is loaded beforeOtherDir/Bar.php, this problem might go unnoticed for a while. In order to prevent this error from surfacing, you must import the namespace with a different alias: