Completed
Branch BUG-9492-refactor-activation-l... (db7e0e)
by
unknown
40:08 queued 27:31
created
core/db_models/helpers/EE_Primary_Key_Index.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -4,7 +4,7 @@
 block discarded – undo
4 4
  * Used to indicate  a primary key index - ie, a set of fields which, when used in combination,
5 5
  * also uniquely identify a model object in the database (in case there is no primary key field).
6 6
  */
7
-class EE_Primary_Key_Index extends EE_Unique_Index{
7
+class EE_Primary_Key_Index extends EE_Unique_Index {
8 8
 	//yep, actually the same as unique index right now
9 9
 	
10 10
 }
Please login to merge, or discard this patch.
core/db_models/helpers/EE_Primary_Table.php 1 patch
Spacing   +5 added lines, -5 removed lines patch added patch discarded remove patch
@@ -4,8 +4,8 @@  discard block
 block discarded – undo
4 4
  * For defining the main table of the model. This is the table with the model's primary key's field. So for CPT models, this will
5 5
  * probably be the wp_posts table (so the table name supplied will be 'posts', as the 'wp_' varies). For models only using one table, this will be that table.
6 6
  */
7
-require_once( EE_MODELS . 'helpers/EE_Table_Base.php');
8
-class EE_Primary_Table extends EE_Table_Base{
7
+require_once(EE_MODELS.'helpers/EE_Table_Base.php');
8
+class EE_Primary_Table extends EE_Table_Base {
9 9
 
10 10
 	/**
11 11
 	 *
@@ -15,14 +15,14 @@  discard block
 block discarded – undo
15 15
 	 * @param boolean $global whether the table is "global" as in there is only 1 table on an entire multisite install,
16 16
 	 *					or whether each site on a multisite install has a copy of this table
17 17
 	 */
18
-	function __construct($table_name, $pk_column = null, $global = false){
19
-		parent::__construct($table_name, $pk_column, $global );
18
+	function __construct($table_name, $pk_column = null, $global = false) {
19
+		parent::__construct($table_name, $pk_column, $global);
20 20
 	}
21 21
 	/**
22 22
 	 * Gets SQL for this table and assigning it an alias. Eg " wp_esp_attendee AS Attendee "
23 23
 	 * @return string
24 24
 	 */
25
-	function get_table_sql(){
25
+	function get_table_sql() {
26 26
 		return " ".$this->get_table_name()." AS ".$this->get_table_alias()." ";
27 27
 	}
28 28
 
Please login to merge, or discard this patch.
core/db_models/helpers/EE_Secondary_Table.php 2 patches
Spacing   +21 added lines, -21 removed lines patch added patch discarded remove patch
@@ -5,8 +5,8 @@  discard block
 block discarded – undo
5 5
  * table's rows. Ie, it can't have many rows in the secondary table that point to
6 6
  * a single row in the primary table
7 7
  */
8
-require_once( EE_MODELS . 'helpers/EE_Table_Base.php');
9
-class EE_Secondary_Table extends EE_Table_Base{
8
+require_once(EE_MODELS.'helpers/EE_Table_Base.php');
9
+class EE_Secondary_Table extends EE_Table_Base {
10 10
 	protected $_extra_join_conditions;
11 11
 
12 12
 	/**
@@ -19,15 +19,15 @@  discard block
 block discarded – undo
19 19
 	 * @param boolean $global whether the table is "global" as in there is only 1 table on an entire multisite install,
20 20
 	 *					or whether each site on a multisite install has a copy of this table
21 21
 	 */
22
-	function __construct($table_name, $pk_column,  $fk_column = null, $extra_join_conditions = null, $global = false ){
22
+	function __construct($table_name, $pk_column, $fk_column = null, $extra_join_conditions = null, $global = false) {
23 23
 		$this->_fk_on_table = $fk_column;
24 24
 		$this->_extra_join_conditions = $extra_join_conditions;
25
-		parent::__construct( $table_name, $pk_column, $global );
25
+		parent::__construct($table_name, $pk_column, $global);
26 26
 	}
27
-	function get_fk_on_table(){
27
+	function get_fk_on_table() {
28 28
 		return $this->_fk_on_table;
29 29
 	}
30
-	function _construct_finalize_set_table_to_join_with(EE_Table_Base $table){
30
+	function _construct_finalize_set_table_to_join_with(EE_Table_Base $table) {
31 31
 		$this->_table_to_join_with = $table;
32 32
 	}
33 33
 	/**
@@ -35,14 +35,14 @@  discard block
 block discarded – undo
35 35
 	 * @return string of sql like "Event.post_type = 'event'", which gets added to
36 36
 	 * the end of the join statement with the primary table
37 37
 	 */
38
-	function get_extra_join_conditions(){
38
+	function get_extra_join_conditions() {
39 39
 		return $this->_extra_join_conditions;
40 40
 	}
41 41
 	/**
42 42
 	 *
43 43
 	 * @return EE_Primary_Table
44 44
 	 */
45
-	function get_table_to_join_with(){
45
+	function get_table_to_join_with() {
46 46
 		return $this->_table_to_join_with;
47 47
 	}
48 48
 	/**
@@ -52,15 +52,15 @@  discard block
 block discarded – undo
52 52
 	 * @param string $table allows us to set special conditions on the $table_name portion of the join query (i.e. doing a subquery)
53 53
 	 * @return string of SQL
54 54
 	 */
55
-	function get_join_sql( $primary_table_alias_with_model_chain_prefix  ){
55
+	function get_join_sql($primary_table_alias_with_model_chain_prefix) {
56 56
 
57 57
 		$table_name = $this->get_table_name();
58
-		$secondary_table_alias = EE_Model_Parser::get_prefix_from_table_alias_with_model_relation_chain_prefix($primary_table_alias_with_model_chain_prefix) . $this->get_table_alias();
58
+		$secondary_table_alias = EE_Model_Parser::get_prefix_from_table_alias_with_model_relation_chain_prefix($primary_table_alias_with_model_chain_prefix).$this->get_table_alias();
59 59
 		$other_table_pk = $this->get_table_to_join_with()->get_pk_column();
60 60
 		$fk = $this->get_fk_on_table();
61 61
 		$join_sql = " LEFT JOIN $table_name AS $secondary_table_alias ON $primary_table_alias_with_model_chain_prefix.$other_table_pk = $secondary_table_alias.$fk ";
62
-		if($this->get_extra_join_conditions()){
63
-			$join_sql.="AND ".$this->get_extra_join_conditions();
62
+		if ($this->get_extra_join_conditions()) {
63
+			$join_sql .= "AND ".$this->get_extra_join_conditions();
64 64
 		}
65 65
 		return $join_sql;
66 66
 	}
@@ -74,14 +74,14 @@  discard block
 block discarded – undo
74 74
 	 * This is useful if the secondary table is already included in the SQL, but the primary table is not yet.
75 75
 	 * @return string
76 76
 	 */
77
-	function get_inverse_join_sql($secondary_table_alias_with_model_chain_prefix){
78
-		$primary_table_name =$this->get_table_to_join_with()->get_table_name();
79
-		$primary_table_alias = EE_Model_Parser::get_prefix_from_table_alias_with_model_relation_chain_prefix($secondary_table_alias_with_model_chain_prefix) . $this->get_table_to_join_with()->get_table_alias();
80
-		$primary_table_pk = $this->get_table_to_join_with()->get_pk_column();//$this->get_pk_column();
77
+	function get_inverse_join_sql($secondary_table_alias_with_model_chain_prefix) {
78
+		$primary_table_name = $this->get_table_to_join_with()->get_table_name();
79
+		$primary_table_alias = EE_Model_Parser::get_prefix_from_table_alias_with_model_relation_chain_prefix($secondary_table_alias_with_model_chain_prefix).$this->get_table_to_join_with()->get_table_alias();
80
+		$primary_table_pk = $this->get_table_to_join_with()->get_pk_column(); //$this->get_pk_column();
81 81
 		$fk = $this->get_fk_on_table();
82 82
 		$join_sql = " LEFT JOIN $primary_table_name AS $primary_table_alias ON $primary_table_alias.$primary_table_pk = $secondary_table_alias_with_model_chain_prefix.$fk ";
83
-		if($this->get_extra_join_conditions()){
84
-			$join_sql.="AND ".$this->get_extra_join_conditions();
83
+		if ($this->get_extra_join_conditions()) {
84
+			$join_sql .= "AND ".$this->get_extra_join_conditions();
85 85
 		}
86 86
 		return $join_sql;
87 87
 	}
@@ -94,7 +94,7 @@  discard block
 block discarded – undo
94 94
 	public function get_select_join_limit_join($limit) {
95 95
 		//first get the select
96 96
 		$select = $this->get_select_join_limit($limit);
97
-		$join_sql = $this->get_join_sql( $select );
97
+		$join_sql = $this->get_join_sql($select);
98 98
 		return $join_sql;
99 99
 	}
100 100
 
@@ -103,12 +103,12 @@  discard block
 block discarded – undo
103 103
 	function get_fully_qualified_fk_column() {
104 104
 		$table_alias = $this->get_table_alias();
105 105
 		$fk = $this->get_fk_on_table();
106
-		return $table_alias . '.' . $fk;
106
+		return $table_alias.'.'.$fk;
107 107
 	}
108 108
 
109 109
 	function get_fully_qualified_pk_on_fk_table() {
110 110
 		$table_alias = $this->get_table_to_join_with()->get_table_alias();
111 111
 		$pk = $this->get_table_to_join_with()->get_pk_column();
112
-		return $table_alias . '.' . $pk;
112
+		return $table_alias.'.'.$pk;
113 113
 	}
114 114
 }
115 115
\ No newline at end of file
Please login to merge, or discard this patch.
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -49,7 +49,6 @@  discard block
 block discarded – undo
49 49
 	 * creates join statement FROM primary table
50 50
 	 * gets SQL like "LEFT JOIN table_name AS table_alias ON other_table_alias.pk = table_alias.fk
51 51
 	 *
52
-	 * @param string $table allows us to set special conditions on the $table_name portion of the join query (i.e. doing a subquery)
53 52
 	 * @return string of SQL
54 53
 	 */
55 54
 	function get_join_sql( $primary_table_alias_with_model_chain_prefix  ){
@@ -72,6 +71,7 @@  discard block
 block discarded – undo
72 71
 	 * " LEFT JOIN secondary_table_table AS Secondary ON ..." like get_join_sql, this function returns
73 72
 	 * " LEFT JOIN primary_table AS Primary ON ...".
74 73
 	 * This is useful if the secondary table is already included in the SQL, but the primary table is not yet.
74
+	 * @param string $secondary_table_alias_with_model_chain_prefix
75 75
 	 * @return string
76 76
 	 */
77 77
 	function get_inverse_join_sql($secondary_table_alias_with_model_chain_prefix){
Please login to merge, or discard this patch.
core/db_models/helpers/EE_Table_Base.php 1 patch
Spacing   +15 added lines, -15 removed lines patch added patch discarded remove patch
@@ -4,7 +4,7 @@  discard block
 block discarded – undo
4 4
  * Base class for defining the tables that comprise models. This is used to store information
5 5
  * about the table\s alias, private key, etc.
6 6
  */
7
-abstract class EE_Table_Base{
7
+abstract class EE_Table_Base {
8 8
 	var $_table_name;
9 9
 	var $_table_alias;
10 10
 	/**
@@ -21,30 +21,30 @@  discard block
 block discarded – undo
21 21
 	 * @param boolean $global whether the table is "global" as in there is only 1 table on an entire multisite install,
22 22
 	 *					or whether each site on a multisite install has a copy of this table
23 23
 	 */
24
-	function __construct($table_name, $pk_column, $global = false ){
24
+	function __construct($table_name, $pk_column, $global = false) {
25 25
 		global $wpdb;
26
-		if( $global ) {
26
+		if ($global) {
27 27
 			$prefix = $wpdb->base_prefix;
28 28
 		} else {
29 29
 			$prefix = $wpdb->prefix;
30 30
 		}
31 31
 		//if they didn't add the prefix, let's add it
32
-		if( strpos( $table_name, $prefix ) !== 0 ) {
33
-			$table_name = $prefix . $table_name;
32
+		if (strpos($table_name, $prefix) !== 0) {
33
+			$table_name = $prefix.$table_name;
34 34
 		}
35 35
 		$this->_table_name = $table_name;
36 36
 		$this->_pk_column = $pk_column;
37 37
 	}
38 38
 
39
-	function _construct_finalize_with_alias($table_alias){
39
+	function _construct_finalize_with_alias($table_alias) {
40 40
 		$this->_table_alias = $table_alias;
41 41
 	}
42 42
 
43
-	function get_table_name(){
43
+	function get_table_name() {
44 44
 		return $this->_table_name;
45 45
 	}
46
-	function get_table_alias(){
47
-		if( ! $this->_table_alias){
46
+	function get_table_alias() {
47
+		if ( ! $this->_table_alias) {
48 48
 			throw new EE_Error("You must call _construct_finalize_with_alias before using the EE_Table_Base. Did you forget to call parent::__construct at the end of your EEMerimental_Base child's __construct?");
49 49
 		}
50 50
 		return $this->_table_alias;
@@ -54,7 +54,7 @@  discard block
 block discarded – undo
54 54
 	 *
55 55
 	 * @return string name of column of PK
56 56
 	 */
57
-	function get_pk_column(){
57
+	function get_pk_column() {
58 58
 		return $this->_pk_column;
59 59
 	}
60 60
 
@@ -64,8 +64,8 @@  discard block
 block discarded – undo
64 64
 	 * returns a string with the table alias, a period, and the private key's column.
65 65
 	 * @return string
66 66
 	 */
67
-	function get_fully_qualified_pk_column(){
68
-		$sql =  $this->get_table_alias().".".$this->get_pk_column();
67
+	function get_fully_qualified_pk_column() {
68
+		$sql = $this->get_table_alias().".".$this->get_pk_column();
69 69
 		return $sql;
70 70
 	}
71 71
 
@@ -74,9 +74,9 @@  discard block
 block discarded – undo
74 74
 	 * returns the special sql for a inner select with a limit.
75 75
 	 * @return string    SQL select
76 76
 	 */
77
-	public function get_select_join_limit( $limit ) {
78
-		$limit = is_array( $limit ) ? 'LIMIT ' . implode(',', array_map( 'intval', $limit ) ) : 'LIMIT ' . (int) $limit;
79
-		$SQL = SP . '(SELECT * FROM ' . $this->_table_name . SP . $limit . ') AS ' . $this->_table_alias;
77
+	public function get_select_join_limit($limit) {
78
+		$limit = is_array($limit) ? 'LIMIT '.implode(',', array_map('intval', $limit)) : 'LIMIT '.(int) $limit;
79
+		$SQL = SP.'(SELECT * FROM '.$this->_table_name.SP.$limit.') AS '.$this->_table_alias;
80 80
 		return $SQL;
81 81
 	}
82 82
 }
Please login to merge, or discard this patch.
core/db_models/helpers/EE_Unique_Index.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -4,7 +4,7 @@
 block discarded – undo
4 4
  * Used to indicate  a UNIQUE key index - ie, a set of fields which must be unique
5 5
  * for ALL the model objects of this type
6 6
  */
7
-class EE_Unique_Index extends EE_Index{
7
+class EE_Unique_Index extends EE_Index {
8 8
 	//yep, actually the same as index right now
9 9
 	
10 10
 }
Please login to merge, or discard this patch.
core/db_models/relations/EE_Belongs_To_Relation.php 2 patches
Braces   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -94,7 +94,7 @@
 block discarded – undo
94 94
 		//get its value
95 95
 		if( $model_obj_or_id instanceof EE_Base_Class){
96 96
 			$model_obj = $model_obj_or_id;
97
-		}else{
97
+		} else{
98 98
 			$model_obj = $this->get_this_model()->ensure_is_obj($model_obj_or_id);
99 99
 		}
100 100
 		$ID_value_on_other_model = $model_obj->get($fk_field_obj->get_name());
Please login to merge, or discard this patch.
Spacing   +10 added lines, -10 removed lines patch added patch discarded remove patch
@@ -1,5 +1,5 @@  discard block
 block discarded – undo
1 1
 <?php
2
-require_once( EE_MODELS . 'relations/EE_Model_Relation_Base.php');
2
+require_once(EE_MODELS.'relations/EE_Model_Relation_Base.php');
3 3
 /**
4 4
  * Class EE_Belongs_To_Relation
5 5
  *
@@ -36,10 +36,10 @@  discard block
 block discarded – undo
36 36
 		//create the sql string like
37 37
 		$this_table_fk_field = $this->get_this_model()->get_foreign_key_to($this->get_other_model()->get_this_model_name());
38 38
 		$other_table_pk_field = $this->get_other_model()->get_primary_key_field();
39
-		$this_table_alias = EE_Model_Parser::extract_table_alias_model_relation_chain_prefix($model_relation_chain, $this->get_this_model()->get_this_model_name()) . $this_table_fk_field->get_table_alias();
40
-		$other_table_alias = EE_Model_Parser::extract_table_alias_model_relation_chain_prefix($model_relation_chain, $this->get_other_model()->get_this_model_name()) . $other_table_pk_field->get_table_alias();
39
+		$this_table_alias = EE_Model_Parser::extract_table_alias_model_relation_chain_prefix($model_relation_chain, $this->get_this_model()->get_this_model_name()).$this_table_fk_field->get_table_alias();
40
+		$other_table_alias = EE_Model_Parser::extract_table_alias_model_relation_chain_prefix($model_relation_chain, $this->get_other_model()->get_this_model_name()).$other_table_pk_field->get_table_alias();
41 41
 		$other_table = $this->get_other_model()->get_table_for_alias($other_table_alias);
42
-		return $this->_left_join($other_table, $other_table_alias, $other_table_pk_field->get_table_column(), $this_table_alias, $this_table_fk_field->get_table_column()) . $this->get_other_model()->_construct_internal_join_to_table_with_alias($other_table_alias);
42
+		return $this->_left_join($other_table, $other_table_alias, $other_table_pk_field->get_table_column(), $this_table_alias, $this_table_fk_field->get_table_column()).$this->get_other_model()->_construct_internal_join_to_table_with_alias($other_table_alias);
43 43
 	}
44 44
 
45 45
 
@@ -58,7 +58,7 @@  discard block
 block discarded – undo
58 58
 		$other_model_obj = $this->get_other_model()->ensure_is_obj($other_obj_or_id, true);
59 59
 		//find the field on the other model which is a foreign key to this model
60 60
 		$fk_on_this_model = $this->get_this_model()->get_foreign_key_to($this->get_other_model()->get_this_model_name());
61
-		if ( $this_model_obj->get($fk_on_this_model->get_name()) != $other_model_obj->ID()){
61
+		if ($this_model_obj->get($fk_on_this_model->get_name()) != $other_model_obj->ID()) {
62 62
 			//set that field on the other model to this model's ID
63 63
 			$this_model_obj->set($fk_on_this_model->get_name(), $other_model_obj->ID());
64 64
 			$this_model_obj->save();
@@ -79,7 +79,7 @@  discard block
 block discarded – undo
79 79
 	 */
80 80
 	public function remove_relation_to($this_obj_or_id, $other_obj_or_id, $where_query = array()) {
81 81
 		$this_model_obj = $this->get_this_model()->ensure_is_obj($this_obj_or_id, true);
82
-		$other_model_obj = $this->get_other_model()->ensure_is_obj( $other_obj_or_id );
82
+		$other_model_obj = $this->get_other_model()->ensure_is_obj($other_obj_or_id);
83 83
 		//find the field on the other model which is a foreign key to this model
84 84
 		$fk_on_this_model = $this->get_this_model()->get_foreign_key_to($this->get_other_model()->get_this_model_name());
85 85
 		//set that field on the other model to this model's ID
@@ -100,15 +100,15 @@  discard block
 block discarded – undo
100 100
 	 * @throws \EE_Error
101 101
 	 */
102 102
 	public function get_all_related($model_obj_or_id, $query_params = array(), $values_already_prepared_by_model_object = false) {
103
-		if( $values_already_prepared_by_model_object !== false ) {
104
-			EE_Error::doing_it_wrong( 'EE_Model_Relation_Base::get_all_related', __( 'The argument $values_already_prepared_by_model_object is no longer used.', 'event_espresso' ), '4.8.1' );
103
+		if ($values_already_prepared_by_model_object !== false) {
104
+			EE_Error::doing_it_wrong('EE_Model_Relation_Base::get_all_related', __('The argument $values_already_prepared_by_model_object is no longer used.', 'event_espresso'), '4.8.1');
105 105
 		}
106 106
 		//get column on this model object which is a foreign key to the other model
107 107
 		$fk_field_obj = $this->get_this_model()->get_foreign_key_to($this->get_other_model()->get_this_model_name());
108 108
 		//get its value
109
-		if( $model_obj_or_id instanceof EE_Base_Class){
109
+		if ($model_obj_or_id instanceof EE_Base_Class) {
110 110
 			$model_obj = $model_obj_or_id;
111
-		}else{
111
+		} else {
112 112
 			$model_obj = $this->get_this_model()->ensure_is_obj($model_obj_or_id);
113 113
 		}
114 114
 		$ID_value_on_other_model = $model_obj->get($fk_field_obj->get_name());
Please login to merge, or discard this patch.
core/db_models/strategies/EE_Restriction_Generator_Base.strategy.php 2 patches
Spacing   +23 added lines, -23 removed lines patch added patch discarded remove patch
@@ -1,6 +1,6 @@  discard block
 block discarded – undo
1 1
 <?php
2
-if ( !defined( 'EVENT_ESPRESSO_VERSION' ) ) {
3
-	exit( 'No direct script access allowed' );
2
+if ( ! defined('EVENT_ESPRESSO_VERSION')) {
3
+	exit('No direct script access allowed');
4 4
 }
5 5
 
6 6
 /**
@@ -53,7 +53,7 @@  discard block
 block discarded – undo
53 53
 	 * @param EEM_Base $model
54 54
 	 * @param string $action
55 55
 	 */
56
-	public function _construct_finalize( EEM_Base $model, $action ){
56
+	public function _construct_finalize(EEM_Base $model, $action) {
57 57
 		$this->_model = $model;
58 58
 		$this->_action = $action;
59 59
 	}
@@ -65,8 +65,8 @@  discard block
 block discarded – undo
65 65
 	 * @return EEM_Base | EEM_Soft_Delete_Base
66 66
 	 */
67 67
 	public function model() {
68
-		if( ! $this->_model instanceof EEM_Base ) {
69
-			throw new EE_Error( sprintf( __( 'Cannot generate capability restrictions because model has not yet been set on the %s. Please ensure _construct_finalize() was called', 'event_espresso' ), get_class( $this ) ) );
68
+		if ( ! $this->_model instanceof EEM_Base) {
69
+			throw new EE_Error(sprintf(__('Cannot generate capability restrictions because model has not yet been set on the %s. Please ensure _construct_finalize() was called', 'event_espresso'), get_class($this)));
70 70
 		}
71 71
 		return $this->_model;
72 72
 	}
@@ -79,8 +79,8 @@  discard block
 block discarded – undo
79 79
 	 * @return string
80 80
 	 */
81 81
 	public function action() {
82
-		if( ! $this->_action ) {
83
-			throw new EE_Error( sprintf( __( 'Cannot generate capability restrictions because model has not yet been set on the %s. Please ensure _construct_finalize() was called', 'event_espresso' ), get_class( $this ) ) );
82
+		if ( ! $this->_action) {
83
+			throw new EE_Error(sprintf(__('Cannot generate capability restrictions because model has not yet been set on the %s. Please ensure _construct_finalize() was called', 'event_espresso'), get_class($this)));
84 84
 		}
85 85
 		return $this->_action;
86 86
 	}
@@ -89,10 +89,10 @@  discard block
 block discarded – undo
89 89
 	 * Returns whether or not _construct_finalize() has been called on this restriction generator object
90 90
 	 * @return boolean
91 91
 	 */
92
-	public function construction_finalized(){
93
-		if( $this->_model instanceof EEM_Base  && $this->_action ){
92
+	public function construction_finalized() {
93
+		if ($this->_model instanceof EEM_Base && $this->_action) {
94 94
 			return true;
95
-		}else{
95
+		} else {
96 96
 			return false;
97 97
 		}
98 98
 	}
@@ -103,10 +103,10 @@  discard block
 block discarded – undo
103 103
 	 * @return array @see EEM_Base::_cap_restrictions
104 104
 	 */
105 105
 	public function generate_restrictions() {
106
-		if( $this->_cap_restrictions_generated === false ) {
107
-			$this->_cap_restrictions_generated = apply_filters( 'FHEE__EE_Restriction_Generator_Base__generate_restrictions__first_time', $this->_generate_restrictions(), $this );
106
+		if ($this->_cap_restrictions_generated === false) {
107
+			$this->_cap_restrictions_generated = apply_filters('FHEE__EE_Restriction_Generator_Base__generate_restrictions__first_time', $this->_generate_restrictions(), $this);
108 108
 		}
109
-		return apply_filters( 'FHEE__EE_Restriction_Generator_Base__generate_restrictions__every_time', $this->_cap_restrictions_generated, $this );
109
+		return apply_filters('FHEE__EE_Restriction_Generator_Base__generate_restrictions__every_time', $this->_cap_restrictions_generated, $this);
110 110
 	}
111 111
 
112 112
 	/**
@@ -122,10 +122,10 @@  discard block
 block discarded – undo
122 122
 	 * making restrictions and caching them on itself in case its asked later
123 123
 	 * @return boolean
124 124
 	 */
125
-	public function has_generated_cap_restrictions(){
126
-		if( $this->_cap_restrictions_generated === false ){
125
+	public function has_generated_cap_restrictions() {
126
+		if ($this->_cap_restrictions_generated === false) {
127 127
 			return false;
128
-		}else{
128
+		} else {
129 129
 			return true;
130 130
 		}
131 131
 	}
@@ -139,8 +139,8 @@  discard block
 block discarded – undo
139 139
 	 * @param string $action
140 140
 	 * @return string
141 141
 	 */
142
-	public static function get_cap_name( $model, $action ) {
143
-		return apply_filters( 'FHEE__EE_Restriction_Generator__get_cap_name', ( $model->is_wp_core_model() ? '' : 'ee_' ) . $action . '_' . $model->cap_slug(), $model, $action );
142
+	public static function get_cap_name($model, $action) {
143
+		return apply_filters('FHEE__EE_Restriction_Generator__get_cap_name', ($model->is_wp_core_model() ? '' : 'ee_').$action.'_'.$model->cap_slug(), $model, $action);
144 144
 	}
145 145
 
146 146
 	/**
@@ -149,11 +149,11 @@  discard block
 block discarded – undo
149 149
 	 * @param string $action
150 150
 	 * @return boolean
151 151
 	 */
152
-	public static function is_cap( $model, $action ) {
153
-		$caps_for_admin = EE_Registry::instance()->CAP->get_ee_capabilities( 'administrator' );
154
-		if( in_array( self::get_cap_name( $model, $action ), $caps_for_admin ) ) {
152
+	public static function is_cap($model, $action) {
153
+		$caps_for_admin = EE_Registry::instance()->CAP->get_ee_capabilities('administrator');
154
+		if (in_array(self::get_cap_name($model, $action), $caps_for_admin)) {
155 155
 			return true;
156
-		}else{
156
+		} else {
157 157
 			return false;
158 158
 		}
159 159
 	}
@@ -164,7 +164,7 @@  discard block
 block discarded – undo
164 164
 	 * @return string
165 165
 	 */
166 166
 	public static function get_default_restrictions_cap() {
167
-		return apply_filters( 'FHEE__EE_Restriction_Generator_Base__default_restrictions_cap', 'manage_options' );
167
+		return apply_filters('FHEE__EE_Restriction_Generator_Base__default_restrictions_cap', 'manage_options');
168 168
 	}
169 169
 }
170 170
 
Please login to merge, or discard this patch.
Braces   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -92,7 +92,7 @@  discard block
 block discarded – undo
92 92
 	public function construction_finalized(){
93 93
 		if( $this->_model instanceof EEM_Base  && $this->_action ){
94 94
 			return true;
95
-		}else{
95
+		} else{
96 96
 			return false;
97 97
 		}
98 98
 	}
@@ -125,7 +125,7 @@  discard block
 block discarded – undo
125 125
 	public function has_generated_cap_restrictions(){
126 126
 		if( $this->_cap_restrictions_generated === false ){
127 127
 			return false;
128
-		}else{
128
+		} else{
129 129
 			return true;
130 130
 		}
131 131
 	}
@@ -153,7 +153,7 @@  discard block
 block discarded – undo
153 153
 		$caps_for_admin = EE_Registry::instance()->CAP->get_ee_capabilities( 'administrator' );
154 154
 		if( in_array( self::get_cap_name( $model, $action ), $caps_for_admin ) ) {
155 155
 			return true;
156
-		}else{
156
+		} else{
157 157
 			return false;
158 158
 		}
159 159
 	}
Please login to merge, or discard this patch.
strategies/EE_Restriction_Generator_Default_Protected.strategy.php 1 patch
Spacing   +22 added lines, -22 removed lines patch added patch discarded remove patch
@@ -1,7 +1,7 @@  discard block
 block discarded – undo
1 1
 <?php
2 2
 
3
-if ( !defined( 'EVENT_ESPRESSO_VERSION' ) ) {
4
-	exit( 'No direct script access allowed' );
3
+if ( ! defined('EVENT_ESPRESSO_VERSION')) {
4
+	exit('No direct script access allowed');
5 5
 }
6 6
 
7 7
 /**
@@ -40,9 +40,9 @@  discard block
 block discarded – undo
40 40
 	 * @param string $path_to_event_model The model chain to follow to get to the event model, including the event model itself.
41 41
 	 * Eg 'Ticket.Datetime.Event'
42 42
 	 */
43
-	public function __construct( $default_field_name, $path_to_event_model ) {
43
+	public function __construct($default_field_name, $path_to_event_model) {
44 44
 		$this->_default_field_name = $default_field_name;
45
-		if( substr( $path_to_event_model, -1, 1 ) != '.' ) {
45
+		if (substr($path_to_event_model, -1, 1) != '.') {
46 46
 			$path_to_event_model .= '.';
47 47
 		}
48 48
 		$this->_path_to_event_model = $path_to_event_model;
@@ -57,7 +57,7 @@  discard block
 block discarded – undo
57 57
 	protected function _generate_restrictions( ) {
58 58
 		//if there are no standard caps for this model, then for now all we know is
59 59
 		//if they need the default cap to access this
60
-		if ( ! $this->model()->cap_slug() ) {
60
+		if ( ! $this->model()->cap_slug()) {
61 61
 			return array(
62 62
 				self::get_default_restrictions_cap() => new EE_Return_None_Where_Conditions()
63 63
 			);
@@ -65,37 +65,37 @@  discard block
 block discarded – undo
65 65
 
66 66
 		$event_model = EEM_Event::instance();
67 67
 
68
-		$restrictions =  array(
68
+		$restrictions = array(
69 69
 			//first: basically access to non-defaults is essentially controlled by which events are accessible
70 70
 			//if they don't have the basic event cap, they can't access ANY non-default items
71
-			EE_Restriction_Generator_Base::get_cap_name($event_model, $this->action()) => new EE_Default_Where_Conditions( array( $this->_default_field_name => true ) ),
71
+			EE_Restriction_Generator_Base::get_cap_name($event_model, $this->action()) => new EE_Default_Where_Conditions(array($this->_default_field_name => true)),
72 72
 			//if they don't have the others event cap, they can't access others' non-default items
73
-			EE_Restriction_Generator_Base::get_cap_name($event_model, $this->action() . '_others' ) => new EE_Default_Where_Conditions( array(
74
-				'OR*no_' . EE_Restriction_Generator_Base::get_cap_name($event_model, $this->action() . '_others' ) => array(
75
-					$this->_path_to_event_model . 'EVT_wp_user' => EE_Default_Where_Conditions::current_user_placeholder ),
76
-					$this->_default_field_name => true ) ),
73
+			EE_Restriction_Generator_Base::get_cap_name($event_model, $this->action().'_others') => new EE_Default_Where_Conditions(array(
74
+				'OR*no_'.EE_Restriction_Generator_Base::get_cap_name($event_model, $this->action().'_others') => array(
75
+					$this->_path_to_event_model.'EVT_wp_user' => EE_Default_Where_Conditions::current_user_placeholder ),
76
+					$this->_default_field_name => true )),
77 77
 			//if they have basic and others, but not private, they can't access others' private non-default items
78
-			EE_Restriction_Generator_Base::get_cap_name($event_model, $this->action() . '_private' ) => new EE_Default_Where_Conditions(array(
79
-				'OR*no_' .EE_Restriction_Generator_Base::get_cap_name($event_model, $this->action() . '_private' ) => array(
80
-				$this->_path_to_event_model . 'EVT_wp_user' => EE_Default_Where_Conditions::current_user_placeholder,
81
-				$this->_path_to_event_model . 'status' => array( '!=', 'private' ),
82
-				$this->_default_field_name => true ) ) ),
78
+			EE_Restriction_Generator_Base::get_cap_name($event_model, $this->action().'_private') => new EE_Default_Where_Conditions(array(
79
+				'OR*no_'.EE_Restriction_Generator_Base::get_cap_name($event_model, $this->action().'_private') => array(
80
+				$this->_path_to_event_model.'EVT_wp_user' => EE_Default_Where_Conditions::current_user_placeholder,
81
+				$this->_path_to_event_model.'status' => array('!=', 'private'),
82
+				$this->_default_field_name => true ) )),
83 83
 			//second: access to defaults is controlled by the defaulty capabilities
84 84
 			//if they don't have the default capability, restrict access to only non-default items
85
-			EE_Restriction_Generator_Base::get_cap_name( $this->model(), $this->action() . '_default' )	=> new EE_Default_Where_Conditions( array( $this->_default_field_name => false ) ),
85
+			EE_Restriction_Generator_Base::get_cap_name($this->model(), $this->action().'_default')	=> new EE_Default_Where_Conditions(array($this->_default_field_name => false)),
86 86
 			//if they don't have the "others" default capability, restrict access to only their default ones, and non-default ones
87 87
 			 );
88
-		if( EE_Restriction_Generator_Base::is_cap(  $this->model(), $this->action() . '_others_default' ) ) {
89
-			$restrictions[ EE_Restriction_Generator_Base::get_cap_name( $this->model(), $this->action() . '_others_default' ) ] = new EE_Default_Where_Conditions( array(
88
+		if (EE_Restriction_Generator_Base::is_cap($this->model(), $this->action().'_others_default')) {
89
+			$restrictions[EE_Restriction_Generator_Base::get_cap_name($this->model(), $this->action().'_others_default')] = new EE_Default_Where_Conditions(array(
90 90
 					//if they don't have the others default cap, they can't access others default items (but they can access
91 91
 					//their own default items, and non-default items)
92
-					'OR*no_' . EE_Restriction_Generator_Base::get_cap_name( $this->model(), $this->action() . '_others_default' ) => array(
92
+					'OR*no_'.EE_Restriction_Generator_Base::get_cap_name($this->model(), $this->action().'_others_default') => array(
93 93
 						'AND' => array(
94
-							$this->_path_to_event_model . 'EVT_wp_user' => EE_Default_Where_Conditions::current_user_placeholder,
94
+							$this->_path_to_event_model.'EVT_wp_user' => EE_Default_Where_Conditions::current_user_placeholder,
95 95
 							$this->_default_field_name => true
96 96
 							),
97 97
 						$this->_default_field_name => false
98
-					) ) );
98
+					) ));
99 99
 		}
100 100
 		return $restrictions;
101 101
 
Please login to merge, or discard this patch.
db_models/strategies/EE_Restriction_Generator_Default_Public.strategy.php 2 patches
Indentation   +4 added lines, -4 removed lines patch added patch discarded remove patch
@@ -21,10 +21,10 @@
 block discarded – undo
21 21
  */
22 22
 class EE_Restriction_Generator_Default_Public extends EE_Restriction_Generator_Base {
23 23
 /**
24
-	 * Name of the field on this model (or a related model, including the model chain to it)
25
-	 * that is a boolean indicating whether or not a model object is considered "Default" or not
26
-	 * @var string
27
-	 */
24
+ * Name of the field on this model (or a related model, including the model chain to it)
25
+ * that is a boolean indicating whether or not a model object is considered "Default" or not
26
+ * @var string
27
+ */
28 28
 	protected $_default_field_name;
29 29
 
30 30
 	/**
Please login to merge, or discard this patch.
Spacing   +22 added lines, -22 removed lines patch added patch discarded remove patch
@@ -1,7 +1,7 @@  discard block
 block discarded – undo
1 1
 <?php
2 2
 
3
-if ( !defined( 'EVENT_ESPRESSO_VERSION' ) ) {
4
-	exit( 'No direct script access allowed' );
3
+if ( ! defined('EVENT_ESPRESSO_VERSION')) {
4
+	exit('No direct script access allowed');
5 5
 }
6 6
 
7 7
 /**
@@ -40,9 +40,9 @@  discard block
 block discarded – undo
40 40
 	 * @param string $path_to_event_model The model chain to follow to get to the event model, including the event model itself.
41 41
 	 * Eg 'Ticket.Datetime.Event'
42 42
 	 */
43
-	public function __construct( $default_field_name, $path_to_event_model ) {
43
+	public function __construct($default_field_name, $path_to_event_model) {
44 44
 		$this->_default_field_name = $default_field_name;
45
-		if( substr( $path_to_event_model, -1, 1 ) != '.' ) {
45
+		if (substr($path_to_event_model, -1, 1) != '.') {
46 46
 			$path_to_event_model .= '.';
47 47
 		}
48 48
 		$this->_path_to_event_model = $path_to_event_model;
@@ -55,7 +55,7 @@  discard block
 block discarded – undo
55 55
 	protected function _generate_restrictions() {
56 56
 		//if there are no standard caps for this model, then for now all we know
57 57
 		//if they need the default cap to access this
58
-		if ( !$this->model()->cap_slug() ) {
58
+		if ( ! $this->model()->cap_slug()) {
59 59
 			return array(
60 60
 				self::get_default_restrictions_cap() => new EE_Return_None_Where_Conditions()
61 61
 			);
@@ -66,45 +66,45 @@  discard block
 block discarded – undo
66 66
 		$restrictions = array(
67 67
 			//first: basically access to non-defaults is essentially controlled by which events are accessible
68 68
 			//if they don't have the basic event cap, they can't access ANY non-default items
69
-			EE_Restriction_Generator_Base::get_cap_name( $event_model, $this->action() ) => new EE_Default_Where_Conditions( array(
70
-				'OR*no_' . EE_Restriction_Generator_Base::get_cap_name( $event_model, $this->action() ) => array(
69
+			EE_Restriction_Generator_Base::get_cap_name($event_model, $this->action()) => new EE_Default_Where_Conditions(array(
70
+				'OR*no_'.EE_Restriction_Generator_Base::get_cap_name($event_model, $this->action()) => array(
71 71
 					$this->_default_field_name             => true,
72
-					$this->_path_to_event_model . 'status' => 'publish'
72
+					$this->_path_to_event_model.'status' => 'publish'
73 73
 				)
74
-			) ),
74
+			)),
75 75
 			//if they don't have the others event cap, they can only access their own, others' that are for published events, or defaults
76
-			EE_Restriction_Generator_Base::get_cap_name( $event_model, $this->action() . '_others' ) => new EE_Default_Where_Conditions(
76
+			EE_Restriction_Generator_Base::get_cap_name($event_model, $this->action().'_others') => new EE_Default_Where_Conditions(
77 77
 				array(
78
-					'OR*no_' . EE_Restriction_Generator_Base::get_cap_name( $event_model, $this->action() . '_others' ) => array(
79
-						$this->_path_to_event_model . 'EVT_wp_user' => EE_Default_Where_Conditions::current_user_placeholder,
78
+					'OR*no_'.EE_Restriction_Generator_Base::get_cap_name($event_model, $this->action().'_others') => array(
79
+						$this->_path_to_event_model.'EVT_wp_user' => EE_Default_Where_Conditions::current_user_placeholder,
80 80
 						$this->_default_field_name => true,
81
-						$this->_path_to_event_model . 'status' => 'publish'
81
+						$this->_path_to_event_model.'status' => 'publish'
82 82
 					)
83 83
 				)
84 84
 			),
85 85
 			//if they have basic and others, but not private, they can access default, their own, and others' that aren't private
86
-			EE_Restriction_Generator_Base::get_cap_name( $event_model, $this->action() . '_private' )   => new EE_Default_Where_Conditions(
86
+			EE_Restriction_Generator_Base::get_cap_name($event_model, $this->action().'_private')   => new EE_Default_Where_Conditions(
87 87
 				array(
88
-					'OR*no_' . EE_Restriction_Generator_Base::get_cap_name( $event_model, $this->action() . '_private' ) => array(
89
-						$this->_path_to_event_model . 'EVT_wp_user' => EE_Default_Where_Conditions::current_user_placeholder,
90
-						$this->_path_to_event_model . 'status' => array( '!=', 'private' ),
88
+					'OR*no_'.EE_Restriction_Generator_Base::get_cap_name($event_model, $this->action().'_private') => array(
89
+						$this->_path_to_event_model.'EVT_wp_user' => EE_Default_Where_Conditions::current_user_placeholder,
90
+						$this->_path_to_event_model.'status' => array('!=', 'private'),
91 91
 						$this->_default_field_name => true
92 92
 					)
93 93
 				)
94 94
 			),
95 95
 			//second: access to defaults is controlled by the default capabilities
96 96
 			//if they don't have the basic default capability, restrict access to only non-default items
97
-			EE_Restriction_Generator_Base::get_cap_name( $this->model(), $this->action() . '_default' ) => new EE_Default_Where_Conditions(
98
-				array( $this->_default_field_name => false )
97
+			EE_Restriction_Generator_Base::get_cap_name($this->model(), $this->action().'_default') => new EE_Default_Where_Conditions(
98
+				array($this->_default_field_name => false)
99 99
 			),
100 100
 		);
101
-		if ( EE_Restriction_Generator_Base::is_cap( $this->model(), $this->action() . '_others_default' ) ) {
101
+		if (EE_Restriction_Generator_Base::is_cap($this->model(), $this->action().'_others_default')) {
102 102
 			//if they don't have the "others" default capability, restrict access to only their default ones, and non-default ones
103
-			$restrictions[ EE_Restriction_Generator_Base::get_cap_name( $this->model(), $this->action() . '_others_default' ) ] = new EE_Default_Where_Conditions(
103
+			$restrictions[EE_Restriction_Generator_Base::get_cap_name($this->model(), $this->action().'_others_default')] = new EE_Default_Where_Conditions(
104 104
 				array(
105 105
 					//if they don't have the others default cap, they can't access others default items (but they can access
106 106
 					//their own default items, and non-default items)
107
-					'OR*no_' . EE_Restriction_Generator_Base::get_cap_name( $this->model(), $this->action() . '_others_default' ) => array(
107
+					'OR*no_'.EE_Restriction_Generator_Base::get_cap_name($this->model(), $this->action().'_others_default') => array(
108 108
 						'AND' => array(
109 109
 							EE_Default_Where_Conditions::user_field_name_placeholder => EE_Default_Where_Conditions::current_user_placeholder,
110 110
 							$this->_default_field_name => true
Please login to merge, or discard this patch.