Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.
Common duplication problems, and corresponding solutions are:
Complex classes like Registry often do a lot of different things. To break such a class down, we need to identify a cohesive component within that class. A common approach to find such a component is to look for fields/methods that share the same prefixes, or suffixes. You can also have a look at the cohesion graph to spot any un-connected, or weakly-connected components.
Once you have determined the fields that belong together, you can apply the Extract Class refactoring. If the component makes sense as a sub-class, Extract Subclass is also a candidate, and is often faster.
While breaking up the class, it is a good idea to analyze how other classes use Registry, and based on these observations, apply Extract Interface, too.
| 1 | <?php |
||
| 23 | class Registry |
||
| 24 | { |
||
| 25 | |||
| 26 | const FILE_NAME_BUILD_MANIFEST = 'build-manifest.json'; |
||
| 27 | |||
| 28 | /** |
||
| 29 | * @var AssetCollection $assets |
||
| 30 | */ |
||
| 31 | protected $assets; |
||
| 32 | |||
| 33 | /** |
||
| 34 | * @var I18nRegistry |
||
| 35 | */ |
||
| 36 | private $i18n_registry; |
||
| 37 | |||
| 38 | /** |
||
| 39 | * This holds the jsdata data object that will be exposed on pages that enqueue the `eejs-core` script. |
||
| 40 | * |
||
| 41 | * @var array |
||
| 42 | */ |
||
| 43 | protected $jsdata = array(); |
||
| 44 | |||
| 45 | /** |
||
| 46 | * This keeps track of all scripts with registered data. It is used to prevent duplicate data objects setup in the |
||
| 47 | * page source. |
||
| 48 | * |
||
| 49 | * @var array |
||
| 50 | */ |
||
| 51 | private $script_handles_with_data = array(); |
||
| 52 | |||
| 53 | |||
| 54 | /** |
||
| 55 | * Holds the manifest data obtained from registered manifest files. |
||
| 56 | * Manifests are maps of asset chunk name to actual built asset file names. |
||
| 57 | * Shape of this array is: |
||
| 58 | * array( |
||
| 59 | * 'some_namespace_slug' => array( |
||
| 60 | * 'some_chunk_name' => array( |
||
| 61 | * 'js' => 'filename.js' |
||
| 62 | * 'css' => 'filename.js' |
||
| 63 | * ), |
||
| 64 | * 'url_base' => 'https://baseurl.com/to/assets |
||
| 65 | * ) |
||
| 66 | * ) |
||
| 67 | * |
||
| 68 | * @var array |
||
| 69 | */ |
||
| 70 | private $manifest_data = array(); |
||
| 71 | |||
| 72 | |||
| 73 | /** |
||
| 74 | * Registry constructor. |
||
| 75 | * Hooking into WP actions for script registry. |
||
| 76 | * |
||
| 77 | * @param AssetCollection $assets |
||
| 78 | * @param I18nRegistry $i18n_registry |
||
| 79 | */ |
||
| 80 | public function __construct(AssetCollection $assets, I18nRegistry $i18n_registry) |
||
| 93 | |||
| 94 | |||
| 95 | /** |
||
| 96 | * For classes that have Registry as a dependency, this provides a handy way to register script handles for i18n |
||
| 97 | * translation handling. |
||
| 98 | * |
||
| 99 | * @return I18nRegistry |
||
| 100 | */ |
||
| 101 | public function getI18nRegistry() |
||
| 105 | |||
| 106 | |||
| 107 | /** |
||
| 108 | * Callback for the wp_enqueue_scripts actions used to register assets. |
||
| 109 | * |
||
| 110 | * @since 4.9.62.p |
||
| 111 | * @throws Exception |
||
| 112 | */ |
||
| 113 | public function registerScriptsAndStyles() |
||
| 122 | |||
| 123 | |||
| 124 | /** |
||
| 125 | * Registers JS assets with WP core |
||
| 126 | * |
||
| 127 | * @since 4.9.62.p |
||
| 128 | * @param JavascriptAsset[] $scripts |
||
| 129 | * @throws AssetRegistrationException |
||
| 130 | * @throws InvalidDataTypeException |
||
| 131 | */ |
||
| 132 | public function registerScripts(array $scripts) |
||
| 133 | { |
||
| 134 | foreach ($scripts as $script) { |
||
| 135 | // skip to next script if this has already been done |
||
| 136 | if ($script->isRegistered()) { |
||
| 137 | continue; |
||
| 138 | } |
||
| 139 | do_action( |
||
| 140 | 'AHEE__EventEspresso_core_services_assets_Registry__registerScripts__before_script', |
||
| 141 | $script |
||
| 142 | ); |
||
| 143 | $registered = wp_register_script( |
||
| 144 | $script->handle(), |
||
| 145 | $script->source(), |
||
| 146 | $script->dependencies(), |
||
| 147 | $script->version(), |
||
| 148 | $script->loadInFooter() |
||
| 149 | ); |
||
| 150 | if (! $registered && $this->debug()) { |
||
| 151 | throw new AssetRegistrationException($script->handle()); |
||
| 152 | } |
||
| 153 | $script->setRegistered($registered); |
||
| 154 | if ($script->requiresTranslation()) { |
||
| 155 | $this->registerTranslation($script->handle()); |
||
| 156 | } |
||
| 157 | do_action( |
||
| 158 | 'AHEE__EventEspresso_core_services_assets_Registry__registerScripts__after_script', |
||
| 159 | $script |
||
| 160 | ); |
||
| 161 | } |
||
| 162 | } |
||
| 163 | |||
| 164 | |||
| 165 | /** |
||
| 166 | * Registers CSS assets with WP core |
||
| 167 | * |
||
| 168 | * @since 4.9.62.p |
||
| 169 | * @param StylesheetAsset[] $styles |
||
| 170 | * @throws InvalidDataTypeException |
||
| 171 | */ |
||
| 172 | public function registerStyles(array $styles) |
||
| 197 | |||
| 198 | |||
| 199 | /** |
||
| 200 | * Call back for the script print in frontend and backend. |
||
| 201 | * Used to call wp_localize_scripts so that data can be added throughout the runtime until this later hook point. |
||
| 202 | * |
||
| 203 | * @since 4.9.31.rc.015 |
||
| 204 | */ |
||
| 205 | public function enqueueData() |
||
| 222 | |||
| 223 | |||
| 224 | /** |
||
| 225 | * Used to add data to eejs.data object. |
||
| 226 | * Note: Overriding existing data is not allowed. |
||
| 227 | * Data will be accessible as a javascript object when you list `eejs-core` as a dependency for your javascript. |
||
| 228 | * If the data you add is something like this: |
||
| 229 | * $this->addData( 'my_plugin_data', array( 'foo' => 'gar' ) ); |
||
| 230 | * It will be exposed in the page source as: |
||
| 231 | * eejs.data.my_plugin_data.foo == gar |
||
| 232 | * |
||
| 233 | * @param string $key Key used to access your data |
||
| 234 | * @param string|array $value Value to attach to key |
||
| 235 | * @throws InvalidArgumentException |
||
| 236 | */ |
||
| 237 | public function addData($key, $value) |
||
| 243 | |||
| 244 | |||
| 245 | /** |
||
| 246 | * Similar to addData except this allows for users to push values to an existing key where the values on key are |
||
| 247 | * elements in an array. |
||
| 248 | * |
||
| 249 | * When you use this method, the value you include will be merged with the array on $key. |
||
| 250 | * So if the $key was 'test' and you added a value of ['my_data'] then it would be represented in the javascript |
||
| 251 | * object like this, eejs.data.test = [ my_data, |
||
| 252 | * ] |
||
| 253 | * If there has already been a scalar value attached to the data object given key (via addData for instance), then |
||
| 254 | * this will throw an exception. |
||
| 255 | * |
||
| 256 | * Caution: Only add data using this method if you are okay with the potential for additional data added on the same |
||
| 257 | * key potentially overriding the existing data on merge (specifically with associative arrays). |
||
| 258 | * |
||
| 259 | * @param string $key Key to attach data to. |
||
| 260 | * @param string|array $value Value being registered. |
||
| 261 | * @throws InvalidArgumentException |
||
| 262 | */ |
||
| 263 | public function pushData($key, $value) |
||
| 289 | |||
| 290 | |||
| 291 | /** |
||
| 292 | * Used to set content used by javascript for a template. |
||
| 293 | * Note: Overrides of existing registered templates are not allowed. |
||
| 294 | * |
||
| 295 | * @param string $template_reference |
||
| 296 | * @param string $template_content |
||
| 297 | * @throws InvalidArgumentException |
||
| 298 | */ |
||
| 299 | public function addTemplate($template_reference, $template_content) |
||
| 321 | |||
| 322 | |||
| 323 | /** |
||
| 324 | * Retrieve the template content already registered for the given reference. |
||
| 325 | * |
||
| 326 | * @param string $template_reference |
||
| 327 | * @return string |
||
| 328 | */ |
||
| 329 | public function getTemplate($template_reference) |
||
| 335 | |||
| 336 | |||
| 337 | /** |
||
| 338 | * Retrieve registered data. |
||
| 339 | * |
||
| 340 | * @param string $key Name of key to attach data to. |
||
| 341 | * @return mixed If there is no for the given key, then false is returned. |
||
| 342 | */ |
||
| 343 | public function getData($key) |
||
| 349 | |||
| 350 | |||
| 351 | /** |
||
| 352 | * Verifies whether the given data exists already on the jsdata array. |
||
| 353 | * Overriding data is not allowed. |
||
| 354 | * |
||
| 355 | * @param string $key Index for data. |
||
| 356 | * @return bool If valid then return true. |
||
| 357 | * @throws InvalidArgumentException if data already exists. |
||
| 358 | */ |
||
| 359 | protected function verifyDataNotExisting($key) |
||
| 392 | |||
| 393 | |||
| 394 | /** |
||
| 395 | * Get the actual asset path for asset manifests. |
||
| 396 | * If there is no asset path found for the given $chunk_name, then the $chunk_name is returned. |
||
| 397 | * |
||
| 398 | * @param string $namespace The namespace associated with the manifest file hosting the map of chunk_name to actual |
||
| 399 | * asset file location. |
||
| 400 | * @param string $chunk_name |
||
| 401 | * @param string $asset_type |
||
| 402 | * @return string |
||
| 403 | * @since 4.9.59.p |
||
| 404 | */ |
||
| 405 | public function getAssetUrl($namespace, $chunk_name, $asset_type) |
||
| 422 | |||
| 423 | |||
| 424 | |||
| 425 | /** |
||
| 426 | * Return the url to a js file for the given namespace and chunk name. |
||
| 427 | * |
||
| 428 | * @param string $namespace |
||
| 429 | * @param string $chunk_name |
||
| 430 | * @return string |
||
| 431 | */ |
||
| 432 | public function getJsUrl($namespace, $chunk_name) |
||
| 436 | |||
| 437 | |||
| 438 | /** |
||
| 439 | * Return the url to a css file for the given namespace and chunk name. |
||
| 440 | * |
||
| 441 | * @param string $namespace |
||
| 442 | * @param string $chunk_name |
||
| 443 | * @return string |
||
| 444 | */ |
||
| 445 | public function getCssUrl($namespace, $chunk_name) |
||
| 449 | |||
| 450 | |||
| 451 | /** |
||
| 452 | * @since 4.9.62.p |
||
| 453 | * @throws InvalidArgumentException |
||
| 454 | * @throws InvalidFilePathException |
||
| 455 | */ |
||
| 456 | public function registerManifestFiles() |
||
| 467 | |||
| 468 | |||
| 469 | /** |
||
| 470 | * Used to register a js/css manifest file with the registered_manifest_files property. |
||
| 471 | * |
||
| 472 | * @param string $namespace Provided to associate the manifest file with a specific namespace. |
||
| 473 | * @param string $url_base The url base for the manifest file location. |
||
| 474 | * @param string $manifest_file The absolute path to the manifest file. |
||
| 475 | * @throws InvalidArgumentException |
||
| 476 | * @throws InvalidFilePathException |
||
| 477 | * @since 4.9.59.p |
||
| 478 | */ |
||
| 479 | public function registerManifestFile($namespace, $url_base, $manifest_file) |
||
| 520 | |||
| 521 | |||
| 522 | /** |
||
| 523 | * Decodes json from the provided manifest file. |
||
| 524 | * |
||
| 525 | * @since 4.9.59.p |
||
| 526 | * @param string $manifest_file Path to manifest file. |
||
| 527 | * @return array |
||
| 528 | * @throws InvalidFilePathException |
||
| 529 | */ |
||
| 530 | private function decodeManifestFile($manifest_file) |
||
| 537 | |||
| 538 | |||
| 539 | /** |
||
| 540 | * This is used to set registered script handles that have data. |
||
| 541 | * |
||
| 542 | * @param string $script_handle |
||
| 543 | */ |
||
| 544 | private function addRegisteredScriptHandlesWithData($script_handle) |
||
| 548 | |||
| 549 | |||
| 550 | /**i |
||
| 551 | * Checks WP_Scripts for all of each script handle registered internally as having data and unsets from the |
||
| 552 | * Dependency stored in WP_Scripts if its set. |
||
| 553 | */ |
||
| 554 | private function removeAlreadyRegisteredDataForScriptHandles() |
||
| 563 | |||
| 564 | |||
| 565 | /** |
||
| 566 | * Removes any data dependency registered in WP_Scripts if its set. |
||
| 567 | * |
||
| 568 | * @param string $script_handle |
||
| 569 | */ |
||
| 570 | private function removeAlreadyRegisteredDataForScriptHandle($script_handle) |
||
| 592 | |||
| 593 | |||
| 594 | /** |
||
| 595 | * register translations for a registered script |
||
| 596 | * |
||
| 597 | * @param string $handle |
||
| 598 | */ |
||
| 599 | public function registerTranslation($handle) |
||
| 603 | |||
| 604 | |||
| 605 | /** |
||
| 606 | * @since 4.9.63.p |
||
| 607 | * @return bool |
||
| 608 | */ |
||
| 609 | private function debug() |
||
| 616 | } |
||
| 617 |