MessagesAdmin - Code Metrics - Inspection of "Daily Inspection: trim backslashes from class name..." - eventespresso/event-espresso-core - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Branch — FET-3467-waitlists (78124b)

unknown

created 2017-05-18 21:00 UTC

MessagesAdmin A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	51
Duplicated Lines	0 %

Coupling/Cohesion

Components	0
Dependencies	1

Importance

Changes	2
Bugs	0	Features	1

Metric	Value
c	2
b	0
f	1
dl	0
loc	51
rs	10
wmc	5
lcom	0
cbo	1

5 Methods

Rating	Name	Size	Complexity
A	amOnMessagesActivityListTablePage()	4	1
A	amOnDefaultMessageTemplateListTablePage()	4	1
A	amOnCustomMessageTemplateListTablePage()	4	1
A	amOnMessageSettingsPage()	4	1
A	clickToEditMessageTemplateByMessageType()	4	1

<?php
namespace EventEspresso\Codeception\helpers;

use Page\MessagesAdmin as MessagesPage;

/**
 * Trait MessagesAdmin
 * Helper actions for the Messages Admin Pages
 * @package EventEspresso\Codeception\helpers
 */
trait MessagesAdmin
{
    /**
     * @param string $additional_params Any additional request parameters for the generated url should be included as
     *                                  a string.
     */
    public function amOnMessagesActivityListTablePage($additional_params = '')
    {
        $this->actor()->amOnAdminPage(MessagesPage::messageActivityListTableUrl($additional_params));
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
    }

    /**
     * @param string $additional_params Any additional request parameters for the generated url should be included as
     *                                  a string.
     */
    public function amOnDefaultMessageTemplateListTablePage($additional_params = '')
    {
        $this->actor()->amOnAdminPage(MessagesPage::defaultMessageTemplateListTableUrl($additional_params));
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
    }


    /**
     * @param string $additional_params Any additional request parameters for the generated url should be included as
     *                                  a string.
     */
    public function amOnCustomMessageTemplateListTablePage($additional_params = '')
    {
        $this->actor()->amOnAdminPage(MessagesPage::customMessageTemplateListTableUrl($additional_params));
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
    }


    /**
     * Directs to message settings page
     */
    public function amOnMessageSettingsPage()
    {
        $this->actor()->amOnAdminPage(MessagesPage::messageSettingsUrl());
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
    }


    /**
     * Assumes you are already on the list table page that has the ui for editing the template.
     * @param string $message_type_slug
     * @param string $context [optional] if you want to click directly to the given context in the editor
     */
    public function clickToEditMessageTemplateByMessageType($message_type_slug, $context = '')
    {
        $this->actor()->click(MessagesPage::editMessageTemplateClassByMessageType($message_type_slug, $context));
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
    }

}

1			<?php
2			namespace EventEspresso\Codeception\helpers;
3
4			use Page\MessagesAdmin as MessagesPage;
5
6			/**
7			* Trait MessagesAdmin
8			* Helper actions for the Messages Admin Pages
9			* @package EventEspresso\Codeception\helpers
10			*/
11			trait MessagesAdmin
12			{
13			/**
14			* @param string $additional_params Any additional request parameters for the generated url should be included as
15			* a string.
16			*/
17			public function amOnMessagesActivityListTablePage($additional_params = '')
18			{
19			$this->actor()->amOnAdminPage(MessagesPage::messageActivityListTableUrl($additional_params));
			0 ignored issues – show Bug introduced 2017-05-15 22:28 UTC by Report Bug Copy Issue Report It seems like `actor()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
20			}
21
22			/**
23			* @param string $additional_params Any additional request parameters for the generated url should be included as
24			* a string.
25			*/
26			public function amOnDefaultMessageTemplateListTablePage($additional_params = '')
27			{
28			$this->actor()->amOnAdminPage(MessagesPage::defaultMessageTemplateListTableUrl($additional_params));
			0 ignored issues – show Bug introduced 2017-05-15 22:28 UTC by Report Bug Copy Issue Report It seems like `actor()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
29			}
30
31
32			/**
33			* @param string $additional_params Any additional request parameters for the generated url should be included as
34			* a string.
35			*/
36			public function amOnCustomMessageTemplateListTablePage($additional_params = '')
37			{
38			$this->actor()->amOnAdminPage(MessagesPage::customMessageTemplateListTableUrl($additional_params));
			0 ignored issues – show Bug introduced 2017-05-15 22:28 UTC by Report Bug Copy Issue Report It seems like `actor()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
39			}
40
41
42			/**
43			* Directs to message settings page
44			*/
45			public function amOnMessageSettingsPage()
46			{
47			$this->actor()->amOnAdminPage(MessagesPage::messageSettingsUrl());
			0 ignored issues – show Bug introduced 2017-05-15 22:28 UTC by Report Bug Copy Issue Report It seems like `actor()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
48			}
49
50
51			/**
52			* Assumes you are already on the list table page that has the ui for editing the template.
53			* @param string $message_type_slug
54			* @param string $context [optional] if you want to click directly to the given context in the editor
55			*/
56			public function clickToEditMessageTemplateByMessageType($message_type_slug, $context = '')
57			{
58			$this->actor()->click(MessagesPage::editMessageTemplateClassByMessageType($message_type_slug, $context));
			0 ignored issues – show Bug introduced 2017-05-15 22:28 UTC by Report Bug Copy Issue Report It seems like `actor()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
59			}
60
61			}

eventespresso / event-espresso-core

Branch — FET-3467-waitlists (78124b)

MessagesAdmin A

Complexity

Size/Duplication

Coupling/Cohesion

Importance

5 Methods

Duplication Side-by-Side

Filter issues like