eventespresso /
event-espresso-core
Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.
Common duplication problems, and corresponding solutions are:
Complex classes like PostShortcodeTracking often do a lot of different things. To break such a class down, we need to identify a cohesive component within that class. A common approach to find such a component is to look for fields/methods that share the same prefixes, or suffixes. You can also have a look at the cohesion graph to spot any un-connected, or weakly-connected components.
Once you have determined the fields that belong together, you can apply the Extract Class refactoring. If the component makes sense as a sub-class, Extract Subclass is also a candidate, and is often faster.
While breaking up the class, it is a good idea to analyze how other classes use PostShortcodeTracking, and based on these observations, apply Extract Interface, too.
| 1 | <?php |
||
| 21 | class PostShortcodeTracking { |
||
| 22 | |||
| 23 | /** |
||
| 24 | * set_hooks_admin |
||
| 25 | * |
||
| 26 | * @access public |
||
| 27 | */ |
||
| 28 | public static function set_hooks_admin() { |
||
| 60 | |||
| 61 | |||
| 62 | |||
| 63 | /** |
||
| 64 | * parse_post_content_on_save |
||
| 65 | * |
||
| 66 | * any time a post is saved, we need to check for any EE shortcodes that may be embedded in the content, |
||
| 67 | * and then track what posts those shortcodes are on, so that we can initialize shortcodes well before the_content() runs. |
||
| 68 | * this allows us to do things like enqueue scripts for shortcodes ONLY on the pages the shortcodes are actually used on |
||
| 69 | * |
||
| 70 | * @access public |
||
| 71 | * @param int $post_ID |
||
| 72 | * @param \WP_Post $post |
||
| 73 | * @return void |
||
| 74 | */ |
||
| 75 | public static function parse_post_content_on_save( $post_ID, $post ) { |
||
| 76 | // if the post is trashed, then let's remove our post shortcode tracking |
||
| 77 | if ( $post instanceof \WP_Post && $post->post_status == 'trash' ) { |
||
|
|
|||
| 78 | PostShortcodeTracking::unset_post_shortcodes_on_delete( $post_ID ); |
||
| 79 | return; |
||
| 80 | } |
||
| 81 | // default post types |
||
| 82 | $post_types = array( 'post' => 0, 'page' => 1 ); |
||
| 83 | // add CPTs |
||
| 84 | $CPTs = \EE_Register_CPTs::get_CPTs(); |
||
| 85 | $post_types = array_merge( $post_types, $CPTs ); |
||
| 86 | // for default or CPT posts... |
||
| 87 | if ( isset( $post_types[ $post->post_type ] ) ) { |
||
| 88 | // post on frontpage ? |
||
| 89 | $page_for_posts = \EE_Config::get_page_for_posts(); |
||
| 90 | if ( $post->post_name == $page_for_posts ) { |
||
| 91 | PostShortcodeTracking::set_post_shortcodes_for_posts_page( $page_for_posts ); |
||
| 92 | return; |
||
| 93 | } |
||
| 94 | // array of shortcodes indexed by post name |
||
| 95 | \EE_Registry::CFG()->core->post_shortcodes = isset( \EE_Registry::CFG()->core->post_shortcodes ) |
||
| 96 | ? \EE_Registry::CFG()->core->post_shortcodes |
||
| 97 | : array(); |
||
| 98 | // whether to proceed with update |
||
| 99 | $update_post_shortcodes = false; |
||
| 100 | // empty both arrays |
||
| 101 | \EE_Registry::CFG()->core->post_shortcodes[ $post->post_name ] = array(); |
||
| 102 | // check that posts page is already being tracked |
||
| 103 | if ( ! isset( \EE_Registry::CFG()->core->post_shortcodes[ $page_for_posts ] ) ) { |
||
| 104 | // if not, then ensure that it is properly added |
||
| 105 | \EE_Registry::CFG()->core->post_shortcodes[ $page_for_posts ] = array(); |
||
| 106 | } |
||
| 107 | // loop thru shortcodes |
||
| 108 | foreach ( \EE_Registry::instance()->shortcodes as $EES_Shortcode => $shortcode_dir ) { |
||
| 109 | // convert to UPPERCASE to get actual shortcode |
||
| 110 | $EES_Shortcode = strtoupper( $EES_Shortcode ); |
||
| 111 | // is the shortcode in the post_content ? |
||
| 112 | if ( strpos( $post->post_content, $EES_Shortcode ) !== false ) { |
||
| 113 | // map shortcode to post names and post IDs |
||
| 114 | \EE_Registry::CFG()->core->post_shortcodes[ $post->post_name ][ $EES_Shortcode ] = $post_ID; |
||
| 115 | // and add this shortcode to the tracking for the blog page |
||
| 116 | PostShortcodeTracking::set_post_shortcode_for_posts_page( $page_for_posts, $EES_Shortcode, $post_ID ); |
||
| 117 | $update_post_shortcodes = true; |
||
| 118 | } else { |
||
| 119 | // shortcode is not present in post content, so check if we were tracking it previously |
||
| 120 | // stop tracking if shortcode is not used in this specific post |
||
| 121 | if ( isset( \EE_Registry::CFG()->core->post_shortcodes[ $post->post_name ][ $EES_Shortcode ] ) ) { |
||
| 122 | unset( \EE_Registry::CFG()->core->post_shortcodes[ $post->post_name ][ $EES_Shortcode ] ); |
||
| 123 | $update_post_shortcodes = true; |
||
| 124 | } |
||
| 125 | // make sure that something is set for the shortcode posts (even though we may remove this) |
||
| 126 | $shortcode_posts = isset( |
||
| 127 | \EE_Registry::CFG()->core->post_shortcodes[ $page_for_posts ][ $EES_Shortcode ] |
||
| 128 | ) |
||
| 129 | ? \EE_Registry::CFG()->core->post_shortcodes[ $page_for_posts ][ $EES_Shortcode ] |
||
| 130 | : array(); |
||
| 131 | // and stop tracking for this shortcode on the blog page if it is not used |
||
| 132 | $update_post_shortcodes = PostShortcodeTracking::unset_posts_page_shortcode_for_post( |
||
| 133 | $post_ID, |
||
| 134 | $EES_Shortcode, |
||
| 135 | $shortcode_posts, |
||
| 136 | $page_for_posts, |
||
| 137 | $update_post_shortcodes |
||
| 138 | ) |
||
| 139 | ? true |
||
| 140 | : $update_post_shortcodes; |
||
| 141 | } |
||
| 142 | } |
||
| 143 | if ( $update_post_shortcodes ) { |
||
| 144 | PostShortcodeTracking::update_post_shortcodes( $page_for_posts ); |
||
| 145 | } |
||
| 146 | } |
||
| 147 | } |
||
| 148 | |||
| 149 | |||
| 150 | |||
| 151 | /** |
||
| 152 | * set_post_shortcodes_for_posts_page (plz note: shortcodes is plural) |
||
| 153 | * |
||
| 154 | * called when updating the WordPress Posts Page, |
||
| 155 | * and adds shortcode tracking for the Posts Page, for all shortcodes currently tracked on individual posts |
||
| 156 | * |
||
| 157 | * @access protected |
||
| 158 | * @param string $page_for_posts |
||
| 159 | * @return void |
||
| 160 | */ |
||
| 161 | protected static function set_post_shortcodes_for_posts_page( $page_for_posts ) { |
||
| 171 | |||
| 172 | |||
| 173 | |||
| 174 | /** |
||
| 175 | * set_post_shortcode_for_posts_page (plz note: shortcode is singular) |
||
| 176 | * |
||
| 177 | * adds Posts Page shortcode tracking for the supplied shortcode for an individual post |
||
| 178 | * |
||
| 179 | * @access protected |
||
| 180 | * @param string $page_for_posts |
||
| 181 | * @param $EES_Shortcode |
||
| 182 | * @param $post_ID |
||
| 183 | */ |
||
| 184 | protected static function set_post_shortcode_for_posts_page( $page_for_posts, $EES_Shortcode, $post_ID ) { |
||
| 205 | |||
| 206 | |||
| 207 | |||
| 208 | /** |
||
| 209 | * unset_post_shortcodes_on_delete |
||
| 210 | * |
||
| 211 | * @access protected |
||
| 212 | * @param int $ID |
||
| 213 | * @return void |
||
| 214 | */ |
||
| 215 | protected static function unset_post_shortcodes_on_delete( $ID ) { |
||
| 250 | |||
| 251 | |||
| 252 | |||
| 253 | /** |
||
| 254 | * unset_post_shortcodes_on_delete |
||
| 255 | * |
||
| 256 | * @access protected |
||
| 257 | * @param int $ID |
||
| 258 | * @param $shortcode_class |
||
| 259 | * @param $shortcode_posts |
||
| 260 | * @param $page_for_posts |
||
| 261 | * @param bool $update_post_shortcodes |
||
| 262 | * @return bool |
||
| 263 | */ |
||
| 264 | protected static function unset_posts_page_shortcode_for_post( |
||
| 290 | |||
| 291 | |||
| 292 | |||
| 293 | /** |
||
| 294 | * update_post_shortcodes |
||
| 295 | * |
||
| 296 | * @access public |
||
| 297 | * @param $page_for_posts |
||
| 298 | * @return void |
||
| 299 | */ |
||
| 300 | public static function update_post_shortcodes( $page_for_posts = '' ) { |
||
| 363 | |||
| 364 | |||
| 365 | |||
| 366 | /** |
||
| 367 | * reset_page_for_posts_on_initial_set |
||
| 368 | * |
||
| 369 | * if an admin is on the WP Reading Settings page and sets the option for "Posts page", |
||
| 370 | * when it had previously been unset, |
||
| 371 | * then we need to attribute any actively used shortcodes to the new blog page |
||
| 372 | * |
||
| 373 | * @access public |
||
| 374 | * @param string $option |
||
| 375 | * @param string $value |
||
| 376 | * @return void |
||
| 377 | */ |
||
| 378 | public static function reset_page_for_posts_on_initial_set( $option, $value ) { |
||
| 381 | |||
| 382 | |||
| 383 | |||
| 384 | /** |
||
| 385 | * reset_page_for_posts_on_change |
||
| 386 | * |
||
| 387 | * if an admin is on the WP Reading Settings page and changes the option for "Posts page", |
||
| 388 | * then we need to attribute any actively used shortcodes for the previous blog page to the new blog page |
||
| 389 | * |
||
| 390 | * @access public |
||
| 391 | * @param string $option |
||
| 392 | * @param string $old_value |
||
| 393 | * @param string $value |
||
| 394 | * @return void |
||
| 395 | */ |
||
| 396 | public static function reset_page_for_posts_on_change( $option, $old_value = '', $value = '' ) { |
||
| 397 | View Code Duplication | if ( $option == 'page_for_posts' ) { |
|
| 398 | global $wpdb; |
||
| 399 | $table = $wpdb->posts; |
||
| 400 | $SQL = "SELECT post_name from $table WHERE post_type='posts' OR post_type='page' AND post_status='publish' AND ID=%d"; |
||
| 401 | $new_page_for_posts = $value ? $wpdb->get_var( $wpdb->prepare( $SQL, $value ) ) : 'posts'; |
||
| 402 | PostShortcodeTracking::set_post_shortcodes_for_posts_page( $new_page_for_posts ); |
||
| 403 | } |
||
| 404 | } |
||
| 405 | |||
| 406 | |||
| 407 | |||
| 408 | /** |
||
| 409 | * reset_page_for_posts_on_delete |
||
| 410 | * |
||
| 411 | * if an admin deletes a page designated as the WP "Posts page", |
||
| 412 | * then we need to attribute any actively used shortcodes for that blog page to a generic 'posts' page |
||
| 413 | * |
||
| 414 | * @access public |
||
| 415 | * @param string $option |
||
| 416 | * @return void |
||
| 417 | */ |
||
| 418 | public static function reset_page_for_posts_on_delete( $option ) { |
||
| 423 | |||
| 424 | |||
| 425 | } |
||
| 426 | // End of file PostShortcodeTracking.php |
||
| 427 | // Location: /PostShortcodeTracking.php |
This error could be the result of:
1. Missing dependencies
PHP Analyzer uses your
composer.jsonfile (if available) to determine the dependencies of your project and to determine all the available classes and functions. It expects thecomposer.jsonto be in the root folder of your repository.Are you sure this class is defined by one of your dependencies, or did you maybe not list a dependency in either the
requireorrequire-devsection?2. Missing use statement
PHP does not complain about undefined classes in
ìnstanceofchecks. For example, the following PHP code will work perfectly fine:If you have not tested against this specific condition, such errors might go unnoticed.