eventespresso / event-espresso-core

core/libraries/payment_methods/EE_Offsite_Gateway.lib.php

Indentation +102 added lines, -102 removed lines

@@ -15,117 +15,117 @@
 abstract class EE_Offsite_Gateway extends EE_Gateway
 {
 
-    /**
-     * whether or not the gateway uses an IPN
-     * that is sent in a separate request than the returning registrant.
-     * if false, then we need to process the payment results manually
-     * as soon as the registrant returns from the off-site gateway
-     *
-     * @type bool
-     */
-    protected $_uses_separate_IPN_request = false;
+	/**
+	 * whether or not the gateway uses an IPN
+	 * that is sent in a separate request than the returning registrant.
+	 * if false, then we need to process the payment results manually
+	 * as soon as the registrant returns from the off-site gateway
+	 *
+	 * @type bool
+	 */
+	protected $_uses_separate_IPN_request = false;
 
 
-    /**
-     * EE_Offsite_Gateway constructor
-     */
-    public function __construct()
-    {
-        $this->_supports_receiving_refunds = true;
-        parent::__construct();
-    }
+	/**
+	 * EE_Offsite_Gateway constructor
+	 */
+	public function __construct()
+	{
+		$this->_supports_receiving_refunds = true;
+		parent::__construct();
+	}
 
 
-    /**
-     * Adds information into the payment object's redirect_url and redirect_args so
-     * client code can use that payment to know where (and with what information)
-     * to redirect the user to in order to make the payment on the offsite gateway's website.
-     * Saving the payment from within this method is unnecessary,
-     * as it is the responsibility of client code to save it.
-     *
-     * @param EE_Payment $payment    to process
-     * @param array      $billing_info
-     * @param string     $return_url URL to send the user to after a successful payment on the payment provider's
-     *                               website
-     * @param string     $notify_url URL to send the instant payment notification
-     * @param string     $cancel_url URL to send the user to after a cancelled payment attempt on teh payment
-     *                               provider's website
-     * @return EE_Payment
-     */
-    abstract public function set_redirection_info(
-        $payment,
-        $billing_info = array(),
-        $return_url = null,
-        $notify_url = null,
-        $cancel_url = null
-    );
+	/**
+	 * Adds information into the payment object's redirect_url and redirect_args so
+	 * client code can use that payment to know where (and with what information)
+	 * to redirect the user to in order to make the payment on the offsite gateway's website.
+	 * Saving the payment from within this method is unnecessary,
+	 * as it is the responsibility of client code to save it.
+	 *
+	 * @param EE_Payment $payment    to process
+	 * @param array      $billing_info
+	 * @param string     $return_url URL to send the user to after a successful payment on the payment provider's
+	 *                               website
+	 * @param string     $notify_url URL to send the instant payment notification
+	 * @param string     $cancel_url URL to send the user to after a cancelled payment attempt on teh payment
+	 *                               provider's website
+	 * @return EE_Payment
+	 */
+	abstract public function set_redirection_info(
+		$payment,
+		$billing_info = array(),
+		$return_url = null,
+		$notify_url = null,
+		$cancel_url = null
+	);
 
 
-    /**
-     * Often used for IPNs. But applies the info in $update_info to the payment.
-     * What is $update_info? Often the contents of $_REQUEST, but not necessarily. Whatever
-     * the payment method passes in. Saving the payment from within this method is unnecessary,
-     * as it is the responsibility of client code to save it.
-     *
-     * @param array           $update_info of whatever
-     * @param EEI_Transaction $transaction
-     * @return EEI_Payment updated
-     */
-    abstract public function handle_payment_update($update_info, $transaction);
+	/**
+	 * Often used for IPNs. But applies the info in $update_info to the payment.
+	 * What is $update_info? Often the contents of $_REQUEST, but not necessarily. Whatever
+	 * the payment method passes in. Saving the payment from within this method is unnecessary,
+	 * as it is the responsibility of client code to save it.
+	 *
+	 * @param array           $update_info of whatever
+	 * @param EEI_Transaction $transaction
+	 * @return EEI_Payment updated
+	 */
+	abstract public function handle_payment_update($update_info, $transaction);
 
 
-    /**
-     * uses_separate_IPN_request
-     *
-     * return true or false for whether or not the gateway uses an IPN
-     * that is sent in a separate request than the returning registrant.
-     * if false, then we need to process the payment results manually
-     * as soon as the registrant returns from the off-site gateway
-     *
-     * @deprecated since version 4.8.39.rc.001 please use handle_IPN_in_this_request() instead
-     *
-     * @return bool
-     */
-    public function uses_separate_IPN_request()
-    {
-        return $this->_uses_separate_IPN_request;
-    }
+	/**
+	 * uses_separate_IPN_request
+	 *
+	 * return true or false for whether or not the gateway uses an IPN
+	 * that is sent in a separate request than the returning registrant.
+	 * if false, then we need to process the payment results manually
+	 * as soon as the registrant returns from the off-site gateway
+	 *
+	 * @deprecated since version 4.8.39.rc.001 please use handle_IPN_in_this_request() instead
+	 *
+	 * @return bool
+	 */
+	public function uses_separate_IPN_request()
+	{
+		return $this->_uses_separate_IPN_request;
+	}
 
 
-    /**
-     * set_uses_separate_IPN_request
-     *
-     * @access protected
-     * @param boolean $uses_separate_IPN_request
-     */
-    protected function set_uses_separate_IPN_request($uses_separate_IPN_request)
-    {
-        $this->_uses_separate_IPN_request = filter_var($uses_separate_IPN_request, FILTER_VALIDATE_BOOLEAN);
-    }
+	/**
+	 * set_uses_separate_IPN_request
+	 *
+	 * @access protected
+	 * @param boolean $uses_separate_IPN_request
+	 */
+	protected function set_uses_separate_IPN_request($uses_separate_IPN_request)
+	{
+		$this->_uses_separate_IPN_request = filter_var($uses_separate_IPN_request, FILTER_VALIDATE_BOOLEAN);
+	}
 
-    /**
-     * Allows gateway to dynamically decide whether or not to handle a payment update
-     * by overriding this method. By default, if this is a "true" IPN (meaning
-     * it's a separate request from when the user returns from the offsite gateway)
-     * and this gateway class is setup to handle IPNs in separate "true" IPNs, then
-     * this will return true, otherwise it will return false.
-     * If however, this is a request when the user is returning
-     * from an offsite gateway, and this gateway class is setup to process the payment
-     * data when the user returns, then this will return true.
-     *
-     * @param array   $request_data
-     * @param boolean $separate_IPN_request
-     * @return boolean
-     */
-    public function handle_IPN_in_this_request($request_data, $separate_IPN_request)
-    {
-        if ($separate_IPN_request) {
-            // payment data being sent in a request separate from the user
-            // it is this other request that will update the TXN and payment info
-            return $this->_uses_separate_IPN_request;
-        } else {
-            // it's a request where the user returned from an offsite gateway WITH the payment data
-            return ! $this->_uses_separate_IPN_request;
-        }
-    }
+	/**
+	 * Allows gateway to dynamically decide whether or not to handle a payment update
+	 * by overriding this method. By default, if this is a "true" IPN (meaning
+	 * it's a separate request from when the user returns from the offsite gateway)
+	 * and this gateway class is setup to handle IPNs in separate "true" IPNs, then
+	 * this will return true, otherwise it will return false.
+	 * If however, this is a request when the user is returning
+	 * from an offsite gateway, and this gateway class is setup to process the payment
+	 * data when the user returns, then this will return true.
+	 *
+	 * @param array   $request_data
+	 * @param boolean $separate_IPN_request
+	 * @return boolean
+	 */
+	public function handle_IPN_in_this_request($request_data, $separate_IPN_request)
+	{
+		if ($separate_IPN_request) {
+			// payment data being sent in a request separate from the user
+			// it is this other request that will update the TXN and payment info
+			return $this->_uses_separate_IPN_request;
+		} else {
+			// it's a request where the user returned from an offsite gateway WITH the payment data
+			return ! $this->_uses_separate_IPN_request;
+		}
+	}
 }

payment_methods/Paypal_Express/EEG_Paypal_Express.gateway.php

Indentation +544 added lines, -544 removed lines

@@ -13,548 +13,548 @@
 class EEG_Paypal_Express extends EE_Offsite_Gateway
 {
 
-    /**
-     * Merchant API Username.
-     *
-     * @var string
-     */
-    protected $_api_username;
-
-    /**
-     * Merchant API Password.
-     *
-     * @var string
-     */
-    protected $_api_password;
-
-    /**
-     * API Signature.
-     *
-     * @var string
-     */
-    protected $_api_signature;
-
-    /**
-     * Request Shipping address on PP checkout page.
-     *
-     * @var string
-     */
-    protected $_request_shipping_addr;
-
-    /**
-     * Business/personal logo.
-     *
-     * @var string
-     */
-    protected $_image_url = '';
-
-    /**
-     * gateway URL variable
-     *
-     * @var string
-     */
-    protected $_base_gateway_url = '';
-
-
-    /**
-     * number of decimal places to round numbers to when performing calculations
-     *
-     * @var integer
-     */
-    protected $decimal_precision = 6;
-
-    /**
-     * @var ItemizedOrder
-     * @since $VID:$
-     */
-    protected $itemized_order;
-
-    /**
-     * @var TokenRequest
-     * @since $VID:$
-     */
-    protected $token_request;
-
-
-    /**
-     * EEG_Paypal_Express constructor.
-     */
-    public function __construct()
-    {
-        require_once 'polyfills.php';
-        $this->_currencies_supported = [
-            'USD',
-            'AUD',
-            'BRL',
-            'CAD',
-            'CZK',
-            'DKK',
-            'EUR',
-            'HKD',
-            'HUF',
-            'ILS',
-            'JPY',
-            'MYR',
-            'MXN',
-            'NOK',
-            'NZD',
-            'PHP',
-            'PLN',
-            'GBP',
-            'RUB',
-            'SGD',
-            'SEK',
-            'CHF',
-            'TWD',
-            'THB',
-            'TRY',
-            'INR',
-        ];
-        parent::__construct();
-        $this->decimal_precision = EE_Registry::instance()->CFG->currency->dec_plc;
-    }
-
-
-    /**
-     * Sets the gateway URL variable based on whether debug mode is enabled or not.
-     *
-     * @param array $settings_array
-     */
-    public function set_settings($settings_array)
-    {
-        parent::set_settings($settings_array);
-        // Redirect URL.
-        $this->_base_gateway_url = $this->_debug_mode
-            ? 'https://api-3t.sandbox.paypal.com/nvp'
-            : 'https://api-3t.paypal.com/nvp';
-    }
-
-
-    /**
-     * @param EEI_Payment $payment
-     * @param array       $billing_info
-     * @param string      $return_url
-     * @param string      $notify_url
-     * @param string      $cancel_url
-     * @return EE_Payment|EEI_Payment
-     * @throws EE_Error
-     * @throws ReflectionException
-     * @throws Exception
-     */
-    public function set_redirection_info(
-        $payment,
-        $billing_info = [],
-        $return_url = null,
-        $notify_url = null,
-        $cancel_url = null
-    ) {
-        if (! $this->validatePayment($payment)) {
-            return $payment;
-        }
-        if (! $this->validateTransaction($payment)) {
-            return $payment;
-        }
-        $this->token_request = new TokenRequest($this->_get_gateway_formatter());
-        $token_request_details = apply_filters(
-            'FHEE__EEG_Paypal_Express__set_redirection_info__arguments',
-            $this->token_request->generateDetails(
-                $payment,
-                $this->getOrderItems($payment),
-                $return_url ?? '',
-                $cancel_url ?? '',
-                $this->_image_url ?? '',
-                $this->_request_shipping_addr ?? ''
-            ),
-            $this
-        );
-        // Request PayPal token.
-        $token_request_response = $this->_ppExpress_request($token_request_details, 'Payment Token', $payment);
-        $token_request_status   = $this->_ppExpress_check_response($token_request_response);
-        $this->token_request->processResponse($payment, $token_request_status, $this->isInSandboxMode());
-
-        return $payment;
-    }
-
-
-    /**
-     * @param array           $update_info {
-     * @type string           $gateway_txn_id
-     * @type string           $status      an EEMI_Payment status
-     *                                     }
-     * @param EEI_Transaction $transaction
-     * @return EEI_Payment
-     * @throws Exception
-     */
-    public function handle_payment_update($update_info, $transaction): EEI_Payment
-    {
-        // if the supplied transaction is valid, we'll retrieve the actual payment object from it
-        // but we'll use a temporary payment for now that we can return with errors if things go wrong
-        $payment = EE_Payment::new_instance();
-        if (! $this->validateTransaction($payment, $transaction)) {
-            return $payment;
-        }
-        $payment = $transaction->last_payment();
-        if (! $this->validatePayment($payment)) {
-            return $payment;
-        }
-        // payment appears to be good... so far
-        $this->log(['Return from Authorization' => $update_info], $payment);
-        $payment_token = $this->getPaymentToken($payment);
-        $customer_details = $this->requestCustomerDetails($payment, $payment_token);
-        // We got the PayerID so now we can Complete the transaction.
-        $this->processPayment($payment, $payment_token, $customer_details);
-
-        return $payment;
-    }
-
-
-    /**
-     * @throws Exception
-     */
-    private function getOrderItems(EE_Payment $payment, array $request_response_args = []): array
-    {
-        $this->itemized_order = new ItemizedOrder($this->_get_gateway_formatter());
-        try {
-            $itemized_order = $this->itemized_order->getExistingItemizedOrder($request_response_args);
-        } catch (Exception $exception) {
-            if (WP_DEBUG) {
-                throw $exception;
-            }
-            // Reset the list and log an error, maybe allow to try and generate a new list (below).
-            $itemized_order = [];
-            $this->log(
-                [
-                    esc_html__(
-                        'Could not generate a proper item list with:',
-                        'event_espresso'
-                    ) => $request_response_args,
-                ],
-                $payment
-            );
-        }
-        if (empty($itemized_order)) {
-            $itemized_order = $this->itemized_order->generateItemizedOrder($payment);
-        }
-        return $itemized_order;
-    }
-
-
-    /**
-     *  Make the Express checkout request.
-     *
-     * @param array       $request_params
-     * @param string      $request_text
-     * @param EEI_Payment $payment
-     * @return array|WP_Error
-     */
-    public function _ppExpress_request(array $request_params, string $request_text, EEI_Payment $payment)
-    {
-        $request_dtls = [
-            'VERSION'      => '204.0',
-            'USER'         => $this->_api_username,
-            'PWD'          => $this->_api_password,
-            'SIGNATURE'    => $this->_api_signature,
-            // EE will blow up if you change this
-            'BUTTONSOURCE' => 'EventEspresso_SP',
-        ];
-        $dtls         = array_merge($request_dtls, $request_params);
-        $this->_log_clean_request($dtls, $payment, $request_text . ' Request');
-        // Request Customer Details.
-        $request_response = wp_remote_post(
-            $this->_base_gateway_url,
-            [
-                'method'      => 'POST',
-                'timeout'     => 45,
-                'httpversion' => '1.1',
-                'cookies'     => [],
-                'headers'     => [],
-                'body'        => http_build_query($dtls),
-            ]
-        );
-        // Log the response.
-        $this->log([$request_text . ' Response' => $request_response], $payment);
-        return $request_response;
-    }
-
-
-    /**
-     *  Check the response status.
-     *
-     * @param mixed $request_response
-     * @return array
-     */
-    public function _ppExpress_check_response($request_response): array
-    {
-        if (is_wp_error($request_response) || empty($request_response['body'])) {
-            // If we got here then there was an error in this request.
-            return ['status' => false, 'args' => $request_response];
-        }
-        $response_args = [];
-        parse_str(urldecode($request_response['body']), $response_args);
-        if (! isset($response_args['ACK'])) {
-            return ['status' => false, 'args' => $request_response];
-        }
-        if (
-            (
-                isset($response_args['PAYERID'])
-                || isset($response_args['TOKEN'])
-                || isset($response_args['PAYMENTINFO_0_TRANSACTIONID'])
-                || (isset($response_args['PAYMENTSTATUS']) && $response_args['PAYMENTSTATUS'] === 'Completed')
-            )
-            && in_array($response_args['ACK'], ['Success', 'SuccessWithWarning'], true)
-        ) {
-            // Response status OK, return response parameters for further processing.
-            return ['status' => true, 'args' => $response_args];
-        }
-        $errors = $this->_get_errors($response_args);
-        return ['status' => false, 'args' => $errors];
-    }
-
-
-    /**
-     *  Log a "Cleared" request.
-     *
-     * @param array       $request
-     * @param EEI_Payment $payment
-     * @param string      $info
-     * @return void
-     */
-    private function _log_clean_request(array $request, EEI_Payment $payment, string $info)
-    {
-        $cleaned_request_data = $request;
-        unset($cleaned_request_data['PWD'], $cleaned_request_data['USER'], $cleaned_request_data['SIGNATURE']);
-        $this->log([$info => $cleaned_request_data], $payment);
-    }
-
-
-    /**
-     *  Get error from the response data.
-     *
-     * @param array $data_array
-     * @return array
-     */
-    private function _get_errors(array $data_array): array
-    {
-        $errors = [];
-        $n      = 0;
-        while (isset($data_array[ "L_ERRORCODE{$n}" ])) {
-            $l_error_code    = $data_array[ "L_ERRORCODE{$n}" ] ?? '';
-            $l_severity_code = $data_array[ "L_SEVERITYCODE{$n}" ] ?? '';
-            $l_short_message = $data_array[ "L_SHORTMESSAGE{$n}" ] ?? '';
-            $l_long_message  = $data_array[ "L_LONGMESSAGE{$n}" ] ?? '';
-            if ($n === 0) {
-                $errors = [
-                    'L_ERRORCODE'    => $l_error_code,
-                    'L_SHORTMESSAGE' => $l_short_message,
-                    'L_LONGMESSAGE'  => $l_long_message,
-                    'L_SEVERITYCODE' => $l_severity_code,
-                ];
-            } else {
-                $errors['L_ERRORCODE']    .= ', ' . $l_error_code;
-                $errors['L_SHORTMESSAGE'] .= ', ' . $l_short_message;
-                $errors['L_LONGMESSAGE']  .= ', ' . $l_long_message;
-                $errors['L_SEVERITYCODE'] .= ', ' . $l_severity_code;
-            }
-            $n++;
-        }
-        return $errors;
-    }
-
-
-    /**
-     * @param EE_Payment $payment
-     * @return mixed|null
-     * @throws EE_Error
-     * @since   $VID:$
-     */
-    private function getPaymentToken(EE_Payment $payment)
-    {
-        $payment_details = $payment->details();
-        // Check if we still have the token.
-        if (! isset($payment_details['TOKEN']) || empty($payment_details['TOKEN'])) {
-            $payment->set_status($this->_pay_model->failed_status());
-            return null;
-        }
-        return $payment_details['TOKEN'];
-    }
-
-    /**
-     * @param EE_Payment $payment
-     * @param array      $checkout_response
-     * @param array      $customer_data
-     * @throws EE_Error
-     * @throws ReflectionException
-     * @since   $VID:$
-     */
-    private function paymentApproved(EE_Payment $payment, array $checkout_response, array $customer_data)
-    {
-        $primary_registrant = $payment->transaction()->primary_registration();
-        $primary_registration_code = $primary_registrant instanceof EE_Registration ?
-            $primary_registrant->reg_code()
-            : '';
-        $payment->set_extra_accntng($primary_registration_code);
-        $payment_amount = $checkout_response['PAYMENTINFO_0_AMT'] ?? 0;
-        $payment->set_amount((float) $payment_amount);
-        $payment->set_txn_id_chq_nmbr($checkout_response['PAYMENTINFO_0_TRANSACTIONID'] ?? null);
-        $payment->set_details($customer_data);
-        $payment->set_gateway_response($checkout_response['PAYMENTINFO_0_ACK'] ?? '');
-        $payment->set_status($this->_pay_model->approved_status());
-    }
-
-
-    /**
-     * @param EE_Payment $payment
-     * @param array      $checkout_response
-     * @throws EE_Error
-     * @since   $VID:$
-     */
-    private function paymentDeclined(EE_Payment $payment, array $checkout_response)
-    {
-        $gateway_response = isset($checkout_response['L_ERRORCODE'])
-            ? $checkout_response['L_ERRORCODE'] . '; ' . $checkout_response['L_SHORTMESSAGE']
-            : esc_html__('Error occurred while trying to Capture the funds.', 'event_espresso');
-
-        $payment->set_gateway_response($gateway_response);
-        $payment->set_details($checkout_response);
-        $payment->set_status($this->_pay_model->declined_status());
-    }
-
-
-    /**
-     * @param EE_Payment $payment
-     * @param array $customer_data
-     * @throws EE_Error
-     * @since   $VID:$
-     */
-    private function paymentFailed(EE_Payment $payment, array $customer_data)
-    {
-        $gateway_response = isset($customer_data['L_ERRORCODE'])
-            ? $customer_data['L_ERRORCODE'] . '; ' . $customer_data['L_SHORTMESSAGE']
-            : esc_html__('Error occurred while trying to get payment Details from PayPal.', 'event_espresso');
-
-        $payment->set_gateway_response($gateway_response);
-        $payment->set_details($customer_data);
-        $payment->set_status($this->_pay_model->failed_status());
-    }
-
-
-    /**
-     * @param EE_Payment $payment
-     * @param string     $payment_token
-     * @param array      $customer_details
-     * @return void
-     * @throws EE_Error
-     * @throws ReflectionException
-     * @throws Exception
-     * @since   $VID:$
-     */
-    private function processPayment(EE_Payment $payment, string $payment_token, array $customer_details)
-    {
-        $checkout_request_dtls = [
-            'METHOD'                         => 'DoExpressCheckoutPayment',
-            'PAYERID'                        => $customer_details['PAYERID'],
-            'TOKEN'                          => $payment_token,
-            'PAYMENTREQUEST_0_PAYMENTACTION' => 'Sale',
-            'PAYMENTREQUEST_0_AMT'           => $payment->amount(),
-            'PAYMENTREQUEST_0_CURRENCYCODE'  => $payment->currency_code(),
-        ];
-        // Include itemized list.
-        $itemized_list         = $this->getOrderItems($payment, $customer_details);
-        $checkout_request_dtls = array_merge($checkout_request_dtls, $itemized_list);
-        // Payment Checkout/Capture.
-        $checkout_request_response = $this->_ppExpress_request(
-            $checkout_request_dtls,
-            'Do Payment',
-            $payment
-        );
-        $checkout_request_status   = $this->_ppExpress_check_response($checkout_request_response);
-        $checkout_response         =
-            isset($checkout_request_status['args']) && is_array($checkout_request_status['args'])
-                ? $checkout_request_status['args']
-                : [];
-        if ($checkout_request_status['status']) {
-            // All is well, payment approved.
-            $this->paymentApproved($payment, $checkout_response, $customer_details);
-        } else {
-            $this->paymentDeclined($payment, $checkout_response);
-        }
-    }
-
-
-    /**
-     * @param EE_Payment $payment
-     * @param string $payment_token
-     * @return array
-     * @throws EE_Error
-     * @since   $VID:$
-     */
-    private function requestCustomerDetails(EE_Payment $payment, string $payment_token): array
-    {
-        $customer_details_request_dtls = [
-            'METHOD' => 'GetExpressCheckoutDetails',
-            'TOKEN'  => $payment_token,
-        ];
-        // Request Customer Details.
-        $customer_details_request_response = $this->_ppExpress_request(
-            $customer_details_request_dtls,
-            'Customer Details',
-            $payment
-        );
-        $customer_details_rstatus          = $this->_ppExpress_check_response($customer_details_request_response);
-        $customer_details = isset($customer_details_rstatus['args']) && is_array($customer_details_rstatus['args'])
-            ? $customer_details_rstatus['args']
-            : [];
-        if (! $customer_details_rstatus['status']) {
-            $this->paymentFailed($payment, $customer_details);
-        }
-        return $customer_details;
-    }
-
-
-
-    /**
-     * @param EE_Payment|null $payment
-     * @return bool
-     * @throws EE_Error
-     * @since   $VID:$
-     */
-    private function validatePayment(?EE_Payment $payment): bool
-    {
-        if (! $payment instanceof EE_Payment) {
-            $payment = EE_Payment::new_instance();
-            $payment->set_gateway_response(
-                esc_html__(
-                    'An error occurred while trying to process the payment.',
-                    'event_espresso'
-                )
-            );
-            $payment->set_status($this->_pay_model->failed_status());
-            return false;
-        }
-        return true;
-    }
-
-
-    /**
-     * @param EE_Payment          $payment
-     * @param EE_Transaction|null $transaction
-     * @return bool
-     * @throws EE_Error
-     * @since   $VID:$
-     */
-    private function validateTransaction(EE_Payment $payment, ?EE_Transaction $transaction = null): bool
-    {
-        $transaction = $transaction ?? $payment->transaction();
-        if (! $transaction instanceof EE_Transaction) {
-            $payment->set_gateway_response(
-                esc_html__(
-                    'Could not process this payment because it has no associated transaction.',
-                    'event_espresso'
-                )
-            );
-            $payment->set_status($this->_pay_model->failed_status());
-            return false;
-        }
-        return true;
-    }
+	/**
+	 * Merchant API Username.
+	 *
+	 * @var string
+	 */
+	protected $_api_username;
+
+	/**
+	 * Merchant API Password.
+	 *
+	 * @var string
+	 */
+	protected $_api_password;
+
+	/**
+	 * API Signature.
+	 *
+	 * @var string
+	 */
+	protected $_api_signature;
+
+	/**
+	 * Request Shipping address on PP checkout page.
+	 *
+	 * @var string
+	 */
+	protected $_request_shipping_addr;
+
+	/**
+	 * Business/personal logo.
+	 *
+	 * @var string
+	 */
+	protected $_image_url = '';
+
+	/**
+	 * gateway URL variable
+	 *
+	 * @var string
+	 */
+	protected $_base_gateway_url = '';
+
+
+	/**
+	 * number of decimal places to round numbers to when performing calculations
+	 *
+	 * @var integer
+	 */
+	protected $decimal_precision = 6;
+
+	/**
+	 * @var ItemizedOrder
+	 * @since $VID:$
+	 */
+	protected $itemized_order;
+
+	/**
+	 * @var TokenRequest
+	 * @since $VID:$
+	 */
+	protected $token_request;
+
+
+	/**
+	 * EEG_Paypal_Express constructor.
+	 */
+	public function __construct()
+	{
+		require_once 'polyfills.php';
+		$this->_currencies_supported = [
+			'USD',
+			'AUD',
+			'BRL',
+			'CAD',
+			'CZK',
+			'DKK',
+			'EUR',
+			'HKD',
+			'HUF',
+			'ILS',
+			'JPY',
+			'MYR',
+			'MXN',
+			'NOK',
+			'NZD',
+			'PHP',
+			'PLN',
+			'GBP',
+			'RUB',
+			'SGD',
+			'SEK',
+			'CHF',
+			'TWD',
+			'THB',
+			'TRY',
+			'INR',
+		];
+		parent::__construct();
+		$this->decimal_precision = EE_Registry::instance()->CFG->currency->dec_plc;
+	}
+
+
+	/**
+	 * Sets the gateway URL variable based on whether debug mode is enabled or not.
+	 *
+	 * @param array $settings_array
+	 */
+	public function set_settings($settings_array)
+	{
+		parent::set_settings($settings_array);
+		// Redirect URL.
+		$this->_base_gateway_url = $this->_debug_mode
+			? 'https://api-3t.sandbox.paypal.com/nvp'
+			: 'https://api-3t.paypal.com/nvp';
+	}
+
+
+	/**
+	 * @param EEI_Payment $payment
+	 * @param array       $billing_info
+	 * @param string      $return_url
+	 * @param string      $notify_url
+	 * @param string      $cancel_url
+	 * @return EE_Payment|EEI_Payment
+	 * @throws EE_Error
+	 * @throws ReflectionException
+	 * @throws Exception
+	 */
+	public function set_redirection_info(
+		$payment,
+		$billing_info = [],
+		$return_url = null,
+		$notify_url = null,
+		$cancel_url = null
+	) {
+		if (! $this->validatePayment($payment)) {
+			return $payment;
+		}
+		if (! $this->validateTransaction($payment)) {
+			return $payment;
+		}
+		$this->token_request = new TokenRequest($this->_get_gateway_formatter());
+		$token_request_details = apply_filters(
+			'FHEE__EEG_Paypal_Express__set_redirection_info__arguments',
+			$this->token_request->generateDetails(
+				$payment,
+				$this->getOrderItems($payment),
+				$return_url ?? '',
+				$cancel_url ?? '',
+				$this->_image_url ?? '',
+				$this->_request_shipping_addr ?? ''
+			),
+			$this
+		);
+		// Request PayPal token.
+		$token_request_response = $this->_ppExpress_request($token_request_details, 'Payment Token', $payment);
+		$token_request_status   = $this->_ppExpress_check_response($token_request_response);
+		$this->token_request->processResponse($payment, $token_request_status, $this->isInSandboxMode());
+
+		return $payment;
+	}
+
+
+	/**
+	 * @param array           $update_info {
+	 * @type string           $gateway_txn_id
+	 * @type string           $status      an EEMI_Payment status
+	 *                                     }
+	 * @param EEI_Transaction $transaction
+	 * @return EEI_Payment
+	 * @throws Exception
+	 */
+	public function handle_payment_update($update_info, $transaction): EEI_Payment
+	{
+		// if the supplied transaction is valid, we'll retrieve the actual payment object from it
+		// but we'll use a temporary payment for now that we can return with errors if things go wrong
+		$payment = EE_Payment::new_instance();
+		if (! $this->validateTransaction($payment, $transaction)) {
+			return $payment;
+		}
+		$payment = $transaction->last_payment();
+		if (! $this->validatePayment($payment)) {
+			return $payment;
+		}
+		// payment appears to be good... so far
+		$this->log(['Return from Authorization' => $update_info], $payment);
+		$payment_token = $this->getPaymentToken($payment);
+		$customer_details = $this->requestCustomerDetails($payment, $payment_token);
+		// We got the PayerID so now we can Complete the transaction.
+		$this->processPayment($payment, $payment_token, $customer_details);
+
+		return $payment;
+	}
+
+
+	/**
+	 * @throws Exception
+	 */
+	private function getOrderItems(EE_Payment $payment, array $request_response_args = []): array
+	{
+		$this->itemized_order = new ItemizedOrder($this->_get_gateway_formatter());
+		try {
+			$itemized_order = $this->itemized_order->getExistingItemizedOrder($request_response_args);
+		} catch (Exception $exception) {
+			if (WP_DEBUG) {
+				throw $exception;
+			}
+			// Reset the list and log an error, maybe allow to try and generate a new list (below).
+			$itemized_order = [];
+			$this->log(
+				[
+					esc_html__(
+						'Could not generate a proper item list with:',
+						'event_espresso'
+					) => $request_response_args,
+				],
+				$payment
+			);
+		}
+		if (empty($itemized_order)) {
+			$itemized_order = $this->itemized_order->generateItemizedOrder($payment);
+		}
+		return $itemized_order;
+	}
+
+
+	/**
+	 *  Make the Express checkout request.
+	 *
+	 * @param array       $request_params
+	 * @param string      $request_text
+	 * @param EEI_Payment $payment
+	 * @return array|WP_Error
+	 */
+	public function _ppExpress_request(array $request_params, string $request_text, EEI_Payment $payment)
+	{
+		$request_dtls = [
+			'VERSION'      => '204.0',
+			'USER'         => $this->_api_username,
+			'PWD'          => $this->_api_password,
+			'SIGNATURE'    => $this->_api_signature,
+			// EE will blow up if you change this
+			'BUTTONSOURCE' => 'EventEspresso_SP',
+		];
+		$dtls         = array_merge($request_dtls, $request_params);
+		$this->_log_clean_request($dtls, $payment, $request_text . ' Request');
+		// Request Customer Details.
+		$request_response = wp_remote_post(
+			$this->_base_gateway_url,
+			[
+				'method'      => 'POST',
+				'timeout'     => 45,
+				'httpversion' => '1.1',
+				'cookies'     => [],
+				'headers'     => [],
+				'body'        => http_build_query($dtls),
+			]
+		);
+		// Log the response.
+		$this->log([$request_text . ' Response' => $request_response], $payment);
+		return $request_response;
+	}
+
+
+	/**
+	 *  Check the response status.
+	 *
+	 * @param mixed $request_response
+	 * @return array
+	 */
+	public function _ppExpress_check_response($request_response): array
+	{
+		if (is_wp_error($request_response) || empty($request_response['body'])) {
+			// If we got here then there was an error in this request.
+			return ['status' => false, 'args' => $request_response];
+		}
+		$response_args = [];
+		parse_str(urldecode($request_response['body']), $response_args);
+		if (! isset($response_args['ACK'])) {
+			return ['status' => false, 'args' => $request_response];
+		}
+		if (
+			(
+				isset($response_args['PAYERID'])
+				|| isset($response_args['TOKEN'])
+				|| isset($response_args['PAYMENTINFO_0_TRANSACTIONID'])
+				|| (isset($response_args['PAYMENTSTATUS']) && $response_args['PAYMENTSTATUS'] === 'Completed')
+			)
+			&& in_array($response_args['ACK'], ['Success', 'SuccessWithWarning'], true)
+		) {
+			// Response status OK, return response parameters for further processing.
+			return ['status' => true, 'args' => $response_args];
+		}
+		$errors = $this->_get_errors($response_args);
+		return ['status' => false, 'args' => $errors];
+	}
+
+
+	/**
+	 *  Log a "Cleared" request.
+	 *
+	 * @param array       $request
+	 * @param EEI_Payment $payment
+	 * @param string      $info
+	 * @return void
+	 */
+	private function _log_clean_request(array $request, EEI_Payment $payment, string $info)
+	{
+		$cleaned_request_data = $request;
+		unset($cleaned_request_data['PWD'], $cleaned_request_data['USER'], $cleaned_request_data['SIGNATURE']);
+		$this->log([$info => $cleaned_request_data], $payment);
+	}
+
+
+	/**
+	 *  Get error from the response data.
+	 *
+	 * @param array $data_array
+	 * @return array
+	 */
+	private function _get_errors(array $data_array): array
+	{
+		$errors = [];
+		$n      = 0;
+		while (isset($data_array[ "L_ERRORCODE{$n}" ])) {
+			$l_error_code    = $data_array[ "L_ERRORCODE{$n}" ] ?? '';
+			$l_severity_code = $data_array[ "L_SEVERITYCODE{$n}" ] ?? '';
+			$l_short_message = $data_array[ "L_SHORTMESSAGE{$n}" ] ?? '';
+			$l_long_message  = $data_array[ "L_LONGMESSAGE{$n}" ] ?? '';
+			if ($n === 0) {
+				$errors = [
+					'L_ERRORCODE'    => $l_error_code,
+					'L_SHORTMESSAGE' => $l_short_message,
+					'L_LONGMESSAGE'  => $l_long_message,
+					'L_SEVERITYCODE' => $l_severity_code,
+				];
+			} else {
+				$errors['L_ERRORCODE']    .= ', ' . $l_error_code;
+				$errors['L_SHORTMESSAGE'] .= ', ' . $l_short_message;
+				$errors['L_LONGMESSAGE']  .= ', ' . $l_long_message;
+				$errors['L_SEVERITYCODE'] .= ', ' . $l_severity_code;
+			}
+			$n++;
+		}
+		return $errors;
+	}
+
+
+	/**
+	 * @param EE_Payment $payment
+	 * @return mixed|null
+	 * @throws EE_Error
+	 * @since   $VID:$
+	 */
+	private function getPaymentToken(EE_Payment $payment)
+	{
+		$payment_details = $payment->details();
+		// Check if we still have the token.
+		if (! isset($payment_details['TOKEN']) || empty($payment_details['TOKEN'])) {
+			$payment->set_status($this->_pay_model->failed_status());
+			return null;
+		}
+		return $payment_details['TOKEN'];
+	}
+
+	/**
+	 * @param EE_Payment $payment
+	 * @param array      $checkout_response
+	 * @param array      $customer_data
+	 * @throws EE_Error
+	 * @throws ReflectionException
+	 * @since   $VID:$
+	 */
+	private function paymentApproved(EE_Payment $payment, array $checkout_response, array $customer_data)
+	{
+		$primary_registrant = $payment->transaction()->primary_registration();
+		$primary_registration_code = $primary_registrant instanceof EE_Registration ?
+			$primary_registrant->reg_code()
+			: '';
+		$payment->set_extra_accntng($primary_registration_code);
+		$payment_amount = $checkout_response['PAYMENTINFO_0_AMT'] ?? 0;
+		$payment->set_amount((float) $payment_amount);
+		$payment->set_txn_id_chq_nmbr($checkout_response['PAYMENTINFO_0_TRANSACTIONID'] ?? null);
+		$payment->set_details($customer_data);
+		$payment->set_gateway_response($checkout_response['PAYMENTINFO_0_ACK'] ?? '');
+		$payment->set_status($this->_pay_model->approved_status());
+	}
+
+
+	/**
+	 * @param EE_Payment $payment
+	 * @param array      $checkout_response
+	 * @throws EE_Error
+	 * @since   $VID:$
+	 */
+	private function paymentDeclined(EE_Payment $payment, array $checkout_response)
+	{
+		$gateway_response = isset($checkout_response['L_ERRORCODE'])
+			? $checkout_response['L_ERRORCODE'] . '; ' . $checkout_response['L_SHORTMESSAGE']
+			: esc_html__('Error occurred while trying to Capture the funds.', 'event_espresso');
+
+		$payment->set_gateway_response($gateway_response);
+		$payment->set_details($checkout_response);
+		$payment->set_status($this->_pay_model->declined_status());
+	}
+
+
+	/**
+	 * @param EE_Payment $payment
+	 * @param array $customer_data
+	 * @throws EE_Error
+	 * @since   $VID:$
+	 */
+	private function paymentFailed(EE_Payment $payment, array $customer_data)
+	{
+		$gateway_response = isset($customer_data['L_ERRORCODE'])
+			? $customer_data['L_ERRORCODE'] . '; ' . $customer_data['L_SHORTMESSAGE']
+			: esc_html__('Error occurred while trying to get payment Details from PayPal.', 'event_espresso');
+
+		$payment->set_gateway_response($gateway_response);
+		$payment->set_details($customer_data);
+		$payment->set_status($this->_pay_model->failed_status());
+	}
+
+
+	/**
+	 * @param EE_Payment $payment
+	 * @param string     $payment_token
+	 * @param array      $customer_details
+	 * @return void
+	 * @throws EE_Error
+	 * @throws ReflectionException
+	 * @throws Exception
+	 * @since   $VID:$
+	 */
+	private function processPayment(EE_Payment $payment, string $payment_token, array $customer_details)
+	{
+		$checkout_request_dtls = [
+			'METHOD'                         => 'DoExpressCheckoutPayment',
+			'PAYERID'                        => $customer_details['PAYERID'],
+			'TOKEN'                          => $payment_token,
+			'PAYMENTREQUEST_0_PAYMENTACTION' => 'Sale',
+			'PAYMENTREQUEST_0_AMT'           => $payment->amount(),
+			'PAYMENTREQUEST_0_CURRENCYCODE'  => $payment->currency_code(),
+		];
+		// Include itemized list.
+		$itemized_list         = $this->getOrderItems($payment, $customer_details);
+		$checkout_request_dtls = array_merge($checkout_request_dtls, $itemized_list);
+		// Payment Checkout/Capture.
+		$checkout_request_response = $this->_ppExpress_request(
+			$checkout_request_dtls,
+			'Do Payment',
+			$payment
+		);
+		$checkout_request_status   = $this->_ppExpress_check_response($checkout_request_response);
+		$checkout_response         =
+			isset($checkout_request_status['args']) && is_array($checkout_request_status['args'])
+				? $checkout_request_status['args']
+				: [];
+		if ($checkout_request_status['status']) {
+			// All is well, payment approved.
+			$this->paymentApproved($payment, $checkout_response, $customer_details);
+		} else {
+			$this->paymentDeclined($payment, $checkout_response);
+		}
+	}
+
+
+	/**
+	 * @param EE_Payment $payment
+	 * @param string $payment_token
+	 * @return array
+	 * @throws EE_Error
+	 * @since   $VID:$
+	 */
+	private function requestCustomerDetails(EE_Payment $payment, string $payment_token): array
+	{
+		$customer_details_request_dtls = [
+			'METHOD' => 'GetExpressCheckoutDetails',
+			'TOKEN'  => $payment_token,
+		];
+		// Request Customer Details.
+		$customer_details_request_response = $this->_ppExpress_request(
+			$customer_details_request_dtls,
+			'Customer Details',
+			$payment
+		);
+		$customer_details_rstatus          = $this->_ppExpress_check_response($customer_details_request_response);
+		$customer_details = isset($customer_details_rstatus['args']) && is_array($customer_details_rstatus['args'])
+			? $customer_details_rstatus['args']
+			: [];
+		if (! $customer_details_rstatus['status']) {
+			$this->paymentFailed($payment, $customer_details);
+		}
+		return $customer_details;
+	}
+
+
+
+	/**
+	 * @param EE_Payment|null $payment
+	 * @return bool
+	 * @throws EE_Error
+	 * @since   $VID:$
+	 */
+	private function validatePayment(?EE_Payment $payment): bool
+	{
+		if (! $payment instanceof EE_Payment) {
+			$payment = EE_Payment::new_instance();
+			$payment->set_gateway_response(
+				esc_html__(
+					'An error occurred while trying to process the payment.',
+					'event_espresso'
+				)
+			);
+			$payment->set_status($this->_pay_model->failed_status());
+			return false;
+		}
+		return true;
+	}
+
+
+	/**
+	 * @param EE_Payment          $payment
+	 * @param EE_Transaction|null $transaction
+	 * @return bool
+	 * @throws EE_Error
+	 * @since   $VID:$
+	 */
+	private function validateTransaction(EE_Payment $payment, ?EE_Transaction $transaction = null): bool
+	{
+		$transaction = $transaction ?? $payment->transaction();
+		if (! $transaction instanceof EE_Transaction) {
+			$payment->set_gateway_response(
+				esc_html__(
+					'Could not process this payment because it has no associated transaction.',
+					'event_espresso'
+				)
+			);
+			$payment->set_status($this->_pay_model->failed_status());
+			return false;
+		}
+		return true;
+	}
 }

Spacing +24 added lines, -24 removed lines

@@ -148,10 +148,10 @@ 
         $notify_url = null,
         $cancel_url = null
     ) {
-        if (! $this->validatePayment($payment)) {
+        if ( ! $this->validatePayment($payment)) {
             return $payment;
         }
-        if (! $this->validateTransaction($payment)) {
+        if ( ! $this->validateTransaction($payment)) {
             return $payment;
         }
         $this->token_request = new TokenRequest($this->_get_gateway_formatter());
@@ -190,11 +190,11 @@ 
         // if the supplied transaction is valid, we'll retrieve the actual payment object from it
         // but we'll use a temporary payment for now that we can return with errors if things go wrong
         $payment = EE_Payment::new_instance();
-        if (! $this->validateTransaction($payment, $transaction)) {
+        if ( ! $this->validateTransaction($payment, $transaction)) {
             return $payment;
         }
         $payment = $transaction->last_payment();
-        if (! $this->validatePayment($payment)) {
+        if ( ! $this->validatePayment($payment)) {
             return $payment;
         }
         // payment appears to be good... so far
@@ -257,8 +257,8 @@ 
             // EE will blow up if you change this
             'BUTTONSOURCE' => 'EventEspresso_SP',
         ];
-        $dtls         = array_merge($request_dtls, $request_params);
-        $this->_log_clean_request($dtls, $payment, $request_text . ' Request');
+        $dtls = array_merge($request_dtls, $request_params);
+        $this->_log_clean_request($dtls, $payment, $request_text.' Request');
         // Request Customer Details.
         $request_response = wp_remote_post(
             $this->_base_gateway_url,
@@ -272,7 +272,7 @@ 
             ]
         );
         // Log the response.
-        $this->log([$request_text . ' Response' => $request_response], $payment);
+        $this->log([$request_text.' Response' => $request_response], $payment);
         return $request_response;
     }
 
@@ -291,7 +291,7 @@ 
         }
         $response_args = [];
         parse_str(urldecode($request_response['body']), $response_args);
-        if (! isset($response_args['ACK'])) {
+        if ( ! isset($response_args['ACK'])) {
             return ['status' => false, 'args' => $request_response];
         }
         if (
@@ -337,11 +337,11 @@ 
     {
         $errors = [];
         $n      = 0;
-        while (isset($data_array[ "L_ERRORCODE{$n}" ])) {
-            $l_error_code    = $data_array[ "L_ERRORCODE{$n}" ] ?? '';
-            $l_severity_code = $data_array[ "L_SEVERITYCODE{$n}" ] ?? '';
-            $l_short_message = $data_array[ "L_SHORTMESSAGE{$n}" ] ?? '';
-            $l_long_message  = $data_array[ "L_LONGMESSAGE{$n}" ] ?? '';
+        while (isset($data_array["L_ERRORCODE{$n}"])) {
+            $l_error_code    = $data_array["L_ERRORCODE{$n}"] ?? '';
+            $l_severity_code = $data_array["L_SEVERITYCODE{$n}"] ?? '';
+            $l_short_message = $data_array["L_SHORTMESSAGE{$n}"] ?? '';
+            $l_long_message  = $data_array["L_LONGMESSAGE{$n}"] ?? '';
             if ($n === 0) {
                 $errors = [
                     'L_ERRORCODE'    => $l_error_code,
@@ -350,10 +350,10 @@ 
                     'L_SEVERITYCODE' => $l_severity_code,
                 ];
             } else {
-                $errors['L_ERRORCODE']    .= ', ' . $l_error_code;
-                $errors['L_SHORTMESSAGE'] .= ', ' . $l_short_message;
-                $errors['L_LONGMESSAGE']  .= ', ' . $l_long_message;
-                $errors['L_SEVERITYCODE'] .= ', ' . $l_severity_code;
+                $errors['L_ERRORCODE']    .= ', '.$l_error_code;
+                $errors['L_SHORTMESSAGE'] .= ', '.$l_short_message;
+                $errors['L_LONGMESSAGE']  .= ', '.$l_long_message;
+                $errors['L_SEVERITYCODE'] .= ', '.$l_severity_code;
             }
             $n++;
         }
@@ -371,7 +371,7 @@ 
     {
         $payment_details = $payment->details();
         // Check if we still have the token.
-        if (! isset($payment_details['TOKEN']) || empty($payment_details['TOKEN'])) {
+        if ( ! isset($payment_details['TOKEN']) || empty($payment_details['TOKEN'])) {
             $payment->set_status($this->_pay_model->failed_status());
             return null;
         }
@@ -411,7 +411,7 @@ 
     private function paymentDeclined(EE_Payment $payment, array $checkout_response)
     {
         $gateway_response = isset($checkout_response['L_ERRORCODE'])
-            ? $checkout_response['L_ERRORCODE'] . '; ' . $checkout_response['L_SHORTMESSAGE']
+            ? $checkout_response['L_ERRORCODE'].'; '.$checkout_response['L_SHORTMESSAGE']
             : esc_html__('Error occurred while trying to Capture the funds.', 'event_espresso');
 
         $payment->set_gateway_response($gateway_response);
@@ -429,7 +429,7 @@ 
     private function paymentFailed(EE_Payment $payment, array $customer_data)
     {
         $gateway_response = isset($customer_data['L_ERRORCODE'])
-            ? $customer_data['L_ERRORCODE'] . '; ' . $customer_data['L_SHORTMESSAGE']
+            ? $customer_data['L_ERRORCODE'].'; '.$customer_data['L_SHORTMESSAGE']
             : esc_html__('Error occurred while trying to get payment Details from PayPal.', 'event_espresso');
 
         $payment->set_gateway_response($gateway_response);
@@ -500,11 +500,11 @@ 
             'Customer Details',
             $payment
         );
-        $customer_details_rstatus          = $this->_ppExpress_check_response($customer_details_request_response);
+        $customer_details_rstatus = $this->_ppExpress_check_response($customer_details_request_response);
         $customer_details = isset($customer_details_rstatus['args']) && is_array($customer_details_rstatus['args'])
             ? $customer_details_rstatus['args']
             : [];
-        if (! $customer_details_rstatus['status']) {
+        if ( ! $customer_details_rstatus['status']) {
             $this->paymentFailed($payment, $customer_details);
         }
         return $customer_details;
@@ -520,7 +520,7 @@ 
      */
     private function validatePayment(?EE_Payment $payment): bool
     {
-        if (! $payment instanceof EE_Payment) {
+        if ( ! $payment instanceof EE_Payment) {
             $payment = EE_Payment::new_instance();
             $payment->set_gateway_response(
                 esc_html__(
@@ -545,7 +545,7 @@ 
     private function validateTransaction(EE_Payment $payment, ?EE_Transaction $transaction = null): bool
     {
         $transaction = $transaction ?? $payment->transaction();
-        if (! $transaction instanceof EE_Transaction) {
+        if ( ! $transaction instanceof EE_Transaction) {
             $payment->set_gateway_response(
                 esc_html__(
                     'Could not process this payment because it has no associated transaction.',

payment_methods/Paypal_Express/ItemizedOrder.php

Indentation +265 added lines, -265 removed lines

@@ -16,292 +16,292 @@
 {
 
 
-    /**
-     * number of decimal places to round numbers to when performing calculations
-     *
-     * @var integer
-     */
-    protected $decimal_precision = 6;
+	/**
+	 * number of decimal places to round numbers to when performing calculations
+	 *
+	 * @var integer
+	 */
+	protected $decimal_precision = 6;
 
-    /**
-     * @var GatewayDataFormatterInterface
-     */
-    protected $gateway_data_formatter;
+	/**
+	 * @var GatewayDataFormatterInterface
+	 */
+	protected $gateway_data_formatter;
 
-    /**
-     * keeps track of exactly how much the itemized order amount equals
-     *
-     * @var float
-     */
-    private $itemized_order_sum = 0.00;
+	/**
+	 * keeps track of exactly how much the itemized order amount equals
+	 *
+	 * @var float
+	 */
+	private $itemized_order_sum = 0.00;
 
-    /**
-     * @var array
-     */
-    private $order_items;
+	/**
+	 * @var array
+	 */
+	private $order_items;
 
-    /**
-     * the payment being processed
-     *
-     * @var EE_Payment
-     */
-    protected $payment;
+	/**
+	 * the payment being processed
+	 *
+	 * @var EE_Payment
+	 */
+	protected $payment;
 
-    /**
-     * @var EE_Transaction
-     */
-    private $transaction;
+	/**
+	 * @var EE_Transaction
+	 */
+	private $transaction;
 
 
-    /**
-     * @param GatewayDataFormatterInterface $gateway_data_formatter
-     */
-    public function __construct(GatewayDataFormatterInterface $gateway_data_formatter)
-    {
-        $this->decimal_precision      = EE_Registry::instance()->CFG->currency->dec_plc;
-        $this->gateway_data_formatter = $gateway_data_formatter;
-        $this->order_items            = [];
-    }
+	/**
+	 * @param GatewayDataFormatterInterface $gateway_data_formatter
+	 */
+	public function __construct(GatewayDataFormatterInterface $gateway_data_formatter)
+	{
+		$this->decimal_precision      = EE_Registry::instance()->CFG->currency->dec_plc;
+		$this->gateway_data_formatter = $gateway_data_formatter;
+		$this->order_items            = [];
+	}
 
 
-    /**
-     * @param array $request_response_args
-     * @return array
-     */
-    public function getExistingItemizedOrder(array $request_response_args): array
-    {
-        // If we have data from a previous communication with PP (on this transaction) we may use that for our list...
-        if (
-            ! empty($request_response_args)
-            && array_key_exists('L_PAYMENTREQUEST_0_AMT0', $request_response_args)
-            && array_key_exists('PAYMENTREQUEST_0_ITEMAMT', $request_response_args)
-        ) {
-            foreach ($request_response_args as $arg_key => $arg_val) {
-                if (
-                    strpos($arg_key, 'PAYMENTREQUEST_') !== false
-                    && strpos($arg_key, 'NOTIFYURL') === false
-                ) {
-                    $this->order_items[ $arg_key ] = $arg_val;
-                }
-            }
-            // If we only get a few Items then something is not right.
-            if (count($this->order_items) < 3) {
-                throw new RuntimeException(
-                    sprintf(
-                        esc_html__(
-                            'Unable to continue with the checkout because a proper purchase list could not be generated. The purchased list we could have sent was %1$s',
-                            'event_espresso'
-                        ),
-                        wp_json_encode($this->order_items)
-                    )
-                );
-            }
-        }
-        return $this->order_items;
-    }
+	/**
+	 * @param array $request_response_args
+	 * @return array
+	 */
+	public function getExistingItemizedOrder(array $request_response_args): array
+	{
+		// If we have data from a previous communication with PP (on this transaction) we may use that for our list...
+		if (
+			! empty($request_response_args)
+			&& array_key_exists('L_PAYMENTREQUEST_0_AMT0', $request_response_args)
+			&& array_key_exists('PAYMENTREQUEST_0_ITEMAMT', $request_response_args)
+		) {
+			foreach ($request_response_args as $arg_key => $arg_val) {
+				if (
+					strpos($arg_key, 'PAYMENTREQUEST_') !== false
+					&& strpos($arg_key, 'NOTIFYURL') === false
+				) {
+					$this->order_items[ $arg_key ] = $arg_val;
+				}
+			}
+			// If we only get a few Items then something is not right.
+			if (count($this->order_items) < 3) {
+				throw new RuntimeException(
+					sprintf(
+						esc_html__(
+							'Unable to continue with the checkout because a proper purchase list could not be generated. The purchased list we could have sent was %1$s',
+							'event_espresso'
+						),
+						wp_json_encode($this->order_items)
+					)
+				);
+			}
+		}
+		return $this->order_items;
+	}
 
 
-    /**
-     *  Make a list of items that are in the giver transaction.
-     *
-     * @param EE_Payment $payment
-     * @return array
-     * @throws EE_Error
-     * @throws ReflectionException
-     */
-    public function generateItemizedOrder(EE_Payment $payment): array
-    {
-        $this->payment     = $payment;
-        $this->transaction = $this->payment->transaction();
-        // reset order items
-        $this->order_items = [];
-        if ($this->paymentIsForTransactionTotal()) {
-            $this->itemizeOrderForFullPayment();
-        } else {
-            $this->handlePartialPayment();
-        }
-        return $this->order_items;
-    }
+	/**
+	 *  Make a list of items that are in the giver transaction.
+	 *
+	 * @param EE_Payment $payment
+	 * @return array
+	 * @throws EE_Error
+	 * @throws ReflectionException
+	 */
+	public function generateItemizedOrder(EE_Payment $payment): array
+	{
+		$this->payment     = $payment;
+		$this->transaction = $this->payment->transaction();
+		// reset order items
+		$this->order_items = [];
+		if ($this->paymentIsForTransactionTotal()) {
+			$this->itemizeOrderForFullPayment();
+		} else {
+			$this->handlePartialPayment();
+		}
+		return $this->order_items;
+	}
 
 
-    /**
-     * @return bool
-     * @throws ReflectionException
-     * @throws EE_Error
-     */
-    private function paymentIsForTransactionTotal(): bool
-    {
-        return EEH_Money::compare_floats($this->payment->amount(), $this->transaction->total(), '==');
-    }
+	/**
+	 * @return bool
+	 * @throws ReflectionException
+	 * @throws EE_Error
+	 */
+	private function paymentIsForTransactionTotal(): bool
+	{
+		return EEH_Money::compare_floats($this->payment->amount(), $this->transaction->total(), '==');
+	}
 
 
-    /**
-     * @return void
-     * @throws EE_Error
-     * @throws ReflectionException
-     */
-    private function itemizeOrderForFullPayment()
-    {
-        $item_num        = 0;
-        $total_line_item = $this->transaction->total_line_item();
-        $item_num        = $this->addOrderItemsForLineItems($total_line_item, $item_num);
-        $this->addOrderItemsForAdditionalCharges($total_line_item);
-        $this->handleItemizedOrderSumDifference($total_line_item, $item_num);
-    }
+	/**
+	 * @return void
+	 * @throws EE_Error
+	 * @throws ReflectionException
+	 */
+	private function itemizeOrderForFullPayment()
+	{
+		$item_num        = 0;
+		$total_line_item = $this->transaction->total_line_item();
+		$item_num        = $this->addOrderItemsForLineItems($total_line_item, $item_num);
+		$this->addOrderItemsForAdditionalCharges($total_line_item);
+		$this->handleItemizedOrderSumDifference($total_line_item, $item_num);
+	}
 
 
-    /**
-     * @return void
-     * @throws EE_Error
-     */
-    private function handlePartialPayment()
-    {
-        // Item Name.
-        $this->order_items['L_PAYMENTREQUEST_0_NAME0'] = mb_strcut(
-            $this->gateway_data_formatter->formatPartialPaymentLineItemName($this->payment),
-            0,
-            127
-        );
-        // Item description.
-        $this->order_items['L_PAYMENTREQUEST_0_DESC0'] = mb_strcut(
-            $this->gateway_data_formatter->formatPartialPaymentLineItemDesc($this->payment),
-            0,
-            127
-        );
-        // Cost of individual item.
-        $this->order_items['L_PAYMENTREQUEST_0_AMT0'] = $this->gateway_data_formatter->formatCurrency(
-            $this->payment->amount(),
-            $this->decimal_precision
-        );
-        // Item Number.
-        $this->order_items['L_PAYMENTREQUEST_0_NUMBER0'] = 1;
-        // Item quantity.
-        $this->order_items['L_PAYMENTREQUEST_0_QTY0'] = 1;
-        // Digital item is sold.
-        $this->order_items['L_PAYMENTREQUEST_0_ITEMCATEGORY0'] = 'Physical';
-        // Item's sales S/H and tax amount.
-        $this->order_items['PAYMENTREQUEST_0_ITEMAMT']     = $this->gateway_data_formatter->formatCurrency(
-            $this->payment->amount(),
-            $this->decimal_precision
-        );
-        $this->order_items['PAYMENTREQUEST_0_TAXAMT']      = '0';
-        $this->order_items['PAYMENTREQUEST_0_SHIPPINGAMT'] = '0';
-        $this->order_items['PAYMENTREQUEST_0_HANDLINGAMT'] = '0';
-    }
+	/**
+	 * @return void
+	 * @throws EE_Error
+	 */
+	private function handlePartialPayment()
+	{
+		// Item Name.
+		$this->order_items['L_PAYMENTREQUEST_0_NAME0'] = mb_strcut(
+			$this->gateway_data_formatter->formatPartialPaymentLineItemName($this->payment),
+			0,
+			127
+		);
+		// Item description.
+		$this->order_items['L_PAYMENTREQUEST_0_DESC0'] = mb_strcut(
+			$this->gateway_data_formatter->formatPartialPaymentLineItemDesc($this->payment),
+			0,
+			127
+		);
+		// Cost of individual item.
+		$this->order_items['L_PAYMENTREQUEST_0_AMT0'] = $this->gateway_data_formatter->formatCurrency(
+			$this->payment->amount(),
+			$this->decimal_precision
+		);
+		// Item Number.
+		$this->order_items['L_PAYMENTREQUEST_0_NUMBER0'] = 1;
+		// Item quantity.
+		$this->order_items['L_PAYMENTREQUEST_0_QTY0'] = 1;
+		// Digital item is sold.
+		$this->order_items['L_PAYMENTREQUEST_0_ITEMCATEGORY0'] = 'Physical';
+		// Item's sales S/H and tax amount.
+		$this->order_items['PAYMENTREQUEST_0_ITEMAMT']     = $this->gateway_data_formatter->formatCurrency(
+			$this->payment->amount(),
+			$this->decimal_precision
+		);
+		$this->order_items['PAYMENTREQUEST_0_TAXAMT']      = '0';
+		$this->order_items['PAYMENTREQUEST_0_SHIPPINGAMT'] = '0';
+		$this->order_items['PAYMENTREQUEST_0_HANDLINGAMT'] = '0';
+	}
 
 
-    /**
-     * @param EE_Line_Item $total_line_item
-     * @param int          $item_num
-     * @return int
-     * @throws EE_Error
-     * @throws ReflectionException
-     */
-    private function addOrderItemsForLineItems(EE_Line_Item $total_line_item, int $item_num): int
-    {
-        // Go through each item in the list.
-        foreach ($total_line_item->get_items() as $line_item) {
-            if ($line_item instanceof EE_Line_Item) {
-                // PayPal doesn't like line items with 0.00 amount, so we may skip those.
-                if (EEH_Money::compare_floats($line_item->pretaxTotal(), '0.00', '==')) {
-                    continue;
-                }
-                $unit_price         = $this->gateway_data_formatter->formatCurrency(
-                    $line_item->unit_price(),
-                    $this->decimal_precision
-                );
-                $line_item_quantity = $line_item->quantity();
-                // This is a discount.
-                if ($line_item->is_percent()) {
-                    $unit_price         = $line_item->pretaxTotal();
-                    $line_item_quantity = 1;
-                }
-                // Item Name.
-                $this->order_items[ "L_PAYMENTREQUEST_0_NAME{$item_num}" ] = mb_strcut(
-                    $this->gateway_data_formatter->formatLineItemName($line_item, $this->payment),
-                    0,
-                    127
-                );
-                // Item description.
-                $this->order_items[ "L_PAYMENTREQUEST_0_DESC{$item_num}" ] = mb_strcut(
-                    $this->gateway_data_formatter->formatLineItemDesc($line_item, $this->payment),
-                    0,
-                    127
-                );
-                // Cost of individual item.
-                $this->order_items[ "L_PAYMENTREQUEST_0_AMT{$item_num}" ] = $unit_price;
-                // Item Number.
-                $this->order_items[ "L_PAYMENTREQUEST_0_NUMBER{$item_num}" ] = $item_num + 1;
-                // Item quantity.
-                $this->order_items[ "L_PAYMENTREQUEST_0_QTY{$item_num}" ] = $line_item_quantity;
-                // Digital item is sold.
-                $this->order_items[ "L_PAYMENTREQUEST_0_ITEMCATEGORY{$item_num}" ] = 'Physical';
-                // add item total to order sum
-                $this->itemized_order_sum += $unit_price * $line_item_quantity;
-                ++$item_num;
-            }
-        }
-        return $item_num;
-    }
+	/**
+	 * @param EE_Line_Item $total_line_item
+	 * @param int          $item_num
+	 * @return int
+	 * @throws EE_Error
+	 * @throws ReflectionException
+	 */
+	private function addOrderItemsForLineItems(EE_Line_Item $total_line_item, int $item_num): int
+	{
+		// Go through each item in the list.
+		foreach ($total_line_item->get_items() as $line_item) {
+			if ($line_item instanceof EE_Line_Item) {
+				// PayPal doesn't like line items with 0.00 amount, so we may skip those.
+				if (EEH_Money::compare_floats($line_item->pretaxTotal(), '0.00', '==')) {
+					continue;
+				}
+				$unit_price         = $this->gateway_data_formatter->formatCurrency(
+					$line_item->unit_price(),
+					$this->decimal_precision
+				);
+				$line_item_quantity = $line_item->quantity();
+				// This is a discount.
+				if ($line_item->is_percent()) {
+					$unit_price         = $line_item->pretaxTotal();
+					$line_item_quantity = 1;
+				}
+				// Item Name.
+				$this->order_items[ "L_PAYMENTREQUEST_0_NAME{$item_num}" ] = mb_strcut(
+					$this->gateway_data_formatter->formatLineItemName($line_item, $this->payment),
+					0,
+					127
+				);
+				// Item description.
+				$this->order_items[ "L_PAYMENTREQUEST_0_DESC{$item_num}" ] = mb_strcut(
+					$this->gateway_data_formatter->formatLineItemDesc($line_item, $this->payment),
+					0,
+					127
+				);
+				// Cost of individual item.
+				$this->order_items[ "L_PAYMENTREQUEST_0_AMT{$item_num}" ] = $unit_price;
+				// Item Number.
+				$this->order_items[ "L_PAYMENTREQUEST_0_NUMBER{$item_num}" ] = $item_num + 1;
+				// Item quantity.
+				$this->order_items[ "L_PAYMENTREQUEST_0_QTY{$item_num}" ] = $line_item_quantity;
+				// Digital item is sold.
+				$this->order_items[ "L_PAYMENTREQUEST_0_ITEMCATEGORY{$item_num}" ] = 'Physical';
+				// add item total to order sum
+				$this->itemized_order_sum += $unit_price * $line_item_quantity;
+				++$item_num;
+			}
+		}
+		return $item_num;
+	}
 
 
-    /**
-     * @param EE_Line_Item $total_line_item
-     * @return void
-     * @throws EE_Error
-     * @throws ReflectionException
-     */
-    private function addOrderItemsForAdditionalCharges(EE_Line_Item $total_line_item)
-    {
-        // Item's sales S/H and tax amount.
-        $this->order_items['PAYMENTREQUEST_0_ITEMAMT']     = $total_line_item->get_items_total();
-        $this->order_items['PAYMENTREQUEST_0_TAXAMT']      = $total_line_item->get_total_tax();
-        $this->order_items['PAYMENTREQUEST_0_SHIPPINGAMT'] = '0';
-        $this->order_items['PAYMENTREQUEST_0_HANDLINGAMT'] = '0';
-    }
+	/**
+	 * @param EE_Line_Item $total_line_item
+	 * @return void
+	 * @throws EE_Error
+	 * @throws ReflectionException
+	 */
+	private function addOrderItemsForAdditionalCharges(EE_Line_Item $total_line_item)
+	{
+		// Item's sales S/H and tax amount.
+		$this->order_items['PAYMENTREQUEST_0_ITEMAMT']     = $total_line_item->get_items_total();
+		$this->order_items['PAYMENTREQUEST_0_TAXAMT']      = $total_line_item->get_total_tax();
+		$this->order_items['PAYMENTREQUEST_0_SHIPPINGAMT'] = '0';
+		$this->order_items['PAYMENTREQUEST_0_HANDLINGAMT'] = '0';
+	}
 
 
-    /**
-     * @param EE_Line_Item $total_line_item
-     * @param int          $item_num
-     * @return void
-     * @throws EE_Error
-     * @throws ReflectionException
-     */
-    private function handleItemizedOrderSumDifference(EE_Line_Item $total_line_item, int $item_num)
-    {
-        // calculate the difference between the TXN total and the itemized order sum
-        $itemized_order_sum_difference = round(
-            $this->transaction->total()
-            - $this->itemized_order_sum
-            - $total_line_item->get_total_tax(),
-            $this->decimal_precision
-        );
-        // If we were not able to recognize some item like promotion, surcharge or cancellation,
-        // add the difference as an extra line item.
-        if (EEH_Money::compare_floats($itemized_order_sum_difference, 0, '!=')) {
-            // Item Name.
-            $this->order_items[ "L_PAYMENTREQUEST_0_NAME{$item_num}" ] = mb_strcut(
-                esc_html__(
-                    'Other (promotion/surcharge/cancellation)',
-                    'event_espresso'
-                ),
-                0,
-                127
-            );
-            // Item description.
-            $this->order_items[ "L_PAYMENTREQUEST_0_DESC{$item_num}" ] = '';
-            // Cost of individual item.
-            $this->order_items[ "L_PAYMENTREQUEST_0_AMT{$item_num}" ] = $this->gateway_data_formatter->formatCurrency(
-                $itemized_order_sum_difference,
-                $this->decimal_precision
-            );
-            // Item Number.
-            $this->order_items[ "L_PAYMENTREQUEST_0_NUMBER{$item_num}" ] = $item_num + 1;
-            // Item quantity.
-            $this->order_items[ "L_PAYMENTREQUEST_0_QTY{$item_num}" ] = 1;
-            // Digital item is sold.
-            $this->order_items[ "L_PAYMENTREQUEST_0_ITEMCATEGORY{$item_num}" ] = 'Physical';
-        }
-    }
+	/**
+	 * @param EE_Line_Item $total_line_item
+	 * @param int          $item_num
+	 * @return void
+	 * @throws EE_Error
+	 * @throws ReflectionException
+	 */
+	private function handleItemizedOrderSumDifference(EE_Line_Item $total_line_item, int $item_num)
+	{
+		// calculate the difference between the TXN total and the itemized order sum
+		$itemized_order_sum_difference = round(
+			$this->transaction->total()
+			- $this->itemized_order_sum
+			- $total_line_item->get_total_tax(),
+			$this->decimal_precision
+		);
+		// If we were not able to recognize some item like promotion, surcharge or cancellation,
+		// add the difference as an extra line item.
+		if (EEH_Money::compare_floats($itemized_order_sum_difference, 0, '!=')) {
+			// Item Name.
+			$this->order_items[ "L_PAYMENTREQUEST_0_NAME{$item_num}" ] = mb_strcut(
+				esc_html__(
+					'Other (promotion/surcharge/cancellation)',
+					'event_espresso'
+				),
+				0,
+				127
+			);
+			// Item description.
+			$this->order_items[ "L_PAYMENTREQUEST_0_DESC{$item_num}" ] = '';
+			// Cost of individual item.
+			$this->order_items[ "L_PAYMENTREQUEST_0_AMT{$item_num}" ] = $this->gateway_data_formatter->formatCurrency(
+				$itemized_order_sum_difference,
+				$this->decimal_precision
+			);
+			// Item Number.
+			$this->order_items[ "L_PAYMENTREQUEST_0_NUMBER{$item_num}" ] = $item_num + 1;
+			// Item quantity.
+			$this->order_items[ "L_PAYMENTREQUEST_0_QTY{$item_num}" ] = 1;
+			// Digital item is sold.
+			$this->order_items[ "L_PAYMENTREQUEST_0_ITEMCATEGORY{$item_num}" ] = 'Physical';
+		}
+	}
 }

Spacing +15 added lines, -15 removed lines

@@ -81,7 +81,7 @@ 
                     strpos($arg_key, 'PAYMENTREQUEST_') !== false
                     && strpos($arg_key, 'NOTIFYURL') === false
                 ) {
-                    $this->order_items[ $arg_key ] = $arg_val;
+                    $this->order_items[$arg_key] = $arg_val;
                 }
             }
             // If we only get a few Items then something is not right.
@@ -180,7 +180,7 @@ 
         // Digital item is sold.
         $this->order_items['L_PAYMENTREQUEST_0_ITEMCATEGORY0'] = 'Physical';
         // Item's sales S/H and tax amount.
-        $this->order_items['PAYMENTREQUEST_0_ITEMAMT']     = $this->gateway_data_formatter->formatCurrency(
+        $this->order_items['PAYMENTREQUEST_0_ITEMAMT'] = $this->gateway_data_formatter->formatCurrency(
             $this->payment->amount(),
             $this->decimal_precision
         );
@@ -206,7 +206,7 @@ 
                 if (EEH_Money::compare_floats($line_item->pretaxTotal(), '0.00', '==')) {
                     continue;
                 }
-                $unit_price         = $this->gateway_data_formatter->formatCurrency(
+                $unit_price = $this->gateway_data_formatter->formatCurrency(
                     $line_item->unit_price(),
                     $this->decimal_precision
                 );
@@ -217,25 +217,25 @@ 
                     $line_item_quantity = 1;
                 }
                 // Item Name.
-                $this->order_items[ "L_PAYMENTREQUEST_0_NAME{$item_num}" ] = mb_strcut(
+                $this->order_items["L_PAYMENTREQUEST_0_NAME{$item_num}"] = mb_strcut(
                     $this->gateway_data_formatter->formatLineItemName($line_item, $this->payment),
                     0,
                     127
                 );
                 // Item description.
-                $this->order_items[ "L_PAYMENTREQUEST_0_DESC{$item_num}" ] = mb_strcut(
+                $this->order_items["L_PAYMENTREQUEST_0_DESC{$item_num}"] = mb_strcut(
                     $this->gateway_data_formatter->formatLineItemDesc($line_item, $this->payment),
                     0,
                     127
                 );
                 // Cost of individual item.
-                $this->order_items[ "L_PAYMENTREQUEST_0_AMT{$item_num}" ] = $unit_price;
+                $this->order_items["L_PAYMENTREQUEST_0_AMT{$item_num}"] = $unit_price;
                 // Item Number.
-                $this->order_items[ "L_PAYMENTREQUEST_0_NUMBER{$item_num}" ] = $item_num + 1;
+                $this->order_items["L_PAYMENTREQUEST_0_NUMBER{$item_num}"] = $item_num + 1;
                 // Item quantity.
-                $this->order_items[ "L_PAYMENTREQUEST_0_QTY{$item_num}" ] = $line_item_quantity;
+                $this->order_items["L_PAYMENTREQUEST_0_QTY{$item_num}"] = $line_item_quantity;
                 // Digital item is sold.
-                $this->order_items[ "L_PAYMENTREQUEST_0_ITEMCATEGORY{$item_num}" ] = 'Physical';
+                $this->order_items["L_PAYMENTREQUEST_0_ITEMCATEGORY{$item_num}"] = 'Physical';
                 // add item total to order sum
                 $this->itemized_order_sum += $unit_price * $line_item_quantity;
                 ++$item_num;
@@ -281,7 +281,7 @@ 
         // add the difference as an extra line item.
         if (EEH_Money::compare_floats($itemized_order_sum_difference, 0, '!=')) {
             // Item Name.
-            $this->order_items[ "L_PAYMENTREQUEST_0_NAME{$item_num}" ] = mb_strcut(
+            $this->order_items["L_PAYMENTREQUEST_0_NAME{$item_num}"] = mb_strcut(
                 esc_html__(
                     'Other (promotion/surcharge/cancellation)',
                     'event_espresso'
@@ -290,18 +290,18 @@ 
                 127
             );
             // Item description.
-            $this->order_items[ "L_PAYMENTREQUEST_0_DESC{$item_num}" ] = '';
+            $this->order_items["L_PAYMENTREQUEST_0_DESC{$item_num}"] = '';
             // Cost of individual item.
-            $this->order_items[ "L_PAYMENTREQUEST_0_AMT{$item_num}" ] = $this->gateway_data_formatter->formatCurrency(
+            $this->order_items["L_PAYMENTREQUEST_0_AMT{$item_num}"] = $this->gateway_data_formatter->formatCurrency(
                 $itemized_order_sum_difference,
                 $this->decimal_precision
             );
             // Item Number.
-            $this->order_items[ "L_PAYMENTREQUEST_0_NUMBER{$item_num}" ] = $item_num + 1;
+            $this->order_items["L_PAYMENTREQUEST_0_NUMBER{$item_num}"] = $item_num + 1;
             // Item quantity.
-            $this->order_items[ "L_PAYMENTREQUEST_0_QTY{$item_num}" ] = 1;
+            $this->order_items["L_PAYMENTREQUEST_0_QTY{$item_num}"] = 1;
             // Digital item is sold.
-            $this->order_items[ "L_PAYMENTREQUEST_0_ITEMCATEGORY{$item_num}" ] = 'Physical';
+            $this->order_items["L_PAYMENTREQUEST_0_ITEMCATEGORY{$item_num}"] = 'Physical';
         }
     }
 }

payment_methods/Paypal_Express/TokenRequest.php

Indentation +113 added lines, -113 removed lines

@@ -13,124 +13,124 @@
 class TokenRequest
 {
 
-    /**
-     * @var GatewayDataFormatterInterface
-     */
-    protected $gateway_data_formatter;
+	/**
+	 * @var GatewayDataFormatterInterface
+	 */
+	protected $gateway_data_formatter;
 
 
-    /**
-     * @param GatewayDataFormatterInterface $gateway_data_formatter
-     */
-    public function __construct(GatewayDataFormatterInterface $gateway_data_formatter)
-    {
-        $this->gateway_data_formatter = $gateway_data_formatter;
-    }
+	/**
+	 * @param GatewayDataFormatterInterface $gateway_data_formatter
+	 */
+	public function __construct(GatewayDataFormatterInterface $gateway_data_formatter)
+	{
+		$this->gateway_data_formatter = $gateway_data_formatter;
+	}
 
 
-    /**
-     * @param EE_Payment $payment
-     * @param array      $itemized_order
-     * @param string     $return_url
-     * @param string     $cancel_url
-     * @param string     $logo_image_url
-     * @param bool       $request_shipping_address
-     * @return array
-     * @throws EE_Error
-     * @throws ReflectionException
-     */
-    public function generateDetails(
-        EE_Payment $payment,
-        array $itemized_order = [],
-        string $return_url = '',
-        string $cancel_url = '',
-        string $logo_image_url = '',
-        bool $request_shipping_address = false
-    ): array {
-        $locale = explode('-', get_bloginfo('language'));
-        // Gather request parameters.
-        $token_request_details = [
-            'METHOD'                         => 'SetExpressCheckout',
-            'PAYMENTREQUEST_0_AMT'           => $payment->amount(),
-            'PAYMENTREQUEST_0_CURRENCYCODE'  => $payment->currency_code(),
-            'PAYMENTREQUEST_0_DESC'          => mb_strcut(
-                $this->gateway_data_formatter->formatOrderDescription($payment),
-                0,
-                127
-            ),
-            'RETURNURL'                      => $return_url,
-            'CANCELURL'                      => $cancel_url,
-            'PAYMENTREQUEST_0_PAYMENTACTION' => 'Sale',
-            // Buyer does not need to create a PayPal account to check out.
-            // This is referred to as PayPal Account Optional.
-            'SOLUTIONTYPE'                   => 'Sole',
-            // Locale of the pages displayed by PayPal during Express Checkout.
-            'LOCALECODE'                     => $locale[1],
-        ];
-        $token_request_details = array_merge($token_request_details, $itemized_order);
-        if (! $request_shipping_address) {
-            // Do not request shipping details on the PP Checkout page.
-            $token_request_details['NOSHIPPING']         = '1';
-            $token_request_details['REQCONFIRMSHIPPING'] = '0';
-        } else {
-            // Automatically filling out shipping and contact information.
-            $transaction          = $payment->transaction();
-            $primary_registration = $transaction->primary_registration();
-            $primary_attendee     = $primary_registration instanceof EE_Registration
-                ? $primary_registration->attendee()
-                : false;
-            if ($primary_attendee instanceof EE_Attendee) {
-                // If you do not pass the shipping address, PayPal obtains it from the buyer's account profile.
-                $token_request_details['NOSHIPPING']                         = '2';
-                $token_request_details['PAYMENTREQUEST_0_SHIPTOSTREET']      = $primary_attendee->address();
-                $token_request_details['PAYMENTREQUEST_0_SHIPTOSTREET2']     = $primary_attendee->address2();
-                $token_request_details['PAYMENTREQUEST_0_SHIPTOCITY']        = $primary_attendee->city();
-                $token_request_details['PAYMENTREQUEST_0_SHIPTOSTATE']       = $primary_attendee->state_abbrev();
-                $token_request_details['PAYMENTREQUEST_0_SHIPTOCOUNTRYCODE'] = $primary_attendee->country_ID();
-                $token_request_details['PAYMENTREQUEST_0_SHIPTOZIP']         = $primary_attendee->zip();
-                $token_request_details['PAYMENTREQUEST_0_EMAIL']             = $primary_attendee->email();
-                $token_request_details['PAYMENTREQUEST_0_SHIPTOPHONENUM']    = $primary_attendee->phone();
-            }
-        }
-        // Used a business/personal logo on the PayPal page.
-        if (! empty($logo_image_url)) {
-            $token_request_details['LOGOIMG'] = $logo_image_url;
-        }
-        return $token_request_details;
-    }
+	/**
+	 * @param EE_Payment $payment
+	 * @param array      $itemized_order
+	 * @param string     $return_url
+	 * @param string     $cancel_url
+	 * @param string     $logo_image_url
+	 * @param bool       $request_shipping_address
+	 * @return array
+	 * @throws EE_Error
+	 * @throws ReflectionException
+	 */
+	public function generateDetails(
+		EE_Payment $payment,
+		array $itemized_order = [],
+		string $return_url = '',
+		string $cancel_url = '',
+		string $logo_image_url = '',
+		bool $request_shipping_address = false
+	): array {
+		$locale = explode('-', get_bloginfo('language'));
+		// Gather request parameters.
+		$token_request_details = [
+			'METHOD'                         => 'SetExpressCheckout',
+			'PAYMENTREQUEST_0_AMT'           => $payment->amount(),
+			'PAYMENTREQUEST_0_CURRENCYCODE'  => $payment->currency_code(),
+			'PAYMENTREQUEST_0_DESC'          => mb_strcut(
+				$this->gateway_data_formatter->formatOrderDescription($payment),
+				0,
+				127
+			),
+			'RETURNURL'                      => $return_url,
+			'CANCELURL'                      => $cancel_url,
+			'PAYMENTREQUEST_0_PAYMENTACTION' => 'Sale',
+			// Buyer does not need to create a PayPal account to check out.
+			// This is referred to as PayPal Account Optional.
+			'SOLUTIONTYPE'                   => 'Sole',
+			// Locale of the pages displayed by PayPal during Express Checkout.
+			'LOCALECODE'                     => $locale[1],
+		];
+		$token_request_details = array_merge($token_request_details, $itemized_order);
+		if (! $request_shipping_address) {
+			// Do not request shipping details on the PP Checkout page.
+			$token_request_details['NOSHIPPING']         = '1';
+			$token_request_details['REQCONFIRMSHIPPING'] = '0';
+		} else {
+			// Automatically filling out shipping and contact information.
+			$transaction          = $payment->transaction();
+			$primary_registration = $transaction->primary_registration();
+			$primary_attendee     = $primary_registration instanceof EE_Registration
+				? $primary_registration->attendee()
+				: false;
+			if ($primary_attendee instanceof EE_Attendee) {
+				// If you do not pass the shipping address, PayPal obtains it from the buyer's account profile.
+				$token_request_details['NOSHIPPING']                         = '2';
+				$token_request_details['PAYMENTREQUEST_0_SHIPTOSTREET']      = $primary_attendee->address();
+				$token_request_details['PAYMENTREQUEST_0_SHIPTOSTREET2']     = $primary_attendee->address2();
+				$token_request_details['PAYMENTREQUEST_0_SHIPTOCITY']        = $primary_attendee->city();
+				$token_request_details['PAYMENTREQUEST_0_SHIPTOSTATE']       = $primary_attendee->state_abbrev();
+				$token_request_details['PAYMENTREQUEST_0_SHIPTOCOUNTRYCODE'] = $primary_attendee->country_ID();
+				$token_request_details['PAYMENTREQUEST_0_SHIPTOZIP']         = $primary_attendee->zip();
+				$token_request_details['PAYMENTREQUEST_0_EMAIL']             = $primary_attendee->email();
+				$token_request_details['PAYMENTREQUEST_0_SHIPTOPHONENUM']    = $primary_attendee->phone();
+			}
+		}
+		// Used a business/personal logo on the PayPal page.
+		if (! empty($logo_image_url)) {
+			$token_request_details['LOGOIMG'] = $logo_image_url;
+		}
+		return $token_request_details;
+	}
 
 
-    /**
-     * @param EE_Payment $payment
-     * @param array      $token_request_status
-     * @param bool       $is_in_sandbox_mode
-     * @throws EE_Error
-     * @throws ReflectionException
-     */
-    public function processResponse(EE_Payment $payment, array $token_request_status, bool $is_in_sandbox_mode)
-    {
-        $response_args = (isset($token_request_status['args']) && is_array($token_request_status['args']))
-            ? $token_request_status['args']
-            : [];
-        if ($token_request_status['status']) {
-            // We got the Token so we may continue with the payment and redirect the client.
-            $payment->set_details($response_args);
-            $gateway_url = $is_in_sandbox_mode ? 'https://www.sandbox.paypal.com' : 'https://www.paypal.com';
-            $token       = $response_args['TOKEN'];
-            $payment->set_redirect_url(
-                "{$gateway_url}/checkoutnow?useraction=commit&cmd=_express-checkout&token={$token}"
-            );
-            return;
-        }
-        $gateway_response = isset($response_args['L_ERRORCODE'])
-            ? $response_args['L_ERRORCODE'] . '; ' . $response_args['L_SHORTMESSAGE']
-            : esc_html__(
-                'Error occurred while trying to setup the Express Checkout.',
-                'event_espresso'
-            );
+	/**
+	 * @param EE_Payment $payment
+	 * @param array      $token_request_status
+	 * @param bool       $is_in_sandbox_mode
+	 * @throws EE_Error
+	 * @throws ReflectionException
+	 */
+	public function processResponse(EE_Payment $payment, array $token_request_status, bool $is_in_sandbox_mode)
+	{
+		$response_args = (isset($token_request_status['args']) && is_array($token_request_status['args']))
+			? $token_request_status['args']
+			: [];
+		if ($token_request_status['status']) {
+			// We got the Token so we may continue with the payment and redirect the client.
+			$payment->set_details($response_args);
+			$gateway_url = $is_in_sandbox_mode ? 'https://www.sandbox.paypal.com' : 'https://www.paypal.com';
+			$token       = $response_args['TOKEN'];
+			$payment->set_redirect_url(
+				"{$gateway_url}/checkoutnow?useraction=commit&cmd=_express-checkout&token={$token}"
+			);
+			return;
+		}
+		$gateway_response = isset($response_args['L_ERRORCODE'])
+			? $response_args['L_ERRORCODE'] . '; ' . $response_args['L_SHORTMESSAGE']
+			: esc_html__(
+				'Error occurred while trying to setup the Express Checkout.',
+				'event_espresso'
+			);
 
-        $payment->set_gateway_response($gateway_response);
-        $payment->set_details($response_args);
-        $payment->set_status(EEM_Payment::instance()->failed_status());
-    }
+		$payment->set_gateway_response($gateway_response);
+		$payment->set_details($response_args);
+		$payment->set_status(EEM_Payment::instance()->failed_status());
+	}
 }

Spacing +3 added lines, -3 removed lines

@@ -68,7 +68,7 @@ 
             'LOCALECODE'                     => $locale[1],
         ];
         $token_request_details = array_merge($token_request_details, $itemized_order);
-        if (! $request_shipping_address) {
+        if ( ! $request_shipping_address) {
             // Do not request shipping details on the PP Checkout page.
             $token_request_details['NOSHIPPING']         = '1';
             $token_request_details['REQCONFIRMSHIPPING'] = '0';
@@ -93,7 +93,7 @@ 
             }
         }
         // Used a business/personal logo on the PayPal page.
-        if (! empty($logo_image_url)) {
+        if ( ! empty($logo_image_url)) {
             $token_request_details['LOGOIMG'] = $logo_image_url;
         }
         return $token_request_details;
@@ -123,7 +123,7 @@ 
             return;
         }
         $gateway_response = isset($response_args['L_ERRORCODE'])
-            ? $response_args['L_ERRORCODE'] . '; ' . $response_args['L_SHORTMESSAGE']
+            ? $response_args['L_ERRORCODE'].'; '.$response_args['L_SHORTMESSAGE']
             : esc_html__(
                 'Error occurred while trying to setup the Express Checkout.',
                 'event_espresso'

payment_methods/Paypal_Express/polyfills.php

Indentation +14 added lines, -14 removed lines

@@ -1,18 +1,18 @@
 <?php
 
 if (! function_exists('mb_strcut')) {
-    /**
-     * Quickfix to address https://events.codebasehq.com/projects/event-espresso/tickets/11089 ASAP
-     * Very simple mimic of mb_substr (which WP ensures exists in wp-includes/compat.php). Still has all the problems of mb_substr
-     * (namely, that we might send too many characters to PayPal; however in this case they just issue a warning but nothing breaks)
-     *
-     * @param $string
-     * @param $start
-     * @param $length
-     * @return string
-     */
-    function mb_strcut($string, $start, $length = null): string
-    {
-        return mb_substr($string, $start, $length);
-    }
+	/**
+	 * Quickfix to address https://events.codebasehq.com/projects/event-espresso/tickets/11089 ASAP
+	 * Very simple mimic of mb_substr (which WP ensures exists in wp-includes/compat.php). Still has all the problems of mb_substr
+	 * (namely, that we might send too many characters to PayPal; however in this case they just issue a warning but nothing breaks)
+	 *
+	 * @param $string
+	 * @param $start
+	 * @param $length
+	 * @return string
+	 */
+	function mb_strcut($string, $start, $length = null): string
+	{
+		return mb_substr($string, $start, $length);
+	}
 }

Spacing +1 added lines, -1 removed lines

@@ -1,6 +1,6 @@
 <?php
 
-if (! function_exists('mb_strcut')) {
+if ( ! function_exists('mb_strcut')) {
     /**
      * Quickfix to address https://events.codebasehq.com/projects/event-espresso/tickets/11089 ASAP
      * Very simple mimic of mb_substr (which WP ensures exists in wp-includes/compat.php). Still has all the problems of mb_substr

payment_methods/Paypal_Standard/EEG_Paypal_Standard.gateway.php

Indentation +550 added lines, -550 removed lines

@@ -20,554 +20,554 @@
 class EEG_Paypal_Standard extends EE_Offsite_Gateway
 {
 
-    /**
-     * Name for the wp option used to save the itemized payment
-     */
-    const itemized_payment_option_name = '_itemized_payment';
-
-    protected $_paypal_id;
-
-    protected $_image_url;
-
-    protected $_shipping_details;
-
-    protected $_paypal_shipping;
-
-    protected $_paypal_taxes;
-
-    protected $_gateway_url;
-
-    protected $_currencies_supported = array(
-        'USD',
-        'GBP',
-        'CAD',
-        'AUD',
-        'BRL',
-        'CHF',
-        'CZK',
-        'DKK',
-        'EUR',
-        'HKD',
-        'HUF',
-        'ILS',
-        'JPY',
-        'MXN',
-        'MYR',
-        'NOK',
-        'NZD',
-        'PHP',
-        'PLN',
-        'SEK',
-        'SGD',
-        'THB',
-        'TRY',
-        'TWD',
-        'RUB'
-    );
-
-    /**
-     * @var ItemizedOrder
-     * @since $VID:$
-     */
-    protected $itemized_order;
-
-
-    /**
-     * EEG_Paypal_Standard constructor.
-     */
-    public function __construct()
-    {
-        $this->set_uses_separate_IPN_request(true);
-        parent::__construct();
-    }
-
-
-    /**
-     * @return mixed
-     */
-    public function gatewayUrl()
-    {
-        return $this->_gateway_url;
-    }
-
-
-    /**
-     * @return mixed
-     */
-    public function imageUrl()
-    {
-        return $this->_image_url;
-    }
-
-
-    /**
-     * @return mixed
-     */
-    public function paypalId()
-    {
-        return $this->_paypal_id;
-    }
-
-
-    /**
-     * @return mixed
-     */
-    public function paypalShipping()
-    {
-        return $this->_paypal_shipping;
-    }
-
-
-
-    /**
-     * @return mixed
-     */
-    public function paypalTaxes()
-    {
-        return $this->_paypal_taxes;
-    }
-
-
-    /**
-     * @return mixed
-     */
-    public function shippingDetails()
-    {
-        return $this->_shipping_details;
-    }
-
-
-    /**
-     * Also sets the gateway url class variable based on whether debug mode is enabled or not.
-     *
-     * @param array $settings_array
-     */
-    public function set_settings($settings_array)
-    {
-        parent::set_settings($settings_array);
-        $this->_gateway_url = $this->_debug_mode
-            ? 'https://www.sandbox.paypal.com/cgi-bin/webscr'
-            : 'https://www.paypal.com/cgi-bin/webscr';
-    }
-
-
-    /**
-     * @param EEI_Payment $payment      the payment to process
-     * @param array       $billing_info but should be empty for this gateway
-     * @param string      $return_url   URL to send the user to after payment on the payment provider's website
-     * @param string      $notify_url   URL to send the instant payment notification
-     * @param string      $cancel_url   URL to send the user to after a cancelled payment attempt
-     *                                  on the payment provider's website
-     * @return EEI_Payment
-     * @throws EE_Error
-     * @throws ReflectionException
-     */
-    public function set_redirection_info(
-        $payment,
-        $billing_info = array(),
-        $return_url = null,
-        $notify_url = null,
-        $cancel_url = null
-    ) {
-        $this->itemized_order = new ItemizedOrder($this->_get_gateway_formatter(), $this);
-        $redirect_args = apply_filters(
-            "FHEE__EEG_Paypal_Standard__set_redirection_info__arguments",
-            $this->itemized_order->generateItemizedOrderForPayment(
-                $payment,
-                $return_url,
-                $notify_url,
-                $cancel_url
-            ),
-            $this
-        );
-
-        $payment->set_redirect_url($this->_gateway_url);
-        $payment->set_redirect_args($redirect_args);
-        // log the results
-        $this->log(
-            array(
-                'message'     => esc_html__('PayPal payment request initiated.', 'event_espresso'),
-                'transaction' => $payment->transaction()->model_field_array(),
-            ),
-            $payment
-        );
-        return $payment;
-    }
-
-
-    /**
-     * Often used for IPNs. But applies the info in $update_info to the payment.
-     * What is $update_info? Often the contents of $_REQUEST, but not necessarily. Whatever
-     * the payment method passes in.
-     *
-     * @param array $update_info like $_POST
-     * @param EEI_Transaction $transaction
-     * @return EEI_Payment updated
-     * @throws EE_Error, IpnException
-     */
-    public function handle_payment_update($update_info, $transaction)
-    {
-        // verify there's payment data that's been sent
-        if (empty($update_info['payment_status']) || empty($update_info['txn_id'])) {
-            // log the results
-            $this->log(
-                array(
-                    'message'     => esc_html__(
-                        'PayPal IPN response is missing critical payment data. This may indicate a PDT request and require your PayPal account settings to be corrected.',
-                        'event_espresso'
-                    ),
-                    'update_info' => $update_info,
-                ),
-                $transaction
-            );
-            // waaaait... is this a PDT request? (see https://developer.paypal.com/docs/classic/products/payment-data-transfer/)
-            // indicated by the "tx" argument? If so, we don't need it. We'll just use the IPN data when it comes
-            if (isset($update_info['tx'])) {
-                return $transaction->last_payment();
-            } else {
-                return null;
-            }
-        }
-        $payment = $this->_pay_model->get_payment_by_txn_id_chq_nmbr($update_info['txn_id']);
-        if (! $payment instanceof EEI_Payment) {
-            $payment = $transaction->last_payment();
-        }
-        // ok, then validate the IPN. Even if we've already processed this payment,
-        // let PayPal know we don't want to hear from them anymore!
-        if (! $this->validate_ipn($update_info, $payment)) {
-            return $payment;
-        }
-        // kill request here if this is a refund, we don't support them yet (we'd need to adjust the transaction,
-        // registrations, ticket counts, etc)
-        if (
-            (
-                $update_info['payment_status'] === 'Refunded'
-                || $update_info['payment_status'] === 'Partially_Refunded'
-            )
-            && apply_filters('FHEE__EEG_Paypal_Standard__handle_payment_update__kill_refund_request', true)
-        ) {
-            throw new EventEspresso\core\exceptions\IpnException(
-                sprintf(
-                    esc_html__('Event Espresso does not yet support %1$s IPNs from PayPal', 'event_espresso'),
-                    $update_info['payment_status']
-                ),
-                EventEspresso\core\exceptions\IpnException::UNSUPPORTED,
-                null,
-                $payment,
-                $update_info
-            );
-        }
-        // ok, well let's process this payment then!
-        switch ($update_info['payment_status']) {
-            case 'Completed':
-                $status = $this->_pay_model->approved_status();
-                $gateway_response = esc_html__('The payment is approved.', 'event_espresso');
-                break;
-
-            case 'Pending':
-                $status = $this->_pay_model->pending_status();
-                $gateway_response = esc_html__(
-                    'The payment is in progress. Another message will be sent when payment is approved.',
-                    'event_espresso'
-                );
-                break;
-
-            case 'Denied':
-                $status = $this->_pay_model->declined_status();
-                $gateway_response = esc_html__('The payment has been declined.', 'event_espresso');
-                break;
-
-            case 'Expired':
-            case 'Failed':
-                $status = $this->_pay_model->failed_status();
-                $gateway_response = esc_html__('The payment failed for technical reasons or expired.', 'event_espresso');
-                break;
-
-            case 'Refunded':
-            case 'Partially_Refunded':
-                // even though it's a refund, we consider the payment as approved, it just has a negative value
-                $status = $this->_pay_model->approved_status();
-                $gateway_response = esc_html__(
-                    'The payment has been refunded. Please update registrations accordingly.',
-                    'event_espresso'
-                );
-                break;
-
-            case 'Voided':
-            case 'Reversed':
-            case 'Canceled_Reversal':
-            default:
-                $status = $this->_pay_model->cancelled_status();
-                $gateway_response = esc_html__(
-                    'The payment was cancelled, reversed, or voided. Please update registrations accordingly.',
-                    'event_espresso'
-                );
-                break;
-        }
-
-        // check if we've already processed this payment
-        if ($payment instanceof EEI_Payment) {
-            // payment exists. if this has the exact same status and amount, don't bother updating. just return
-            if ($payment->status() === $status && $payment->amount() === (float) $update_info['mc_gross']) {
-                // DUPLICATED IPN! don't bother updating transaction
-                throw new IpnException(
-                    sprintf(
-                        esc_html__(
-                            'It appears we have received a duplicate IPN from PayPal for payment %d',
-                            'event_espresso'
-                        ),
-                        $payment->ID()
-                    ),
-                    IpnException::DUPLICATE,
-                    null,
-                    $payment,
-                    $update_info
-                );
-            } else {
-                // new payment yippee !!!
-                $payment->set_status($status);
-                $payment->set_amount((float) $update_info['mc_gross']);
-                $payment->set_gateway_response($gateway_response);
-                $payment->set_details($update_info);
-                $payment->set_txn_id_chq_nmbr($update_info['txn_id']);
-                $this->log(
-                    array(
-                        'message'  => esc_html__(
-                            'Updated payment either from IPN or as part of POST from PayPal',
-                            'event_espresso'
-                        ),
-                        'url'      => $this->_process_response_url(),
-                        'payment'  => $payment->model_field_array(),
-                        'IPN_data' => $update_info
-                    ),
-                    $payment
-                );
-            }
-        }
-        do_action('FHEE__EEG_Paypal_Standard__handle_payment_update__payment_processed', $payment, $this);
-        return $payment;
-    }
-
-
-    /**
-     * Validate the IPN notification.
-     *
-     * @param array                  $update_info like $_REQUEST
-     * @param EE_Payment|EEI_Payment $payment
-     * @return boolean
-     * @throws EE_Error
-     */
-    public function validate_ipn($update_info, $payment)
-    {
-        // allow us to skip validating IPNs with PayPal (useful for testing)
-        if (apply_filters('FHEE__EEG_Paypal_Standard__validate_ipn__skip', false)) {
-            return true;
-        }
-        // ...otherwise, we actually don't care what the $update_info is, we need to look
-        // at the request directly because we can't use $update_info because it has issues with quotes
-        // Reading POSTed data directly from $_POST causes serialization issues with array data in the POST.
-        // Instead, read raw POST data from the input stream.
-        // @see https://gist.github.com/xcommerce-gists/3440401
-        $raw_post_data = file_get_contents('php://input');
-        $raw_post_array = explode('&', $raw_post_data);
-        $update_info = array();
-        foreach ($raw_post_array as $keyval) {
-            $keyval = explode('=', $keyval);
-            if (count($keyval) === 2) {
-                $update_info[ $keyval[0] ] = urldecode($keyval[1]);
-            }
-        }
-        // read the IPN message sent from PayPal and prepend 'cmd=_notify-validate'
-        $req = 'cmd=_notify-validate';
-        $uses_get_magic_quotes = function_exists('get_magic_quotes_gpc') && get_magic_quotes_gpc() === 1;
-        foreach ($update_info as $key => $value) {
-            $value = $uses_get_magic_quotes ? urlencode(stripslashes($value)) : urlencode($value);
-            $req .= "&$key=$value";
-        }
-        // HTTP POST the complete, unaltered IPN back to PayPal
-        $response = wp_remote_post(
-            $this->_gateway_url,
-            array(
-                'body'              => $req,
-                'sslverify'         => false,
-                'timeout'           => 60,
-                // make sure to set a site specific unique "user-agent" string since the WordPres default gets declined by PayPal
-                // plz see: https://github.com/websharks/s2member/issues/610
-                'user-agent'        => 'Event Espresso v' . EVENT_ESPRESSO_VERSION . '; ' . home_url(),
-                'httpversion'       => '1.1'
-            )
-        );
-        // then check the response
-        if (
-            array_key_exists('body', $response)
-            && ! is_wp_error($response)
-            && strcmp($response['body'], "VERIFIED") === 0
-        ) {
-            return true;
-        }
-        // huh, something's wack... the IPN didn't validate. We must have replied to the IPN incorrectly,
-        // or their API must have changed: http://www.paypalobjects.com/en_US/ebook/PP_OrderManagement_IntegrationGuide/ipn.html
-        if ($response instanceof WP_Error) {
-            $error_msg = sprintf(
-                esc_html__('WP Error. Code: "%1$s", Message: "%2$s", Data: "%3$s"', 'event_espresso'),
-                $response->get_error_code(),
-                $response->get_error_message(),
-                print_r($response->get_error_data(), true)
-            );
-        } elseif (is_array($response) && isset($response['body'])) {
-            $error_msg = $response['body'];
-        } else {
-            $error_msg = print_r($response, true);
-        }
-        $payment->set_gateway_response(
-            sprintf(
-                esc_html__("IPN Validation failed! Paypal responded with '%s'", "event_espresso"),
-                $error_msg
-            )
-        );
-        $payment->set_details(array('REQUEST' => $update_info, 'VALIDATION_RESPONSE' => $response));
-        $payment->set_status(EEM_Payment::status_id_failed);
-        // log the results
-        $this->log(
-            array(
-                'url'     => $this->_process_response_url(),
-                'message' => $payment->gateway_response(),
-                'details' => $payment->details(),
-            ),
-            $payment
-        );
-        return false;
-    }
-
-
-    /**
-     * _process_response_url
-     * @return string
-     */
-    protected function _process_response_url(): string
-    {
-        if (isset($_SERVER['HTTP_HOST'], $_SERVER['REQUEST_URI'])) {
-            $url = is_ssl() ? 'https://' : 'http://';
-            $url .= EEH_URL::filter_input_server_url('HTTP_HOST');
-            $url .= EEH_URL::filter_input_server_url();
-        } else {
-            $url = 'unknown';
-        }
-        return $url;
-    }
-
-
-    /**
-     * Updates the transaction and line items based on the payment IPN data from PayPal,
-     * like the taxes or shipping
-     *
-     * @param EEI_Payment $payment
-     * @throws EE_Error
-     * @throws ReflectionException
-     */
-    public function update_txn_based_on_payment($payment)
-    {
-        $update_info = $payment->details();
-        /** @var EE_Transaction $transaction */
-        $transaction = $payment->transaction();
-        $payment_was_itemized = $payment->get_extra_meta(EEG_Paypal_Standard::itemized_payment_option_name, true, false);
-        if (! $transaction) {
-            $this->log(
-                esc_html__(
-                    // @codingStandardsIgnoreStart
-                    'Payment with ID %d has no related transaction, and so update_txn_based_on_payment couldn\'t be executed properly',
-                    // @codingStandardsIgnoreEnd
-                    'event_espresso'
-                ),
-                $payment
-            );
-            return;
-        }
-        if (
-            ! is_array($update_info)
-            || ! isset($update_info['mc_shipping'])
-            || ! isset($update_info['tax'])
-        ) {
-            $this->log(
-                array(
-                    'message' => esc_html__(
-                        // @codingStandardsIgnoreStart
-                        'Could not update transaction based on payment because the payment details have not yet been put on the payment. This normally happens during the IPN or returning from PayPal',
-                        // @codingStandardsIgnoreEnd
-                        'event_espresso'
-                    ),
-                    'url'     => $this->_process_response_url(),
-                    'payment' => $payment->model_field_array()
-                ),
-                $payment
-            );
-            return;
-        }
-        if ($payment->status() !== $this->_pay_model->approved_status()) {
-            $this->log(
-                array(
-                    'message' => esc_html__(
-                        'We shouldn\'t update transactions taxes or shipping data from non-approved payments',
-                        'event_espresso'
-                    ),
-                    'url'     => $this->_process_response_url(),
-                    'payment' => $payment->model_field_array()
-                ),
-                $payment
-            );
-            return;
-        }
-        $grand_total_needs_resaving = false;
-        /** @var EE_Line_Item $transaction_total_line_item */
-        $transaction_total_line_item = $transaction->total_line_item();
-
-        // might paypal have changed the taxes?
-        if ($this->_paypal_taxes && $payment_was_itemized) {
-            // note that we're doing this BEFORE adding shipping;
-            // we actually want PayPal's shipping to remain non-taxable
-            $this->_line_item->set_line_items_taxable($transaction_total_line_item, true, 'paypal_shipping');
-            $this->_line_item->set_total_tax_to(
-                $transaction_total_line_item,
-                (float) $update_info['tax'],
-                esc_html__('Taxes', 'event_espresso'),
-                esc_html__('Calculated by Paypal', 'event_espresso'),
-                'paypal_tax'
-            );
-            $grand_total_needs_resaving = true;
-        }
-
-        $shipping_amount = (float) $update_info['mc_shipping'];
-        // might paypal have added shipping?
-        if ($this->_paypal_shipping && $shipping_amount && $payment_was_itemized) {
-            $this->_line_item->add_unrelated_item(
-                $transaction_total_line_item,
-                sprintf(esc_html__('Shipping for transaction %1$s', 'event_espresso'), $transaction->ID()),
-                $shipping_amount,
-                esc_html__('Shipping charges calculated by Paypal', 'event_espresso'),
-                1,
-                false,
-                'paypal_shipping_' . $transaction->ID()
-            );
-            $grand_total_needs_resaving = true;
-        }
-
-        if ($grand_total_needs_resaving) {
-            $transaction_total_line_item->save_this_and_descendants_to_txn($transaction->ID());
-            /** @var EE_Registration_Processor $registration_processor */
-            $registration_processor = EE_Registry::instance()->load_class('Registration_Processor');
-            $registration_processor->update_registration_final_prices($transaction);
-        }
-        $this->log(
-            array(
-                'message'                     => esc_html__('Updated transaction related to payment', 'event_espresso'),
-                'url'                         => $this->_process_response_url(),
-                'transaction (updated)'       => $transaction->model_field_array(),
-                'payment (updated)'           => $payment->model_field_array(),
-                'use_paypal_shipping'         => $this->_paypal_shipping,
-                'use_paypal_tax'              => $this->_paypal_taxes,
-                'grand_total_needed_resaving' => $grand_total_needs_resaving,
-            ),
-            $payment
-        );
-    }
+	/**
+	 * Name for the wp option used to save the itemized payment
+	 */
+	const itemized_payment_option_name = '_itemized_payment';
+
+	protected $_paypal_id;
+
+	protected $_image_url;
+
+	protected $_shipping_details;
+
+	protected $_paypal_shipping;
+
+	protected $_paypal_taxes;
+
+	protected $_gateway_url;
+
+	protected $_currencies_supported = array(
+		'USD',
+		'GBP',
+		'CAD',
+		'AUD',
+		'BRL',
+		'CHF',
+		'CZK',
+		'DKK',
+		'EUR',
+		'HKD',
+		'HUF',
+		'ILS',
+		'JPY',
+		'MXN',
+		'MYR',
+		'NOK',
+		'NZD',
+		'PHP',
+		'PLN',
+		'SEK',
+		'SGD',
+		'THB',
+		'TRY',
+		'TWD',
+		'RUB'
+	);
+
+	/**
+	 * @var ItemizedOrder
+	 * @since $VID:$
+	 */
+	protected $itemized_order;
+
+
+	/**
+	 * EEG_Paypal_Standard constructor.
+	 */
+	public function __construct()
+	{
+		$this->set_uses_separate_IPN_request(true);
+		parent::__construct();
+	}
+
+
+	/**
+	 * @return mixed
+	 */
+	public function gatewayUrl()
+	{
+		return $this->_gateway_url;
+	}
+
+
+	/**
+	 * @return mixed
+	 */
+	public function imageUrl()
+	{
+		return $this->_image_url;
+	}
+
+
+	/**
+	 * @return mixed
+	 */
+	public function paypalId()
+	{
+		return $this->_paypal_id;
+	}
+
+
+	/**
+	 * @return mixed
+	 */
+	public function paypalShipping()
+	{
+		return $this->_paypal_shipping;
+	}
+
+
+
+	/**
+	 * @return mixed
+	 */
+	public function paypalTaxes()
+	{
+		return $this->_paypal_taxes;
+	}
+
+
+	/**
+	 * @return mixed
+	 */
+	public function shippingDetails()
+	{
+		return $this->_shipping_details;
+	}
+
+
+	/**
+	 * Also sets the gateway url class variable based on whether debug mode is enabled or not.
+	 *
+	 * @param array $settings_array
+	 */
+	public function set_settings($settings_array)
+	{
+		parent::set_settings($settings_array);
+		$this->_gateway_url = $this->_debug_mode
+			? 'https://www.sandbox.paypal.com/cgi-bin/webscr'
+			: 'https://www.paypal.com/cgi-bin/webscr';
+	}
+
+
+	/**
+	 * @param EEI_Payment $payment      the payment to process
+	 * @param array       $billing_info but should be empty for this gateway
+	 * @param string      $return_url   URL to send the user to after payment on the payment provider's website
+	 * @param string      $notify_url   URL to send the instant payment notification
+	 * @param string      $cancel_url   URL to send the user to after a cancelled payment attempt
+	 *                                  on the payment provider's website
+	 * @return EEI_Payment
+	 * @throws EE_Error
+	 * @throws ReflectionException
+	 */
+	public function set_redirection_info(
+		$payment,
+		$billing_info = array(),
+		$return_url = null,
+		$notify_url = null,
+		$cancel_url = null
+	) {
+		$this->itemized_order = new ItemizedOrder($this->_get_gateway_formatter(), $this);
+		$redirect_args = apply_filters(
+			"FHEE__EEG_Paypal_Standard__set_redirection_info__arguments",
+			$this->itemized_order->generateItemizedOrderForPayment(
+				$payment,
+				$return_url,
+				$notify_url,
+				$cancel_url
+			),
+			$this
+		);
+
+		$payment->set_redirect_url($this->_gateway_url);
+		$payment->set_redirect_args($redirect_args);
+		// log the results
+		$this->log(
+			array(
+				'message'     => esc_html__('PayPal payment request initiated.', 'event_espresso'),
+				'transaction' => $payment->transaction()->model_field_array(),
+			),
+			$payment
+		);
+		return $payment;
+	}
+
+
+	/**
+	 * Often used for IPNs. But applies the info in $update_info to the payment.
+	 * What is $update_info? Often the contents of $_REQUEST, but not necessarily. Whatever
+	 * the payment method passes in.
+	 *
+	 * @param array $update_info like $_POST
+	 * @param EEI_Transaction $transaction
+	 * @return EEI_Payment updated
+	 * @throws EE_Error, IpnException
+	 */
+	public function handle_payment_update($update_info, $transaction)
+	{
+		// verify there's payment data that's been sent
+		if (empty($update_info['payment_status']) || empty($update_info['txn_id'])) {
+			// log the results
+			$this->log(
+				array(
+					'message'     => esc_html__(
+						'PayPal IPN response is missing critical payment data. This may indicate a PDT request and require your PayPal account settings to be corrected.',
+						'event_espresso'
+					),
+					'update_info' => $update_info,
+				),
+				$transaction
+			);
+			// waaaait... is this a PDT request? (see https://developer.paypal.com/docs/classic/products/payment-data-transfer/)
+			// indicated by the "tx" argument? If so, we don't need it. We'll just use the IPN data when it comes
+			if (isset($update_info['tx'])) {
+				return $transaction->last_payment();
+			} else {
+				return null;
+			}
+		}
+		$payment = $this->_pay_model->get_payment_by_txn_id_chq_nmbr($update_info['txn_id']);
+		if (! $payment instanceof EEI_Payment) {
+			$payment = $transaction->last_payment();
+		}
+		// ok, then validate the IPN. Even if we've already processed this payment,
+		// let PayPal know we don't want to hear from them anymore!
+		if (! $this->validate_ipn($update_info, $payment)) {
+			return $payment;
+		}
+		// kill request here if this is a refund, we don't support them yet (we'd need to adjust the transaction,
+		// registrations, ticket counts, etc)
+		if (
+			(
+				$update_info['payment_status'] === 'Refunded'
+				|| $update_info['payment_status'] === 'Partially_Refunded'
+			)
+			&& apply_filters('FHEE__EEG_Paypal_Standard__handle_payment_update__kill_refund_request', true)
+		) {
+			throw new EventEspresso\core\exceptions\IpnException(
+				sprintf(
+					esc_html__('Event Espresso does not yet support %1$s IPNs from PayPal', 'event_espresso'),
+					$update_info['payment_status']
+				),
+				EventEspresso\core\exceptions\IpnException::UNSUPPORTED,
+				null,
+				$payment,
+				$update_info
+			);
+		}
+		// ok, well let's process this payment then!
+		switch ($update_info['payment_status']) {
+			case 'Completed':
+				$status = $this->_pay_model->approved_status();
+				$gateway_response = esc_html__('The payment is approved.', 'event_espresso');
+				break;
+
+			case 'Pending':
+				$status = $this->_pay_model->pending_status();
+				$gateway_response = esc_html__(
+					'The payment is in progress. Another message will be sent when payment is approved.',
+					'event_espresso'
+				);
+				break;
+
+			case 'Denied':
+				$status = $this->_pay_model->declined_status();
+				$gateway_response = esc_html__('The payment has been declined.', 'event_espresso');
+				break;
+
+			case 'Expired':
+			case 'Failed':
+				$status = $this->_pay_model->failed_status();
+				$gateway_response = esc_html__('The payment failed for technical reasons or expired.', 'event_espresso');
+				break;
+
+			case 'Refunded':
+			case 'Partially_Refunded':
+				// even though it's a refund, we consider the payment as approved, it just has a negative value
+				$status = $this->_pay_model->approved_status();
+				$gateway_response = esc_html__(
+					'The payment has been refunded. Please update registrations accordingly.',
+					'event_espresso'
+				);
+				break;
+
+			case 'Voided':
+			case 'Reversed':
+			case 'Canceled_Reversal':
+			default:
+				$status = $this->_pay_model->cancelled_status();
+				$gateway_response = esc_html__(
+					'The payment was cancelled, reversed, or voided. Please update registrations accordingly.',
+					'event_espresso'
+				);
+				break;
+		}
+
+		// check if we've already processed this payment
+		if ($payment instanceof EEI_Payment) {
+			// payment exists. if this has the exact same status and amount, don't bother updating. just return
+			if ($payment->status() === $status && $payment->amount() === (float) $update_info['mc_gross']) {
+				// DUPLICATED IPN! don't bother updating transaction
+				throw new IpnException(
+					sprintf(
+						esc_html__(
+							'It appears we have received a duplicate IPN from PayPal for payment %d',
+							'event_espresso'
+						),
+						$payment->ID()
+					),
+					IpnException::DUPLICATE,
+					null,
+					$payment,
+					$update_info
+				);
+			} else {
+				// new payment yippee !!!
+				$payment->set_status($status);
+				$payment->set_amount((float) $update_info['mc_gross']);
+				$payment->set_gateway_response($gateway_response);
+				$payment->set_details($update_info);
+				$payment->set_txn_id_chq_nmbr($update_info['txn_id']);
+				$this->log(
+					array(
+						'message'  => esc_html__(
+							'Updated payment either from IPN or as part of POST from PayPal',
+							'event_espresso'
+						),
+						'url'      => $this->_process_response_url(),
+						'payment'  => $payment->model_field_array(),
+						'IPN_data' => $update_info
+					),
+					$payment
+				);
+			}
+		}
+		do_action('FHEE__EEG_Paypal_Standard__handle_payment_update__payment_processed', $payment, $this);
+		return $payment;
+	}
+
+
+	/**
+	 * Validate the IPN notification.
+	 *
+	 * @param array                  $update_info like $_REQUEST
+	 * @param EE_Payment|EEI_Payment $payment
+	 * @return boolean
+	 * @throws EE_Error
+	 */
+	public function validate_ipn($update_info, $payment)
+	{
+		// allow us to skip validating IPNs with PayPal (useful for testing)
+		if (apply_filters('FHEE__EEG_Paypal_Standard__validate_ipn__skip', false)) {
+			return true;
+		}
+		// ...otherwise, we actually don't care what the $update_info is, we need to look
+		// at the request directly because we can't use $update_info because it has issues with quotes
+		// Reading POSTed data directly from $_POST causes serialization issues with array data in the POST.
+		// Instead, read raw POST data from the input stream.
+		// @see https://gist.github.com/xcommerce-gists/3440401
+		$raw_post_data = file_get_contents('php://input');
+		$raw_post_array = explode('&', $raw_post_data);
+		$update_info = array();
+		foreach ($raw_post_array as $keyval) {
+			$keyval = explode('=', $keyval);
+			if (count($keyval) === 2) {
+				$update_info[ $keyval[0] ] = urldecode($keyval[1]);
+			}
+		}
+		// read the IPN message sent from PayPal and prepend 'cmd=_notify-validate'
+		$req = 'cmd=_notify-validate';
+		$uses_get_magic_quotes = function_exists('get_magic_quotes_gpc') && get_magic_quotes_gpc() === 1;
+		foreach ($update_info as $key => $value) {
+			$value = $uses_get_magic_quotes ? urlencode(stripslashes($value)) : urlencode($value);
+			$req .= "&$key=$value";
+		}
+		// HTTP POST the complete, unaltered IPN back to PayPal
+		$response = wp_remote_post(
+			$this->_gateway_url,
+			array(
+				'body'              => $req,
+				'sslverify'         => false,
+				'timeout'           => 60,
+				// make sure to set a site specific unique "user-agent" string since the WordPres default gets declined by PayPal
+				// plz see: https://github.com/websharks/s2member/issues/610
+				'user-agent'        => 'Event Espresso v' . EVENT_ESPRESSO_VERSION . '; ' . home_url(),
+				'httpversion'       => '1.1'
+			)
+		);
+		// then check the response
+		if (
+			array_key_exists('body', $response)
+			&& ! is_wp_error($response)
+			&& strcmp($response['body'], "VERIFIED") === 0
+		) {
+			return true;
+		}
+		// huh, something's wack... the IPN didn't validate. We must have replied to the IPN incorrectly,
+		// or their API must have changed: http://www.paypalobjects.com/en_US/ebook/PP_OrderManagement_IntegrationGuide/ipn.html
+		if ($response instanceof WP_Error) {
+			$error_msg = sprintf(
+				esc_html__('WP Error. Code: "%1$s", Message: "%2$s", Data: "%3$s"', 'event_espresso'),
+				$response->get_error_code(),
+				$response->get_error_message(),
+				print_r($response->get_error_data(), true)
+			);
+		} elseif (is_array($response) && isset($response['body'])) {
+			$error_msg = $response['body'];
+		} else {
+			$error_msg = print_r($response, true);
+		}
+		$payment->set_gateway_response(
+			sprintf(
+				esc_html__("IPN Validation failed! Paypal responded with '%s'", "event_espresso"),
+				$error_msg
+			)
+		);
+		$payment->set_details(array('REQUEST' => $update_info, 'VALIDATION_RESPONSE' => $response));
+		$payment->set_status(EEM_Payment::status_id_failed);
+		// log the results
+		$this->log(
+			array(
+				'url'     => $this->_process_response_url(),
+				'message' => $payment->gateway_response(),
+				'details' => $payment->details(),
+			),
+			$payment
+		);
+		return false;
+	}
+
+
+	/**
+	 * _process_response_url
+	 * @return string
+	 */
+	protected function _process_response_url(): string
+	{
+		if (isset($_SERVER['HTTP_HOST'], $_SERVER['REQUEST_URI'])) {
+			$url = is_ssl() ? 'https://' : 'http://';
+			$url .= EEH_URL::filter_input_server_url('HTTP_HOST');
+			$url .= EEH_URL::filter_input_server_url();
+		} else {
+			$url = 'unknown';
+		}
+		return $url;
+	}
+
+
+	/**
+	 * Updates the transaction and line items based on the payment IPN data from PayPal,
+	 * like the taxes or shipping
+	 *
+	 * @param EEI_Payment $payment
+	 * @throws EE_Error
+	 * @throws ReflectionException
+	 */
+	public function update_txn_based_on_payment($payment)
+	{
+		$update_info = $payment->details();
+		/** @var EE_Transaction $transaction */
+		$transaction = $payment->transaction();
+		$payment_was_itemized = $payment->get_extra_meta(EEG_Paypal_Standard::itemized_payment_option_name, true, false);
+		if (! $transaction) {
+			$this->log(
+				esc_html__(
+					// @codingStandardsIgnoreStart
+					'Payment with ID %d has no related transaction, and so update_txn_based_on_payment couldn\'t be executed properly',
+					// @codingStandardsIgnoreEnd
+					'event_espresso'
+				),
+				$payment
+			);
+			return;
+		}
+		if (
+			! is_array($update_info)
+			|| ! isset($update_info['mc_shipping'])
+			|| ! isset($update_info['tax'])
+		) {
+			$this->log(
+				array(
+					'message' => esc_html__(
+						// @codingStandardsIgnoreStart
+						'Could not update transaction based on payment because the payment details have not yet been put on the payment. This normally happens during the IPN or returning from PayPal',
+						// @codingStandardsIgnoreEnd
+						'event_espresso'
+					),
+					'url'     => $this->_process_response_url(),
+					'payment' => $payment->model_field_array()
+				),
+				$payment
+			);
+			return;
+		}
+		if ($payment->status() !== $this->_pay_model->approved_status()) {
+			$this->log(
+				array(
+					'message' => esc_html__(
+						'We shouldn\'t update transactions taxes or shipping data from non-approved payments',
+						'event_espresso'
+					),
+					'url'     => $this->_process_response_url(),
+					'payment' => $payment->model_field_array()
+				),
+				$payment
+			);
+			return;
+		}
+		$grand_total_needs_resaving = false;
+		/** @var EE_Line_Item $transaction_total_line_item */
+		$transaction_total_line_item = $transaction->total_line_item();
+
+		// might paypal have changed the taxes?
+		if ($this->_paypal_taxes && $payment_was_itemized) {
+			// note that we're doing this BEFORE adding shipping;
+			// we actually want PayPal's shipping to remain non-taxable
+			$this->_line_item->set_line_items_taxable($transaction_total_line_item, true, 'paypal_shipping');
+			$this->_line_item->set_total_tax_to(
+				$transaction_total_line_item,
+				(float) $update_info['tax'],
+				esc_html__('Taxes', 'event_espresso'),
+				esc_html__('Calculated by Paypal', 'event_espresso'),
+				'paypal_tax'
+			);
+			$grand_total_needs_resaving = true;
+		}
+
+		$shipping_amount = (float) $update_info['mc_shipping'];
+		// might paypal have added shipping?
+		if ($this->_paypal_shipping && $shipping_amount && $payment_was_itemized) {
+			$this->_line_item->add_unrelated_item(
+				$transaction_total_line_item,
+				sprintf(esc_html__('Shipping for transaction %1$s', 'event_espresso'), $transaction->ID()),
+				$shipping_amount,
+				esc_html__('Shipping charges calculated by Paypal', 'event_espresso'),
+				1,
+				false,
+				'paypal_shipping_' . $transaction->ID()
+			);
+			$grand_total_needs_resaving = true;
+		}
+
+		if ($grand_total_needs_resaving) {
+			$transaction_total_line_item->save_this_and_descendants_to_txn($transaction->ID());
+			/** @var EE_Registration_Processor $registration_processor */
+			$registration_processor = EE_Registry::instance()->load_class('Registration_Processor');
+			$registration_processor->update_registration_final_prices($transaction);
+		}
+		$this->log(
+			array(
+				'message'                     => esc_html__('Updated transaction related to payment', 'event_espresso'),
+				'url'                         => $this->_process_response_url(),
+				'transaction (updated)'       => $transaction->model_field_array(),
+				'payment (updated)'           => $payment->model_field_array(),
+				'use_paypal_shipping'         => $this->_paypal_shipping,
+				'use_paypal_tax'              => $this->_paypal_taxes,
+				'grand_total_needed_resaving' => $grand_total_needs_resaving,
+			),
+			$payment
+		);
+	}
 }

Spacing +6 added lines, -6 removed lines

@@ -229,12 +229,12 @@ 
             }
         }
         $payment = $this->_pay_model->get_payment_by_txn_id_chq_nmbr($update_info['txn_id']);
-        if (! $payment instanceof EEI_Payment) {
+        if ( ! $payment instanceof EEI_Payment) {
             $payment = $transaction->last_payment();
         }
         // ok, then validate the IPN. Even if we've already processed this payment,
         // let PayPal know we don't want to hear from them anymore!
-        if (! $this->validate_ipn($update_info, $payment)) {
+        if ( ! $this->validate_ipn($update_info, $payment)) {
             return $payment;
         }
         // kill request here if this is a refund, we don't support them yet (we'd need to adjust the transaction,
@@ -374,7 +374,7 @@ 
         foreach ($raw_post_array as $keyval) {
             $keyval = explode('=', $keyval);
             if (count($keyval) === 2) {
-                $update_info[ $keyval[0] ] = urldecode($keyval[1]);
+                $update_info[$keyval[0]] = urldecode($keyval[1]);
             }
         }
         // read the IPN message sent from PayPal and prepend 'cmd=_notify-validate'
@@ -393,7 +393,7 @@ 
                 'timeout'           => 60,
                 // make sure to set a site specific unique "user-agent" string since the WordPres default gets declined by PayPal
                 // plz see: https://github.com/websharks/s2member/issues/610
-                'user-agent'        => 'Event Espresso v' . EVENT_ESPRESSO_VERSION . '; ' . home_url(),
+                'user-agent'        => 'Event Espresso v'.EVENT_ESPRESSO_VERSION.'; '.home_url(),
                 'httpversion'       => '1.1'
             )
         );
@@ -471,7 +471,7 @@ 
         /** @var EE_Transaction $transaction */
         $transaction = $payment->transaction();
         $payment_was_itemized = $payment->get_extra_meta(EEG_Paypal_Standard::itemized_payment_option_name, true, false);
-        if (! $transaction) {
+        if ( ! $transaction) {
             $this->log(
                 esc_html__(
                     // @codingStandardsIgnoreStart
@@ -546,7 +546,7 @@ 
                 esc_html__('Shipping charges calculated by Paypal', 'event_espresso'),
                 1,
                 false,
-                'paypal_shipping_' . $transaction->ID()
+                'paypal_shipping_'.$transaction->ID()
             );
             $grand_total_needs_resaving = true;
         }

payment_methods/Paypal_Standard/ItemizedOrder.php

Indentation +251 added lines, -251 removed lines

@@ -14,282 +14,282 @@
 
 class ItemizedOrder
 {
-    /**
-     * @var float
-     */
-    private $existing_shipping_charges = 0.00;
+	/**
+	 * @var float
+	 */
+	private $existing_shipping_charges = 0.00;
 
-    /**
-     * keeps track of exactly how much the itemized order amount equals
-     *
-     * @var float
-     */
-    private $itemized_order_sum = 0.00;
+	/**
+	 * keeps track of exactly how much the itemized order amount equals
+	 *
+	 * @var float
+	 */
+	private $itemized_order_sum = 0.00;
 
-    /**
-     * @var GatewayDataFormatterInterface
-     */
-    protected $gateway_data_formatter;
+	/**
+	 * @var GatewayDataFormatterInterface
+	 */
+	protected $gateway_data_formatter;
 
-    /**
-     * @var array
-     */
-    private $order_items;
+	/**
+	 * @var array
+	 */
+	private $order_items;
 
-    /**
-     * the payment being processed
-     *
-     * @var EE_Payment
-     */
-    protected $payment;
+	/**
+	 * the payment being processed
+	 *
+	 * @var EE_Payment
+	 */
+	protected $payment;
 
-    /**
-     * @var EEG_Paypal_Standard
-     */
-    protected $paypal_gateway;
+	/**
+	 * @var EEG_Paypal_Standard
+	 */
+	protected $paypal_gateway;
 
-    /**
-     * @var float
-     */
-    private $total_discounts = 0.00;
+	/**
+	 * @var float
+	 */
+	private $total_discounts = 0.00;
 
-    /**
-     * @var EE_Transaction
-     */
-    private $transaction;
+	/**
+	 * @var EE_Transaction
+	 */
+	private $transaction;
 
 
-    /**
-     * @param GatewayDataFormatterInterface $gateway_data_formatter
-     * @param EEG_Paypal_Standard           $paypal_gateway
-     */
-    public function __construct(GatewayDataFormatterInterface $gateway_data_formatter, EEG_Paypal_Standard $paypal_gateway)
-    {
-        $this->gateway_data_formatter = $gateway_data_formatter;
-        $this->paypal_gateway = $paypal_gateway;
-    }
+	/**
+	 * @param GatewayDataFormatterInterface $gateway_data_formatter
+	 * @param EEG_Paypal_Standard           $paypal_gateway
+	 */
+	public function __construct(GatewayDataFormatterInterface $gateway_data_formatter, EEG_Paypal_Standard $paypal_gateway)
+	{
+		$this->gateway_data_formatter = $gateway_data_formatter;
+		$this->paypal_gateway = $paypal_gateway;
+	}
 
 
-    /**
-     * @param EE_Payment $payment
-     * @param string     $return_url    URL to send the user to after payment on the payment provider's website
-     * @param string     $notify_url    URL to send the instant payment notification
-     * @param string     $cancel_url    URL to send the user to after a cancelled payment attempt
-     *                                  on the payment provider's website
-     * @return array
-     * @throws EE_Error
-     * @throws ReflectionException
-     */
-    public function generateItemizedOrderForPayment(
-        EE_Payment $payment,
-        string $return_url = '',
-        string $notify_url = '',
-        string $cancel_url = ''
-    ): array {
-        $this->payment         = $payment;
-        $this->transaction     = $this->payment->transaction();
-        $this->total_discounts = $this->transaction->paid();
-        $total_line_item       = $this->transaction->total_line_item();
+	/**
+	 * @param EE_Payment $payment
+	 * @param string     $return_url    URL to send the user to after payment on the payment provider's website
+	 * @param string     $notify_url    URL to send the instant payment notification
+	 * @param string     $cancel_url    URL to send the user to after a cancelled payment attempt
+	 *                                  on the payment provider's website
+	 * @return array
+	 * @throws EE_Error
+	 * @throws ReflectionException
+	 */
+	public function generateItemizedOrderForPayment(
+		EE_Payment $payment,
+		string $return_url = '',
+		string $notify_url = '',
+		string $cancel_url = ''
+	): array {
+		$this->payment         = $payment;
+		$this->transaction     = $this->payment->transaction();
+		$this->total_discounts = $this->transaction->paid();
+		$total_line_item       = $this->transaction->total_line_item();
 
-        // only itemize the order if we're paying for the rest of the order's amount
-        $item_num = 1;
-        $item_num = $this->paymentIsForTransactionTotal()
-            ? $this->itemizeOrderForFullPayment($total_line_item, $item_num)
-            : $this->handlePartialPayment($item_num);
+		// only itemize the order if we're paying for the rest of the order's amount
+		$item_num = 1;
+		$item_num = $this->paymentIsForTransactionTotal()
+			? $this->itemizeOrderForFullPayment($total_line_item, $item_num)
+			: $this->handlePartialPayment($item_num);
 
-        if ($this->paypal_gateway->isInSandboxMode()) {
-            $this->addSandboxModeArgs($item_num, $notify_url, $return_url);
-        }
-        $this->addGeneralOrderItems($cancel_url, $notify_url, $return_url);
-        return $this->order_items;
-    }
+		if ($this->paypal_gateway->isInSandboxMode()) {
+			$this->addSandboxModeArgs($item_num, $notify_url, $return_url);
+		}
+		$this->addGeneralOrderItems($cancel_url, $notify_url, $return_url);
+		return $this->order_items;
+	}
 
 
-    /**
-     * @return bool
-     * @throws ReflectionException
-     * @throws EE_Error
-     */
-    private function paymentIsForTransactionTotal(): bool
-    {
-        return EEH_Money::compare_floats($this->payment->amount(), $this->transaction->total(), '==');
-    }
+	/**
+	 * @return bool
+	 * @throws ReflectionException
+	 * @throws EE_Error
+	 */
+	private function paymentIsForTransactionTotal(): bool
+	{
+		return EEH_Money::compare_floats($this->payment->amount(), $this->transaction->total(), '==');
+	}
 
 
-    /**
-     * if the payment is for the remaining transaction amount,
-     * keep track of exactly how much the itemized order amount equals
-     *
-     * @param EE_Line_Item $total_line_item
-     * @param int          $item_num
-     * @return int
-     * @throws EE_Error
-     * @throws ReflectionException
-     */
-    private function itemizeOrderForFullPayment(EE_Line_Item $total_line_item, int $item_num): int
-    {
-        $this->payment->update_extra_meta(EEG_Paypal_Standard::itemized_payment_option_name, true);
-        // this payment is for the remaining transaction amount, so let's show all the line items
-        $item_num = $this->addOrderItemsForLineItems($total_line_item, $item_num);
-        // and make adjustments as needed
-        $item_num = $this->handleItemizedOrderSumDifference($total_line_item, $item_num);
-        // add our taxes to the order if we're NOT using PayPal's
-        if (! $this->paypal_gateway->paypalTaxes()) {
-            $this->order_items['tax_cart'] = $total_line_item->get_total_tax();
-        }
-        return $item_num;
-    }
+	/**
+	 * if the payment is for the remaining transaction amount,
+	 * keep track of exactly how much the itemized order amount equals
+	 *
+	 * @param EE_Line_Item $total_line_item
+	 * @param int          $item_num
+	 * @return int
+	 * @throws EE_Error
+	 * @throws ReflectionException
+	 */
+	private function itemizeOrderForFullPayment(EE_Line_Item $total_line_item, int $item_num): int
+	{
+		$this->payment->update_extra_meta(EEG_Paypal_Standard::itemized_payment_option_name, true);
+		// this payment is for the remaining transaction amount, so let's show all the line items
+		$item_num = $this->addOrderItemsForLineItems($total_line_item, $item_num);
+		// and make adjustments as needed
+		$item_num = $this->handleItemizedOrderSumDifference($total_line_item, $item_num);
+		// add our taxes to the order if we're NOT using PayPal's
+		if (! $this->paypal_gateway->paypalTaxes()) {
+			$this->order_items['tax_cart'] = $total_line_item->get_total_tax();
+		}
+		return $item_num;
+	}
 
 
-    /**
-     * @param int $item_num
-     * @return int
-     * @throws EE_Error
-     * @throws ReflectionException
-     */
-    private function handlePartialPayment(int $item_num): int
-    {
-        $this->payment->update_extra_meta(EEG_Paypal_Standard::itemized_payment_option_name, false);
-        // partial payment that's not for the remaining amount, so we can't send an itemized list
-        $this->order_items[ "item_name_{$item_num}" ] = substr(
-            $this->gateway_data_formatter->formatPartialPaymentLineItemName($this->payment),
-            0,
-            127
-        );
-        $this->order_items[ "amount_{$item_num}" ]    = $this->payment->amount();
-        $this->order_items[ "shipping_{$item_num}" ]  = '0';
-        $this->order_items[ "shipping2_{$item_num}" ] = '0';
-        $this->order_items['tax_cart']              = '0';
-        $item_num++;
-        return $item_num;
-    }
+	/**
+	 * @param int $item_num
+	 * @return int
+	 * @throws EE_Error
+	 * @throws ReflectionException
+	 */
+	private function handlePartialPayment(int $item_num): int
+	{
+		$this->payment->update_extra_meta(EEG_Paypal_Standard::itemized_payment_option_name, false);
+		// partial payment that's not for the remaining amount, so we can't send an itemized list
+		$this->order_items[ "item_name_{$item_num}" ] = substr(
+			$this->gateway_data_formatter->formatPartialPaymentLineItemName($this->payment),
+			0,
+			127
+		);
+		$this->order_items[ "amount_{$item_num}" ]    = $this->payment->amount();
+		$this->order_items[ "shipping_{$item_num}" ]  = '0';
+		$this->order_items[ "shipping2_{$item_num}" ] = '0';
+		$this->order_items['tax_cart']              = '0';
+		$item_num++;
+		return $item_num;
+	}
 
 
-    /**
-     * @param EE_Line_Item $total_line_item
-     * @param int          $item_num
-     * @return int
-     * @throws EE_Error
-     * @throws ReflectionException
-     */
-    private function addOrderItemsForLineItems(EE_Line_Item $total_line_item, int $item_num): int
-    {
-        foreach ($total_line_item->get_items() as $line_item) {
-            if ($line_item instanceof EE_Line_Item) {
-                // it's some kind of discount
-                if (EEH_Money::compare_floats($line_item->pretaxTotal(), 0.00, '<')) {
-                    $this->total_discounts    += abs($line_item->pretaxTotal());
-                    $this->itemized_order_sum += $line_item->pretaxTotal();
-                    continue;
-                }
-                // dont include shipping again.
-                if (strpos($line_item->code(), 'paypal_shipping_') === 0) {
-                    $this->existing_shipping_charges = $line_item->pretaxTotal();
-                    continue;
-                }
-                $this->order_items[ "item_name_{$item_num}" ] = substr(
-                    $this->gateway_data_formatter->formatLineItemName($line_item, $this->payment),
-                    0,
-                    127
-                );
-                $this->order_items[ "amount_{$item_num}" ]    = $line_item->unit_price();
-                $this->order_items[ "quantity_{$item_num}" ]  = $line_item->quantity();
-                // if we're not letting PayPal calculate shipping, tell them its 0
-                if (! $this->paypal_gateway->paypalShipping()) {
-                    $this->order_items[ "shipping_{$item_num}" ]  = '0';
-                    $this->order_items[ "shipping2_{$item_num}" ] = '0';
-                }
-                $this->itemized_order_sum += $line_item->pretaxTotal();
-                $item_num++;
-            }
-        }
-        return $item_num;
-    }
+	/**
+	 * @param EE_Line_Item $total_line_item
+	 * @param int          $item_num
+	 * @return int
+	 * @throws EE_Error
+	 * @throws ReflectionException
+	 */
+	private function addOrderItemsForLineItems(EE_Line_Item $total_line_item, int $item_num): int
+	{
+		foreach ($total_line_item->get_items() as $line_item) {
+			if ($line_item instanceof EE_Line_Item) {
+				// it's some kind of discount
+				if (EEH_Money::compare_floats($line_item->pretaxTotal(), 0.00, '<')) {
+					$this->total_discounts    += abs($line_item->pretaxTotal());
+					$this->itemized_order_sum += $line_item->pretaxTotal();
+					continue;
+				}
+				// dont include shipping again.
+				if (strpos($line_item->code(), 'paypal_shipping_') === 0) {
+					$this->existing_shipping_charges = $line_item->pretaxTotal();
+					continue;
+				}
+				$this->order_items[ "item_name_{$item_num}" ] = substr(
+					$this->gateway_data_formatter->formatLineItemName($line_item, $this->payment),
+					0,
+					127
+				);
+				$this->order_items[ "amount_{$item_num}" ]    = $line_item->unit_price();
+				$this->order_items[ "quantity_{$item_num}" ]  = $line_item->quantity();
+				// if we're not letting PayPal calculate shipping, tell them its 0
+				if (! $this->paypal_gateway->paypalShipping()) {
+					$this->order_items[ "shipping_{$item_num}" ]  = '0';
+					$this->order_items[ "shipping2_{$item_num}" ] = '0';
+				}
+				$this->itemized_order_sum += $line_item->pretaxTotal();
+				$item_num++;
+			}
+		}
+		return $item_num;
+	}
 
 
-    /**
-     * @param EE_Line_Item $total_line_item
-     * @param int          $item_num
-     * @return int
-     * @throws EE_Error
-     * @throws ReflectionException
-     */
-    private function handleItemizedOrderSumDifference(EE_Line_Item $total_line_item, int $item_num): int
-    {
-        $taxes_li = EEH_Line_Item::get_taxes_subtotal($total_line_item);
-        // calculate the difference between the TXN total and the itemized order sum
-        $itemized_order_sum_difference = round(
-            $this->transaction->total()
-            - $this->itemized_order_sum
-            - $taxes_li->total()
-            - $this->existing_shipping_charges,
-            2
-        );
-        // ideally the itemized order sum equals the transaction total, but if not (which is weird),
-        // and the itemized sum is LESS than the transaction total...
-        if (EEH_Money::compare_floats($itemized_order_sum_difference, 0.00, '<')) {
-            // add the difference to the discounts
-            $this->total_discounts += abs($itemized_order_sum_difference);
-        } elseif (EEH_Money::compare_floats($itemized_order_sum_difference, 0.00, '>')) {
-            // the itemized order sum is MORE than the transaction total
-            $this->order_items[ "item_name_{$item_num}" ] = substr(
-                esc_html__('additional charges', 'event_espresso'),
-                0,
-                127
-            );
-            $this->order_items[ "amount_{$item_num}" ]    = $this->gateway_data_formatter->formatCurrency(
-                $itemized_order_sum_difference
-            );
-            $this->order_items[ "quantity_{$item_num}" ]  = 1;
-            $item_num++;
-        }
-        if (EEH_Money::compare_floats($this->total_discounts, 0.00, '>')) {
-            $this->order_items['discount_amount_cart'] = $this->gateway_data_formatter->formatCurrency(
-                $this->total_discounts
-            );
-        }
-        return $item_num;
-    }
+	/**
+	 * @param EE_Line_Item $total_line_item
+	 * @param int          $item_num
+	 * @return int
+	 * @throws EE_Error
+	 * @throws ReflectionException
+	 */
+	private function handleItemizedOrderSumDifference(EE_Line_Item $total_line_item, int $item_num): int
+	{
+		$taxes_li = EEH_Line_Item::get_taxes_subtotal($total_line_item);
+		// calculate the difference between the TXN total and the itemized order sum
+		$itemized_order_sum_difference = round(
+			$this->transaction->total()
+			- $this->itemized_order_sum
+			- $taxes_li->total()
+			- $this->existing_shipping_charges,
+			2
+		);
+		// ideally the itemized order sum equals the transaction total, but if not (which is weird),
+		// and the itemized sum is LESS than the transaction total...
+		if (EEH_Money::compare_floats($itemized_order_sum_difference, 0.00, '<')) {
+			// add the difference to the discounts
+			$this->total_discounts += abs($itemized_order_sum_difference);
+		} elseif (EEH_Money::compare_floats($itemized_order_sum_difference, 0.00, '>')) {
+			// the itemized order sum is MORE than the transaction total
+			$this->order_items[ "item_name_{$item_num}" ] = substr(
+				esc_html__('additional charges', 'event_espresso'),
+				0,
+				127
+			);
+			$this->order_items[ "amount_{$item_num}" ]    = $this->gateway_data_formatter->formatCurrency(
+				$itemized_order_sum_difference
+			);
+			$this->order_items[ "quantity_{$item_num}" ]  = 1;
+			$item_num++;
+		}
+		if (EEH_Money::compare_floats($this->total_discounts, 0.00, '>')) {
+			$this->order_items['discount_amount_cart'] = $this->gateway_data_formatter->formatCurrency(
+				$this->total_discounts
+			);
+		}
+		return $item_num;
+	}
 
 
-    /**
-     * @param int    $item_num
-     * @param string $notify_url
-     * @param string $return_url
-     */
-    private function addSandboxModeArgs(int $item_num, string $notify_url, string $return_url)
-    {
-        $this->order_items[ "item_name_{$item_num}" ] = 'DEBUG INFO (this item only added in sandbox mode';
-        $this->order_items[ "amount_{$item_num}" ]    = 0;
-        $this->order_items[ "on0_{$item_num}" ]       = 'NOTIFY URL';
-        $this->order_items[ "os0_{$item_num}" ]       = $notify_url;
-        $this->order_items[ "on1_{$item_num}" ]       = 'RETURN URL';
-        $this->order_items[ "os1_{$item_num}" ]       = $return_url;
-        $this->order_items[ "shipping_{$item_num}" ]  = '0';
-        $this->order_items[ "shipping2_{$item_num}" ] = '0';
-        // $this->order_items['option_index_' . $item_num] = 1; // <-- dunno if this is needed ?
-    }
+	/**
+	 * @param int    $item_num
+	 * @param string $notify_url
+	 * @param string $return_url
+	 */
+	private function addSandboxModeArgs(int $item_num, string $notify_url, string $return_url)
+	{
+		$this->order_items[ "item_name_{$item_num}" ] = 'DEBUG INFO (this item only added in sandbox mode';
+		$this->order_items[ "amount_{$item_num}" ]    = 0;
+		$this->order_items[ "on0_{$item_num}" ]       = 'NOTIFY URL';
+		$this->order_items[ "os0_{$item_num}" ]       = $notify_url;
+		$this->order_items[ "on1_{$item_num}" ]       = 'RETURN URL';
+		$this->order_items[ "os1_{$item_num}" ]       = $return_url;
+		$this->order_items[ "shipping_{$item_num}" ]  = '0';
+		$this->order_items[ "shipping2_{$item_num}" ] = '0';
+		// $this->order_items['option_index_' . $item_num] = 1; // <-- dunno if this is needed ?
+	}
 
 
-    /**
-     * @param string $cancel_url
-     * @param string $notify_url
-     * @param string $return_url
-     */
-    private function addGeneralOrderItems(string $cancel_url, string $notify_url, string $return_url)
-    {
-        $this->order_items['business']      = $this->paypal_gateway->paypalId();
-        $this->order_items['return']        = $return_url;
-        $this->order_items['cancel_return'] = $cancel_url;
-        $this->order_items['notify_url']    = $notify_url;
-        $this->order_items['cmd']           = '_cart';
-        $this->order_items['upload']        = 1;
-        $this->order_items['currency_code'] = $this->payment->currency_code();
-        $this->order_items['rm']            = 2;// makes the user return with method=POST
-        $this->order_items['no_shipping']   = $this->paypal_gateway->shippingDetails();
-        $this->order_items['bn']            = 'EventEspresso_SP';// EE will blow up if you change this
-        if ($this->paypal_gateway->imageUrl()) {
-            $this->order_items['image_url'] = $this->paypal_gateway->imageUrl();
-        }
-    }
+	/**
+	 * @param string $cancel_url
+	 * @param string $notify_url
+	 * @param string $return_url
+	 */
+	private function addGeneralOrderItems(string $cancel_url, string $notify_url, string $return_url)
+	{
+		$this->order_items['business']      = $this->paypal_gateway->paypalId();
+		$this->order_items['return']        = $return_url;
+		$this->order_items['cancel_return'] = $cancel_url;
+		$this->order_items['notify_url']    = $notify_url;
+		$this->order_items['cmd']           = '_cart';
+		$this->order_items['upload']        = 1;
+		$this->order_items['currency_code'] = $this->payment->currency_code();
+		$this->order_items['rm']            = 2;// makes the user return with method=POST
+		$this->order_items['no_shipping']   = $this->paypal_gateway->shippingDetails();
+		$this->order_items['bn']            = 'EventEspresso_SP';// EE will blow up if you change this
+		if ($this->paypal_gateway->imageUrl()) {
+			$this->order_items['image_url'] = $this->paypal_gateway->imageUrl();
+		}
+	}
 }

Spacing +25 added lines, -25 removed lines

@@ -134,7 +134,7 @@ 
         // and make adjustments as needed
         $item_num = $this->handleItemizedOrderSumDifference($total_line_item, $item_num);
         // add our taxes to the order if we're NOT using PayPal's
-        if (! $this->paypal_gateway->paypalTaxes()) {
+        if ( ! $this->paypal_gateway->paypalTaxes()) {
             $this->order_items['tax_cart'] = $total_line_item->get_total_tax();
         }
         return $item_num;
@@ -151,15 +151,15 @@ 
     {
         $this->payment->update_extra_meta(EEG_Paypal_Standard::itemized_payment_option_name, false);
         // partial payment that's not for the remaining amount, so we can't send an itemized list
-        $this->order_items[ "item_name_{$item_num}" ] = substr(
+        $this->order_items["item_name_{$item_num}"] = substr(
             $this->gateway_data_formatter->formatPartialPaymentLineItemName($this->payment),
             0,
             127
         );
-        $this->order_items[ "amount_{$item_num}" ]    = $this->payment->amount();
-        $this->order_items[ "shipping_{$item_num}" ]  = '0';
-        $this->order_items[ "shipping2_{$item_num}" ] = '0';
-        $this->order_items['tax_cart']              = '0';
+        $this->order_items["amount_{$item_num}"]    = $this->payment->amount();
+        $this->order_items["shipping_{$item_num}"]  = '0';
+        $this->order_items["shipping2_{$item_num}"] = '0';
+        $this->order_items['tax_cart'] = '0';
         $item_num++;
         return $item_num;
     }
@@ -187,17 +187,17 @@ 
                     $this->existing_shipping_charges = $line_item->pretaxTotal();
                     continue;
                 }
-                $this->order_items[ "item_name_{$item_num}" ] = substr(
+                $this->order_items["item_name_{$item_num}"] = substr(
                     $this->gateway_data_formatter->formatLineItemName($line_item, $this->payment),
                     0,
                     127
                 );
-                $this->order_items[ "amount_{$item_num}" ]    = $line_item->unit_price();
-                $this->order_items[ "quantity_{$item_num}" ]  = $line_item->quantity();
+                $this->order_items["amount_{$item_num}"]    = $line_item->unit_price();
+                $this->order_items["quantity_{$item_num}"]  = $line_item->quantity();
                 // if we're not letting PayPal calculate shipping, tell them its 0
-                if (! $this->paypal_gateway->paypalShipping()) {
-                    $this->order_items[ "shipping_{$item_num}" ]  = '0';
-                    $this->order_items[ "shipping2_{$item_num}" ] = '0';
+                if ( ! $this->paypal_gateway->paypalShipping()) {
+                    $this->order_items["shipping_{$item_num}"]  = '0';
+                    $this->order_items["shipping2_{$item_num}"] = '0';
                 }
                 $this->itemized_order_sum += $line_item->pretaxTotal();
                 $item_num++;
@@ -232,15 +232,15 @@ 
             $this->total_discounts += abs($itemized_order_sum_difference);
         } elseif (EEH_Money::compare_floats($itemized_order_sum_difference, 0.00, '>')) {
             // the itemized order sum is MORE than the transaction total
-            $this->order_items[ "item_name_{$item_num}" ] = substr(
+            $this->order_items["item_name_{$item_num}"] = substr(
                 esc_html__('additional charges', 'event_espresso'),
                 0,
                 127
             );
-            $this->order_items[ "amount_{$item_num}" ]    = $this->gateway_data_formatter->formatCurrency(
+            $this->order_items["amount_{$item_num}"]    = $this->gateway_data_formatter->formatCurrency(
                 $itemized_order_sum_difference
             );
-            $this->order_items[ "quantity_{$item_num}" ]  = 1;
+            $this->order_items["quantity_{$item_num}"]  = 1;
             $item_num++;
         }
         if (EEH_Money::compare_floats($this->total_discounts, 0.00, '>')) {
@@ -259,14 +259,14 @@ 
      */
     private function addSandboxModeArgs(int $item_num, string $notify_url, string $return_url)
     {
-        $this->order_items[ "item_name_{$item_num}" ] = 'DEBUG INFO (this item only added in sandbox mode';
-        $this->order_items[ "amount_{$item_num}" ]    = 0;
-        $this->order_items[ "on0_{$item_num}" ]       = 'NOTIFY URL';
-        $this->order_items[ "os0_{$item_num}" ]       = $notify_url;
-        $this->order_items[ "on1_{$item_num}" ]       = 'RETURN URL';
-        $this->order_items[ "os1_{$item_num}" ]       = $return_url;
-        $this->order_items[ "shipping_{$item_num}" ]  = '0';
-        $this->order_items[ "shipping2_{$item_num}" ] = '0';
+        $this->order_items["item_name_{$item_num}"] = 'DEBUG INFO (this item only added in sandbox mode';
+        $this->order_items["amount_{$item_num}"]    = 0;
+        $this->order_items["on0_{$item_num}"]       = 'NOTIFY URL';
+        $this->order_items["os0_{$item_num}"]       = $notify_url;
+        $this->order_items["on1_{$item_num}"]       = 'RETURN URL';
+        $this->order_items["os1_{$item_num}"]       = $return_url;
+        $this->order_items["shipping_{$item_num}"]  = '0';
+        $this->order_items["shipping2_{$item_num}"] = '0';
         // $this->order_items['option_index_' . $item_num] = 1; // <-- dunno if this is needed ?
     }
 
@@ -285,9 +285,9 @@ 
         $this->order_items['cmd']           = '_cart';
         $this->order_items['upload']        = 1;
         $this->order_items['currency_code'] = $this->payment->currency_code();
-        $this->order_items['rm']            = 2;// makes the user return with method=POST
+        $this->order_items['rm']            = 2; // makes the user return with method=POST
         $this->order_items['no_shipping']   = $this->paypal_gateway->shippingDetails();
-        $this->order_items['bn']            = 'EventEspresso_SP';// EE will blow up if you change this
+        $this->order_items['bn']            = 'EventEspresso_SP'; // EE will blow up if you change this
         if ($this->paypal_gateway->imageUrl()) {
             $this->order_items['image_url'] = $this->paypal_gateway->imageUrl();
         }

caffeinated/modules/ticket_selector_caff/templates/ticket_selector_price_details.template.php

Indentation +49 added lines, -49 removed lines

@@ -7,10 +7,10 @@ 
  */
 
 if (! function_exists('espressoSubtotalRow')) {
-    function espressoSubtotalRow(float $running_total, bool $show = true): string
-    {
-        return $show
-            ? '
+	function espressoSubtotalRow(float $running_total, bool $show = true): string
+	{
+		return $show
+			? '
                 <tr>
                     <td colspan="2" class="jst-rght small-text sbttl">
                         <b>' . esc_html__('subtotal', 'event_espresso') . '</b>
@@ -20,18 +20,18 @@ 
                     </td>
                 </tr>
             '
-            : '';
-    }
+			: '';
+	}
 }
 
 if ($display_ticket_price) { ?>
     <section class="tckt-slctr-tkt-price-sctn">
         <h5><?php echo esc_html(
-            apply_filters(
-                'FHEE__ticket_selector_chart_template__ticket_details_price_breakdown_heading',
-                __('Price', 'event_espresso')
-            )
-        ); ?></h5>
+			apply_filters(
+				'FHEE__ticket_selector_chart_template__ticket_details_price_breakdown_heading',
+				__('Price', 'event_espresso')
+			)
+		); ?></h5>
         <div class="tckt-slctr-tkt-details-tbl-wrap-dv">
             <table class="tckt-slctr-tkt-details-tbl">
                 <thead>
@@ -51,7 +51,7 @@ 
                 </thead>
                 <tbody>
                     <?php
-                    if ($ticket->base_price() instanceof EE_Price) { ?>
+					if ($ticket->base_price() instanceof EE_Price) { ?>
                         <tr>
                             <td data-th="<?php esc_html_e('Name', 'event_espresso'); ?>" class="small-text" colspan="2">
                                 <b><?php echo $ticket->base_price()->name(); ?></b></td>
@@ -60,31 +60,31 @@ 
                             </td>
                         </tr>
                         <?php
-                        $running_total = $ticket->base_price()->amount();
-                    } else {
-                        $running_total = 0;
-                    }
-                    $pretax_total     = $running_total;
-                    $display_subtotal = true;
-                    // now add price modifiers
-                    foreach ($ticket->price_modifiers() as $price_mod) {
-                        if ($price_mod->is_tax()) {
-                            echo espressoSubtotalRow($running_total, $display_subtotal);
-                            $display_subtotal = false;
-                            $new_sub_total    = $pretax_total * ($price_mod->amount() / 100);
-                        } elseif ($price_mod->is_percent()) {
-                            $new_sub_total = $running_total * ($price_mod->amount() / 100);
-                        } else {
-                            $new_sub_total = $price_mod->amount();
-                        }
-                        $new_sub_total = $price_mod->is_discount()
-                            ? $new_sub_total * -1
-                            : $new_sub_total;
-                        $description   = $price_mod->desc() . ' ';
-                        $description   .= $price_mod->is_percent()
-                            ? $price_mod->amount() . '%'
-                            : EEH_Template::format_currency($price_mod->amount());
-                        ?>
+						$running_total = $ticket->base_price()->amount();
+					} else {
+						$running_total = 0;
+					}
+					$pretax_total     = $running_total;
+					$display_subtotal = true;
+					// now add price modifiers
+					foreach ($ticket->price_modifiers() as $price_mod) {
+						if ($price_mod->is_tax()) {
+							echo espressoSubtotalRow($running_total, $display_subtotal);
+							$display_subtotal = false;
+							$new_sub_total    = $pretax_total * ($price_mod->amount() / 100);
+						} elseif ($price_mod->is_percent()) {
+							$new_sub_total = $running_total * ($price_mod->amount() / 100);
+						} else {
+							$new_sub_total = $price_mod->amount();
+						}
+						$new_sub_total = $price_mod->is_discount()
+							? $new_sub_total * -1
+							: $new_sub_total;
+						$description   = $price_mod->desc() . ' ';
+						$description   .= $price_mod->is_percent()
+							? $price_mod->amount() . '%'
+							: EEH_Template::format_currency($price_mod->amount());
+						?>
                         <tr>
                             <td data-th="<?php esc_html_e('Name', 'event_espresso'); ?>"
                                 class="jst-rght small-text"
@@ -101,8 +101,8 @@ 
                         </tr>
                     <?php } ?>
                     <?php if ($ticket->taxable()) {
-                        echo espressoSubtotalRow($running_total);
-                        foreach ($ticket->get_ticket_taxes_for_admin() as $tax) { ?>
+						echo espressoSubtotalRow($running_total);
+						foreach ($ticket->get_ticket_taxes_for_admin() as $tax) { ?>
                             <tr>
                                 <td data-th="<?php esc_html_e('Name', 'event_espresso'); ?>"
                                     class="jst-rght small-text"
@@ -125,19 +125,19 @@ 
                         <td colspan="2" class="jst-rght small-text ttl-lbl-td">
                             <b>
                                 <?php echo esc_html(
-                                    apply_filters(
-                                        'FHEE__ticket_selector_chart_template__ticket_details_total_price',
-                                        __('Total', 'event_espresso')
-                                    )
-                                ); ?>
+									apply_filters(
+										'FHEE__ticket_selector_chart_template__ticket_details_total_price',
+										__('Total', 'event_espresso')
+									)
+								); ?>
                             </b>
                         </td>
                         <td data-th="<?php echo esc_html(
-                            apply_filters(
-                                'FHEE__ticket_selector_chart_template__ticket_details_total_price',
-                                __('Total', 'event_espresso')
-                            )
-                        ); ?>" class="jst-rght small-text"
+							apply_filters(
+								'FHEE__ticket_selector_chart_template__ticket_details_total_price',
+								__('Total', 'event_espresso')
+							)
+						); ?>" class="jst-rght small-text"
                         >
                             <b><?php echo EEH_Template::format_currency($running_total); ?></b>
                         </td>

Spacing +7 added lines, -7 removed lines

@@ -6,17 +6,17 @@ 
  * @var EE_Ticket $ticket
  */
 
-if (! function_exists('espressoSubtotalRow')) {
+if ( ! function_exists('espressoSubtotalRow')) {
     function espressoSubtotalRow(float $running_total, bool $show = true): string
     {
         return $show
             ? '
                 <tr>
                     <td colspan="2" class="jst-rght small-text sbttl">
-                        <b>' . esc_html__('subtotal', 'event_espresso') . '</b>
+                        <b>' . esc_html__('subtotal', 'event_espresso').'</b>
                     </td>
-                    <td data-th="' . esc_html__('subtotal', 'event_espresso') . '" class="jst-rght small-text">
-                        <b>' . EEH_Template::format_currency($running_total) . '</b>
+                    <td data-th="' . esc_html__('subtotal', 'event_espresso').'" class="jst-rght small-text">
+                        <b>' . EEH_Template::format_currency($running_total).'</b>
                     </td>
                 </tr>
             '
@@ -80,9 +80,9 @@ 
                         $new_sub_total = $price_mod->is_discount()
                             ? $new_sub_total * -1
                             : $new_sub_total;
-                        $description   = $price_mod->desc() . ' ';
-                        $description   .= $price_mod->is_percent()
-                            ? $price_mod->amount() . '%'
+                        $description   = $price_mod->desc().' ';
+                        $description .= $price_mod->is_percent()
+                            ? $price_mod->amount().'%'
                             : EEH_Template::format_currency($price_mod->amount());
                         ?>
                         <tr>