Completed
Branch BUG-5580-mike-implementation (468206)
by
unknown
08:00 queued 1434:13
created
core/db_models/helpers/EE_Unique_Index.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -4,7 +4,7 @@
 block discarded – undo
4 4
  * Used to indicate  a UNIQUE key index - ie, a set of fields which must be unique
5 5
  * for ALL the model objects of this type
6 6
  */
7
-class EE_Unique_Index extends EE_Index{
7
+class EE_Unique_Index extends EE_Index {
8 8
 	//yep, actually the same as index right now
9 9
 	
10 10
 }
Please login to merge, or discard this patch.
core/db_models/relations/EE_Belongs_To_Any_Relation.php 1 patch
Spacing   +5 added lines, -5 removed lines patch added patch discarded remove patch
@@ -6,7 +6,7 @@  discard block
 block discarded – undo
6 6
  * in order to specify which model the foreign key points to (eg, the foreign key may have a value of 34, but is that Transaction with
7 7
  * ID 34 or Registration with ID 34? The EE_Any_Foreign_Model_name_Field specifies which of the two). 
8 8
  */
9
-require_once( EE_MODELS . 'relations/EE_Belongs_To_Relation.php');
9
+require_once(EE_MODELS.'relations/EE_Belongs_To_Relation.php');
10 10
 
11 11
 class EE_Belongs_To_Any_Relation extends EE_Belongs_To_Relation {
12 12
 
@@ -19,8 +19,8 @@  discard block
 block discarded – undo
19 19
 		
20 20
 		
21 21
 		$other_table_pk_field = $this->get_other_model()->get_primary_key_field();
22
-		$this_table_alias = EE_Model_Parser::extract_table_alias_model_relation_chain_prefix($model_relation_chain,$this->get_this_model()->get_this_model_name()) . $this_table_fk_field->get_table_alias();
23
-		$other_table_alias = EE_Model_Parser::extract_table_alias_model_relation_chain_prefix($model_relation_chain, $this->get_other_model()->get_this_model_name()) . $other_table_pk_field->get_table_alias();
22
+		$this_table_alias = EE_Model_Parser::extract_table_alias_model_relation_chain_prefix($model_relation_chain, $this->get_this_model()->get_this_model_name()).$this_table_fk_field->get_table_alias();
23
+		$other_table_alias = EE_Model_Parser::extract_table_alias_model_relation_chain_prefix($model_relation_chain, $this->get_other_model()->get_this_model_name()).$other_table_pk_field->get_table_alias();
24 24
 		$other_table = $this->get_other_model()->get_table_for_alias($other_table_alias);
25 25
 		return $this->_left_join($other_table, 
26 26
 				$other_table_alias, 
@@ -58,12 +58,12 @@  discard block
 block discarded – undo
58 58
 	 */
59 59
 	function remove_relation_to($this_obj_or_id, $other_obj_or_id) {
60 60
 		$this_model_obj = $this->get_this_model()->ensure_is_obj($this_obj_or_id, true);
61
-		$other_model_obj = $this->get_other_model()->ensure_is_obj( $other_obj_or_id );
61
+		$other_model_obj = $this->get_other_model()->ensure_is_obj($other_obj_or_id);
62 62
 		//find the field on th eother model which is a foreign key to this model
63 63
 		$fk_on_this_model = $this->get_this_model()->get_foreign_key_to($this->get_other_model()->get_this_model_name());
64 64
 		//set that field on the other model to this model's ID
65 65
 		$this_model_obj->set($fk_on_this_model->get_name(), null, true);
66
-		$this_model_obj->set($this->get_this_model()->get_field_containing_related_model_name()->get_name(),null,true);
66
+		$this_model_obj->set($this->get_this_model()->get_field_containing_related_model_name()->get_name(), null, true);
67 67
 		$this_model_obj->save();
68 68
 		return $other_model_obj;
69 69
 	}
Please login to merge, or discard this patch.
core/db_models/relations/EE_Has_Many_Any_Relation.php 1 patch
Spacing   +9 added lines, -9 removed lines patch added patch discarded remove patch
@@ -7,16 +7,16 @@  discard block
 block discarded – undo
7 7
  * ID 34 or Registration with ID 34? The EE_Any_Foreign_Model_name_Field specifies which of the two).
8 8
  *
9 9
  */
10
-require_once( EE_MODELS . 'relations/EE_Model_Relation_Base.php');
11
-class EE_Has_Many_Any_Relation extends EE_Has_Many_Relation{
10
+require_once(EE_MODELS.'relations/EE_Model_Relation_Base.php');
11
+class EE_Has_Many_Any_Relation extends EE_Has_Many_Relation {
12 12
 
13
-	function get_join_statement($model_relation_chain){
13
+	function get_join_statement($model_relation_chain) {
14 14
 		//create the sql string like
15 15
 		// LEFT JOIN other_table AS table_alias ON this_table_alias.pk = other_table_alias.fk extra_join_conditions
16 16
 		$this_table_pk_field = $this->get_this_model()->get_primary_key_field();
17 17
 		$other_table_fk_field = $this->get_other_model()->get_foreign_key_to($this->get_this_model()->get_this_model_name());
18
-		$pk_table_alias = EE_Model_Parser::extract_table_alias_model_relation_chain_prefix($model_relation_chain, $this->get_this_model()->get_this_model_name()) . $this_table_pk_field->get_table_alias();
19
-		$fk_table_alias = EE_Model_Parser::extract_table_alias_model_relation_chain_prefix($model_relation_chain, $this->get_other_model()->get_this_model_name()) . $other_table_fk_field->get_table_alias();
18
+		$pk_table_alias = EE_Model_Parser::extract_table_alias_model_relation_chain_prefix($model_relation_chain, $this->get_this_model()->get_this_model_name()).$this_table_pk_field->get_table_alias();
19
+		$fk_table_alias = EE_Model_Parser::extract_table_alias_model_relation_chain_prefix($model_relation_chain, $this->get_other_model()->get_this_model_name()).$other_table_fk_field->get_table_alias();
20 20
 		$fk_table = $this->get_other_model()->get_table_for_alias($fk_table_alias);
21 21
 		$field_with_model_name = $this->get_other_model()->get_field_containing_related_model_name();
22 22
 
@@ -25,7 +25,7 @@  discard block
 block discarded – undo
25 25
 				$other_table_fk_field->get_table_column(),
26 26
 				$pk_table_alias,
27 27
 				$this_table_pk_field->get_table_column(),
28
-				$fk_table_alias . '.' . $field_with_model_name->get_table_column() . "='" . $this->get_this_model()->get_this_model_name() . "'" )
28
+				$fk_table_alias.'.'.$field_with_model_name->get_table_column()."='".$this->get_this_model()->get_this_model_name()."'")
29 29
 				.$this->get_other_model()->_construct_internal_join_to_table_with_alias($fk_table_alias);
30 30
 	}
31 31
 	/**
@@ -34,7 +34,7 @@  discard block
 block discarded – undo
34 34
 	 * @param EE_Base_Class/int $other_obj_or_id
35 35
 	 * @return EE_Base_Class
36 36
 	 */
37
-	 function add_relation_to($this_obj_or_id, $other_obj_or_id ){
37
+	 function add_relation_to($this_obj_or_id, $other_obj_or_id) {
38 38
 		 $this_model_obj = $this->get_this_model()->ensure_is_obj($this_obj_or_id, true);
39 39
 		 $other_model_obj = $this->get_other_model()->ensure_is_obj($other_obj_or_id, true);
40 40
 
@@ -53,12 +53,12 @@  discard block
 block discarded – undo
53 53
 	 * @param EE_Base_Class/int $other_obj_or_id
54 54
 	 * @return EE_Base_Class
55 55
 	 */
56
-	 function remove_relation_to($this_obj_or_id, $other_obj_or_id){
56
+	 function remove_relation_to($this_obj_or_id, $other_obj_or_id) {
57 57
 		 $other_model_obj = $this->get_other_model()->ensure_is_obj($other_obj_or_id, true);
58 58
 		 //find the field on th eother model which is a foreign key to this model
59 59
 		 $fk_field_on_other_model = $this->get_other_model()->get_foreign_key_to($this->get_this_model()->get_this_model_name());
60 60
 		 //set that field on the other model to this model's ID
61
-		 $other_model_obj->set($fk_field_on_other_model->get_name(),null, true);
61
+		 $other_model_obj->set($fk_field_on_other_model->get_name(), null, true);
62 62
 		 $other_model_obj->set($this->get_other_model()->get_field_containing_related_model_name()->get_name(), null, true);
63 63
 		 $other_model_obj->save();
64 64
 		 return $other_model_obj;
Please login to merge, or discard this patch.
core/db_models/relations/EE_Has_Many_Relation.php 1 patch
Spacing   +10 added lines, -10 removed lines patch added patch discarded remove patch
@@ -4,8 +4,8 @@  discard block
 block discarded – undo
4 4
 /**
5 5
  * In this relation, the OTHER model ahs the foreign key pointing to this model
6 6
  */
7
-require_once( EE_MODELS . 'relations/EE_Model_Relation_Base.php');
8
-class EE_Has_Many_Relation extends EE_Model_Relation_Base{	
7
+require_once(EE_MODELS.'relations/EE_Model_Relation_Base.php');
8
+class EE_Has_Many_Relation extends EE_Model_Relation_Base {	
9 9
 	
10 10
 	/**
11 11
 	 * Object representing the relationship between two models. Has_Many_Relations are where the OTHER model has the foreign key
@@ -15,16 +15,16 @@  discard block
 block discarded – undo
15 15
 	 * @param boolean $block_deletes For this type of relation, we block by default. If there are related models across this relation, block (prevent and add an error) the deletion of this model
16 16
 	 * @param type $blocking_delete_error_message a customized error message on blocking deletes instead of the default
17 17
 	 */
18
-	function __construct($block_deletes = true, $blocking_delete_error_message = null){
18
+	function __construct($block_deletes = true, $blocking_delete_error_message = null) {
19 19
 		parent::__construct($block_deletes, $blocking_delete_error_message);
20 20
 	}
21
-	function get_join_statement($model_relation_chain){
21
+	function get_join_statement($model_relation_chain) {
22 22
 		//create the sql string like
23 23
 		// LEFT JOIN other_table AS table_alias ON this_table_alias.pk = other_table_alias.fk extra_join_conditions
24 24
 		$this_table_pk_field = $this->get_this_model()->get_primary_key_field();
25 25
 		$other_table_fk_field = $this->get_other_model()->get_foreign_key_to($this->get_this_model()->get_this_model_name());
26
-		$pk_table_alias = EE_Model_Parser::extract_table_alias_model_relation_chain_prefix($model_relation_chain, $this->get_this_model()->get_this_model_name()) . $this_table_pk_field->get_table_alias();
27
-		$fk_table_alias = EE_Model_Parser::extract_table_alias_model_relation_chain_prefix($model_relation_chain, $this->get_other_model()->get_this_model_name()) . $other_table_fk_field->get_table_alias();
26
+		$pk_table_alias = EE_Model_Parser::extract_table_alias_model_relation_chain_prefix($model_relation_chain, $this->get_this_model()->get_this_model_name()).$this_table_pk_field->get_table_alias();
27
+		$fk_table_alias = EE_Model_Parser::extract_table_alias_model_relation_chain_prefix($model_relation_chain, $this->get_other_model()->get_this_model_name()).$other_table_fk_field->get_table_alias();
28 28
 		$fk_table = $this->get_other_model()->get_table_for_alias($fk_table_alias);
29 29
 		
30 30
 		return $this->_left_join($fk_table, $fk_table_alias, $other_table_fk_field->get_table_column(), $pk_table_alias, $this_table_pk_field->get_table_column()).$this->get_other_model()->_construct_internal_join_to_table_with_alias($fk_table_alias);
@@ -35,13 +35,13 @@  discard block
 block discarded – undo
35 35
 	 * @param EE_Base_Class/int $other_obj_or_id
36 36
 	 * @return EE_Base_Class
37 37
 	 */
38
-	 function add_relation_to($this_obj_or_id, $other_obj_or_id ){
38
+	 function add_relation_to($this_obj_or_id, $other_obj_or_id) {
39 39
 		 $this_model_obj = $this->get_this_model()->ensure_is_obj($this_obj_or_id, true);
40 40
 		 $other_model_obj = $this->get_other_model()->ensure_is_obj($other_obj_or_id, true);
41 41
 		 
42 42
 		 //find the field on th eother model which is a foreign key to this model
43 43
 		 $fk_field_on_other_model = $this->get_other_model()->get_foreign_key_to($this->get_this_model()->get_this_model_name());
44
-		 if($other_model_obj->get($fk_field_on_other_model->get_name()) != $this_model_obj->ID()){
44
+		 if ($other_model_obj->get($fk_field_on_other_model->get_name()) != $this_model_obj->ID()) {
45 45
 			//set that field on the other model to this model's ID
46 46
 			$other_model_obj->set($fk_field_on_other_model->get_name(), $this_model_obj->ID());
47 47
 			$other_model_obj->save();
@@ -55,12 +55,12 @@  discard block
 block discarded – undo
55 55
 	 * @param EE_Base_Class/int $other_obj_or_id
56 56
 	 * @return EE_Base_Class
57 57
 	 */
58
-	 function remove_relation_to($this_obj_or_id, $other_obj_or_id){
58
+	 function remove_relation_to($this_obj_or_id, $other_obj_or_id) {
59 59
 		 $other_model_obj = $this->get_other_model()->ensure_is_obj($other_obj_or_id, true);
60 60
 		 //find the field on th eother model which is a foreign key to this model
61 61
 		 $fk_field_on_other_model = $this->get_other_model()->get_foreign_key_to($this->get_this_model()->get_this_model_name());
62 62
 		 //set that field on the other model to this model's ID
63
-		 $other_model_obj->set($fk_field_on_other_model->get_name(),null, true);
63
+		 $other_model_obj->set($fk_field_on_other_model->get_name(), null, true);
64 64
 		 $other_model_obj->save();
65 65
 		 return $other_model_obj;
66 66
 	 }
Please login to merge, or discard this patch.
core/db_models/strategies/EE_Default_Where_Conditions.strategy.php 2 patches
Spacing   +22 added lines, -22 removed lines patch added patch discarded remove patch
@@ -4,7 +4,7 @@  discard block
 block discarded – undo
4 4
  * Strategy to be used for getting default where conditions for EEM_Base children.
5 5
  * Should be initialized and set on construction of model
6 6
  */
7
-class EE_Default_Where_Conditions{
7
+class EE_Default_Where_Conditions {
8 8
 	/**
9 9
 	 * This const can be used in EE_Default_Where_Conditions values, and at the time of querying it will be
10 10
 	 * replaced with the current user's ID (because we don't want to use the current user's ID at time of
@@ -36,7 +36,7 @@  discard block
 block discarded – undo
36 36
 	 * onto any field names
37 37
 	 * @param array $custom_where_conditions
38 38
 	 */
39
-	public function __construct( $custom_where_conditions = array() ) {
39
+	public function __construct($custom_where_conditions = array()) {
40 40
 		$this->_where_conditions_provided = $custom_where_conditions;
41 41
 	}
42 42
 
@@ -45,7 +45,7 @@  discard block
 block discarded – undo
45 45
 	 * for querying of the model.
46 46
 	 * @param EEM_Base $model
47 47
 	 */
48
-	function _finalize_construct(EEM_Base $model){
48
+	function _finalize_construct(EEM_Base $model) {
49 49
 		$this->_model = $model;
50 50
 	}
51 51
 	/**
@@ -60,15 +60,15 @@  discard block
 block discarded – undo
60 60
 	 * @param string $model_relation_chain
61 61
 	 * @return array like what's expected in EEM_Base::get_all()'s $query_params[0]
62 62
 	 */
63
-	function get_default_where_conditions( $model_relation_chain = '' ){
64
-		return $this->prepare_where_conditions_for_querying( array_merge( $this->_get_default_where_conditions(), $this->get_where_conditions_provided() ), $model_relation_chain );
63
+	function get_default_where_conditions($model_relation_chain = '') {
64
+		return $this->prepare_where_conditions_for_querying(array_merge($this->_get_default_where_conditions(), $this->get_where_conditions_provided()), $model_relation_chain);
65 65
 	}
66 66
 	/**
67 67
 	 * Gets the default where conditions that are specific to this child of EE_Default_Where_Conditions.
68 68
 	 * Adding model relation chains is handled by the public method get_default_where_conditions
69 69
 	 * @return array
70 70
 	 */
71
-	protected function _get_default_where_conditions(){
71
+	protected function _get_default_where_conditions() {
72 72
 		return array();
73 73
 	}
74 74
 
@@ -82,33 +82,33 @@  discard block
 block discarded – undo
82 82
 	 * @return array
83 83
 	 * @throws \EE_Error
84 84
 	 */
85
-	public function prepare_where_conditions_for_querying( $where_conditions, $model_relation_chain ) {
85
+	public function prepare_where_conditions_for_querying($where_conditions, $model_relation_chain) {
86 86
 		$where_conditions_with_model_relation_chain_prefixes = array();
87
-		if( ! is_array( $where_conditions ) ){
87
+		if ( ! is_array($where_conditions)) {
88 88
 			$where_conditions = array();
89 89
 		}
90
-		foreach( $where_conditions as $key => $value ) {
91
-			if( in_array( $key, array( 'OR', 'AND', 'NOT' ) ) ||
92
-			strpos( $key, 'OR*' )  !== false ||
93
-					strpos( $key, 'AND*' ) !== false ||
94
-					strpos( $key, 'NOT*' ) !== false ){
95
-				$where_conditions_with_model_relation_chain_prefixes[ $key ] = $this->prepare_where_conditions_for_querying( $value, $model_relation_chain );
96
-			}else{
97
-				if($model_relation_chain != '' && $model_relation_chain[strlen($model_relation_chain)-1] !='.'){
98
-					$model_relation_chain=$model_relation_chain.".";
90
+		foreach ($where_conditions as $key => $value) {
91
+			if (in_array($key, array('OR', 'AND', 'NOT')) ||
92
+			strpos($key, 'OR*') !== false ||
93
+					strpos($key, 'AND*') !== false ||
94
+					strpos($key, 'NOT*') !== false) {
95
+				$where_conditions_with_model_relation_chain_prefixes[$key] = $this->prepare_where_conditions_for_querying($value, $model_relation_chain);
96
+			} else {
97
+				if ($model_relation_chain != '' && $model_relation_chain[strlen($model_relation_chain) - 1] != '.') {
98
+					$model_relation_chain = $model_relation_chain.".";
99 99
 				}
100 100
 				//check for the current user id place holder, and if present change it
101
-				if( $value === self::current_user_placeholder ){
101
+				if ($value === self::current_user_placeholder) {
102 102
 					$value = get_current_user_id();
103 103
 				}
104 104
 				//check for user field placeholder
105
-				if( $key == self::user_field_name_placeholder ) {
106
-					if( ! $this->_model->wp_user_field_name() ) {
107
-						throw new EE_Error( sprintf( __( 'There is no foreign key to the WP_User model on model %s. Please either modify your default where conditions, add a _model_chain_to_wp_user onto the model, or a proper EE_WP_User_Field onto the model', 'event_espresso' ), $this->_model->get_this_model_name() ) );
105
+				if ($key == self::user_field_name_placeholder) {
106
+					if ( ! $this->_model->wp_user_field_name()) {
107
+						throw new EE_Error(sprintf(__('There is no foreign key to the WP_User model on model %s. Please either modify your default where conditions, add a _model_chain_to_wp_user onto the model, or a proper EE_WP_User_Field onto the model', 'event_espresso'), $this->_model->get_this_model_name()));
108 108
 					}
109 109
 					$key = $this->_model->wp_user_field_name();
110 110
 				}
111
-				$where_conditions_with_model_relation_chain_prefixes[ $model_relation_chain . $key ] = $value;
111
+				$where_conditions_with_model_relation_chain_prefixes[$model_relation_chain.$key] = $value;
112 112
 			}
113 113
 		}
114 114
 		return $where_conditions_with_model_relation_chain_prefixes;
Please login to merge, or discard this patch.
Braces   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -33,7 +33,7 @@
 block discarded – undo
33 33
 		if( $normalized_value ){
34 34
 			if (filter_var($normalized_value, FILTER_VALIDATE_URL) === false){
35 35
 				throw new EE_Validation_Error( $this->get_validation_error_message(), 'invalid_url');
36
-			}else{
36
+			} else{
37 37
 				EE_Registry::instance()->load_helper('URL');
38 38
 				if( ! EEH_URL::remote_file_exists(
39 39
 						$normalized_value,
Please login to merge, or discard this patch.
core/db_models/strategies/EE_Restriction_Generator_Base.strategy.php 2 patches
Spacing   +23 added lines, -23 removed lines patch added patch discarded remove patch
@@ -1,6 +1,6 @@  discard block
 block discarded – undo
1 1
 <?php
2
-if ( !defined( 'EVENT_ESPRESSO_VERSION' ) ) {
3
-	exit( 'No direct script access allowed' );
2
+if ( ! defined('EVENT_ESPRESSO_VERSION')) {
3
+	exit('No direct script access allowed');
4 4
 }
5 5
 
6 6
 /**
@@ -53,7 +53,7 @@  discard block
 block discarded – undo
53 53
 	 * @param EEM_Base $model
54 54
 	 * @param string $action
55 55
 	 */
56
-	public function _construct_finalize( EEM_Base $model, $action ){
56
+	public function _construct_finalize(EEM_Base $model, $action) {
57 57
 		$this->_model = $model;
58 58
 		$this->_action = $action;
59 59
 	}
@@ -65,8 +65,8 @@  discard block
 block discarded – undo
65 65
 	 * @return EEM_Base | EEM_Soft_Delete_Base
66 66
 	 */
67 67
 	public function model() {
68
-		if( ! $this->_model instanceof EEM_Base ) {
69
-			throw new EE_Error( sprintf( __( 'Cannot generate capability restrictions because model has not yet been set on the %s. Please ensure _construct_finalize() was called', 'event_espresso' ), get_class( $this ) ) );
68
+		if ( ! $this->_model instanceof EEM_Base) {
69
+			throw new EE_Error(sprintf(__('Cannot generate capability restrictions because model has not yet been set on the %s. Please ensure _construct_finalize() was called', 'event_espresso'), get_class($this)));
70 70
 		}
71 71
 		return $this->_model;
72 72
 	}
@@ -79,8 +79,8 @@  discard block
 block discarded – undo
79 79
 	 * @return string
80 80
 	 */
81 81
 	public function action() {
82
-		if( ! $this->_action ) {
83
-			throw new EE_Error( sprintf( __( 'Cannot generate capability restrictions because model has not yet been set on the %s. Please ensure _construct_finalize() was called', 'event_espresso' ), get_class( $this ) ) );
82
+		if ( ! $this->_action) {
83
+			throw new EE_Error(sprintf(__('Cannot generate capability restrictions because model has not yet been set on the %s. Please ensure _construct_finalize() was called', 'event_espresso'), get_class($this)));
84 84
 		}
85 85
 		return $this->_action;
86 86
 	}
@@ -89,10 +89,10 @@  discard block
 block discarded – undo
89 89
 	 * Returns whether or not _construct_finalize() has been called on this restriction generator object
90 90
 	 * @return boolean
91 91
 	 */
92
-	public function construction_finalized(){
93
-		if( $this->_model instanceof EEM_Base  && $this->_action ){
92
+	public function construction_finalized() {
93
+		if ($this->_model instanceof EEM_Base && $this->_action) {
94 94
 			return true;
95
-		}else{
95
+		} else {
96 96
 			return false;
97 97
 		}
98 98
 	}
@@ -103,10 +103,10 @@  discard block
 block discarded – undo
103 103
 	 * @return array @see EEM_Base::_cap_restrictions
104 104
 	 */
105 105
 	public function generate_restrictions() {
106
-		if( $this->_cap_restrictions_generated === false ) {
107
-			$this->_cap_restrictions_generated = apply_filters( 'FHEE__EE_Restriction_Generator_Base__generate_restrictions__first_time', $this->_generate_restrictions(), $this );
106
+		if ($this->_cap_restrictions_generated === false) {
107
+			$this->_cap_restrictions_generated = apply_filters('FHEE__EE_Restriction_Generator_Base__generate_restrictions__first_time', $this->_generate_restrictions(), $this);
108 108
 		}
109
-		return apply_filters( 'FHEE__EE_Restriction_Generator_Base__generate_restrictions__every_time', $this->_cap_restrictions_generated, $this );
109
+		return apply_filters('FHEE__EE_Restriction_Generator_Base__generate_restrictions__every_time', $this->_cap_restrictions_generated, $this);
110 110
 	}
111 111
 
112 112
 	/**
@@ -122,10 +122,10 @@  discard block
 block discarded – undo
122 122
 	 * making restrictions and caching them on itself in case its asked later
123 123
 	 * @return boolean
124 124
 	 */
125
-	public function has_generated_cap_restrictions(){
126
-		if( $this->_cap_restrictions_generated === false ){
125
+	public function has_generated_cap_restrictions() {
126
+		if ($this->_cap_restrictions_generated === false) {
127 127
 			return false;
128
-		}else{
128
+		} else {
129 129
 			return true;
130 130
 		}
131 131
 	}
@@ -139,8 +139,8 @@  discard block
 block discarded – undo
139 139
 	 * @param string $action
140 140
 	 * @return string
141 141
 	 */
142
-	public static function get_cap_name( $model, $action ) {
143
-		return apply_filters( 'FHEE__EE_Restriction_Generator__get_cap_name', ( $model->is_wp_core_model() ? '' : 'ee_' ) . $action . '_' . $model->cap_slug(), $model, $action );
142
+	public static function get_cap_name($model, $action) {
143
+		return apply_filters('FHEE__EE_Restriction_Generator__get_cap_name', ($model->is_wp_core_model() ? '' : 'ee_').$action.'_'.$model->cap_slug(), $model, $action);
144 144
 	}
145 145
 
146 146
 	/**
@@ -149,11 +149,11 @@  discard block
 block discarded – undo
149 149
 	 * @param string $action
150 150
 	 * @return boolean
151 151
 	 */
152
-	public static function is_cap( $model, $action ) {
153
-		$caps_for_admin = EE_Registry::instance()->CAP->get_ee_capabilities( 'administrator' );
154
-		if( in_array( self::get_cap_name( $model, $action ), $caps_for_admin ) ) {
152
+	public static function is_cap($model, $action) {
153
+		$caps_for_admin = EE_Registry::instance()->CAP->get_ee_capabilities('administrator');
154
+		if (in_array(self::get_cap_name($model, $action), $caps_for_admin)) {
155 155
 			return true;
156
-		}else{
156
+		} else {
157 157
 			return false;
158 158
 		}
159 159
 	}
@@ -164,7 +164,7 @@  discard block
 block discarded – undo
164 164
 	 * @return string
165 165
 	 */
166 166
 	public static function get_default_restrictions_cap() {
167
-		return apply_filters( 'FHEE__EE_Restriction_Generator_Base__default_restrictions_cap', 'manage_options' );
167
+		return apply_filters('FHEE__EE_Restriction_Generator_Base__default_restrictions_cap', 'manage_options');
168 168
 	}
169 169
 }
170 170
 
Please login to merge, or discard this patch.
Braces   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -92,7 +92,7 @@  discard block
 block discarded – undo
92 92
 	public function construction_finalized(){
93 93
 		if( $this->_model instanceof EEM_Base  && $this->_action ){
94 94
 			return true;
95
-		}else{
95
+		} else{
96 96
 			return false;
97 97
 		}
98 98
 	}
@@ -125,7 +125,7 @@  discard block
 block discarded – undo
125 125
 	public function has_generated_cap_restrictions(){
126 126
 		if( $this->_cap_restrictions_generated === false ){
127 127
 			return false;
128
-		}else{
128
+		} else{
129 129
 			return true;
130 130
 		}
131 131
 	}
@@ -153,7 +153,7 @@  discard block
 block discarded – undo
153 153
 		$caps_for_admin = EE_Registry::instance()->CAP->get_ee_capabilities( 'administrator' );
154 154
 		if( in_array( self::get_cap_name( $model, $action ), $caps_for_admin ) ) {
155 155
 			return true;
156
-		}else{
156
+		} else{
157 157
 			return false;
158 158
 		}
159 159
 	}
Please login to merge, or discard this patch.
strategies/EE_Restriction_Generator_Default_Protected.strategy.php 1 patch
Spacing   +22 added lines, -22 removed lines patch added patch discarded remove patch
@@ -1,7 +1,7 @@  discard block
 block discarded – undo
1 1
 <?php
2 2
 
3
-if ( !defined( 'EVENT_ESPRESSO_VERSION' ) ) {
4
-	exit( 'No direct script access allowed' );
3
+if ( ! defined('EVENT_ESPRESSO_VERSION')) {
4
+	exit('No direct script access allowed');
5 5
 }
6 6
 
7 7
 /**
@@ -40,9 +40,9 @@  discard block
 block discarded – undo
40 40
 	 * @param string $path_to_event_model The model chain to follow to get to the event model, including the event model itself.
41 41
 	 * Eg 'Ticket.Datetime.Event'
42 42
 	 */
43
-	public function __construct( $default_field_name, $path_to_event_model ) {
43
+	public function __construct($default_field_name, $path_to_event_model) {
44 44
 		$this->_default_field_name = $default_field_name;
45
-		if( substr( $path_to_event_model, -1, 1 ) != '.' ) {
45
+		if (substr($path_to_event_model, -1, 1) != '.') {
46 46
 			$path_to_event_model .= '.';
47 47
 		}
48 48
 		$this->_path_to_event_model = $path_to_event_model;
@@ -57,7 +57,7 @@  discard block
 block discarded – undo
57 57
 	protected function _generate_restrictions( ) {
58 58
 		//if there are no standard caps for this model, then for now all we know is
59 59
 		//if they need the default cap to access this
60
-		if ( ! $this->model()->cap_slug() ) {
60
+		if ( ! $this->model()->cap_slug()) {
61 61
 			return array(
62 62
 				self::get_default_restrictions_cap() => new EE_Return_None_Where_Conditions()
63 63
 			);
@@ -65,37 +65,37 @@  discard block
 block discarded – undo
65 65
 
66 66
 		$event_model = EEM_Event::instance();
67 67
 
68
-		$restrictions =  array(
68
+		$restrictions = array(
69 69
 			//first: basically access to non-defaults is essentially controlled by which events are accessible
70 70
 			//if they don't have the basic event cap, they can't access ANY non-default items
71
-			EE_Restriction_Generator_Base::get_cap_name($event_model, $this->action()) => new EE_Default_Where_Conditions( array( $this->_default_field_name => true ) ),
71
+			EE_Restriction_Generator_Base::get_cap_name($event_model, $this->action()) => new EE_Default_Where_Conditions(array($this->_default_field_name => true)),
72 72
 			//if they don't have the others event cap, they can't access others' non-default items
73
-			EE_Restriction_Generator_Base::get_cap_name($event_model, $this->action() . '_others' ) => new EE_Default_Where_Conditions( array(
74
-				'OR*no_' . EE_Restriction_Generator_Base::get_cap_name($event_model, $this->action() . '_others' ) => array(
75
-					$this->_path_to_event_model . 'EVT_wp_user' => EE_Default_Where_Conditions::current_user_placeholder ),
76
-					$this->_default_field_name => true ) ),
73
+			EE_Restriction_Generator_Base::get_cap_name($event_model, $this->action().'_others') => new EE_Default_Where_Conditions(array(
74
+				'OR*no_'.EE_Restriction_Generator_Base::get_cap_name($event_model, $this->action().'_others') => array(
75
+					$this->_path_to_event_model.'EVT_wp_user' => EE_Default_Where_Conditions::current_user_placeholder ),
76
+					$this->_default_field_name => true )),
77 77
 			//if they have basic and others, but not private, they can't access others' private non-default items
78
-			EE_Restriction_Generator_Base::get_cap_name($event_model, $this->action() . '_private' ) => new EE_Default_Where_Conditions(array(
79
-				'OR*no_' .EE_Restriction_Generator_Base::get_cap_name($event_model, $this->action() . '_private' ) => array(
80
-				$this->_path_to_event_model . 'EVT_wp_user' => EE_Default_Where_Conditions::current_user_placeholder,
81
-				$this->_path_to_event_model . 'status' => array( '!=', 'private' ),
82
-				$this->_default_field_name => true ) ) ),
78
+			EE_Restriction_Generator_Base::get_cap_name($event_model, $this->action().'_private') => new EE_Default_Where_Conditions(array(
79
+				'OR*no_'.EE_Restriction_Generator_Base::get_cap_name($event_model, $this->action().'_private') => array(
80
+				$this->_path_to_event_model.'EVT_wp_user' => EE_Default_Where_Conditions::current_user_placeholder,
81
+				$this->_path_to_event_model.'status' => array('!=', 'private'),
82
+				$this->_default_field_name => true ) )),
83 83
 			//second: access to defaults is controlled by the defaulty capabilities
84 84
 			//if they don't have the default capability, restrict access to only non-default items
85
-			EE_Restriction_Generator_Base::get_cap_name( $this->model(), $this->action() . '_default' )	=> new EE_Default_Where_Conditions( array( $this->_default_field_name => false ) ),
85
+			EE_Restriction_Generator_Base::get_cap_name($this->model(), $this->action().'_default')	=> new EE_Default_Where_Conditions(array($this->_default_field_name => false)),
86 86
 			//if they don't have the "others" default capability, restrict access to only their default ones, and non-default ones
87 87
 			 );
88
-		if( EE_Restriction_Generator_Base::is_cap(  $this->model(), $this->action() . '_others_default' ) ) {
89
-			$restrictions[ EE_Restriction_Generator_Base::get_cap_name( $this->model(), $this->action() . '_others_default' ) ] = new EE_Default_Where_Conditions( array(
88
+		if (EE_Restriction_Generator_Base::is_cap($this->model(), $this->action().'_others_default')) {
89
+			$restrictions[EE_Restriction_Generator_Base::get_cap_name($this->model(), $this->action().'_others_default')] = new EE_Default_Where_Conditions(array(
90 90
 					//if they don't have the others default cap, they can't access others default items (but they can access
91 91
 					//their own default items, and non-default items)
92
-					'OR*no_' . EE_Restriction_Generator_Base::get_cap_name( $this->model(), $this->action() . '_others_default' ) => array(
92
+					'OR*no_'.EE_Restriction_Generator_Base::get_cap_name($this->model(), $this->action().'_others_default') => array(
93 93
 						'AND' => array(
94
-							$this->_path_to_event_model . 'EVT_wp_user' => EE_Default_Where_Conditions::current_user_placeholder,
94
+							$this->_path_to_event_model.'EVT_wp_user' => EE_Default_Where_Conditions::current_user_placeholder,
95 95
 							$this->_default_field_name => true
96 96
 							),
97 97
 						$this->_default_field_name => false
98
-					) ) );
98
+					) ));
99 99
 		}
100 100
 		return $restrictions;
101 101
 
Please login to merge, or discard this patch.
db_models/strategies/EE_Restriction_Generator_Default_Public.strategy.php 2 patches
Indentation   +4 added lines, -4 removed lines patch added patch discarded remove patch
@@ -21,10 +21,10 @@
 block discarded – undo
21 21
  */
22 22
 class EE_Restriction_Generator_Default_Public extends EE_Restriction_Generator_Base {
23 23
 /**
24
-	 * Name of the field on this model (or a related model, including the model chain to it)
25
-	 * that is a boolean indicating whether or not a model object is considered "Default" or not
26
-	 * @var string
27
-	 */
24
+ * Name of the field on this model (or a related model, including the model chain to it)
25
+ * that is a boolean indicating whether or not a model object is considered "Default" or not
26
+ * @var string
27
+ */
28 28
 	protected $_default_field_name;
29 29
 
30 30
 	/**
Please login to merge, or discard this patch.
Spacing   +22 added lines, -22 removed lines patch added patch discarded remove patch
@@ -1,7 +1,7 @@  discard block
 block discarded – undo
1 1
 <?php
2 2
 
3
-if ( !defined( 'EVENT_ESPRESSO_VERSION' ) ) {
4
-	exit( 'No direct script access allowed' );
3
+if ( ! defined('EVENT_ESPRESSO_VERSION')) {
4
+	exit('No direct script access allowed');
5 5
 }
6 6
 
7 7
 /**
@@ -40,9 +40,9 @@  discard block
 block discarded – undo
40 40
 	 * @param string $path_to_event_model The model chain to follow to get to the event model, including the event model itself.
41 41
 	 * Eg 'Ticket.Datetime.Event'
42 42
 	 */
43
-	public function __construct( $default_field_name, $path_to_event_model ) {
43
+	public function __construct($default_field_name, $path_to_event_model) {
44 44
 		$this->_default_field_name = $default_field_name;
45
-		if( substr( $path_to_event_model, -1, 1 ) != '.' ) {
45
+		if (substr($path_to_event_model, -1, 1) != '.') {
46 46
 			$path_to_event_model .= '.';
47 47
 		}
48 48
 		$this->_path_to_event_model = $path_to_event_model;
@@ -55,7 +55,7 @@  discard block
 block discarded – undo
55 55
 	protected function _generate_restrictions() {
56 56
 		//if there are no standard caps for this model, then for now all we know
57 57
 		//if they need the default cap to access this
58
-		if ( !$this->model()->cap_slug() ) {
58
+		if ( ! $this->model()->cap_slug()) {
59 59
 			return array(
60 60
 				self::get_default_restrictions_cap() => new EE_Return_None_Where_Conditions()
61 61
 			);
@@ -66,45 +66,45 @@  discard block
 block discarded – undo
66 66
 		$restrictions = array(
67 67
 			//first: basically access to non-defaults is essentially controlled by which events are accessible
68 68
 			//if they don't have the basic event cap, they can't access ANY non-default items
69
-			EE_Restriction_Generator_Base::get_cap_name( $event_model, $this->action() ) => new EE_Default_Where_Conditions( array(
70
-				'OR*no_' . EE_Restriction_Generator_Base::get_cap_name( $event_model, $this->action() ) => array(
69
+			EE_Restriction_Generator_Base::get_cap_name($event_model, $this->action()) => new EE_Default_Where_Conditions(array(
70
+				'OR*no_'.EE_Restriction_Generator_Base::get_cap_name($event_model, $this->action()) => array(
71 71
 					$this->_default_field_name             => true,
72
-					$this->_path_to_event_model . 'status' => 'publish'
72
+					$this->_path_to_event_model.'status' => 'publish'
73 73
 				)
74
-			) ),
74
+			)),
75 75
 			//if they don't have the others event cap, they can only access their own, others' that are for published events, or defaults
76
-			EE_Restriction_Generator_Base::get_cap_name( $event_model, $this->action() . '_others' ) => new EE_Default_Where_Conditions(
76
+			EE_Restriction_Generator_Base::get_cap_name($event_model, $this->action().'_others') => new EE_Default_Where_Conditions(
77 77
 				array(
78
-					'OR*no_' . EE_Restriction_Generator_Base::get_cap_name( $event_model, $this->action() . '_others' ) => array(
79
-						$this->_path_to_event_model . 'EVT_wp_user' => EE_Default_Where_Conditions::current_user_placeholder,
78
+					'OR*no_'.EE_Restriction_Generator_Base::get_cap_name($event_model, $this->action().'_others') => array(
79
+						$this->_path_to_event_model.'EVT_wp_user' => EE_Default_Where_Conditions::current_user_placeholder,
80 80
 						$this->_default_field_name => true,
81
-						$this->_path_to_event_model . 'status' => 'publish'
81
+						$this->_path_to_event_model.'status' => 'publish'
82 82
 					)
83 83
 				)
84 84
 			),
85 85
 			//if they have basic and others, but not private, they can access default, their own, and others' that aren't private
86
-			EE_Restriction_Generator_Base::get_cap_name( $event_model, $this->action() . '_private' )   => new EE_Default_Where_Conditions(
86
+			EE_Restriction_Generator_Base::get_cap_name($event_model, $this->action().'_private')   => new EE_Default_Where_Conditions(
87 87
 				array(
88
-					'OR*no_' . EE_Restriction_Generator_Base::get_cap_name( $event_model, $this->action() . '_private' ) => array(
89
-						$this->_path_to_event_model . 'EVT_wp_user' => EE_Default_Where_Conditions::current_user_placeholder,
90
-						$this->_path_to_event_model . 'status' => array( '!=', 'private' ),
88
+					'OR*no_'.EE_Restriction_Generator_Base::get_cap_name($event_model, $this->action().'_private') => array(
89
+						$this->_path_to_event_model.'EVT_wp_user' => EE_Default_Where_Conditions::current_user_placeholder,
90
+						$this->_path_to_event_model.'status' => array('!=', 'private'),
91 91
 						$this->_default_field_name => true
92 92
 					)
93 93
 				)
94 94
 			),
95 95
 			//second: access to defaults is controlled by the default capabilities
96 96
 			//if they don't have the basic default capability, restrict access to only non-default items
97
-			EE_Restriction_Generator_Base::get_cap_name( $this->model(), $this->action() . '_default' ) => new EE_Default_Where_Conditions(
98
-				array( $this->_default_field_name => false )
97
+			EE_Restriction_Generator_Base::get_cap_name($this->model(), $this->action().'_default') => new EE_Default_Where_Conditions(
98
+				array($this->_default_field_name => false)
99 99
 			),
100 100
 		);
101
-		if ( EE_Restriction_Generator_Base::is_cap( $this->model(), $this->action() . '_others_default' ) ) {
101
+		if (EE_Restriction_Generator_Base::is_cap($this->model(), $this->action().'_others_default')) {
102 102
 			//if they don't have the "others" default capability, restrict access to only their default ones, and non-default ones
103
-			$restrictions[ EE_Restriction_Generator_Base::get_cap_name( $this->model(), $this->action() . '_others_default' ) ] = new EE_Default_Where_Conditions(
103
+			$restrictions[EE_Restriction_Generator_Base::get_cap_name($this->model(), $this->action().'_others_default')] = new EE_Default_Where_Conditions(
104 104
 				array(
105 105
 					//if they don't have the others default cap, they can't access others default items (but they can access
106 106
 					//their own default items, and non-default items)
107
-					'OR*no_' . EE_Restriction_Generator_Base::get_cap_name( $this->model(), $this->action() . '_others_default' ) => array(
107
+					'OR*no_'.EE_Restriction_Generator_Base::get_cap_name($this->model(), $this->action().'_others_default') => array(
108 108
 						'AND' => array(
109 109
 							EE_Default_Where_Conditions::user_field_name_placeholder => EE_Default_Where_Conditions::current_user_placeholder,
110 110
 							$this->_default_field_name => true
Please login to merge, or discard this patch.
strategies/EE_Restriction_Generator_Event_Related_Protected.strategy.php 2 patches
Spacing   +14 added lines, -14 removed lines patch added patch discarded remove patch
@@ -1,7 +1,7 @@  discard block
 block discarded – undo
1 1
 <?php
2 2
 
3
-if ( !defined( 'EVENT_ESPRESSO_VERSION' ) ) {
4
-	exit( 'No direct script access allowed' );
3
+if ( ! defined('EVENT_ESPRESSO_VERSION')) {
4
+	exit('No direct script access allowed');
5 5
 }
6 6
 
7 7
 /**
@@ -44,8 +44,8 @@  discard block
 block discarded – undo
44 44
 	 * EDIT EVENTS in order to DELETE DATETIMES. If none if provided, assumed to be the same
45 45
 	 * as on the primary model.
46 46
 	 */
47
-	public function __construct( $path_to_event_model, $cap_context_on_event_model = null ) {
48
-		if( substr( $path_to_event_model, -1, 1 ) != '.' ) {
47
+	public function __construct($path_to_event_model, $cap_context_on_event_model = null) {
48
+		if (substr($path_to_event_model, -1, 1) != '.') {
49 49
 			$path_to_event_model .= '.';
50 50
 		}
51 51
 		$this->_path_to_event_model = $path_to_event_model;
@@ -59,9 +59,9 @@  discard block
 block discarded – undo
59 59
 	 * @return string one of EEM_Base::valid_cap_contexts()
60 60
 	 */
61 61
 	protected function action_for_event() {
62
-		if( $this->_cap_context_on_event_model ) {
62
+		if ($this->_cap_context_on_event_model) {
63 63
 			return $this->_cap_context_on_event_model;
64
-		}else{
64
+		} else {
65 65
 			return $this->action();
66 66
 		}
67 67
 	}
@@ -73,7 +73,7 @@  discard block
 block discarded – undo
73 73
 	protected function _generate_restrictions() {
74 74
 		//if there are no standard caps for this model, then for now all we know
75 75
 		//if they need the default cap to access this
76
-		if ( ! $this->model()->cap_slug() ) {
76
+		if ( ! $this->model()->cap_slug()) {
77 77
 			return array(
78 78
 				self::get_default_restrictions_cap() => new EE_Return_None_Where_Conditions()
79 79
 			);
@@ -83,17 +83,17 @@  discard block
 block discarded – undo
83 83
 		return array(
84 84
 			//first: basically access to non-defaults is essentially controlled by which events are accessible
85 85
 			//if they don't have the basic event cap, they can't access ANY non-default items
86
-			EE_Restriction_Generator_Base::get_cap_name( $event_model, $this->action_for_event() )              => new EE_Return_None_Where_Conditions(),
86
+			EE_Restriction_Generator_Base::get_cap_name($event_model, $this->action_for_event())              => new EE_Return_None_Where_Conditions(),
87 87
 			//if they don't have the others event cap, they can't access others' non-default items
88
-			EE_Restriction_Generator_Base::get_cap_name( $event_model, $this->action_for_event() . '_others' )  => new EE_Default_Where_Conditions(
89
-				array( $this->_path_to_event_model . 'EVT_wp_user' => EE_Default_Where_Conditions::current_user_placeholder )
88
+			EE_Restriction_Generator_Base::get_cap_name($event_model, $this->action_for_event().'_others')  => new EE_Default_Where_Conditions(
89
+				array($this->_path_to_event_model.'EVT_wp_user' => EE_Default_Where_Conditions::current_user_placeholder)
90 90
 			),
91 91
 			//if they have basic and others, but not private, they can't access others' private non-default items
92
-			EE_Restriction_Generator_Base::get_cap_name( $event_model, $this->action_for_event() . '_private' ) => new EE_Default_Where_Conditions(
92
+			EE_Restriction_Generator_Base::get_cap_name($event_model, $this->action_for_event().'_private') => new EE_Default_Where_Conditions(
93 93
 				array(
94
-					'OR*no_' . EE_Restriction_Generator_Base::get_cap_name( $event_model, $this->action_for_event() . '_private' ) => array(
95
-						$this->_path_to_event_model . 'EVT_wp_user' => EE_Default_Where_Conditions::current_user_placeholder,
96
-						$this->_path_to_event_model . 'status'      => array( '!=', 'private' )
94
+					'OR*no_'.EE_Restriction_Generator_Base::get_cap_name($event_model, $this->action_for_event().'_private') => array(
95
+						$this->_path_to_event_model.'EVT_wp_user' => EE_Default_Where_Conditions::current_user_placeholder,
96
+						$this->_path_to_event_model.'status'      => array('!=', 'private')
97 97
 					)
98 98
 				)
99 99
 			),
Please login to merge, or discard this patch.
Braces   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -90,7 +90,7 @@
 block discarded – undo
90 90
 		//so in case teh IPN is arriving later, let's try to process an IPN!
91 91
 		if($_SERVER['REQUEST_METHOD'] == 'POST'){
92 92
 			return $this->handle_ipn($_POST, $transaction );
93
-		}else{
93
+		} else{
94 94
 			return parent::finalize_payment_for( $transaction );
95 95
 		}
96 96
 	}
Please login to merge, or discard this patch.