InsuranceDuplicationChecker::checkForDuplicates() - Code Metrics - event15/RegistriesDomain - Measure and Improve Code Quality continuously with Scrutinizer

InsuranceDuplicationChecker::checkForDuplicates() B
last analyzed 2017-03-30 08:30 UTC

↳ Parent: InsuranceDuplicationChecker

Complexity

Conditions	5
Paths	4

Size

Total Lines	16
Code Lines	8

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	16
rs	8.8571
c	0
b	0
f	0
cc	5
eloc	8
nc	4
nop	2

<?php

namespace Madkom\RegistryApplication\Domain\CarManagement\Insurances;

/**
 * Class InsuranceDuplicationChecker.
 *
 * Klasa udostępnia metodę sprawdzającą, czy dane ubezpieczenie już istnieje.
 * Jeżeli data rozpoczęcia wprowadzanego ubezpieczenia jest mniejsza lub równa
 * dacie zakończenia umowy ostatniego ubezpieczenia, to wynik funkcji zwróci TRUE,
 * co będzie oznaczać, że taka operacja jest niedozwolona
 */
class InsuranceDuplicationChecker
{
    /**
     * @param \Madkom\RegistryApplication\Domain\CarManagement\Insurances\Insurance $newInsurance
     *
     * @return boolean
     */
    public function checkForDuplicates(array $existingInsurance, Insurance $newInsurance)
    {
        /** @var \Madkom\RegistryApplication\Domain\CarManagement\Insurances\Insurance $insurance */
        foreach ($existingInsurance as $insurance) {
            if (($newInsurance->getDateFrom() <= $insurance->getDateTo())
                && ($newInsurance->getType() === $insurance->getType())
abstract class User
{
    /** @return string */
    abstract public function getPassword();
}

class MyUser extends User
{
    public function getPassword()
    {
        // return something
    }

    public function getDisplayName()
    {
        // return some name.
    }
}

class AuthSystem
{
    public function authenticate(User $user)
    {
        $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName()));
        // do something.
    }
}
            ) {
                return true;
            }
            if ($newInsurance->getId() === $insurance->getId()) {
                return true;
            }
        }

        return false;
    }
}


1			<?php
2
3			namespace Madkom\RegistryApplication\Domain\CarManagement\Insurances;
4
5			/**
6			* Class InsuranceDuplicationChecker.
7			*
8			* Klasa udostępnia metodę sprawdzającą, czy dane ubezpieczenie już istnieje.
9			* Jeżeli data rozpoczęcia wprowadzanego ubezpieczenia jest mniejsza lub równa
10			* dacie zakończenia umowy ostatniego ubezpieczenia, to wynik funkcji zwróci TRUE,
11			* co będzie oznaczać, że taka operacja jest niedozwolona
12			*/
13			class InsuranceDuplicationChecker
14			{
15			/**
16			* @param \Madkom\RegistryApplication\Domain\CarManagement\Insurances\Insurance $newInsurance
17			*
18			* @return boolean
19			*/
20			public function checkForDuplicates(array $existingInsurance, Insurance $newInsurance)
21			{
22			/** @var \Madkom\RegistryApplication\Domain\CarManagement\Insurances\Insurance $insurance */
23			foreach ($existingInsurance as $insurance) {
24			if (($newInsurance->getDateFrom() <= $insurance->getDateTo())
25			&& ($newInsurance->getType() === $insurance->getType())
			0 ignored issues – show Bug introduced 2016-04-04 13:03 UTC by Report Bug Copy Issue Report It seems like you code against a specific sub-type and not the parent class `Madkom\RegistryApplicati...nt\Insurances\Insurance` as the method `getType()` does only exist in the following sub-classes of `Madkom\RegistryApplicati...nt\Insurances\Insurance`: `Madkom\RegistryApplicati...ances\AccidentInsurance`, `Madkom\RegistryApplicati...ces\AssistanceInsurance`, `Madkom\RegistryApplicati...Insurances\CarInsurance`, `Madkom\RegistryApplicati...nces\LiabilityInsurance`. Maybe you want to `instanceof` check for one of these explicitly? Let’s take a look at an example: abstract class User { /** @return string / abstract public function getPassword(); } class MyUser extends User { public function getPassword() { // return something } public function getDisplayName() { // return some name. } } class AuthSystem { public function authenticate(User $user) { $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName())); // do something. } } In the above example, the authenticate() method works fine as long as you just pass instances of MyUser. However, if you now also want to pass a different sub-classes of User which does not have a getDisplayName() method, the code will break. Available Fixes Change the type-hint for the parameter: class AuthSystem { public function authenticate(MyUser $user) { / ... / } } Add an additional type-check: class AuthSystem { public function authenticate(User $user) { if ($user instanceof MyUser) { $this->logger->info(/* ... /); } // or alternatively if ( ! $user instanceof MyUser) { throw new \LogicException( '$user must be an instance of MyUser, ' .'other instances are not supported.' ); } } } Note:* PHP Analyzer uses reverse abstract interpretation to narrow down the types inside the if block in such a case. Add the method to the parent class: abstract class User { /** @return string / abstract public function getPassword(); /* @return string */ abstract public function getDisplayName(); } Loading history...
26			) {
27			return true;
28			}
29			if ($newInsurance->getId() === $insurance->getId()) {
30			return true;
31			}
32			}
33
34			return false;
35			}
36			}
37

event15 / RegistriesDomain

InsuranceDuplicationChecker::checkForDuplicates() B last analyzed 2017-03-30 08:30 UTC

Complexity

Size

Duplication

Importance

Available Fixes

Duplication Side-by-Side

Filter issues like

InsuranceDuplicationChecker::checkForDuplicates() B
last analyzed 2017-03-30 08:30 UTC