etrias-nl / paazl-connector

src/Services/DocumentServiceInterface.php

<?php

/*
 * This file is part of PHP CS Fixer.
 *
 * (c) Fabien Potencier <fabien@symfony.com>
 *     Dariusz Rumiński <dariusz.ruminski@gmail.com>
 *
 * This source file is subject to the MIT license that is bundled
 * with this source code in the file LICENSE.
 */

namespace Etrias\PaazlConnector\Services;

use Etrias\PaazlConnector\SoapTypes\GenerateAdditionalImageDocumentResponse;
use Etrias\PaazlConnector\SoapTypes\GenerateAdditionalPdfDocumentResponse;
use Etrias\PaazlConnector\SoapTypes\GeneratePdfCustomsDocumentsResponse;
use Etrias\PaazlConnector\SoapTypes\ProofOfDeliveryResponse;

interface DocumentServiceInterface
{
    /**
     * @param $orderReference
     * @param $barcode
     * @param $documentType
     * @param null $printer

Are you sure the doc-type for parameter $printer is correct as it would always require null to be passed?

Are you sure the doc-type for parameter $targetWebShop is correct as it would always require null to be passed?

     * @param null $targetWebShop
     *
     * @return GenerateAdditionalPdfDocumentResponse
     */
    public function generateAdditionalPdfDocument(
        $orderReference,
        $barcode,
        $documentType,
        $printer = null,
        $targetWebShop = null
    );

    /**
     * @param $orderReference
     * @param $barcode
     * @param $documentType
     * @param null $targetWebShop

Are you sure the doc-type for parameter $targetWebShop is correct as it would always require null to be passed?

     *
     * @return GenerateAdditionalImageDocumentResponse
     */
    public function generateAdditionalImageDocument($orderReference, $barcode, $documentType, $targetWebShop = null);

    /**
     * @param array $orderReferences
     * @param $targetWebShop
     *
     * @return GeneratePdfCustomsDocumentsResponse
     */
    public function generatePdfCustomsDocuments(array $orderReferences, $targetWebShop = null);

    /**
     * @param $barcode
     * @param null $targetWebShop

Are you sure the doc-type for parameter $targetWebShop is correct as it would always require null to be passed?

     *
     * @return ProofOfDeliveryResponse
     */
    public function getProofOfDelivery($barcode, $targetWebShop = null);
}