ShippingService::getShippingMethods() - Code Metrics - Inspection of "Feature/it 1762 shipping methods" - etrias-nl/ewarehousing-connector - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Pull Request — develop (#9)

unknown

created 2018-06-18 12:18 UTC

ShippingService::getShippingMethods() A

↳ Parent: ShippingService

Complexity

Conditions	1
Paths	1

Size

Total Lines	14
Code Lines	6

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
cc	1
eloc	6
nc	1
nop	3
dl	0
loc	14
rs	9.4285
c	0
b	0
f	0

<?php

/*
 * This file is part of PHP CS Fixer.
 *
 * (c) Fabien Potencier <[email protected]>
 *     Dariusz Rumiński <[email protected]>
 *
 * This source file is subject to the MIT license that is bundled
 * with this source code in the file LICENSE.
 */

namespace Etrias\EwarehousingConnector\Services;

use Etrias\EwarehousingConnector\Client\EwarehousingClient;
use Etrias\EwarehousingConnector\Response\ShippingResponse;
use Etrias\EwarehousingConnector\Serializer\ServiceTrait;
use GuzzleHttp\RequestOptions;
use JMS\Serializer\SerializerInterface;

class ShippingService implements ShippingServiceInterface
{
    use ServiceTrait;

    /** @var EwarehousingClient */
    protected $client;

    /** @var SerializerInterface */
    protected $serializer;

    /**
     * OrderService constructor.
     *
     * @param EwarehousingClient  $client
     * @param SerializerInterface $serializer
     */
    public function __construct(EwarehousingClient $client, SerializerInterface $serializer)
    {
        $this->client = $client;
        $this->serializer = $serializer;
    }

    /**
     * {@inheritdoc}
     *
     * @return ShippingResponse[]
     */
    public function getShippingMethods(
        $distributor = null,
        $code = null,
        $type = null
    ) {
        $data = [
            'from' => $distributor,
            'to' => $code,
            'page' => $type
        ];

        $guzzleResponse = $this->client->get('1/shippingmethods', [RequestOptions::QUERY => $data]);

        return $this->deserializeResponse($guzzleResponse, 'array<'.ShippingResponse::class.'>');
    }

}


1			<?php
2
3			/*
4			* This file is part of PHP CS Fixer.
5			*
6			* (c) Fabien Potencier <[email protected]>
7			* Dariusz Rumiński <[email protected]>
8			*
9			* This source file is subject to the MIT license that is bundled
10			* with this source code in the file LICENSE.
11			*/
12
13			namespace Etrias\EwarehousingConnector\Services;
14
15			use Etrias\EwarehousingConnector\Client\EwarehousingClient;
16			use Etrias\EwarehousingConnector\Response\ShippingResponse;
17			use Etrias\EwarehousingConnector\Serializer\ServiceTrait;
18			use GuzzleHttp\RequestOptions;
19			use JMS\Serializer\SerializerInterface;
20
21			class ShippingService implements ShippingServiceInterface
22			{
23			use ServiceTrait;
24
25			/** @var EwarehousingClient */
26			protected $client;
27
28			/** @var SerializerInterface */
29			protected $serializer;
30
31			/**
32			* OrderService constructor.
33			*
34			* @param EwarehousingClient $client
35			* @param SerializerInterface $serializer
36			*/
37			public function __construct(EwarehousingClient $client, SerializerInterface $serializer)
38			{
39			$this->client = $client;
40			$this->serializer = $serializer;
41			}
42
43			/**
44			* {@inheritdoc}
45			*
46			* @return ShippingResponse[]
47			*/
48			public function getShippingMethods(
49			$distributor = null,
50			$code = null,
51			$type = null
52			) {
53			$data = [
54			'from' => $distributor,
55			'to' => $code,
56			'page' => $type
57			];
58
59			$guzzleResponse = $this->client->get('1/shippingmethods', [RequestOptions::QUERY => $data]);
60
61			return $this->deserializeResponse($guzzleResponse, 'array<'.ShippingResponse::class.'>');
62			}
63
64			}
65

etrias-nl / ewarehousing-connector

Pull Request — develop (#9)

ShippingService::getShippingMethods() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like