Issues in gindex.php (master) - Issues in master - etraxis/etraxis-obsolete - Measure and Improve Code Quality continuously with Scrutinizer

Issues (1098)

Security Analysis not enabled

Cross-Site Scripting

Cross-Site Scripting enables an attacker to inject code into the response of a web-request that is viewed by other users. It can for example be used to bypass access controls, or even to take over other users' accounts.

File Exposure

File Exposure allows an attacker to gain access to local files that he should not be able to access. These files can for example include database credentials, or other configuration files.

File Manipulation

File Manipulation enables an attacker to write custom data to files. This potentially leads to injection of arbitrary code on the server.

Object Injection

Object Injection enables an attacker to inject an object into PHP code, and can lead to arbitrary code execution, file exposure, or file manipulation attacks.

Code Injection

Code Injection enables an attacker to execute arbitrary code on the server.

Response Splitting

Response Splitting can be used to send arbitrary responses.

File Inclusion

File Inclusion enables an attacker to inject custom files into PHP's file loading mechanism, either explicitly passed to include, or for example via PHP's auto-loading mechanism.

Command Injection

Command Injection enables an attacker to inject a shell command that is execute with the privileges of the web-server. This can be used to expose sensitive data, or gain access of your server.

SQL Injection

SQL Injection enables an attacker to execute arbitrary SQL code on your database server gaining access to user data, or manipulating user data.

XPath Injection

XPath Injection enables an attacker to modify the parts of XML document that are read. If that XML document is for example used for authentication, this can lead to further vulnerabilities similar to SQL Injection.

LDAP Injection

LDAP Injection enables an attacker to inject LDAP statements potentially granting permission to run unauthorized queries, or modify content inside the LDAP tree.

Header Injection

Other Vulnerability

This category comprises other attack vectors such as manipulating the PHP runtime, loading custom extensions, freezing the runtime, or similar.

Regex Injection

Regex Injection enables an attacker to execute arbitrary code in your PHP process.

XML Injection

XML Injection enables an attacker to read files on your local filesystem including configuration files, or can be abused to freeze your web-server process.

Variable Injection

Variable Injection enables an attacker to overwrite program variables with custom data, and can lead to further vulnerabilities.

Unfortunately, the security analysis is currently not available for your project. If you are a non-commercial open-source project, please contact support to gain access.

src/projects/gindex.php (4 issues)

Labels

Severity

Minor 4

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php

//------------------------------------------------------------------------------
//
//  eTraxis - Records tracking web-based system
//  Copyright (C) 2005-2010  Artem Rodygin
//
//  This program is free software: you can redistribute it and/or modify
//  it under the terms of the GNU General Public License as published by
//  the Free Software Foundation, either version 3 of the License, or
//  (at your option) any later version.
//
//  This program is distributed in the hope that it will be useful,
//  but WITHOUT ANY WARRANTY; without even the implied warranty of
//  MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
//  GNU General Public License for more details.
//
//  You should have received a copy of the GNU General Public License
//  along with this program.  If not, see <http://www.gnu.org/licenses/>.
//
//------------------------------------------------------------------------------

/**
 * @package eTraxis
 * @ignore
 */

/**#@+
 * Dependency.
 */
require_once('../engine/engine.php');
require_once('../dbo/groups.php');
require_once('../dbo/projects.php');
/**#@-*/

init_page(LOAD_TAB);

if (get_user_level() != USER_LEVEL_ADMIN)
{
    debug_write_log(DEBUG_NOTICE, 'User must have admin rights to be allowed.');
    exit;
}

// check that requested project exists

$id      = ustr2int(try_request('id'));
$project = project_find($id);

if (!$project)

{
    debug_write_log(DEBUG_NOTICE, 'Project cannot be found.');
    exit;
}

// local JS functions

$resTitle  = get_js_resource(RES_NEW_GROUP_ID);
$resOK     = get_js_resource(RES_OK_ID);
$resCancel = get_js_resource(RES_CANCEL_ID);

$xml = <<<JQUERY
<script>

function groupCreate ()
{
    jqModal("{$resTitle}", "gcreate.php?id={$id}", "{$resOK}", "{$resCancel}", "$('#createform').submit()");
}

</script>
JQUERY;

// get list of groups

$sort = $page = NULL;
$list = groups_list($id, $sort, $page);

$from = $to = 0;

// generate buttons

$xml .= '<button action="groupCreate()">' . get_html_resource(RES_CREATE_ID) . '</button>';

// generate list of groups

if ($list->rows != 0)
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
{
    $bookmarks = gen_xml_bookmarks($page, $list->rows, $from, $to, 'gindex.php?id=' . $id . '&amp;');
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}

    $sort1 = ($sort == 1 ? 3 : 1);
    $sort2 = ($sort == 2 ? 4 : 2);

    $xml .= '<list>'
          . '<hrow>'
          . "<hcell url=\"gindex.php?id={$id}&amp;sort={$sort1}\">" . get_html_resource(RES_GROUP_NAME_ID)  . '</hcell>'
          . "<hcell/>"
          . "<hcell url=\"gindex.php?id={$id}&amp;sort={$sort2}\">" . get_html_resource(RES_DESCRIPTION_ID) . '</hcell>'
          . '</hrow>';

    $list->seek($from - 1);

    for ($i = $from; $i <= $to; $i++)
    {
        $row = $list->fetch();

        $xml .= "<row url=\"gview.php?pid={$id}&amp;id={$row['group_id']}\">"
              . '<cell>' . ustr2html($row['group_name']) . '</cell>'
              . '<cell>' . get_html_resource($row['is_global'] ? RES_GLOBAL_ID : RES_LOCAL_ID) . '</cell>'
              . '<cell>' . ustr2html($row['description']) . '</cell>'
              . '</row>';
    }

    $xml .= '</list>'
          . $bookmarks;
}

echo(xml2html($xml));

?>



1			<?php
2
3			//------------------------------------------------------------------------------
4			//
5			// eTraxis - Records tracking web-based system
6			// Copyright (C) 2005-2010 Artem Rodygin
7			//
8			// This program is free software: you can redistribute it and/or modify
9			// it under the terms of the GNU General Public License as published by
10			// the Free Software Foundation, either version 3 of the License, or
11			// (at your option) any later version.
12			//
13			// This program is distributed in the hope that it will be useful,
14			// but WITHOUT ANY WARRANTY; without even the implied warranty of
15			// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
16			// GNU General Public License for more details.
17			//
18			// You should have received a copy of the GNU General Public License
19			// along with this program. If not, see <http://www.gnu.org/licenses/>.
20			//
21			//------------------------------------------------------------------------------
22
23			/**
24			* @package eTraxis
25			* @ignore
26			*/
27
28			/**#@+
29			* Dependency.
30			*/
31			require_once('../engine/engine.php');
32			require_once('../dbo/groups.php');
33			require_once('../dbo/projects.php');
34			/*#@-/
35
36			init_page(LOAD_TAB);
37
38			if (get_user_level() != USER_LEVEL_ADMIN)
39			{
40			debug_write_log(DEBUG_NOTICE, 'User must have admin rights to be allowed.');
41			exit;
42			}
43
44			// check that requested project exists
45
46			$id = ustr2int(try_request('id'));
47			$project = project_find($id);
48
49			if (!$project)
			0 ignored issues – show Bug Best Practice introduced 2016-02-05 20:14 UTC by Report Bug Copy Issue Report Show Similar Issues like this The expression `$project` of type `array` is implicitly converted to a boolean; are you sure this is intended? If so, consider using `empty($expr)` instead to make it clear that you intend to check for an array without elements. This check marks implicit conversions of arrays to boolean values in a comparison. While in PHP an empty array is considered to be equal (but not identical) to false, this is not always apparent. Consider making the comparison explicit by using `empty(..)` or `! empty(...)` instead. Loading history...
50			{
51			debug_write_log(DEBUG_NOTICE, 'Project cannot be found.');
52			exit;
53			}
54
55			// local JS functions
56
57			$resTitle = get_js_resource(RES_NEW_GROUP_ID);
58			$resOK = get_js_resource(RES_OK_ID);
59			$resCancel = get_js_resource(RES_CANCEL_ID);
60
61			$xml = <<<JQUERY
62			<script>
63
64			function groupCreate ()
65			{
66			jqModal("{$resTitle}", "gcreate.php?id={$id}", "{$resOK}", "{$resCancel}", "$('#createform').submit()");
67			}
68
69			</script>
70			JQUERY;
71
72			// get list of groups
73
74			$sort = $page = NULL;
75			$list = groups_list($id, $sort, $page);
76
77			$from = $to = 0;
78
79			// generate buttons
80
81			$xml .= '<button action="groupCreate()">' . get_html_resource(RES_CREATE_ID) . '</button>';
82
83			// generate list of groups
84
85			if ($list->rows != 0)
			0 ignored issues – show Documentation introduced 2016-02-05 20:14 UTC by Report Bug Copy Issue Report Show Similar Issues like this The property `$rows` is declared protected in `CRecordset`. Since you implemented `__get()`, maybe consider adding a @property or @property-read annotation. This makes it easier for IDEs to provide auto-completion. Since your code implements the magic setter `_set`, this function will be called for any write access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /** * @property int $x * @property int $y * @property string $text */ class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } Since the property has write access only, you can use the @property-write annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history...
86			{
87			$bookmarks = gen_xml_bookmarks($page, $list->rows, $from, $to, 'gindex.php?id=' . $id . '&');
			0 ignored issues – show Documentation introduced 2016-02-05 20:14 UTC by Report Bug Copy Issue Report Show Similar Issues like this The property `$rows` is declared protected in `CRecordset`. Since you implemented `__get()`, maybe consider adding a @property or @property-read annotation. This makes it easier for IDEs to provide auto-completion. Since your code implements the magic setter `_set`, this function will be called for any write access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /** * @property int $x * @property int $y * @property string $text */ class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } Since the property has write access only, you can use the @property-write annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history...
88
89			$sort1 = ($sort == 1 ? 3 : 1);
90			$sort2 = ($sort == 2 ? 4 : 2);
91
92			$xml .= '<list>'
93			. '<hrow>'
94			. "<hcell url=\"gindex.php?id={$id}&sort={$sort1}\">" . get_html_resource(RES_GROUP_NAME_ID) . '</hcell>'
95			. "<hcell/>"
96			. "<hcell url=\"gindex.php?id={$id}&sort={$sort2}\">" . get_html_resource(RES_DESCRIPTION_ID) . '</hcell>'
97			. '</hrow>';
98
99			$list->seek($from - 1);
100
101			for ($i = $from; $i <= $to; $i++)
102			{
103			$row = $list->fetch();
104
105			$xml .= "<row url=\"gview.php?pid={$id}&id={$row['group_id']}\">"
106			. '<cell>' . ustr2html($row['group_name']) . '</cell>'
107			. '<cell>' . get_html_resource($row['is_global'] ? RES_GLOBAL_ID : RES_LOCAL_ID) . '</cell>'
108			. '<cell>' . ustr2html($row['description']) . '</cell>'
109			. '</row>';
110			}
111
112			$xml .= '</list>'
113			. $bookmarks;
114			}
115
116			echo(xml2html($xml));
117
118			?>
			0 ignored issues – show Best Practice introduced 2016-02-05 20:14 UTC by Report Bug Copy Issue Report Show Similar Issues like this It is not recommended to use PHP's closing tag `?>` in files other than templates. Using a closing tag in PHP files that only contain PHP code is not recommended as you might accidentally add whitespace after the closing tag which would then be output by PHP. This can cause severe problems, for example headers cannot be sent anymore. A simple precaution is to leave off the closing tag as it is not required, and it also has no negative effects whatsoever. Loading history...
119

etraxis / etraxis-obsolete

Issues (1098)

Security Analysis not enabled

src/projects/gindex.php (4 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like