Issues in records.php (master) - Issues in master - etraxis/etraxis-obsolete - Measure and Improve Code Quality continuously with Scrutinizer

Issues (1098)

Security Analysis not enabled

Cross-Site Scripting
Cross-Site Scripting enables an attacker to inject code into the response of a web-request that is viewed by other users. It can for example be used to bypass access controls, or even to take over other users' accounts.
File Exposure
File Exposure allows an attacker to gain access to local files that he should not be able to access. These files can for example include database credentials, or other configuration files.
File Manipulation
File Manipulation enables an attacker to write custom data to files. This potentially leads to injection of arbitrary code on the server.
Object Injection
Object Injection enables an attacker to inject an object into PHP code, and can lead to arbitrary code execution, file exposure, or file manipulation attacks.
Code Injection
Code Injection enables an attacker to execute arbitrary code on the server.
Response Splitting
Response Splitting can be used to send arbitrary responses.
File Inclusion
File Inclusion enables an attacker to inject custom files into PHP's file loading mechanism, either explicitly passed to include, or for example via PHP's auto-loading mechanism.
Command Injection
Command Injection enables an attacker to inject a shell command that is execute with the privileges of the web-server. This can be used to expose sensitive data, or gain access of your server.
SQL Injection
SQL Injection enables an attacker to execute arbitrary SQL code on your database server gaining access to user data, or manipulating user data.
XPath Injection
XPath Injection enables an attacker to modify the parts of XML document that are read. If that XML document is for example used for authentication, this can lead to further vulnerabilities similar to SQL Injection.
LDAP Injection
LDAP Injection enables an attacker to inject LDAP statements potentially granting permission to run unauthorized queries, or modify content inside the LDAP tree.
Header Injection
Other Vulnerability
This category comprises other attack vectors such as manipulating the PHP runtime, loading custom extensions, freezing the runtime, or similar.
Regex Injection
Regex Injection enables an attacker to execute arbitrary code in your PHP process.
XML Injection
XML Injection enables an attacker to read files on your local filesystem including configuration files, or can be abused to freeze your web-server process.
Variable Injection
Variable Injection enables an attacker to overwrite program variables with custom data, and can lead to further vulnerabilities.
Unfortunately, the security analysis is currently not available for your project. If you are a non-commercial open-source project, please contact support to gain access.
src/dbo/records.php (15 issues)

Labels

Severity

Minor 15
Artem Rodygin 15
Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more
<?php

//------------------------------------------------------------------------------
//
//  eTraxis - Records tracking web-based system
//  Copyright (C) 2005-2012  Artem Rodygin
//
//  This program is free software: you can redistribute it and/or modify
//  it under the terms of the GNU General Public License as published by
//  the Free Software Foundation, either version 3 of the License, or
//  (at your option) any later version.
//
//  This program is distributed in the hope that it will be useful,
//  but WITHOUT ANY WARRANTY; without even the implied warranty of
//  MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
//  GNU General Public License for more details.
//
//  You should have received a copy of the GNU General Public License
//  along with this program.  If not, see <http://www.gnu.org/licenses/>.
//
//------------------------------------------------------------------------------

/**
 * Records
 *
 * This module provides API to work with records.
 * See also {@link https://github.com/etraxis/etraxis-obsolete/wiki/tbl_records tbl_records} database table.
 *
 * @package DBO
 * @subpackage Records
 */

/**#@+
 * Dependency.
 */
require_once('../engine/engine.php');
require_once('../dbo/accounts.php');
require_once('../dbo/filters.php');
require_once('../dbo/fields.php');
require_once('../dbo/values.php');
require_once('../dbo/events.php');
/**#@-*/

//------------------------------------------------------------------------------
//  Definitions.
//------------------------------------------------------------------------------

/**#@+
 * Data restrictions.
 */
define('MAX_RECORD_SUBJECT',  250);
define('MAX_COMMENT_BODY',    4000);
define('MAX_ATTACHMENT_NAME', 100);
define('MAX_SEARCH_TEXT',     100);
define('MAX_SEARCH_WORDS',    5);
/**#@-*/

/**#@+
 * Record operations.
 */
define('OPERATION_CREATE_RECORD', 1);
define('OPERATION_MODIFY_RECORD', 2);
define('OPERATION_CHANGE_STATE',  3);
/**#@-*/

/**#@+
 * Tabs on record view page.
 */
define('RECORD_TAB_MAIN',           1);
define('RECORD_TAB_HISTORY',        2);
define('RECORD_TAB_CHANGES',        3);
define('RECORD_TAB_FIELDS',         4);
define('RECORD_TAB_COMMENTS',       5);
define('RECORD_TAB_ATTACHMENTS',    6);
define('RECORD_TAB_PARENTS',        7);
define('RECORD_TAB_SUBRECORDS',     8);
/**#@-*/

//------------------------------------------------------------------------------
//  Functions.
//------------------------------------------------------------------------------

/**
 * Formats specified record ID, adding template prefix if specified and leading zeroes if required.
 *
 * @param int $id Record ID.
 * @param string $prefix Template prefix.
 * @return string Formatted record ID.
 */
function record_id ($id, $prefix = NULL)
{
    debug_write_log(DEBUG_TRACE, '[record_id]');
    debug_write_log(DEBUG_DUMP,  '[record_id] $id     = ' . $id);
    debug_write_log(DEBUG_DUMP,  '[record_id] $prefix = ' . $prefix);

    return ustr2html((is_null($prefix) ? NULL : $prefix . '-') . str_pad($id, 3, '0', STR_PAD_LEFT));
}

/**
 * Finds in database and returns the information about specified record.
 *
 * @param int $id Record ID.
 * @return array Array with data if record is found in database, FALSE otherwise.
 */
function record_find ($id)
{
    debug_write_log(DEBUG_TRACE, '[record_find]');
    debug_write_log(DEBUG_DUMP,  '[record_find] $id = ' . $id);

    $rs = dal_query('records/fndid.sql', $id, time());

    return ($rs->rows == 0 ? FALSE : $rs->fetch());
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
}

/**
 * Returns {@link CRecordset DAL recordset} which contains all records, allowed to be displayed
 * in accordance to current set of filters, search mode, user permissions, etc.
 * Recordset is sorted in accordance with current sort mode.
 *
 * @param array $columns List of columns (see {@link column_list}).
 * @param int &$sort Sort mode (used as output only). The function retrieves current sort mode from
 * client cookie ({@link COOKIE_RECORDS_SORT}) and updates it, if it's out of valid range.
 * @param int &$page Number of current page tab (used as output only). The function retrieves current
 * page from client cookie ({@link COOKIE_RECORDS_PAGE}) and updates it, if it's out of valid range.
 * @param bool $search_mode Whether the search mode is on.
 * @param string $search_text Text to be searched (ignored when search mode is off).
 * @return CRecordset Recordset with list of records.
 */
function records_list ($columns, &$sort, &$page, $search_mode = FALSE, $search_text = NULL)
{
    debug_write_log(DEBUG_TRACE, '[records_list]');

    $sort = try_request('sort', try_cookie(COOKIE_RECORDS_SORT . $_SESSION[VAR_VIEW]));
    $sort = ustr2int($sort, -count($columns), count($columns));

    $page = try_request('page', try_cookie(COOKIE_RECORDS_PAGE . $_SESSION[VAR_VIEW]));
    $page = ustr2int($page, 1, MAXINT);

    $date = getdate();
    $time = mktime(23, 59, 59, $date['mon'], $date['mday'], $date['year']);

    $clause_select = array('r.record_id',
                           'r.subject',
                           'r.responsible_id',
                           'r.creator_id',
                           'r.creation_time',
                           'r.change_time',
                           'r.closure_time',
                           'r.postpone_time',
                           'p.project_name',
                           't.template_name',
                           't.template_prefix',
                           't.critical_age',
                           's.state_name',
                           's.state_abbr');

    $clause_from   = array('tbl_projects p',
                           'tbl_states s');

    $clause_join   = array('tbl_records r');

    $clause_where  = array('p.project_id = t.project_id',
                           't.template_id = s.template_id',
                           's.state_id = r.state_id');

    save_cookie(COOKIE_RECORDS_SORT . $_SESSION[VAR_VIEW], $sort);
    save_cookie(COOKIE_RECORDS_PAGE . $_SESSION[VAR_VIEW], $page);

    // Add default access conditions for guests and registered users.

    if (get_user_level() == USER_LEVEL_GUEST)
    {
        array_push($clause_select, '0 as read_time');
        array_push($clause_from,   'tbl_templates t');
        array_push($clause_where,  't.guest_access = 1');
        array_push($clause_where,  'r.closure_time is null');
    }
    else
    {
        $perms = 'select gp.template_id, count(gp.group_id) as gnum '
               . 'from tbl_membership ms, tbl_group_perms gp '
               . 'where ms.account_id = %1 and ms.group_id = gp.group_id and '
               . (DATABASE_DRIVER == DRIVER_ORACLE9 ? 'mod(floor(gp.perms / %2), 2) = 1 ' : '(gp.perms & %2) <> 0 ')
               . 'group by template_id';

        $perms = ustrprocess($perms, $_SESSION[VAR_USERID], PERMIT_VIEW_RECORD);

        array_push($clause_from,  "tbl_templates t left outer join ({$perms}) perms on t.template_id = perms.template_id");
        array_push($clause_where, ustrprocess('(perms.gnum is not null' .
                                              ' or r.creator_id = %1' .
                                              ' or r.responsible_id = %1' .
                                              ' or ' . (DATABASE_DRIVER == DRIVER_ORACLE9 ? 'mod(floor(t.registered_perm / %2), 2) = 1' : '(t.registered_perm & %2) <> 0') .
                                              ' or t.guest_access = 1)',
                                              $_SESSION[VAR_USERID], PERMIT_VIEW_RECORD));

        array_push($clause_select, 'rd.read_time');
        array_push($clause_join,   'left outer join tbl_reads rd on rd.record_id = r.record_id and rd.account_id = ' . $_SESSION[VAR_USERID]);
    }

    // Add search conditions if search is activated.

    if ($search_mode)
    {
        debug_write_log(DEBUG_NOTICE, '[records_list] Search mode is turned on.');
        debug_write_log(DEBUG_DUMP,   '[records_list] $search_text = ' . $search_text);

        $search = array();

        if (is_intvalue($search_text))
        {
            array_push($search,
                       'select e.record_id ' .
                       'from tbl_events e, tbl_field_values fv ' .
                       'where e.event_id = fv.event_id and fv.field_type = ' . FIELD_TYPE_NUMBER . ' and fv.is_latest = 1 and fv.value_id = ' . $search_text);
        }

        $search_text = "'%" . ustr2sql(ustrtolower($search_text)) . "%'";

        $search_in_subject  = (in_array(DATABASE_DRIVER, array(DRIVER_ORACLE9, DRIVER_PGSQL80)) ? 'lower' : NULL) . '(r.subject)       like ' . $search_text;
        $search_in_svalues  = (in_array(DATABASE_DRIVER, array(DRIVER_ORACLE9, DRIVER_PGSQL80)) ? 'lower' : NULL) . '(sv.string_value) like ' . $search_text;
        $search_in_tvalues  = (in_array(DATABASE_DRIVER, array(DRIVER_ORACLE9, DRIVER_PGSQL80)) ? 'lower' : NULL) . '(tv.text_value)   like ' . $search_text;
        $search_in_comments = (in_array(DATABASE_DRIVER, array(DRIVER_ORACLE9, DRIVER_PGSQL80)) ? 'lower' : NULL) . '(c.comment_body)  like ' . $search_text;

        array_push($search,
                   'select r.record_id ' .
                   'from tbl_records r ' .
                   'where ' . $search_in_subject);

        array_push($search,
                   'select e.record_id ' .
                   'from tbl_events e, tbl_field_values fv, tbl_string_values sv ' .
                   'where e.event_id = fv.event_id and fv.field_type = ' . FIELD_TYPE_STRING . ' and fv.value_id = sv.value_id and fv.is_latest = 1 and ' .
                   $search_in_svalues);

        array_push($search,
                   'select e.record_id ' .
                   'from tbl_events e, tbl_field_values fv, tbl_text_values tv ' .
                   'where e.event_id = fv.event_id and fv.field_type = ' . FIELD_TYPE_MULTILINED . ' and fv.value_id = tv.value_id and fv.is_latest = 1 and ' .
                   $search_in_tvalues);

        array_push($search,
                   'select e.record_id ' .
                   'from tbl_events e, tbl_comments c ' .
                   'where e.event_id = c.event_id and ' .
                   $search_in_comments);

        $sql = 'select record_id from (' . implode(' union ', $search) . ') data';

        $ids = array();
        $rsx = new CRecordset($sql);

        while (($row = $rsx->fetch()))
        {
            array_push($ids, $row['record_id']);
        }

        $search_ids = (count($ids) == 0)
                   ? 'NULL'
                   : implode(', ', $ids);

        debug_write_log(DEBUG_NOTICE, '[records_list] $search_ids = [' . $search_ids . ']' );

        array_push($clause_where, 'r.record_id in (' . $search_ids . ')');
    }

    // Add filters, if it's not a search or if it's a filtered search.

    if (!$search_mode || $_SESSION[VAR_USE_FILTERS])
    {
        debug_write_log(DEBUG_NOTICE, '[records_list] Filters are in use.');

        $filters = array();

        $fsort = $fpage = NULL;
        $rs = filters_list($_SESSION[VAR_USERID], TRUE, $fsort, $fpage);

        while (($filter = $rs->fetch()))
        {
            if ($filter['filter_flags'] == 0 &&
                $filter['filter_type']  == FILTER_TYPE_ALL_PROJECTS)
            {
                continue;
            }

            $clause_filter = array();

            switch ($filter['filter_type'])
            {
                case FILTER_TYPE_ALL_PROJECTS:
                    break;

                case FILTER_TYPE_ALL_TEMPLATES:
                    array_push($clause_select, 'p.project_id');
                    array_push($clause_filter, 'p.project_id = ' . $filter['filter_param']);
                    break;

                case FILTER_TYPE_ALL_STATES:
                    array_push($clause_select, 't.template_id');
                    array_push($clause_filter, 't.template_id = ' . $filter['filter_param']);
                    break;

                case FILTER_TYPE_SEL_STATES:
                    $states = filter_states_get($filter['filter_id'], $filter['filter_param']);
                    array_push($clause_select, 's.state_id');
                    array_push($clause_filter, 's.state_id in (' . implode(',', array_unique($states)) . ')');
                    break;

                default:
                    debug_write_log(DEBUG_WARNING, '[records_list] Unknown filter type = ' . $filter['filter_type']);
            }

            if ($filter['filter_flags'] & FILTER_FLAG_CREATED_BY)
            {
                array_push($clause_select, 'r.creator_id');
                array_push($clause_filter,
                           'r.creator_id in ' .
                           '(select account_id ' .
                           'from tbl_filter_accounts ' .
                           'where filter_id = ' . $filter['filter_id'] . ' and filter_flag = ' . FILTER_FLAG_CREATED_BY . ')');
            }

            if ($filter['filter_flags'] & FILTER_FLAG_ASSIGNED_TO)
            {
                array_push($clause_select, 'r.responsible_id');
                array_push($clause_filter,
                           'r.responsible_id in ' .
                           '(select account_id ' .
                           'from tbl_filter_accounts ' .
                           'where filter_id = ' . $filter['filter_id'] . ' and filter_flag = ' . FILTER_FLAG_ASSIGNED_TO . ')');
            }

            if ($filter['filter_flags'] & FILTER_FLAG_UNASSIGNED)
            {
                array_push($clause_select, 'r.responsible_id');
                array_push($clause_filter, 'r.responsible_id is null');
            }

            if (($filter['filter_type'] != FILTER_TYPE_SEL_STATES) &&
                ($filter['filter_flags'] & FILTER_FLAG_UNCLOSED))
            {
                array_push($clause_filter, 'r.closure_time is null');
            }

            if ($filter['filter_flags'] & FILTER_FLAG_POSTPONED)
            {
                array_push($clause_filter, 'r.postpone_time > ' . $time);
            }

            if ($filter['filter_flags'] & FILTER_FLAG_ACTIVE)
            {
                array_push($clause_filter, 'r.postpone_time <=' . $time);
            }

            if ($filter['filter_type'] == FILTER_TYPE_ALL_STATES ||
                $filter['filter_type'] == FILTER_TYPE_SEL_STATES)
            {
                $rs2 = dal_query('filters/ftlist.sql', $filter['filter_id']);

                while (($row = $rs2->fetch()))
                {
                    array_push($clause_filter,
                               'r.record_id in ' .
                               '(select record_id ' .
                               'from tbl_events ' .
                               'where (event_type = ' . EVENT_RECORD_CREATED . ' or event_type = ' . EVENT_RECORD_STATE_CHANGED . ') and ' .
                               'event_time >= ' . $row['date1'] . ' and ' .
                               'event_time <= ' . $row['date2'] . ' and ' .
                               'event_param = ' . $row['state_id'] . ')');
                }

                $rs2 = dal_query('filters/fflist.sql', $filter['filter_id']);

                while (($row = $rs2->fetch()))
                {
                    switch ($row['field_type'])
                    {
                        case FIELD_TYPE_CHECKBOX:
                        case FIELD_TYPE_LIST:
                        case FIELD_TYPE_RECORD:

                            $value = (is_null($row['param1'])
                                      ? 'fv.value_id is null'
                                      : 'fv.value_id = ' . $row['param1']);

                            array_push($clause_filter,
                                       'r.record_id in ' .
                                       '(select e.record_id ' .
                                       'from tbl_events e, tbl_field_values fv ' .
                                       'where fv.event_id = e.event_id and ' .
                                       'fv.field_id = ' . $row['field_id'] . ' and ' .
                                       $value . ' and ' .
                                       'fv.is_latest = 1)');

                            break;

                        case FIELD_TYPE_NUMBER:
                        case FIELD_TYPE_DATE:
                        case FIELD_TYPE_DURATION:

                            $range = (is_null($row['param1']) && is_null($row['param2']) ? 'fv.value_id is null and ' : NULL);

                            if (!is_null($row['param1']))
                            {
                                $range .= 'fv.value_id >= ' . $row['param1'] . ' and ';
                            }

                            if (!is_null($row['param2']))
                            {
                                $range .= 'fv.value_id <= ' . $row['param2'] . ' and ';
                            }

                            array_push($clause_filter,
                                       'r.record_id in ' .
                                       '(select e.record_id ' .
                                       'from tbl_events e, tbl_field_values fv ' .
                                       'where fv.event_id = e.event_id and ' .
                                       'fv.field_id = '  . $row['field_id'] . ' and ' .
                                       $range .
                                       'fv.is_latest = 1)');

                            break;

                        case FIELD_TYPE_FLOAT:

                            $range = (is_null($row['param1']) && is_null($row['param2']) ? 'fv.value_id is null and ' : NULL);

                            if (!is_null($row['param1']))
                            {
                                $range .= 'fl1.float_value >= fl2.float_value and ';
                            }

                            if (!is_null($row['param2']))
                            {
                                $range .= 'fl1.float_value <= fl3.float_value and ';
                            }

                            array_push($clause_filter,
                                       'r.record_id in ' .
                                       '(select e.record_id ' .
                                       'from tbl_events e, tbl_field_values fv, tbl_float_values fl1, tbl_float_values fl2, tbl_float_values fl3 ' .
                                       'where fv.event_id = e.event_id and ' .
                                       'fv.field_id = '  . $row['field_id'] . ' and ' .
                                       'fv.value_id = fl1.value_id and ' .
                                       $range .
                                       'fl2.value_id = ' . $row['param1'] . ' and ' .
                                       'fl3.value_id = ' . $row['param2'] . ' and ' .
                                       'fv.is_latest = 1)');

                            break;

                        case FIELD_TYPE_STRING:

                            if (is_null($row['param1']))
                            {
                                array_push($clause_filter,
                                           'r.record_id in ' .
                                           '(select e.record_id ' .
                                           'from tbl_events e, tbl_field_values fv ' .
                                           'where fv.event_id = e.event_id and ' .
                                           'fv.field_id = ' . $row['field_id'] . ' and ' .
                                           'fv.value_id is null and ' .
                                           'fv.is_latest = 1)');
                            }
                            else
                            {
                                switch (DATABASE_DRIVER)
                                {
                                    case DRIVER_MYSQL50:
                                        $concat = "concat('%', sf.string_value, '%')";
                                        break;
                                    case DRIVER_ORACLE9:
                                        $concat = "concat(concat('%', sf.string_value), '%')";
                                        break;
                                    case DRIVER_MSSQL2K:
                                        $concat = "'%' + sf.string_value + '%'";
                                        break;
                                    case DRIVER_PGSQL80:
                                        $concat = "'%' || sf.string_value || '%'";
                                        break;
                                    default: ;  // nop
                                }

                                array_push($clause_filter,
                                           'r.record_id in ' .
                                           '(select e.record_id ' .
                                           'from tbl_events e, tbl_field_values fv, tbl_string_values sv, tbl_string_values sf ' .
                                           'where fv.event_id = e.event_id and ' .
                                           'fv.field_id = ' . $row['field_id'] . ' and ' .
                                           'fv.value_id = sv.value_id and ' .
                                           'sf.value_id = ' . $row['param1'] . ' and ' .
                                           'sv.string_value like ' . $concat . ' and ' .
                                           'fv.is_latest = 1)');
                            }

                            break;

                        case FIELD_TYPE_MULTILINED:

                            if (is_null($row['param1']))
                            {
                                array_push($clause_filter,
                                           'r.record_id in ' .
                                           '(select e.record_id ' .
                                           'from tbl_events e, tbl_field_values fv ' .
                                           'where fv.event_id = e.event_id and ' .
                                           'fv.field_id = ' . $row['field_id'] . ' and ' .
                                           'fv.value_id is null and ' .
                                           'fv.is_latest = 1)');
                            }
                            else
                            {
                                switch (DATABASE_DRIVER)
                                {
                                    case DRIVER_MYSQL50:
                                        $concat = "concat('%', sf.string_value, '%')";
                                        break;
                                    case DRIVER_ORACLE9:
                                        $concat = "concat(concat('%', sf.string_value), '%')";
                                        break;
                                    case DRIVER_MSSQL2K:
                                        $concat = "'%' + sf.string_value + '%'";
                                        break;
                                    case DRIVER_PGSQL80:
                                        $concat = "'%' || sf.string_value || '%'";
                                        break;
                                    default: ;  // nop
                                }

                                array_push($clause_filter,
                                           'r.record_id in ' .
                                           '(select e.record_id ' .
                                           'from tbl_events e, tbl_field_values fv, tbl_text_values tv, tbl_string_values sf ' .
                                           'where fv.event_id = e.event_id and ' .
                                           'fv.field_id = ' . $row['field_id'] . ' and ' .
                                           'fv.value_id = tv.value_id and ' .
                                           'sf.value_id = ' . $row['param1'] . ' and ' .
                                           'tv.text_value like ' . $concat . ' and ' .
                                           'fv.is_latest = 1)');
                            }

                            break;
                    }
                }
            }

            array_push($filters, implode(' and ', array_unique($clause_filter)));
        }

        if (count($filters) != 0)
        {
            array_push($clause_where, '(' . implode(' or ', array_unique($filters)) . ')');
        }
    }

    // Create basic query.

    $sql = 'select ' . implode(', ',    array_unique($clause_select)) .
           ' from '  . implode(', ',    array_unique($clause_from))   .
           ', '      . implode(' ',     array_unique($clause_join))   .
           ' where ' . implode(' and ', array_unique($clause_where));

    $clause_select = array('r.*');
    $clause_select = array('r.record_id',
                           'r.subject',
                           'r.responsible_id',
                           'r.creator_id',
                           'r.creation_time',
                           'r.change_time',
                           'r.closure_time',
                           'r.postpone_time',
                           'r.project_name',
                           'r.template_name',
                           'r.template_prefix',
                           'r.critical_age',
                           'r.state_name',
                           'r.state_abbr',
                           'r.read_time');
    $clause_from   = array();
    $clause_join   = array();
    $clause_where  = array();
    $clause_order  = array();

    // SQL condition to check that current user is allowed to read the field.

    $sql_field_perms = <<<SQL

        f.field_id in (select f.field_id
                       from
                           tbl_group_perms  gp,
                           tbl_membership   ms,
                           tbl_field_perms  fp,
                           tbl_fields f
                       where
                           fp.field_id   = f.field_id  and
                           fp.group_id   = gp.group_id and
                           ms.group_id   = gp.group_id and
                           ms.account_id = {$_SESSION[VAR_USERID]} and
                           fp.perms      = 1)

        or r.creator_id = {$_SESSION[VAR_USERID]} and
           f.field_id in (select f.field_id
                          from tbl_fields f
                          where f.author_perm >= 1)

        or r.responsible_id = {$_SESSION[VAR_USERID]} and
           f.field_id in (select f.field_id
                          from tbl_fields f
                          where f.responsible_perm >= 1)

        or f.field_id in (select f.field_id
                          from tbl_fields f
                          where f.registered_perm >= 1 or f.guest_access = 1)
SQL;

    // Generate columns of the current view.

    foreach ($columns as $i => $column)
    {
        $i += 1;

        switch ($column['column_type'])
        {
            case COLUMN_TYPE_ID:

                array_push($clause_select, 'r.template_prefix');

                if ($i == $sort)
                {
                    array_push($clause_order, 'record_id asc');
                }
                elseif (-$i == $sort)
                {
                    array_push($clause_order, 'record_id desc');
                }

                break;

            case COLUMN_TYPE_STATE_ABBR:

                array_push($clause_select, 'r.state_abbr');

                if ($i == $sort)
                {
                    array_push($clause_order, 'state_abbr asc');
                }
                elseif (-$i == $sort)
                {
                    array_push($clause_order, 'state_abbr desc');
                }

                break;

            case COLUMN_TYPE_PROJECT:

                array_push($clause_select, 'r.project_name');

                if ($i == $sort)
                {
                    array_push($clause_order, 'project_name asc');
                }
                elseif (-$i == $sort)
                {
                    array_push($clause_order, 'project_name desc');
                }

                break;

            case COLUMN_TYPE_SUBJECT:

                array_push($clause_select, 'r.subject');

                if ($i == $sort)
                {
                    array_push($clause_order, 'subject asc');
                }
                elseif (-$i == $sort)
                {
                    array_push($clause_order, 'subject desc');
                }

                break;

            case COLUMN_TYPE_AUTHOR:

                array_push($clause_select, 'ac.fullname as author_fullname');
                array_push($clause_join,   'left outer join tbl_accounts ac on ac.account_id = r.creator_id');

                if ($i == $sort)
                {
                    array_push($clause_order, 'author_fullname asc');
                }
                elseif (-$i == $sort)
                {
                    array_push($clause_order, 'author_fullname desc');
                }

                break;

            case COLUMN_TYPE_RESPONSIBLE:

                array_push($clause_select, 'ar.fullname as responsible_fullname');
                array_push($clause_join,   'left outer join tbl_accounts ar on ar.account_id = r.responsible_id');

                if ($i == $sort)
                {
                    array_push($clause_order, 'responsible_fullname asc');
                }
                elseif (-$i == $sort)
                {
                    array_push($clause_order, 'responsible_fullname desc');
                }

                break;

            case COLUMN_TYPE_LAST_EVENT:

                if ($i == $sort)
                {
                    array_push($clause_order, 'change_time asc');
                }
                elseif (-$i == $sort)
                {
                    array_push($clause_order, 'change_time desc');
                }

                break;

            case COLUMN_TYPE_AGE:

                array_push($clause_select, '(' . $time . ' - r.creation_time) as opened_age');
                array_push($clause_select, '(r.closure_time - r.creation_time) as closed_age');

                if ($i == $sort)
                {
                    array_push($clause_order, 'closed_age asc');
                    array_push($clause_order, 'opened_age asc');
                }
                elseif (-$i == $sort)
                {
                    array_push($clause_order, 'closed_age desc');
                    array_push($clause_order, 'opened_age desc');
                }

                break;

            case COLUMN_TYPE_CREATION_DATE:

                array_push($clause_select, 'r.creation_time');

                if ($i == $sort)
                {
                    array_push($clause_order, 'creation_time asc');
                }
                elseif (-$i == $sort)
                {
                    array_push($clause_order, 'creation_time desc');
                }

                break;

            case COLUMN_TYPE_TEMPLATE:

                array_push($clause_select, 'r.template_name');

                if ($i == $sort)
                {
                    array_push($clause_order, 'template_name asc');
                }
                elseif (-$i == $sort)
                {
                    array_push($clause_order, 'template_name desc');
                }

                break;

            case COLUMN_TYPE_STATE_NAME:

                array_push($clause_select, 'r.state_name');

                if ($i == $sort)
                {
                    array_push($clause_order, 'state_name asc');
                }
                elseif (-$i == $sort)
                {
                    array_push($clause_order, 'state_name desc');
                }

                break;

            case COLUMN_TYPE_LAST_STATE:

                array_push($clause_select, 'st.state_time');
                array_push($clause_from,   '(select record_id, max(event_time) as state_time' .
                                           ' from tbl_events' .
                                           ' where event_type = 1 or event_type = 4' .
                                           ' group by record_id) st');
                array_push($clause_where,  'r.record_id = st.record_id');

                if ($i == $sort)
                {
                    array_push($clause_order, 'state_time asc');
                }
                elseif (-$i == $sort)
                {
                    array_push($clause_order, 'state_time desc');
                }

                break;

            case COLUMN_TYPE_FLOAT:

                array_push($clause_select, "v{$column['column_id']}.value{$column['column_id']}");

                array_push($clause_join,
                           "left outer join " .
                           "(select r.record_id, flv.float_value as value{$column['column_id']} " .
                           "from tbl_records r, tbl_states s, tbl_fields f, tbl_events e, tbl_field_values fv " .
                           "left outer join tbl_float_values flv on fv.value_id = flv.value_id " .
                           "where r.record_id = e.record_id and s.state_id = f.state_id and s.state_name = '{$column['state_name']}' and f.field_id = fv.field_id and f.field_name = '{$column['field_name']}' and f.field_type = " . FIELD_TYPE_FLOAT . " and e.event_id = fv.event_id and fv.is_latest = 1 and ({$sql_field_perms})) v{$column['column_id']} " .
                           "on r.record_id = v{$column['column_id']}.record_id");

                if ($i == $sort)
                {
                    array_push($clause_order, "value{$column['column_id']} asc");
                }
                elseif (-$i == $sort)
                {
                    array_push($clause_order, "value{$column['column_id']} desc");
                }

                break;

            case COLUMN_TYPE_STRING:

                array_push($clause_select, "v{$column['column_id']}.value{$column['column_id']}");

                array_push($clause_join,
                           "left outer join " .
                           "(select r.record_id, sv.string_value as value{$column['column_id']} " .
                           "from tbl_records r, tbl_states s, tbl_fields f, tbl_events e, tbl_field_values fv " .
                           "left outer join tbl_string_values sv on fv.value_id = sv.value_id " .
                           "where r.record_id = e.record_id and s.state_id = f.state_id and s.state_name = '{$column['state_name']}' and f.field_id = fv.field_id and f.field_name = '{$column['field_name']}' and f.field_type = " . FIELD_TYPE_STRING . " and e.event_id = fv.event_id and fv.is_latest = 1 and ({$sql_field_perms})) v{$column['column_id']} " .
                           "on r.record_id = v{$column['column_id']}.record_id");

                if ($i == $sort)
                {
                    array_push($clause_order, "value{$column['column_id']} asc");
                }
                elseif (-$i == $sort)
                {
                    array_push($clause_order, "value{$column['column_id']} desc");
                }

                break;

            case COLUMN_TYPE_MULTILINED:

                $txtval = (DATABASE_DRIVER == DRIVER_MSSQL2K ? 'substring(tv.text_value, 1, 4000)' : 'substr(tv.text_value, 1, 4000)');

                if (DATABASE_DRIVER == DRIVER_ORACLE9)
                {
                    array_push($clause_select, "to_char(v{$column['column_id']}.value{$column['column_id']}) as \"value{$column['column_id']}\"");
                }
                else
                {
                    array_push($clause_select, "v{$column['column_id']}.value{$column['column_id']}");
                }

                array_push($clause_join,
                           "left outer join " .
                           "(select r.record_id, {$txtval} as value{$column['column_id']} " .
                           "from tbl_records r, tbl_states s, tbl_fields f, tbl_events e, tbl_field_values fv " .
                           "left outer join tbl_text_values tv on fv.value_id = tv.value_id " .
                           "where r.record_id = e.record_id and s.state_id = f.state_id and s.state_name = '{$column['state_name']}' and f.field_id = fv.field_id and f.field_name = '{$column['field_name']}' and f.field_type = " . FIELD_TYPE_MULTILINED . " and e.event_id = fv.event_id and fv.is_latest = 1 and ({$sql_field_perms})) v{$column['column_id']} " .
                           "on r.record_id = v{$column['column_id']}.record_id");

                if ($i == $sort)
                {
                    array_push($clause_order, DATABASE_DRIVER == DRIVER_ORACLE9
                                                    ? "to_char(value{$column['column_id']}) asc"
                                                    : "value{$column['column_id']} asc");
                }
                elseif (-$i == $sort)
                {
                    array_push($clause_order, DATABASE_DRIVER == DRIVER_ORACLE9
                                                    ? "to_char(value{$column['column_id']}) desc"
                                                    : "value{$column['column_id']} desc");
                }

                break;

            case COLUMN_TYPE_LIST_STRING:

                array_push($clause_select, "v{$column['column_id']}.value{$column['column_id']}");

                array_push($clause_join,
                           "left outer join " .
                           "(select r.record_id, lv.str_value as value{$column['column_id']} " .
                           "from tbl_records r, tbl_states s, tbl_fields f, tbl_events e, tbl_field_values fv " .
                           "left outer join tbl_list_values lv on fv.field_id = lv.field_id and fv.value_id = lv.int_value " .
                           "where r.record_id = e.record_id and s.state_id = f.state_id and s.state_name = '{$column['state_name']}' and f.field_id = fv.field_id and f.field_name = '{$column['field_name']}' and f.field_type = " . FIELD_TYPE_LIST . " and e.event_id = fv.event_id and fv.is_latest = 1 and ({$sql_field_perms})) v{$column['column_id']} " .
                           "on r.record_id = v{$column['column_id']}.record_id");

                if ($i == $sort)
                {
                    array_push($clause_order, "value{$column['column_id']} asc");
                }
                elseif (-$i == $sort)
                {
                    array_push($clause_order, "value{$column['column_id']} desc");
                }

                break;

            case COLUMN_TYPE_NUMBER:
            case COLUMN_TYPE_CHECKBOX:
            case COLUMN_TYPE_LIST_NUMBER:
            case COLUMN_TYPE_RECORD:
            case COLUMN_TYPE_DATE:
            case COLUMN_TYPE_DURATION:

                $types = array
                (
                    COLUMN_TYPE_NUMBER      => FIELD_TYPE_NUMBER,
                    COLUMN_TYPE_CHECKBOX    => FIELD_TYPE_CHECKBOX,
                    COLUMN_TYPE_LIST_NUMBER => FIELD_TYPE_LIST,
                    COLUMN_TYPE_RECORD      => FIELD_TYPE_RECORD,
                    COLUMN_TYPE_DATE        => FIELD_TYPE_DATE,
                    COLUMN_TYPE_DURATION    => FIELD_TYPE_DURATION,
                );

                array_push($clause_select, "v{$column['column_id']}.value{$column['column_id']}");

                array_push($clause_join,
                           "left outer join " .
                           "(select r.record_id, fv.value_id as value{$column['column_id']} " .
                           "from tbl_records r, tbl_states s, tbl_fields f, tbl_events e, tbl_field_values fv " .
                           "where r.record_id = e.record_id and s.state_id = f.state_id and s.state_name = '{$column['state_name']}' and f.field_id = fv.field_id and f.field_name = '{$column['field_name']}' and f.field_type = {$types[$column['column_type']]} and e.event_id = fv.event_id and fv.is_latest = 1 and ({$sql_field_perms})) v{$column['column_id']} " .
                           "on r.record_id = v{$column['column_id']}.record_id");

                if ($i == $sort)
                {
                    array_push($clause_order, "value{$column['column_id']} asc");
                }
                elseif (-$i == $sort)
                {
                    array_push($clause_order, "value{$column['column_id']} desc");
                }

                break;

            default:
                debug_write_log(DEBUG_WARNING, '[records_list] Unknown column type = ' . $column['column_type']);
        }
    }

    // Add default sorting.

    if ($sort < 0)
    {
        array_push($clause_order, 'record_id desc');
    }
    else
    {
        array_push($clause_order, 'record_id asc');
    }

    // Bring it all together.

    array_push($clause_from, "({$sql}) r");

    $sql = 'select '    . implode(', ',    array_unique($clause_select)) .
           ' from '     . implode(', ',    array_unique($clause_from))   .
           ' '          . implode(' ',     array_unique($clause_join));

    if (count($clause_where) != 0)
    {
        $sql .= ' where ' . implode(' and ', array_unique($clause_where));
    }

    $sql .= ' order by ' . implode(', ', array_unique($clause_order));

    return new CRecordset($sql);
}

/**
 * Returns {@link CRecordset DAL recordset} which contains number of created records per week for specified project.
 * Each row of returned recordset contains two fields:
 * <ul>
 * <li><b>week</b> - number of week after {@link http://en.wikipedia.org/wiki/Unix_time Unix Epoch}.</li>
 * <li><b>amount</b> - number of records, created during this week</li>
 * </ul>
 *
 * @param int $id ID of project which records should be counted.
 * @return CRecordset Recordset with list of counts.
 */
function record_opened ($id)
{
    debug_write_log(DEBUG_TRACE, '[record_opened]');
    debug_write_log(DEBUG_DUMP,  '[record_opened] $id = ' . $id);

    return dal_query('records/opened.sql', $id, date('Z'), (DATABASE_DRIVER == DRIVER_ORACLE9 ? 'ceil' : 'ceiling'));
}

/**
 * Returns {@link CRecordset DAL recordset} which contains number of closed records per week for specified project.
 * Each row of returned recordset contains two fields:
 * <ul>
 * <li><b>week</b> - number of week after {@link http://en.wikipedia.org/wiki/Unix_time Unix Epoch}.</li>
 * <li><b>amount</b> - number of records, closed during this week</li>
 * </ul>
 *
 * @param int $id ID of project which records should be counted.
 * @return CRecordset Recordset with list of counts.
 */
function record_closed ($id)
{
    debug_write_log(DEBUG_TRACE, '[record_closed]');
    debug_write_log(DEBUG_DUMP,  '[record_closed] $id = ' . $id);

    return dal_query('records/closed.sql', $id, date('Z'), (DATABASE_DRIVER == DRIVER_ORACLE9 ? 'ceil' : 'ceiling'));
}

/**
 * Validates record information (including all custom fields) before creation, modification, or changing state.
 *
 * @param int $operation Code of operation:
 * <ul>
 * <li>{@link OPERATION_CREATE_RECORD} - new record is going to be created</li>
 * <li>{@link OPERATION_MODIFY_RECORD} - record is going to be modified</li>
 * <li>{@link OPERATION_CHANGE_STATE} - state of record is going to be changed</li>
 * </ul>
 * @param string $subject Subject of the record (ignored on state change).
 * @param int $record_id Record ID (should be NULL on creation).
 * @param int $state_id ID of new state (current on modification).
 * @param int $creator_id Author of record (used only on modification, otherwise ignored).
 * @param int $responsible_id Responsible of record (used only on modification, otherwise ignored).
 * @return int Error code:
 * <ul>
 * <li>{@link NO_ERROR} - data are valid</li>
 * <li>{@link ERROR_INCOMPLETE_FORM} - at least one of required field is empty</li>
 * <li>{@link ERROR_INVALID_INTEGER_VALUE} - value of some custom field of {@link FIELD_TYPE_NUMBER}, {@link FIELD_TYPE_LIST}, or {@link FIELD_TYPE_RECORD} type is not an integer</li>
 * <li>{@link ERROR_INTEGER_VALUE_OUT_OF_RANGE} - value of some custom field of {@link FIELD_TYPE_NUMBER} or {@link FIELD_TYPE_LIST} type is out of valid range</li>
 * <li>{@link ERROR_VALUE_FAILS_REGEX_CHECK} - value of some custom field of {@link FIELD_TYPE_STRING} or {@link FIELD_TYPE_MULTILINED} type fails the custom PCRE check</li>
 * <li>{@link ERROR_RECORD_NOT_FOUND} - value of some custom field of {@link FIELD_TYPE_RECORD} type is not an ID of existing record</li>
 * <li>{@link ERROR_INVALID_DATE_VALUE} - value of some custom field of {@link FIELD_TYPE_DATE} type is not a valid date value</li>
 * <li>{@link ERROR_DATE_VALUE_OUT_OF_RANGE} - value of some custom field of {@link FIELD_TYPE_DATE} type is out of valid range</li>
 * <li>{@link ERROR_INVALID_TIME_VALUE} - value of some custom field of {@link FIELD_TYPE_DURATION} type is not a valid duration value</li>
 * <li>{@link ERROR_TIME_VALUE_OUT_OF_RANGE} - value of some custom field of {@link FIELD_TYPE_DURATION} type is out of valid range</li>
 * </ul>
 */
function record_validate ($operation, $subject, $record_id, $state_id, $creator_id = 0, $responsible_id = 0)
{
    debug_write_log(DEBUG_TRACE, '[record_validate]');
    debug_write_log(DEBUG_DUMP,  '[record_validate] $operation      = ' . $operation);
    debug_write_log(DEBUG_DUMP,  '[record_validate] $subject        = ' . $subject);
    debug_write_log(DEBUG_DUMP,  '[record_validate] $record_id      = ' . $record_id);
    debug_write_log(DEBUG_DUMP,  '[record_validate] $state_id       = ' . $state_id);
    debug_write_log(DEBUG_DUMP,  '[record_validate] $creator_id     = ' . $creator_id);
    debug_write_log(DEBUG_DUMP,  '[record_validate] $responsible_id = ' . $responsible_id);

    // Check the subject.
    if ($operation != OPERATION_CHANGE_STATE &&
        ustrlen($subject) == 0)
    {
        debug_write_log(DEBUG_NOTICE, '[record_validate] At least one required field is empty.');
        return ERROR_INCOMPLETE_FORM;
    }

    // Get the list of custom fields.
    if ($operation != OPERATION_MODIFY_RECORD)
    {
        $rs = dal_query('fields/list.sql', $state_id, 'field_order');
    }
    else
    {
        $rs = dal_query('records/flist.sql',
                        $record_id,
                        $state_id,
                        $creator_id,
                        is_null($responsible_id) ? 0 : $responsible_id,
                        $_SESSION[VAR_USERID],
                        FIELD_ALLOW_TO_WRITE);
    }

    // Check value candidates of all fields.
    // Values of all custom fields are passed to the function via $_REQUEST.
    while (($row = $rs->fetch()))
    {
        $name  = 'field' . $row['field_id'];
        $value = ($row['field_type'] == FIELD_TYPE_CHECKBOX ? isset($_REQUEST[$name]) : trim(try_request($name)));

        // Required custom fields must be filled in.
        if ($row['is_required'] &&
            $row['field_type'] != FIELD_TYPE_CHECKBOX &&
            ustrlen($value) == 0)

etraxis / etraxis-obsolete

Issues (1098)

Security Analysis not enabled

src/dbo/records.php (15 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine
