src/engine/sessions.php ➔ init_page()

Complexity

Conditions	23
Paths	120

Size

Total Lines	150
Code Lines	82

Duplication

Lines	0
Ratio	0 %

Importance

Changes

0

<?php
function init_page ($page_type = LOAD_CONTAINER, $guest_is_allowed = FALSE)
{
    global $timezones;
    global $encodings;
    global $line_endings_chars;

    @session_start();

It seems like you do not handle an error condition here. This can introduce security issues, and is generally not recommended.

    if (!isset($_SESSION[VAR_ERROR]))
    {
        $_SESSION[VAR_ERROR] = NO_ERROR;
    }

    if (get_magic_quotes_gpc() != 0)
    {
        foreach ($_REQUEST as $key => $value)
        {
            if (is_array($value))
            {
                foreach ($value as $subkey => $subvalue)
                {
                    $_REQUEST[$key][$subkey] = stripslashes($subvalue);
                }
            }
            else
            {
                $_REQUEST[$key] = stripslashes($value);
            }
        }
    }

    if (get_user_level() == USER_LEVEL_GUEST)
    {
        create_session();
        open_session(account_get_token(NULL));

The call to account_get_token() has too many arguments starting with NULL.

    }

    if (get_user_level() == USER_LEVEL_GUEST)
    {
        debug_write_log(DEBUG_NOTICE, '[init_page] User is not authorized.');

        // Force the guest to log in
        if (!$guest_is_allowed)

The expression $guest_is_allowed of type false|integer is loosely compared to false; this is ambiguous if the integer can be zero. You might want to explicitly use === null instead.

        {
            debug_write_log(DEBUG_NOTICE, '[init_page] Guest must be logged in.');
            save_cookie(COOKIE_URI, $_SERVER['REQUEST_URI']);

            if ($page_type == LOAD_CONTAINER)
            {
                header('Location: ' . WEBROOT . 'logon/index.php');
            }
            elseif ($page_type == LOAD_INLINE)
            {
                header('HTTP/1.1 307 ' . WEBROOT . 'logon/index.php');
            }
            elseif ($page_type == LOAD_RSS)
            {
                debug_write_log(DEBUG_NOTICE, '[init_page] Request for HTTP Basic Auth.');
                header('WWW-Authenticate: Basic realm="eTraxis RSS"');
                header('HTTP/1.0 401 Unauthorized');
            }

            exit;
        }
    }
    else
    {
        $rs = dal_query('accounts/fndid2.sql',
                        $_SESSION[VAR_USERID],
                        time(),
                        LOCKS_COUNT,
                        time() - LOCKS_TIMEOUT * 60);

        if ($rs->rows == 0)

The property $rows is declared protected in CRecordset. Since you implemented __get(), maybe consider adding a @property or @property-read annotation. This makes it easier for IDEs to provide auto-completion.

        {
            debug_write_log(DEBUG_NOTICE, '[init_page] Specified user cannot be authorized.');
            open_session(GUEST_USER_ID);
        }
        else
        {
            $account = $rs->fetch();
            $account['passwd'] = trim($account['passwd']);

            // Up to version 3.6.7 passwords were stored as MD5 hashes which took 32 chars.
            // As of 3.6.8 passwords are stored as base64-encoded SHA1 hashes which take 28 chars.
            // For backward compatibility we let user authenticate if his password is stored as MD5-hash,
            // but we have to replace the password with its SHA1-hash.
            // To make user enter his password as soon as possible we are forcing him to log out.
            if (strlen($account['passwd']) == 32 &&
                !$account['is_ldapuser'])
            {
                debug_write_log(DEBUG_NOTICE, '[init_page] The password is stored as MD5 hash and must be updated.');
                open_session(GUEST_USER_ID);
            }
            else
            {
                $_SESSION[VAR_USERNAME]      = account_get_username($account['username']);
                $_SESSION[VAR_FULLNAME]      = $account['fullname'];
                $_SESSION[VAR_PASSWD_EXPIRE] = $account['passwd_expire'];
                $_SESSION[VAR_ISADMIN]       = $account['is_admin'];
                $_SESSION[VAR_LDAPUSER]      = $account['is_ldapuser'];
                $_SESSION[VAR_LOCALE]        = $account['locale'];
                $_SESSION[VAR_TIMEZONE]      = intval(date('Z'));
                $_SESSION[VAR_TEXTROWS]      = $account['text_rows'];
                $_SESSION[VAR_PAGEROWS]      = $account['page_rows'];
                $_SESSION[VAR_PAGEBKMS]      = $account['page_bkms'];
                $_SESSION[VAR_AUTO_REFRESH]  = ustr2int($account['auto_refresh'], MIN_AUTO_REFRESH, MAX_AUTO_REFRESH);
                $_SESSION[VAR_DELIMITER]     = chr($account['csv_delim']);
                $_SESSION[VAR_ENCODING]      = $encodings[$account['csv_encoding']];
                $_SESSION[VAR_LINE_ENDINGS]  = $line_endings_chars[$account['csv_line_ends']];
                $_SESSION[VAR_VIEW]          = $account['view_id'];
                $_SESSION[VAR_THEME_NAME]    = $account['theme_name'];

                if ($account['timezone'] > 0 &&
                    $account['timezone'] <= count($timezones))
                {
                    $_SESSION[VAR_TIMEZONE] = timezone_offset_get(timezone_open($timezones[$account['timezone']]), date_create());
                }

                save_cookie(COOKIE_AUTH_USERID, $_SESSION[VAR_USERID]);
                save_cookie(COOKIE_AUTH_TOKEN,  $account['auth_token']);

                dal_query('accounts/settoken2.sql', $_SESSION[VAR_USERID], time() + SESSION_EXPIRE * 60);

                if ((strpos($_SERVER['PHP_SELF'], '/settings/') === FALSE                     ) &&
                    (PASSWORD_EXPIRATION != 0                                                 ) &&
                    ($_SESSION[VAR_PASSWD_EXPIRE] + PASSWORD_EXPIRATION * SECS_IN_DAY < time()) &&
                    (!$_SESSION[VAR_LDAPUSER]                                                 ))
                {
                    debug_write_log(DEBUG_NOTICE, '[init_page] Password is expired.');

                    save_cookie(COOKIE_URI, $_SERVER['REQUEST_URI']);

                    if ($page_type == LOAD_CONTAINER)
                    {
                        header('Location: ' . WEBROOT . 'settings/index.php?tab=3');
                    }
                    elseif ($page_type == LOAD_INLINE)
                    {
                        header('HTTP/1.1 307 ' . WEBROOT . 'settings/index.php?tab=3');
                    }

                    exit;
                }

                clear_cookie(COOKIE_URI);
            }
        }
    }
}