RabbitServiceProvider::loadRpcServers() - Code Metrics - Inspection of "[FEATURE#26106] Fix ssl + options" - etna-alternance/composer-rabbitmq-service-provider - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — v2 (#16)

by Faouzi

created 2016-06-16 15:22 UTC

RabbitServiceProvider::loadRpcServers() A

↳ Parent: RabbitServiceProvider

Complexity

Conditions	3
Paths	1

Size

Total Lines	20
Code Lines	13

Duplication

Lines	0
Ratio	0 %

Importance

Changes	3
Bugs	0	Features	0

Metric	Value
c	3
b	0
f	0
dl	0
loc	20
rs	9.4285
cc	3
eloc	13
nc	1
nop	1

<?php

namespace ETNA\Silex\Provider\RabbitMQ;

use OldSound\RabbitMqBundle\RabbitMq\AnonConsumer;
use OldSound\RabbitMqBundle\RabbitMq\BaseConsumer;
use OldSound\RabbitMqBundle\RabbitMq\Consumer;
.
|-- OtherDir
|   |-- Bar.php
|   `-- Foo.php
`-- SomeDir
    `-- Foo.php
use OldSound\RabbitMqBundle\RabbitMq\MultipleConsumer;
use OldSound\RabbitMqBundle\RabbitMq\Producer;
use OldSound\RabbitMqBundle\RabbitMq\RpcClient;
use OldSound\RabbitMqBundle\RabbitMq\RpcServer;
use PhpAmqpLib\Connection\AMQPConnection;
use PhpAmqpLib\Connection\AMQPLazyConnection;
use PhpAmqpLib\Connection\AMQPSSLConnection;
use Pimple\Container;
use Pimple\ServiceProviderInterface;

/**
 * Code repris de fiunchinho/rabbitmq-service-provider en attendant la compatibilité
 * avec silex 2
 */
class RabbitServiceProvider implements ServiceProviderInterface
{
    const DEFAULT_CONNECTION = 'default';

    public function register(Container $app)
    {
        $this->loadConnections($app);
class User
{
    private $email;

    public function getEmail()
    {
        return $this->email;
    }

    public function setEmail($email)
    {
        $this->email = $email;
    }
}
        $this->loadProducers($app);
class User
{
    private $email;

    public function getEmail()
    {
        return $this->email;
    }

    public function setEmail($email)
    {
        $this->email = $email;
    }
}
        $this->loadConsumers($app);
class User
{
    private $email;

    public function getEmail()
    {
        return $this->email;
    }

    public function setEmail($email)
    {
        $this->email = $email;
    }
}
        $this->loadAnonymousConsumers($app);
class User
{
    private $email;

    public function getEmail()
    {
        return $this->email;
    }

    public function setEmail($email)
    {
        $this->email = $email;
    }
}
        $this->loadMultipleConsumers($app);
class User
{
    private $email;

    public function getEmail()
    {
        return $this->email;
    }

    public function setEmail($email)
    {
        $this->email = $email;
    }
}
        $this->loadRpcClients($app);
class User
{
    private $email;

    public function getEmail()
    {
        return $this->email;
    }

    public function setEmail($email)
    {
        $this->email = $email;
    }
}
        $this->loadRpcServers($app);
class User
{
    private $email;

    public function getEmail()
    {
        return $this->email;
    }

    public function setEmail($email)
    {
        $this->email = $email;
    }
}
    }

    /**
     * Return the name of the connection to use.
     *
     * @param  array     $options     Options for the Producer or Consumer.
     * @param  array     $connections Connections defined in the config file.
     * @return string                 The connection name that will be used
     */
    private function getConnection($app, $options, $connections)
    {
        $connection_name = @$options['connection']?: self::DEFAULT_CONNECTION;

        if (!isset($connections[$connection_name])) {
            throw new \InvalidArgumentException('Configuration for connection [' . $connection_name . '] not found');
        }

        return $app['rabbit.connection'][$connection_name];
    }

    /**
     * @param Container $app
     */
    private function loadConnections($app)
    {
        $app['rabbit.connection'] = function ($app) {
            if (!isset($app['rabbit.connections'])) {
                throw new \InvalidArgumentException('You need to specify at least a connection in your configuration.');
            }

            $connections = [];
            foreach ($app["rabbit.connections"] as $name => $options) {
                $amqp_class = "PhpAmqpLib\Connection\AMQPConnection";
                $amqp_args  = [
                    $options["host"],
                    $options["port"],
                    $options["user"],
                    $options["password"],
                    $options["vhost"]
                ];

                if (isset($options["ssl"]) && true === $options["ssl"]) {
                    $amqp_class = "PhpAmqpLib\Connection\AMQPSSLConnection";
                    $amqp_args  = array_merge(
                        $amqp_args,
                        [
                            isset($options["ssl_options"]) ? $options["ssl_options"] : ['verify_peer' => false],
                            isset($options["options"]) ?
                                $options["options"] :
                                ['read_write_timeout' => 60,'heartbeat' => 30]
                        ]
                    );
                }

                $reflection = new \ReflectionClass($amqp_class);
                $connection = $reflection->newInstanceArgs($amqp_args);

                register_shutdown_function(
                    function ($connection) {
                        $connection->close();
                    },
                    $connection
                );

                $connections[$name] = $connection;
            }

            return $connections;
        };
    }

    /**
     * @param Container $app
     */
    private function loadProducers($app)
    {
        $app['rabbit.producer'] = function ($app) {
            if (!isset($app['rabbit.producers'])) {
                return;
            }
            $producers = [];
            foreach ($app['rabbit.producers'] as $name => $options) {
                $connection = $this->getConnection($app, $options, $app['rabbit.connections']);

                $producer = new Producer($connection);
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
                $producer->setExchangeOptions($options['exchange_options']);

                //this producer doesn't define a queue
                if (!isset($options['queue_options'])) {
                    $options['queue_options']['name'] = null;
                }
                $producer->setQueueOptions($options['queue_options']);

                if ((array_key_exists('auto_setup_fabric', $options)) && (!$options['auto_setup_fabric'])) {
                    $producer->disableAutoSetupFabric();
                }

                $producers[$name] = $producer;
            }

            return $producers;
        };
    }

    /**
     * @param Container $app
     */
    private function loadConsumers($app)
    {
        $app['rabbit.consumer'] = function ($app) {
            if (!isset($app['rabbit.consumers'])) {
                return;
            }

            $consumers = [];
            foreach ($app['rabbit.consumers'] as $name => $options) {
                $connection = $this->getConnection($app, $options, $app['rabbit.connections']);
                $consumer = new Consumer($connection);
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
                $consumer->setExchangeOptions($options['exchange_options']);
                $consumer->setQueueOptions($options['queue_options']);
                $consumer->setCallback(array($app[$options['callback']], 'execute'));
                $consumer = $this->setQosOptions($consumer, $options);

                if (array_key_exists('idle_timeout', $options)) {
                    $consumer->setIdleTimeout($options['idle_timeout']);
                }

                if ((array_key_exists('auto_setup_fabric', $options)) && (!$options['auto_setup_fabric'])) {
                    $consumer->disableAutoSetupFabric();
                }

                $consumers[$name] = $consumer;
            }

            return $consumers;
        };
    }

    /**
     * @param Container $app
     */
    private function loadAnonymousConsumers($app)
    {
        $app['rabbit.anonymous_consumer'] = function ($app) {
            if (!isset($app['rabbit.anon_consumers'])) {
                return;
            }

            $consumers = [];
            foreach ($app['rabbit.anon_consumers'] as $name => $options) {
                $connection = $this->getConnection($app, $options, $app['rabbit.connections']);
                $consumer = new AnonConsumer($connection);
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
                $consumer->setExchangeOptions($options['exchange_options']);
                $consumer->setCallback(array($options['callback'], 'execute'));

                $consumers[$name] = $consumer;
            }

            return $consumers;
        };
    }

    /**
     * @param Container $app
     */
    private function loadMultipleConsumers($app)
    {
        $app['rabbit.multiple_consumer'] = function ($app) {
            if (!isset($app['rabbit.multiple_consumers'])) {
                return;
            }

            $consumers = [];
            foreach ($app['rabbit.multiple_consumers'] as $name => $options) {
                $connection = $this->getConnection($app, $options, $app['rabbit.connections']);
                $consumer = new MultipleConsumer($connection);
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
                $consumer->setExchangeOptions($options['exchange_options']);
                $consumer->setQueues($options['queues']);
                $consumer = $this->setQosOptions($consumer, $options);

                if (array_key_exists('idle_timeout', $options)) {
                    $consumer->setIdleTimeout($options['idle_timeout']);
                }

                if ((array_key_exists('auto_setup_fabric', $options)) && (!$options['auto_setup_fabric'])) {
                    $consumer->disableAutoSetupFabric();
                }

                $consumers[$name] = $consumer;
            }

            return $consumers;
        };

    }

    /**
     * @param Container $app
     */
    private function loadRpcClients($app)
    {
        $app['rabbit.rpc_client'] = function ($app) {
            if (!isset($app['rabbit.rpc_clients'])) {
                return;
            }

            $clients = [];
            foreach ($app['rabbit.rpc_clients'] as $name => $options) {
                $connection = $this->getConnection($app, $options, $app['rabbit.connections']);
                $client = new RpcClient($connection);
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);

                if (array_key_exists('expect_serialized_response', $options)) {
                    $client->initClient($options['expect_serialized_response']);
                }

                $clients[$name] = $client;
            }

            return $clients;
        };
    }

    /**
     * @param Container $app
     */
    private function loadRpcServers($app)
    {
        $app['rabbit.rpc_server'] = function ($app) {
            if (!isset($app['rabbit.rpc_servers'])) {
                return;
            }

            $servers = [];
            foreach ($app['rabbit.rpc_servers'] as $name => $options) {
                $connection = $this->getConnection($app, $options, $app['rabbit.connections']);
                $server = new RpcServer($connection);
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
                $server->initServer($name);
                $server->setCallback(array($options['callback'], 'execute'));
                $server         = $this->setQosOptions($server, $options);
                $servers[$name] = $server;
            }

            return $servers;
        };
    }

    private function setQosOptions(BaseConsumer $consumer, $options)
    {
        if (array_key_exists('qos_options', $options)) {
            $consumer->setQosOptions(
                $options['qos_options']['prefetch_size'],
                $options['qos_options']['prefetch_count'],
                $options['qos_options']['global']
            );
        }

        return $consumer;
    }
}


1			<?php
2
3			namespace ETNA\Silex\Provider\RabbitMQ;
4
5			use OldSound\RabbitMqBundle\RabbitMq\AnonConsumer;
6			use OldSound\RabbitMqBundle\RabbitMq\BaseConsumer;
7			use OldSound\RabbitMqBundle\RabbitMq\Consumer;
			0 ignored issues – show Bug introduced 2016-03-14 15:50 UTC by Report Bug Copy Issue Report This use statement conflicts with another class in this namespace, `ETNA\Silex\Provider\RabbitMQ\Consumer`. Let’s assume that you have a directory layout like this: . \|-- OtherDir \| \|-- Bar.php \| `-- Foo.php `-- SomeDir `-- Foo.php and let’s assume the following content of `Bar.php`: // Bar.php namespace OtherDir; use SomeDir\Foo; // This now conflicts the class OtherDir\Foo If both files `OtherDir/Foo.php` and `SomeDir/Foo.php` are loaded in the same runtime, you will see a PHP error such as the following: PHP Fatal error: Cannot use SomeDir\Foo as Foo because the name is already in use in OtherDir/Foo.php However, as `OtherDir/Foo.php` does not necessarily have to be loaded and the error is only triggered if it is loaded before `OtherDir/Bar.php`, this problem might go unnoticed for a while. In order to prevent this error from surfacing, you must import the namespace with a different alias: // Bar.php namespace OtherDir; use SomeDir\Foo as SomeDirFoo; // There is no conflict anymore. Loading history...
8			use OldSound\RabbitMqBundle\RabbitMq\MultipleConsumer;
9			use OldSound\RabbitMqBundle\RabbitMq\Producer;
10			use OldSound\RabbitMqBundle\RabbitMq\RpcClient;
11			use OldSound\RabbitMqBundle\RabbitMq\RpcServer;
12			use PhpAmqpLib\Connection\AMQPConnection;
13			use PhpAmqpLib\Connection\AMQPLazyConnection;
14			use PhpAmqpLib\Connection\AMQPSSLConnection;
15			use Pimple\Container;
16			use Pimple\ServiceProviderInterface;
17
18			/**
19			* Code repris de fiunchinho/rabbitmq-service-provider en attendant la compatibilité
20			* avec silex 2
21			*/
22			class RabbitServiceProvider implements ServiceProviderInterface
23			{
24			const DEFAULT_CONNECTION = 'default';
25
26			public function register(Container $app)
27			{
28			$this->loadConnections($app);
			0 ignored issues – show Unused Code introduced 2016-03-14 15:50 UTC by Report Bug Copy Issue Report The call to the method `ETNA\Silex\Provider\Rabb...ider::loadConnections()` seems un-needed as the method has no side-effects. PHP Analyzer performs a side-effects analysis of your code. A side-effect is basically anything that might be visible after the scope of the method is left. Let’s take a look at an example: class User { private $email; public function getEmail() { return $this->email; } public function setEmail($email) { $this->email = $email; } } If we look at the `getEmail()` method, we can see that it has no side-effect. Whether you call this method or not, no future calls to other methods are affected by this. As such code as the following is useless: $user = new User(); $user->getEmail(); // This line could safely be removed as it has no effect. On the hand, if we look at the `setEmail()`, this method _has_ side-effects. In the following case, we could not remove the method call: $user = new User(); $user->setEmail('email@domain'); // This line has a side-effect (it changes an // instance variable). Loading history...
29			$this->loadProducers($app);
			0 ignored issues – show Unused Code introduced 2016-03-14 15:50 UTC by Report Bug Copy Issue Report The call to the method `ETNA\Silex\Provider\Rabb...ovider::loadProducers()` seems un-needed as the method has no side-effects. PHP Analyzer performs a side-effects analysis of your code. A side-effect is basically anything that might be visible after the scope of the method is left. Let’s take a look at an example: class User { private $email; public function getEmail() { return $this->email; } public function setEmail($email) { $this->email = $email; } } If we look at the `getEmail()` method, we can see that it has no side-effect. Whether you call this method or not, no future calls to other methods are affected by this. As such code as the following is useless: $user = new User(); $user->getEmail(); // This line could safely be removed as it has no effect. On the hand, if we look at the `setEmail()`, this method _has_ side-effects. In the following case, we could not remove the method call: $user = new User(); $user->setEmail('email@domain'); // This line has a side-effect (it changes an // instance variable). Loading history...
30			$this->loadConsumers($app);
			0 ignored issues – show Unused Code introduced 2016-03-14 15:50 UTC by Report Bug Copy Issue Report The call to the method `ETNA\Silex\Provider\Rabb...ovider::loadConsumers()` seems un-needed as the method has no side-effects. PHP Analyzer performs a side-effects analysis of your code. A side-effect is basically anything that might be visible after the scope of the method is left. Let’s take a look at an example: class User { private $email; public function getEmail() { return $this->email; } public function setEmail($email) { $this->email = $email; } } If we look at the `getEmail()` method, we can see that it has no side-effect. Whether you call this method or not, no future calls to other methods are affected by this. As such code as the following is useless: $user = new User(); $user->getEmail(); // This line could safely be removed as it has no effect. On the hand, if we look at the `setEmail()`, this method _has_ side-effects. In the following case, we could not remove the method call: $user = new User(); $user->setEmail('email@domain'); // This line has a side-effect (it changes an // instance variable). Loading history...
31			$this->loadAnonymousConsumers($app);
			0 ignored issues – show Unused Code introduced 2016-03-14 15:50 UTC by Report Bug Copy Issue Report The call to the method `ETNA\Silex\Provider\Rabb...oadAnonymousConsumers()` seems un-needed as the method has no side-effects. PHP Analyzer performs a side-effects analysis of your code. A side-effect is basically anything that might be visible after the scope of the method is left. Let’s take a look at an example: class User { private $email; public function getEmail() { return $this->email; } public function setEmail($email) { $this->email = $email; } } If we look at the `getEmail()` method, we can see that it has no side-effect. Whether you call this method or not, no future calls to other methods are affected by this. As such code as the following is useless: $user = new User(); $user->getEmail(); // This line could safely be removed as it has no effect. On the hand, if we look at the `setEmail()`, this method _has_ side-effects. In the following case, we could not remove the method call: $user = new User(); $user->setEmail('email@domain'); // This line has a side-effect (it changes an // instance variable). Loading history...
32			$this->loadMultipleConsumers($app);
			0 ignored issues – show Unused Code introduced 2016-03-14 15:50 UTC by Report Bug Copy Issue Report The call to the method `ETNA\Silex\Provider\Rabb...loadMultipleConsumers()` seems un-needed as the method has no side-effects. PHP Analyzer performs a side-effects analysis of your code. A side-effect is basically anything that might be visible after the scope of the method is left. Let’s take a look at an example: class User { private $email; public function getEmail() { return $this->email; } public function setEmail($email) { $this->email = $email; } } If we look at the `getEmail()` method, we can see that it has no side-effect. Whether you call this method or not, no future calls to other methods are affected by this. As such code as the following is useless: $user = new User(); $user->getEmail(); // This line could safely be removed as it has no effect. On the hand, if we look at the `setEmail()`, this method _has_ side-effects. In the following case, we could not remove the method call: $user = new User(); $user->setEmail('email@domain'); // This line has a side-effect (it changes an // instance variable). Loading history...
33			$this->loadRpcClients($app);
			0 ignored issues – show Unused Code introduced 2016-03-14 15:50 UTC by Report Bug Copy Issue Report The call to the method `ETNA\Silex\Provider\Rabb...vider::loadRpcClients()` seems un-needed as the method has no side-effects. PHP Analyzer performs a side-effects analysis of your code. A side-effect is basically anything that might be visible after the scope of the method is left. Let’s take a look at an example: class User { private $email; public function getEmail() { return $this->email; } public function setEmail($email) { $this->email = $email; } } If we look at the `getEmail()` method, we can see that it has no side-effect. Whether you call this method or not, no future calls to other methods are affected by this. As such code as the following is useless: $user = new User(); $user->getEmail(); // This line could safely be removed as it has no effect. On the hand, if we look at the `setEmail()`, this method _has_ side-effects. In the following case, we could not remove the method call: $user = new User(); $user->setEmail('email@domain'); // This line has a side-effect (it changes an // instance variable). Loading history...

etna-alternance / composer-rabbitmq-service-provider

Pull Request — v2 (#16)

RabbitServiceProvider::loadRpcServers() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like