Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.
Common duplication problems, and corresponding solutions are:
1 | <?php |
||
12 | class FeatureContext extends BaseContext implements SnippetAcceptingContext |
||
13 | { |
||
14 | /** |
||
15 | * @BeforeScenario |
||
16 | */ |
||
17 | public static function createExchangeAndQueue() |
||
33 | |||
34 | /** |
||
35 | * @AfterScenario @consumer |
||
36 | */ |
||
37 | public static function flushMessages() |
||
43 | |||
44 | /** |
||
45 | * @Then la connection :connection devrait être définie |
||
46 | */ |
||
47 | View Code Duplication | public function laConnectionDevraitEtreDefinie($connection) |
|
55 | |||
56 | /** |
||
57 | * @Then la connection :conn devrait être une instance de :class_name |
||
58 | */ |
||
59 | public function laConnectionDevraitEtreUneInstanceDe($conn, $class_name) |
||
60 | { |
||
61 | $connection = $this->laConnectionDevraitEtreDefinie($conn); |
||
62 | if (false === $connection instanceof $class_name) { |
||
63 | $actual_class = get_class($connection); |
||
64 | throw new \Exception( |
||
65 | "Expected connection {$conn} to be instance of {$class_name}. Instance of {$actual_class} instead." |
||
66 | ); |
||
67 | } |
||
68 | } |
||
69 | |||
70 | /** |
||
71 | * @Then le producer :producer devrait être défini |
||
72 | */ |
||
73 | View Code Duplication | public function leProducerDevraitEtreDefini($producer) |
|
81 | |||
82 | /** |
||
83 | * @Then le producer :producer devrait être une instance de :class_name |
||
84 | */ |
||
85 | public function leProducerDevraitEtreUneInstanceDe($producer_name, $class_name) |
||
86 | { |
||
87 | $producer = $this->leProducerDevraitEtreDefini($producer_name); |
||
88 | if (false === $producer instanceof $class_name) { |
||
89 | $class = get_class($producer); |
||
90 | throw new \Exception( |
||
91 | "Expected producer {$producer_name} to be instance of {$class_name}. Instance of {$class} instead." |
||
92 | ); |
||
93 | } |
||
94 | } |
||
95 | |||
96 | /** |
||
97 | * @When je publie un job via le producer :producer_name avec le corps contenu dans :body_file |
||
98 | */ |
||
99 | public function jePublieUnJobViaLeProducerAvecLeCorpsContenuDans($producer_name, $body_file) |
||
110 | |||
111 | /** |
||
112 | * @Then le consumer :consumer devrait être défini |
||
113 | */ |
||
114 | View Code Duplication | public function leConsumerDevraitEtreDefini($consumer) |
|
122 | |||
123 | /** |
||
124 | * @Then le consumer :consumer_name devrait être une instance de :class_name |
||
125 | */ |
||
126 | public function leConsumerDevraitEtreUneInstanceDe($consumer_name, $class_name) |
||
136 | |||
137 | /** |
||
138 | * @Given que je publie un message pour le consumer :consumer_name avec le corps contenu dans :body_file |
||
139 | */ |
||
140 | public function queJePublieUnMessagePourLeConsumerAvecLeCorpsContenuDans($consumer_name, $body_file) |
||
155 | |||
156 | /** |
||
157 | * @When le consumer :consumer_name consomme :nb_messages message |
||
158 | */ |
||
159 | public function leConsumerConsommeMessage($consumer_name, $nb_messages) |
||
165 | |||
166 | /** |
||
167 | * @Then le consumer :consumer_name devrait avoir consommé :nb_messages message avec le corps contenu dans :result_file |
||
168 | */ |
||
169 | public function leConsumerDevraitAvoirConsommeMessageAvecLeCorpsContenuDans( |
||
192 | } |
||
193 |