Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.
Common duplication problems, and corresponding solutions are:
1 | <?php |
||
13 | trait WorkflowTransitionTrait |
||
14 | { |
||
15 | public static function transitionIndex($page = 10) |
||
23 | |||
24 | public static function transitionCreate() |
||
30 | |||
31 | public static function transitionStore($request = array()) |
||
32 | { |
||
33 | $name = str_replace('_','-',\Transliteration::clean_filename(strtolower($req->label))); |
||
34 | $label = $request->label; |
||
35 | $from = join(',',$request->from); |
||
36 | $to = join(',',$request->to); |
||
37 | $message = $request->message; |
||
38 | |||
39 | try |
||
40 | { |
||
41 | WorkflowTransition::create([ |
||
42 | 'name' => $name, |
||
43 | 'label' => $label, |
||
44 | 'from' => $from, |
||
45 | 'to' => $to, |
||
46 | 'message' => $message |
||
47 | ]); |
||
48 | } |
||
49 | catch(\Illuminate\Database\QueryException $e){ |
||
50 | // do what you want here with $e->getMessage(); |
||
51 | return redirect()->route('transition')->with('message', 'Error'); |
||
52 | } |
||
53 | |||
54 | return redirect()->route('transition')->with('message', 'Add data success'); |
||
55 | } |
||
56 | |||
57 | View Code Duplication | public static function transitionEdit($id) |
|
64 | |||
65 | View Code Duplication | public static function transitionUpdate($request = array(), $id) |
|
90 | |||
91 | public static function transitionActive($id){ |
||
96 | |||
97 | public static function transitionDeActive($id){ |
||
102 | |||
103 | } |
||
104 |
This check looks for variable assignements that are either overwritten by other assignments or where the variable is not used subsequently.
Both the
$myVar
assignment in line 1 and the$higher
assignment in line 2 are dead. The first because$myVar
is never used and the second because$higher
is always overwritten for every possible time line.