HostkeysController - Code Metrics - Inspection of "upfix" - etanasia/laravel-api-managers - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 5fb9ba...ca94a8 )

by Esza

created 2019-07-18 18:06 UTC

HostkeysController A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	345
Duplicated Lines	38.84 %

Coupling/Cohesion

Components	0
Dependencies	6

Importance

Changes

Metric	Value
wmc	35
lcom	0
cbo	6
dl	134
loc	345
rs	9.6
c	0
b	0
f	0

10 Methods

Rating	Name	Duplication	Size	Complexity
A	index()	22	22	3
A	create()	0	4	1
A	store()	40	40	3
A	show()	0	4	1
A	get()	0	37	2
B	send_apimanager()	24	52	5
A	edit()	0	4	1
A	update()	40	40	3
A	destroy()	0	4	1
F	request()	8	85	15

How to fix Duplicated Code

<?php

namespace App\Http\Controllers;

use App\Http\Controllers\Controller;
use Illuminate\Http\Request;
use App\Hostkeys;
use That0n3guy\Transliteration;

use GuzzleHttp\Exception\GuzzleException;
use GuzzleHttp\Client;
use GuzzleHttp\Pool;
use GuzzleHttp\Psr7;
use Auth;
use Validator, Image, Session, File, Response, Redirect, Exception;

class HostkeysController extends Controller
{

  /**
   * Display a listing of the resource.
   *
   * @return Response
   */
  public function index(Request $request)

  {
      try {
        if($request->get('search') != ''){
          $data['data']	= Hostkeys::with('getState')
foreach ($collection as $item) {
    $myArray['foo'] = $item->getFoo();

    if ($item->hasBar()) {
        $myArray['bar'] = $item->getBar();
    }

    // do something with $myArray
}
                                 ->with('getTransition')
                                 ->with('getUserName')
                                 ->where('hostname', 'like', '%'.$request->get('search').'%')
                                 ->orderBy('id', 'desc')
                                 ->paginate(env('PAGINATE', 10));
        } else{
          $data['data']	= Hostkeys::with('getState')
foreach ($collection as $item) {
    $myArray['foo'] = $item->getFoo();

    if ($item->hasBar()) {
        $myArray['bar'] = $item->getBar();
    }

    // do something with $myArray
}
                                 ->with('getTransition')
                                 ->with('getUserName')
                                 ->orderBy('id', 'desc')
                                 ->paginate(env('PAGINATE', 10));
        }
      } catch (Exception $e) {
          $data['data']	= [];
function myFunction($a) {
    switch ($a) {
        case 'foo':
            $x = 1;
            break;

        case 'bar':
            $x = 2;
            break;
    }

    // $x is potentially undefined here.
    echo $x;
}
      }
      return view('host_keys.index', $data);
  }

  /**
   * Show the form for creating a new resource.
   *
   * @return Response
   */
  public function create()
  {
    return view('host_keys.create');
  }

  /**
   * Store a newly created resource in storage.
   *
   * @return Response
   */
  public function store(Request $request)

  {
      try {
          if($request->keys != NULL){
            $keys = $request->keys;
          }else {
            $keys = "";
          }
          $hostkey = New Hostkeys;
          $hostkey->hostname 	= str_replace(array('https://', 'http://'), array('',''),$request->hostname);
          $hostkey->keys 		= $keys;
          $hostkey->state 		= $request->state;
          $hostkey->transition 	= $request->transition;
          $hostkey->user_id     = $request->user_id;
          $hostkey->save();

          $error = false;
          $statusCode = 200;
          $title = 'Success';
          $type = 'success';
          $message = 'Data Saved Successfuly.';
          $result = $hostkey;
      } catch (Exception $e) {
          $error = true;
          $statusCode = 404;
          $title = 'Error';
          $type = 'error';
          $message = 'Error';
          $result = 'Not Found';
      } finally {
          return Response::json(array(
            'error' => $error,
function myFunction($a) {
    switch ($a) {
        case 'foo':
            $x = 1;
            break;

        case 'bar':
            $x = 2;
            break;
    }

    // $x is potentially undefined here.
    echo $x;
}
            'status' => $statusCode,
function myFunction($a) {
    switch ($a) {
        case 'foo':
            $x = 1;
            break;

        case 'bar':
            $x = 2;
            break;
    }

    // $x is potentially undefined here.
    echo $x;
}
            'title' => $title,
function myFunction($a) {
    switch ($a) {
        case 'foo':
            $x = 1;
            break;

        case 'bar':
            $x = 2;
            break;
    }

    // $x is potentially undefined here.
    echo $x;
}
            'type' => $type,
function myFunction($a) {
    switch ($a) {
        case 'foo':
            $x = 1;
            break;

        case 'bar':
            $x = 2;
            break;
    }

    // $x is potentially undefined here.
    echo $x;
}
            'message' => $message,
function myFunction($a) {
    switch ($a) {
        case 'foo':
            $x = 1;
            break;

        case 'bar':
            $x = 2;
            break;
    }

    // $x is potentially undefined here.
    echo $x;
}
            'result' => $result
function myFunction($a) {
    switch ($a) {
        case 'foo':
            $x = 1;
            break;

        case 'bar':
            $x = 2;
            break;
    }

    // $x is potentially undefined here.
    echo $x;
}
          ));
      }
  }

  /**
   * Display the specified resource.
   *
   * @param  int  $id
   * @return Response
   */
  public function show($id)
  {

  }

  public function get($hostname)
  {
      try {
          $data	= Hostkeys::with('getState')
                                 ->with('getTransition')
                                 ->with('getUserName')
                                 ->where('hostname', 'like', '%'.$hostname.'%')
                                 ->orderBy('id', 'desc')
                                 ->first();

           $error = false;
           $statusCode = 200;
           $title = 'Success';
           $type = 'success';
           $message = 'Success';
           $result = $data->hostname;
           $resultid = $data->id;
      } catch (Exception $e) {
          $error = true;
          $statusCode = 404;
          $title = 'Error';
          $type = 'error';
          $message = 'Error';
          $result = 'Not Found';
          $resultid = 'Not Found';
      } finally {
          return Response::json(array(
            'error' => $error,
function myFunction($a) {
    switch ($a) {
        case 'foo':
            $x = 1;
            break;

        case 'bar':
            $x = 2;
            break;
    }

    // $x is potentially undefined here.
    echo $x;
}
            'status' => $statusCode,
function myFunction($a) {
    switch ($a) {
        case 'foo':
            $x = 1;
            break;

        case 'bar':
            $x = 2;
            break;
    }

    // $x is potentially undefined here.
    echo $x;
}
            'title' => $title,
function myFunction($a) {
    switch ($a) {
        case 'foo':
            $x = 1;
            break;

        case 'bar':
            $x = 2;
            break;
    }

    // $x is potentially undefined here.
    echo $x;
}
            'type' => $type,
function myFunction($a) {
    switch ($a) {
        case 'foo':
            $x = 1;
            break;

        case 'bar':
            $x = 2;
            break;
    }

    // $x is potentially undefined here.
    echo $x;
}
            'message' => $message,
function myFunction($a) {
    switch ($a) {
        case 'foo':
            $x = 1;
            break;

        case 'bar':
            $x = 2;
            break;
    }

    // $x is potentially undefined here.
    echo $x;
}
            'result' => $result,
function myFunction($a) {
    switch ($a) {
        case 'foo':
            $x = 1;
            break;

        case 'bar':
            $x = 2;
            break;
    }

    // $x is potentially undefined here.
    echo $x;
}
            'id' => $resultid
function myFunction($a) {
    switch ($a) {
        case 'foo':
            $x = 1;
            break;

        case 'bar':
            $x = 2;
            break;
    }

    // $x is potentially undefined here.
    echo $x;
}
          ));
      }
  }

  public function request(Request $request){
      Validator::extend('without_spaces', function($attr, $value){
        return preg_match('/^\S*$/u', $value);
      });
      $validator = Validator::make($request->all(), [
        'host'			=> 'required|without_spaces|unique:host_keys,hostname',
        'description'		=> 'required',
      ]);
      if($validator->fails())
      {
        Session::flash('message', 'Please fix the error(s) below');
            return redirect()->back()
                ->withErrors($validator)
                ->withInput();
      }
      if(Auth::guest()){ $current_user = 1; }

      else{ $current_user = (Auth::user())?((Auth::user()->id)?Auth::user()->id:1):1; }
      $headers = ['Content-Type' => 'application/json'];
      $data = [
        'host' => $request->host,
        'client' => $request->client,
        'request' => 'Request',
        'deskripsi' => $request->description,
        'user_id' => $current_user
      ];
      $body = json_encode($data);
      $host 			= str_replace(array('https://', 'http://'), array('',''),$request->host);

      try {
          $url = "https://".$host."/api/v1/api-manager/request";
          $client = new \GuzzleHttp\Client();
          $res = $client->request('POST', $url,['headers'=>$headers,'body'=>$body]);
          $response = $res->getBody();
          $responses = json_decode($response);
          $msg = "success";
      } catch (GuzzleException $e) {
          $msg = "error";
          $responses = $e;
      }

      if($msg == "success"){
        $responses = $responses;

      }else {
        try {
            $urlz = "http://".$host."/api/v1/api-manager/request";
            $clientz = new \GuzzleHttp\Client();
            $resz = $clientz->request('POST', $urlz,['headers'=>$headers,'body'=>$body]);
            $responsez = $resz->getBody();
            $responsesz = json_decode($responsez);
            $msgz = "success";
        } catch (GuzzleException $er) {
            $msgz = "error";
            $responsesz = $er;
        }

        if($msgz == "success"){
          $responses = $responsesz;
        }else {
          $message = $msgz.' - '.$responsesz->getMessage();
          Session::flash('message', $message);
          return Redirect::to('host-keys');
        }
      }

      if($responses->status == 200){
		$hostkey = New Hostkeys;
		$hostkey->hostname 		= $host;
		$hostkey->keys 			= "";
		$hostkey->state 		= $responses->result->request;
		$hostkey->transition 	= "Propose To ".$responses->result->request;
		$hostkey->user_id       = $responses->result->user_id;
        $hostkey->save();
        if(env('URL_APIMANAGER') != NULL){

          $url_apimanager = str_replace('"', '',env('URL_APIMANAGER'));
          if($url_apimanager != "" || $url_apimanager != NULL || $url_apimanager != false || !empty($url_apimanager)){
            $this->send_apimanager($url_apimanager,$request,$current_user,$hostkey->transition);
          }
        }
        Session::flash('message', 'Send Request Api Keys Successfuly');
      }else {
        Session::flash('message', $responses->message);
      }

      return Redirect::to('host-keys');
  }

  private function send_apimanager($url_apimanager,$request,$current_user,$keterangan){
      $headers = ['Content-Type' => 'application/json'];
      $host       = str_replace(array('https://', 'http://'), array('',''),$request->host);
      $client       = str_replace(array('https://', 'http://'), array('',''),$request->client);
      $data = [
        'host' => $host,
        'client' => $client,
        'keterangan' => $keterangan,
        'user_id' => $current_user
      ];
      $body = json_encode($data);
      $url_apimanager       = str_replace(array('https://', 'http://'), array('',''),$url_apimanager);

      try {
          $url = "https://".$url_apimanager."/api/store";
          $client = new \GuzzleHttp\Client();
          $res = $client->request('POST', $url,['headers'=>$headers,'body'=>$body]);
          $response = $res->getBody();
          $responses = json_decode($response);
          $msg = "success";
      } catch (GuzzleException $e) {
          $msg = "error";
          $responses = $e;
      }

      if($msg == "success"){

        $responses = $responses;

        $message = 'Send Apikey to Host Api Manager successfully with description is '.$keterangan;
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}
      }else {
        try {
            $urlz = "http://".$url_apimanager."/api/store";
            $clientz = new \GuzzleHttp\Client();
            $resz = $clientz->request('POST', $urlz,['headers'=>$headers,'body'=>$body]);
            $responsez = $resz->getBody();
            $responsesz = json_decode($responsez);
            $msgz = "success";
        } catch (GuzzleException $er) {
            $msgz = "error";
            $responsesz = $er;
        }

        if($msgz == "success"){
          $responses = $responsesz;
          $message = 'Send Apikey to Host Api Manager successfully with description is '.$keterangan;
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}
        }else {
          $responses = $responsesz->getMessage();
          $message = $msgz.' - '.$responsesz->getMessage();
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}
        }
      }

      return $responses;
  }

  /**
   * Show the form for editing the specified resource.
   *
   * @param  int  $id
   * @return Response
   */
  public function edit($id)
  {

  }

  /**
   * Update the specified resource in storage.
   *
   * @param  int  $id
   * @return Response
   */
   public function update(Request $request, $id)

   {
       try {
           if($request->keys != NULL){
             $keys = $request->keys;
           }else {
             $keys = "";
           }
           $hostkey = Hostkeys::findOrFail($id);
           $hostkey->hostname 	= str_replace(array('https://', 'http://'), array('',''),$request->hostname);
           $hostkey->keys 		= $keys;
           $hostkey->state 		= $request->state;
           $hostkey->transition = $request->transition;
           $hostkey->user_id    = $request->user_id;
           $hostkey->save();

           $error = false;
           $statusCode = 200;
           $title = 'Success';
           $type = 'success';
           $message = 'Data Saved Successfuly.';
           $result = $hostkey;
       } catch (Exception $e) {
           $error = true;
           $statusCode = 404;
           $title = 'Error';
           $type = 'error';
           $message = 'Error';
           $result = 'Not Found';
       } finally {
           return Response::json(array(
             'error' => $error,
function myFunction($a) {
    switch ($a) {
        case 'foo':
            $x = 1;
            break;

        case 'bar':
            $x = 2;
            break;
    }

    // $x is potentially undefined here.
    echo $x;
}
             'status' => $statusCode,
function myFunction($a) {
    switch ($a) {
        case 'foo':
            $x = 1;
            break;

        case 'bar':
            $x = 2;
            break;
    }

    // $x is potentially undefined here.
    echo $x;
}
             'title' => $title,
function myFunction($a) {
    switch ($a) {
        case 'foo':
            $x = 1;
            break;

        case 'bar':
            $x = 2;
            break;
    }

    // $x is potentially undefined here.
    echo $x;
}
             'type' => $type,
function myFunction($a) {
    switch ($a) {
        case 'foo':
            $x = 1;
            break;

        case 'bar':
            $x = 2;
            break;
    }

    // $x is potentially undefined here.
    echo $x;
}
             'message' => $message,
function myFunction($a) {
    switch ($a) {
        case 'foo':
            $x = 1;
            break;

        case 'bar':
            $x = 2;
            break;
    }

    // $x is potentially undefined here.
    echo $x;
}
             'result' => $result
function myFunction($a) {
    switch ($a) {
        case 'foo':
            $x = 1;
            break;

        case 'bar':
            $x = 2;
            break;
    }

    // $x is potentially undefined here.
    echo $x;
}
           ));
       }
   }

  /**
   * Remove the specified resource from storage.
   *
   * @param  int  $id
   * @return Response
   */
  public function destroy($id)
  {

  }

}

?>



Push — master ( 5fb9ba...ca94a8 )

HostkeysController A

Complexity

Size/Duplication

Coupling/Cohesion

Importance

10 Methods

How to fix Duplicated Code

Duplicated Code

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

1		<?php
2
3		namespace App\Http\Controllers;
4
5		use App\Http\Controllers\Controller;
6		use Illuminate\Http\Request;
7		use App\Hostkeys;
8		use That0n3guy\Transliteration;
9
10		use GuzzleHttp\Exception\GuzzleException;
11		use GuzzleHttp\Client;
12		use GuzzleHttp\Pool;
13		use GuzzleHttp\Psr7;
14		use Auth;
15		use Validator, Image, Session, File, Response, Redirect, Exception;
16
17		class HostkeysController extends Controller
18		{
19
20		/**
21		* Display a listing of the resource.
22		*
23		* @return Response
24		*/
25	View Code Duplication	public function index(Request $request)
		0 ignored issues – show Duplication introduced 2019-07-11 09:28 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
26		{
27		try {
28		if($request->get('search') != ''){
29		$data['data'] = Hostkeys::with('getState')
		0 ignored issues – show Coding Style Comprehensibility introduced 2019-07-11 09:28 UTC by Report Bug Copy Issue Report `$data` was never initialized. Although not strictly required by PHP, it is generally a good practice to add `$data = array();` before regardless. Adding an explicit array definition is generally preferable to implicit array definition as it guarantees a stable state of the code. Let’s take a look at an example: foreach ($collection as $item) { $myArray['foo'] = $item->getFoo(); if ($item->hasBar()) { $myArray['bar'] = $item->getBar(); } // do something with $myArray } As you can see in this example, the array `$myArray` is initialized the first time when the foreach loop is entered. You can also see that the value of the `bar` key is only written conditionally; thus, its value might result from a previous iteration. This might or might not be intended. To make your intention clear, your code more readible and to avoid accidental bugs, we recommend to add an explicit initialization `$myArray = array()` either outside or inside the foreach loop. Loading history...
30		->with('getTransition')
31		->with('getUserName')
32		->where('hostname', 'like', '%'.$request->get('search').'%')
33		->orderBy('id', 'desc')
34		->paginate(env('PAGINATE', 10));
35		} else{
36		$data['data'] = Hostkeys::with('getState')
		0 ignored issues – show Coding Style Comprehensibility introduced 2019-07-11 09:28 UTC by Report Bug Copy Issue Report `$data` was never initialized. Although not strictly required by PHP, it is generally a good practice to add `$data = array();` before regardless. Adding an explicit array definition is generally preferable to implicit array definition as it guarantees a stable state of the code. Let’s take a look at an example: foreach ($collection as $item) { $myArray['foo'] = $item->getFoo(); if ($item->hasBar()) { $myArray['bar'] = $item->getBar(); } // do something with $myArray } As you can see in this example, the array `$myArray` is initialized the first time when the foreach loop is entered. You can also see that the value of the `bar` key is only written conditionally; thus, its value might result from a previous iteration. This might or might not be intended. To make your intention clear, your code more readible and to avoid accidental bugs, we recommend to add an explicit initialization `$myArray = array()` either outside or inside the foreach loop. Loading history...
37		->with('getTransition')

etanasia / laravel-api-managers

Push — master ( 5fb9ba...ca94a8 )

HostkeysController A

Complexity

Size/Duplication

Coupling/Cohesion

Importance

10 Methods

How to fix Duplicated Code

Duplicated Code

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Duplication Side-by-Side

Filter issues like