Gameap\Http\Controllers\API\ServersRconController

Complexity

Total Complexity

12

Size/Duplication

Total Lines	112
Duplicated Lines	0 %

Test Coverage

Coverage

64.52%

Importance

Changes	1
Bugs	0	Features	0

7 Methods

Rating	Name	Duplication	Size	Complexity
A	supportedFeatures()	0	3	1
A	message()	0	9	2
A	sendCommand()	0	8	2
A	ban()	0	13	2
A	kick()	0	9	2
A	getPlayers()	0	9	2
A	fastRcon()	0	5	1

<?php

namespace Gameap\Http\Controllers\API;

use Gameap\Http\Controllers\AuthController;

This use statement conflicts with another class in this namespace, Gameap\Http\Controllers\API\AuthController. Consider defining an alias.

use Gameap\Http\Requests\API\Rcon\BanRequest;
use Gameap\Http\Requests\API\Rcon\CommandRequest;
use Gameap\Http\Requests\API\Rcon\KickRequest;
use Gameap\Models\Server;
use Gameap\Services\RconService;

class ServersRconController extends AuthController
{
    /**
     * Get supported features list
     *
     * @param RconService $rconService
     * @param Server $server
     * @return array
     * @throws \Knik\GRcon\Exceptions\ProtocolNotSupportedException
     */
    public function supportedFeatures(RconService $rconService, Server $server)
    {
        return $rconService->supportedFeatures($server);
    }

    public function fastRcon(Server $server)
    {
        $this->authorize('server-rcon-console', $server);

        return $server->gameMod->fast_rcon;
    }

    /**
     * @param RconService $rconService
     * @param CommandRequest $request
     * @return array
     */
    public function sendCommand(CommandRequest $request, RconService $rconService, Server $server)
    {
        $this->authorize('server-rcon-console', $server);

        return [
            'output' => $server->processActive()
                ? $rconService->sendCommand($server, $request->post('command'))

It seems like $request->post('command') can also be of type array and null; however, parameter $command of Gameap\Services\RconService::sendCommand() does only seem to accept string, maybe add an additional type check?

                : 'Server is offline',
        ];
    }

    /**
     * Get Player list
     *
     * @param RconService $rconService
     * @param Server $server
     * @return array
     * @throws \Knik\GRcon\Exceptions\PlayersManageNotSupportedExceptions
     */
    public function getPlayers(RconService $rconService, Server $server)
    {
        $this->authorize('server-rcon-players', $server);

        if (!$server->processActive()) {
            return [];
        }

        return $rconService->getPlayers($server);
    }

    /**
     * Kick Player
     *
     * @param KickRequest $request
     * @param RconService $rconService
     * @param Server $server
     * @return mixed
     * @throws \Knik\GRcon\Exceptions\ProtocolNotSupportedException
     */
    public function kick(KickRequest $request, RconService $rconService, Server $server)
    {
        $this->authorize('server-rcon-players', $server);

        if (!$server->processActive()) {
            return 'Server is offline';
        }

        return $rconService->kick($server, $request->post('player'), $request->post('reason'));

It seems like $request->post('reason') can also be of type array and null; however, parameter $reason of Gameap\Services\RconService::kick() does only seem to accept string, maybe add an additional type check?

    }

    /**
     * Ban Player
     *
     * @param BanRequest $request
     * @param RconService $rconService
     * @param Server $server
     * @return mixed
     * @throws \Knik\GRcon\Exceptions\PlayersManageNotSupportedExceptions
     * @throws \Knik\GRcon\Exceptions\ProtocolNotSupportedException
     */
    public function ban(BanRequest $request, RconService $rconService, Server $server)
    {
        $this->authorize('server-rcon-players', $server);

        if (!$server->processActive()) {
            return 'Server is offline';
        }

        return $rconService->ban(
            $server,
            $request->post('player'),
            $request->post('reason'),

It seems like $request->post('reason') can also be of type array and null; however, parameter $reason of Gameap\Services\RconService::ban() does only seem to accept string, maybe add an additional type check?

            $request->post('time')

$request->post('time') of type array|null|string is incompatible with the type integer expected by parameter $time of Gameap\Services\RconService::ban().

        );
    }

    public function message(RconService $rconService, Server $server)
    {
        $this->authorize('server-rcon-players', $server);

        if ($server->processActive()) {
            return 'Server is offline';
        }

        return 'Not implemented';
    }
}