InfoService::loadVersionFromGameap() - Code Metrics - Inspection of "refactoring and testing" - et-nik/gameap - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — develop ( 99647f...e3783d )

by Nikita

created 2021-01-05 18:11 UTC

InfoService::loadVersionFromGameap() A

↳ Parent: InfoService

Complexity

Conditions	3
Paths	3

Size

Total Lines	15
Code Lines	9

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	0
CRAP Score	12

Importance

Changes

Metric	Value
eloc	9
c	0
b	0
f	0
dl	0
loc	15
ccs	0
cts	6
cp	0
rs	9.9666
cc	3
nc	3
nop	0
crap	12

<?php

namespace Gameap\Services;

use GuzzleHttp\Client;
use GuzzleHttp\Exception\RequestException;
use Illuminate\Http\Response;

class InfoService
{
    private const GAMEAP_LATEST_VERSION_URI = 'http://www.gameap.ru/gameap_version.txt';
    private const GITHUB_LATEST_VERSION_URI = 'https://api.github.com/repos/et-nik/gameap/releases/latest';
    /** @var Client */
    private $client;

    public function __construct(Client $client)
    {
        $this->client = $client;
    }

    public function latestRelease(): string
    {
        $version = $this->loadVersionFromGameap();

        if ($version === '') {
            $version = $this->loadVersionFromGithub();
        }

        return $version;
    }

    private function loadVersionFromGameap(): string
    {
        try {
            $res = $this->client->get(self::GAMEAP_LATEST_VERSION_URI);
        } catch (RequestException $e) {
            return '';
        }

        if ($res->getStatusCode() === Response::HTTP_OK) {
            $lines  = explode("\n", $res->getBody()->getContents());
            $parts  = explode(': ', $lines[0]);
            return $parts[1];
        }

        return '';
    }

    private function loadVersionFromGithub(): string
    {
        try {
            $res = $this->client->get(self::GITHUB_LATEST_VERSION_URI);
        } catch (RequestException $e) {
            return '';
        }

        if ($res->getStatusCode() === Response::HTTP_OK) {
            $result = json_decode($res->getBody()->getContents());

            if (!empty($result->tag_name)) {
                return $result->tag_name;
            }
        }

        return '';
    }
}


1			<?php
2
3			namespace Gameap\Services;
4
5			use GuzzleHttp\Client;
6			use GuzzleHttp\Exception\RequestException;
7			use Illuminate\Http\Response;
8
9			class InfoService
10			{
11			private const GAMEAP_LATEST_VERSION_URI = 'http://www.gameap.ru/gameap_version.txt';
12			private const GITHUB_LATEST_VERSION_URI = 'https://api.github.com/repos/et-nik/gameap/releases/latest';
13			/** @var Client */
14			private $client;
15
16			public function __construct(Client $client)
17			{
18			$this->client = $client;
19			}
20
21			public function latestRelease(): string
22			{
23			$version = $this->loadVersionFromGameap();
24
25			if ($version === '') {
26			$version = $this->loadVersionFromGithub();
27			}
28
29			return $version;
30			}
31
32			private function loadVersionFromGameap(): string
33			{
34			try {
35			$res = $this->client->get(self::GAMEAP_LATEST_VERSION_URI);
36			} catch (RequestException $e) {
37			return '';
38			}
39
40			if ($res->getStatusCode() === Response::HTTP_OK) {
41			$lines = explode("\n", $res->getBody()->getContents());
42			$parts = explode(': ', $lines[0]);
43			return $parts[1];
44			}
45
46			return '';
47			}
48
49			private function loadVersionFromGithub(): string
50			{
51			try {
52			$res = $this->client->get(self::GITHUB_LATEST_VERSION_URI);
53			} catch (RequestException $e) {
54			return '';
55			}
56
57			if ($res->getStatusCode() === Response::HTTP_OK) {
58			$result = json_decode($res->getBody()->getContents());
59
60			if (!empty($result->tag_name)) {
61			return $result->tag_name;
62			}
63			}
64
65			return '';
66			}
67			}
68

et-nik / gameap

Push — develop ( 99647f...e3783d )

InfoService::loadVersionFromGameap() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like