Gameap\Services\CertificateService::signCsr()

Complexity

Conditions	7
Paths	18

Size

Total Lines	56
Code Lines	36

Duplication

Lines	0
Ratio	0 %

Importance

Changes

0

<?php
    static public function signCsr($csrPath)
    {
        if (!Storage::exists(self::ROOT_CA)) {
            self::generateRoot();
        }

        $rootCa = Storage::get(self::ROOT_CA);
        $rootKey = Storage::get(self::ROOT_KEY);

        if (file_exists($csrPath)) {
            $csr = file_get_contents($csrPath);
            $fromStorage = false;
        } else if (Storage::exists($csrPath)) {
            $csr = Storage::get($csrPath);
            $fromStorage = true;
        } else {
            throw new GameapException('Invalid csr path');
        }

        $pathinfo = pathinfo($csrPath);
        $signedCertificatePath = $pathinfo['dirname'] . '/' . $pathinfo['filename'] . '.crt';

        $CAPrivKey = new RSA();
        $CAPrivKey->loadKey($rootKey);

$rootKey of type Illuminate\Contracts\Filesystem\Filesystem is incompatible with the type array|phpseclib\Crypt\RSA|string expected by parameter $key of phpseclib\Crypt\RSA::loadKey().

        $issuer = new X509();
        $issuer->loadCA($rootCa);

$rootCa of type Illuminate\Contracts\Filesystem\Filesystem is incompatible with the type string expected by parameter $cert of phpseclib\File\X509::loadCA().

        $issuer->loadX509($rootCa);

$rootCa of type Illuminate\Contracts\Filesystem\Filesystem is incompatible with the type string expected by parameter $cert of phpseclib\File\X509::loadX509().

        $issuer->setPrivateKey($CAPrivKey);

        $subject = new X509();
        $subject->loadCSR($csr);

It seems like $csr can also be of type Illuminate\Contracts\Filesystem\Filesystem; however, parameter $csr of phpseclib\File\X509::loadCSR() does only seem to accept string, maybe add an additional type check?

        $x509 = new X509();
        $x509->setEndDate('+10 year');

        $result = $x509->sign($issuer, $subject, 'sha256WithRSAEncryption');
        $result['tbsCertificate']['version'] = 'v1';

        if ($result == false) {

The condition $result == false is always true.

It seems like you are loosely comparing two booleans. Considering using the strict comparison === instead.

            throw new GameapException('Signing has failed.');
        }

        $pemCertificate = $x509->saveX509($result);

        if (empty($pemCertificate)) {
            throw new GameapException('X509 Saving has failed.');
        }

        if ($fromStorage) {
            Storage::put($signedCertificatePath, $pemCertificate);
        } else {
            file_put_contents($signedCertificatePath, $pemCertificate);
        }

        return $signedCertificatePath;
    }
}