Gameap\Repositories\ServersTasksRepository

Complexity

Total Complexity

14

Size/Duplication

Total Lines	122
Duplicated Lines	0 %

Test Coverage

Coverage

95.92%

Importance

Changes	1
Bugs	0	Features	0

8 Methods

Rating	Name	Duplication	Size	Complexity
A	getTasks()	0	10	2
A	update()	0	6	1
A	convert()	0	20	4
A	get()	0	3	1
A	store()	0	8	1
A	__construct()	0	3	1
A	validate()	0	4	3
A	convertModelToArray()	0	15	1

<?php

namespace Gameap\Repositories;

use Carbon\CarbonInterval;
use Gameap\Exceptions\Repositories\RepositoryValidationException;
use Gameap\Models\ServerTask;

class ServersTasksRepository
{
    public const MIN_PERIOD_IN_SECONDS = 600;

    /** @var ServerTask */
    protected $model;

    public function __construct(ServerTask $serverTask)
    {
        $this->model = $serverTask;
    }

    /**
     * @param int $serverId
     * @return array
     */
    public function getTasks(int $serverId): array
    {
        $tasks = [];

        /** @var ServerTask $task */
        foreach (ServerTask::where('server_id', $serverId)->get() as $task) {
            $tasks[] = $this->convertModelToArray($task);
        }

        return $tasks;
    }

    /**
     * @param int $taskId
     * @return array
     */
    public function get(int $taskId): array
    {
        return $this->convertModelToArray(ServerTask::find($taskId));

It seems like Gameap\Models\ServerTask::find($taskId) can also be of type null; however, parameter $task of Gameap\Repositories\ServersTasksRepository::convertModelToArray() does only seem to accept Gameap\Models\ServerTask, maybe add an additional type check?

    }

    /**
     * @param array $task
     * @return int
     * @throws RepositoryValidationException
     */
    public function store(array $task): int
    {
        $this->validate($task);
        $convertedTask = $this->convert($task);

        $serverTask = ServerTask::create($convertedTask);

        return $serverTask->id;
    }

    /**
     * @param int $taskId
     * @param array $task
     * @throws RepositoryValidationException
     */
    public function update(int $taskId, array $task): void
    {
        $this->validate($task);
        $convertedTask = $this->convert($task);

        ServerTask::where('id', $taskId)->update($convertedTask);
    }

    /**
     * @param array $task
     * @return array
     * @throws RepositoryValidationException
     */
    private function convert(array $task)
    {
        if ($task['repeat'] != 1) {
            if (empty($task['repeat_period'])) {
                throw new RepositoryValidationException(__('servers_tasks.errors.empty_period'));

It seems like __('servers_tasks.errors.empty_period') can also be of type array and array; however, parameter $message of Gameap\Exceptions\Repositories\RepositoryValidationException::__construct() does only seem to accept string, maybe add an additional type check?

            }

            $task['repeat_period'] = CarbonInterval::fromString($task['repeat_period'])
                ->locale('en')
                ->cascade()
                ->totalSeconds;

            if ($task['repeat_period'] < self::MIN_PERIOD_IN_SECONDS) {
                throw new RepositoryValidationException(__('servers_tasks.errors.minimum_period'));
            }
        } else {
            $task['repeat_period'] = 0;
        }

        return $task;
    }

    /**
     * @param array $task
     * @throws RepositoryValidationException
     */
    private function validate(array $task): void
    {
        if (empty($task) || empty($task['command'])) {
            throw new RepositoryValidationException(__('servers_tasks.errors.empty_command'));

It seems like __('servers_tasks.errors.empty_command') can also be of type array and array; however, parameter $message of Gameap\Exceptions\Repositories\RepositoryValidationException::__construct() does only seem to accept string, maybe add an additional type check?

        }
    }

    /**
     * @param ServerTask $task
     * @return array
     */
    private function convertModelToArray(ServerTask $task)
    {
        return [
            'id'            => $task->id,
            'command'       => $task->command,
            'server_id'     => $task->server_id,
            'repeat'        => $task->repeat,
            'repeat_period' => CarbonInterval::seconds($task->repeat_period)
                ->locale('en')
                ->cascade()
                ->forHumans(),
            'execute_date' => $task->execute_date,
            'payload'      => $task->payload,
            'created_at'   => $task->created_at,
            'updated_at'   => $task->updated_at,
        ];
    }
}