Gameap\Http\Requests\API\Admin\UpdateNodeRequest

Complexity

Total Complexity

2

Size/Duplication

Total Lines	36
Duplicated Lines	0 %

Importance

Changes	2
Bugs	0	Features	0

2 Methods

Rating	Name	Duplication	Size	Complexity
A	id()	0	3	1
A	rules()	0	28	1

<?php

namespace Gameap\Http\Requests\API\Admin;

use Gameap\Http\Requests\JsonRequest;

class UpdateNodeRequest extends JsonRequest
{
    public function rules()
    {
        return [
            'name'                  => 'required|max:128',
            'location'              => 'required|max:128',
            'ip'                    => 'required',
            'work_path'             => 'required|max:128',
            'gdaemon_host'          => 'required|max:128',
            'gdaemon_port'          => 'required|numeric|digits_between:1,65535',
            'gdaemon_login'         => 'max:128',
            'gdaemon_password'      => 'max:128',
            'gdaemon_api_key'       => '',
            'gdaemon_server_cert'   => 'sometimes',
            'client_certificate_id' => 'numeric|exists:client_certificates,id',
            'script_install'        => '',
            'script_reinstall'      => '',
            'script_update'         => '',
            'script_start'          => '',
            'script_pause'          => '',
            'script_unpause'        => '',
            'script_stop'           => '',
            'script_kill'           => '',
            'script_restart'        => '',
            'script_status'         => '',
            'script_stats'          => '',
            'script_get_console'    => '',
            'script_send_command'   => '',
            'script_delete'         => '',
        ];
    }

    public function id(): int
    {
        return $this->get('id');

The expression return $this->get('id') could return the type null which is incompatible with the type-hinted return integer. Consider adding an additional type-check to rule them out.

    }
}