Knik\Binn\BinnMap

Complexity

Total Complexity

45

Size/Duplication

Total Lines	284
Duplicated Lines	0 %

Test Coverage

Coverage

84%

Importance

Changes

0

8 Methods

Rating	Name	Duplication	Size	Complexity
A	unserialize()	0	10	2
A	validArray()	0	12	3
A	binnOpen()	0	4	2
C	_binnLoad()	0	93	16
A	__construct()	0	10	2
B	getBinnVal()	0	47	11
A	_addVal()	0	24	2
B	serialize()	0	32	7

<?php

namespace Knik\Binn;

use Knik\Binn\Exceptions\InvalidArrayException;

class BinnMap extends BinnAbstract
{
    protected $binnType = self::BINN_MAP;

    public function __construct($binnString = '')
    {
        $this->binnType = self::BINN_MAP;
        $this->binnClass = self::class;

        if ($binnString != '') {
            $this->_binnLoad($binnString);
        }

        return $this;
    }

    /**
     * @param string $binnString
     */
    public function binnOpen($binnString = '')
    {
        if ($binnString != '') {
            $this->_binnLoad($binnString);
        }
    }

    /**
     * @param integer $key
     * @param int   $type
     * @param mixed $value
     */
    private function _addVal($key, $type, $value)
    {
        if (in_array($type,
            [self::BINN_INT64, self::BINN_INT32, self::BINN_INT16,
                self::BINN_UINT64,self::BINN_UINT32, self::BINN_UINT16])
        ) {
            $type = $this->compressInt($type, $value);
        }

        $size = $this->getTypeSize($type, $value);

        $this->dataSize += $size['data'];
        $this->metaSize += $size['meta'];

        // Key size. 4 bytes
        $this->metaSize += 4;

        $this->count++;

        $this->binnArr[] = [
            self::KEY_TYPE      => $type,
            self::KEY_VAL       => $value,
            self::KEY_SIZE      => $size['data'],
            self::KEY_KEY       => $key,
        ];
    }

    /**
     * @param string
     */
    private function _binnLoad($binnString)
    {
        $pos = 1; // Position
        $sizeBytes = $this->unpack(self::BINN_UINT8, $binnString[$pos]);

        // Size
        if ($sizeBytes & 1 << 7) {
            $sizeBytes = $this->unpack(self::BINN_UINT32, substr($binnString, $pos, 4));
            $this->size = ($sizeBytes &~ (1 << 31)); // Cut bit
            $pos += 4;
        } else {
            $this->size = $sizeBytes;

It seems like $sizeBytes can also be of type boolean. However, the property $size is declared as type integer. Maybe add an additional type check?

            $pos += 1;
        }

        unset($sizeBytes);

        $countBytes = $this->unpack(self::BINN_UINT8, $binnString[$pos]);

        // Size
        if ($countBytes & 1 << 7) {
            $countBytes = $this->unpack(self::BINN_UINT32, substr($binnString, $pos, 4));
            $this->count = ($countBytes &~ (1 << 31)); // Cut bit
            $pos += 4;
        } else {
            $this->count = $countBytes;

It seems like $countBytes can also be of type boolean. However, the property $count is declared as type integer. Maybe add an additional type check?

            $pos += 1;
        }

        unset($countBytes);

        // Data
        $stopWhile = false;
        while ($pos < $this->size && !$stopWhile) {
            $varKey = $this->unpack(self::BINN_INT32, substr($binnString, $pos, 4));
            $pos += 4;

            $varType = $this->unpack(self::BINN_UINT8, $binnString[$pos]);
            $varStorageType = $this->storageType($varType);
            $pos += 1;

            if ($varStorageType === self::BINN_STORAGE_QWORD
                || $varStorageType === self::BINN_STORAGE_DWORD
                || $varStorageType === self::BINN_STORAGE_WORD
                || $varStorageType === self::BINN_STORAGE_BYTE
                || $varStorageType === self::BINN_STORAGE_NOBYTES
            ) {
                $varSize = $this->getTypeSize($varType);
                $val = $this->unpack($varType, substr($binnString, $pos, $varSize['data']));
                $this->_addVal($varKey, $varType, $val);

It seems like $varType can also be of type boolean; however, parameter $type of Knik\Binn\BinnMap::_addVal() does only seem to accept integer, maybe add an additional type check?

It seems like $varKey can also be of type boolean; however, parameter $key of Knik\Binn\BinnMap::_addVal() does only seem to accept integer, maybe add an additional type check?

                $pos += $varSize['data'];

            } else if ($varStorageType === self::BINN_STRING ) {
                $stringSize = $this->unpack(self::BINN_UINT8, $binnString[$pos]);

                // Size
                if ($stringSize & 1 << 7) {
                    $stringSize = $this->unpack(self::BINN_UINT32, substr($binnString, $pos, 4));
                    $stringSize = ($stringSize &~ (1 << 31)); // Cut bit
                    $pos += 4;
                } else {
                    $pos += 1;
                }

                $this->_addVal($varKey,self::BINN_STRING, $this->unpack(
                    self::BINN_STRING,
                    substr($binnString, $pos, $stringSize)

It seems like $stringSize can also be of type boolean; however, parameter $length of substr() does only seem to accept integer, maybe add an additional type check?

                ));

                $pos += $stringSize;
                $pos += 1; // Null byte
            } else if ($varStorageType === self::BINN_STORAGE_CONTAINER) {
                $list_size = $this->unpack(self::BINN_UINT8, $binnString[$pos]);;

                // Size
                if ($list_size & 1 << 7) {
                    $list_size = $this->unpack(self::BINN_UINT32, substr($binnString, $pos, 4));
                    $list_size = ($list_size &~ (1 << 31)); // Cut bit
                }

                $substring = substr($binnString, $pos-1, $list_size);

                foreach ($this->containersClasses as $containerType => $containersClass) {
                    if ($containerType === $varType) {
                        $container = new $containersClass($substring);
                        $this->_addVal($varKey, $varType, $container);
                        break;
                    }
                }

                $pos += ($list_size-1);
            } else {
                $stopWhile = true;
            }
        }
    }

    /**
     * Get binary string
     *
     * @return string
     */
    public function getBinnVal()
    {
        $this->calculateSize();

        $this->binnString = '';
        $this->binnString .= $this->pack(self::BINN_UINT8, $this->binnType);

        $this->binnString .= $this->packSize($this->size);

        $count = count($this->binnArr);
        $this->binnString .= $this->packSize($count);

        foreach ($this->binnArr as &$arr) {
            $key = $arr[self::KEY_KEY];
            $type = $arr[self::KEY_TYPE];
            $storageType = $this->storageType($type);

            $this->binnString .= $this->pack(self::BINN_INT32, $key);

            if ($type === self::BINN_BOOL) {
                $this->binnString .= $arr[self::KEY_VAL]
                    ? $this->packType(self::BINN_TRUE)
                    : $this->packType(self::BINN_FALSE);

                continue;
            }

            if ($storageType === self::BINN_STORAGE_QWORD
                || $storageType === self::BINN_STORAGE_DWORD
                || $storageType === self::BINN_STORAGE_WORD
                || $storageType === self::BINN_STORAGE_BYTE
            ) {
                $this->binnString .= $this->packType($arr[self::KEY_TYPE]);
                $this->binnString .= $this->pack($arr[self::KEY_TYPE], $arr[self::KEY_VAL]);
            } else if ($storageType === self::BINN_STORAGE_NOBYTES) {
                $this->binnString .= $this->packType($arr[self::KEY_TYPE]);
            } else if ($storageType === self::BINN_STORAGE_STRING) {
                $this->binnString .= $this->packType(self::BINN_STRING);
                $this->binnString .= $this->packSize($arr[self::KEY_SIZE]);
                $this->binnString .= $this->pack(self::BINN_STRING, $arr[self::KEY_VAL]);
                $this->binnString .= $this->pack(self::BINN_NULL);
            } else if ($storageType === self::BINN_STORAGE_CONTAINER) {
                $this->binnString .= $arr[self::KEY_VAL]->getBinnVal();
            }
        }

        return $this->binnString;
    }

    /**
     * Check is valid array to serialize
     *
     * @param $array
     * @return bool
     */
    public static function validArray($array)
    {
        $array = (array)$array;
        if (!self::isArrayAssoc($array)) {
            return false;
        }

        if (self::isArrayObject($array)) {
            return false;
        }

        return true;
    }

    /**
     * @param array $array
     * @return string
     */
    public function serialize($array = [])
    {
        if (empty($array)) {
            return $this->getBinnVal();
        }

        $this->binnFree();

        if (! $this->isArrayAssoc($array)) {
            throw new InvalidArrayException('Array should be associative');
        }

        foreach ($array as $key => $item) {
            $type = $this->detectType($item);
            $storageType = $this->storageType($type);

            if ($storageType === self::BINN_STORAGE_CONTAINER) {
                foreach ($this->containersClasses as $contanerType => $containersClass)
                {
                    if ($containersClass::validArray($item)) {
                        $container = new $containersClass();
                        $container->serialize($item);
                        $item = $container;
                        break;
                    }
                }
            }

            $this->_addVal($key, $type, $item);
        }

        return $this->getBinnVal();
    }

    /**
     * @param string $binnString
     * @return array
     */
    public function unserialize($binnString = '')
    {
        if (empty($binnString)) {
            return $this->getBinnArr();
        }

        $this->binnFree();

        $this->binnOpen($binnString);
        return $this->getBinnArr();
    }
}