Knik\Binn\BinnObject::_binnLoad()

Complexity

Conditions	16
Paths	44

Size

Total Lines	97
Code Lines	64

Duplication

Lines	0
Ratio	0 %

Importance

Changes

0

<?php
    private function _binnLoad($binnString)
    {
        $pos = 1; // Position
        $sizeBytes = $this->unpack(self::BINN_UINT8, $binnString[$pos]);

        // Size
        if ($sizeBytes & 1 << 7) {
            $sizeBytes = $this->unpack(self::BINN_UINT32, substr($binnString, $pos, 4));
            $this->size = ($sizeBytes &~ (1 << 31)); // Cut bit
            $pos += 4;
        } else {
            $this->size = $sizeBytes;

It seems like $sizeBytes can also be of type boolean. However, the property $size is declared as type integer. Maybe add an additional type check?

            $pos += 1;
        }

        unset($sizeBytes);

        $countBytes = $this->unpack(self::BINN_UINT8, $binnString[$pos]);

        // Size
        if ($countBytes & 1 << 7) {
            $countBytes = $this->unpack(self::BINN_UINT32, substr($binnString, $pos, 4));
            $this->count = ($countBytes &~ (1 << 31)); // Cut bit
            $pos += 4;
        } else {
            $this->count = $countBytes;

It seems like $countBytes can also be of type boolean. However, the property $count is declared as type integer. Maybe add an additional type check?

            $pos += 1;
        }

        unset($countBytes);

        // Data
        $stopWhile = false;
        while ($pos < $this->size && !$stopWhile) {
            // Key size
            $varKeySize = $this->unpack(self::BINN_UINT8, substr($binnString, $pos, 1));
            $pos += 1;

            $varKey = $this->unpack(self::BINN_STRING, substr($binnString, $pos, $varKeySize));

It seems like $varKeySize can also be of type boolean; however, parameter $length of substr() does only seem to accept integer, maybe add an additional type check?

            $pos += $varKeySize;

            $varType = $this->unpack(self::BINN_UINT8, $binnString[$pos]);
            $varStorageType = $this->storageType($varType);
            $pos += 1;

            if ($varStorageType === self::BINN_STORAGE_QWORD
                || $varStorageType === self::BINN_STORAGE_DWORD
                || $varStorageType === self::BINN_STORAGE_WORD
                || $varStorageType === self::BINN_STORAGE_BYTE
                || $varStorageType === self::BINN_STORAGE_NOBYTES
            ) {
                $varSize = $this->getTypeSize($varType);
                $val = $this->unpack($varType, substr($binnString, $pos, $varSize['data']));
                $this->_addVal($varKey, $varType, $val);

It seems like $varType can also be of type boolean; however, parameter $type of Knik\Binn\BinnObject::_addVal() does only seem to accept integer, maybe add an additional type check?

It seems like $varKey can also be of type boolean; however, parameter $key of Knik\Binn\BinnObject::_addVal() does only seem to accept integer, maybe add an additional type check?

                $pos += $varSize['data'];

            } else if ($varStorageType === self::BINN_STRING ) {
                $stringSize = $this->unpack(self::BINN_UINT8, $binnString[$pos]);

                // Size
                if ($stringSize & 1 << 7) {
                    $stringSize = $this->unpack(self::BINN_UINT32, substr($binnString, $pos, 4));
                    $stringSize = ($stringSize &~ (1 << 31)); // Cut bit
                    $pos += 4;
                } else {
                    $pos += 1;
                }

                $this->_addVal($varKey,self::BINN_STRING, $this->unpack(
                    self::BINN_STRING,
                    substr($binnString, $pos, $stringSize)
                ));

                $pos += $stringSize;
                $pos += 1; // Null byte
            } else if ($varStorageType === self::BINN_STORAGE_CONTAINER) {
                $list_size = $this->unpack(self::BINN_UINT8, $binnString[$pos]);;

                // Size
                if ($list_size & 1 << 7) {
                    $list_size = $this->unpack(self::BINN_UINT32, substr($binnString, $pos, 4));
                    $list_size = ($list_size &~ (1 << 31)); // Cut bit
                }

                $substring = substr($binnString, $pos-1, $list_size);

                foreach ($this->containersClasses as $containerType => $containersClass) {
                    if ($containerType === $varType) {
                        $container = new $containersClass($substring);
                        $this->_addVal($varKey, $varType, $container);
                        break;
                    }
                }

                $pos += ($list_size-1);
            } else {
                $stopWhile = true;
            }
}