DCP\Mapper\Collections\Maps\CollectionMap

Complexity

Total Complexity

10

Size/Duplication

Total Lines	50
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	2

Importance

Changes	3
Bugs	0	Features	0

4 Methods

Rating	Name	Duplication	Size	Complexity
A	get()	0	8	2
A	add()	0	14	2
A	getWithCallback()	0	14	3
A	addWithTypeCheck()	0	8	3

<?php

namespace DCP\Mapper\Collections\Maps;

use DCP\Mapper\Collection;
use DCP\Mapper\Exception\InvalidArgumentException;
use DCP\Mapper\Exception\OutOfBoundsException;

abstract class CollectionMap extends Map implements CollectionMapInterface
{
    public function get($key, $default = true, $callback = null)
    {
        if ($default) {
            return $this->getWithCallback($key, $callback);
        }

        return $this->getWithCallback($key, null);
    }

    public function add($key, $value, callable $defaultCollectionCallback = null)
    {
        $collection = self::get($key, false);

        if (!$collection) {
            /** @var Collection $collection */
            $collection = call_user_func($defaultCollectionCallback);
            $this->set($key, $collection);
        }

        $collection->add($value);

        return $this;
    }

    protected function getWithCallback($key, callable $defaultCallback = null)
    {
        $collection = null;

        try {
            $collection = parent::get($key);

It seems like you call parent on a different method (get() instead of getWithCallback()). Are you sure this is correct? If so, you might want to change this to $this->get().

        } catch (OutOfBoundsException $exception) {
            if ($defaultCallback) {
                $collection = call_user_func($defaultCallback);
            }
        }

        return $collection;
    }

    protected function addWithTypeCheck($key, $value, $type, callable $callback = null)
    {
        if (!(is_object($value) && is_subclass_of($value, $type))) {

Due to PHP Bug #53727, is_subclass_of might return inconsistent results on some PHP versions if $type can be an interface. If so, you could instead use ReflectionClass::implementsInterface.

            throw new InvalidArgumentException(sprintf('$value must be an instance of %s', $type));
        }

        return self::add($key, $value, $callback);
    }
}