AsksForArticles::askForArticles() - Code Metrics - eric98/articles - Measure and Improve Code Quality continuously with Scrutinizer

AsksForArticles::askForArticles() A
last analyzed 2018-02-27 17:38 UTC

↳ Parent: AsksForArticles

Complexity

Conditions	1
Paths	1

Size

Total Lines	8
Code Lines	5

Duplication

Lines	8
Ratio	100 %

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
cc	1
eloc	5
nc	1
nop	0
dl	8
loc	8
rs	9.4285
c	1
b	0
f	0

<?php

namespace Ergare17\Articles\Console\Commands\Traits;

use Ergare17\Articles\Models\Article;

/**
 * Trait AsksForArticles.
 */
trait AsksForArticles

{
    /**
     * Ask for articles.
     *
     * @return mixed
     */
    protected function askForArticles()
    {
        $articles = Article::all();
        $article_titles = $articles->pluck('title')->toArray();
        $article_title = $this->choice('Article id?', $article_titles);
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}

        return $articles->where('title', $article_title)->first()->id;
    }
}


1		<?php
2
3		namespace Ergare17\Articles\Console\Commands\Traits;
4
5		use Ergare17\Articles\Models\Article;
6
7		/**
8		* Trait AsksForArticles.
9		*/
10	View Code Duplication	trait AsksForArticles
		0 ignored issues – show Duplication introduced 2018-02-13 16:00 UTC by Report Bug Copy Issue Report This class seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
11		{
12		/**
13		* Ask for articles.
14		*
15		* @return mixed
16		*/
17		protected function askForArticles()
18		{
19		$articles = Article::all();
20		$article_titles = $articles->pluck('title')->toArray();
21		$article_title = $this->choice('Article id?', $article_titles);
		0 ignored issues – show Bug introduced 2018-02-13 16:00 UTC by Report Bug Copy Issue Report It seems like `choice()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
22
23		return $articles->where('title', $article_title)->first()->id;
24		}
25		}
26

eric98 / articles

AsksForArticles::askForArticles() A last analyzed 2018-02-27 17:38 UTC

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like

AsksForArticles::askForArticles() A
last analyzed 2018-02-27 17:38 UTC