ListArticlesCommand::handle() - Code Metrics - eric98/articles - Measure and Improve Code Quality continuously with Scrutinizer

ListArticlesCommand::handle() B
last analyzed 2018-02-27 17:38 UTC

↳ Parent: ListArticlesCommand

Complexity

Conditions	4
Paths	7

Size

Total Lines	22
Code Lines	16

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
cc	4
eloc	16
nc	7
nop	0
dl	0
loc	22
rs	8.9197
c	1
b	0
f	0

<?php

namespace Ergare17\Articles\Console\Commands;

use App\User;
use Ergare17\Articles\Models\Article;
use http\Exception;
use Illuminate\Console\Command;

class ListArticlesCommand extends Command
{
    /**
     * The name and signature of the console command.
     *
     * @var string
     */
    protected $signature = 'article:list';

    /**
     * The console command description.
     *
     * @var string
     */
    protected $description = 'List articles';

    /**
     * Create a new command instance.
     *
     * @return void

     */
    public function __construct()
    {
        parent::__construct();
    }

    /**
     * Execute the console command.
     *
     * @return mixed
     */
    public function handle()
    {
        try {
            $articles = Article::all();

            $headers = ['id', 'Title','Description', 'Read', 'User id', 'User Name'];
            $fields = [];
            foreach ($articles as $article) {
                $fields[] = [
                    'id:'               => $article->id,
                    'Title:'             => $article->title,
                    'Description:' => $article->description,
                    'Read:'        => $article->read ? 'Yes' : 'No',
                    'User id:'          => $article->user_id,
                    'User name:'        => User::findOrFail($article->user_id)->name,
                ];
            }
        } catch (Exception $e) {

            $this->error('Error');
        }
        $this->table($headers, $fields);
function myFunction($a) {
    switch ($a) {
        case 'foo':
            $x = 1;
            break;

        case 'bar':
            $x = 2;
            break;
    }

    // $x is potentially undefined here.
    echo $x;
}
    }
}


ListArticlesCommand::handle() B
last analyzed 2018-02-27 17:38 UTC

Complexity

Size

Duplication

Importance

Available Fixes

Available Fixes

1			<?php
2
3			namespace Ergare17\Articles\Console\Commands;
4
5			use App\User;
6			use Ergare17\Articles\Models\Article;
7			use http\Exception;
8			use Illuminate\Console\Command;
9
10			class ListArticlesCommand extends Command
11			{
12			/**
13			* The name and signature of the console command.
14			*
15			* @var string
16			*/
17			protected $signature = 'article:list';
18
19			/**
20			* The console command description.
21			*
22			* @var string
23			*/
24			protected $description = 'List articles';
25
26			/**
27			* Create a new command instance.
28			*
29			* @return void
			0 ignored issues – show Comprehensibility Best Practice introduced 2018-02-13 16:00 UTC by Report Bug Copy Issue Report Adding a `@return` annotation to constructors is generally not recommended as a constructor does not have a meaningful return value. Adding a `@return` annotation to a constructor is not recommended, since a constructor does not have a meaningful return value. Please refer to the PHP core documentation on constructors. Loading history...
30			*/
31			public function __construct()
32			{
33			parent::__construct();
34			}
35
36			/**
37			* Execute the console command.
38			*
39			* @return mixed
40			*/
41			public function handle()
42			{
43			try {
44			$articles = Article::all();
45
46			$headers = ['id', 'Title','Description', 'Read', 'User id', 'User Name'];
47			$fields = [];
48			foreach ($articles as $article) {
49			$fields[] = [
50			'id:' => $article->id,
51			'Title:' => $article->title,
52			'Description:' => $article->description,
53			'Read:' => $article->read ? 'Yes' : 'No',
54			'User id:' => $article->user_id,
55			'User name:' => User::findOrFail($article->user_id)->name,
56			];
57			}
58			} catch (Exception $e) {
			0 ignored issues – show Bug introduced 2018-02-13 16:00 UTC by Report Bug Copy Issue Report The class `http\Exception` does not exist. Did you forget a USE statement, or did you not list all dependencies? Scrutinizer analyzes your `composer.json`/`composer.lock` file if available to determine the classes, and functions that are defined by your dependencies. It seems like the listed class was neither found in your dependencies, nor was it found in the analyzed files in your repository. If you are using some other form of dependency management, you might want to disable this analysis. Loading history...
59			$this->error('Error');
60			}
61			$this->table($headers, $fields);
			0 ignored issues – show Bug introduced 2018-02-13 16:00 UTC by Report Bug Copy Issue Report The variable `$headers` does not seem to be defined for all execution paths leading up to this point. If you define a variable conditionally, it can happen that it is not defined for all execution paths. Let’s take a look at an example: function myFunction($a) { switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; } // $x is potentially undefined here. echo $x; } In the above example, the variable `$x` is defined if you pass “foo” or “bar” as argument for `$a`. However, since the `switch` statement has no default case statement, if you pass any other value, the variable `$x` would be undefined. Available Fixes Check for existence of the variable explicitly: function myFunction($a) { switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; } if (isset($x)) { // Make sure it's always set. echo $x; } } Define a default value for the variable: function myFunction($a) { $x = ''; // Set a default which gets overridden for certain paths. switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; } echo $x; } Add a value for the missing path: function myFunction($a) { switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; // We add support for the missing case. default: $x = ''; break; } echo $x; } Loading history... Bug introduced 2018-02-13 16:00 UTC by Report Bug Copy Issue Report The variable `$fields` does not seem to be defined for all execution paths leading up to this point. If you define a variable conditionally, it can happen that it is not defined for all execution paths. Let’s take a look at an example: function myFunction($a) { switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; } // $x is potentially undefined here. echo $x; } In the above example, the variable `$x` is defined if you pass “foo” or “bar” as argument for `$a`. However, since the `switch` statement has no default case statement, if you pass any other value, the variable `$x` would be undefined. Available Fixes Check for existence of the variable explicitly: function myFunction($a) { switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; } if (isset($x)) { // Make sure it's always set. echo $x; } } Define a default value for the variable: function myFunction($a) { $x = ''; // Set a default which gets overridden for certain paths. switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; } echo $x; } Add a value for the missing path: function myFunction($a) { switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; // We add support for the missing case. default: $x = ''; break; } echo $x; } Loading history...
62			}
63			}
64

eric98 / articles

ListArticlesCommand::handle() B last analyzed 2018-02-27 17:38 UTC

Complexity

Size

Duplication

Importance

Available Fixes

Available Fixes

Duplication Side-by-Side

Filter issues like

ListArticlesCommand::handle() B
last analyzed 2018-02-27 17:38 UTC