Ergare17\Articles\Http\Controllers\ArticleController

Complexity

Total Complexity

8

Size/Duplication

Total Lines	122
Duplicated Lines	0 %

Coupling/Cohesion

Components	0
Dependencies	2

Importance

Changes	6
Bugs	1	Features	0

8 Methods

Rating	Name	Duplication	Size	Complexity
A	index()	0	7	1
A	create()	0	6	1
A	store()	0	12	1
A	show()	0	5	1
A	show1()	0	16	1
A	edit()	0	6	1
A	update()	0	7	1
A	destroy()	0	6	1

<?php

namespace Ergare17\Articles\Http\Controllers;

use App\User;
use Ergare17\Articles\Http\Requests\DestroyArticle;
use Ergare17\Articles\Http\Requests\ShowArticle;
use Ergare17\Articles\Http\Requests\StoreArticle;
use Ergare17\Articles\Http\Requests\UpdateArticle;
use Ergare17\Articles\Models\Article;
use Illuminate\Http\Request;
use Illuminate\Support\Facades\App;
use Redirect;
use Session;

class ArticleController extends Controller
{
    /**
     * Display a listing of the resource.
     *
     * @return \Illuminate\Http\Response
     */
    public function index()
    {
        // CRUD -> Retrieve --> List
        // BREAD -> Browse Read Edit Add Delete
        $articles = Article::all();
        return view('articles::list_article', ['articles' => $articles]);
    }

    /**
     * Show the form for creating a new resource.
     *
     * @return \Illuminate\Http\Response
     */
    public function create()
    {
        $users = User::all();

        return view('articles::create_article', ['users' => $users]);
    }

    /**
     * Store a newly created resource in storage.
     *
     * @param  \Illuminate\Http\Request  $request
     * @return \Illuminate\Http\Response
     */
    public function store(StoreArticle $request)
    {
        Article::create([

The method create() does not exist on Ergare17\Articles\Models\Article. Did you maybe mean created()?

            'title'             => $request->title,
            'description'      => $request->description,
            'user_id'          => $request->user_id,
            'read'        => false,
        ]);

        Session::flash('status', 'Created ok!');
        return Redirect::to('/articles_php/create');
    }

    /**
     * Display the specified resource.
     *
     * @param  \App\Article  $article
     * @return \Illuminate\Http\Response
     */
    public function show(ShowArticle $request, Article $article)
    {
//        return view('show_article',compact('article'));

70% of this comment could be valid code. Did you maybe forget this after debugging?

        return view('articles::show_article', compact('article'));
    }

    /**
     * Display the specified resource.
     *
     * @param  \App\Article  $article

There is no parameter named $article. Was it maybe removed?

     * @return \Illuminate\Http\Response
     */
    public function show1($id)
    {
        dump($id);
        dump($article = Article::find($id));

//        if ($article == null)abort(404);

53% of this comment could be valid code. Did you maybe forget this after debugging?

//        try{
//            $article = Article::findOrFail($id);
//        } catch(\Exception $e){
//            abort(404);
//        }
        $article = Article::findOrFail($id);

        dump($article->title);
//        return $article;
    }

    /**
     * Show the form for editing the specified resource.
     *
     * @param  \App\Article  $article
     * @return \Illuminate\Http\Response
     */
    public function edit(Article $article)
    {
        $users = User::all();

        return view('articles::edit_article', ['article' => $article,'users' => $users]);
    }

    /**
     * Update the specified resource in storage.
     *
     * @param  \Illuminate\Http\Request  $request
     * @param  \App\Article  $article
     * @return \Illuminate\Http\Response
     */
    public function update(UpdateArticle $request, Article $article)
    {
        $article->update($request->only(['title','description','user_id']));

        Session::flash('status', 'Edited ok!');
        return Redirect::to('/articles_php/edit/'.$article->id);

The property id does not exist on object<Ergare17\Articles\Models\Article>. Since you implemented __get, maybe consider adding a @property annotation.

    }

    /**
     * Remove the specified resource from storage.
     *
     * @param  \App\Article  $article
     * @return \Illuminate\Http\Response
     */
    public function destroy(DestroyArticle $request, Article $article)
    {
        $article->delete();
        Session::flash('status', 'Article was deleted successful!');
        return Redirect::to('/articles_php');
    }
}