ApiReadArticleController - Code Metrics - eric98/articles - Measure and Improve Code Quality continuously with Scrutinizer

ApiReadArticleController A
last analyzed 2018-02-27 17:38 UTC

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	18
Duplicated Lines	0 %

Coupling/Cohesion

Components	0
Dependencies	2

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
dl	0
loc	18
rs	10
c	1
b	0
f	0
wmc	2
lcom	0
cbo	2

2 Methods

Rating	Name	Duplication	Size	Complexity
A	store()	0	7	1
A	destroy()	0	7	1

<?php

namespace Ergare17\Articles\Http\Controllers;

use Ergare17\Articles\Http\Requests\DestroyReadArticle;
use Ergare17\Articles\Http\Requests\StoreReadArticle;
use Ergare17\Articles\Models\Article;

class ApiReadArticleController extends Controller
{
    public function store(StoreReadArticle $request, Article $article)
    {
        $article->read = true;
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
        $article->save();

        return $article;
    }

    public function destroy(DestroyReadArticle $request, Article $article)
    {
        $article->read = false;
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
        $article->save();

        return $article;
    }
}


1			<?php
2
3			namespace Ergare17\Articles\Http\Controllers;
4
5			use Ergare17\Articles\Http\Requests\DestroyReadArticle;
6			use Ergare17\Articles\Http\Requests\StoreReadArticle;
7			use Ergare17\Articles\Models\Article;
8
9			class ApiReadArticleController extends Controller
10			{
11			public function store(StoreReadArticle $request, Article $article)
12			{
13			$article->read = true;
			0 ignored issues – show Documentation introduced 2018-02-13 16:00 UTC by Report Bug Copy Issue Report The property `read` does not exist on `object<Ergare17\Articles\Models\Article>`. Since you implemented `__set`, maybe consider adding a @property annotation. Since your code implements the magic setter `_set`, this function will be called for any write access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /** * @property int $x * @property int $y * @property string $text */ class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } Since the property has write access only, you can use the @property-write annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history...
14			$article->save();
15
16			return $article;
17			}
18
19			public function destroy(DestroyReadArticle $request, Article $article)
20			{
21			$article->read = false;
			0 ignored issues – show Documentation introduced 2018-02-13 16:00 UTC by Report Bug Copy Issue Report The property `read` does not exist on `object<Ergare17\Articles\Models\Article>`. Since you implemented `__set`, maybe consider adding a @property annotation. Since your code implements the magic setter `_set`, this function will be called for any write access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /** * @property int $x * @property int $y * @property string $text */ class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } Since the property has write access only, you can use the @property-write annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history...
22			$article->save();
23
24			return $article;
25			}
26			}
27

eric98 / articles

ApiReadArticleController A last analyzed 2018-02-27 17:38 UTC

Complexity

Size/Duplication

Coupling/Cohesion

Importance

2 Methods

Duplication Side-by-Side

Filter issues like

ApiReadArticleController A
last analyzed 2018-02-27 17:38 UTC