Completed
Push — master ( 78e6bb...0aee00 )
by Eric
03:35
created

ApiTaskController::index()   A

Complexity

Conditions 1
Paths 1

Size

Total Lines 3
Code Lines 1

Duplication

Lines 0
Ratio 0 %

Importance

Changes 1
Bugs 0 Features 0
Metric Value
cc 1
eloc 1
c 1
b 0
f 0
nc 1
nop 1
dl 0
loc 3
rs 10
1
<?php
2
3
namespace App\Http\Controllers;
4
5
use App\Http\Requests\CompleteTask;
6
use App\Http\Requests\DestroyTask;
7
use App\Http\Requests\ListTask;
8
use App\Http\Requests\ShowTask;
9
use App\Http\Requests\StoreTask;
10
use App\Http\Requests\UpdateTask;
11
use App\Task;
12
13
class ApiTaskController extends Controller
14
{
15
    public function index(ListTask $request)
0 ignored issues
show
Unused Code introduced by
The parameter $request is not used and could be removed. ( Ignorable by Annotation )

If this is a false-positive, you can also ignore this issue in your code via the ignore-unused  annotation

15
    public function index(/** @scrutinizer ignore-unused */ ListTask $request)

This check looks for parameters that have been defined for a function or method, but which are not used in the method body.

Loading history...
16
    {
17
        return Task::all();
18
    }
19
20
    // Injeccció de depèndències
21
    public function store(StoreTask $request)
22
    {
23
        $request->validate([
0 ignored issues
show
Unused Code introduced by
The call to Illuminate\Foundation\Http\FormRequest::validate() has too many arguments starting with array('name' => 'required'). ( Ignorable by Annotation )

If this is a false-positive, you can also ignore this issue in your code via the ignore-call  annotation

23
        $request->/** @scrutinizer ignore-call */ 
24
                  validate([

This check compares calls to functions or methods with their respective definitions. If the call has more arguments than are defined, it raises an issue.

If a function is defined several times with a different number of parameters, the check may pick up the wrong definition and report false positives. One codebase where this has been known to happen is Wordpress. Please note the @ignore annotation hint above.

Loading history...
24
            'name' => 'required',
25
        ]);
26
27
        $task = Task::create([
28
            'name'      => $request->name,
29
            'user_id'   => $request->user_id,
30
            'completed' => false,
31
        ]);
32
33
        return $task;
34
    }
35
36
    public function destroy(DestroyTask $request, Task $task)
0 ignored issues
show
Unused Code introduced by
The parameter $request is not used and could be removed. ( Ignorable by Annotation )

If this is a false-positive, you can also ignore this issue in your code via the ignore-unused  annotation

36
    public function destroy(/** @scrutinizer ignore-unused */ DestroyTask $request, Task $task)

This check looks for parameters that have been defined for a function or method, but which are not used in the method body.

Loading history...
37
    {
38
        $task->delete();
39
40
        return $task;
41
    }
42
43
    public function update(UpdateTask $request, Task $task)
44
    {
45
        $request->validate([
0 ignored issues
show
Unused Code introduced by
The call to Illuminate\Foundation\Http\FormRequest::validate() has too many arguments starting with array('name' => 'required'). ( Ignorable by Annotation )

If this is a false-positive, you can also ignore this issue in your code via the ignore-call  annotation

45
        $request->/** @scrutinizer ignore-call */ 
46
                  validate([

This check compares calls to functions or methods with their respective definitions. If the call has more arguments than are defined, it raises an issue.

If a function is defined several times with a different number of parameters, the check may pick up the wrong definition and report false positives. One codebase where this has been known to happen is Wordpress. Please note the @ignore annotation hint above.

Loading history...
46
            'name' => 'required',
47
        ]);
48
        $task->name = $request->name;
49
        $task->save();
50
51
        return $task;
52
    }
53
54
    public function complete(CompleteTask $request, Task $task)
0 ignored issues
show
Unused Code introduced by
The parameter $request is not used and could be removed. ( Ignorable by Annotation )

If this is a false-positive, you can also ignore this issue in your code via the ignore-unused  annotation

54
    public function complete(/** @scrutinizer ignore-unused */ CompleteTask $request, Task $task)

This check looks for parameters that have been defined for a function or method, but which are not used in the method body.

Loading history...
55
    {
56
        $task->update(['completed' => $task->completed ? false : true]);
57
58
        return $task;
59
    }
60
61
    public function show(ShowTask $request, Task $task)
0 ignored issues
show
Unused Code introduced by
The parameter $request is not used and could be removed. ( Ignorable by Annotation )

If this is a false-positive, you can also ignore this issue in your code via the ignore-unused  annotation

61
    public function show(/** @scrutinizer ignore-unused */ ShowTask $request, Task $task)

This check looks for parameters that have been defined for a function or method, but which are not used in the method body.

Loading history...
62
    {
63
        return $task;
64
    }
65
}
66