Route - Code Metrics - Inspection of "Rework of routing skill" - eric-chau/jarvis - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#28)

by Eric

created 2016-01-12 22:43 UTC

Route A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	73
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	1

Metric	Value
wmc	11
lcom	1
cbo	1
dl	0
loc	73
rs	10

11 Methods

Rating	Name	Size	Complexity
A	__construct()	5	1
A	name()	4	1
A	method()	4	1
A	setMethod()	6	1
A	pattern()	4	1
A	setPattern()	6	1
A	handler()	4	1
A	setHandler()	6	1
A	scope()	4	1
A	setScope()	6	1
A	end()	4	1

<?php


declare(strict_types = 1);

namespace Jarvis\Skill\Routing;

use Jarvis\Jarvis;

/**
 * @author Eric Chau <[email protected]>
 */
class Route
{
    private $name;
    private $method = 'get';
    private $pattern = '/';
    private $handler;
    private $scope = Jarvis::DEFAULT_SCOPE;
    private $router;

    public function __construct(string $name = null, Router $router)
    {
        $this->name = $name;
        $this->router = $router;
    }

    public function name()
    {
        return $this->name;
    }

    public function method() : string
    {
        return $this->method;
    }

    public function setMethod(string $method) : Route
    {
        $this->method = strtolower($method);

        return $this;
    }

    public function pattern() : string
    {
        return $this->pattern;
    }

    public function setPattern(string $pattern) : Route
    {
        $this->pattern = $pattern;

        return $this;
    }

    public function handler()
    {
        return $this->handler;
    }

    public function setHandler($handler) : Route
    {
        $this->handler = $handler;

        return $this;
    }

    public function scope() : string
    {
        return $this->scope;
    }

    public function setScope(string $scope) : Route
    {
        $this->scope = $scope;

        return $this;
    }

    public function end()
    {
        return $this->router->addRoute($this);
    }
}


1			<?php
			1 ignored issue – show Coding Style Compatibility introduced 2016-01-11 00:57 UTC by Report Bug Copy Issue Report For compatibility and reusability of your code, PSR1 recommends that a file should introduce either new symbols (like classes, functions, etc.) or have side-effects (like outputting something, or including other files), but not both at the same time. The first symbol is defined on line 12 and the first side effect is on line 3. The PSR-1: Basic Coding Standard recommends that a file should either introduce new symbols, that is classes, functions, constants or similar, or have side effects. Side effects are anything that executes logic, like for example printing output, changing ini settings or writing to a file. The idea behind this recommendation is that merely auto-loading a class should not change the state of an application. It also promotes a cleaner style of programming and makes your code less prone to errors, because the logic is not spread out all over the place. To learn more about the PSR-1, please see the PHP-FIG site on the PSR-1. Loading history...
2
3			declare(strict_types = 1);
4
5			namespace Jarvis\Skill\Routing;
6
7			use Jarvis\Jarvis;
8
9			/**
10			* @author Eric Chau <[email protected]>
11			*/
12			class Route
13			{
14			private $name;
15			private $method = 'get';
16			private $pattern = '/';
17			private $handler;
18			private $scope = Jarvis::DEFAULT_SCOPE;
19			private $router;
20
21			public function __construct(string $name = null, Router $router)
22			{
23			$this->name = $name;
24			$this->router = $router;
25			}
26
27			public function name()
28			{
29			return $this->name;
30			}
31
32			public function method() : string
33			{
34			return $this->method;
35			}
36
37			public function setMethod(string $method) : Route
38			{
39			$this->method = strtolower($method);
40
41			return $this;
42			}
43
44			public function pattern() : string
45			{
46			return $this->pattern;
47			}
48
49			public function setPattern(string $pattern) : Route
50			{
51			$this->pattern = $pattern;
52
53			return $this;
54			}
55
56			public function handler()
57			{
58			return $this->handler;
59			}
60
61			public function setHandler($handler) : Route
62			{
63			$this->handler = $handler;
64
65			return $this;
66			}
67
68			public function scope() : string
69			{
70			return $this->scope;
71			}
72
73			public function setScope(string $scope) : Route
74			{
75			$this->scope = $scope;
76
77			return $this;
78			}
79
80			public function end()
81			{
82			return $this->router->addRoute($this);
83			}
84			}
85

eric-chau / jarvis

Pull Request — master (#28)

Route A

Complexity

Size/Duplication

Coupling/Cohesion

11 Methods

Duplication Side-by-Side

Filter issues like