AnalyzeEvent::__construct() - Code Metrics - Inspection of "changed AnalyzeEvent to extend ResponseEvent to av..." - eric-chau/jarvis - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#39)

by Eric

created 2016-05-22 10:31 UTC

AnalyzeEvent::__construct() A

↳ Parent: AnalyzeEvent

Complexity

Conditions	1
Paths	1

Size

Total Lines	4
Code Lines	2

Duplication

Lines	0
Ratio	0 %

Importance

Changes	2
Bugs	0	Features	0

Metric	Value
c	2
b	0
f	0
dl	0
loc	4
rs	10
cc	1
eloc	2
nc	1
nop	1

<?php

declare(strict_types = 1);

namespace Jarvis\Skill\EventBroadcaster;

use Symfony\Component\HttpFoundation\{Request, Response};

/**
 * @author Eric Chau <[email protected]>
 */
class AnalyzeEvent extends ResponseEvent
{
    /**
     * Creates an instance of AnalyzeEvent.
     *
     * @param Request $request
     */
    public function __construct(Request $request)

    {
        $this->request = $request;
    }

    /**
     * @codeCoverageIgnore
     *
     * @param  Response $response
     * @return self
     */
    public function setResponse(Response $response) : AnalyzeEvent
    {
        $this->response = $response;

        return $this;
    }
}


1			<?php
2
3			declare(strict_types = 1);
4
5			namespace Jarvis\Skill\EventBroadcaster;
6
7			use Symfony\Component\HttpFoundation\{Request, Response};
8
9			/**
10			* @author Eric Chau <[email protected]>
11			*/
12			class AnalyzeEvent extends ResponseEvent
13			{
14			/**
15			* Creates an instance of AnalyzeEvent.
16			*
17			* @param Request $request
18			*/
19			public function __construct(Request $request)
			0 ignored issues – show Bug introduced 2015-12-18 22:38 UTC by Report Bug Copy Issue Report You have injected the Request via parameter `$request`. This is generally not recommended as there might be multiple instances during a request cycle (f.e. when using sub-requests). Instead, it is recommended to inject the RequestStack and retrieve the current request each time you need it via `getCurrentRequest()`. Loading history...
20			{
21			$this->request = $request;
22			}
23
24			/**
25			* @codeCoverageIgnore
26			*
27			* @param Response $response
28			* @return self
29			*/
30			public function setResponse(Response $response) : AnalyzeEvent
31			{
32			$this->response = $response;
33
34			return $this;
35			}
36			}
37

eric-chau / jarvis

Pull Request — master (#39)

AnalyzeEvent::__construct() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like