Jarvis\Skill\EventBroadcaster\ResponseEvent

Complexity

Total Complexity

4

Size/Duplication

Total Lines	35
Duplicated Lines	0 %

Coupling/Cohesion

Components	0
Dependencies	2

Importance

Changes	4
Bugs	0	Features	1

3 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	9	2
A	request()	0	4	1
A	response()	0	4	1

<?php

declare(strict_types = 1);

namespace Jarvis\Skill\EventBroadcaster;

use Symfony\Component\HttpFoundation\Request;
use Symfony\Component\HttpFoundation\Response;

/**
 * @author Eric Chau <eriic.chau@gmail.com>
 */
class ResponseEvent extends SimpleEvent
{
    protected $request;
    protected $response;

    public function __construct(Request $request, $response)

You have injected the Request via parameter $request. This is generally not recommended as there might be multiple instances during a request cycle (f.e. when using sub-requests). Instead, it is recommended to inject the RequestStack and retrieve the current request each time you need it via getCurrentRequest().

    {
        $this->request = $request;
        if (!($response instanceof Response)) {
            $response = new Response($response);
        }

        $this->response = $response;
    }

    /**
     * @codeCoverageIgnore
     *
     * @return Request
     */
    public function request(): Request
    {
        return $this->request;
    }

    /**
     * @codeCoverageIgnore
     *
     * @return Response
     */
    public function response(): Response
    {
        return $this->response;
    }
}