Erdemkeren\TemporaryAccess\Http\Middleware\OtpAccess

Complexity

Total Complexity

9

Size/Duplication

Total Lines	95
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	4

Test Coverage

Coverage

0%

Importance

Changes

0

5 Methods

Rating	Name	Duplication	Size	Complexity
A	handle()	0	31	5
A	redirectToOtpPage()	0	9	1
A	getGuard()	0	4	1
A	getAuthUser()	0	4	1
A	sendNewOtpToUser()	0	6	1

<?php

/*
 * @copyright 2018 Hilmi Erdem KEREN
 * @license MIT
 */

namespace Erdemkeren\TemporaryAccess\Http\Middleware;

use Closure;
use Illuminate\Contracts\Auth\Guard;
use Erdemkeren\TemporaryAccess\Token;
use Illuminate\Http\RedirectResponse;
use Illuminate\Contracts\Auth\Authenticatable;
use Erdemkeren\TemporaryAccess\TemporaryAccessFacade as TemporaryAccess;

class OtpAccess
{
    /**
     * Handle an incoming request.
     *
     * @param \Illuminate\Http\Request $request
     * @param \Closure                 $next
     * @param null|string              $guard
     *
     * @return mixed
     */
    public function handle($request, Closure $next, $guard = null)
    {
        if (! $user = $this->getAuthUser($guard)) {
            throw new \LogicException(
                'The otp access control middleware requires user authentication via laravel guards.'
            );
        }

        if (! $request->hasCookie('otp_token')) {
            $this->sendNewOtpToUser($request->user());

            return $this->redirectToOtpPage();
        }

        $token = TemporaryAccess::retrieveByCipherText(
            $user->getAuthIdentifier(),
            $request->cookie('otp_token')

It seems like $request->cookie('otp_token') targeting Illuminate\Http\Concerns\InteractsWithInput::cookie() can also be of type array or null; however, Erdemkeren\TemporaryAccess\TemporaryAccessFacade::retrieveByCipherText() does only seem to accept string, maybe add an additional type check?

        );

        if (! $token || $token->expired()) {
            $this->sendNewOtpToUser($request->user());

            return $this->redirectToOtpPage();
        }

        $request->macro('otpToken', function () use ($token): Token {
            return $token;
        });

        return $next($request);
    }

    /**
     * Get the redirect url if check do not pass.
     *
     * @return RedirectResponse
     */
    protected function redirectToOtpPage(): RedirectResponse
    {
        session([
            'otp_requested'    => true,
            'otp_redirect_url' => url()->current(),
        ]);

        return redirect()->route('otp.create');
    }

    /**
     * Get the guard by the given name.
     *
     * @param string $guard
     *
     * @return Guard
     */
    private function getGuard($guard): Guard
    {
        return auth()->guard($guard);
    }

    /**
     * Get the authenticated user from
     * the guard by the given name.
     *
     * @param string $guard
     *
     * @return null|Authenticatable
     */
    private function getAuthUser($guard): ?Authenticatable
    {
        return $this->getGuard($guard)->user();
    }

    /**
     * Create a new otp and notify the user.
     *
     * @param Authenticatable $user
     */
    private function sendNewOtpToUser(Authenticatable $user): void
    {
        $token = TemporaryAccess::create($user, 6);

        $user->notify($token->toNotification());

The method notify() does not seem to exist on object<Illuminate\Contracts\Auth\Authenticatable>.

    }
}