Erdemkeren\Otp\Generators\NumericGenerator

Complexity

Total Complexity

4

Size/Duplication

Total Lines	29
Duplicated Lines	0 %

Importance

Changes

0

2 Methods

Rating	Name	Duplication	Size	Complexity
A	generateRangeForLength()	0	14	2
A	generate()	0	11	2

<?php

/*
 * @copyright 2021 Hilmi Erdem KEREN
 * @license MIT
 */

namespace Erdemkeren\Otp\Generators;

use Erdemkeren\Otp\Contracts\GeneratorContract;
use Throwable;

class NumericGenerator implements GeneratorContract
{
    public function generate(int $length = null): string
    {
        $range = $this->generateRangeForLength($length);

It seems like $length can also be of type null; however, parameter $length of Erdemkeren\Otp\Generators\NumericGenerator::generateRangeForLength() does only seem to accept integer, maybe add an additional type check?

        try {
            $int = random_int($range[0], $range[1]);
        } catch (Throwable) {
            $int = rand($range[0], $range[1]);
        }

        return (string) $int;
    }

    protected function generateRangeForLength(int $length): array
    {
        $min = 1;
        $max = 9;

        while ($length > 1) {
            $min .= 0;
            $max .= 9;

            $length--;
        }

        return [
            $min, $max,
        ];
    }
}