Erdemkeren\Otp\FormatManager

Complexity

Total Complexity

5

Size/Duplication

Total Lines	21
Duplicated Lines	0 %

Importance

Changes	1
Bugs	0	Features	0

3 Methods

Rating	Name	Duplication	Size	Complexity
A	get()	0	8	3
A	register()	0	3	1
A	__construct()	0	2	1

<?php
/*
 * Copyright (c) 2021. Hilmi Erdem Keren
 * license MIT
 */

namespace Erdemkeren\Otp;

use Erdemkeren\Otp\Contracts\FormatContract;
use Erdemkeren\Otp\Contracts\FormatManagerContract;
use Erdemkeren\Otp\Exceptions\UnknownOtpFormat;

class FormatManager implements FormatManagerContract
{
    private static array $formats;

    public function __construct(private string $defaultFormat)
    {
    }

    public function get(string $name): FormatContract
    {
        $name = $name === 'default' ? $this->defaultFormat : $name;
        if (! array_key_exists($name, static::$formats)) {

Since $formats is declared private, accessing it with static will lead to errors in possible sub-classes; you can either use self, or increase the visibility of $formats to at least protected.

            throw UnknownOtpFormat::createForName($name);
        }

        return static::$formats[$name];
    }

    public function register(FormatContract $format): void
    {
        static::$formats[$format->name()] = $format;

Since $formats is declared private, accessing it with static will lead to errors in possible sub-classes; you can either use self, or increase the visibility of $formats to at least protected.

    }
}