ShortMessageCollection::toArray() - Code Metrics - Inspection of "docs: Updates the wrong property type hinting." - erdemkeren/jet-sms-php - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 5c498e...edddde )

by Hilmi Erdem

created 2018-02-17 01:03 UTC

ShortMessageCollection::toArray() A

↳ Parent: ShortMessageCollection

Complexity

Conditions	2
Paths	2

Size

Total Lines	16
Code Lines	9

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	10
CRAP Score	2

Importance

Changes

Metric	Value
dl	0
loc	16
ccs	10
cts	10
cp	1
rs	9.4285
c	0
b	0
f	0
cc	2
eloc	9
nc	2
nop	0
crap	2

<?php

namespace Erdemkeren\JetSms;

/**
 * Class ShortMessageCollection.
 */
class ShortMessageCollection
{
    /**
     * The items of the collection.
     *
     * @var array
     */
    protected $items = [];

    /**
     * Push a new short message to the given collection.
     *
     * @param ShortMessage $shortMessage
     *
     * @return self
     */
    public function push(ShortMessage $shortMessage)
    {
        if ($shortMessage->hasManyReceivers()) {
            throw new \LogicException(
                "Expected one receiver per short message, got many."
            );
        }

        $this->items[] = $shortMessage;

        return $this;
    }

    /**
     * Get the xml representation of the items.
     *
     * @return string
     */
    public function toXml()
    {
        $messages = '';
        /** @var ShortMessage $shortMessage */
        foreach ($this->items as $shortMessage) {
            $messages .= $shortMessage->toMultipleMessagesXml();
        }

        return $messages;
    }

    /**
     * Get the array presentation of the items.
     *
     * @return array
     */
    public function toArray()
    {
        $messages = [];
        $receivers = [];

        /** @var ShortMessage $shortMessage */
        foreach ($this->items as $shortMessage) {
            $messages[] = $shortMessage->body();
            $receivers[] = $shortMessage->receiversString();
        }

        return [
            'Msisdns'        => implode('|', $receivers),
            'Messages'       => implode('|', $messages),
        ];
    }
}


1		<?php
2
3		namespace Erdemkeren\JetSms;
4
5		/**
6		* Class ShortMessageCollection.
7		*/
8		class ShortMessageCollection
9		{
10		/**
11		* The items of the collection.
12		*
13		* @var array
14		*/
15		protected $items = [];
16
17		/**
18		* Push a new short message to the given collection.
19		*
20		* @param ShortMessage $shortMessage
21		*
22		* @return self
23		*/
24	3	public function push(ShortMessage $shortMessage)
25		{
26	3	if ($shortMessage->hasManyReceivers()) {
27	1	throw new \LogicException(
28		"Expected one receiver per short message, got many."
29	1	);
30		}
31
32	3	$this->items[] = $shortMessage;
33
34	3	return $this;
35		}
36
37		/**
38		* Get the xml representation of the items.
39		*
40		* @return string
41		*/
42	1	public function toXml()
43		{
44	1	$messages = '';
45		/** @var ShortMessage $shortMessage */
46	1	foreach ($this->items as $shortMessage) {
47	1	$messages .= $shortMessage->toMultipleMessagesXml();
48	1	}
49
50	1	return $messages;
51		}
52
53		/**
54		* Get the array presentation of the items.
55		*
56		* @return array
57		*/
58	1	public function toArray()
59		{
60	1	$messages = [];
61	1	$receivers = [];
62
63		/** @var ShortMessage $shortMessage */
64	1	foreach ($this->items as $shortMessage) {
65	1	$messages[] = $shortMessage->body();
66	1	$receivers[] = $shortMessage->receiversString();
67	1	}
68
69		return [
70	1	'Msisdns' => implode('\|', $receivers),
71	1	'Messages' => implode('\|', $messages),
72	1	];
73		}
74		}
75

erdemkeren / jet-sms-php

Push — master ( 5c498e...edddde )

ShortMessageCollection::toArray() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like