RecursiveGenerator::generateForProperty() - Code Metrics - Inspection of "recursive objects generating" - er1z/fakemock - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 969ba5...87cf68 )

by Przemysław eRIZ

created 2018-11-15 10:49 UTC

RecursiveGenerator::generateForProperty() A

↳ Parent: RecursiveGenerator

Complexity

Conditions	3
Paths	3

Size

Total Lines	14
Code Lines	7

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
eloc	7
dl	0
loc	14
rs	10
c	0
b	0
f	0
cc	3
nc	3
nop	2

<?php

namespace Er1z\FakeMock\Generator;

use Er1z\FakeMock\FakeMock;
use Er1z\FakeMock\Generator\RecursiveGenerator\ClassMapper;
use Er1z\FakeMock\Generator\RecursiveGenerator\ClassMapperInterface;
use Er1z\FakeMock\Metadata\FieldMetadata;

class RecursiveGenerator implements GeneratorInterface
{
    /**
     * @var ClassMapperInterface
     */
    protected $classMapper;

    public function __construct(?ClassMapperInterface $classMapper = null)
    {
        $this->classMapper = $classMapper ?? new ClassMapper();
    }

    public function generateForProperty(FieldMetadata $field, FakeMock $fakemock)
    {
        if (!$field->configuration->recursive) {
$a = canBeFalseAndNull();

// Instead of
if ( ! $a) { }

// Better use one of the explicit versions:
if ($a !== null) { }
if ($a !== false) { }
if ($a !== null && $a !== false) { }
            return null;
        }

        $value = $this->classMapper->getObjectForField($field);
        if (!$value) {
            return null;
        }

        $value = $fakemock->fill($value);

        return $value;
    }

    public function addClassMapping(string $intefaceOrAbstractFqcn, string $targetFqcn)
    {
        $this->classMapper->addClassMapping($intefaceOrAbstractFqcn, $targetFqcn);
    }
}


1			<?php
2
3			namespace Er1z\FakeMock\Generator;
4
5			use Er1z\FakeMock\FakeMock;
6			use Er1z\FakeMock\Generator\RecursiveGenerator\ClassMapper;
7			use Er1z\FakeMock\Generator\RecursiveGenerator\ClassMapperInterface;
8			use Er1z\FakeMock\Metadata\FieldMetadata;
9
10			class RecursiveGenerator implements GeneratorInterface
11			{
12			/**
13			* @var ClassMapperInterface
14			*/
15			protected $classMapper;
16
17			public function __construct(?ClassMapperInterface $classMapper = null)
18			{
19			$this->classMapper = $classMapper ?? new ClassMapper();
20			}
21
22			public function generateForProperty(FieldMetadata $field, FakeMock $fakemock)
23			{
24			if (!$field->configuration->recursive) {
			0 ignored issues – show Bug Best Practice introduced 2018-11-14 15:03 UTC by Report Bug Copy Issue Report The expression `$field->configuration->recursive` of type `boolean\|null` is loosely compared to `false`; this is ambiguous if the boolean can be false. You might want to explicitly use `!== null` instead. If an expression can have both `false`, and `null` as possible values. It is generally a good practice to always use strict comparison to clearly distinguish between those two values. $a = canBeFalseAndNull(); // Instead of if ( ! $a) { } // Better use one of the explicit versions: if ($a !== null) { } if ($a !== false) { } if ($a !== null && $a !== false) { } Loading history...
25			return null;
26			}
27
28			$value = $this->classMapper->getObjectForField($field);
29			if (!$value) {
30			return null;
31			}
32
33			$value = $fakemock->fill($value);
34
35			return $value;
36			}
37
38			public function addClassMapping(string $intefaceOrAbstractFqcn, string $targetFqcn)
39			{
40			$this->classMapper->addClassMapping($intefaceOrAbstractFqcn, $targetFqcn);
41			}
42			}
43

er1z / fakemock

Push — master ( 969ba5...87cf68 )

RecursiveGenerator::generateForProperty() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like