AssertGenerator::generateForProperty() - Code Metrics - Inspection of "correct asserts group processing" - er1z/fakemock - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( dca783...294a52 )

by Przemysław eRIZ

created 2018-11-19 12:50 UTC

AssertGenerator::generateForProperty() A

↳ Parent: AssertGenerator

Complexity

Conditions	4
Paths	4

Size

Total Lines	21
Code Lines	10

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	11
CRAP Score	4

Importance

Changes

Metric	Value
eloc	10
dl	0
loc	21
ccs	11
cts	11
cp	1
rs	9.9332
c	0
b	0
f	0
cc	4
nc	4
nop	3
crap	4

<?php

namespace Er1z\FakeMock\Generator;

use Er1z\FakeMock\FakeMock;
use Er1z\FakeMock\Metadata\FieldMetadata;
use Symfony\Component\Validator\Constraint;
filter:
    dependency_paths: ["lib/*"]

/**
 * @todo: add interface with FakerableInterface in order to inject main Faker instance or sth
 * Class AssertGenerator
 */
class AssertGenerator extends AttachableGeneratorAbstract
{
    public function generateForProperty(FieldMetadata $field, FakeMock $fakemock, ?string $group = null)
    {
        if (!$field->configuration->useAsserts) {
            return null;
        }

        $allAsserts = $field->annotations->findAllBy(Constraint::class);
        $asserts = $this->filterByGroup($allAsserts, $group);

        if ($asserts) {

            $assert = $asserts[0];

            // https://coderwall.com/p/cpxxxw/php-get-class-name-without-namespace - reflection is the fastest?
            $baseClass = new \ReflectionClass($assert);

            if ($generator = $this->getGenerator($baseClass->getShortName())) {
                return $generator->generateForProperty($field, $assert, $this->generator);
            }
        }

        return null;
    }

    protected function filterByGroup($asserts, ?string $group = null){
        if(is_null($group)){
            return $asserts;
        }

        $result = array_filter($asserts, function($a) use ($group){
            /**
             * @var $a Constraint
             */
            return in_array($group, $a->groups);
        });

        return array_values($result);
    }

    protected function getGeneratorFqcn($simpleClassName)
    {
        return sprintf('Er1z\\FakeMock\\Generator\\AssertGenerator\\%s', $simpleClassName);
    }
}


1		<?php
2
3		namespace Er1z\FakeMock\Generator;
4
5		use Er1z\FakeMock\FakeMock;
6		use Er1z\FakeMock\Metadata\FieldMetadata;
7		use Symfony\Component\Validator\Constraint;
		0 ignored issues – show Bug introduced 2018-11-14 10:12 UTC by Report Bug Copy Issue Report The type `Symfony\Component\Validator\Constraint` was not found. Maybe you did not declare it correctly or list all dependencies? The issue could also be caused by a filter entry in the build configuration. If the path has been excluded in your configuration, e.g. `excluded_paths: ["lib/"]`, you can move it to the dependency path list as follows: filter: dependency_paths: ["lib/"] For further information see https://scrutinizer-ci.com/docs/tools/php/php-scrutinizer/#list-dependency-paths Loading history...
8
9		/**
10		* @todo: add interface with FakerableInterface in order to inject main Faker instance or sth
11		* Class AssertGenerator
12		*/
13		class AssertGenerator extends AttachableGeneratorAbstract
14		{
15	37	public function generateForProperty(FieldMetadata $field, FakeMock $fakemock, ?string $group = null)
16		{
17	37	if (!$field->configuration->useAsserts) {
18	13	return null;
19		}
20
21	24	$allAsserts = $field->annotations->findAllBy(Constraint::class);
22	24	$asserts = $this->filterByGroup($allAsserts, $group);
23
24	24	if ($asserts) {
		0 ignored issues – show Bug Best Practice introduced 2018-11-19 12:45 UTC by Report Bug Copy Issue Report The expression `$asserts` of type `array` is implicitly converted to a boolean; are you sure this is intended? If so, consider using `! empty($expr)` instead to make it clear that you intend to check for an array without elements. This check marks implicit conversions of arrays to boolean values in a comparison. While in PHP an empty array is considered to be equal (but not identical) to false, this is not always apparent. Consider making the comparison explicit by using `empty(..)` or `! empty(...)` instead. Loading history...
25	9	$assert = $asserts[0];
26
27		// https://coderwall.com/p/cpxxxw/php-get-class-name-without-namespace - reflection is the fastest?
28	9	$baseClass = new \ReflectionClass($assert);
29
30	9	if ($generator = $this->getGenerator($baseClass->getShortName())) {
31	6	return $generator->generateForProperty($field, $assert, $this->generator);
32		}
33		}
34
35	18	return null;
36		}
37
38	24	protected function filterByGroup($asserts, ?string $group = null){
39	24	if(is_null($group)){
40	24	return $asserts;
41		}
42
43		$result = array_filter($asserts, function($a) use ($group){
44		/**
45		* @var $a Constraint
46		*/
47		return in_array($group, $a->groups);
48		});
49
50		return array_values($result);
51		}
52
53	12	protected function getGeneratorFqcn($simpleClassName)
54		{
55	12	return sprintf('Er1z\\FakeMock\\Generator\\AssertGenerator\\%s', $simpleClassName);
56		}
57		}
58

er1z / fakemock

Push — master ( dca783...294a52 )

AssertGenerator::generateForProperty() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like