Equip\ValueObject\PhoneNumber

Complexity

Total Complexity

10

Size/Duplication

Total Lines	53
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	1

Test Coverage

Coverage

100%

Importance

Changes	1
Bugs	0	Features	1

5 Methods

Rating	Name	Duplication	Size	Complexity
B	__construct()	0	21	5
A	value()	0	8	2
A	util()	0	4	1
A	preferredRegion()	0	4	1
A	preferredFormat()	0	4	1

<?php

namespace Equip\ValueObject;

use InvalidArgumentException;
use libphonenumber\PhoneNumberFormat;
use libphonenumber\PhoneNumberUtil;

class PhoneNumber
{
    /**
     * @var libphonenumber\PhoneNumber|null
     */
    private $number;

    public function __construct($number, $is_required = true)
    {
        static $empty_values = [null, ''];

        if (!$is_required && in_array($number, $empty_values, true)) {
            $number = null;
        } elseif (!is_string($number)) {
            throw new InvalidArgumentException('Value must be a phone number');
        } else {
            $number = $this->util()->parse($number, $this->preferredRegion());

            // Parsing does not ensure a valid phone number format, it only ensures
            // a general level of consistency in the numbers and sets a region.

            if (!$this->util()->isValidNumber($number)) {
                throw new InvalidArgumentException('Value must be a valid phone number for the region');
            }
        }

        $this->number = $number;

It seems like $number can also be of type object<libphonenumber\PhoneNumber>. However, the property $number is declared as type object<Equip\ValueObject\libphonenumber\PhoneNumber>|null. Maybe add an additional type check?

    }

    public function value()
    {
        if ($this->number) {
            return $this->util()->format($this->number, $this->preferredFormat());
        }

        return null;
    }

    protected function util()
    {
        return PhoneNumberUtil::getInstance();
    }

    protected function preferredRegion()
    {
        return PhoneNumberUtil::UNKNOWN_REGION;
    }

    protected function preferredFormat()
    {
        return PhoneNumberFormat::E164;
    }
}