Equip\Structure\OrderedList

Complexity

Total Complexity

10

Size/Duplication

Total Lines	68
Duplicated Lines	41.18 %

Coupling/Cohesion

Components	1
Dependencies	2

Test Coverage

Coverage

100%

6 Methods

Rating	Name	Duplication	Size	Complexity
A	hasValue()	0	4	1
A	withValues()	14	14	2
A	withValue()	0	10	1
A	withoutValue()	14	14	2
A	sortValues()	0	4	1
A	assertValid()	0	12	3

<?php

namespace Equip\Structure;

use Equip\Structure\Traits\CanStructure;

class OrderedList implements ListInterface
{
    use CanStructure;

    public function hasValue($value)
    {
        return in_array($value, $this->values, true);
    }

    public function withValues(array $values)

This method seems to be duplicated in your project.

    {
        if ($this->values === $values) {
            return $this;
        }

        $this->assertValid($values);

        $copy = clone $this;
        $copy->values = $values;
        $copy->sortValues();

        return $copy;
    }

    public function withValue($value)
    {
        $this->assertValid([$value]);

        $copy = clone $this;
        $copy->values[] = $value;
        $copy->sortValues();

        return $copy;
    }

    public function withoutValue($value)

This method seems to be duplicated in your project.

    {
        $key = array_search($value, $this->values, true);

        if ($key === false) {
            return $this;
        }

        $copy = clone $this;
        unset($copy->values[$key]);
        $copy->sortValues();

        return $copy;
    }

    protected function sortValues()
    {
        sort($this->values, SORT_REGULAR);
    }

    protected function assertValid(array $values)
    {
        if (empty($values)) {
            return;
        }

        if ($values !== array_values($values)) {
            throw ValidationException::invalid(
                'List structures cannot have distinct keys'
            );
        }
    }
}