Equip\Queue\Driver\RedisDriver

Complexity

Total Complexity

4

Size/Duplication

Total Lines	33
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	0

Importance

Changes	2
Bugs	1	Features	1

3 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	4	1
A	push()	0	4	1
A	pop()	0	6	2

<?php

namespace Equip\Queue\Driver;

use Redis;

class RedisDriver implements DriverInterface
{
    /**
     * @var Redis
     */
    private $redis;

    /**
     * @param Redis $redis
     */
    public function __construct(Redis $redis)
    {
        $this->redis = $redis;
    }

    /**
     * @inheritdoc
     */
    public function push($queue, $message)
    {
        return (bool) $this->redis->rPush($queue, $message);
    }

    /**
     * @inheritdoc
     */
    public function pop($queue)
    {
        list($_, $message) = $this->redis->blPop([$queue], 5) ?: null;

The assignment to $_ is unused. Consider omitting it like so list($first,,$third).

        return $message;
    }
}