Worker::tick() - Code Metrics - Inspection of "Update to support Tactician" - equip/queue - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#10)

by Adam

created 2016-08-31 18:18 UTC

Worker::tick() A

↳ Parent: Worker

Complexity

Conditions	3
Paths	5

Size

Total Lines	18
Code Lines	12

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	11
CRAP Score	3

Importance

Changes	7
Bugs	1	Features	4

Metric	Value
c	7
b	1
f	4
dl	0
loc	18
ccs	11
cts	11
cp	1
rs	9.4285
cc	3
eloc	12
nc	5
nop	1
crap	3

<?php

namespace Equip\Queue;

use Equip\Queue\Driver\DriverInterface;
use Exception;
use League\Tactician\CommandBus;

class Worker
{
    /**
     * @var DriverInterface
     */
    private $driver;

    /**
     * @var Event
     */
    private $event;

    /**
     * @var CommandBus
     */
    private $command_bus;

    public function __construct(
        DriverInterface $driver,
        Event $event,
        CommandBus $command_bus
    ) {
        $this->driver = $driver;
        $this->event = $event;
        $this->command_bus = $command_bus;
    }

    /**
     * Consumes messages off of the queue
     *
     * @codeCoverageIgnore
     *
     * @param string $queue
     */
    public function consume($queue)
    {
        while ($this->tick($queue)) { /* NOOP */ }
    }

    /**
     * Handles fetching messages from the queue
     *
     * @param string $queue
     *
     * @return bool
     */
    protected function tick($queue)
    {
        $message = $this->driver->dequeue($queue);
        if (empty($message)) {
            return true;
        }

        $command = unserialize($message);
        try {
            $this->event->acknowledge($command);
            $this->command_bus->handle($command);
            $this->event->finish($command);
        } catch (Exception $exception) {
            $this->event->reject($command, $exception);
        }

        return true;
    }
}


1		<?php
2
3		namespace Equip\Queue;
4
5		use Equip\Queue\Driver\DriverInterface;
6		use Exception;
7		use League\Tactician\CommandBus;
8
9		class Worker
10		{
11		/**
12		* @var DriverInterface
13		*/
14		private $driver;
15
16		/**
17		* @var Event
18		*/
19		private $event;
20
21		/**
22		* @var CommandBus
23		*/
24		private $command_bus;
25
26	3	public function __construct(
27		DriverInterface $driver,
28		Event $event,
29		CommandBus $command_bus
30		) {
31	3	$this->driver = $driver;
32	3	$this->event = $event;
33	3	$this->command_bus = $command_bus;
34	3	}
35
36		/**
37		* Consumes messages off of the queue
38		*
39		* @codeCoverageIgnore
40		*
41		* @param string $queue
42		*/
43		public function consume($queue)
44		{
45		while ($this->tick($queue)) { /* NOOP */ }
46		}
47
48		/**
49		* Handles fetching messages from the queue
50		*
51		* @param string $queue
52		*
53		* @return bool
54		*/
55	3	protected function tick($queue)
56		{
57	3	$message = $this->driver->dequeue($queue);
58	3	if (empty($message)) {
59	1	return true;
60		}
61
62	2	$command = unserialize($message);
63		try {
64	2	$this->event->acknowledge($command);
65	2	$this->command_bus->handle($command);
66	1	$this->event->finish($command);
67	2	} catch (Exception $exception) {
68	1	$this->event->reject($command, $exception);
69		}
70
71	2	return true;
72		}
73		}
74

equip / queue

Pull Request — master (#10)

Worker::tick() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like