QueueMiddleware::getQueue() - Code Metrics - Inspection of "Update to support Tactician" - equip/queue - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#10)

by Adam

created 2016-08-31 18:18 UTC

QueueMiddleware::getQueue() A

↳ Parent: QueueMiddleware

Complexity

Conditions	3
Paths	3

Size

Total Lines	12
Code Lines	6

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	8
CRAP Score	3

Importance

Changes	2
Bugs	0	Features	1

Metric	Value
c	2
b	0
f	1
dl	0
loc	12
ccs	8
cts	8
cp	1
rs	9.4285
cc	3
eloc	6
nc	3
nop	1
crap	3

<?php

namespace Equip\Queue;

use Exception;
use League\Tactician\Middleware;

class QueueMiddleware implements Middleware
{
    /**
     * @var Queue
     */
    private $queue;

    /**
     * @var array
     */
    private $queue_map;

    /**
     * @param Queue $queue
     * @param array $queue_map
     */
    public function __construct(Queue $queue, array $queue_map = [])
    {
        $this->queue = $queue;
        $this->queue_map = $queue_map;
    }

    /**
     * @inheritdoc
     */
    public function execute($command, callable $next)
    {
        if ($command instanceof QueueableCommand) {
            $queue = $this->getQueue(get_class($command));

            return $this->queue->add(
                $queue,
                // Wraps the command so it isn't requeued
                new QueuedCommand($command)
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
            );
        }

        if ($command instanceof QueuedCommand) {
            $command = $command->command();
        }

        return $next($command);
    }

    /**
     * Gets the specific queue for the command
     *
     * @param string $command_name
     *
     * @return string

     *
     * @throws \Exception If the command isn't assigned to a pipe
     */
    private function getQueue($command_name)
    {
        foreach ($this->queue_map as $queue => $commands) {
            if (in_array($command_name, $commands)) {
                return $queue;
            }
        }

        throw new Exception(
            sprintf('No queue has been set for the `%s` command', $command_name)
        );
    }
}


1		<?php
2
3		namespace Equip\Queue;
4
5		use Exception;
6		use League\Tactician\Middleware;
7
8		class QueueMiddleware implements Middleware
9		{
10		/**
11		* @var Queue
12		*/
13		private $queue;
14
15		/**
16		* @var array
17		*/
18		private $queue_map;
19
20		/**
21		* @param Queue $queue
22		* @param array $queue_map
23		*/
24	5	public function __construct(Queue $queue, array $queue_map = [])
25		{
26	5	$this->queue = $queue;
27	5	$this->queue_map = $queue_map;
28	5	}
29
30		/**
31		* @inheritdoc
32		*/
33	3	public function execute($command, callable $next)
34		{
35	3	if ($command instanceof QueueableCommand) {
36	1	$queue = $this->getQueue(get_class($command));
37
38	1	return $this->queue->add(
39	1	$queue,
40		// Wraps the command so it isn't requeued
41	1	new QueuedCommand($command)
		0 ignored issues – show Documentation introduced 2016-08-31 17:58 UTC by Report Bug Copy Issue Report `new \Equip\Queue\QueuedCommand($command)` is of type `object<Equip\Queue\QueuedCommand>`, but the function expects a `string`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
42	1	);
43		}
44
45	2	if ($command instanceof QueuedCommand) {
46	1	$command = $command->command();
47	1	}
48
49	2	return $next($command);
50		}
51
52		/**
53		* Gets the specific queue for the command
54		*
55		* @param string $command_name
56		*
57		* @return string
		0 ignored issues – show Documentation introduced 2016-08-31 17:58 UTC by Report Bug Copy Issue Report Should the return type not be `integer\|string`? This check compares the return type specified in the `@return` annotation of a function or method doc comment with the types returned by the function and raises an issue if they mismatch. Loading history...
58		*
59		* @throws \Exception If the command isn't assigned to a pipe
60		*/
61	3	private function getQueue($command_name)
62		{
63	3	foreach ($this->queue_map as $queue => $commands) {
64	3	if (in_array($command_name, $commands)) {
65	2	return $queue;
66		}
67	2	}
68
69	1	throw new Exception(
70	1	sprintf('No queue has been set for the `%s` command', $command_name)
71	1	);
72		}
73		}
74

equip / queue

Pull Request — master (#10)

QueueMiddleware::getQueue() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like