Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.
Common duplication problems, and corresponding solutions are:
1 | <?php |
||
8 | class Event |
||
9 | { |
||
10 | const QUEUE_ACKNOWLEDGE = 'queue.acknowledge'; |
||
11 | const QUEUE_REJECT = 'queue.reject'; |
||
12 | |||
13 | /** |
||
14 | * @var EmitterInterface |
||
15 | */ |
||
16 | private $emitter; |
||
17 | |||
18 | /** |
||
19 | * @param EmitterInterface $emitter |
||
20 | */ |
||
21 | public function __construct(EmitterInterface $emitter) |
||
25 | |||
26 | /** |
||
27 | * Emits message acknowledgement events |
||
28 | * |
||
29 | * @param Message $message |
||
30 | */ |
||
31 | View Code Duplication | public function acknowledge(Message $message) |
|
40 | |||
41 | /** |
||
42 | * Emits message rejection events |
||
43 | * |
||
44 | * @param Message $message |
||
45 | * @param Exception $exception |
||
46 | */ |
||
47 | View Code Duplication | public function reject(Message $message, Exception $exception) |
|
56 | } |
||
57 |
Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation.
You can also find more detailed suggestions in the “Code” section of your repository.